Re: [Samba] smbd crashes

2012-02-09 Thread Peter Trifonov
Hi all,

I managed to fix the problem.  The solution was to apply this patch
http://www.opensource.apple.com/source/samba/samba-235/patches/ignore-tdb-sp
inlock-flag
to  libtdb sources. Maybe this helps someone facing the same problem...

With best regards,
P. Trifonov


 -Original Message-
 From: samba-boun...@lists.samba.org [mailto:samba-
 boun...@lists.samba.org] On Behalf Of Peter Trifonov
 Sent: Thursday, February 09, 2012 12:57 AM
 To: samba@lists.samba.org
 Subject: Re: [Samba] smbd crashes
 
 Hello folks,
 
 
  After upgrading from samba 3.4.9 to samba 3.6.1 on a FreeBSD 8.1 x86
  system smbd stopped working.
  It starts successfully, but crashes as soon as someone tries to
  connect to
 a
  share.
  Log file contains a lot of entries like the following:
 
  [2012/02/06 11:05:13,  1] lib/util_tdb.c:521(tdb_wrap_log)
tdb(unnamed): tdb_open_ex: spinlocks no longer supported
  [2012/02/06 11:05:13,  0] lib/messages_local.c:112(messaging_tdb_init)
ERROR: Failed to initialise messages database: Unknown error: 0
 
 The problem still remains  after upgrading to samba 3.6.3.
 It appears that spinlocks are somehow automatically enabled for any newly
 created database. Is there any way to avoid this behavior?
 
 
 
 
 
 With best regards,
 P. Trifonov
 --
 To unsubscribe from this list go to the following URL and read the
 instructions:  https://lists.samba.org/mailman/options/samba
 

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Samba4 user mapping into filesystem

2012-02-09 Thread Brantley Hobbs
On Wed, Feb 8, 2012 at 5:31 PM, William Brown
william.e.br...@adelaide.edu.au wrote:
 You likely don't have ACL's enabled on the filesystem that samba is sharing.
 You can check with

 sudo tune2fs -l /dev/vg_lillie/lv_root | grep option

 replacing your disk into that command. You should see something like

 Default mount options:    user_xattr acl

 If not, you should enable the filesystem ACL using tune2fs, then reboot your
 machine.

 tune2fs -o acl /dev/sda1


 And this is why you don't use a mailing list while half asleep. I misread
 yoru problem. Probably still good to check that.

 Anyway, do you have the machine joined to its own domain? Are you running
 winbind to resolve the usernames etc?

 The issue you might be seeing is that while they have an owner that isn't
 there, if you use getfacl on the file it should have the ACL's to allow the
 group / user in question to read/write it. The non existent user could be
 due to winbind trying to map the user Id to an account, but you don't have
 the client side of the resolver setup, so it shows non existant. using ls,
 check the numerical ID on the files.


Odd.  I certainly have the mount options in /etc/fstab, and using the
little test on the HOWTO
(https://wiki.samba.org/index.php/Samba4/HOWTO#NOTE_about_filesystem_support),
it's supposed to be working.  However, listing the filesystem options
with tune2fs shows none for Default mount options.  ext_attr
does show as a feature in Filesystem features however.

To your other questions:

- I assume that provisioning the installation implicitly joined it to
the domain.  This is the only domain controller on a very small
network.  If provisioning didn't join it automatically, then no, it's
not joined to its own domain.

- Winbind isn't installed.  I followed the HOWTO, but didn't see a
step about installing winbind.

Like I say, everything else appears to be working fine.  I'm just
trying to wrap my head around the relationship between Samba's
internal users and the underlying filesystem permissions.

Thanks for you help!
Brantley
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] RFC2307 Samba4 [Was: Linux users and Samba 4]

2012-02-09 Thread steve

On 13/01/12 16:59, Adam Tauno Williams wrote:

On Fri, 2012-01-13 at 10:32 -0500, Adam Tauno Williams wrote:

On Fri, 2012-01-13 at 02:51 +0100, steve wrote:

On 12/01/12 23:02, Adam Tauno Williams wrote:

Quoting stevest...@steve-ss.com:

Samba4's winbind does not support RFC2307,  so doing this is pretty
rough.  I think you need to either use CIFS + winbind everywhere or
somehow maintain an external idmap.
Yea, it is horrible.  We are staring down the barrell of the same
gun.

As Jeremy said, they are discussing what needs to be done before
releasing Samba 4.0.0 and how to reconcile Samba 3's winbind and Samba
4's winbind etc., so if something that is critical for you does not
currently work, you should file a bug report.

Yep. I realise the 'alphaness' of Samba 4 but I think I am not alone
with my issue. I think I should be easy to fix now before it goes beta.
https://bugzilla.samba.org/show_bug.cgi?id=8635

Holy awesome; it got better.  I just tested an upgrade of our
production domain and it appears that Samba4 took [and kept] the UID
number from the existing account.
Production
-
[root@littleboy ~]# id adam
uid=437(adam) gid=230(cis) groups=230(cis)
Test Server

barbel:~ # wbinfo -i adam
BACKBONE\adam:*:437:100:Adam Williams:/home/BACKBONE/adam:/bin/false
Home directory is a bit wierd, and the gidNumber didn't stick.  But at
least I have the uidNumber.
4.0.0alpha18-GIT-103c1cb [openSUSE 12.1 x86_64] transitioned via
samba-tool domain samba3upgrade from Samba S3w/LDAPSAM.

Nice find you have there. Meanwhile I've got it working. Very rough. But
working for 10 hour Kerberos sessions at a time;)
http://linuxcostablanca.blogspot.com/2011/12/samba-4-linux-integration-first-i-want.html
Steve

What I'm puzzled by [and maybe this is a deficiency in Samba4 still] is
that while the LDAP modify works the wbinfo output doesn't change.

dn: CN=adam,CN=Users,DC=micore,DC=us
changetype: modify
add: objectclass
objectclass: posixaccount
-
add: objectclass
objectclass: shadowaccount
-
add: uidnumber
uidnumber: 437
-
add: gidnumber
gidnumber: 230
-
add:unixhomedirectory
unixhomedirectory: /home/adam
-
add: loginshell
loginshell: /bin/ksh

barbel:~ # wbinfo -i adam
BACKBONE\adam:*:437:100:Adam Williams:/home/BACKBONE/adam:/bin/false

I am able to get my home-directory path back to the previous value
[ based on the useful information from this link -
https://lists.samba.org/archive/samba/2010-May/156051.html  ]

Setting: template homedir = /home/%ACCOUNTNAME%

The old %U type variables aren't supported.  But the above results in
the same thing -

barbel:/opt/s4 # wbinfo -i adam
BACKBONE\adam:*:437:100:Adam Williams:/home/adam:/bin/false

I found a list of Windows environment variables here
http://vlaurie.com/computers2/Articles/environment.htm   According the
old 2010 thread these are now expanded on the client side in Microsoft
fashion rather than expanded on the serve [in the config backend??].


You have to rfc2307-ify the group too. e.g.:
samba-tool group add suseusers
samba-tool group addmembers suseusers steve6

wbinfo --group-info=suseusers
suseusers:*:316:

kinit Administrator

ldapmodify -h 192.168.1.3 -D cn=Administrator,cn=Users,dc=hh3,dc=site -Y 
GSSAPI

dn: cn=suseusers,sn=Users,dc=hh3,dc=site
changetype: modify
add: objectClass
objectClass: posixAccount
-
add: objectClass
objectClass: posixGroup
hit enter + ctrl C. . .bug in os 12.1??
Then,
Use nslcd to map uid:gid from LDAP:
/etc/nsswitch.conf
passwd:files ldap
group: files ldap

and then:
hh3:/home/steve # getent passwd steve6
steve6:*:315:316:steve6:/home/CACTUS/steve6:/bin/bash
hh3:/home/steve # getent group suseusers
suseusers:*:316:
hh3:/home/steve # wbinfo -i steve6
CACTUS\steve6:*:315:316::/home/CACTUS/steve6:/bin/false

Linux= nfs4/idmapd. w7= out of the box.

Server:
hh3:/tmp # id steve6
uid=315(steve6) gid=316(suseusers) groups=316(suseusers)

Client:
steve6@hh6:~ id
uid=315(steve6) gid=316(suseusers) groups=316(suseusers)
steve6@hh6:~ echo Hola  file
steve6@hh6:~ ls -l file
-rw-r--r-- 1 steve6 suseusers 5 Feb  9 13:52 file

Maybe I should add this to the bug report.
Cheers,
Steve

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Samba4 user mapping into filesystem

2012-02-09 Thread Aaron E.

This may help you out..

https://wiki.samba.org/index.php/Samba4/Winbind

On 02/09/2012 07:17 AM, Brantley Hobbs wrote:

On Wed, Feb 8, 2012 at 5:31 PM, William Brown
william.e.br...@adelaide.edu.au  wrote:

You likely don't have ACL's enabled on the filesystem that samba is sharing.
You can check with

sudo tune2fs -l /dev/vg_lillie/lv_root | grep option

replacing your disk into that command. You should see something like

Default mount options:user_xattr acl

If not, you should enable the filesystem ACL using tune2fs, then reboot your
machine.

tune2fs -o acl /dev/sda1


And this is why you don't use a mailing list while half asleep. I misread
yoru problem. Probably still good to check that.

Anyway, do you have the machine joined to its own domain? Are you running
winbind to resolve the usernames etc?

The issue you might be seeing is that while they have an owner that isn't
there, if you use getfacl on the file it should have the ACL's to allow the
group / user in question to read/write it. The non existent user could be
due to winbind trying to map the user Id to an account, but you don't have
the client side of the resolver setup, so it shows non existant. using ls,
check the numerical ID on the files.



Odd.  I certainly have the mount options in /etc/fstab, and using the
little test on the HOWTO
(https://wiki.samba.org/index.php/Samba4/HOWTO#NOTE_about_filesystem_support),
it's supposed to be working.  However, listing the filesystem options
with tune2fs shows none for Default mount options.  ext_attr
does show as a feature in Filesystem features however.

To your other questions:

- I assume that provisioning the installation implicitly joined it to
the domain.  This is the only domain controller on a very small
network.  If provisioning didn't join it automatically, then no, it's
not joined to its own domain.

- Winbind isn't installed.  I followed the HOWTO, but didn't see a
step about installing winbind.

Like I say, everything else appears to be working fine.  I'm just
trying to wrap my head around the relationship between Samba's
internal users and the underlying filesystem permissions.

Thanks for you help!
Brantley


--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[Samba] samba-tool set default group

2012-02-09 Thread steve

Hi
How do I set the default group for a user?

e.g.
samba-tool group add opensuse
samba-tool group addusers opensuse steve

But steve's default group is still Users.

I'm looking for soething like this:
'samba-tool group setdefaultgroup steve opensuse'

But here isn't that command. I have to do it in Windows.

Is there a command I'm missing?
Cheers,
Steve
--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Samba4 user mapping into filesystem

2012-02-09 Thread steve




- Winbind isn't installed.  I followed the HOWTO, but didn't see a
step about installing winbind.
If you installed S4 you already have it. But s4 winbind doesn't seem to 
map uid:gid correctly at te mo:( We used nss-ldapd with nfs4 to do the 
mapping for the Linux side. See the:


Re: [Samba] RFC2307  Samba4 [Was: Linux users and Samba 4]

thread. Just posted an update to it so it's prob. in your inbox now.

HTH,
Steve

--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Screenshot

2012-02-09 Thread Gaiseric Vandal

Can't see the attached screenshot.   I don't think the lists support it.

Did you set up group mapping (net group map list should show this.)  I 
have samba 3.5.x with ldap backend.   Make sure the windows domain 
admins group is mapping to a unix group with RID 512.



On 02/09/2012 02:50 AM, Simon Faulkner wrote:
Any chance anyone can take a look at this screen shot of the 
Administrator group on a Domain PC


I can't figure out why it is showing the SID rather than the name of 
the group?


TIA

Simon



--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Group Mappings

2012-02-09 Thread Gaiseric Vandal
Do you have any XP clients?  Do they have the same issue?  What backend 
are you using?




On 02/08/2012 03:03 PM, Simon Faulkner wrote:

Samba 3.6.2

My Domain Admins, including root, don't get admin permissions on local 
PCs.


My Windows 7 clients can join the domain but when I look in the 
Administrators group it shows the sid for the Domain Admins group (RID 
= 512) and the icon has a question mark


net groupmap list seems OK

Any ideas where to look next?

TIA

Simon



--
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[Samba] Unable to create principle and join domain with solaris / samba 3.5.8

2012-02-09 Thread Paul Smith
Has anyone had any success using net ads join to create a new service
principal and join Active Directory using samba 3.5.8. This works fine
in 3.0.35 but I'm not able to get a working create/join with 3.5.8

In samba 3.0.35 (on a host which is already allowing kerberised
loginsvia AD), the following works:

net ads join createupn='CIFS/host.domain.com' \
createcomputer='path/to/principal/' -U myadlogin

After upgrading and restarting, samba works fine but deleting the AD
service principal and samba/private files to reconfigure, the net join
fails:

# net ads join createupn='CIFS/smbtest.uk.domain.com'
createcomputer='MITKerberos/Services' -U myadlogin
Enter myadlogin's password:
Failed to join domain: failed to precreate account in ou
MITKerberos/Services: Invalid DN syntax

The OU exists in AD (and works for earlier samba versions). Looking at
net ads join output with -d 99, it looks like the net command isn't
passing the netbios name through?

[2012/02/09 15:45:29.014700, 1] libnet/libnet_join.c:1978()
libnet_Join:
libnet_JoinCtx: struct libnet_JoinCtx
out: struct libnet_JoinCtx
account_name : NULL
netbios_domain_name : 'AAA'
dns_domain_name : 'aaa.ads.domain.com'
forest_name : 'ADS.DOMAIN.COM'
dn : NULL
domain_sid : *
domain_sid : S-1-5-21-1606980848-1965331169-1417001333
modified_config : 0x00 (0)
error_string : 'failed to precreate account in ou
MITKerberos/Services: Invalid DN syntax'
domain_is_ad : 0x01 (1)
result : WERR_DEFAULT_JOIN_REQUIRED
[2012/02/09 15:45:29.014909, 10] intl/lang_tdb.c:138()
lang_tdb_init: /usr/lib/samba/en_GB.UTF-8.msg: No such file or directory
Failed to join domain: failed to precreate account in ou
MITKerberos/Services: Invalid DN syntax
[2012/02/09 15:45:29.015245, 2] utils/net.c:916()
return code = -1

The smb.conf for this is as follows

[global]
server string = SMBTEST Samba Server
security = ADS
realm = AAA.ADS.DOMAIN.COM
netbios name = SMBTEST
workgroup = AAA
interfaces = SMBTEST.uk.domain.com
bind interfaces only = Yes
log level = 3
log file = /var/samba/log/log.%m
max log size = 128
socket options = TCP_NODELAY IPTOS_LOWDELAY SO_RCVBUF=65536
SO_SNDBUF=65536 SO_KEEPALIVE
nis homedir = No
hide dot files = Yes
wide links = No
local master = No
domain master = No
preferred master = No
os level = 0

[homes]
comment = Home Directories
browseable = yes
public = no
writable = yes

Anyone have any pointers on how to create principles and join AD using
3.5.8 or any ideas of relevant changes between 3.0.35 and 3.5.8 that
might explain this?

Regards

Paul
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[Samba] Include directory in smb.conf

2012-02-09 Thread Santiago Diez
Hi there,

I'm wondering if there any patch or recent developement that would allow to
include a directory rather than a file in smb.conf

Something like

includedir = /etc/samba/shares.d/

instead of

include = /etc/samba/shares.conf

Thanks for your help

Santiago
-
*Santiago DIEZ*
*Director*
*+33 6 37 90 81 98*
-

http://www.google.com/url?q=http%3A%2F%2Fsantiago.news.free.fr%2Flogo.pngsa=Dsntz=1usg=AFrqEzfmW2Io3OI5IqEGiVeDRebZgD4TaQ
-
*Quark Systems  CAOBA*
*23 rue du Buisson Saint-Louis, 75010 Paris
*-
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Samba 4 and new Kerberos version

2012-02-09 Thread Gémes Géza
2012-02-08 09:29 keltezéssel, steve írta:
 On 07/02/12 20:52, Gémes Géza wrote:
 2012-02-07 16:07 keltezéssel, steve írta:
 On 07/02/12 12:01, Andrew Bartlett wrote:
 On Tue, 2012-02-07 at 10:24 +0100, steve wrote:
 I just got this from the mit list:

 quote
 DES transition
 ==

 The krb5-1.8 release disables single-DES cryptosystems by
 default.  As
 a result, you may need to add the libdefaults setting
 allow_weak_crypto = true to communicate with existing Kerberos
 infrastructures if they do not support stronger ciphers.

 /quote

 Does/will this apply to us?
 Heimdal did this a long time ago, so yes.  If you wish to use DES, you
 have to set that in your krb5.conf.

 Andrew Bartlett

 Hi
 I'm using S4 out of the box on openSUSE 12.1. All the Kerberos
 transactions seem to choose arcfour.
 Does the des stuff apply to me?
 Thanks,
 Steve

 Hi,
 You need to enable weak crypto if you want to use kerberos with apps
 which depends on des (e.g nfs, openafs).
 Regards
 Geza
 Mmm. That's what I thought. I added that line to krb5.conf before
 using nfs. I commented it and it still works. The s4 nfs transactions
 seem to choose arcfour, not des. I can't find this documented anywhere
 but noises on the nfs kernel list suggest that the weak crypto is not
 now necessary. Will leave the line commented until nfs explodes at
 some stage.
 Cheers,
 Steve

Could have been fixed I've used nfs with gss/krb a few years ago when it
ws working with des-cbc-crc only, have migrated to openafs since then.

Cheers

Geza
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] samba-tool set default group

2012-02-09 Thread Gémes Géza
2012-02-09 14:21 keltezéssel, steve írta:
 Hi
 How do I set the default group for a user?

 e.g.
 samba-tool group add opensuse
 samba-tool group addusers opensuse steve

 But steve's default group is still Users.

 I'm looking for soething like this:
 'samba-tool group setdefaultgroup steve opensuse'

 But here isn't that command. I have to do it in Windows.

 Is there a command I'm missing?
 Cheers,
 Steve
IMHO currently your best bet is ldbmodify.

Regards

Geza
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


Re: [Samba] Include directory in smb.conf

2012-02-09 Thread Nico Kadel-Garcia
On Thu, Feb 9, 2012 at 1:04 PM, Santiago Diez santiago.d...@caoba.fr wrote:
 Hi there,

 I'm wondering if there any patch or recent developement that would allow to
 include a directory rather than a file in smb.conf

 Something like

 includedir = /etc/samba/shares.d/

 instead of

 include = /etc/samba/shares.conf

That seems potentially destabilizing, and makes for considerably more
complex parsing of a target directory. In particular, order
sensitivity of included files is a pain in the ass and can be
enormously destabilizing.  And me, I'd be concerned that some idiot
would point to an auto-mounted or NFS-mounted directory and lead to
all *sorts* of timeout craziness.

This kind of approach is, of course, used for other tools like Nagios
and NRPE and httpd. But it can get very tricky to handle. If I had to
have a configuration for Samba built up from dynamically arranged
smaller components, I'd set up /etc/samba/Makefile, drop components in
/etc/samba/*.conf, and use it to build and source control
/etc/samba/smb.conf.

Do you have some particular need for this? Or did it just seem like a good idea?
-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[Samba] Samba with dns error Failed to connect to our DC

2012-02-09 Thread Gilmour, Scott
Hi,
I just installed Ubuntu Server and Ubuntu classic desktop.  Now I am trying to 
join active directory and I get this DNS error and failed to connect to the DC.
How to fix this error plus I noticed on my windows 2008 Server that my Ubuntu 
server showed up as a Computer and not a domain controller.
Is this correct?  I would think it would show up as a DC just as it does when I 
joined my 2003 Server to my 2008 Server.
Thanks
Scott

root@FreeRadius:/home/sqauser# net ads join -U Administrator
Enter Administrator's password:
Using short domain name -- SQA
Joined 'FREERADIUS' to realm 'SQA.net'
[2012/02/09 16:48:09.744544,  0] utils/net_ads.c:1147(net_update_dns_internal)
  net_update_dns_internal: Failed to connect to our DC!
DNS update failed!
root@FreeRadius:/home/sqauser# wbinfo -u
FREERADIUS\nobody
FREERADIUS\sqauser
SQA\administrator
SQA\guest
SQA\krbtgt
SQA\00-01-88-00-00-00
SQA\00-01-88-00-00-01
SQA\00-01-88-00-00-02

-- 
To unsubscribe from this list go to the following URL and read the
instructions:  https://lists.samba.org/mailman/options/samba


[SCM] Samba Shared Repository - branch master updated

2012-02-09 Thread Stefan Metzmacher
The branch, master has been updated
   via  de53fcd tevent: change the version to 0.9.15
   via  b5436fd tevent: Fix deleting signal events from within themselves
  from  4328f3c smbwrapper: Remove smbwrapper

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit de53fcd8de5b751efb97adb43663a73059dc8ed3
Author: Stefan Metzmacher me...@samba.org
Date:   Thu Feb 9 10:11:19 2012 +0100

tevent: change the version to 0.9.15

metze

Autobuild-User: Stefan Metzmacher me...@samba.org
Autobuild-Date: Thu Feb  9 12:24:19 CET 2012 on sn-devel-104

commit b5436fde5bbe5b849212258088add492ee8fc4ce
Author: Volker Lendecke v...@samba.org
Date:   Sat Jan 28 22:18:00 2012 +0100

tevent: Fix deleting signal events from within themselves

Signed-off-by: Stefan Metzmacher me...@samba.org

---

Summary of changes:
 .../ABI/{tevent-0.9.14.sigs = tevent-0.9.15.sigs} |0
 lib/tevent/tevent_signal.c |   35 ++-
 lib/tevent/wscript |2 +-
 3 files changed, 34 insertions(+), 3 deletions(-)
 copy lib/tevent/ABI/{tevent-0.9.14.sigs = tevent-0.9.15.sigs} (100%)


Changeset truncated at 500 lines:

diff --git a/lib/tevent/ABI/tevent-0.9.14.sigs 
b/lib/tevent/ABI/tevent-0.9.15.sigs
similarity index 100%
copy from lib/tevent/ABI/tevent-0.9.14.sigs
copy to lib/tevent/ABI/tevent-0.9.15.sigs
diff --git a/lib/tevent/tevent_signal.c b/lib/tevent/tevent_signal.c
index fabe72c..248dd35 100644
--- a/lib/tevent/tevent_signal.c
+++ b/lib/tevent/tevent_signal.c
@@ -307,6 +307,15 @@ struct tevent_signal *tevent_common_add_signal(struct 
tevent_context *ev,
return se;
 }
 
+struct tevent_se_exists {
+   struct tevent_se_exists **myself;
+};
+
+static int tevent_se_exists_destructor(struct tevent_se_exists *s)
+{
+   *s-myself = NULL;
+   return 0;
+}
 
 /*
   check if a signal is pending
@@ -335,6 +344,23 @@ int tevent_common_check_signal(struct tevent_context *ev)
}
for (sl=sig_state-sig_handlers[i];sl;sl=next) {
struct tevent_signal *se = sl-se;
+   struct tevent_se_exists *exists;
+
+   /*
+* We have to be careful to not touch se
+* after it was deleted in its handler. Thus
+* we allocate a child whose destructor will
+* tell by nulling out itself that its parent
+* is gone.
+*/
+   exists = talloc(se, struct tevent_se_exists);
+   if (exists == NULL) {
+   continue;
+   }
+   exists-myself = exists;
+   talloc_set_destructor(
+   exists, tevent_se_exists_destructor);
+
next = sl-next;
 #ifdef SA_SIGINFO
if (se-sa_flags  SA_SIGINFO) {
@@ -352,21 +378,26 @@ int tevent_common_check_signal(struct tevent_context *ev)
se-handler(ev, se, i, 1,

(void*)sig_state-sig_info[i][ofs], 
se-private_data);
+   if (!exists) {
+   break;
+   }
}
 #ifdef SA_RESETHAND
-   if (se-sa_flags  SA_RESETHAND) {
+   if (exists  (se-sa_flags  SA_RESETHAND)) {
talloc_free(se);
}
 #endif
+   talloc_free(exists);
continue;
}
 #endif
se-handler(ev, se, i, count, NULL, se-private_data);
 #ifdef SA_RESETHAND
-   if (se-sa_flags  SA_RESETHAND) {
+   if (exists  (se-sa_flags  SA_RESETHAND)) {
talloc_free(se);
}
 #endif
+   talloc_free(exists);
}
 
 #ifdef SA_SIGINFO
diff --git a/lib/tevent/wscript b/lib/tevent/wscript
index f98253f..b4bcb71 100644
--- a/lib/tevent/wscript
+++ b/lib/tevent/wscript
@@ -1,7 +1,7 @@
 #!/usr/bin/env python
 
 APPNAME = 'tevent'
-VERSION = '0.9.14'
+VERSION = '0.9.15'
 
 blddir = 'bin'
 


-- 
Samba Shared Repository


[SCM] Samba Shared Repository - branch master updated

2012-02-09 Thread Günther Deschner
The branch, master has been updated
   via  2464a7b s3-libsmb: Remove obsolete smb_krb5_locate_kdc.
   via  419e92b s3-net: Don't use an internal krb5 for kdc lookup.
  from  de53fcd tevent: change the version to 0.9.15

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 2464a7b0ddb556bed86a845c9400e26c4d7f584a
Author: Andreas Schneider a...@samba.org
Date:   Wed Nov 30 17:58:30 2011 +0100

s3-libsmb: Remove obsolete smb_krb5_locate_kdc.

Signed-off-by: Günther Deschner g...@samba.org

Autobuild-User: Günther Deschner g...@samba.org
Autobuild-Date: Thu Feb  9 14:58:57 CET 2012 on sn-devel-104

commit 419e92b1499c77ddf3648d6b99ed482a57b3e713
Author: Andreas Schneider a...@samba.org
Date:   Wed Nov 30 17:39:22 2011 +0100

s3-net: Don't use an internal krb5 for kdc lookup.

This replaces the use of the internal krb5_locate_kdc() function with
our own get_kdc_list() function.

Signed-off-by: Günther Deschner g...@samba.org

---

Summary of changes:
 source3/configure.in  |1 -
 source3/include/krb5_protos.h |4 --
 source3/libsmb/clikrb5.c  |   89 -
 source3/utils/net_lookup.c|   42 +++-
 source3/wscript   |2 +-
 5 files changed, 24 insertions(+), 114 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/configure.in b/source3/configure.in
index 298fe1b..1ce1a5b 100644
--- a/source3/configure.in
+++ b/source3/configure.in
@@ -3860,7 +3860,6 @@ if test x$with_ads_support != xno; then
   AC_CHECK_FUNC_EXT(krb5_string_to_key_salt, $KRB5_LIBS)
   AC_CHECK_FUNC_EXT(krb5_auth_con_setkey, $KRB5_LIBS)
   AC_CHECK_FUNC_EXT(krb5_auth_con_setuseruserkey, $KRB5_LIBS)
-  AC_CHECK_FUNC_EXT(krb5_locate_kdc, $KRB5_LIBS)
   AC_CHECK_FUNC_EXT(krb5_get_permitted_enctypes, $KRB5_LIBS)
   AC_CHECK_FUNC_EXT(krb5_get_default_in_tkt_etypes, $KRB5_LIBS)
   AC_CHECK_FUNC_EXT(krb5_free_data_contents, $KRB5_LIBS)
diff --git a/source3/include/krb5_protos.h b/source3/include/krb5_protos.h
index 32f995c..f16cafd 100644
--- a/source3/include/krb5_protos.h
+++ b/source3/include/krb5_protos.h
@@ -67,10 +67,6 @@ bool setup_kaddr( krb5_address *pkaddr, struct 
sockaddr_storage *paddr);
 int create_kerberos_key_from_string(krb5_context context, krb5_principal 
host_princ, krb5_data *password, krb5_keyblock *key, krb5_enctype enctype, bool 
no_salt);
 bool get_auth_data_from_tkt(TALLOC_CTX *mem_ctx, DATA_BLOB *auth_data, 
krb5_ticket *tkt);
 krb5_const_principal get_principal_from_tkt(krb5_ticket *tkt);
-krb5_error_code smb_krb5_locate_kdc(krb5_context ctx, const krb5_data *realm, 
struct sockaddr **addr_pp, int *naddrs, int get_masters);
-#if defined(HAVE_KRB5_LOCATE_KDC)
-krb5_error_code krb5_locate_kdc(krb5_context ctx, const krb5_data *realm, 
struct sockaddr **addr_pp, int *naddrs, int get_masters);
-#endif
 krb5_error_code get_kerberos_allowed_etypes(krb5_context context, krb5_enctype 
**enctypes);
 bool get_krb5_smb_session_key(TALLOC_CTX *mem_ctx,
  krb5_context context,
diff --git a/source3/libsmb/clikrb5.c b/source3/libsmb/clikrb5.c
index 9af3e49..8cea29c 100644
--- a/source3/libsmb/clikrb5.c
+++ b/source3/libsmb/clikrb5.c
@@ -347,95 +347,6 @@ bool unwrap_pac(TALLOC_CTX *mem_ctx, DATA_BLOB *auth_data, 
DATA_BLOB *unwrapped_
 #endif
 }
 
-#if !defined(HAVE_KRB5_LOCATE_KDC)
-
-/* krb5_locate_kdc is an internal MIT symbol. MIT are not yet willing to commit
- * to a public interface for this functionality, so we have to be able to live
- * without it if the MIT libraries are hiding their internal symbols.
- */
-
-#if defined(KRB5_KRBHST_INIT)
-/* Heimdal */
- krb5_error_code smb_krb5_locate_kdc(krb5_context ctx, const krb5_data *realm, 
struct sockaddr **addr_pp, int *naddrs, int get_masters)
-{
-   krb5_krbhst_handle hnd;
-   krb5_krbhst_info *hinfo;
-   krb5_error_code rc;
-   int num_kdcs, i;
-   struct sockaddr *sa;
-   struct addrinfo *ai;
-
-   *addr_pp = NULL;
-   *naddrs = 0;
-
-   rc = krb5_krbhst_init(ctx, realm-data, KRB5_KRBHST_KDC, hnd);
-   if (rc) {
-   DEBUG(0, (smb_krb5_locate_kdc: krb5_krbhst_init failed 
(%s)\n, error_message(rc)));
-   return rc;
-   }
-
-   for ( num_kdcs = 0; (rc = krb5_krbhst_next(ctx, hnd, hinfo) == 0); 
num_kdcs++)
-   ;
-
-   krb5_krbhst_reset(ctx, hnd);
-
-   if (!num_kdcs) {
-   DEBUG(0, (smb_krb5_locate_kdc: zero kdcs found !\n));
-   krb5_krbhst_free(ctx, hnd);
-   return -1;
-   }
-
-   sa = SMB_MALLOC_ARRAY( struct sockaddr, num_kdcs );
-   if (!sa) {
-   DEBUG(0, (smb_krb5_locate_kdc: malloc failed\n));
-   krb5_krbhst_free(ctx, hnd);
-   naddrs = 0;
-   

[SCM] Samba Shared Repository - branch master updated

2012-02-09 Thread Andreas Schneider
The branch, master has been updated
   via  5ec1273 s3-printing: Add new printers to registry.
  from  2464a7b s3-libsmb: Remove obsolete smb_krb5_locate_kdc.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 5ec12732c3092d248a374ae7af155a409c7ee88e
Author: Björn Baumbach b...@sernet.de
Date:   Tue Feb 7 11:41:54 2012 +0100

s3-printing: Add new printers to registry.

This fixes bug #8554, #8612 and #8748.

Pair-Programmed-With: Stefan Metzmacher me...@samba.org

Autobuild-User: Andreas Schneider a...@cryptomilk.org
Autobuild-Date: Thu Feb  9 16:39:04 CET 2012 on sn-devel-104

---

Summary of changes:
 source3/include/nt_printing.h  |4 +++
 source3/printing/nt_printing.c |   19 +++-
 source3/smbd/server_reload.c   |   44 ++--
 3 files changed, 54 insertions(+), 13 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/include/nt_printing.h b/source3/include/nt_printing.h
index 4735c4e..08a2161 100644
--- a/source3/include/nt_printing.h
+++ b/source3/include/nt_printing.h
@@ -176,5 +176,9 @@ void nt_printer_remove(TALLOC_CTX *mem_ctx,
const struct auth_session_info *server_info,
struct messaging_context *msg_ctx,
const char *printer);
+void nt_printer_add(TALLOC_CTX *mem_ctx,
+   const struct auth_session_info *server_info,
+   struct messaging_context *msg_ctx,
+   const char *printer);
 
 #endif /* NT_PRINTING_H_ */
diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index 7fc55c3..92aa320 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -1845,7 +1845,22 @@ void nt_printer_remove(TALLOC_CTX *mem_ctx,
result = winreg_delete_printer_key_internal(mem_ctx, session_info, 
msg_ctx,
   printer, );
if (!W_ERROR_IS_OK(result)) {
-   DEBUG(0, (nt_printer_remove: failed to remove printer %s,
- printer));
+   DEBUG(0, (nt_printer_remove: failed to remove printer %s: 
+   %s\n, printer, win_errstr(result)));
+   }
+}
+
+void nt_printer_add(TALLOC_CTX *mem_ctx,
+   const struct auth_session_info *session_info,
+   struct messaging_context *msg_ctx,
+   const char *printer)
+{
+   WERROR result;
+
+   result = winreg_create_printer_internal(mem_ctx, session_info, msg_ctx,
+   printer);
+   if (!W_ERROR_IS_OK(result)) {
+   DEBUG(0, (nt_printer_add: failed to add printer %s: %s\n,
+ printer, win_errstr(result)));
}
 }
diff --git a/source3/smbd/server_reload.c b/source3/smbd/server_reload.c
index f15f80e..6d4b876 100644
--- a/source3/smbd/server_reload.c
+++ b/source3/smbd/server_reload.c
@@ -50,14 +50,19 @@ void delete_and_reload_printers(struct tevent_context *ev,
 {
struct auth_session_info *session_info = NULL;
struct spoolss_PrinterInfo2 *pinfo2 = NULL;
+   int n_services;
+   int pnum;
int snum;
-   int n_services = lp_numservices();
-   int pnum = lp_servicenumber(PRINTERS_NAME);
const char *pname;
+   const char *sname;
NTSTATUS status;
-   bool skip = false;
 
-   SMB_ASSERT(pcap_cache_loaded());
+   /* Get pcap printers updated */
+   load_printers(ev, msg_ctx);
+
+   n_services = lp_numservices();
+   pnum = lp_servicenumber(PRINTERS_NAME);
+
DEBUG(10, (reloading printer services from pcap cache\n));
 
status = make_session_info_system(talloc_tos(), session_info);
@@ -66,18 +71,29 @@ void delete_and_reload_printers(struct tevent_context *ev,
  Could not create system session_info\n));
/* can't remove stale printers before we
 * are fully initilized */
-   skip = true;
+   return;
}
 
-   /* remove stale printers */
-   for (snum = 0; skip == false  snum  n_services; snum++) {
-   /* avoid removing PRINTERS_NAME or non-autoloaded printers */
-   if (snum == pnum || !(lp_snum_ok(snum)  lp_print_ok(snum) 
- lp_autoloaded(snum)))
+   /*
+* Add default config for printers added to smb.conf file and remove
+* stale printers
+*/
+   for (snum = 0; snum  n_services; snum++) {
+   /* avoid removing PRINTERS_NAME */
+   if (snum == pnum) {
+   continue;
+   }
+
+   /* skip no-printer services */
+   if (!(lp_snum_ok(snum)  lp_print_ok(snum))) {

[SCM] Samba Shared Repository - branch master updated

2012-02-09 Thread Volker Lendecke
The branch, master has been updated
   via  744ed53 gensec: Fix a memory corruption in gensec_use_kerberos_mechs
  from  5ec1273 s3-printing: Add new printers to registry.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 744ed53a62037a659133ccd4de2065491208ae7d
Author: Volker Lendecke v...@samba.org
Date:   Thu Feb 9 16:07:12 2012 +0100

gensec: Fix a memory corruption in gensec_use_kerberos_mechs

Without this I get the following valgrind error:

==27740== Invalid write of size 8
==27740==at 0x62C53E: gensec_use_kerberos_mechs (gensec_start.c:112)
==27740==by 0x62C623: gensec_security_mechs (gensec_start.c:141)
==27740==by 0x62C777: gensec_security_by_oid (gensec_start.c:181)
==27740==by 0x62DD6E: gensec_start_mech_by_oid (gensec_start.c:735)
==27740==by 0x50D6FD: negprot_spnego (negprot.c:210)
==27740==by 0x5B0DEA: smbd_smb2_request_process_negprot 
(smb2_negprot.c:209)
==27740==by 0x5AD036: smbd_smb2_request_dispatch (smb2_server.c:1417)
==27740==by 0x5AFB77: smbd_smb2_first_negprot (smb2_server.c:2643)
==27740==by 0x585C00: process_smb (process.c:1641)
==27740==by 0x587F78: smbd_server_connection_read_handler 
(process.c:2314)
==27740==by 0x587FD6: smbd_server_connection_handler (process.c:2331)
==27740==by 0x99E05B: run_events_poll (events.c:286)
==27740==by 0x584AFF: smbd_server_connection_loop_once (process.c:984)
==27740==by 0x58B2D9: smbd_process (process.c:3389)
==27740==by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740==by 0x99E05B: run_events_poll (events.c:286)
==27740==by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740==by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740==by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740==by 0xDE6DD8: main (server.c:1413)
==27740==  Address 0x9ff3538 is 4,232 bytes inside a block of size 8,288 
alloc'd
==27740==at 0x4C261D7: malloc (in 
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==27740==by 0x6926965: __talloc (talloc.c:560)
==27740==by 0x6926771: talloc_pool (talloc.c:598)
==27740==by 0x93B927: talloc_stackframe_internal (talloc_stack.c:145)
==27740==by 0x93B9D6: talloc_stackframe_pool (talloc_stack.c:171)
==27740==by 0x58B2B7: smbd_process (process.c:3385)
==27740==by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740==by 0x99E05B: run_events_poll (events.c:286)
==27740==by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740==by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740==by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740==by 0xDE6DD8: main (server.c:1413)

In the for-loop we can increment j twice, so we need twice as many output 
array
elements as input array elements.

Autobuild-User: Volker Lendecke v...@samba.org
Autobuild-Date: Thu Feb  9 19:44:47 CET 2012 on sn-devel-104

---

Summary of changes:
 auth/gensec/gensec_start.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/auth/gensec/gensec_start.c b/auth/gensec/gensec_start.c
index 08b2fb6..ab092a7 100644
--- a/auth/gensec/gensec_start.c
+++ b/auth/gensec/gensec_start.c
@@ -75,7 +75,8 @@ _PUBLIC_ struct gensec_security_ops 
**gensec_use_kerberos_mechs(TALLOC_CTX *mem_
/* noop */
}
 
-   new_gensec_list = talloc_array(mem_ctx, struct gensec_security_ops *, 
num_mechs_in + 1);
+   new_gensec_list = talloc_array(mem_ctx, struct gensec_security_ops *,
+  num_mechs_in*2 + 1);
if (!new_gensec_list) {
return NULL;
}


-- 
Samba Shared Repository


autobuild: intermittent test failure detected

2012-02-09 Thread autobuild
The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2012-02-10-0020/flakey.log

The samba3 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-02-10-0020/samba3.stderr
   http://git.samba.org/autobuild.flakey/2012-02-10-0020/samba3.stdout

The source4 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-02-10-0020/samba4.stderr
   http://git.samba.org/autobuild.flakey/2012-02-10-0020/samba4.stdout
  
The top commit at the time of the failure was:

commit 744ed53a62037a659133ccd4de2065491208ae7d
Author: Volker Lendecke v...@samba.org
Date:   Thu Feb 9 16:07:12 2012 +0100

gensec: Fix a memory corruption in gensec_use_kerberos_mechs

Without this I get the following valgrind error:

==27740== Invalid write of size 8
==27740==at 0x62C53E: gensec_use_kerberos_mechs (gensec_start.c:112)
==27740==by 0x62C623: gensec_security_mechs (gensec_start.c:141)
==27740==by 0x62C777: gensec_security_by_oid (gensec_start.c:181)
==27740==by 0x62DD6E: gensec_start_mech_by_oid (gensec_start.c:735)
==27740==by 0x50D6FD: negprot_spnego (negprot.c:210)
==27740==by 0x5B0DEA: smbd_smb2_request_process_negprot 
(smb2_negprot.c:209)
==27740==by 0x5AD036: smbd_smb2_request_dispatch (smb2_server.c:1417)
==27740==by 0x5AFB77: smbd_smb2_first_negprot (smb2_server.c:2643)
==27740==by 0x585C00: process_smb (process.c:1641)
==27740==by 0x587F78: smbd_server_connection_read_handler 
(process.c:2314)
==27740==by 0x587FD6: smbd_server_connection_handler (process.c:2331)
==27740==by 0x99E05B: run_events_poll (events.c:286)
==27740==by 0x584AFF: smbd_server_connection_loop_once (process.c:984)
==27740==by 0x58B2D9: smbd_process (process.c:3389)
==27740==by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740==by 0x99E05B: run_events_poll (events.c:286)
==27740==by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740==by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740==by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740==by 0xDE6DD8: main (server.c:1413)
==27740==  Address 0x9ff3538 is 4,232 bytes inside a block of size 8,288 
alloc'd
==27740==at 0x4C261D7: malloc (in 
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==27740==by 0x6926965: __talloc (talloc.c:560)
==27740==by 0x6926771: talloc_pool (talloc.c:598)
==27740==by 0x93B927: talloc_stackframe_internal (talloc_stack.c:145)
==27740==by 0x93B9D6: talloc_stackframe_pool (talloc_stack.c:171)
==27740==by 0x58B2B7: smbd_process (process.c:3385)
==27740==by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740==by 0x99E05B: run_events_poll (events.c:286)
==27740==by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740==by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740==by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740==by 0xDE6DD8: main (server.c:1413)

In the for-loop we can increment j twice, so we need twice as many output 
array
elements as input array elements.

Autobuild-User: Volker Lendecke v...@samba.org
Autobuild-Date: Thu Feb  9 19:44:47 CET 2012 on sn-devel-104


Re: [SCM] Samba Shared Repository - branch master updated

2012-02-09 Thread Jelmer Vernooij

Hi Andreas, Björn,

On 02/09/2012 04:40 PM, Andreas Schneider wrote:

The branch, master has been updated
via  5ec1273 s3-printing: Add new printers to registry.
   from  2464a7b s3-libsmb: Remove obsolete smb_krb5_locate_kdc.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 5ec12732c3092d248a374ae7af155a409c7ee88e
Author: Björn Baumbachb...@sernet.de
Date:   Tue Feb 7 11:41:54 2012 +0100

 s3-printing: Add new printers to registry.

 This fixes bug #8554, #8612 and #8748.

 Pair-Programmed-With: Stefan Metzmacherme...@samba.org

 Autobuild-User: Andreas Schneidera...@cryptomilk.org
 Autobuild-Date: Thu Feb  9 16:39:04 CET 2012 on sn-devel-104

After this change (or perhaps an earlier one?) I'm unable to push 
changes to autobuild. The last two builds fail with:


[275/1226 in 17m41s] samba3.posix_s3.rpc.spoolss.printer (s3dc)
Testing DsSpooler-  SetPrinter relations
Testing GetPrinter level 2
Testing SetPrinter level 2
Testing GetPrinterDataEx(DsSpooler - description)
Testing SetPrinter level 2
Testing GetPrinterDataEx(DsSpooler - location)
Testing GetPrinter level 2
Testing GetPrinterDataEx(DsSpooler - description)
Testing GetPrinterDataEx(DsSpooler - driverName)
WARNING!: ../source4/torture/rpc/spoolss.c:3648: r.out.result was WERR_BADFILE, 
expected WERR_OK: GetPrinterDataEx(DsSpooler - driverName) failed
WARNING!: ../source4/torture/rpc/spoolss.c:5509: Expression `test_GetPrinterDataEx(tctx, p, handle, 
DsSpooler, driverName,type,data,needed)' failed: failed to query
UNEXPECTED(failure): samba3.posix_s3.rpc.spoolss.printer 
.addprinterex.printerdata_dsspooler
REASON: _StringException: _StringException: ../source4/torture/rpc/spoolss.c:7879: 
Expression `test_PrinterData_DsSpooler(tctx, p,t-handle, 
t-info2.printername)' failed: failed to test printer data winreg dsspooler

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

A summary with detailed information can be found in:
  ./bin/ab/summary
test: running (/usr/bin/perl /memdisk/autobuild/flakey/b12981/samba4/selftest/selftest.pl --target=samba 
--prefix=./bin/ab --srcdir=/memdisk/autobuild/flakey/b12981/samba4 
--exclude=/memdisk/autobuild/flakey/b12981/samba4/selftest/skip --testlist=/usr/bin/python 
/memdisk/autobuild/flakey/b12981/samba4/source3/selftest/tests.py| --testlist=/usr/bin/python 
/memdisk/autobuild/flakey/b12981/samba4/source4/selftest/tests.py| 
--binary-mapping=nmblookup3:nmblookup3,smbclient3:smbclient3,smbtorture4:smbtorture,ntlm_auth3:ntlm_auth3 
--exclude=/memdisk/autobuild/flakey/b12981/samba4/selftest/slow --socket-wrapper  touch 
./bin/ab/st_done) | /usr/bin/python -u /memdisk/autobuild/flakey/b12981/samba4/selftest/filter-subunit 
--expected-failures=/memdisk/autobuild/flakey/b12981/samba4/selftest/knownfail 
--flapping=/memdisk/autobuild/flakey/b12981/samba4/selftest/flapping --fail-immediately | tee 
./bin/ab/subunit | /usr/bin/python -u /memdisk/autobuild/flakey/b12981/samba4/selftest/format-subunit 
--prefix=./bin/ab --immediate

Cheers,

Jelmer


[SCM] Samba Shared Repository - branch master updated

2012-02-09 Thread Jelmer Vernooij
The branch, master has been updated
   via  209d3c0 tests/source: Add wafsamba/ files to list of Python files 
to check.
   via  88a041a wafsamba: Expand tabs.
  from  744ed53 gensec: Fix a memory corruption in gensec_use_kerberos_mechs

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 209d3c0b7187f2c4e6be5a972206094cdf70224f
Author: Jelmer Vernooij jel...@samba.org
Date:   Thu Feb 9 13:12:06 2012 +0100

tests/source: Add wafsamba/ files to list of Python files to check.

Autobuild-User: Jelmer Vernooij jel...@samba.org
Autobuild-Date: Fri Feb 10 01:45:16 CET 2012 on sn-devel-104

commit 88a041aa21c520fef46fae5a7db8958d4202cc8f
Author: Jelmer Vernooij jel...@samba.org
Date:   Thu Feb 9 13:08:31 2012 +0100

wafsamba: Expand tabs.

---

Summary of changes:
 buildtools/wafsamba/gccdeps.py |  182 ++--
 buildtools/wafsamba/generic_cc.py  |   68 +++---
 buildtools/wafsamba/irixcc.py  |   96 +++---
 buildtools/wafsamba/nothreads.py   |  362 
 buildtools/wafsamba/samba3.py  |   18 +-
 buildtools/wafsamba/samba_conftests.py |2 +-
 buildtools/wafsamba/samba_optimisation.py  |  156 +-
 buildtools/wafsamba/samba_pidl.py  |4 +-
 buildtools/wafsamba/samba_wildcard.py  |  210 +++---
 buildtools/wafsamba/tru64cc.py |   96 +++---
 source4/scripting/python/samba/tests/source.py |   18 +-
 11 files changed, 613 insertions(+), 599 deletions(-)


Changeset truncated at 500 lines:

diff --git a/buildtools/wafsamba/gccdeps.py b/buildtools/wafsamba/gccdeps.py
index 6600c9c..2f09083 100644
--- a/buildtools/wafsamba/gccdeps.py
+++ b/buildtools/wafsamba/gccdeps.py
@@ -18,111 +18,111 @@ preprocessor_flag = '-MD'
 @feature('cc')
 @before('apply_core')
 def add_mmd_cc(self):
-   if self.env.get_flat('CCFLAGS').find(preprocessor_flag)  0:
-   self.env.append_value('CCFLAGS', preprocessor_flag)
+if self.env.get_flat('CCFLAGS').find(preprocessor_flag)  0:
+self.env.append_value('CCFLAGS', preprocessor_flag)
 
 @feature('cxx')
 @before('apply_core')
 def add_mmd_cxx(self):
-   if self.env.get_flat('CXXFLAGS').find(preprocessor_flag)  0:
-   self.env.append_value('CXXFLAGS', preprocessor_flag)
+if self.env.get_flat('CXXFLAGS').find(preprocessor_flag)  0:
+self.env.append_value('CXXFLAGS', preprocessor_flag)
 
 def scan(self):
-   the scanner does not do anything initially
-   nodes = self.generator.bld.node_deps.get(self.unique_id(), [])
-   names = []
-   return (nodes, names)
+the scanner does not do anything initially
+nodes = self.generator.bld.node_deps.get(self.unique_id(), [])
+names = []
+return (nodes, names)
 
 re_o = re.compile(\.o$)
 re_src = re.compile(^(\.\.)[\\/](.*)$)
 
 def post_run(self):
-   # The following code is executed by threads, it is not safe, so a lock 
is needed...
-
-   if getattr(self, 'cached', None):
-   return Task.Task.post_run(self)
-
-   name = self.outputs[0].abspath(self.env)
-   name = re_o.sub('.d', name)
-   txt = Utils.readf(name)
-   #os.unlink(name)
-
-   txt = txt.replace('\\\n', '')
-
-   lst = txt.strip().split(':')
-   val = :.join(lst[1:])
-   val = val.split()
-
-   nodes = []
-   bld = self.generator.bld
-
-   f = re.compile(^(+self.env.variant()+|\.\.)[\\/](.*)$)
-   for x in val:
-   if os.path.isabs(x):
-
-   if not preproc.go_absolute:
-   continue
-
-   lock.acquire()
-   try:
-   node = bld.root.find_resource(x)
-   finally:
-   lock.release()
-   else:
-   g = re.search(re_src, x)
-   if g:
-   x = g.group(2)
-   lock.acquire()
-   try:
-   node = 
bld.bldnode.parent.find_resource(x)
-   finally:
-   lock.release()
-   else:
-   g = re.search(f, x)
-   if g:
-   x = g.group(2)
-   lock.acquire()
-   try:
-   node = 
bld.srcnode.find_resource(x)
-   finally:
-   lock.release()
-
-   if id(node) == id(self.inputs[0]):
-   # ignore the 

autobuild: intermittent test failure detected

2012-02-09 Thread autobuild
The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2012-02-10-0225/flakey.log

The samba3 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-02-10-0225/samba3.stderr
   http://git.samba.org/autobuild.flakey/2012-02-10-0225/samba3.stdout

The source4 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-02-10-0225/samba4.stderr
   http://git.samba.org/autobuild.flakey/2012-02-10-0225/samba4.stdout
  
The top commit at the time of the failure was:

commit 209d3c0b7187f2c4e6be5a972206094cdf70224f
Author: Jelmer Vernooij jel...@samba.org
Date:   Thu Feb 9 13:12:06 2012 +0100

tests/source: Add wafsamba/ files to list of Python files to check.

Autobuild-User: Jelmer Vernooij jel...@samba.org
Autobuild-Date: Fri Feb 10 01:45:16 CET 2012 on sn-devel-104


[SCM] Samba Shared Repository - branch master updated

2012-02-09 Thread Andrew Bartlett
The branch, master has been updated
   via  a056238 s4-nbt_server: remove unused winsdb_get_seqnumber()
   via  5c2a213 s3-libsmb: Remove unused kerberos_set_creds_enctype()
   via  292974e s3-libsmb: Remove unused kerberos_compatible_enctypes
   via  474fbfb s3-lib: Remove unused is_myworkgroup()
   via  4512353 s3-charcnv: Remove unused rpcstr_push()
   via  a7835f4 s3-libsmb: Remove unused smb_krb5_mk_error()
   via  3d63100 s3-param: Remove unused share_defined()
   via  a74e556 s4-lib/samba3: Remove unused smbpasswd_decode_acb_info()
   via  efc210d lib/util: Remove unused str_format_nbt_domain()
   via  fc5a214 charset: Remove unused strcmp_w()
   via  ac57def s4-lib/tls: remove unused tls_support()
   via  abc90d8 s4-cmdline: Remove unused popt_common_dont_ask()
   via  40bf23d s3-lib: Remove unused pid_path()
   via  7824fd5 s3-registry: Remove unused prs_uint8()
   via  3b88c1e s3-charcnv: Remove unused pull_string_fn
   via  983d205 charset: Remove unused iconv_talloc()
   via  88298f9 build: Add --enable-coverage option to build with gcov 
support
   via  45e681d heimdal: Re-run lexyacc.sh to remove #line statements
   via  11c5301 heimdal_build: omit #line statments
   via  c38ba53 heimdal: Re-run lexyacc.sh
   via  292b863 credentials: Show returned error_string in debug message
  from  209d3c0 tests/source: Add wafsamba/ files to list of Python files 
to check.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit a056238bcd67ca611a4856c73e1e947c184ac7f5
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 11:25:58 2012 +1100

s4-nbt_server: remove unused winsdb_get_seqnumber()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

Autobuild-User: Andrew Bartlett abart...@samba.org
Autobuild-Date: Fri Feb 10 08:21:41 CET 2012 on sn-devel-104

commit 5c2a2135c92388659cf5b3d151272671cc2c5383
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 15:37:50 2012 +1100

s3-libsmb: Remove unused kerberos_set_creds_enctype()

Also remove the unused configure tests for krb5_c_enctype_compare.

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

commit 292974ed0ca768ff1cffb85313a923e7d4bcf549
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 15:34:45 2012 +1100

s3-libsmb: Remove unused kerberos_compatible_enctypes

Also remove the unused configure tests for krb5_c_enctype_compare.

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

commit 474fbfb7b712fe6be61505ca1796d0a3442a618a
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 15:20:24 2012 +1100

s3-lib: Remove unused is_myworkgroup()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

commit 45123530e52d9d096d5a01f02ba4672bd75b9305
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 13:40:52 2012 +1100

s3-charcnv: Remove unused rpcstr_push()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

commit a7835f473694dd7ff0ad7679e86fd4b2de7e23ce
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 13:29:06 2012 +1100

s3-libsmb: Remove unused smb_krb5_mk_error()

Also remove now-unused configure checks for krb5_mk_error().

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

commit 3d63100890371b25a873afe0fd240d6069e274dc
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 13:24:46 2012 +1100

s3-param: Remove unused share_defined()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

commit a74e556a7c2446a25f796a76043d7cdf2d8745b3
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 13:22:37 2012 +1100

s4-lib/samba3: Remove unused smbpasswd_decode_acb_info()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

commit efc210d5208a2da1fc33c7ebd745bf806dd26f62
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 12:49:45 2012 +1100

lib/util: Remove unused str_format_nbt_domain()

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

commit fc5a214d71ac46d031098afb3b8ccf2de472ef94
Author: Andrew Bartlett abart...@samba.org
Date:   Thu Feb 9 12:46:38 2012 +1100

charset: Remove unused strcmp_w()

Found by callcatcher.

Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html

Andrew Bartlett

commit ac57defdb4171c5b8266083f18ce89fecf0a4032
Author: Andrew Bartlett 

autobuild: intermittent test failure detected

2012-02-09 Thread autobuild
The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2012-02-10-0824/flakey.log

The samba3 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-02-10-0824/samba3.stderr
   http://git.samba.org/autobuild.flakey/2012-02-10-0824/samba3.stdout

The source4 build logs are available here:

   http://git.samba.org/autobuild.flakey/2012-02-10-0824/samba4.stderr
   http://git.samba.org/autobuild.flakey/2012-02-10-0824/samba4.stdout
  
The top commit at the time of the failure was:

commit 209d3c0b7187f2c4e6be5a972206094cdf70224f
Author: Jelmer Vernooij jel...@samba.org
Date:   Thu Feb 9 13:12:06 2012 +0100

tests/source: Add wafsamba/ files to list of Python files to check.

Autobuild-User: Jelmer Vernooij jel...@samba.org
Autobuild-Date: Fri Feb 10 01:45:16 CET 2012 on sn-devel-104