[Samba] Solaris 11 ZFS - acl_xattr still needed ?
Dear list, Setup is: Solaris 11 ZFS + Samba 3.5.10 What is the recommended way nowadays of performing strict permissions mapping between Samba and Windows NT 6.1 ? And a more broader question: is it desirable ? As we know ZFS has native NFSv4 ACL's and this would mean that permissions applied on Windows side should have an exact match on the ZFS side. Is it acl_xattr module still needed ? Example: [samba] path=/export/home/samba writable=yes vfs objects=acl_xattr By the way: acl_xattr is production ready now if I am not mistaken ? Dragos -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] cross-compile samba4
On 2012-05-17 14:06, Andrew Bartlett wrote: Hi Mike, I've CC'ed Kai, who is our expert on Samba4 on ARM. Hopefully he can help you out. I have to admit that so far I've resorted to building natively on the ARM hardware I run things on. You need a target Python version in your path, and cross-compiling Python has so far been a stumbling block for me. The dreamplug is a Kirkwood-based ARMv5, right? With a reasonably fast disk, I can build on similar hardware in ~2 hours, iirc. Make sure you have enough RAM, the build takes 128 megs. HTH, Kai -- Kai Blin Worldforge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] cross-compile samba4
On 18/05/2012 08:15, Kai Blin wrote: On 2012-05-17 14:06, Andrew Bartlett wrote: Hi Mike, I've CC'ed Kai, who is our expert on Samba4 on ARM. Hopefully he can help you out. I have to admit that so far I've resorted to building natively on the ARM hardware I run things on. You need a target Python version in your path, and cross-compiling Python has so far been a stumbling block for me. The dreamplug is a Kirkwood-based ARMv5, right? With a reasonably fast disk, I can build on similar hardware in ~2 hours, iirc. Make sure you have enough RAM, the build takes 128 megs. HTH, Kai Thanks guys, that's very helpful. I have compiled natively on the dreamplug and it did take ~2hrs. In the past I've usually had to compile numerous times and time is money as they say :), so compiling on my desktop, at just under 5mins, would be a boon. Cheers, Mike. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] cross-compile samba4
On 2012-05-18 09:45, Mike Howard wrote: Hi Mike, I have compiled natively on the dreamplug and it did take ~2hrs. In the past I've usually had to compile numerous times and time is money as they say :), so compiling on my desktop, at just under 5mins, would be a boon. The Archlinux|ARM folks have a guide on using distcc cross-compiling guide on their website, http://archlinuxarm.org/developers/distcc-cross-compiling I haven't tried this myself yet, but it should be adaptable to your set-up and allow you to launch ARM builds that are distributed to your desktop machine. HTH, Kai -- Kai Blin Worldforge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] Is there anything like cifs autofs for windows?
Hi Under Linux, we can tell the automounter to mount just the bit we need e.g. * -fstype=cifs,rw,sec=krb5 ://server/share/ Windows seems to mount the whole lot, even if only one user is working on one file in one subfolder. We are not able to change smb.conf just now and were wondering if there anything similar for windows. Cheers, Steve -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba compilation issue
http://www.samba.org/ftp/talloc/ - has talloc 1.3.x not 1.0.x (my mistake.) For the non working machine - which package are you using for 3.4.2? SMCsamba is the package from Sunfreeware.com.I am unclear if you non-working has 3.4.2 or 3.5.3. SUNWsmb* packages are from Sun/Oracle. I am also guessing that on the working machine you have gcc from sunfreeware (based on the /usr/local path.) Depending on how your LD_LIBRARY_PATH was set and which gcc you were using, the SMCsamba packages could have provided some required libraries when building software. My guess is that samba 3.5.x uses a newer libtalloc than 3.4.x and that was causing some of the problems.Although LD_LIBRARY_PATH and PKG_CONFIG_PATH should have let you specify the version you wanted. I wonder if the wrong gcc isnt picking it up correctly- so using the same gcc as the working machine may matter. Are you on a sparc or x86_64 system? I believe that sunfreeware gcc on sparc compiles 64-bit by default but on x86_64 will compile 32-bit by default (even on a 64-bit machine.) I still think the simplest thing is to just use the latest Sun/Oracle samba and skip compiling. You should be able to download the Samba patches from Oracle without having to install the full patch cluster. PS. I noticed that samba 3.4.x and higher enforce the Solaris NGROUPS_MAX parameter. You probably want to have set ngroups_max=32 in /etc/system- otherwise default is 16. If you have the latest kernel patches (147440-10 or 147441-10 as of 2-3 months ago) you can set this even higher. From: prabu.muru...@emc.com [mailto:prabu.muru...@emc.com] Sent: Friday, May 18, 2012 12:25 AM To: gaiseric.van...@gmail.com; samba@lists.samba.org Subject: RE: Samba compilation issue Thanks a lot for your reply. I was going crazy because of this issue. Let me answer your questions. Can you cat talloc.pc- make sure the config file shows the correct path. bash-3.2# more /usr/local/samba-extras/lib/pkgconfig/talloc.pc prefix=/usr/local/samba-extras exec_prefix=${prefix} libdir=${prefix}/lib includedir=${prefix}/include Name: talloc Description: A hierarchical pool based memory system with destructors Version: 2.0.7 Libs: -Wl,-rpath,/usr/local/samba-extras/lib -L${libdir} -ltalloc Cflags: -I${includedir} URL: http://talloc.samba.org/ I wonder what the significant difference is between your two solaris 10 machines. Which gcc are you using. Do either of them have the sunfreeware versions of samba? Or the sun bundled versions of samba. Maybe one machine already has libtalloc installed.What does pkginfo | grep -i samba show? I think samba 3.0x. binaries from Sun/Oracle may have been in /usr/sfw/bin not /usr/bin. On the working server /usr/local/bin/gcc version is 3.4.6. Here /bin/gcc is 3.4.3. path and version are different. Non working machine bash-3.2# pkginfo | grep -i samba application SMCsamba samba è 3.5.3 system SUNWsmbaSsamba - A Windows SMB/CIFS fileserver for UNIX (Source) system SUNWsmbacsamba - A Windows SMB/CIFS fileserver for UNIX (client) system SUNWsmbarsamba - A Windows SMB/CIFS fileserver for UNIX (Root) system SUNWsmbausamba - A Windows SMB/CIFS fileserver for UNIX (Usr) Working machine bash-3.00# pkginfo |grep samba application SMCsamba samba è 3.0.24 system SUNWsmbacsamba - A Windows SMB/CIFS fileserver for UNIX (client) è system SUNWsmbarsamba - A Windows SMB/CIFS fileserver for UNIX (Root) system SUNWsmbausamba - A Windows SMB/CIFS fileserver for UNIX (Usr) system sambaSMB based file/printer sharing What is the current version of samba you are running. Did you compile that or is if from a package? Is the current version in the PKG_CONFIG_PATH or LD_LIBRARY_PATH when compiling the new one? Working machine we were compiled samba 3.0.21b. now compiled 3.4.17. Non working machine current version 3.4.2(as package, not from source code) since 3.0.21b was not getting compiled. Working machine OS is Solaris 10_update 5. Non-working machine is latest OS Solaris 10_update 10. PS The samba 3.4.17 source code includes talloc. But it might be 1.0.x Maybe try downloading and compiling 1.0.x instead. And I would try building it into the same directory that you are building the rest of samba. I dont see 1.0.x under http://www.samba.org/ftp/talloc/. So I tried with 2.0.7. bash-3.2# pwd /usr/local/talloc-2.0.7 bash-3.2# ./configure --prefix=/usr/local/samba-3.4.17/source/ Is the current version in the PKG_CONFIG_PATH or LD_LIBRARY_PATH when compiling the new one? No they are not included in the new one. bash-3.2# echo $LD_LIBRARY_PATH
[Samba] Annoying: libreoffice doesn't understand smb:// protocol
Hi This is really annoying: If we e.g. in Nautilus: smb://server/share and then attempt to open a file using libreoffice, the splash screen appears for a few seconds and then disappears. We have to mount the share locally to be able to open the file. The beauty of the smb:// gvfs method is that it mounts with the uid of the user. Does anyone have a workaround? Maybe I should take this to libreoffice? Cheers, Steve -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba compilation issue
your configure syntax looks correct One major issue I ran into was the ld (linker) command. Gcc on Solaris (either from sun freeware tools cd or from www.sunfreeware.com) was built with /usr/ccs/bin/ld - which is an old version. A lot of software expects gnu ld or at least a newer version of ld. I could sometimes force stuff by sym linking /usr/ccs/bin/ld to /usr/local/bin/ld or /usr/sfw/bin/gld. /opt/usr/local/samba/sbin/smbd -V didn't show any output? Does /usr/sbin/smbd -V show output (that would be the sun/oracle version. Probably not relevant if it does work.) When you installed samba from sunfreeware did it warn about any missing dependencies? On 05/18/12 12:36, prabu.muru...@emc.com wrote: I ran ./configure --enable-external-libtalloc=no --with-libtalloc=no Issue is same. Above command is fine? I compiled talloc 1.3.0. still make gives the same error. I have attached output of make errors. Reinstalling 3.4.2 didn't helpL. *Thanks,* *Prabu* *From:*Gaiseric Vandal [mailto:gaiseric.van...@gmail.com] *Sent:* Friday, May 18, 2012 9:22 PM *To:* Murugan, Prabu *Subject:* Re: Samba compilation issue Your configure options (./configure --help) include --enable-external-libtalloc Enable external talloc [default=auto] --with-libtalloc Build the libtalloc shared library (default=yes if shared libs supported) You should be able to set to =no Or try building talloc 1.3.x with Samba 3.4.x. Do either of the following work? /opt/usr/local/samba/sbin/smbd -V /opt/usr/local/samba/sbin/smbd -b /opt/usr/local/samba/testparm -v -s /opt/usr/local/samba/lib/smb.conf You may want to have /opt/usr/local/samba/lib/ at the beginning of your LD_LIBRARY_PATH. You may want to reinstall the Sunfreeware version of samba 3.4.2 if you need to get samba up and running quickly on this machine. On 05/18/12 10:31, prabu.muru...@emc.com mailto:prabu.muru...@emc.com wrote: Yes the 3.5.10 is from Sun/Oracle. How to disable talloc while running ./configure? Smbd --F doesn't give any error. bash-3.2# LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/usr/local/samba/lib/ bash-3.2# /opt/usr/local/samba/sbin/smbd -F -s /opt/usr/local/samba/lib/smb.conf bash-3.2# ps -ef |grep smbd root 7201 7167 0 19:32:20 pts/1 0:00 grep smbd bash-3.2# which pkg-config /bin/pkg-config bash-3.2# /bin/pkg-config --version 0.15.0 When I try to compile talloc-2.0.7. I get this error. Waf: Entering directory `/usr/local/talloc-2.0.7/bin' [15/28] Compiling lib/replace/test/testsuite.c ../lib/replace/test/testsuite.c:52: error: syntax error before torture_local_replace ../lib/replace/test/testsuite.c:52: warning: data definition has no type or storage class ../lib/replace/test/testsuite.c:1058: error: syntax error before torture_local_replace ../lib/replace/test/testsuite.c: In function `torture_local_replace': ../lib/replace/test/testsuite.c:1060: error: `bool' undeclared (first use in this function) ../lib/replace/test/testsuite.c:1060: error: (Each undeclared identifier is reported only once ../lib/replace/test/testsuite.c:1060: error: for each function it appears in.) ../lib/replace/test/testsuite.c:1060: error: syntax error before ret ../lib/replace/test/testsuite.c:1061: error: `ret' undeclared (first use in this function) Waf: Leaving directory `/usr/local/talloc-2.0.7/bin' Build failed: - task failed (err #1): {task: cc testsuite.c - testsuite_3.o} make: Fatal error: Command failed for target `all' *Thanks,* *Prabu* *From:*Gaiseric Vandal [mailto:gaiseric.van...@gmail.com] *Sent:* Friday, May 18, 2012 6:57 PM *To:* Murugan, Prabu *Cc:* samba@lists.samba.org mailto:samba@lists.samba.org *Subject:* Re: Samba compilation issue This is a lot to keep track off. So the 3.5.10 is from Sun/Oracle? I see on sunfreeware.com that 3.4.2 is still their latest version. But I thought it would have installed in /usr/local/. If you moved renamed the directory, you may need to update your LD_LIBRARY_PATH. You may want to try running smbd with -F (foreground) instead of -D and see if that provides more errors. What does which pkg-config show on each machine? I see there is a sunfreeware.com version of pkg-config. The latest sun/oracle one is 0 .15 which the one one sunfreeware.com is 0.25. FYI when I compile samba I will usually compile in /usr/local/samba-version. Once I have it compiled I can delete or rename the previous version and then symlink /usr/local/samba to the new version. Can you do make talloc from with in the samba source code directory to build, in advance, the talloc that is bundled in?Or can you just disable talloc when you configure? Although I would be interested if you then get warnings that tdb is unavailable.
Re: [Samba] Samba compilation issue
When you installed samba did you specify an alternate path? I don't understand why it is in /opt/usr/local Since you can at least run it with -V, it indicates that the binary and the library paths are good. You may want to look at your samba log files (/var/samba/logs and /var/log/samba ) to see if there is some other issue - maybe with your config files, local cache or locks, or local db files. gcc will be harddwired to use /usr/ccs/bin/ld. You can try the following #mv /usr/ccs/bin/ld /usr/ccs/bin/ld.bak #ln -s /usr/local/bin/ld /usr/ccs/bin/ld This is not generally a good idea BUT it might help identify if your linker is a problem. Are these standalone servers or domain members or domain controllers? On 05/18/12 13:02, prabu.muru...@emc.com wrote: smbd -V is showing the version. bash-3.2# /opt/usr/local/samba/sbin/smbd -V Version 3.4.2 ld is picking from /usr/local/bin/ld bash-3.2# which ld /usr/local/bin/ld bash-3.2# /usr/local/bin/ld --version GNU ld (GNU Binutils) 2.21. I don't remember whether it gave error regarding dependencies while installing 3.4.2. But I installed all the dependencies as a prerequisite. *Thanks,* *Prabu* *From:*Gaiseric Vandal [mailto:gaiseric.van...@gmail.com] *Sent:* Friday, May 18, 2012 10:25 PM *To:* Murugan, Prabu; Samba *Subject:* Re: Samba compilation issue your configure syntax looks correct One major issue I ran into was the ld (linker) command. Gcc on Solaris (either from sun freeware tools cd or from www.sunfreeware.com http://www.sunfreeware.com) was built with /usr/ccs/bin/ld - which is an old version. A lot of software expects gnu ld or at least a newer version of ld. I could sometimes force stuff by sym linking /usr/ccs/bin/ld to /usr/local/bin/ld or /usr/sfw/bin/gld. /opt/usr/local/samba/sbin/smbd -V didn't show any output? Does /usr/sbin/smbd -V show output (that would be the sun/oracle version. Probably not relevant if it does work.) When you installed samba from sunfreeware did it warn about any missing dependencies? On 05/18/12 12:36, prabu.muru...@emc.com mailto:prabu.muru...@emc.com wrote: I ran ./configure --enable-external-libtalloc=no --with-libtalloc=no Issue is same. Above command is fine? I compiled talloc 1.3.0. still make gives the same error. I have attached output of make errors. Reinstalling 3.4.2 didn't helpL. *Thanks,* *Prabu* *From:*Gaiseric Vandal [mailto:gaiseric.van...@gmail.com] *Sent:* Friday, May 18, 2012 9:22 PM *To:* Murugan, Prabu *Subject:* Re: Samba compilation issue Your configure options (./configure --help) include --enable-external-libtalloc Enable external talloc [default=auto] --with-libtalloc Build the libtalloc shared library (default=yes if shared libs supported) You should be able to set to =no Or try building talloc 1.3.x with Samba 3.4.x. Do either of the following work? /opt/usr/local/samba/sbin/smbd -V /opt/usr/local/samba/sbin/smbd -b /opt/usr/local/samba/testparm -v -s /opt/usr/local/samba/lib/smb.conf You may want to have /opt/usr/local/samba/lib/ at the beginning of your LD_LIBRARY_PATH. You may want to reinstall the Sunfreeware version of samba 3.4.2 if you need to get samba up and running quickly on this machine. On 05/18/12 10:31, prabu.muru...@emc.com mailto:prabu.muru...@emc.com wrote: Yes the 3.5.10 is from Sun/Oracle. How to disable talloc while running ./configure? Smbd --F doesn't give any error. bash-3.2# LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/usr/local/samba/lib/ bash-3.2# /opt/usr/local/samba/sbin/smbd -F -s /opt/usr/local/samba/lib/smb.conf bash-3.2# ps -ef |grep smbd root 7201 7167 0 19:32:20 pts/1 0:00 grep smbd bash-3.2# which pkg-config /bin/pkg-config bash-3.2# /bin/pkg-config --version 0.15.0 When I try to compile talloc-2.0.7. I get this error. Waf: Entering directory `/usr/local/talloc-2.0.7/bin' [15/28] Compiling lib/replace/test/testsuite.c ../lib/replace/test/testsuite.c:52: error: syntax error before torture_local_replace ../lib/replace/test/testsuite.c:52: warning: data definition has no type or storage class ../lib/replace/test/testsuite.c:1058: error: syntax error before torture_local_replace ../lib/replace/test/testsuite.c: In function `torture_local_replace': ../lib/replace/test/testsuite.c:1060: error: `bool' undeclared (first use in this function) ../lib/replace/test/testsuite.c:1060: error: (Each undeclared identifier is reported only once ../lib/replace/test/testsuite.c:1060: error: for each function it appears in.) ../lib/replace/test/testsuite.c:1060: error: syntax error before ret ../lib/replace/test/testsuite.c:1061: error: `ret' undeclared (first use in this function) Waf: Leaving directory
[Samba] Password problem
Hi folks, My client and I are having a problem getting a portable Esaote ultrasound machine to connect to a Samba server. The unit has an integrated laptop with a Windows XP version that can hardly be modified. Upon delivery the vendor only changed the user name and workgroup for us. When I asked for the user password to make a matching Samba account, the vendor refused because they use a key on a USB stick for that. They said to fill in a name and password for the server every time we needed to access the Windows share. So far I've experimented with the Samba map to guest and guest account options, which should work, but I'd really like to see this machine connect to the Samba server in the usual fashion. Does anyone have any suggestions? Any workarounds, or hacks that I might try? Thanks, Jaap -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba4 for AD using existing LDAP, Kerberos, and Bind Setup.
Hi, I don't have a personal experience on it, but in case of suspecting a missing functionalitaty IMHO you should ask at the samba-rtechnical mailing list. Cheers Geza Geza, Have you actually set up a cross domain trust in Samba4 yet? My impression was that this was NOT working yet. I know you can configure the S3 server to join the S4 domain, but I don't think that's what you are talking about. I've been waiting to be able to set up a domain trust for some time now (with a WS2008 DC trusting a Samba4 based domain), and would love to know if you've found a way to do it! On Wed, May 16, 2012 at 1:26 AM, Gémes Géza g...@kzsdabas.hu mailto:g...@kzsdabas.hu wrote: On 2012-05-16 04:28, David Minard wrote: We run Apple's OD to support our Linux, Mac, and Windows clients and servers. We are under pressure to use AD because more and more software coming out for Windows requires it. We don't want to use AD, so Samba4 looks good. However, we don't want to pull apart our directory to implement samba4. Is there a way to get Samba 4 running so that it is able to use the existing LDAP and Kerberos set up for user info and user auth look up, still support Windows clients with AD, and still use our existing bind for general host look ups, but use samba4's own internal DNS for AD stuff? Cheers, David. If Apples solution is based on Samba3 (I have no personal experience with it). You would probably need two domains: the existing one and a new Samba4 one. Then set up a cross-domain trust between. Then join your windows boxes to the Samba4 domain. Regards Geza -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- Charles Tryon _ “Risks are not to be evaluated in terms of the probability of success, but in terms of the value of the goal.” - Ralph D. Winter -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Trouble with mount.cifs while smbclient works (Ubuntu 12.04)
Yes, I think that has been the normal behavior since our data was moved to this device. I assumed it was due to filesystem permissions -- that I don't have read access to the root level of the share, but do have r/w access to the /training/ directory below it. Using smbclient, get NT_STATUS_ACCESS_DENIED when I try: ls ls training ls /training ls /training/ but if I cd to training, I can list its contents. BTW, I've tried appending the path in my mount command as well and mount.cifs still doesn't handle it: -Original Message- From: Günter Kukkukk [mailto:li...@kukkukk.com] Sent: Thursday, May 17, 2012 8:03 PM To: Purcell, Scott After connect you do a ls training/ and get access denied, but then you cd into that subdir and ls is working. Do you _always_ see this behavior? When you use ls directly after connect, do you get some error? Cheers, Günter -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Trouble with mount.cifs while smbclient works (Ubuntu 12.04)
That line does exist in the specified file. -Original Message- From: Shirish Pargaonkar [mailto:shirishpargaon...@gmail.com] Sent: Thursday, May 17, 2012 11:09 PM To: Purcell, Scott Perhaps you need an entry like this create dns_resolver* * /usr/sbin/cifs.upcall %k in file /etc/request-key.conf -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba4 for AD using existing LDAP, Kerberos, and Bind Setup.
David, I'd echo Gemes comment about posting your question to the samba-techni...@lists.samba.org list which would be more appropriate. There is some topical discussion going on there regarding content of a samba4 Beta release, and your question would be well timed. I'd suggest that you also consider the samba4 on existing: dhcp, dns ntp infrastructure. Good sources of information are at: WhatsNew - http://gitweb.samba.org/?p=samba.git;a=blob;f=WHATSNEW.txt;h=8798a875cc7618 da819e9ecd1db6cb7f25f85a94;hb=edb15ffef29fbb69a4d1dfc862fe8d6a3a027347 Other useful references: 1. https://wiki.samba.org/index.php/Samba4/HOWTO 2. https://wiki.samba.org/index.php/Samba4/HOWTO/Join_a_domain_as_a_DC 3. https://wiki.samba.org/index.php/Samba4/samba3upgrade/HOWTO 4. Last updated March 2011 https://wiki.samba.org/index.php/Samba4_DRS_TODO_List#Support_RODC Kind regards, Dewayne. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 45082a8 s4-torture: Improve torture test boilerplate, use torture_assert() via 8c52d1b s4-torture: Always use torture_assert() to handle failures via e919cad s4-torture: provide correct torture failures for failure to connect via 8e5badc build: Also look for iconv in /usr/local by default via 4626f25 Add include/lib folders from the commandline via 975e799 s4-torture: Fix rpc.samr.priv test to use torture_assert() macros via ae338bf autobuild: Run ABI check on samba4-libs as well. via 611ca8e build: Move generated files out of the normal build tree via 584a51b build: Move generated version.h to a waf-invisible location from 01c502d pygensec: Fix init of variable if not specified. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 45082a88c7928ca36003ade071aafe4de54d Author: Andrew Bartlett abart...@samba.org Date: Fri May 18 15:43:31 2012 +1000 s4-torture: Improve torture test boilerplate, use torture_assert() This ensures that if this fails, it is reported as a subunit error correctly. Andrew Bartlett Autobuild-User: Andrew Bartlett abart...@samba.org Autobuild-Date: Fri May 18 09:35:13 CEST 2012 on sn-devel-104 commit 8c52d1b8ac7d56eb728e4cc4ed2a560365d374b5 Author: Andrew Bartlett abart...@samba.org Date: Fri May 18 15:06:28 2012 +1000 s4-torture: Always use torture_assert() to handle failures commit e919cadcca063a4cb1a76a3c30b15f056a51e16d Author: Andrew Bartlett abart...@samba.org Date: Fri May 18 14:22:27 2012 +1000 s4-torture: provide correct torture failures for failure to connect commit 8e5badc2564019bc2d8b923971bd37bd8e5bb039 Author: Andrew Bartlett abart...@samba.org Date: Fri May 18 08:28:18 2012 +1000 build: Also look for iconv in /usr/local by default This should help the build find iconv on FreeBSD and similar systems, and make it possible to operate with 8-bit character sets. Andrew Bartlett commit 4626f25b5353c4c648e9403c6593feb2c9a2e347 Author: Thomas Nagy tnagy2po...@gmail.com Date: Thu May 17 14:49:08 2012 +0200 Add include/lib folders from the commandline By using opt.add_option(..., match=['Checking for library iconv'], dest='iconvdir'), all configuration tests displaying 'Checking for library iconv' will get $(iconvdir)/lib and $(iconvdir)/include commit 975e799e866b4d97b71a7bf3ddabf7c19f8a9f87 Author: Andrew Bartlett abart...@samba.org Date: Thu May 17 13:10:31 2012 +1000 s4-torture: Fix rpc.samr.priv test to use torture_assert() macros commit ae338bf3f532c0bd5956e2ad9c2747ebd66bb49c Author: Andrew Bartlett abart...@samba.org Date: Thu May 17 13:21:57 2012 +1000 autobuild: Run ABI check on samba4-libs as well. Because this build is without the developer options (so as to check that we build without those) we do not do an ABI check by default. Andrew Bartlett commit 611ca8e8196738345de3596ca61e75fe5a895c26 Author: Andrew Bartlett abart...@samba.org Date: Thu May 17 11:12:07 2012 +1000 build: Move generated files out of the normal build tree This avoids some dual-build-system interactions. Andrew Bartlett commit 584a51b2ca891c5546c7e9ee8f039bfeb4d6a319 Author: Andrew Bartlett abart...@samba.org Date: Thu May 17 16:43:48 2012 +1000 build: Move generated version.h to a waf-invisible location Generally, it is better if our generated header files for the autoconf build do not end up in places that the waf build can see. Andrew Bartlett --- Summary of changes: .gitignore |4 +- buildtools/wafsamba/samba_conftests.py | 67 - buildtools/wafsamba/wscript|5 + examples/VFS/Makefile.in |1 + script/autobuild.py| 10 +- source3/Makefile.in| 170 source3/autoconf/librpc/gen_ndr/README |7 ++ source3/autogen.sh |4 +- source3/script/mkversion.sh|2 +- source4/torture/basic/delaywrite.c | 64 +++- source4/torture/basic/disconnect.c |4 +- source4/torture/basic/locking.c| 19 ++--- source4/torture/raw/chkpath.c |4 +- source4/torture/raw/context.c | 24 + source4/torture/raw/eas.c |8 +- source4/torture/raw/ioctl.c|4 +- source4/torture/raw/lock.c | 44 ++-- source4/torture/raw/mkdir.c|4 +- source4/torture/raw/mux.c |4 +- source4/torture/raw/open.c | 64 +++- source4/torture/raw/oplock.c |8 +- source4/torture/raw/read.c | 20
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via f5ca3f1 s3: Revert the serverid changes, they need more work from 45082a8 s4-torture: Improve torture test boilerplate, use torture_assert() http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit f5ca3f11e47e48d195616f813b5b2c9e8255c6cd Author: Volker Lendecke v...@samba.org Date: Fri May 18 09:10:02 2012 +0200 s3: Revert the serverid changes, they need more work Autobuild-User: Volker Lendecke v...@samba.org Autobuild-Date: Fri May 18 13:12:14 CEST 2012 on sn-devel-104 --- Summary of changes: source3/Makefile.in |3 +- source3/locking/locking.c | 40 + source3/locking/proto.h |1 - source3/locking/share_mode_lock.c | 42 + source3/smbd/close.c | 16 +--- source3/smbd/open.c | 25 - source3/smbd/trans2.c |3 - source3/torture/proto.h |1 - source3/torture/test_cleanup.c| 175 - source3/torture/torture.c |1 - source3/wscript_build |1 - 11 files changed, 46 insertions(+), 262 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/Makefile.in b/source3/Makefile.in index 984cc00..1eb8cd8 100644 --- a/source3/Makefile.in +++ b/source3/Makefile.in @@ -1282,12 +1282,11 @@ SMBTORTURE_OBJ1 = torture/torture.o torture/nbio.o torture/scanner.o torture/uta torture/t_strappend.o SMBTORTURE_OBJ = $(SMBTORTURE_OBJ1) $(PARAM_OBJ) $(TLDAP_OBJ) \ - $(LIBSMB_OBJ) $(KRBCLIENT_OBJ) $(LIB_NONSMBD_OBJ) $(LOCKING_OBJ) \ + $(LIBSMB_OBJ) $(KRBCLIENT_OBJ) $(LIB_NONSMBD_OBJ) \ @LIBWBCLIENT_STATIC@ \ torture/wbc_async.o \ ../nsswitch/wb_reqtrans.o \ ../libcli/lsarpc/util_lsarpc.o \ - lib/filename_util.o \ $(LIBMSRPC_OBJ) $(LIBMSRPC_GEN_OBJ) $(LIBCLI_ECHO_OBJ) MASKTEST_OBJ = torture/masktest.o $(PARAM_OBJ) $(LIBSMB_OBJ) $(KRBCLIENT_OBJ) \ diff --git a/source3/locking/locking.c b/source3/locking/locking.c index b9fba17..b9afd23 100644 --- a/source3/locking/locking.c +++ b/source3/locking/locking.c @@ -556,10 +556,6 @@ bool rename_share_filename(struct messaging_context *msg_ctx, continue; } - if (share_mode_stale_pid(d, i)) { - continue; - } - DEBUG(10,(rename_share_filename: sending rename message to pid %s file_id %s sharepath %s base_name %s stream_name %s\n, @@ -620,9 +616,7 @@ bool is_valid_share_mode_entry(const struct share_mode_entry *e) num_props += (EXCLUSIVE_OPLOCK_TYPE(e-op_type) ? 1 : 0); num_props += (LEVEL_II_OPLOCK_TYPE(e-op_type) ? 1 : 0); - if (serverid_exists(e-pid) (num_props 1)) { - smb_panic(Invalid share mode entry); - } + SMB_ASSERT(num_props = 1); return (num_props != 0); } @@ -631,38 +625,6 @@ bool is_deferred_open_entry(const struct share_mode_entry *e) return (e-op_type == DEFERRED_OPEN_ENTRY); } -/* - * In case d-share_modes[i] conflicts with something or otherwise is - * being used, we need to make sure the corresponding process still - * exists. This routine checks it and potentially removes the entry - * from d-share_modes. Modifies d-num_share_modes, watch out in - * routines iterating over that array. - */ -bool share_mode_stale_pid(struct share_mode_data *d, unsigned i) -{ - struct share_mode_entry *e; - - if (i d-num_share_modes) { - DEBUG(1, (Asking for index %u, only %u around\n, - i, (unsigned)d-num_share_modes)); - return false; - } - e = d-share_modes[i]; - if (serverid_exists(e-pid)) { - DEBUG(10, (PID %s (index %u out of %u) still exists\n, - procid_str_static(e-pid), i, - (unsigned)d-num_share_modes)); - return false; - } - DEBUG(10, (PID %s (index %u out of %u) does not exist anymore\n, - procid_str_static(e-pid), i, - (unsigned)d-num_share_modes)); - *e = d-share_modes[d-num_share_modes-1]; - d-num_share_modes -= 1; - d-modified = true; - return true; -} - /*** Fill a share mode entry. / diff --git a/source3/locking/proto.h b/source3/locking/proto.h index f6a6f2e..54badd9 100644 --- a/source3/locking/proto.h +++ b/source3/locking/proto.h @@ -168,7 +168,6 @@ void get_file_infos(struct file_id id, struct timespec *write_time); bool
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 5c219a1 s4:torture: Add raw.session.reauth2 test via 61e023b s4:torture: rename raw.session.reauth = raw.session.reauth1 via d58f7cd s3:smbd: allow creating new spnego sessions only with a 0 vuid via 84ce448 s3:smbd: SMBtdis should return ERRSRV, ERRinvnid instead of NETWORK_NAME_DELETED via d79b46f selftest/Samba3: add 'smbd:suicide mode = yes' from 7db6374 s3:idmap_cache: improve checks for format of value string in idmap_cache_find_sid2unixid() http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 5c219a1c5cc9450743c946aeb4a2b99e58f15b2d Author: Volker Lendecke v...@samba.org Date: Wed May 2 15:54:03 2012 +0200 s4:torture: Add raw.session.reauth2 test Signed-off-by: Stefan Metzmacher me...@samba.org Autobuild-User: Stefan Metzmacher me...@samba.org Autobuild-Date: Fri May 18 18:25:42 CEST 2012 on sn-devel-104 commit 61e023bbf6c6918e58d272c32261c65c88b0fe97 Author: Stefan Metzmacher me...@samba.org Date: Fri May 18 13:39:48 2012 +0200 s4:torture: rename raw.session.reauth = raw.session.reauth1 metze commit d58f7cd5469baba5b47bbd6923103aa4c6b42c91 Author: Stefan Metzmacher me...@samba.org Date: Thu May 3 16:13:08 2012 +0200 s3:smbd: allow creating new spnego sessions only with a 0 vuid Found by the raw.context test. metze commit 84ce4484e7cee8a1d32da698a23941d2ed429b0c Author: Stefan Metzmacher me...@samba.org Date: Thu May 3 15:53:56 2012 +0200 s3:smbd: SMBtdis should return ERRSRV, ERRinvnid instead of NETWORK_NAME_DELETED Found by the raw.context test. metze commit d79b46f358d7e6fd942bb0f3da2174455e9b1740 Author: Stefan Metzmacher me...@samba.org Date: Thu May 17 01:06:29 2012 +0200 selftest/Samba3: add 'smbd:suicide mode = yes' metze --- Summary of changes: selftest/target/Samba3.pm |1 + source3/smbd/reply.c |2 +- source3/smbd/sesssetup.c |5 ++ source4/torture/raw/session.c | 148 - 4 files changed, 152 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm index 04026be..d55c6d7 100755 --- a/selftest/target/Samba3.pm +++ b/selftest/target/Samba3.pm @@ -845,6 +845,7 @@ sub provision($$) interfaces = $server_ip/8 bind interfaces only = yes panic action = $self-{srcdir}/selftest/gdb_backtrace %d %\$(MAKE_TEST_BINARY) + smbd:suicide mode = yes workgroup = $domain diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c index dc43106..45f761c 100644 --- a/source3/smbd/reply.c +++ b/source3/smbd/reply.c @@ -5058,7 +5058,7 @@ void reply_tdis(struct smb_request *req) if (!conn) { DEBUG(4,(Invalid connection in tdis\n)); - reply_nterror(req, NT_STATUS_NETWORK_NAME_DELETED); + reply_force_doserror(req, ERRSRV, ERRinvnid); END_PROFILE(SMBtdis); return; } diff --git a/source3/smbd/sesssetup.c b/source3/smbd/sesssetup.c index 7d1535a..f9ba976 100644 --- a/source3/smbd/sesssetup.c +++ b/source3/smbd/sesssetup.c @@ -202,6 +202,11 @@ static void reply_sesssetup_and_X_spnego(struct smb_request *req) /* Do we have a valid vuid now ? */ if (!is_partial_auth_vuid(sconn, vuid)) { + if (vuid != 0) { + reply_force_doserror(req, ERRSRV, ERRbaduid); + return; + } + /* No, start a new authentication setup. */ vuid = register_initial_vuid(sconn); if (vuid == UID_FIELD_INVALID) { diff --git a/source4/torture/raw/session.c b/source4/torture/raw/session.c index 3402693..21fb4da 100644 --- a/source4/torture/raw/session.c +++ b/source4/torture/raw/session.c @@ -25,10 +25,11 @@ #include lib/cmdline/popt_common.h #include param/param.h #include torture/util.h +#include auth/credentials/credentials.h -static bool test_session_reauth(struct torture_context *tctx, - struct smbcli_state *cli) +static bool test_session_reauth1(struct torture_context *tctx, +struct smbcli_state *cli) { NTSTATUS status; struct smb_composite_sesssetup io; @@ -82,12 +83,153 @@ done: return ok; } +static bool test_session_reauth2_oplock_timeout( + struct smbcli_transport *transport, uint16_t tid, uint16_t fnum, + uint8_t level, void *private_data) +{ + return true; +} + +static bool test_session_reauth2(struct torture_context *tctx, +struct smbcli_state *cli) +{ + char *random_string; + char *fname; + union smb_open
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 32cbf20 Move the set_write_time() call to after get_existing_share_mode_lock() returns with a share mode. via 87a62df Raise the debug level from 1 to 5 in get_share_mode_lock_internal() from 5c219a1 s4:torture: Add raw.session.reauth2 test http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 32cbf20e65578b3d5e71d571d81d561f33a887e2 Author: Jeremy Allison j...@samba.org Date: Fri May 18 19:29:36 2012 -0700 Move the set_write_time() call to after get_existing_share_mode_lock() returns with a share mode. get_existing_share_mode_lock() isn't really the right call here, as we're being called after close_remove_share_mode() inside close_normal_file() so it's quite normal to not have an existing share mode here. However, get_share_mode_lock() doesn't work because that will create a new share mode if one doesn't exist - so stick with this call (just ignore any error we get if the share mode doesn't exist. The previous commit raised the error message debug level inside get_share_mode_lock_internal() so we don't always get a level 1 error message if get_existing_share_mode_lock() fails. Autobuild-User: Jeremy Allison j...@samba.org Autobuild-Date: Sat May 19 06:26:33 CEST 2012 on sn-devel-104 commit 87a62df8e69bfd45c944f44fb7d03da244dc9a44 Author: Jeremy Allison j...@samba.org Date: Fri May 18 19:24:51 2012 -0700 Raise the debug level from 1 to 5 in get_share_mode_lock_internal() This isn't a fatal condition, there is a valid codepath that can cause this message. --- Summary of changes: source3/locking/share_mode_lock.c |3 ++- source3/smbd/close.c | 18 +++--- 2 files changed, 17 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/locking/share_mode_lock.c b/source3/locking/share_mode_lock.c index f28332c..493bc15 100644 --- a/source3/locking/share_mode_lock.c +++ b/source3/locking/share_mode_lock.c @@ -355,7 +355,8 @@ static struct share_mode_lock *get_share_mode_lock_internal( } if (d == NULL) { - DEBUG(1, (Could not get share mode lock\n)); + DEBUG(5, (get_share_mode_lock_internal: + Could not get share mode lock\n)); TALLOC_FREE(rec); return NULL; } diff --git a/source3/smbd/close.c b/source3/smbd/close.c index c87b1a0..ede7925 100644 --- a/source3/smbd/close.c +++ b/source3/smbd/close.c @@ -616,12 +616,24 @@ static NTSTATUS update_write_time_on_close(struct files_struct *fsp) return NT_STATUS_OK; } - /* On close if we're changing the real file time we -* must update it in the open file db too. */ - (void)set_write_time(fsp-file_id, fsp-close_write_time); + /* +* get_existing_share_mode_lock() isn't really the right +* call here, as we're being called after +* close_remove_share_mode() inside close_normal_file() +* so it's quite normal to not have an existing share +* mode here. However, get_share_mode_lock() doesn't +* work because that will create a new share mode if +* one doesn't exist - so stick with this call (just +* ignore any error we get if the share mode doesn't +* exist. +*/ lck = get_existing_share_mode_lock(talloc_tos(), fsp-file_id); if (lck) { + /* On close if we're changing the real file time we +* must update it in the open file db too. */ + (void)set_write_time(fsp-file_id, fsp-close_write_time); + /* Close write times overwrite sticky write times so we must replace any sticky write time here. */ if (!null_timespec(lck-data-changed_write_time)) { -- Samba Shared Repository