Re: [Samba] getent group and net ads user info differs
Hai, maybe im wrong, but.. net ads user info lisanyurimicolta Domain Users TerminalServer politicas3 SIIF Comercial Comercial... getent group comercial Capital C ? so 2 different groups is what your talking about. Greetz, Louis -Oorspronkelijk bericht- Van: c...@asualcance.com [mailto:samba-boun...@lists.samba.org] Namens Cristian Saavedra Verzonden: donderdag 4 april 2013 16:45 Aan: samba@lists.samba.org Onderwerp: [Samba] getent group and net ads user info differs Hello I have a samba 4.0.3 pdc and a samba 3.5.10 as a fileserver and i am having an issue that i like to share with you. I have a share son the samba 3 setup like this [Comercial] browsable = Yes comment = Comercial path = /shares2/Comercial valid users = @Ingenieria, @Mercadeo, @Comercial, @SIIF, @Costos, administrador, backup write list = @Comercial, @Mercadeo, @Ingenieria, administrador, claudiavillegas, manuelaparicio read list = @Comercial, @SIIF, ,@Almacen, @Costos, @Uruguay, @Ingenieria, backup force create mode = 666 force directory mode = 777 veto files = /*.exe/*.com/*.dll/*.mp3/*.bat/ As you can see the Comercial group is authorized to read and write, so i have this user lisanyurimicolta she is on the Comercial group: [root@srvfs audit]# net ads user info lisanyurimicolta Domain Users TerminalServer politicas3 SIIF Comercial [root@srvfs audit]# srvfs is my samba 3.x server, but then she can't write on the share, so i'm executing a getent group to validate that she is on that group for the winbind, but i get this [root@srvfs audit]# getent group comercial comercial:*:16777233:claralibreros,christiancano,danilocampo,an abedoya,guillerminagarcia,humbertocardona,marthamurillo,pruebas,yoancanabal,andreasaa,adrianazapata,jhonrealpe,maryamgamboa,jasso naperador,adolfotrullo,christhianjimenez,mariaguerrero,mariomun era,mauricioperdomo,melbaorejuela,paolagomez,richardordonez,gin agarces,juanagudelo,adrianalopez,andrespossu,dianaolano,yulymej ia,edwinyepes,jenniferbazantes,ronaldduque,maribelgomez,linaban ol,lauramulcue,johncastillo,luzgallego,giovannysotomayor,andres gutierrez,arlexcardona,jonathangaviria,victorianavia,andrescampino Why is this happening? any suggestions? Thanks for your help. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] sernet samba4 appliance
On 04/04/2013 01:23 AM, L.P.H. van Belle wrote: Hai, Just a question before im going for a lot of work. Is there, of will there be a new release of the sernet samba 4 appliance. and if so, wil there also amd64 packages. I really like the total solution, with the zarafa schema option etc, its a nice package and easy to install. Or are you people waiting for wheezy to release, i can understand that. Is there is some guideline to follow for rebuilding this to amd64, please tell me. Or some tips are also fine. Greetz, Louis Maybe you'd better off asking sernet directly. Bjorn any comments ? Matthieu. -- Matthieu Patou Samba Team http://samba.org -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba4 fails to work following upgrade - library version errors
I have just finished recompiling and still get the same problem: ./configure --enable-debug --enable-selftest make make install Once it had finished, I checked the version again and : root@raspberrypi:/usr/local/samba/sbin# samba -V samba: /usr/local/samba/lib/private/libcliauth.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libauth4.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libevents.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libcluster.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libprocess_model.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libsamdb-common.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libsamba-modules.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libndr-samba4.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/liberrors.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libservice.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libldbsamba.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libMESSAGING.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) samba: /usr/local/samba/lib/private/libntvfs.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) So I just tried: cd /usr/local/ mv samba samba-old cd /usr/local/samba4 make install The /usr/local/samba folder structure was recreated, but even after completion, when I type samba -V I still get the list of errors above. Help! :( Kind regards Graeme From: Graeme Porter To: Ricky Nance Cc: samba@lists.samba.org samba@lists.samba.org Sent: Wednesday, 3 April 2013, 17:46 Subject: Re: [Samba] Samba4 fails to work following upgrade - library version errors Hi Ricky, Thanks for replying. The original build was just run with the arguments on the HOWTO: ./configure --enable-debug --enable-selftest With the latest build, I thought I'd try adding Avahi on there as a means of announcing the Pi to domain members; as I understand it, Samba4 currently has no means of appearing under the Network Neighborhood, but previous versions did, and that Avahi is capable of providing that. I'd forgotten about adding Avahi in until your reply, oops :( The same arguments I previously used were still part of the ./configure command I ran - i.e. I didn't remove either of them: ./configure --enable-avahi --enable-debug --enable-selftest Could adding this have caused the problem? Kind regards, Graeme From: Ricky Nance ricky.na...@weaubleau.k12.mo.us To: Graeme Porter graeme.por...@yahoo.co.uk Cc: samba@lists.samba.org samba@lists.samba.org Sent: Wednesday, 3 April 2013, 17:21 Subject: Re: [Samba] Samba4 fails to work following upgrade - library version errors The last time you did ./configure, did you specify any arguments, if so, you will need the same arguments on this install. Also, I typically start 'fresh' by issuing a git clean -x -f -d after git pull and before ./configure. Ricky On Wed, Apr 3, 2013 at 11:06 AM, Graeme Porter graeme.por...@yahoo.co.uk wrote: Hello, I was running Samba4 for a while on my Raspberry Pi (Raspbian distro, running 3.6.11+ #371 PREEMPT armv6l kernel). The version of Samba I was running was 4.1.0pre1-GIT-fd8b258. Last night I decided to try to upgrade to see if I could upgrade it without breaking it. Note that the AD this Pi is the DC for doesn't have any physical clients as members; I was using a Virtual PC running WinXP and another running Ubuntu just to test it out - so technically there's no great loss if it did break - but I do want to start using the Pi as a DC for my physical Windows clients (my family's 3x computers - one Vista, one Win7, and one Win8), and I wanted to ensure I could upgrade it cleanly without loss of service first. So I used git pull to download the latest changes, as described in the Samba4 HOWTO guide. The configure, make, and make install stages went without a hitch (although the little Pi doesn't exactly blast through the compile, so it took several long hours). As a just-in-case, I even stopped Samba from running before I ran make install just in case the script couldn't overwrite a file that was in use. So I tried to check which version this had upgraded to by running samba -V: root@raspberrypi:/usr/local/samba4# samba -V samba:
[Samba] S4 file server : access to large file 1 GB
Hi all My S4 is configured as a file server. The AD DC is a 2003 win server. My users are talking about slow speed on open pst file or other largest file. I have this in my smb.conf socket options = TCP_NODELAY SO_RCVBUF=32768 SO_SNDBUF=32768 I tranfer a 3GB file on the server and I see variations in speed transfer. Generally it cost 28% of my bandwith (1 Gb/s) but, after a while, it speed down to 8% or 5% for a little time (1 second) and then go to 28%. I see this 4 times in the transfer. From what can it be ? Thanks FRanck -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba4 fails to work following upgrade - library version errors
Hi On 5 April 2013 12:22, Graeme Porter graeme.por...@yahoo.co.uk wrote: I have just finished recompiling and still get the same problem: ./configure --enable-debug --enable-selftest make make install Once it had finished, I checked the version again and : root@raspberrypi:/usr/local/samba/sbin# samba -V samba: /usr/local/samba/lib/private/libcliauth.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) [...] So I just tried: cd /usr/local/ mv samba samba-old cd /usr/local/samba4 make install The /usr/local/samba folder structure was recreated, but even after completion, when I type samba -V I still get the list of errors above. Help! :( It sounds like the samba binary on your PATH is the old version. What does the following print: $ which samba Does it work if you use the full path name: # /usr/local/samba/bin/samba -V -- Michael Wood esiot...@gmail.com -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba4 fails to work following upgrade - library version errors
Thanks Michael, I've got my domain controller back! I'm now rather distinctly annoyed. I *was* using a symbolic link in /usr/bin called samba that was pointing to /usr/local/samba/sbin/samba - this was the only way I found so far that I could avoid typing the whole command path every time - probably because I still can't see a way to persistently and globally add entries to the path variable (every time I tried this previously, if I logged out and logged in as a different user, my changes to the path were missing, and wouldn't even reappear when I logged back in as myself). My symbolic link appears to have been replaced at some point with an actual version of Samba. I don't know when or as part of what process (I am still a Linux newbie, so probably something I've done wrong again). Also, thanks for introducing me to the which command - every day is an education! Another build of Samba is in order - once again with the --enable-avahi flag, to see if that works out. Many thanks again! Kind regards Graeme From: Michael Wood esiot...@gmail.com To: Graeme Porter graeme.por...@yahoo.co.uk Cc: samba@lists.samba.org samba@lists.samba.org Sent: Friday, 5 April 2013, 15:54 Subject: Re: [Samba] Samba4 fails to work following upgrade - library version errors Hi On 5 April 2013 12:22, Graeme Porter graeme.por...@yahoo.co.uk wrote: I have just finished recompiling and still get the same problem: ./configure --enable-debug --enable-selftest make make install Once it had finished, I checked the version again and : root@raspberrypi:/usr/local/samba/sbin# samba -V samba: /usr/local/samba/lib/private/libcliauth.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) [...] So I just tried: cd /usr/local/ mv samba samba-old cd /usr/local/samba4 make install The /usr/local/samba folder structure was recreated, but even after completion, when I type samba -V I still get the list of errors above. Help! :( It sounds like the samba binary on your PATH is the old version. What does the following print: $ which samba Does it work if you use the full path name: # /usr/local/samba/bin/samba -V -- Michael Wood esiot...@gmail.com -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] S4 file server : access to large file 1 GB
Did you see the same results for all workstations? What versions of the Windows clients are you running that you see this problem with? -gc BOTZ Franck (Informaticien) - DDT 67/SG/MGI/CI franck.b...@bas-rhin.gouv.fr wrote: Hi all My S4 is configured as a file server. The AD DC is a 2003 win server. My users are talking about slow speed on open pst file or other largest file. I have this in my smb.conf socket options = TCP_NODELAY SO_RCVBUF=32768 SO_SNDBUF=32768 I tranfer a 3GB file on the server and I see variations in speed transfer. Generally it cost 28% of my bandwith (1 Gb/s) but, after a while, it speed down to 8% or 5% for a little time (1 second) and then go to 28%. I see this 4 times in the transfer. From what can it be ? Thanks FRanck -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba4 fails to work following upgrade - library version errors
On 05/04/13 16:19, Graeme Porter wrote: Thanks Michael, I've got my domain controller back! I'm now rather distinctly annoyed. I *was* using a symbolic link in /usr/bin called samba that was pointing to /usr/local/samba/sbin/samba - this was the only way I found so far that I could avoid typing the whole command path every time - probably because I still can't see a way to persistently and globally add entries to the path variable (every time I tried this previously, if I logged out and logged in as a different user, my changes to the path were missing, and wouldn't even reappear when I logged back in as myself). My symbolic link appears to have been replaced at some point with an actual version of Samba. I don't know when or as part of what process (I am still a Linux newbie, so probably something I've done wrong again). Also, thanks for introducing me to the which command - every day is an education! Another build of Samba is in order - once again with the --enable-avahi flag, to see if that works out. Many thanks again! Kind regards Graeme From: Michael Wood esiot...@gmail.com To: Graeme Porter graeme.por...@yahoo.co.uk Cc: samba@lists.samba.org samba@lists.samba.org Sent: Friday, 5 April 2013, 15:54 Subject: Re: [Samba] Samba4 fails to work following upgrade - library version errors Hi On 5 April 2013 12:22, Graeme Porter graeme.por...@yahoo.co.uk wrote: I have just finished recompiling and still get the same problem: ./configure --enable-debug --enable-selftest make make install Once it had finished, I checked the version again and : root@raspberrypi:/usr/local/samba/sbin# samba -V samba: /usr/local/samba/lib/private/libcliauth.so: version `SAMBA_4.1.0PRE1_GIT_FD8B258' not found (required by samba) [...] So I just tried: cd /usr/local/ mv samba samba-old cd /usr/local/samba4 make install The /usr/local/samba folder structure was recreated, but even after completion, when I type samba -V I still get the list of errors above. Help! :( It sounds like the samba binary on your PATH is the old version. What does the following print: $ which samba Does it work if you use the full path name: # /usr/local/samba/bin/samba -V Hi, try this # Set the path in /etc/profile.d/samba4.sh echo PATH=\$PATH:/usr/local/samba/bin:/usr/local/samba/sbin /etc/profile.d/samba4.sh export PATH=$PATH:/usr/local/samba/bin:/usr/local/samba/sbin Rowland -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] ClassicUpgrade = EpicFail
ClassicUpgrade of my samba3 data to samba4 fails, with this error:
ERROR(class 'passdb.error'): uncaught exception - Unable to get id for
sid
Full log of the classicupgrade is at the end of this email.
Project member on this list, Andrew Barlett, wrote that the issue is probably
that my Samba 3 passdb was passable in an NT 4 DC mode, but is actually
'invalid' :
The big issue here is that passdb has never had a 'fsck', and Samba
operates quite well as a 'classic' DC with an almost totally invalid
database!
As to what has happened in your particular instance, could you please
post me the output of ldbdump private/idmap.ldb?
I did post that, and will do so again, at the end of this email.
Assuming that the problem is my samba3 passdb.tdb data, what can I do to get on
with the upgrade?
My passdb is small-ish: 927 keys, according to this command, using samba3
binaries:
tdbtool passdb.db keys | wc -l
Is it feasible for me to manually 'fsck' my passdb.db?
Just looking at the output of tdbtool, it appears that there are 3 different
kinds of keys:
1) RID_8 character hex code; e.g. RID_0c54
2) USER_machine name; e.g. USER_mailserver$
3) USER_username; e.g. USER_jdoe
There are 463 RID_ keys, and 463 USER_ keys.
That makes me think that there's supposed to be a RID_ key for each USER_ key.
On that assumption, I did this to compare:
1) get sorted list of names appearing to be associated to RID_ keys:
tdbtool passdb.tdb dump | perl -ne 'if (/^(RID_\S+)/) { $rid=$1; $count =0;}
else { $count++; if ($count == 2 /^\[\w+\]\s+(\w\w\s\s*)+(\w{3,}.*)$/) {
$name = $2; $name =~ s/\s//g; print $name\n;}}' | sort RID-names
2) get sorted list of names from USER_ keys:
tdbtool passdb.tdb keys | grep USER | sed 's/USER_//' | sort USER-names
3) compare the 2 lists:
diff USER-names RID-names
6c6
a758b$
---
a758$
147d146
foo-0m1onzr8h2a$
175,176d173
is-conference$
is-contractor$
244a242
kstachowiak$
270d267
lwilcott$
421a419
termservbill$
424a423
termservdev$
450d448
tthomas
There are diffs. I.e. There is a USER_ key for machine a758b, but no
associated RID_ key.
There are RID_ keys for 4 machine accounts (a758$, kstachowiak$, termservbill$,
termservdev$) that have no USER_ keys. Etc.
Are these diffs indicative of problems that would cause the Classic Upgrade to
fail? If so, can I use pdbedit to remove these problems from my samba3
passdb.tdb?
Thanks,
Jon
p.s. The full classic upgrade log, with log level set to 3:
classicUpgradeLog
Reading smb.conf
Processing section [netlogon]
Processing section [homes]
Processing section [hr]
Processing section [is]
Processing section [billing]
Processing section [names]
Processing section [changed]
Processing section [to]
Processing section [protect]
Processing section [the]
Processing section [innocent]
Processing section [is_helpdesk]
Processing section [ISContractsAndLicenses]
Processing section [unsecure]
Processing section [names]
Processing section [changed]
Processing section [spaceplan]
Processing section [dr]
Processing section [to]
Processing section [hr_scan]
Processing section [ar]
Processing section [minutes]
Processing section [meeting_08_05]
Processing section [meeting_08_18]
Processing section [hr_analyst]
Processing section [hr_payroll]
Processing section [protect]
Processing section [financial_systems]
Processing section [is_files]
Processing section [valuation_model]
Processing section [the]
Processing section [innocent]
Processing section [bla]
Processing section [is_technical_services]
Processing section [bla bla]
Processing section [bla bla bla]
Processing section [bla bla bla bla]
Processing section [is_billing_files]
Processing section [lawson_project]
Processing section [jklsdfjklsdf]
Processing section [sdfsdfa]
Processing section [fax]
Processing section [werwer]
Processing section [anesth_coding]
Processing section [is_crystal_reports]
Processing section [7iiio]
Processing section [uiui]
Processing section [asdasdasd]
Provisioning
Exporting account policy
Exporting groups
Exporting users
snip
I omitted a whole bunch of lines from this output like the following, in order
to remove sensitive names.
/snip
Ignoring group memberships of 'helpstar-phone$'
S-1-5-21-4219228698-1431711829-1578001372-2776: Unable to enumerate group
memberships, (-1073741724,No such user)
Demoting BDC account trust for mobius, this DC must be elevated to an AD DC
using 'samba-tool domain promote'
Ignoring group memberships of 'mrad$'
S-1-5-21-4219228698-1431711829-1578001372-2952: Unable to enumerate group
memberships, (-1073741724,No such user)
Next rid = 3689
Exporting posix attributes
Reading WINS database
Cannot open wins database, Ignoring: [Errno 2] No such file or directory:
'/usr/local/mobius/var/wins.dat'
lpcfg_load: refreshing parameters from /usr/local/samba/etc/smb.conf
params.c:pm_process() - Processing configuration file
/usr/local/samba/etc/smb.conf
Looking up IPv4 addresses
Looking up IPv6 addresses
No
Re: [Samba] S4 file server : access to large file 1 GB
On Fri, Apr 05, 2013 at 03:37:47PM +0200, BOTZ Franck (Informaticien) - DDT 67/SG/MGI/CI wrote: Hi all My S4 is configured as a file server. The AD DC is a 2003 win server. My users are talking about slow speed on open pst file or other largest file. I have this in my smb.conf socket options = TCP_NODELAY SO_RCVBUF=32768 SO_SNDBUF=32768 Delete the above line with extreme prejudice. Don't go second guessing the kernel socket tuning. Jeremy. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[SCM] CTDB repository - branch 1.0.114 updated - ctdb-1.0.114.5-4-gd85f7f1
The branch, 1.0.114 has been updated
via d85f7f14572924ed45127964723f0924c3c20400 (commit)
via 4aa1c2c55c4caaf7689df3138ab832bc068ed0af (commit)
via e64f9c5fdc91dbcf52099cc119ff5b6f3ced47cc (commit)
via 8939a547a1d9df6653e4878b8127799962e2e9b7 (commit)
from 44e540648477217e37ba43f664124e0996b4496b (commit)
http://gitweb.samba.org/?p=ctdb.git;a=shortlog;h=1.0.114
- Log -
commit d85f7f14572924ed45127964723f0924c3c20400
Author: Martin Schwenke mar...@meltin.net
Date: Wed Nov 9 14:55:07 2011 +1100
Fix typo in ctdb_ltdb_store_server()
The if statement uses ret but means to use ret2.
Signed-off-by: Martin Schwenke mar...@meltin.net
(cherry picked from commit f40101a615f8b9826a484e4697bfea6ee2b9ba88)
commit 4aa1c2c55c4caaf7689df3138ab832bc068ed0af
Author: Michael Adam ob...@samba.org
Date: Tue Nov 20 11:20:34 2012 +0100
ctdb:recover: fix a comment typo
Signed-off-by: Michael Adam ob...@samba.org
(cherry picked from commit 5067392d2e06795559f25828b65c129608b65c0b)
commit e64f9c5fdc91dbcf52099cc119ff5b6f3ced47cc
Author: Volker Lendecke v...@samba.org
Date: Thu Nov 22 15:27:51 2012 +0100
vacuum: Avoid some tallocs in ctdb recovery
In a heavily loaded and volatile database a lot of SCHEDULE_FOR_DELETION
requests can come in between fast vacuuming runs. This can lead to
significant ctdb cpu load due to the cost of doing talloc_free. This
reduces the number of objects a bit by coalescing the two objects
of delete_record_data into one. It will also avoid having to allocate
another talloc header for a SCHEDULE_FOR_DELETION key. Not the full fix
for this problem, but it might contribute a bit.
(cherry picked from commit 9a02f61547ddf74629aca21639d8fb61c1df7cbb)
commit 8939a547a1d9df6653e4878b8127799962e2e9b7
Author: Michael Adam ob...@samba.org
Date: Fri Nov 16 14:33:41 2012 +0100
vacuum: fix a comment typo
Pair-Programmed-With: Volker Lendecke v...@samba.org
Signed-off-by: Michael Adam ob...@samba.org
(cherry picked from commit bab744e3c49efef2e05dc09e8ea9bd3e3fa58716)
---
Summary of changes:
server/ctdb_ltdb_server.c |2 +-
server/ctdb_recover.c |2 +-
server/ctdb_vacuum.c | 16 +---
3 files changed, 11 insertions(+), 9 deletions(-)
Changeset truncated at 500 lines:
diff --git a/server/ctdb_ltdb_server.c b/server/ctdb_ltdb_server.c
index c65b35f..275f6c6 100644
--- a/server/ctdb_ltdb_server.c
+++ b/server/ctdb_ltdb_server.c
@@ -241,7 +241,7 @@ store:
if (schedule_for_deletion) {
int ret2;
ret2 = ctdb_local_schedule_for_deletion(ctdb_db, header, key);
- if (ret != 0) {
+ if (ret2 != 0) {
DEBUG(DEBUG_ERR, (__location__
ctdb_local_schedule_for_deletion failed.\n));
}
}
diff --git a/server/ctdb_recover.c b/server/ctdb_recover.c
index e9e7659..537c4ea 100644
--- a/server/ctdb_recover.c
+++ b/server/ctdb_recover.c
@@ -354,7 +354,7 @@ static int traverse_pulldb(struct tdb_context *tdb,
TDB_DATA key, TDB_DATA data,
}
/*
- pul a bunch of records from a ltdb, filtering by lmaster
+ pull a bunch of records from a ltdb, filtering by lmaster
*/
int32_t ctdb_control_pull_db(struct ctdb_context *ctdb, TDB_DATA indata,
TDB_DATA *outdata)
{
diff --git a/server/ctdb_vacuum.c b/server/ctdb_vacuum.c
index 38e0c07..89e261a 100644
--- a/server/ctdb_vacuum.c
+++ b/server/ctdb_vacuum.c
@@ -93,6 +93,7 @@ struct delete_record_data {
struct ctdb_db_context *ctdb_db;
struct ctdb_ltdb_header hdr;
TDB_DATA key;
+ uint8_t keydata[1];
};
struct delete_records_list {
@@ -110,21 +111,22 @@ static int insert_delete_record_data_into_tree(struct
ctdb_context *ctdb,
{
struct delete_record_data *dd;
uint32_t hash;
+ size_t len;
- dd = talloc_zero(tree, struct delete_record_data);
+ len = offsetof(struct delete_record_data, keydata) + key.dsize;
+
+ dd = (struct delete_record_data *)talloc_size(tree, len);
if (dd == NULL) {
DEBUG(DEBUG_ERR,(__location__ Out of memory\n));
return -1;
}
+ talloc_set_name_const(dd, struct delete_record_data);
dd-ctdb = ctdb;
dd-ctdb_db = ctdb_db;
dd-key.dsize = key.dsize;
- dd-key.dptr = talloc_memdup(dd, key.dptr, key.dsize);
- if (dd-key.dptr == NULL) {
- DEBUG(DEBUG_ERR,(__location__ Out of memory\n));
- return -1;
- }
+ dd-key.dptr = dd-keydata;
+ memcpy(dd-keydata, key.dptr, key.dsize);
dd-hdr = *hdr;
@@ -675,7 +677,7 @@ static int ctdb_process_vacuum_fetch_lists(struct
ctdb_db_context *ctdb_db,
}
/**
- * Proces the delete list:
+
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 243278a doc: Document performance impact of hide unxx parameters from ca0d385 getpass: Don't fail if stdin is not a tty http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 243278a2c5ec29c153fa7d66678452a97e6edbc0 Author: Volker Lendecke v...@samba.org Date: Fri Apr 5 16:44:08 2013 +0200 doc: Document performance impact of hide unxx parameters Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: David Disseldorp dd...@samba.org Autobuild-User(master): David Disseldorp dd...@samba.org Autobuild-Date(master): Fri Apr 5 18:40:58 CEST 2013 on sn-devel-104 --- Summary of changes: docs-xml/smbdotconf/filename/hideunreadable.xml|3 +++ .../smbdotconf/filename/hideunwriteablefiles.xml |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/smbdotconf/filename/hideunreadable.xml b/docs-xml/smbdotconf/filename/hideunreadable.xml index c2c1654..992f135 100644 --- a/docs-xml/smbdotconf/filename/hideunreadable.xml +++ b/docs-xml/smbdotconf/filename/hideunreadable.xml @@ -5,6 +5,9 @@ description paraThis parameter prevents clients from seeing the existance of files that cannot be read. Defaults to off./para + paraPlease note that enabling this can slow down listing large + directories significantly. Samba has to evaluate the ACLs of all + directory members, which can be a lot of effort./para /description value type=defaultno/value /samba:parameter diff --git a/docs-xml/smbdotconf/filename/hideunwriteablefiles.xml b/docs-xml/smbdotconf/filename/hideunwriteablefiles.xml index 831e8c6..6665860 100644 --- a/docs-xml/smbdotconf/filename/hideunwriteablefiles.xml +++ b/docs-xml/smbdotconf/filename/hideunwriteablefiles.xml @@ -7,6 +7,9 @@ This parameter prevents clients from seeing the existance of files that cannot be written to. Defaults to off. Note that unwriteable directories are shown as usual. /para +paraPlease note that enabling this can slow down listing large +directories significantly. Samba has to evaluate the ACLs of all directory +members, which can be a lot of effort./para /description value type=defaultno/value /samba:parameter -- Samba Shared Repository
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2013-04-05-2032/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2013-04-05-2032/samba3.stderr http://git.samba.org/autobuild.flakey/2013-04-05-2032/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2013-04-05-2032/samba.stderr http://git.samba.org/autobuild.flakey/2013-04-05-2032/samba.stdout The top commit at the time of the failure was: commit 243278a2c5ec29c153fa7d66678452a97e6edbc0 Author: Volker Lendecke v...@samba.org Date: Fri Apr 5 16:44:08 2013 +0200 doc: Document performance impact of hide unxx parameters Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: David Disseldorp dd...@samba.org Autobuild-User(master): David Disseldorp dd...@samba.org Autobuild-Date(master): Fri Apr 5 18:40:58 CEST 2013 on sn-devel-104
