CVS update: samba/source/client
Date: Thu Feb 26 06:42:52 2004 Author: sfrench Update of /home/cvs/samba/source/client In directory dp.samba.org:/tmp/cvs-serv32507 Modified Files: Tag: SAMBA_3_0 mount.cifs.c Log Message: Fixes to minor security bug pointed out by AB in the mount helper Revisions: mount.cifs.c1.2.2.14 => 1.2.2.15 http://www.samba.org/cgi-bin/cvsweb/samba/source/client/mount.cifs.c.diff?r1=1.2.2.14&r2=1.2.2.15
CVS update: samba/source/lib
Date: Thu Feb 26 02:11:31 2004 Author: tridge Update of /home/cvs/samba/source/lib In directory dp.samba.org:/tmp/cvs-serv2986 Modified Files: Tag: SAMBA_3_0 adt_tree.c Log Message: fixed compilation with --enable-dmalloc the macro redefinition of free() means we cannot have a structure element called "free" Revisions: adt_tree.c 1.4.4.2 => 1.4.4.3 http://www.samba.org/cgi-bin/cvsweb/samba/source/lib/adt_tree.c.diff?r1=1.4.4.2&r2=1.4.4.3
CVS update: samba/source/include
Date: Thu Feb 26 02:11:26 2004 Author: tridge Update of /home/cvs/samba/source/include In directory dp.samba.org:/tmp/cvs-serv2965 Modified Files: Tag: SAMBA_3_0 adt_tree.h Log Message: fixed compilation with --enable-dmalloc the macro redefinition of free() means we cannot have a structure element called "free" Revisions: adt_tree.h 1.1.4.1 => 1.1.4.2 http://www.samba.org/cgi-bin/cvsweb/samba/source/include/adt_tree.h.diff?r1=1.1.4.1&r2=1.1.4.2
CVS update: samba/source/torture
Date: Thu Feb 26 01:33:35 2004 Author: jra Update of /data/cvs/samba/source/torture In directory dp.samba.org:/tmp/cvs-serv28718/torture Modified Files: Tag: SAMBA_3_0 torture.c Log Message: Merging Richard's rename test. Jeremy. Revisions: torture.c 1.63.2.24 => 1.63.2.25 http://www.samba.org/cgi-bin/cvsweb/samba/source/torture/torture.c.diff?r1=1.63.2.24&r2=1.63.2.25
CVS update: samba/source/smbd
Date: Thu Feb 26 01:31:10 2004
Author: jra
Update of /data/cvs/samba/source/smbd
In directory dp.samba.org:/tmp/cvs-serv28527/smbd
Modified Files:
Tag: SAMBA_3_0
reply.c
Log Message:
Interesting fact found by IFSTEST /t LockOverlappedTest...
Even if it's our own lock context, we need to wait here as
there may be an unlock on the way.
So I removed a "&& !my_lock_ctx" from the following
if statement.
if ((lock_timeout != 0) && lp_blocking_locks(SNUM(conn)) &&
ERROR_WAS_LOCK_DENIED(status)) {
Jeremy.
Revisions:
reply.c 1.381.2.65 => 1.381.2.66
http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/reply.c.diff?r1=1.381.2.65&r2=1.381.2.66
CVS update: samba/source/smbd
Date: Thu Feb 26 01:30:56 2004
Author: jra
Update of /data/cvs/samba/source/smbd
In directory dp.samba.org:/tmp/cvs-serv27817/smbd
Modified Files:
reply.c
Log Message:
Interesting fact found by IFSTEST /t LockOverlappedTest...
Even if it's our own lock context, we need to wait here as
there may be an unlock on the way.
So I removed a "&& !my_lock_ctx" from the following
if statement.
if ((lock_timeout != 0) && lp_blocking_locks(SNUM(conn)) &&
ERROR_WAS_LOCK_DENIED(status)) {
Jeremy.
Revisions:
reply.c 1.446 => 1.447
http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/reply.c.diff?r1=1.446&r2=1.447
CVS update: samba/source/passdb
Date: Wed Feb 25 23:19:17 2004 Author: abartlet Update of /data/cvs/samba/source/passdb In directory dp.samba.org:/tmp/cvs-serv5824/source/passdb Modified Files: machine_sid.c Log Message: (merge from 3.0) Fix bug in previous global_sam_sid() commit. I broke the 'read from MACHINE.SID' file functionality. Also, before we print out the results of 'net getlocalsid' and 'net getdomainsid', ensure we have tried to read that file, or have generated one. Andrew Bartlett Revisions: machine_sid.c 1.19 => 1.20 http://www.samba.org/cgi-bin/cvsweb/samba/source/passdb/machine_sid.c.diff?r1=1.19&r2=1.20
CVS update: samba/source/utils
Date: Wed Feb 25 23:19:17 2004 Author: abartlet Update of /data/cvs/samba/source/utils In directory dp.samba.org:/tmp/cvs-serv5824/source/utils Modified Files: net.c Log Message: (merge from 3.0) Fix bug in previous global_sam_sid() commit. I broke the 'read from MACHINE.SID' file functionality. Also, before we print out the results of 'net getlocalsid' and 'net getdomainsid', ensure we have tried to read that file, or have generated one. Andrew Bartlett Revisions: net.c 1.92 => 1.93 http://www.samba.org/cgi-bin/cvsweb/samba/source/utils/net.c.diff?r1=1.92&r2=1.93
CVS update: samba/source/utils
Date: Wed Feb 25 23:12:29 2004 Author: abartlet Update of /home/cvs/samba/source/utils In directory dp.samba.org:/tmp/cvs-serv4306/utils Modified Files: Tag: SAMBA_3_0 net.c Log Message: Fix bug in previous global_sam_sid() commit. I broke the 'read from MACHINE.SID' file functionality. Also, before we print out the results of 'net getlocalsid' and 'net getdomainsid', ensure we have tried to read that file, or have generated one. Andrew Bartlett Revisions: net.c 1.43.2.41 => 1.43.2.42 http://www.samba.org/cgi-bin/cvsweb/samba/source/utils/net.c.diff?r1=1.43.2.41&r2=1.43.2.42
CVS update: samba/source/passdb
Date: Wed Feb 25 23:12:29 2004 Author: abartlet Update of /home/cvs/samba/source/passdb In directory dp.samba.org:/tmp/cvs-serv4306/passdb Modified Files: Tag: SAMBA_3_0 machine_sid.c Log Message: Fix bug in previous global_sam_sid() commit. I broke the 'read from MACHINE.SID' file functionality. Also, before we print out the results of 'net getlocalsid' and 'net getdomainsid', ensure we have tried to read that file, or have generated one. Andrew Bartlett Revisions: machine_sid.c 1.9.2.8 => 1.9.2.9 http://www.samba.org/cgi-bin/cvsweb/samba/source/passdb/machine_sid.c.diff?r1=1.9.2.8&r2=1.9.2.9
CVS update: samba/source/torture
Date: Wed Feb 25 22:14:35 2004 Author: sharpe Update of /data/cvs/samba/source/torture In directory dp.samba.org:/tmp/cvs-serv26604/torture Modified Files: torture.c Log Message: Adds some more tests of renaming an open file that has been opened with different share modes. It also has a commented out test to see if we can actually open a renamed file, and it turns out that we can, it seems. I am not sure at this stage how long that is the case for, though. Revisions: torture.c 1.110 => 1.111 http://www.samba.org/cgi-bin/cvsweb/samba/source/torture/torture.c.diff?r1=1.110&r2=1.111
CVS update: samba/source/passdb
Date: Wed Feb 25 22:09:46 2004 Author: abartlet Update of /data/cvs/samba/source/passdb In directory dp.samba.org:/tmp/cvs-serv25743/source/passdb Modified Files: machine_sid.c pdb_ldap.c Log Message: (merge from 3.0) I *hate* global variables... OK, what was happening here was that we would invalidate global_sam_sid when we set the sid into secrets.tdb, to force a re-read. The problem was, we would do *two* writes into the TDB, and the second one (in the PDC/BDC case) would be of a NULL pointer. This caused smbd startups to fail, on a blank TDB. By using a local variable in the pdb_generate_sam_sid() code, we avoid this particular trap. I've also added better debugging for the case where this all matters, which is particularly for LDAP, where it finds out a domain SID from the sambaDomain object. Andrew Bartlett Revisions: machine_sid.c 1.18 => 1.19 http://www.samba.org/cgi-bin/cvsweb/samba/source/passdb/machine_sid.c.diff?r1=1.18&r2=1.19 pdb_ldap.c 1.133 => 1.134 http://www.samba.org/cgi-bin/cvsweb/samba/source/passdb/pdb_ldap.c.diff?r1=1.133&r2=1.134
CVS update: samba/source/utils
Date: Wed Feb 25 22:09:46 2004 Author: abartlet Update of /data/cvs/samba/source/utils In directory dp.samba.org:/tmp/cvs-serv25743/source/utils Modified Files: net.c smbpasswd.c Log Message: (merge from 3.0) I *hate* global variables... OK, what was happening here was that we would invalidate global_sam_sid when we set the sid into secrets.tdb, to force a re-read. The problem was, we would do *two* writes into the TDB, and the second one (in the PDC/BDC case) would be of a NULL pointer. This caused smbd startups to fail, on a blank TDB. By using a local variable in the pdb_generate_sam_sid() code, we avoid this particular trap. I've also added better debugging for the case where this all matters, which is particularly for LDAP, where it finds out a domain SID from the sambaDomain object. Andrew Bartlett Revisions: net.c 1.91 => 1.92 http://www.samba.org/cgi-bin/cvsweb/samba/source/utils/net.c.diff?r1=1.91&r2=1.92 smbpasswd.c 1.155 => 1.156 http://www.samba.org/cgi-bin/cvsweb/samba/source/utils/smbpasswd.c.diff?r1=1.155&r2=1.156
CVS update: samba/source/utils
Date: Wed Feb 25 22:01:02 2004 Author: abartlet Update of /home/cvs/samba/source/utils In directory dp.samba.org:/tmp/cvs-serv23162/utils Modified Files: Tag: SAMBA_3_0 smbpasswd.c net.c Log Message: I *hate* global variables... OK, what was happening here was that we would invalidate global_sam_sid when we set the sid into secrets.tdb, to force a re-read. The problem was, we would do *two* writes into the TDB, and the second one (in the PDC/BDC case) would be of a NULL pointer. This caused smbd startups to fail, on a blank TDB. By using a local variable in the pdb_generate_sam_sid() code, we avoid this particular trap. I've also added better debugging for the case where this all matters, which is particularly for LDAP, where it finds out a domain SID from the sambaDomain object. Andrew Bartlett Revisions: smbpasswd.c 1.140.2.19 => 1.140.2.20 http://www.samba.org/cgi-bin/cvsweb/samba/source/utils/smbpasswd.c.diff?r1=1.140.2.19&r2=1.140.2.20 net.c 1.43.2.40 => 1.43.2.41 http://www.samba.org/cgi-bin/cvsweb/samba/source/utils/net.c.diff?r1=1.43.2.40&r2=1.43.2.41
CVS update: samba/source/passdb
Date: Wed Feb 25 22:01:02 2004 Author: abartlet Update of /home/cvs/samba/source/passdb In directory dp.samba.org:/tmp/cvs-serv23162/passdb Modified Files: Tag: SAMBA_3_0 machine_sid.c pdb_ldap.c Log Message: I *hate* global variables... OK, what was happening here was that we would invalidate global_sam_sid when we set the sid into secrets.tdb, to force a re-read. The problem was, we would do *two* writes into the TDB, and the second one (in the PDC/BDC case) would be of a NULL pointer. This caused smbd startups to fail, on a blank TDB. By using a local variable in the pdb_generate_sam_sid() code, we avoid this particular trap. I've also added better debugging for the case where this all matters, which is particularly for LDAP, where it finds out a domain SID from the sambaDomain object. Andrew Bartlett Revisions: machine_sid.c 1.9.2.7 => 1.9.2.8 http://www.samba.org/cgi-bin/cvsweb/samba/source/passdb/machine_sid.c.diff?r1=1.9.2.7&r2=1.9.2.8 pdb_ldap.c 1.28.2.103 => 1.28.2.104 http://www.samba.org/cgi-bin/cvsweb/samba/source/passdb/pdb_ldap.c.diff?r1=1.28.2.103&r2=1.28.2.104
CVS update: samba/source/smbd
Date: Wed Feb 25 21:37:22 2004 Author: jra Update of /data/cvs/samba/source/smbd In directory dp.samba.org:/tmp/cvs-serv19609/smbd Modified Files: Tag: SAMBA_3_0 reply.c Log Message: Fixup strange rename error case (gentest). Jeremy. Revisions: reply.c 1.381.2.64 => 1.381.2.65 http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/reply.c.diff?r1=1.381.2.64&r2=1.381.2.65
CVS update: samba/source/smbd
Date: Wed Feb 25 21:37:09 2004 Author: jra Update of /data/cvs/samba/source/smbd In directory dp.samba.org:/tmp/cvs-serv19585/smbd Modified Files: reply.c Log Message: Fixup strange rename error case (gentest). Jeremy. Revisions: reply.c 1.445 => 1.446 http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/reply.c.diff?r1=1.445&r2=1.446
CVS update: samba/source/rpc_server
Date: Wed Feb 25 20:02:47 2004 Author: jmcd Update of /home/cvs/samba/source/rpc_server In directory dp.samba.org:/tmp/cvs-serv3349/rpc_server Modified Files: Tag: SAMBA_3_0 srv_samr_nt.c Log Message: Do the query part of the previous fix...reset time and duration are set in minutes, not seconds. Works from usrmgr. Revisions: srv_samr_nt.c 1.86.2.69 => 1.86.2.70 http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_samr_nt.c.diff?r1=1.86.2.69&r2=1.86.2.70
CVS update: samba/source/rpc_server
Date: Wed Feb 25 20:02:41 2004 Author: jmcd Update of /home/cvs/samba/source/rpc_server In directory dp.samba.org:/tmp/cvs-serv/rpc_server Modified Files: srv_samr_nt.c Log Message: Do the query part of the previous fix...reset time and duration are set in minutes, not seconds. Works from usrmgr. Revisions: srv_samr_nt.c 1.174 => 1.175 http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_samr_nt.c.diff?r1=1.174&r2=1.175
CVS update: samba/source/rpc_server
Date: Wed Feb 25 15:02:55 2004 Author: jmcd Update of /home/cvs/samba/source/rpc_server In directory dp.samba.org:/tmp/cvs-serv12770/rpc_server Modified Files: Tag: SAMBA_3_0 srv_samr_nt.c Log Message: reset time and duration are set in minutes, not seconds. Works from usrmgr. Revisions: srv_samr_nt.c 1.86.2.68 => 1.86.2.69 http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_samr_nt.c.diff?r1=1.86.2.68&r2=1.86.2.69
CVS update: samba/source/rpc_server
Date: Wed Feb 25 15:01:38 2004 Author: jmcd Update of /home/cvs/samba/source/rpc_server In directory dp.samba.org:/tmp/cvs-serv12577/rpc_server Modified Files: srv_samr_nt.c Log Message: reset time and duration are set in minutes, not seconds. Works from usrmgr. Revisions: srv_samr_nt.c 1.173 => 1.174 http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_server/srv_samr_nt.c.diff?r1=1.173&r2=1.174
