Re: [SCM] Samba Shared Repository branch, v3-2-test, updated. initial-v3-2-unstable-4-gbe91677
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Gerald (Jerry) Carter schrieb: The branch, v3-2-test has been updated via be916777da8c681c393b817105e3dfe8a9c4ef12 (commit) from 631464e2651e33812e43fe59c1e49c5d71f9621a (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. Hi, can remove this useless block, I always start to read that and in the middle of the 2nd line I realize that it's not a commit message Does anyone thing it's usefull? metze -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFHDx4cm70gjA5TCD8RAv2YAKCkgmpfN/Hdb0/zjFePiiQCkaQwVACfeoAE 2o1qwUtz84mOYCpilcPiEx4= =nVhO -END PGP SIGNATURE-
svn commit: samba r25622 - in branches/SAMBA_4_0/source/selftest: .
Author: metze Date: 2007-10-12 08:08:46 + (Fri, 12 Oct 2007) New Revision: 25622 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=25622 Log: let --socket-wrapper-keep-pcap imply --socket-wrapper-pcap metze Modified: branches/SAMBA_4_0/source/selftest/selftest.pl Changeset: Modified: branches/SAMBA_4_0/source/selftest/selftest.pl === --- branches/SAMBA_4_0/source/selftest/selftest.pl 2007-10-12 01:25:52 UTC (rev 25621) +++ branches/SAMBA_4_0/source/selftest/selftest.pl 2007-10-12 08:08:46 UTC (rev 25622) @@ -407,6 +407,10 @@ # Required for smbscript: $ENV{PATH} = $old_pwd/bin:$old_pwd:$ENV{PATH}; +if ($opt_socket_wrapper_keep_pcap) { + # Socket wrapper keep pcap implies socket wrapper pcap + $opt_socket_wrapper_pcap = 1; +} if ($opt_socket_wrapper_pcap) { # Socket wrapper pcap implies socket wrapper
[SCM] Samba Shared Repository - branch v3-2-test updated
The branch, v3-2-test has been updated via 4f084efd6ac39a8347d5cfc73b727940e40150cf (commit) from 12c0b1d82802ccd1b272a8b47ddb7d258e10477c (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 4f084efd6ac39a8347d5cfc73b727940e40150cf Author: Stefan Metzmacher [EMAIL PROTECTED] Date: Fri Oct 12 10:06:27 2007 +0200 offsetof() is always present as shown in some libreplace testing. metze --- Summary of changes: source/lib/tdb/common/tdb_private.h |4 1 files changed, 0 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source/lib/tdb/common/tdb_private.h b/source/lib/tdb/common/tdb_private.h index 032b0ca..d2f2c23 100644 --- a/source/lib/tdb/common/tdb_private.h +++ b/source/lib/tdb/common/tdb_private.h @@ -37,10 +37,6 @@ typedef uint32_t tdb_len_t; typedef uint32_t tdb_off_t; -#ifndef offsetof -#define offsetof(t,f) ((unsigned int)((t *)0)-f) -#endif - #define TDB_MAGIC_FOOD TDB file\n #define TDB_VERSION (0x26011967 + 6) #define TDB_MAGIC (0x26011999U) -- Samba Shared Repository
svn commit: samba r25623 - in branches/SAMBA_4_0/source: .
Author: metze Date: 2007-10-12 08:10:12 + (Fri, 12 Oct 2007) New Revision: 25623 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=sambarev=25623 Log: add 'make test-swrap-pcap' and 'make test-swrap-keep-pcap' metze Modified: branches/SAMBA_4_0/source/main.mk Changeset: Modified: branches/SAMBA_4_0/source/main.mk === --- branches/SAMBA_4_0/source/main.mk 2007-10-12 08:08:46 UTC (rev 25622) +++ branches/SAMBA_4_0/source/main.mk 2007-10-12 08:10:12 UTC (rev 25623) @@ -303,6 +303,12 @@ test-swrap: everything $(SELFTEST) --socket-wrapper --immediate $(TESTS) +test-swrap-pcap: everything + $(SELFTEST) --socket-wrapper-pcap --immediate $(TESTS) + +test-swrap-keep-pcap: everything + $(SELFTEST) --socket-wrapper-keep-pcap --immediate $(TESTS) + test-noswrap: everything $(SELFTEST) --immediate $(TESTS)
Re: [SCM] Samba Shared Repository branch, v3-2-test, updated. initial-v3-2-unstable-4-gbe91677
Stefan (metze) Metzmacher пишет: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Gerald (Jerry) Carter schrieb: The branch, v3-2-test has been updated via be916777da8c681c393b817105e3dfe8a9c4ef12 (commit) from 631464e2651e33812e43fe59c1e49c5d71f9621a (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. Hi, can remove this useless block, I always start to read that and in the middle of the 2nd line I realize that it's not a commit message Does anyone thing it's usefull? I think we could just leave the URL. Commit's SHA1 is already mentioned in the log message. 8 lines less is a good net result. :-) -- / Alexander Bokovoy Samba Team http://www.samba.org/ ALT Linux Team http://www.altlinux.org/ Midgard Project Ry http://www.midgard-project.org/
Re: [SCM] Samba Shared Repository - branch v3-2-test updated
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Can we also have more uniqueness in the subject line? It looks funny to have all commits as part of one huge thread. Guenther - -- Günther DeschnerGPG-ID: 8EE11688 Red Hat [EMAIL PROTECTED] Samba Team [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFHDy9CSOk3aI7hFogRAi2jAJ90a2jHUeuVCG7rQvBSo8eIxGx/twCeJZO8 UjMoMiNuCRN3mvcPyWx2u8o= =/NiA -END PGP SIGNATURE-
[SCM] Samba Shared Repository - branch v3-2-test updated
The branch, v3-2-test has been updated via 4dfda879a3ad44be7008702b9fbefe3858436118 (commit) from 4f084efd6ac39a8347d5cfc73b727940e40150cf (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 4dfda879a3ad44be7008702b9fbefe3858436118 Author: Günther Deschner [EMAIL PROTECTED] Date: Fri Oct 12 11:37:03 2007 +0200 Fix the build WITH_DNS_UPDATES. Jeremy, please have a look. Guenther --- Summary of changes: source/utils/net_dns.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source/utils/net_dns.c b/source/utils/net_dns.c index 716192b..8b82a96 100644 --- a/source/utils/net_dns.c +++ b/source/utils/net_dns.c @@ -157,8 +157,14 @@ int get_my_ip_address( struct in_addr **ips ) } for ( i=0; in; i++ ) { - if (!is_loopback_ip_v4(nics[i].iface_addr.ip.s_addr)) { - memcpy( list[count++], nics[i].iface_addr.ip, sizeof( struct in_addr ) ); + if ((nics[i].ip.ss_family == AF_INET)) { + struct in_addr ifip; + + ifip = ((const struct sockaddr_in *)nics[i].ip)-sin_addr; + + if (!is_loopback_ip_v4(ifip)) { + memcpy(list[count++], ifip, sizeof(struct in_addr)); + } } } *ips = list; -- Samba Shared Repository
Re: [SCM] Samba Shared Repository - branch v3-2-test updated
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Guenther Deschner wrote: Can we also have more uniqueness in the subject line? It looks funny to have all commits as part of one huge thread. We did but didn't you ask to have the initial-v3-2-test-#-$HASH part removed? I'll add it back in for now. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHD2oUIR7qMdg1EfYRAm5vAKDvubKsDeqOd4T7R9gy1SpmEOHjFwCgn32C a+bthnBaEj945qd69R2LSLs= =Ng5M -END PGP SIGNATURE-
Re: [SCM] Samba Shared Repository - branch v3-2-test updated
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Gerald (Jerry) Carter wrote: Guenther Deschner wrote: Can we also have more uniqueness in the subject line? It looks funny to have all commits as part of one huge thread. We did but didn't you ask to have the initial-v3-2-test-#-$HASH part removed? I'll add it back in for now. No, that wasn't me. Thanks for re-adding. Now have a good day with your family! Guenther - -- Günther DeschnerGPG-ID: 8EE11688 Red Hat [EMAIL PROTECTED] Samba Team [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFHD3POSOk3aI7hFogRAqX4AJwOxpTRwVNEo2J2lP4/CWR8cF1X1wCgm75j pPvyhqT71DZHpZfynVz3FTU= =XP7J -END PGP SIGNATURE-
Re: [SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-24-g016795c
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 simo schrieb: On Fri, 2007-10-12 at 16:07 +0200, Stefan (metze) Metzmacher wrote: that's wrong as a function is also possible, and now we have no correct string contant in version.h and version.c breaks: time for trying 'git revert g016795c' :-) I had the impression you can't revert once pushed. git revert creates a new commit, but can't do: git reset --hard HEAD^ git push as this would not be a fast-forward metze -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFHD4yzm70gjA5TCD8RApZhAJ96D4Z/a3+axGnV84wsNqmJr2Fc+gCgohVF kDV+bRFuU80aJpGOTPeU+xs= =A3+U -END PGP SIGNATURE-
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-28-g754671b
The branch, v3-2-test has been updated via 754671b8be0bf73a9e1fe7ff420a1b7a1cd501b7 (commit) via 4ac867f5588e902358eba7bcb4dbfd431181943d (commit) from 9475993dae06fa023f2eb63d04d5f7b07b0b4d93 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit 754671b8be0bf73a9e1fe7ff420a1b7a1cd501b7 Merge: 9475993dae06fa023f2eb63d04d5f7b07b0b4d93 4ac867f5588e902358eba7bcb4dbfd431181943d Author: Jelmer Vernooij [EMAIL PROTECTED] Date: Fri Oct 12 19:41:01 2007 +0200 Merge branch 'v3-2-stable' into my_branch commit 4ac867f5588e902358eba7bcb4dbfd431181943d Author: Jelmer Vernooij [EMAIL PROTECTED] Date: Fri Oct 12 18:42:45 2007 +0200 Fix valgrind window title. --- Summary of changes: source/Makefile.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/Makefile.in b/source/Makefile.in index 50ad4d6..ea1b69b 100644 --- a/source/Makefile.in +++ b/source/Makefile.in @@ -2028,7 +2028,7 @@ test: all torture timelimit valgrindtest: all torture timelimit @echo Running Test suite with valgrind - @NMBD_VALGRIND=xterm -n smbd -e valgrind -q --db-attach=yes --num-callers=30 \ + @NMBD_VALGRIND=xterm -n nmbd -e valgrind -q --db-attach=yes --num-callers=30 \ SMBD_VALGRIND=xterm -n smbd -e valgrind -q --db-attach=yes --num-callers=30 \ VALGRIND=valgrind -q --num-callers=30 --log-file=${selftest_prefix}/st/valgrind.log \ $(srcdir)/script/tests/selftest.sh ${selftest_prefix}/st all ${smbtorture4_path} -- Samba Shared Repository
Re: [SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-24-g016795c
On Fri, 2007-10-12 at 16:07 +0200, Stefan (metze) Metzmacher wrote: that's wrong as a function is also possible, and now we have no correct string contant in version.h and version.c breaks: time for trying 'git revert g016795c' :-) I had the impression you can't revert once pushed. Simo. -- Simo Sorce Samba Team GPL Compliance Officer [EMAIL PROTECTED] Senior Software Engineer at Red Hat Inc. [EMAIL PROTECTED]
[SCM] Samba Shared Repository - branch v3-0-test updated - initial-v3-0-unstable-5-g02cf538
The branch, v3-0-test has been updated via 02cf5380e2deec1eaf10e8c1f393a1ddeee181d9 (commit) from 0fa0c924bbea430de9ea2f38ed9d6f4d6dff2fef (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test - Log - commit 02cf5380e2deec1eaf10e8c1f393a1ddeee181d9 Author: Stefan Metzmacher [EMAIL PROTECTED] Date: Fri Oct 12 16:46:24 2007 +0200 cleanup and extent .gitignore metze (cherry picked from commit 9475993dae06fa023f2eb63d04d5f7b07b0b4d93) --- Summary of changes: .gitignore |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/.gitignore b/.gitignore index e350ef7..d5e5177 100644 --- a/.gitignore +++ b/.gitignore @@ -1,7 +1,6 @@ *.o *.po source/client/client_proto.h -source/groupdb/mapping.po source/include/build_env.h source/include/config.h source/include/config.h.in @@ -12,7 +11,6 @@ source/Makefile source/config.log source/config.status source/configure -source/dynconfig.po source/smbadduser source/bin/* source/script/findsmb @@ -23,7 +21,11 @@ source/smbd/build_options.c source/utils/net_proto.h source/utils/ntlm_auth_proto.h source/web/swat_proto.h -source/nsswitch/winbindd_proto.h source/tags source/utils/passwd_proto.h source/include/includes.h.gch +source/config.cache +source/library-versions +source/nsswitch/*.so +source/proto_exists +source/winbindd/winbindd_proto.h -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-26-g9475993
The branch, v3-2-test has been updated via 9475993dae06fa023f2eb63d04d5f7b07b0b4d93 (commit) from 3a1b0965229facdeab8ddc68e72bd4c5bbec70ac (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit 9475993dae06fa023f2eb63d04d5f7b07b0b4d93 Author: Stefan Metzmacher [EMAIL PROTECTED] Date: Fri Oct 12 16:46:24 2007 +0200 cleanup and extent .gitignore metze --- Summary of changes: .gitignore |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/.gitignore b/.gitignore index e350ef7..d5e5177 100644 --- a/.gitignore +++ b/.gitignore @@ -1,7 +1,6 @@ *.o *.po source/client/client_proto.h -source/groupdb/mapping.po source/include/build_env.h source/include/config.h source/include/config.h.in @@ -12,7 +11,6 @@ source/Makefile source/config.log source/config.status source/configure -source/dynconfig.po source/smbadduser source/bin/* source/script/findsmb @@ -23,7 +21,11 @@ source/smbd/build_options.c source/utils/net_proto.h source/utils/ntlm_auth_proto.h source/web/swat_proto.h -source/nsswitch/winbindd_proto.h source/tags source/utils/passwd_proto.h source/include/includes.h.gch +source/config.cache +source/library-versions +source/nsswitch/*.so +source/proto_exists +source/winbindd/winbindd_proto.h -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-25-g3a1b096
The branch, v3-2-test has been updated via 3a1b0965229facdeab8ddc68e72bd4c5bbec70ac (commit) from 016795c550ee0b78fa46c508703fb5e1e40d8f36 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit 3a1b0965229facdeab8ddc68e72bd4c5bbec70ac Author: Michael Adam [EMAIL PROTECTED] Date: Fri Oct 12 16:15:28 2007 +0200 Revert Remove superfluous quotation marks around samba version This reverts commit 016795c550ee0b78fa46c508703fb5e1e40d8f36. These quotation marks are not superfluous at all... sorry! Michael --- Summary of changes: source/VERSION |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/VERSION b/source/VERSION index d34a625..858b627 100644 --- a/source/VERSION +++ b/source/VERSION @@ -95,5 +95,5 @@ SAMBA_VERSION_IS_GIT_SNAPSHOT=yes # e.g. SAMBA_VERSION_VENDOR_SUFFIX=vendor_version()# # - CVS 3.0.0rc2-VendorVersion# -SAMBA_VERSION_VENDOR_SUFFIX=test +SAMBA_VERSION_VENDOR_SUFFIX=test SAMBA_VENDOR_PATCH= -- Samba Shared Repository
Re: [SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-24-g016795c
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 diff --git a/source/VERSION b/source/VERSION index 858b627..d34a625 100644 --- a/source/VERSION +++ b/source/VERSION @@ -95,5 +95,5 @@ SAMBA_VERSION_IS_GIT_SNAPSHOT=yes # e.g. SAMBA_VERSION_VENDOR_SUFFIX=vendor_version()# # - CVS 3.0.0rc2-VendorVersion# -SAMBA_VERSION_VENDOR_SUFFIX=test +SAMBA_VERSION_VENDOR_SUFFIX=test SAMBA_VENDOR_PATCH= Hi Michael, that's wrong as a function is also possible, and now we have no correct string contant in version.h and version.c breaks: time for trying 'git revert g016795c' :-) Compiling lib/version.c lib/version.c: In function ‘samba_version_string’: lib/version.c:38: error: ‘test’ undeclared (first use in this function) lib/version.c:38: error: (Each undeclared identifier is reported only once lib/version.c:38: error: for each function it appears in.) lib/version.c:31: warning: unused variable ‘remaining’ lib/version.c:29: warning: unused variable ‘tmp_version’ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFHD3+Qm70gjA5TCD8RApCuAJ9K4nYOm0BOR3gawi0hjObXm2eFkACeNMvA dHbFvvqXNLtsF7wQMuXAby0= =txJF -END PGP SIGNATURE-
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-24-g016795c
The branch, v3-2-test has been updated via 016795c550ee0b78fa46c508703fb5e1e40d8f36 (commit) from e68671b59500d7e1b645c80ee264c49893f8df84 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 016795c550ee0b78fa46c508703fb5e1e40d8f36 Author: Michael Adam [EMAIL PROTECTED] Date: Fri Oct 12 14:39:35 2007 +0200 Remove superfluous quotation marks around samba version vendor suffix. Michael --- Summary of changes: source/VERSION |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/VERSION b/source/VERSION index 858b627..d34a625 100644 --- a/source/VERSION +++ b/source/VERSION @@ -95,5 +95,5 @@ SAMBA_VERSION_IS_GIT_SNAPSHOT=yes # e.g. SAMBA_VERSION_VENDOR_SUFFIX=vendor_version()# # - CVS 3.0.0rc2-VendorVersion# -SAMBA_VERSION_VENDOR_SUFFIX=test +SAMBA_VERSION_VENDOR_SUFFIX=test SAMBA_VENDOR_PATCH= -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated
The branch, v3-2-test has been updated via e68671b59500d7e1b645c80ee264c49893f8df84 (commit) from 4dfda879a3ad44be7008702b9fbefe3858436118 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e68671b59500d7e1b645c80ee264c49893f8df84 Author: Michael Adam [EMAIL PROTECTED] Date: Fri Oct 12 13:20:07 2007 +0200 Add become_root/unbecome_root around one call of getsampwsid() in create_token_from_username(). This caused set_nt_acl to partially fail in certain circumstances. This is expected to bring an improvement to bug #4308. Michael --- Summary of changes: source/auth/auth_util.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/auth/auth_util.c b/source/auth/auth_util.c index 325b05f..2c05f04 100644 --- a/source/auth/auth_util.c +++ b/source/auth/auth_util.c @@ -721,6 +721,7 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username, } if (sid_check_is_in_our_domain(user_sid)) { + BOOL ret; /* This is a passdb user, so ask passdb */ @@ -731,7 +732,11 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username, goto done; } - if (!pdb_getsampwsid(sam_acct, user_sid)) { + become_root(); + ret = pdb_getsampwsid(sam_acct, user_sid); + unbecome_root(); + + if (!ret) { DEBUG(1, (pdb_getsampwsid(%s) for user %s failed\n, sid_string_static(user_sid), username)); DEBUGADD(1, (Fall back to unix user %s\n, username)); -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-0-test updated
The branch, v3-0-test has been updated via 0f633851537b689b0ac57b041d97115b6158546f (commit) from b16e4e16340eaa8d93651ba816937e8040b85e95 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 0f633851537b689b0ac57b041d97115b6158546f Author: Michael Adam [EMAIL PROTECTED] Date: Fri Oct 12 13:34:09 2007 +0200 Add become_root/unbecome_root around one call of getsampwsid() in create_token_from_username(). This caused set_nt_acl to partially fail in certain circumstances. This is expected to bring an improvement to bug #4308. Michael --- Summary of changes: source/auth/auth_util.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/auth/auth_util.c b/source/auth/auth_util.c index 1c53447..6fbec48 100644 --- a/source/auth/auth_util.c +++ b/source/auth/auth_util.c @@ -1116,6 +1116,7 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username, } if (sid_check_is_in_our_domain(user_sid)) { + BOOL ret; /* This is a passdb user, so ask passdb */ @@ -1126,7 +1127,11 @@ NTSTATUS create_token_from_username(TALLOC_CTX *mem_ctx, const char *username, goto done; } - if (!pdb_getsampwsid(sam_acct, user_sid)) { + become_root(); + ret = pdb_getsampwsid(sam_acct, user_sid); + unbecome_root(); + + if (!ret) { DEBUG(1, (pdb_getsampwsid(%s) for user %s failed\n, sid_string_static(user_sid), username)); DEBUGADD(1, (Fall back to unix user %s\n, username)); -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-0-test updated - initial-v3-0-unstable-4-g0fa0c92
The branch, v3-0-test has been updated via 0fa0c924bbea430de9ea2f38ed9d6f4d6dff2fef (commit) from 0f633851537b689b0ac57b041d97115b6158546f (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test - Log - commit 0fa0c924bbea430de9ea2f38ed9d6f4d6dff2fef Author: Michael Adam [EMAIL PROTECTED] Date: Fri Oct 12 16:35:46 2007 +0200 Add .gitignore file from v3-2-test. Michael --- Summary of changes: .gitignore | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) create mode 100644 .gitignore Changeset truncated at 500 lines: diff --git a/.gitignore b/.gitignore new file mode 100644 index 000..e350ef7 --- /dev/null +++ b/.gitignore @@ -0,0 +1,29 @@ +*.o +*.po +source/client/client_proto.h +source/groupdb/mapping.po +source/include/build_env.h +source/include/config.h +source/include/config.h.in +source/include/proto.h +source/include/stamp-h +source/include/version.h +source/Makefile +source/config.log +source/config.status +source/configure +source/dynconfig.po +source/smbadduser +source/bin/* +source/script/findsmb +source/script/gen-8bit-gap.sh +source/script/installbin.sh +source/script/uninstallbin.sh +source/smbd/build_options.c +source/utils/net_proto.h +source/utils/ntlm_auth_proto.h +source/web/swat_proto.h +source/nsswitch/winbindd_proto.h +source/tags +source/utils/passwd_proto.h +source/include/includes.h.gch -- Samba Shared Repository
Build status as of Sat Oct 13 00:00:02 2007
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2007-10-12 00:01:02.0 + +++ /home/build/master/cache/broken_results.txt 2007-10-13 00:01:03.0 + @@ -1,4 +1,4 @@ -Build status as of Fri Oct 12 00:00:02 2007 +Build status as of Sat Oct 13 00:00:02 2007 Build counts: Tree Total Broken Panic @@ -7,8 +7,8 @@ ccache 30 10 0 ctdb 0 0 0 distcc 1 0 0 -ldb 30 7 0 -libreplace 29 9 0 +ldb 30 6 0 +libreplace 29 10 0 lorikeet-heimdal 23 14 0 pidl 17 4 0 ppp 10 7 0 @@ -18,8 +18,8 @@ samba-gtk2 2 0 samba4 27 19 4 samba_3_229 28 2 -samba_3_2_test 24 24 0 +samba_3_2_test 25 25 0 smb-build29 29 0 -talloc 30 2 0 +talloc 30 1 0 tdb 30 3 0
[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-30-ga1166e9
The branch, v3-2-test has been updated via a1166e9e651f4acdcf7926c5d8e9cf0c9108fe71 (commit) from 3403c6c330b886c86d6d856c3ffc13b043fd6fc1 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit a1166e9e651f4acdcf7926c5d8e9cf0c9108fe71 Author: Jeremy Allison [EMAIL PROTECTED] Date: Fri Oct 12 21:50:41 2007 -0700 Dummy formatting commit to check I've set up my home git correctly. --- Summary of changes: source/lib/util_sock.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/lib/util_sock.c b/source/lib/util_sock.c index 8c5d1b6..8079932 100644 --- a/source/lib/util_sock.c +++ b/source/lib/util_sock.c @@ -1846,8 +1846,9 @@ bool is_myname_or_ipaddr(const char *s) fstring name, dnsname; char *servername; - if ( !s ) + if ( !s ) { return false; + } /* santize the string from '\\name' */ -- Samba Shared Repository