[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2782-gbdbc8f8
The branch, v3-2-test has been updated via bdbc8f821063df8f612b83ce6c903270fa985cbf (commit) from afe139e3272b324df2dec2d4066b351b03792dc8 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit bdbc8f821063df8f612b83ce6c903270fa985cbf Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 08:21:13 2008 +0200 WHATSNEW: Update changes since 3.2.0. Karolin --- Summary of changes: WHATSNEW.txt |4 1 files changed, 4 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index befa12f..20b3ad2 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -47,6 +47,10 @@ o Jeremy Allison [EMAIL PROTECTED] * Fix uninitialized variable. +o Yannick Bergeron [EMAIL PROTECTED] +* Fix compile error on AIX 6.1 + + o Jim Brown [EMAIL PROTECTED] * Fix SGI compiler warnings. -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-stable updated - release-3-2-0-110-g5915ec8
The branch, v3-2-stable has been updated via 5915ec88a2b704d0970902d9716570037bf0a3e2 (commit) via a794e5f1907cf8c948b2f451411f91ea0c146e97 (commit) from 5d5e171ecc1e7f61f5d5ce2449fb5abd6d3b8f44 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-stable - Log - commit 5915ec88a2b704d0970902d9716570037bf0a3e2 Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 08:21:13 2008 +0200 WHATSNEW: Update changes since 3.2.0. Karolin (cherry picked from commit bdbc8f821063df8f612b83ce6c903270fa985cbf) commit a794e5f1907cf8c948b2f451411f91ea0c146e97 Author: Yannick Bergeron [EMAIL PROTECTED] Date: Mon Aug 4 13:21:02 2008 -0400 Compile error on AIX 6.1 (cherry picked from commit afe139e3272b324df2dec2d4066b351b03792dc8) --- Summary of changes: WHATSNEW.txt |4 source/utils/net_rpc_samsync.c | 16 2 files changed, 12 insertions(+), 8 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index befa12f..20b3ad2 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -47,6 +47,10 @@ o Jeremy Allison [EMAIL PROTECTED] * Fix uninitialized variable. +o Yannick Bergeron [EMAIL PROTECTED] +* Fix compile error on AIX 6.1 + + o Jim Brown [EMAIL PROTECTED] * Fix SGI compiler warnings. diff --git a/source/utils/net_rpc_samsync.c b/source/utils/net_rpc_samsync.c index 38852b1..13a7bce 100644 --- a/source/utils/net_rpc_samsync.c +++ b/source/utils/net_rpc_samsync.c @@ -2019,7 +2019,7 @@ static NTSTATUS fetch_database_to_ldif(struct rpc_pipe_client *pipe_hnd, { char *suffix; const char *builtin_sid = S-1-5-32; - char *add_name = NULL, *mod_name = NULL; + char *add_name = NULL, *mod_filename = NULL; const char *add_template = /tmp/add.ldif.XX; const char *mod_template = /tmp/mod.ldif.XX; fstring sid, domainname; @@ -2064,8 +2064,8 @@ static NTSTATUS fetch_database_to_ldif(struct rpc_pipe_client *pipe_hnd, } add_name = talloc_strdup(mem_ctx, add_template); - mod_name = talloc_strdup(mem_ctx, mod_template); - if (!add_name || !mod_name) { + mod_filename = talloc_strdup(mem_ctx, mod_template); + if (!add_name || !mod_filename) { ret = NT_STATUS_NO_MEMORY; goto done; } @@ -2076,8 +2076,8 @@ static NTSTATUS fetch_database_to_ldif(struct rpc_pipe_client *pipe_hnd, ret = NT_STATUS_UNSUCCESSFUL; goto done; } - if (!(mod_file = fdopen(smb_mkstemp(mod_name),w))) { - DEBUG(1, (Could not open %s\n, mod_name)); + if (!(mod_file = fdopen(smb_mkstemp(mod_filename),w))) { + DEBUG(1, (Could not open %s\n, mod_filename)); ret = NT_STATUS_UNSUCCESSFUL; goto done; } @@ -2315,10 +2315,10 @@ static NTSTATUS fetch_database_to_ldif(struct rpc_pipe_client *pipe_hnd, fclose(mod_file); } - if ((mod_name != NULL) - strcmp(mod_name, mod_template) (unlink(mod_name))) { + if ((mod_filename != NULL) + strcmp(mod_filename, mod_template) (unlink(mod_filename))) { DEBUG(1,(unlink(%s) failed, error was (%s)\n, -mod_name, strerror(errno))); +mod_filename, strerror(errno))); } if (ldif_file (ldif_file != stdout)) { -- Samba Shared Repository
svn commit: samba-web r1209 - in trunk: . history
Author: kseeger Date: 2008-08-05 09:28:00 + (Tue, 05 Aug 2008) New Revision: 1209 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-webrev=1209 Log: -Announce Samba 3.2.1 -Move announcements for 3.2.0 and 3.0.30 to history Karolin Added: trunk/history/samba-3.2.1.html Modified: trunk/header_columns.html trunk/history/index.html trunk/index.html Changeset: Modified: trunk/header_columns.html === --- trunk/header_columns.html 2008-07-31 08:34:59 UTC (rev 1208) +++ trunk/header_columns.html 2008-08-05 09:28:00 UTC (rev 1209) @@ -130,9 +130,9 @@ div class=releases h4Current Stable Release/h4 ul -lia href=/samba/ftp/stable/samba-3.2.0.tar.gzSamba 3.2.0 (gzipped)/a/li -lia href=/samba/history/samba-3.2.0.htmlRelease Notes/a/li -lia href=/samba/ftp/stable/samba-3.2.0.tar.ascSignature/a/li +lia href=/samba/ftp/stable/samba-3.2.1.tar.gzSamba 3.2.1 (gzipped)/a/li +lia href=/samba/history/samba-3.2.1.htmlRelease Notes/a/li +lia href=/samba/ftp/stable/samba-3.2.1.tar.ascSignature/a/li /ul h4Historical/h4 Modified: trunk/history/index.html === --- trunk/history/index.html2008-07-31 08:34:59 UTC (rev 1208) +++ trunk/history/index.html2008-08-05 09:28:00 UTC (rev 1209) @@ -6,8 +6,8 @@ div class=latest ul - liLatest Release mdash; a href=/samba/#latestSamba 3.2.0/a/li - liCurrent Stable Release mdash; a href=/samba/#latestSamba 3.2.0/a/li + liLatest Release mdash; a href=/samba/#latestSamba 3.2.1/a/li + liCurrent Stable Release mdash; a href=/samba/#latestSamba 3.2.1/a/li !-- Second link will point to #stable on this page when current release is a development release -- /ul /div @@ -17,7 +17,37 @@ h2Previous Release Announcements/h2 +h428 May 2008/h4 +p class=headlineSamba 3.0.30 Available for Download/p +pThis is a security release to address CVE-2008-1105. The +a href=/samba/security/CVE-2008-1105.htmloriginal advisory/a +is available online. A a href=/samba/ftp/patches/security/samba-3.0.29- +CVE-2008-1105.patchpatch for Samba 3.0.29/a is available. This security +advisory is applicable to all Samba 3.0.x releases to date. Past security +advisories are available on our a href=/samba/security/security page/a./p + +pThe uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +a href=/samba/ftp/stable/samba-3.0.30.tar.gzdownloaded now/a. +See a href=/samba/history/samba-3.0.30.htmlthe release notes for more info/a./p + + +h41 July 2008/h4 +p class=headlineSamba 3.2.0 Available for Download/p + +pThis is the first stable release of Samba 3.2.0./p + +pPlease be aware that Samba is now distributed under version 3 +of the new GNU General Public License. You may refer to the COPYING +file that accompanies the release source for further licensing details./p + +pThe uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +a href=/samba/ftp/stable/samba-3.2.0.tar.gzdownloaded now/a. +See a href=/samba/history/samba-3.2.0.htmlthe release notes for more info/a./p + + h410 June 2008/h4 p class=headlineSamba 3.2.0rc2 Available for Download/p Copied: trunk/history/samba-3.2.1.html (from rev 1207, trunk/history/samba-3.2.0.html) === --- trunk/history/samba-3.2.0.html 2008-07-10 21:06:43 UTC (rev 1207) +++ trunk/history/samba-3.2.1.html 2008-08-05 09:28:00 UTC (rev 1209) @@ -0,0 +1,151 @@ +!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Transitional//EN +http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd; +html xmlns=http://www.w3.org/1999/xhtml; + +head +titleSamba - Release Notes Archive/title +/head + +body + + H2Samba 3.2.1 Available for Download/H2 + +p +pre + == + Release Notes for Samba 3.2.1 + August 5, 2008 + == + + +This is the second stable release of Samba 3.2. + +Major bug fixes included in Samba 3.2.1 are: + + o Race condition in Winbind leading to a crash. + o Regression in Winbindd offline mode. + o Flushing of smb.conf when creating a new share using SWAT. + o Setting of ACEs in setups with dos filemode = yes. + + +## +Changes +### + +Changes since 3.2.0 +--- + + +o Michael Adam [EMAIL PROTECTED] +* BUG 5608: Fix link creation for libtalloc.so.1 (and friends) on + Solaris 8. +* BUG 5594: Fix make test by adding and using a new testparm + switch --skip-logic-checks. +* Fix creation of libaddns.a, libsmbclient.a and libsharemodes.a. +* Update the section about net conf in the net(8) manpage. +* Improve
svn commit: samba-web r1210 - in trunk/history: .
Author: kseeger Date: 2008-08-05 10:28:51 + (Tue, 05 Aug 2008) New Revision: 1210 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-webrev=1210 Log: Fix german umlauts Karolin Modified: trunk/history/samba-3.2.1.html Changeset: Modified: trunk/history/samba-3.2.1.html === --- trunk/history/samba-3.2.1.html 2008-08-05 09:28:00 UTC (rev 1209) +++ trunk/history/samba-3.2.1.html 2008-08-05 10:28:51 UTC (rev 1210) @@ -70,7 +70,7 @@ * Fix SGI compiler warnings. -o Günther Deschner [EMAIL PROTECTED] +o Guenther Deschner [EMAIL PROTECTED] * BUG 5616: Fix session keys also in rpccli_netr_LogonSamLogonEx wrapper. * BUG 5570: Fix bogus error message during AD domain join. * Fix trusted domain handling in Winbindd. @@ -117,7 +117,7 @@ * Fix overwriting of winbind logfiles. -o Lars Müller [EMAIL PROTECTED] +o Lars Mueller [EMAIL PROTECTED] * Fix vfs_full_audit.c: name table not in sync with vfs.h panic.
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3533-ge61c696
The branch, v3-3-test has been updated via e61c6963cc25883c0b6e7e20596723397e294807 (commit) from ba18af00cc79a4e92372d3c1151061f200bc0655 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit e61c6963cc25883c0b6e7e20596723397e294807 Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 12:55:20 2008 +0200 README.Coding: A few minor fixes. Karolin --- Summary of changes: README.Coding |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/README.Coding b/README.Coding index fd52dbe..52ecf0e 100644 --- a/README.Coding +++ b/README.Coding @@ -1,5 +1,5 @@ ## -## Coding conventions in the Samba 3.0 tree +## Coding conventions in the Samba 3 tree ## === @@ -7,11 +7,11 @@ Quick Start === Coding style guidelines are about reducing the number of unnecessary -reformatting patches and making things easier developers to work together. +reformatting patches and making things easier for developers to work together. You don't have to like them or even agree with them, but once put in place we all have to abide by them (or vote to change them). However, coding style should never outweigh coding itself and so the the guidelines -described here are hopefully easier enough to follow as they are very +described here are hopefully easy enough to follow as they are very common and supported by tools and editors. The basic style, also mentioned in the SAMBA_4_0/prog_guide.txt is the -- Samba Shared Repository
svn commit: samba-web r1212 - in trunk/history: .
Author: kseeger Date: 2008-08-05 11:39:56 + (Tue, 05 Aug 2008) New Revision: 1212 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-webrev=1212 Log: Fix order of entries in the history Karolin Modified: trunk/history/index.html Changeset: Modified: trunk/history/index.html === --- trunk/history/index.html2008-08-05 10:35:45 UTC (rev 1211) +++ trunk/history/index.html2008-08-05 11:39:56 UTC (rev 1212) @@ -17,22 +17,6 @@ h2Previous Release Announcements/h2 -h428 May 2008/h4 -p class=headlineSamba 3.0.30 Available for Download/p - -pThis is a security release to address CVE-2008-1105. The -a href=/samba/security/CVE-2008-1105.htmloriginal advisory/a -is available online. A a href=/samba/ftp/patches/security/samba-3.0.29- -CVE-2008-1105.patchpatch for Samba 3.0.29/a is available. This security -advisory is applicable to all Samba 3.0.x releases to date. Past security -advisories are available on our a href=/samba/security/security page/a./p - -pThe uncompressed tarballs and patch files have been signed -using GnuPG (ID 6568B7EA). The source code can be -a href=/samba/ftp/stable/samba-3.0.30.tar.gzdownloaded now/a. -See a href=/samba/history/samba-3.0.30.htmlthe release notes for more info/a./p - - h41 July 2008/h4 p class=headlineSamba 3.2.0 Available for Download/p @@ -69,6 +53,22 @@ a href=/samba/ftp/Binary_Packages/Binary_Packages download area/a./p +h428 May 2008/h4 +p class=headlineSamba 3.0.30 Available for Download/p + +pThis is a security release to address CVE-2008-1105. The +a href=/samba/security/CVE-2008-1105.htmloriginal advisory/a +is available online. A a href=/samba/ftp/patches/security/samba-3.0.29- +CVE-2008-1105.patchpatch for Samba 3.0.29/a is available. This security +advisory is applicable to all Samba 3.0.x releases to date. Past security +advisories are available on our a href=/samba/security/security page/a./p + +pThe uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +a href=/samba/ftp/stable/samba-3.0.30.tar.gzdownloaded now/a. +See a href=/samba/history/samba-3.0.30.htmlthe release notes for more info/a./p + + h421 May 2008/h4 p class=headlineSamba 3.0.29 Available for Download/p
[SCM] Samba Shared Repository - annotated tag release-3-2-1 created - release-3-2-1
The annotated tag, release-3-2-1 has been created at 39ddbe49410884071b20722b68446bd6b3fa9b19 (tag) tagging 5915ec88a2b704d0970902d9716570037bf0a3e2 (commit) replaces release-3-2-0 tagged by Karolin Seeger on Tue Aug 5 08:48:21 2008 +0200 - Log - tag release-3-2-1 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQBIl/fEbzORW2Vot+oRAt1vAKCihCoUFoXHP7vfKmjtY5xvJykVHACfRTbX UaI6XAbyLX7aZEDZ7sVkHro= =KuHe -END PGP SIGNATURE- Alexander Bokovoy (1): Fix link to Using Samba Andreas Schneider (2): Release still reachable memory if the smbclient context is freed. Remove trailing withespace from wbinfo -m which breaks gdm auth. Bo Yang (1): Allow %u parameters for print job username - use advanced sub Christoph Zauner (1): man pages: Fix typos and add improvements. Günther Deschner (5): Fix build warning. libnetjoin: fix Bug #5570. libwbclient: let wbcStringToSid handle the global NULL sid. winbindd: handle trusted domains without sid. rpc_client: Bug 5616 - fix session keys also in rpccli_netr_LogonSamLogonEx wrapper. Herb Lewis (5): fix comment typo and change some uint32 to uint32_t use variables for files used in multiple places cleanup some dup code by passing the password to the wbinfo_auth* allow SID with 0 in subauthority to be converted properly get rid of unused variable warnings when HAVE_IPV6 not defined Jeremy Allison (20): Fix problem noticed by Jim Brown [EMAIL PROTECTED]. When reverse searching decrement index, Two more fixes from Jim Brown [EMAIL PROTECTED] for SGI compiler warnings. Jim Brown [EMAIL PROTECTED] was right, this needs to be a signed int or MSG_DEBUG now forwarded to all the winbindd children by parent. Ensure consistent use of pdb_get_nt_passwd instead of pdb_get_lanman_passwd. Fix bug #5578, reported by [EMAIL PROTECTED] Bad (non-Samba) use of strlcat gives error. Canonicalize servername in the printer functions to remove leading '\\' characters. Ensure we always return consistent names. Remove worrying warning message when safe_strcpy tries to copy a pseaudo interface Patch from SATOH Fumiyasu [EMAIL PROTECTED] for bug #5202. Re-activate acl group control Allow authentication and memory credential refresh after password change from gdm/xdm. Patch from boyang [EMAIL PROTECTED]. Fix option processing in smbcacls - add POPT_COMMON_CONNECTION. Add fix from Simo for bug #5540 - missing code to substitute Fix swat. Bug #5613. Fix from Volodymyr Khomenko [EMAIL PROTECTED]. Make ntimes From Jim McDonough Use sys_getgrnam not getgrnam. Pointed out by Herb. Remove test changes added in error. If we're not allowing streams on this conn ptr, Fix bug creating files using DOS clients with mixed Fix uninitialized variable. John H Terpstra (1): pdb_ldap: Raise level for debug message to avoid log file flooding. Karolin Seeger (16): VERSION: Raise version number to 3.2.1. WHATSNEW: Update changes since 3.2.0. WHATSNEW: Update changes since 3.2.0. man pages: Add missing whitespace. Fix typo. WHATSNEW: Update changes since 3.2.0. smbldap: Fix typo in debug message. WHATSNEW: Update changes since 3.2.0. man pages: printcap name is a global parameter, not a share specific one. talloc_string_sub2: Don't return NULL if src is empty. WHATSNEW: Update changes since 3.2.0. WHATSNEW: Update changes since 3.2.0. man pages: Fix typos in man smbclient. WHATSNEW: Update changes since 3.2.0. Samba3 HowTo: Fix duplicate chapter id. WHATSNEW: Update changes since 3.2.0. Lars Müller (1): Add SMB_VFS_OP_RECVFILE to get it in sync with vfs.h Michael Adam (40): build: fix creation of libsmbsharemodes.a - don't link in libtdb.a. build: fix creation of libsmbclient.a - don't link in libtalloc.a build: fix creation of libaddns.a - don't link in libtalloc.a testsuite: fix expr typo in net registry testscript. testsuite: fix another expr typo in net registry test script. docs: update the section about net conf in the net(8) manpage. docs: fix VERSION section in the net(8) manpage. docs: fix the net conf section of net(8) to mention config backend = registry. build: fix bug #5608: link creation for libtalloc.so.1 (and friends) on solaris 8 loadparm: refactor initalization of registry config out into lp_smbconf_ctx(). loadparm: refactor processing of service out of process_registry_globals() loadparm: add a function process_registry_shares() loadparm: add parameter allow_registry_shares to lp_load_ex(). loadparm: add call to do_section() to process_registry_service().
svn commit: samba-web r1211 - in trunk/history: .
Author: kseeger Date: 2008-08-05 10:35:45 + (Tue, 05 Aug 2008) New Revision: 1211 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-webrev=1211 Log: Add missing links to release notes Karolin Modified: trunk/history/header_history.html Changeset: Modified: trunk/history/header_history.html === --- trunk/history/header_history.html 2008-08-05 10:28:51 UTC (rev 1210) +++ trunk/history/header_history.html 2008-08-05 10:35:45 UTC (rev 1211) @@ -77,6 +77,11 @@ div class=notes h6Release Notes/h6 ul +lia href=samba-3.2.1.htmlsamba-3.2.1/a/li +lia href=samba-3.2.0.htmlsamba-3.2.0/a/li +lia href=samba-3.0.31.htmlsamba-3.0.31/a/li +lia href=samba-3.0.30.htmlsamba-3.0.30/a/li +lia href=samba-3.0.29.htmlsamba-3.0.29/a/li lia href=samba-3.0.28a.htmlsamba-3.0.28a/a/li lia href=samba-3.0.28.htmlsamba-3.0.28/a/li lia href=samba-3.0.27a.htmlsamba-3.0.27a/a/li
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3534-g0a93fd2
The branch, v3-3-test has been updated via 0a93fd2dedfa7fed1ad0b8a5e079bf7be72a4bd5 (commit) from e61c6963cc25883c0b6e7e20596723397e294807 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit 0a93fd2dedfa7fed1ad0b8a5e079bf7be72a4bd5 Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 14:10:11 2008 +0200 man pages: Add documentation about smbclient command rename. This fixes bug #5268. Thanks to Alexander Franz a.franz [at] gmx.net for reporting! Karolin --- Summary of changes: docs-xml/manpages-3/smbclient.1.xml |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/manpages-3/smbclient.1.xml b/docs-xml/manpages-3/smbclient.1.xml index 5096e7d..e2662cc 100644 --- a/docs-xml/manpages-3/smbclient.1.xml +++ b/docs-xml/manpages-3/smbclient.1.xml @@ -929,6 +929,13 @@ /varlistentry varlistentry + termrename lt;old filenamegt; lt;new filenamegt;/term + listitemparaRename files in the current working directory on the + server from replaceableold filename/replaceable to + replaceablenew filename/replaceable. /para/listitem + /varlistentry + + varlistentry termrm lt;maskgt;/term listitemparaRemove all files matching replaceablemask/replaceable from the current working directory on the server. /para/listitem -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3535-g8195ca2
The branch, v3-3-test has been updated via 8195ca2132cbdba396dc35e9d04d4bdc3a8a666c (commit) from 0a93fd2dedfa7fed1ad0b8a5e079bf7be72a4bd5 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit 8195ca2132cbdba396dc35e9d04d4bdc3a8a666c Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 14:20:32 2008 +0200 man pages: Improve description of boolean values in smb.conf.5. This fixes bug #5378. Thanks Morton K. Poulsen morten+bugzilla.samba.org [at] afdelingp.dk for reporting! Karolin --- Summary of changes: docs-xml/manpages-3/smb.conf.5.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/manpages-3/smb.conf.5.xml b/docs-xml/manpages-3/smb.conf.5.xml index 5c91dff..bb157e5 100644 --- a/docs-xml/manpages-3/smb.conf.5.xml +++ b/docs-xml/manpages-3/smb.conf.5.xml @@ -63,7 +63,7 @@ para The values following the equals sign in parameters are all either a string (no quotes needed) or a boolean, - which may be given as yes/no, 0/1 or true/false. Case is not significant in boolean values, but is preserved + which may be given as yes/no, 1/0 or true/false. Case is not significant in boolean values, but is preserved in string values. Some items such as create masks are numeric. /para -- Samba Shared Repository
svn commit: samba-web r1213 - in trunk: .
Author: kseeger Date: 2008-08-05 12:38:30 + (Tue, 05 Aug 2008) New Revision: 1213 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-webrev=1213 Log: Mark 3.2.1 as latest release Karolin Modified: trunk/index.html Changeset: Modified: trunk/index.html === --- trunk/index.html2008-08-05 11:39:56 UTC (rev 1212) +++ trunk/index.html2008-08-05 12:38:30 UTC (rev 1213) @@ -19,7 +19,7 @@ h2Current Release/h2 -h4a name=stable05 August 2008/a/h4 +h4a name=latest05 August 2008/a/h4 p class=headlineSamba 3.2.1 Available for Download/p pThis is the latest bug fix release for Samba 3.2 and is the
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2786-gc06ee7c
The branch, v3-2-test has been updated via c06ee7cd99c44f10fd7cf9926fe1511664f53ac3 (commit) via c6d2845fddb6eefc78435356f2d004e4dc95d803 (commit) via 6cb22c3722df8cce64d923034ffb32eb12e23572 (commit) via 29de36037d9fc4c8eb58059a9c4caccfb2b4d069 (commit) from bdbc8f821063df8f612b83ce6c903270fa985cbf (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit c06ee7cd99c44f10fd7cf9926fe1511664f53ac3 Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 15:14:51 2008 +0200 WHATSNEW: Start WHATSNEW for 3.2.2. Karolin commit c6d2845fddb6eefc78435356f2d004e4dc95d803 Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 15:13:13 2008 +0200 VERSION: Raise version number up to 3.2.2. Karolin commit 6cb22c3722df8cce64d923034ffb32eb12e23572 Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 14:20:32 2008 +0200 man pages: Improve description of boolean values in smb.conf.5. This fixes bug #5378. Thanks Morton K. Poulsen morten+bugzilla.samba.org [at] afdelingp.dk for reporting! Karolin (cherry picked from commit 8195ca2132cbdba396dc35e9d04d4bdc3a8a666c) commit 29de36037d9fc4c8eb58059a9c4caccfb2b4d069 Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 14:10:11 2008 +0200 man pages: Add documentation about smbclient command rename. This fixes bug #5268. Thanks to Alexander Franz a.franz [at] gmx.net for reporting! Karolin (cherry picked from commit 0a93fd2dedfa7fed1ad0b8a5e079bf7be72a4bd5) --- Summary of changes: WHATSNEW.txt| 122 ++- docs-xml/manpages-3/smb.conf.5.xml |2 +- docs-xml/manpages-3/smbclient.1.xml |7 ++ source/VERSION |2 +- 4 files changed, 15 insertions(+), 118 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 20b3ad2..984b097 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,133 +1,23 @@ == - Release Notes for Samba 3.2.1 - August 5, 2008 + Release Notes for Samba 3.2.2 + == -This is the second stable release of Samba 3.2. +This is the third stable release of Samba 3.2. -Major bug fixes included in Samba 3.2.1 are: +Major bug fixes included in Samba 3.2.2 are: - o Race condition in Winbind leading to a crash. - o Regression in Winbindd offline mode. - o Flushing of smb.conf when creating a new share using SWAT. - o Setting of ACEs in setups with dos filemode = yes. + o ## Changes ### -Changes since 3.2.0 +Changes since 3.2.1 --- -o Michael Adam [EMAIL PROTECTED] -* BUG 5608: Fix link creation for libtalloc.so.1 (and friends) on - Solaris 8. -* BUG 5594: Fix make test by adding and using a new testparm - switch --skip-logic-checks. -* Fix creation of libaddns.a, libsmbclient.a and libsharemodes.a. -* Update the section about net conf in the net(8) manpage. -* Improve processing of registry shares. -* Fix listing of registry shares with testparm. -* Fix several build issues. - - -o Jeremy Allison [EMAIL PROTECTED] -* BUG 5578: Fix error from strlcat. -* BUG 5613: Fix flushing of smb.conf when creating a new share using SWAT. -* Ensure consistent use of pdb_get_nt_passwd instead of - pdb_get_lanman_passwd. -* Remove worrying warning message when safe_strcpy tries to copy a - pseaudo interface name that's too long. -* Canonicalize servername in the printer functions to remove leading - '\\' characters. -* Fix option processing in smbcacls - add POPT_COMMON_CONNECTION. -* Fix bug creating files using DOS clients with mixed case files. -* Fix uninitialized variable. - - -o Yannick Bergeron [EMAIL PROTECTED] -* Fix compile error on AIX 6.1 - - -o Jim Brown [EMAIL PROTECTED] -* Fix SGI compiler warnings. - - -o Günther Deschner [EMAIL PROTECTED] -* BUG 5616: Fix session keys also in rpccli_netr_LogonSamLogonEx wrapper. -* BUG 5570: Fix bogus error message during AD domain join. -* Fix trusted domain handling in Winbindd. -* Fix build warning. - - -o SATOH Fumiyasu [EMAIL PROTECTED] -* BUG 5202: Fix setting of ACEs for users/groups with write access - in setups with 'dos filemode = yes'. -* Re-activate 'acl group control' parameter and make it only apply - to owning group. - - -o Volodymyr Khomenko [EMAIL PROTECTED] -* Make ntimes function more like POSIX and allow NULL arg. - - -o Volker Lendecke [EMAIL PROTECTED] -* BUG 5512: Fix
[SCM] Samba Shared Repository - branch v3-2-stable updated - release-3-2-1-4-gb89ce09
The branch, v3-2-stable has been updated via b89ce09ad4b2b15a3882f653f3e8d19696452330 (commit) via 347378a4185a5afad42d976b9ef1655aa12cd8aa (commit) via 6c33c8e80979dda5b96ba1cea7f00d2d37403acd (commit) via c2ba421ca0b94afdfd56e98681397cb8d97113f5 (commit) from 5915ec88a2b704d0970902d9716570037bf0a3e2 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-stable - Log - commit b89ce09ad4b2b15a3882f653f3e8d19696452330 Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 15:14:51 2008 +0200 WHATSNEW: Start WHATSNEW for 3.2.2. Karolin (cherry picked from commit c06ee7cd99c44f10fd7cf9926fe1511664f53ac3) commit 347378a4185a5afad42d976b9ef1655aa12cd8aa Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 15:13:13 2008 +0200 VERSION: Raise version number up to 3.2.2. Karolin (cherry picked from commit c6d2845fddb6eefc78435356f2d004e4dc95d803) commit 6c33c8e80979dda5b96ba1cea7f00d2d37403acd Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 14:20:32 2008 +0200 man pages: Improve description of boolean values in smb.conf.5. This fixes bug #5378. Thanks Morton K. Poulsen morten+bugzilla.samba.org [at] afdelingp.dk for reporting! Karolin (cherry picked from commit 8195ca2132cbdba396dc35e9d04d4bdc3a8a666c) (cherry picked from commit 6cb22c3722df8cce64d923034ffb32eb12e23572) commit c2ba421ca0b94afdfd56e98681397cb8d97113f5 Author: Karolin Seeger [EMAIL PROTECTED] Date: Tue Aug 5 14:10:11 2008 +0200 man pages: Add documentation about smbclient command rename. This fixes bug #5268. Thanks to Alexander Franz a.franz [at] gmx.net for reporting! Karolin (cherry picked from commit 0a93fd2dedfa7fed1ad0b8a5e079bf7be72a4bd5) (cherry picked from commit 29de36037d9fc4c8eb58059a9c4caccfb2b4d069) --- Summary of changes: WHATSNEW.txt| 122 ++- docs-xml/manpages-3/smb.conf.5.xml |2 +- docs-xml/manpages-3/smbclient.1.xml |7 ++ source/VERSION |2 +- 4 files changed, 15 insertions(+), 118 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 20b3ad2..984b097 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,133 +1,23 @@ == - Release Notes for Samba 3.2.1 - August 5, 2008 + Release Notes for Samba 3.2.2 + == -This is the second stable release of Samba 3.2. +This is the third stable release of Samba 3.2. -Major bug fixes included in Samba 3.2.1 are: +Major bug fixes included in Samba 3.2.2 are: - o Race condition in Winbind leading to a crash. - o Regression in Winbindd offline mode. - o Flushing of smb.conf when creating a new share using SWAT. - o Setting of ACEs in setups with dos filemode = yes. + o ## Changes ### -Changes since 3.2.0 +Changes since 3.2.1 --- -o Michael Adam [EMAIL PROTECTED] -* BUG 5608: Fix link creation for libtalloc.so.1 (and friends) on - Solaris 8. -* BUG 5594: Fix make test by adding and using a new testparm - switch --skip-logic-checks. -* Fix creation of libaddns.a, libsmbclient.a and libsharemodes.a. -* Update the section about net conf in the net(8) manpage. -* Improve processing of registry shares. -* Fix listing of registry shares with testparm. -* Fix several build issues. - - -o Jeremy Allison [EMAIL PROTECTED] -* BUG 5578: Fix error from strlcat. -* BUG 5613: Fix flushing of smb.conf when creating a new share using SWAT. -* Ensure consistent use of pdb_get_nt_passwd instead of - pdb_get_lanman_passwd. -* Remove worrying warning message when safe_strcpy tries to copy a - pseaudo interface name that's too long. -* Canonicalize servername in the printer functions to remove leading - '\\' characters. -* Fix option processing in smbcacls - add POPT_COMMON_CONNECTION. -* Fix bug creating files using DOS clients with mixed case files. -* Fix uninitialized variable. - - -o Yannick Bergeron [EMAIL PROTECTED] -* Fix compile error on AIX 6.1 - - -o Jim Brown [EMAIL PROTECTED] -* Fix SGI compiler warnings. - - -o Günther Deschner [EMAIL PROTECTED] -* BUG 5616: Fix session keys also in rpccli_netr_LogonSamLogonEx wrapper. -* BUG 5570: Fix bogus error message during AD domain join. -* Fix trusted domain handling in Winbindd. -* Fix build warning. - - -o SATOH Fumiyasu [EMAIL PROTECTED] -* BUG 5202: Fix setting of ACEs for users/groups with write access - in setups with
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2787-g91c17ec
The branch, v3-2-test has been updated via 91c17ecfd7b07ff948874c3eb7013eb79c5b66ab (commit) from c06ee7cd99c44f10fd7cf9926fe1511664f53ac3 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit 91c17ecfd7b07ff948874c3eb7013eb79c5b66ab Author: Andrew Bartlett [EMAIL PROTECTED] Date: Tue Jun 17 22:45:29 2008 +1000 Without stdlib.h we don't get a prototype for free(). This test fails if GCC emits any warnings (presumably to detect the function propertly), but unless we include this message then free() fail. Why we need to call free in a configure test is probably something to blame on valgrind... Andrew Bartlett (cherry picked from commit d013f6fadc3e80fabb4a1784207dabc84f9b7dc2) --- Summary of changes: source/configure.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source/configure.in b/source/configure.in index 9a230de..c2b0248 100644 --- a/source/configure.in +++ b/source/configure.in @@ -3747,6 +3747,7 @@ if test x$with_ads_support != xno; then AC_CACHE_CHECK([for krb5_error_code krb5_enctype_to_string(krb5_context context, krb5_enctype enctype, char **str)], smb_krb5_cv_enctype_to_string_takes_krb5_context_arg,[ AC_TRY_RUN_STRICT([ + #include stdlib.h #include krb5.h int main(void) { krb5_context context = NULL; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3536-g92fad0f
The branch, v3-3-test has been updated via 92fad0fc537e75c726d5d6794dd0c4fd61edca2d (commit) from 8195ca2132cbdba396dc35e9d04d4bdc3a8a666c (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit 92fad0fc537e75c726d5d6794dd0c4fd61edca2d Author: Steve French [EMAIL PROTECTED] Date: Tue Aug 5 13:15:46 2008 -0500 Backing out most of changeset 5222b8db3fb692e5071bfd1b41849a8eb0a17995 (so parsing for domain parameter in mount.cifs matches online help) and rephrasing original code to make it more clear. The check for domain was meant to allow for dom or DOM and the option (dom) described in the help (e.g. /sbin/mount.cifs -?) is the shorter (dom) form. The reason that the string we compare against is larger was to improve readability (we could compare against dom but note /* domain or DOMAIN or dom or DOM */ but it seemed terser to just show the larger string in the strcmp target. The change to workgoup from workg* (anything which begins with workg doesn't matter - it is a minor behavior change - but probably few scripts depend on the alias for this option). Rework code so that it is clearer what we are comparing against. --- Summary of changes: source/client/mount.cifs.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source/client/mount.cifs.c b/source/client/mount.cifs.c index 72ef9fe..c7009e3 100644 --- a/source/client/mount.cifs.c +++ b/source/client/mount.cifs.c @@ -517,8 +517,11 @@ static int parse_options(char ** optionsp, int * filesys_flags) printf(CIFS: UNC name too long\n); return 1; } - } else if ((strncmp(data, domain, 6) == 0) - || (strncmp(data, workgroup, 9) == 0)) { + } else if ((strncmp(data, dom /* domain */, 3) == 0) + || (strncmp(data, workg, 5) == 0)) { + /* note this allows for synonyms of domain + such as DOM and dom and workgroup + and WORKGRP etc. */ if (!value || !*value) { printf(CIFS: invalid domain name\n); return 1; /* needs_arg; */ -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3537-g24a93d0
The branch, v3-3-test has been updated via 24a93d03c2ca4e718968e2024604e0f398c96659 (commit) from 92fad0fc537e75c726d5d6794dd0c4fd61edca2d (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit 24a93d03c2ca4e718968e2024604e0f398c96659 Author: Steve French [EMAIL PROTECTED] Date: Tue Aug 5 13:27:07 2008 -0500 cifs.upcall: fix manpage and comments The cifs.resolver key type has been changed to dns_resolver. Fix the comments at the top of cifs.upcall and the manpage accordingly. Signed-off-by: Jeff Layton [EMAIL PROTECTED] Signed-off-by: Steve French [EMAIL PROTECTED] --- docs-xml/manpages-3/cifs.upcall.8.xml |4 ++-- source/client/cifs.upcall.c |8 2 files changed, 6 insertions(+), 6 deletions(-) --- Summary of changes: docs-xml/manpages-3/cifs.upcall.8.xml |4 ++-- source/client/cifs.upcall.c |8 2 files changed, 6 insertions(+), 6 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/manpages-3/cifs.upcall.8.xml b/docs-xml/manpages-3/cifs.upcall.8.xml index 8df776b..3c1bb24 100644 --- a/docs-xml/manpages-3/cifs.upcall.8.xml +++ b/docs-xml/manpages-3/cifs.upcall.8.xml @@ -72,7 +72,7 @@ to be run that way./para /varlistentry varlistentry - termcifs.resolve/term + termdns_resolver/term listitemparaThis key type is for resolving hostnames into IP addresses /para/listitem /varlistentry @@ -83,7 +83,7 @@ to be run that way./para #OPERATION TYPE D C PROGRAM ARG1 ARG2... #= = = = == create cifs.spnego* * /usr/local/sbin/cifs.upcall -c %k -create cifs.resolver * * /usr/local/sbin/cifs.upcall %k +create dns_resolver * * /usr/local/sbin/cifs.upcall %k /programlisting para See citerefentryrefentrytitlerequest-key.confmanvolnum5/manvolnum/refentrytitle/citerefentry for more info on each field. diff --git a/source/client/cifs.upcall.c b/source/client/cifs.upcall.c index 70dae1a..d6c1ddc 100644 --- a/source/client/cifs.upcall.c +++ b/source/client/cifs.upcall.c @@ -5,11 +5,11 @@ * Used by /sbin/request-key for handling * cifs upcall for kerberos authorization of access to share and * cifs upcall for DFS srver name resolving (IPv4/IPv6 aware). -* You should have keyutils installed and add following line to -* /etc/request-key.conf file +* You should have keyutils installed and add something like the +* following lines to /etc/request-key.conf file: -create cifs.spnego * * /usr/local/sbin/cifs.upcall [-v][-c] %k -create cifs.resolver * * /usr/local/sbin/cifs.upcall [-v] %k +create cifs.spnego * * /usr/local/sbin/cifs.upcall %k +create dns_resolver * * /usr/local/sbin/cifs.upcall %k * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3538-g148a012
The branch, v3-3-test has been updated via 148a012421cdd875167e708c5dfa771d97bf9856 (commit) from 24a93d03c2ca4e718968e2024604e0f398c96659 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit 148a012421cdd875167e708c5dfa771d97bf9856 Author: Steve French [EMAIL PROTECTED] Date: Tue Aug 5 15:36:11 2008 -0500 Building cifs.upcall is giving this build warning: client/cifs.upcall.c:205: warning: function declaration isnât a prototype This patch fixes this by properly declaring usage() args as void. Signed-off-by: Jeff Layton [EMAIL PROTECTED] Signed-off-by: Steve French [EMAIL PROTECTED] --- Summary of changes: source/client/cifs.upcall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/client/cifs.upcall.c b/source/client/cifs.upcall.c index d6c1ddc..5a2a22a 100644 --- a/source/client/cifs.upcall.c +++ b/source/client/cifs.upcall.c @@ -201,7 +201,7 @@ int cifs_resolver(const key_serial_t key, const char *key_descr) } void -usage() +usage(void) { syslog(LOG_WARNING, Usage: %s [-c] [-v] key_serial, prog); fprintf(stderr, Usage: %s [-c] [-v] key_serial\n, prog); -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-3543-gf8f21c8
The branch, v3-3-test has been updated via f8f21c8e3922806230e240cb54205fc2db7a3619 (commit) via bfc5d34a196f667276ce1e173821db478d01258b (commit) via 7edfb54c865ddcfd5cdcc8c2184b96aaac2d2ec0 (commit) via 72bd83fea7572a6202027b200d192c05023aa633 (commit) via 103ce6c9e94ce74e616fe922f2584fd46ae1f3f8 (commit) from 148a012421cdd875167e708c5dfa771d97bf9856 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit f8f21c8e3922806230e240cb54205fc2db7a3619 Author: Michael Adam [EMAIL PROTECTED] Date: Tue Aug 5 23:38:56 2008 +0200 dbwrap: add comment describing behaviour of dbwrap_change_int32_atomic(). Michael commit bfc5d34a196f667276ce1e173821db478d01258b Author: Michael Adam [EMAIL PROTECTED] Date: Tue Aug 5 23:14:05 2008 +0200 secrets: fix replacemend random seed generator (security issue). This is a regression introduced by the change to dbwrap. The replacement dbwrap_change_int32_atomic() does not correctly mimic the behaviour of tdb_change_int32_atomic(): The intended behaviour is to use *oldval as an initial value when the entry does not yet exist in the db and to return the old value in *oldval. The effect was that: 1. get_rand_seed() always returns sys_getpid() in *new_seed instead of the incremented seed from the secrets.tdb. 2. the seed stored in the tdb is always starting at 0 instead of sys_getpid() + 1 and incremented in subsequent calls. In principle this is a security issue, but i think the danger is low, since this is only used as a fallback when there is no useable /dev/urandom, and this is at most called on startup or via reinit_after_fork. Michael commit 7edfb54c865ddcfd5cdcc8c2184b96aaac2d2ec0 Author: Michael Adam [EMAIL PROTECTED] Date: Tue Aug 5 23:13:06 2008 +0200 dbwrap: add comment describing behaviour of dbwrap_change_uint32_atomic(). Michael commit 72bd83fea7572a6202027b200d192c05023aa633 Author: Michael Adam [EMAIL PROTECTED] Date: Tue Aug 5 22:38:44 2008 +0200 idmap_tdb2: fix a race condition in idmap_tdb2_allocate_id(). The race is a regression introduced by the change to dbwrap. It might have led to two concurrent processes returning the same id. This fix is achieved by changing dbwrap_change_uint32_atomic() to match the original behaviour of tdb_change_uint32_atomic(), which is the following: *oldval is used as initial value when the value does not yet exist and that the old value should be returned in *oldval. dbwrap_change_uint32_atomic() is used (only) in idmap_tdb2.c, to get new ids. Michael commit 103ce6c9e94ce74e616fe922f2584fd46ae1f3f8 Author: Michael Adam [EMAIL PROTECTED] Date: Mon Aug 4 23:30:16 2008 +0200 registry: use _bystring wrappers to dbwrap_trans_(store|delete). Michael --- Summary of changes: source/lib/dbwrap_util.c | 30 ++ source/registry/reg_backend_db.c |9 +++-- 2 files changed, 29 insertions(+), 10 deletions(-) Changeset truncated at 500 lines: diff --git a/source/lib/dbwrap_util.c b/source/lib/dbwrap_util.c index 07e5082..09e9071 100644 --- a/source/lib/dbwrap_util.c +++ b/source/lib/dbwrap_util.c @@ -98,6 +98,13 @@ bool dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v) return NT_STATUS_IS_OK(status) ? 0 : -1; } +/** + * Atomic unsigned integer change (addition): + * + * if value does not exist yet in the db, use *oldval as initial old value. + * return old value in *oldval. + * store *oldval + change_val to db. + */ uint32_t dbwrap_change_uint32_atomic(struct db_context *db, const char *keystr, uint32_t *oldval, uint32_t change_val) { @@ -110,9 +117,13 @@ uint32_t dbwrap_change_uint32_atomic(struct db_context *db, const char *keystr, return -1; } - if ((rec-value.dptr != NULL) -(rec-value.dsize == sizeof(val))) { + if (rec-value.dptr == NULL) { + val = *oldval; + } else if (rec-value.dsize == sizeof(val)) { val = IVAL(rec-value.dptr, 0); + *oldval = val; + } else { + return -1; } val += change_val; @@ -127,6 +138,13 @@ uint32_t dbwrap_change_uint32_atomic(struct db_context *db, const char *keystr, return 0; } +/** + * Atomic integer change (addition): + * + * if value does not exist yet in the db, use *oldval as initial old value. + * return old value in *oldval. + * store *oldval + change_val to db. + */ int32 dbwrap_change_int32_atomic(struct db_context *db, const char *keystr, int32 *oldval, int32 change_val) { @@ -139,9
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-2791-g0bdab79
The branch, v3-2-test has been updated via 0bdab793c1da9b56790d37ac7d064b67ec51e3a4 (commit) via c0e764d3878120e9612bbd847e581c6fd6c79532 (commit) via c601ad0d1c5b7f3568fef7592e501b8f6be9c469 (commit) via f3cdf9e646180837a470e90f8a17d933f07b60c3 (commit) from 91c17ecfd7b07ff948874c3eb7013eb79c5b66ab (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit 0bdab793c1da9b56790d37ac7d064b67ec51e3a4 Author: Michael Adam [EMAIL PROTECTED] Date: Tue Aug 5 23:38:56 2008 +0200 dbwrap: add comment describing behaviour of dbwrap_change_int32_atomic(). Michael (cherry picked from commit f8f21c8e3922806230e240cb54205fc2db7a3619) commit c0e764d3878120e9612bbd847e581c6fd6c79532 Author: Michael Adam [EMAIL PROTECTED] Date: Tue Aug 5 23:14:05 2008 +0200 secrets: fix replacemend random seed generator (security issue). This is a regression introduced by the change to dbwrap. The replacement dbwrap_change_int32_atomic() does not correctly mimic the behaviour of tdb_change_int32_atomic(): The intended behaviour is to use *oldval as an initial value when the entry does not yet exist in the db and to return the old value in *oldval. The effect was that: 1. get_rand_seed() always returns sys_getpid() in *new_seed instead of the incremented seed from the secrets.tdb. 2. the seed stored in the tdb is always starting at 0 instead of sys_getpid() + 1 and incremented in subsequent calls. In principle this is a security issue, but i think the danger is low, since this is only used as a fallback when there is no useable /dev/urandom, and this is at most called on startup or via reinit_after_fork. Michael (cherry picked from commit bfc5d34a196f667276ce1e173821db478d01258b) commit c601ad0d1c5b7f3568fef7592e501b8f6be9c469 Author: Michael Adam [EMAIL PROTECTED] Date: Tue Aug 5 23:13:06 2008 +0200 dbwrap: add comment describing behaviour of dbwrap_change_uint32_atomic(). Michael (cherry picked from commit 7edfb54c865ddcfd5cdcc8c2184b96aaac2d2ec0) commit f3cdf9e646180837a470e90f8a17d933f07b60c3 Author: Michael Adam [EMAIL PROTECTED] Date: Tue Aug 5 22:38:44 2008 +0200 idmap_tdb2: fix a race condition in idmap_tdb2_allocate_id(). The race is a regression introduced by the change to dbwrap. It might have led to two concurrent processes returning the same id. This fix is achieved by changing dbwrap_change_uint32_atomic() to match the original behaviour of tdb_change_uint32_atomic(), which is the following: *oldval is used as initial value when the value does not yet exist and that the old value should be returned in *oldval. dbwrap_change_uint32_atomic() is used (only) in idmap_tdb2.c, to get new ids. Michael (cherry picked from commit 72bd83fea7572a6202027b200d192c05023aa633) --- Summary of changes: source/lib/dbwrap_util.c | 30 ++ 1 files changed, 26 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source/lib/dbwrap_util.c b/source/lib/dbwrap_util.c index 07e5082..09e9071 100644 --- a/source/lib/dbwrap_util.c +++ b/source/lib/dbwrap_util.c @@ -98,6 +98,13 @@ bool dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v) return NT_STATUS_IS_OK(status) ? 0 : -1; } +/** + * Atomic unsigned integer change (addition): + * + * if value does not exist yet in the db, use *oldval as initial old value. + * return old value in *oldval. + * store *oldval + change_val to db. + */ uint32_t dbwrap_change_uint32_atomic(struct db_context *db, const char *keystr, uint32_t *oldval, uint32_t change_val) { @@ -110,9 +117,13 @@ uint32_t dbwrap_change_uint32_atomic(struct db_context *db, const char *keystr, return -1; } - if ((rec-value.dptr != NULL) -(rec-value.dsize == sizeof(val))) { + if (rec-value.dptr == NULL) { + val = *oldval; + } else if (rec-value.dsize == sizeof(val)) { val = IVAL(rec-value.dptr, 0); + *oldval = val; + } else { + return -1; } val += change_val; @@ -127,6 +138,13 @@ uint32_t dbwrap_change_uint32_atomic(struct db_context *db, const char *keystr, return 0; } +/** + * Atomic integer change (addition): + * + * if value does not exist yet in the db, use *oldval as initial old value. + * return old value in *oldval. + * store *oldval + change_val to db. + */ int32 dbwrap_change_int32_atomic(struct db_context *db, const char *keystr, int32 *oldval, int32 change_val) { @@ -139,9 +157,13 @@ int32
Build status as of Wed Aug 6 00:00:02 2008
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2008-08-05 00:00:28.0 + +++ /home/build/master/cache/broken_results.txt 2008-08-06 00:00:45.0 + @@ -1,4 +1,4 @@ -Build status as of Tue Aug 5 00:00:02 2008 +Build status as of Wed Aug 6 00:00:02 2008 Build counts: Tree Total Broken Panic @@ -9,13 +9,13 @@ ldb 33 32 0 libreplace 32 11 0 lorikeet-heimdal 25 21 0 -pidl 17 18 0 +pidl 18 18 0 ppp 11 0 0 rsync33 11 0 samba-docs 0 0 0 samba-gtk6 6 0 -samba_3_2_test 33 20 0 -samba_4_0_test 30 27 0 +samba_3_2_test 33 21 0 +samba_4_0_test 31 27 0 smb-build30 5 0 talloc 33 6 0 tdb 33 13 0
[SCM] CTDB repository - branch master updated - 84236e03e40bcf46fa634d106903277c149a734f
The branch, master has been updated via 84236e03e40bcf46fa634d106903277c149a734f (commit) via 14f2f719e6ddc266aafde4d4bf80ed3a01e145fe (commit) via b6d9a0396fb4b325778d3810dc656f719f31b9f1 (commit) via f7a70a5f9043b1d7293a515abf5b5228365693da (commit) via aefcb1f817581ac8cd67712d07159fc802f96623 (commit) via fe55bfc8fb6dc628f72f220843e829a251d09936 (commit) via 3a71844cfdb9fe69208030432ddb547b0e215726 (commit) via 306af4ccef132ea023f1f01e11f877a3a742ee4c (commit) via bad53b2d342bb9760497e6f4a61e64ca50d6e771 (commit) via 9806d18b93218c216d538e28f9ed495269f0a938 (commit) via 71d9d24abae62f70acbd7c1ded8af0b817607c2a (commit) via 12087e7d751a8756076662cd8db5dcf35316c0c5 (commit) via 2bc7f3aef4668bd1680db87ef215c349280a84f2 (commit) via aab710f1c6bcdfd8ff2992f8adc15933276dc39e (commit) via 9ff3380099fe6f4d39de126db0826971a10ee692 (commit) via d5dcb46e182466e4b51c106f2491178c23babd8d (commit) via 4d205476d286570a6e1f52b59af42858ce051106 (commit) from a9bce1ac9794f108825190948f404c864a533435 (commit) http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=master - Log - commit 84236e03e40bcf46fa634d106903277c149a734f Author: Ronnie Sahlberg [EMAIL PROTECTED] Date: Wed Aug 6 11:52:26 2008 +1000 remove the reclock file we store pnn counts in. This file creates additional locking stress on the backend filesystem and we may not need it anyway. commit 14f2f719e6ddc266aafde4d4bf80ed3a01e145fe Merge: a9bce1ac9794f108825190948f404c864a533435 b6d9a0396fb4b325778d3810dc656f719f31b9f1 Author: Ronnie Sahlberg [EMAIL PROTECTED] Date: Wed Aug 6 09:17:41 2008 +1000 Merge git://git.samba.org/tridge/ctdb --- Summary of changes: Makefile.in |7 +- client/ctdb_client.c| 334 +-- common/ctdb_ltdb.c | 59 common/ctdb_util.c | 100 +++ include/ctdb.h | 21 ++ include/ctdb_private.h | 26 ++- server/ctdb_control.c | 13 +- server/ctdb_ltdb_server.c |4 +- server/ctdb_persistent.c| 214 +++ server/ctdb_recover.c | 38 +-- server/ctdb_recoverd.c | 172 +--- tests/ctdb_persistent.c | 15 +- tests/{ctdb_persistent.c = ctdb_transaction.c} | 37 ++- tests/ctdb_traverse.c |2 +- tests/rb_test.c | 40 ++-- tests/transaction.sh| 28 ++ tools/ctdb.c| 55 tools/ctdb_vacuum.c | 18 +- 18 files changed, 743 insertions(+), 440 deletions(-) copy tests/{ctdb_persistent.c = ctdb_transaction.c} (87%) create mode 100755 tests/transaction.sh Changeset truncated at 500 lines: diff --git a/Makefile.in b/Makefile.in index 9b5ebe0..cf1240b 100755 --- a/Makefile.in +++ b/Makefile.in @@ -56,7 +56,8 @@ CTDB_SERVER_OBJ = server/ctdbd.o server/ctdb_daemon.o server/ctdb_lockwait.o \ server/ctdb_keepalive.o server/ctdb_logging.o server/ctdb_uptime.c \ $(CTDB_CLIENT_OBJ) $(CTDB_TCP_OBJ) @INFINIBAND_WRAPPER_OBJ@ -TEST_BINS=bin/ctdb_bench bin/ctdb_fetch bin/ctdb_store bin/ctdb_randrec bin/ctdb_persistent bin/ctdb_traverse bin/rb_test \ +TEST_BINS=bin/ctdb_bench bin/ctdb_fetch bin/ctdb_store bin/ctdb_randrec bin/ctdb_persistent \ + bin/ctdb_traverse bin/rb_test bin/ctdb_transaction \ @INFINIBAND_BINS@ BINS = bin/ctdb @CTDB_SCSI_IO@ bin/ctdb_ipmux bin/smnotify @@ -141,6 +142,10 @@ bin/ctdb_persistent: $(CTDB_CLIENT_OBJ) tests/ctdb_persistent.o @echo Linking $@ @$(CC) $(CFLAGS) -o $@ tests/ctdb_persistent.o $(CTDB_CLIENT_OBJ) $(LIB_FLAGS) +bin/ctdb_transaction: $(CTDB_CLIENT_OBJ) tests/ctdb_transaction.o + @echo Linking $@ + @$(CC) $(CFLAGS) -o $@ tests/ctdb_transaction.o $(CTDB_CLIENT_OBJ) $(LIB_FLAGS) + bin/ibwrapper_test: $(CTDB_CLIENT_OBJ) ib/ibwrapper_test.o @echo Linking $@ @$(CC) $(CFLAGS) -o $@ ib/ibwrapper_test.o $(CTDB_CLIENT_OBJ) $(LIB_FLAGS) diff --git a/client/ctdb_client.c b/client/ctdb_client.c index 544f5d1..d06f896 100644 --- a/client/ctdb_client.c +++ b/client/ctdb_client.c @@ -1232,29 +1232,6 @@ int ctdb_ctrl_getdbmap(struct ctdb_context *ctdb, struct timeval timeout, uint32 } /* - get the reclock filename - */ -int ctdb_ctrl_getreclock(struct ctdb_context *ctdb, struct timeval timeout, uint32_t destnode, - TALLOC_CTX *mem_ctx, const char **reclock) -{ - int ret; -
[SCM] CTDB repository - branch 1.0.52 created - a9bce1ac9794f108825190948f404c864a533435
The branch, 1.0.52 has been created at a9bce1ac9794f108825190948f404c864a533435 (commit) - Log - --- -- CTDB repository
[SCM] SAMBA-CTDB repository - branch break-samba deleted - aced114588c73161dfcd434feee6a5285ecab974
The branch, break-samba has been deleted was aced114588c73161dfcd434feee6a5285ecab974 --- aced114588c73161dfcd434feee6a5285ecab974 deliberate breakage of locking --- -- SAMBA-CTDB repository
[SCM] SAMBA-CTDB repository - branch obnox-ctdb deleted - 2e501de00f4b7415a0cfbfc7993096be8e585ca7
The branch, obnox-ctdb has been deleted was 2e501de00f4b7415a0cfbfc7993096be8e585ca7 --- 2e501de00f4b7415a0cfbfc7993096be8e585ca7 loadparm: use the return value of the special handlers in lp_load(). --- -- SAMBA-CTDB repository
[SCM] SAMBA-CTDB repository - branch ipv6 deleted - 6a949202de77399978288e988aa0bf39d983d38f
The branch, ipv6 has been deleted was 6a949202de77399978288e988aa0bf39d983d38f --- 6a949202de77399978288e988aa0bf39d983d38f work in progress for IPv6 support --- -- SAMBA-CTDB repository
[SCM] SAMBA-CTDB repository - branch v4-0-test deleted - 2e8766145ad2e8c666ecdc6c39e97ba302b16e04
The branch, v4-0-test has been deleted was 2e8766145ad2e8c666ecdc6c39e97ba302b16e04 --- 2e8766145ad2e8c666ecdc6c39e97ba302b16e04 Fail earlier on if shared libs can't be built. --- -- SAMBA-CTDB repository