Build status as of Sat Apr 18 00:00:02 2009
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2009-04-17 00:00:11.0 + +++ /home/build/master/cache/broken_results.txt 2009-04-18 00:01:00.0 + @@ -1,4 +1,4 @@ -Build status as of Fri Apr 17 00:00:02 2009 +Build status as of Sat Apr 18 00:00:02 2009 Build counts: Tree Total Broken Panic @@ -6,17 +6,17 @@ ccache 30 6 0 distcc 0 0 0 ldb 30 30 0 -libreplace 30 12 0 +libreplace 30 13 0 lorikeet 0 0 0 -pidl 20 3 0 -ppp 13 0 0 -rsync30 12 0 +pidl 19 3 0 +ppp 12 0 0 +rsync28 12 0 samba-docs 0 0 0 samba-web0 0 0 -samba_3_current 28 19 0 -samba_3_master 28 22 0 -samba_3_next 27 22 0 -samba_4_0_test 30 29 4 +samba_3_current 28 18 0 +samba_3_master 28 28 3 +samba_3_next 28 24 0 +samba_4_0_test 29 29 6 talloc 30 30 0 -tdb 28 10 0 +tdb 28 9 0
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1085-g81b1846
The branch, master has been updated
via 81b18464be170528d5e1549868bcbddbbcd60e1e (commit)
from cdbbc81bad5d53397bf80898cf68d8867cf64cba (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 81b18464be170528d5e1549868bcbddbbcd60e1e
Author: Günther Deschner
Date: Fri Apr 17 23:18:24 2009 +0200
s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.
Also add some become_root()/unbecome_root() pairs which were missing IMHO.
Guenther
---
Summary of changes:
source3/rpc_server/srv_spoolss_nt.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_server/srv_spoolss_nt.c
b/source3/rpc_server/srv_spoolss_nt.c
index 251415a..155d651 100644
--- a/source3/rpc_server/srv_spoolss_nt.c
+++ b/source3/rpc_server/srv_spoolss_nt.c
@@ -8296,7 +8296,7 @@ WERROR _spoolss_AddForm(pipes_struct *p,
/* if the user is not root, doesn't have SE_PRINT_OPERATOR privilege,
and not a printer admin, then fail */
- if ((p->server_info->utok.uid != 0) &&
+ if ((p->server_info->utok.uid != sec_initial_uid()) &&
!user_has_privileges(p->server_info->ptok, &se_printop) &&
!token_contains_name_in_list(uidtoname(p->server_info->utok.uid),
NULL, NULL,
@@ -8320,7 +8320,9 @@ WERROR _spoolss_AddForm(pipes_struct *p,
goto done;
}
+ become_root();
write_ntforms(&list, count);
+ unbecome_root();
/*
* ChangeID must always be set if this is a printer
@@ -8353,6 +8355,7 @@ WERROR _spoolss_DeleteForm(pipes_struct *p,
WERROR status = WERR_OK;
NT_PRINTER_INFO_LEVEL *printer = NULL;
SE_PRIV se_printop = SE_PRINT_OPERATOR;
+ bool ret = false;
DEBUG(5,("_spoolss_DeleteForm\n"));
@@ -8374,7 +8377,7 @@ WERROR _spoolss_DeleteForm(pipes_struct *p,
goto done;
}
- if ((p->server_info->utok.uid != 0) &&
+ if ((p->server_info->utok.uid != sec_initial_uid()) &&
!user_has_privileges(p->server_info->ptok, &se_printop) &&
!token_contains_name_in_list(uidtoname(p->server_info->utok.uid),
NULL, NULL,
@@ -8394,8 +8397,12 @@ WERROR _spoolss_DeleteForm(pipes_struct *p,
count = get_ntforms(&list);
- if ( !delete_a_form(&list, form_name, &count, &status ))
+ become_root();
+ ret = delete_a_form(&list, form_name, &count, &status);
+ unbecome_root();
+ if (ret == false) {
goto done;
+ }
/*
* ChangeID must always be set if this is a printer
@@ -8453,7 +8460,7 @@ WERROR _spoolss_SetForm(pipes_struct *p,
/* if the user is not root, doesn't have SE_PRINT_OPERATOR privilege,
and not a printer admin, then fail */
- if ((p->server_info->utok.uid != 0) &&
+ if ((p->server_info->utok.uid != sec_initial_uid()) &&
!user_has_privileges(p->server_info->ptok, &se_printop) &&
!token_contains_name_in_list(uidtoname(p->server_info->utok.uid),
NULL, NULL,
@@ -8471,7 +8478,9 @@ WERROR _spoolss_SetForm(pipes_struct *p,
count = get_ntforms(&list);
update_a_form(&list, form, count);
+ become_root();
write_ntforms(&list, count);
+ unbecome_root();
/*
* ChangeID must always be set if this is a printer
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1084-gcdbbc81
The branch, master has been updated
via cdbbc81bad5d53397bf80898cf68d8867cf64cba (commit)
via 257809558bfab3e45703cf8be76357596392a3ea (commit)
via c0dfe0cf80ee50f395912b7d6aec0d87febd34c0 (commit)
from 6f90cdaf63b5b584c96b9ffc388c9e8df172db67 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit cdbbc81bad5d53397bf80898cf68d8867cf64cba
Author: Stefan Metzmacher
Date: Fri Apr 3 12:21:17 2009 +0200
s3:docs: document the --request-timeout option of net
metze
commit 257809558bfab3e45703cf8be76357596392a3ea
Author: Stefan Metzmacher
Date: Thu Mar 26 20:32:55 2009 +0100
s3:net: add --request-timeout option
metze
commit c0dfe0cf80ee50f395912b7d6aec0d87febd34c0
Author: Stefan Metzmacher
Date: Thu Mar 26 20:29:24 2009 +0100
s3:net_rpc: don't shutdown a cli_state passed from the caller
This fixes a crash bug if we timeout in net rpc trustdom list.
metze
---
Summary of changes:
docs-xml/manpages-3/net.8.xml |9 +
source3/utils/net.c |1 +
source3/utils/net.h |1 +
source3/utils/net_rpc.c | 17 -
source3/utils/net_util.c |2 ++
5 files changed, 21 insertions(+), 9 deletions(-)
Changeset truncated at 500 lines:
diff --git a/docs-xml/manpages-3/net.8.xml b/docs-xml/manpages-3/net.8.xml
index 77d7bfb..3907f2e 100644
--- a/docs-xml/manpages-3/net.8.xml
+++ b/docs-xml/manpages-3/net.8.xml
@@ -35,6 +35,7 @@
-P
-d debuglevel
-V
+ --request-timeout seconds
@@ -125,6 +126,14 @@
+
+ --request-timeout 30
+
+ Let client requests timeout after 30 seconds the default is 10
+ seconds.
+
+
+
&stdarg.server.debug;
diff --git a/source3/utils/net.c b/source3/utils/net.c
index 7823a98..bd5107a 100644
--- a/source3/utils/net.c
+++ b/source3/utils/net.c
@@ -651,6 +651,7 @@ static struct functable net_func[] = {
{"force", 'f', POPT_ARG_NONE, &c->opt_force},
{"stdin", 'i', POPT_ARG_NONE, &c->opt_stdin},
{"timeout", 't', POPT_ARG_INT,&c->opt_timeout},
+ {"request-timeout",0,POPT_ARG_INT,&c->opt_request_timeout},
{"machine-pass",'P', POPT_ARG_NONE, &c->opt_machine_pass},
{"kerberos",'k', POPT_ARG_NONE, &c->opt_kerberos},
{"myworkgroup", 'W', POPT_ARG_STRING, &c->opt_workgroup},
diff --git a/source3/utils/net.h b/source3/utils/net.h
index 2d72756..d88f962 100644
--- a/source3/utils/net.h
+++ b/source3/utils/net.h
@@ -43,6 +43,7 @@ struct net_context {
const char *opt_container;
int opt_flags;
int opt_timeout;
+ int opt_request_timeout;
const char *opt_target_workgroup;
int opt_machine_pass;
int opt_localgroup;
diff --git a/source3/utils/net_rpc.c b/source3/utils/net_rpc.c
index ed7b2f0..0b66281 100644
--- a/source3/utils/net_rpc.c
+++ b/source3/utils/net_rpc.c
@@ -120,6 +120,7 @@ int run_rpc_command(struct net_context *c,
NTSTATUS nt_status;
DOM_SID *domain_sid;
const char *domain_name;
+ int ret = -1;
/* make use of cli_state handed over as an argument, if possible */
if (!cli_arg) {
@@ -141,15 +142,13 @@ int run_rpc_command(struct net_context *c,
if (!(mem_ctx = talloc_init("run_rpc_command"))) {
DEBUG(0, ("talloc_init() failed\n"));
- cli_shutdown(cli);
- return -1;
+ goto fail;
}
nt_status = net_get_remote_domain_sid(cli, mem_ctx, &domain_sid,
&domain_name);
if (!NT_STATUS_IS_OK(nt_status)) {
- cli_shutdown(cli);
- return -1;
+ goto fail;
}
if (!(conn_flags & NET_FLAGS_NO_PIPE)) {
@@ -164,8 +163,7 @@ int run_rpc_command(struct net_context *c,
if (!NT_STATUS_IS_OK(nt_status)) {
DEBUG(0, ("Could not initialise schannel
netlogon pipe. Error was %s\n",
nt_errstr(nt_status) ));
- cli_shutdown(cli);
- return -1;
+ goto fail;
}
} else {
if (conn_flags & NET_FLAGS_SEAL) {
@@ -183,8 +181,7 @@ int run_rpc_command(struct net_context *c,
DEBUG(0, ("Could not initialise pipe %s. Error
was %s\n",
get_pipe_name_from_iface(interface),
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1081-g6f90cdaf
The branch, master has been updated via 6f90cdaf63b5b584c96b9ffc388c9e8df172db67 (commit) from fe2828c3536eac18902a059049dd12b9b103f731 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 6f90cdaf63b5b584c96b9ffc388c9e8df172db67 Author: Günther Deschner Date: Tue Apr 14 00:01:21 2009 +0200 s3-selftest: enable RPC-SPOOLSS. Guenther --- Summary of changes: source3/script/tests/test_posix_s3.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/script/tests/test_posix_s3.sh b/source3/script/tests/test_posix_s3.sh index 8b092a7..40421fd 100755 --- a/source3/script/tests/test_posix_s3.sh +++ b/source3/script/tests/test_posix_s3.sh @@ -40,7 +40,7 @@ raw="$raw RAW-SAMBA3ROOTDIRFID" rpc="RPC-AUTHCONTEXT RPC-BINDSAMBA3 RPC-SAMBA3-SRVSVC RPC-SAMBA3-SHARESEC" rpc="$rpc RPC-SAMBA3-SPOOLSS RPC-SAMBA3-WKSSVC" rpc="$rpc RPC-NETLOGSAMBA3 RPC-SAMBA3SESSIONKEY RPC-SAMBA3-GETUSERNAME" -rpc="$rpc RPC-SVCCTL RPC-SPOOLSS-WIN RPC-NTSVCS RPC-LSA-LOOKUPSIDS " +rpc="$rpc RPC-SVCCTL RPC-SPOOLSS RPC-SPOOLSS-WIN RPC-NTSVCS RPC-LSA-LOOKUPSIDS" rpc="$rpc RPC-SAMR-PASSWORDS-PWDLASTSET RPC-JOIN" # NOTE: to enable the UNIX-WHOAMI test, we need to change the default share -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1080-gfe2828c
The branch, master has been updated
via fe2828c3536eac18902a059049dd12b9b103f731 (commit)
via 6900d61d369961e0c11e590ccdc102169f21cef3 (commit)
via 5e563ee508d0b3cc87d72ad52d777946ee0537b1 (commit)
via d76837f6da2cf735d2b18c97f3b46ae2f04b750d (commit)
from cb9c0cefaf61cf2c03f92a212dbf6673caa755dd (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit fe2828c3536eac18902a059049dd12b9b103f731
Author: Günther Deschner
Date: Fri Apr 17 17:21:19 2009 +0200
s4-smbtorture: Skip Job pause and resume on paused printers for Samba 3 for
now.
Guenther
commit 6900d61d369961e0c11e590ccdc102169f21cef3
Author: Günther Deschner
Date: Tue Apr 14 00:01:03 2009 +0200
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.
Guenther
commit 5e563ee508d0b3cc87d72ad52d777946ee0537b1
Author: Günther Deschner
Date: Tue Apr 14 00:00:37 2009 +0200
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.
Guenther
commit d76837f6da2cf735d2b18c97f3b46ae2f04b750d
Author: Günther Deschner
Date: Mon Apr 13 23:58:59 2009 +0200
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.
Guenther
---
Summary of changes:
source3/rpc_server/srv_spoolss_nt.c | 187 ++-
source4/torture/rpc/spoolss.c |8 +-
2 files changed, 192 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_server/srv_spoolss_nt.c
b/source3/rpc_server/srv_spoolss_nt.c
index d114152..251415a 100644
--- a/source3/rpc_server/srv_spoolss_nt.c
+++ b/source3/rpc_server/srv_spoolss_nt.c
@@ -4846,6 +4846,121 @@ static WERROR fill_printer_driver_info3(TALLOC_CTX
*mem_ctx,
}
/
+ * fill a spoolss_DriverInfo4 struct
+ /
+
+static WERROR fill_printer_driver_info4(TALLOC_CTX *mem_ctx,
+ struct spoolss_DriverInfo4 *r,
+ const NT_PRINTER_DRIVER_INFO_LEVEL
*driver,
+ const char *servername)
+{
+ const char *cservername = canon_servername(servername);
+
+ r->version = driver->info_3->cversion;
+
+ r->driver_name = talloc_strdup(mem_ctx, driver->info_3->name);
+ W_ERROR_HAVE_NO_MEMORY(r->driver_name);
+ r->architecture = talloc_strdup(mem_ctx,
driver->info_3->environment);
+ W_ERROR_HAVE_NO_MEMORY(r->architecture);
+
+ if (strlen(driver->info_3->driverpath)) {
+ r->driver_path = talloc_asprintf(mem_ctx, "%s%s",
+ cservername, driver->info_3->driverpath);
+ } else {
+ r->driver_path = talloc_strdup(mem_ctx, "");
+ }
+ W_ERROR_HAVE_NO_MEMORY(r->driver_path);
+
+ if (strlen(driver->info_3->datafile)) {
+ r->data_file= talloc_asprintf(mem_ctx, "%s%s",
+ cservername, driver->info_3->datafile);
+ } else {
+ r->data_file= talloc_strdup(mem_ctx, "");
+ }
+ W_ERROR_HAVE_NO_MEMORY(r->data_file);
+
+ if (strlen(driver->info_3->configfile)) {
+ r->config_file = talloc_asprintf(mem_ctx, "%s%s",
+ cservername, driver->info_3->configfile);
+ } else {
+ r->config_file = talloc_strdup(mem_ctx, "");
+ }
+ W_ERROR_HAVE_NO_MEMORY(r->config_file);
+
+ if (strlen(driver->info_3->helpfile)) {
+ r->help_file= talloc_asprintf(mem_ctx, "%s%s",
+ cservername, driver->info_3->helpfile);
+ } else {
+ r->help_file= talloc_strdup(mem_ctx, "");
+ }
+ W_ERROR_HAVE_NO_MEMORY(r->help_file);
+
+ r->dependent_files = string_array_from_driver_info(mem_ctx,
+
driver->info_3->dependentfiles,
+ cservername);
+
+
+ r->monitor_name = talloc_strdup(mem_ctx,
driver->info_3->monitorname);
+ W_ERROR_HAVE_NO_MEMORY(r->monitor_name);
+ r->default_datatype = talloc_strdup(mem_ctx,
driver->info_3->defaultdatatype);
+ W_ERROR_HAVE_NO_MEMORY(r->default_datatype);
+
+ r->previous_names = string_array_from_driver_info(mem_ctx,
+ NULL,
+ cservername);
+
+ return WERR_OK;
+}
+
+/
+ * fill a spoolss_DriverInfo5 struct
+ ***
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1076-gcb9c0ce
The branch, master has been updated
via cb9c0cefaf61cf2c03f92a212dbf6673caa755dd (commit)
from 81253ec14623ed480905433e5bf5df7982cfbfa4 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit cb9c0cefaf61cf2c03f92a212dbf6673caa755dd
Author: Günther Deschner
Date: Fri Apr 17 17:19:38 2009 +0200
s4-smbtorture: rework test_EnumPrinterDrivers() a little to succeed with s3.
Yes, I feel dirty for this but promise to come back and fix appropriately.
Guenther
---
Summary of changes:
source4/torture/rpc/spoolss.c | 25 ++---
1 files changed, 14 insertions(+), 11 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/torture/rpc/spoolss.c b/source4/torture/rpc/spoolss.c
index d17b3c7..af9fe45 100644
--- a/source4/torture/rpc/spoolss.c
+++ b/source4/torture/rpc/spoolss.c
@@ -313,7 +313,11 @@ static bool test_EnumPrinterDrivers(struct torture_context
*tctx,
uint32_t count;
union spoolss_DriverInfo *info;
- r.in.server = "";
+ /* FIXME: gd, come back and fix "" as server, and handle
+* priority of returned error codes in torture test and samba 3
+* server */
+
+ r.in.server = talloc_asprintf(tctx, "%s",
dcerpc_server_name(p));
r.in.environment= SPOOLSS_ARCHITECTURE_NT_X86;
r.in.level = level;
r.in.buffer = NULL;
@@ -331,16 +335,15 @@ static bool test_EnumPrinterDrivers(struct
torture_context *tctx,
/* TODO: do some more checks here */
continue;
}
- torture_assert_werr_equal(tctx, r.out.result,
WERR_INSUFFICIENT_BUFFER,
- "EnumPrinterDrivers failed");
-
- blob = data_blob_talloc(ctx, NULL, needed);
- data_blob_clear(&blob);
- r.in.buffer = &blob;
- r.in.offered = needed;
+ if (W_ERROR_EQUAL(r.out.result, WERR_INSUFFICIENT_BUFFER)) {
+ blob = data_blob_talloc(ctx, NULL, needed);
+ data_blob_clear(&blob);
+ r.in.buffer = &blob;
+ r.in.offered = needed;
- status = dcerpc_spoolss_EnumPrinterDrivers(p, ctx, &r);
- torture_assert_ntstatus_ok(tctx, status,
"dcerpc_spoolss_EnumPrinterDrivers failed");
+ status = dcerpc_spoolss_EnumPrinterDrivers(p, ctx, &r);
+ torture_assert_ntstatus_ok(tctx, status,
"dcerpc_spoolss_EnumPrinterDrivers failed");
+ }
torture_assert_werr_ok(tctx, r.out.result, "EnumPrinterDrivers
failed");
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1075-g81253ec
The branch, master has been updated
via 81253ec14623ed480905433e5bf5df7982cfbfa4 (commit)
from d43a49d4497f882c8f4203a4b96b88a83ad85acb (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 81253ec14623ed480905433e5bf5df7982cfbfa4
Author: Günther Deschner
Date: Fri Apr 17 17:14:20 2009 +0200
s4-smbtorture: Fix RPC-SPOOLSS-WIN for printers with a lot of jobs in the
queue.
Guenther
---
Summary of changes:
source4/torture/rpc/spoolss_win.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/torture/rpc/spoolss_win.c
b/source4/torture/rpc/spoolss_win.c
index 42b6929..719d8e2 100644
--- a/source4/torture/rpc/spoolss_win.c
+++ b/source4/torture/rpc/spoolss_win.c
@@ -290,6 +290,13 @@ static bool test_EnumJobs(struct torture_context *tctx,
status = dcerpc_spoolss_EnumJobs(p, tctx, &ej);
torture_assert_ntstatus_ok(tctx, status, "EnumJobs failed");
+ if (W_ERROR_EQUAL(ej.out.result, WERR_INSUFFICIENT_BUFFER)) {
+ blob = data_blob_talloc_zero(tctx, needed);
+ ej.in.offered = needed;
+ ej.in.buffer = &blob;
+ status = dcerpc_spoolss_EnumJobs(p, tctx, &ej);
+ torture_assert_ntstatus_ok(tctx, status, "EnumJobs failed");
+ }
torture_assert_werr_ok(tctx, ej.out.result, "EnumJobs failed");
return true;
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-stable updated - release-3-3-3-36-ga6dc4b5
The branch, v3-3-stable has been updated
via a6dc4b5dde00a1a33a96b48b592f8368dec5883c (commit)
via c5920e257dc2066e447620cc85f02241d408dcab (commit)
via 5f674ca5172001aff4b90f0f758e0767894ab29a (commit)
from dd02789ce82b2ed7e60a2168e1b0bcb6656d0ce6 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-stable
- Log -
commit a6dc4b5dde00a1a33a96b48b592f8368dec5883c
Author: Karolin Seeger
Date: Fri Apr 17 16:15:08 2009 +0200
VERSION: Raise version number up to 3.3.4.
Karolin
(cherry picked from commit a70f2928c0ceb625424af56b96ac76b74c04fa12)
commit c5920e257dc2066e447620cc85f02241d408dcab
Author: Günther Deschner
Date: Fri Apr 17 15:46:36 2009 +0200
s3-test: enable RPC-LSA-LOOKUPSIDS and RPC-JOIN during make test.
Guenther
(cherry picked from commit 79321cad54a4303abc27766101ffb52f50d64430)
commit 5f674ca5172001aff4b90f0f758e0767894ab29a
Author: Michael Adam
Date: Fri Apr 17 11:40:17 2009 +0200
s3:registry: Prevent creation of keys containing the '/' character.
This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
(cherry picked from commit 943b33587c9905e0b6b6ee090fe9bf9bdfc77465)
---
Summary of changes:
source/VERSION |2 +-
source/registry/reg_api.c| 10 ++
source/script/tests/test_posix_s3.sh |1 +
3 files changed, 12 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/VERSION b/source/VERSION
index 65dadee..56d64fa 100644
--- a/source/VERSION
+++ b/source/VERSION
@@ -25,7 +25,7 @@
SAMBA_VERSION_MAJOR=3
SAMBA_VERSION_MINOR=3
-SAMBA_VERSION_RELEASE=3
+SAMBA_VERSION_RELEASE=4
# Bug fix releases use a letter for the patch revision #
diff --git a/source/registry/reg_api.c b/source/registry/reg_api.c
index c49ee03..0f12c78 100644
--- a/source/registry/reg_api.c
+++ b/source/registry/reg_api.c
@@ -459,6 +459,16 @@ WERROR reg_createkey(TALLOC_CTX *ctx, struct registry_key
*parent,
char *path, *end;
WERROR err;
+ /*
+* We must refuse to handle subkey-paths containing
+* a '/' character because at a lower level, after
+* normalization, '/' is treated as a key separator
+* just like '\\'.
+*/
+ if (strchr(subkeypath, '/') != NULL) {
+ return WERR_INVALID_PARAM;
+ }
+
if (!(mem_ctx = talloc_new(ctx))) return WERR_NOMEM;
if (!(path = talloc_strdup(mem_ctx, subkeypath))) {
diff --git a/source/script/tests/test_posix_s3.sh
b/source/script/tests/test_posix_s3.sh
index 3e99986..3bd9d1c 100755
--- a/source/script/tests/test_posix_s3.sh
+++ b/source/script/tests/test_posix_s3.sh
@@ -38,6 +38,7 @@ raw="$raw RAW-SAMBA3ROOTDIRFID"
rpc="RPC-AUTHCONTEXT RPC-BINDSAMBA3 RPC-SAMBA3-SRVSVC RPC-SAMBA3-SHARESEC"
rpc="$rpc RPC-SAMBA3-SPOOLSS RPC-SAMBA3-WKSSVC"
rpc="$rpc RPC-NETLOGSAMBA3 RPC-SAMBA3SESSIONKEY RPC-SAMBA3-GETUSERNAME"
+rpc="$rpc RPC-LSA-LOOKUPSIDS RPC-JOIN"
# NOTE: to enable the UNIX-WHOAMI test, we need to change the default share
# config to allow guest access. I'm not sure whether this would break other
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-5223-ga70f292
The branch, v3-3-test has been updated via a70f2928c0ceb625424af56b96ac76b74c04fa12 (commit) from 79321cad54a4303abc27766101ffb52f50d64430 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit a70f2928c0ceb625424af56b96ac76b74c04fa12 Author: Karolin Seeger Date: Fri Apr 17 16:15:08 2009 +0200 VERSION: Raise version number up to 3.3.4. Karolin --- Summary of changes: source/VERSION |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source/VERSION b/source/VERSION index 4921232..5c469d6 100644 --- a/source/VERSION +++ b/source/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=3 SAMBA_VERSION_MINOR=3 -SAMBA_VERSION_RELEASE=3 +SAMBA_VERSION_RELEASE=4 # Bug fix releases use a letter for the patch revision # -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-785-g9deb558
The branch, v3-4-test has been updated via 9deb558c5a3c380c7e4964e6fd2fc1b948115078 (commit) via 81dca118cd94988f55a5b4c43436a97d04309b48 (commit) from c33e3b84a706fa429ceeea81fb17c434e8f6cb4e (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test - Log - commit 9deb558c5a3c380c7e4964e6fd2fc1b948115078 Author: Michael Adam Date: Fri Apr 17 15:53:38 2009 +0200 s3: make installmo and uninstallmo scripts executable Michael commit 81dca118cd94988f55a5b4c43436a97d04309b48 Author: Michael Adam Date: Fri Apr 17 15:29:10 2009 +0200 s3: Fix uninstallmo Michael --- Summary of changes: source3/script/uninstallmo.sh |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) mode change 100644 => 100755 source3/script/installmo.sh mode change 100644 => 100755 source3/script/uninstallmo.sh Changeset truncated at 500 lines: diff --git a/source3/script/installmo.sh b/source3/script/installmo.sh old mode 100644 new mode 100755 diff --git a/source3/script/uninstallmo.sh b/source3/script/uninstallmo.sh old mode 100644 new mode 100755 index 5b4475f..663c6b1 --- a/source3/script/uninstallmo.sh +++ b/source3/script/uninstallmo.sh @@ -1 +1,2 @@ -installmo.sh +#!/bin/sh +script/installmo.sh -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1074-gd43a49d
The branch, master has been updated via d43a49d4497f882c8f4203a4b96b88a83ad85acb (commit) via bf1b7ba480d377f6405df412d699ffee991f649c (commit) from 4f9d3400e5aa310e8071c0bb5d62ddaed1d846ee (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit d43a49d4497f882c8f4203a4b96b88a83ad85acb Author: Michael Adam Date: Fri Apr 17 15:53:38 2009 +0200 s3: make installmo and uninstallmo scripts executable Michael commit bf1b7ba480d377f6405df412d699ffee991f649c Author: Michael Adam Date: Fri Apr 17 15:29:10 2009 +0200 s3: Fix uninstallmo Michael --- Summary of changes: source3/script/uninstallmo.sh |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) mode change 100644 => 100755 source3/script/installmo.sh mode change 100644 => 100755 source3/script/uninstallmo.sh Changeset truncated at 500 lines: diff --git a/source3/script/installmo.sh b/source3/script/installmo.sh old mode 100644 new mode 100755 diff --git a/source3/script/uninstallmo.sh b/source3/script/uninstallmo.sh old mode 100644 new mode 100755 index 5b4475f..663c6b1 --- a/source3/script/uninstallmo.sh +++ b/source3/script/uninstallmo.sh @@ -1 +1,2 @@ -installmo.sh +#!/bin/sh +script/installmo.sh -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-5222-g79321ca
The branch, v3-3-test has been updated via 79321cad54a4303abc27766101ffb52f50d64430 (commit) from 943b33587c9905e0b6b6ee090fe9bf9bdfc77465 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test - Log - commit 79321cad54a4303abc27766101ffb52f50d64430 Author: Günther Deschner Date: Fri Apr 17 15:46:36 2009 +0200 s3-test: enable RPC-LSA-LOOKUPSIDS and RPC-JOIN during make test. Guenther --- Summary of changes: source/script/tests/test_posix_s3.sh |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source/script/tests/test_posix_s3.sh b/source/script/tests/test_posix_s3.sh index 3e99986..3bd9d1c 100755 --- a/source/script/tests/test_posix_s3.sh +++ b/source/script/tests/test_posix_s3.sh @@ -38,6 +38,7 @@ raw="$raw RAW-SAMBA3ROOTDIRFID" rpc="RPC-AUTHCONTEXT RPC-BINDSAMBA3 RPC-SAMBA3-SRVSVC RPC-SAMBA3-SHARESEC" rpc="$rpc RPC-SAMBA3-SPOOLSS RPC-SAMBA3-WKSSVC" rpc="$rpc RPC-NETLOGSAMBA3 RPC-SAMBA3SESSIONKEY RPC-SAMBA3-GETUSERNAME" +rpc="$rpc RPC-LSA-LOOKUPSIDS RPC-JOIN" # NOTE: to enable the UNIX-WHOAMI test, we need to change the default share # config to allow guest access. I'm not sure whether this would break other -- Samba Shared Repository
svn commit: samba-web r1289 - in trunk: . history
Author: kseeger Date: 2009-04-17 13:22:36 + (Fri, 17 Apr 2009) New Revision: 1289 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba-web&rev=1289 Log: Announce Samba 3.2.11 Karolin Added: trunk/history/samba-3.2.11.html Modified: trunk/header_columns.html trunk/index.html Changeset: Modified: trunk/header_columns.html === --- trunk/header_columns.html 2009-04-06 12:03:02 UTC (rev 1288) +++ trunk/header_columns.html 2009-04-17 13:22:36 UTC (rev 1289) @@ -137,9 +137,9 @@ Historical -Samba 3.2.10 (gzipped) -Release Notes 3.2.10 -Signature 3.2.10 +Samba 3.2.11 (gzipped) +Release Notes 3.2.11 +Signature 3.2.11 Samba 3.0.34 (gzipped) Release Notes 3.0.34 Signature 3.0.34 Added: trunk/history/samba-3.2.11.html === --- trunk/history/samba-3.2.11.html 2009-04-06 12:03:02 UTC (rev 1288) +++ trunk/history/samba-3.2.11.html 2009-04-17 13:22:36 UTC (rev 1289) @@ -0,0 +1,62 @@ +http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> +http://www.w3.org/1999/xhtml";> + + +Samba - Release Notes Archive + + + + + Samba 3.2.11 Available for Download + + + + == + Release Notes for Samba 3.2.11 + April 17, 2009 + == + + +This is a maintenance release of the Samba 3.2 series. + +Major enhancements in 3.2.11 include: + +o Fix domain logins for WinXP clients pre SP3 (bug #6263). +o Fix samr_OpenDomain access checks (bug #6089). +o Fix smbd crash for close_on_completion. + + +## +Changes +### + +Changes since 3.2.10 + + + +o Jeremy Allison +* BUG 6089: Fix samr_OpenDomain access checks. +* BUG 6254: Fix IPv6 PUT/GET errors to an SMB server (3.3) with + "msdfs root" set to "yes". +* Allow pdbedit to change a user rid/sid. +* When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid. + + +o Günther Deschner +* BUG 6205: Correct sample smb.conf share configuration. +* BUG 6263: Fix domain logins for WinXP clients pre SP3. +* Fix resume command typo for "printing = vlp". + + +o Volker Lendecke +* Fix smbd crash for close_on_completion. +* Fix a memleak in an unlikely error path in change_notify_create(). + + +o Jim McDonough +* Don't look up local user for remote changes, even when root. + + + + Property changes on: trunk/history/samba-3.2.11.html ___ Name: svn:executable + * Modified: trunk/index.html === --- trunk/index.html2009-04-06 12:03:02 UTC (rev 1288) +++ trunk/index.html2009-04-17 13:22:36 UTC (rev 1289) @@ -19,6 +19,22 @@ Current Release +17 April 2009 +Samba 3.2.11 Maintenance Release Available + +This is the latest bug fix release for Samba 3.2 and is the +version recommended for all production Samba servers running +this release series. The uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +downloaded +now. A patch against Samba 3.2.10 +is also available. This release fixes an issue which caused problems after +updates in Samba 3.2.9. See the +release notes for more info. + +31 March 2009 +Samba 3.2.9 Maintenance Release Available + 1 April 2009 Samba 3.3.3 Available for Download
[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-783-gc33e3b8
The branch, v3-4-test has been updated via c33e3b84a706fa429ceeea81fb17c434e8f6cb4e (commit) from 74385e90fa72b132088861d864cb275909ed7f6f (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test - Log - commit c33e3b84a706fa429ceeea81fb17c434e8f6cb4e Author: Günther Deschner Date: Fri Apr 17 15:13:33 2009 +0200 s3-selftest: samba 3 also passes RPC-JOIN so enable it. Guenther (cherry picked from commit 4f9d3400e5aa310e8071c0bb5d62ddaed1d846ee) --- Summary of changes: source3/script/tests/test_posix_s3.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/script/tests/test_posix_s3.sh b/source3/script/tests/test_posix_s3.sh index 093afb6..8b092a7 100755 --- a/source3/script/tests/test_posix_s3.sh +++ b/source3/script/tests/test_posix_s3.sh @@ -41,7 +41,7 @@ rpc="RPC-AUTHCONTEXT RPC-BINDSAMBA3 RPC-SAMBA3-SRVSVC RPC-SAMBA3-SHARESEC" rpc="$rpc RPC-SAMBA3-SPOOLSS RPC-SAMBA3-WKSSVC" rpc="$rpc RPC-NETLOGSAMBA3 RPC-SAMBA3SESSIONKEY RPC-SAMBA3-GETUSERNAME" rpc="$rpc RPC-SVCCTL RPC-SPOOLSS-WIN RPC-NTSVCS RPC-LSA-LOOKUPSIDS " -rpc="$rpc RPC-SAMR-PASSWORDS-PWDLASTSET" +rpc="$rpc RPC-SAMR-PASSWORDS-PWDLASTSET RPC-JOIN" # NOTE: to enable the UNIX-WHOAMI test, we need to change the default share # config to allow guest access. I'm not sure whether this would break other -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1072-g4f9d340
The branch, master has been updated via 4f9d3400e5aa310e8071c0bb5d62ddaed1d846ee (commit) from 8c023fea86d48ff2fd7990003ce2511b4263b762 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 4f9d3400e5aa310e8071c0bb5d62ddaed1d846ee Author: Günther Deschner Date: Fri Apr 17 15:13:33 2009 +0200 s3-selftest: samba 3 also passes RPC-JOIN so enable it. Guenther --- Summary of changes: source3/script/tests/test_posix_s3.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/script/tests/test_posix_s3.sh b/source3/script/tests/test_posix_s3.sh index 093afb6..8b092a7 100755 --- a/source3/script/tests/test_posix_s3.sh +++ b/source3/script/tests/test_posix_s3.sh @@ -41,7 +41,7 @@ rpc="RPC-AUTHCONTEXT RPC-BINDSAMBA3 RPC-SAMBA3-SRVSVC RPC-SAMBA3-SHARESEC" rpc="$rpc RPC-SAMBA3-SPOOLSS RPC-SAMBA3-WKSSVC" rpc="$rpc RPC-NETLOGSAMBA3 RPC-SAMBA3SESSIONKEY RPC-SAMBA3-GETUSERNAME" rpc="$rpc RPC-SVCCTL RPC-SPOOLSS-WIN RPC-NTSVCS RPC-LSA-LOOKUPSIDS " -rpc="$rpc RPC-SAMR-PASSWORDS-PWDLASTSET" +rpc="$rpc RPC-SAMR-PASSWORDS-PWDLASTSET RPC-JOIN" # NOTE: to enable the UNIX-WHOAMI test, we need to change the default share # config to allow guest access. I'm not sure whether this would break other -- Samba Shared Repository
[SCM] Samba Shared Repository - annotated tag release-3-2-11 created - release-3-2-11
The annotated tag, release-3-2-11 has been created at 907c37496586c18136a61b736aa2ddef16d48a64 (tag) tagging 47311ed9f3ed39c02ffbdf7b958135065ab7f0c2 (commit) replaces release-3-2-10 tagged by Karolin Seeger on Fri Apr 17 15:04:15 2009 +0200 - Log - tag release-3-2-11 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.9 (GNU/Linux) iD8DBQBJ6H51bzORW2Vot+oRAnftAJwL2+t8oHwSjacoSH84C5KWhIM0ZwCggJxx XxcQSvJf/3rZRzlM1vqvxYM= =4Ci4 -END PGP SIGNATURE- Guenther Deschner (1): s3-loadparm: Fix resume command typo for "printing = vlp". Günther Deschner (2): s3-examples: Fix Bug #6205. Correct sample smb.conf share configuration. s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3. Jeremy Allison (4): Allow pdbedit to change a user rid/sid. Based on a fix from Alexander Fix bug #6254 - PUT/GET produces an error in IPv6 to a smb-server(3.3) Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+ When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid. Jim McDonough (1): Don't look up local user for remote changes, even when root. Karolin Seeger (7): s3/smbconf_reg: Fix typo. s3/gpo_ldap: Fix typo. s3/loadparm: Fiy typos. s3/popt.h: Fix typo. WHATSNEW: Update changes since 3.2.10. VERSION: Raise version number upt to 3.2.11. WHATSNEW: Rewording. Michael Adam (1): packaging(RHEL): add cifs.upcall binary and manpage to client package Volker Lendecke (2): Fix smbd crash for close_on_completion Fix a memleak in an unlikely error path in change_notify_create() --- -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3559-gde6f099
The branch, v3-2-test has been updated
via de6f09988d84752e5333cba1fa69c5a685e903b7 (commit)
from 642afabf26dbb7d0f73c15c5502a90020f65a914 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit de6f09988d84752e5333cba1fa69c5a685e903b7
Author: Michael Adam
Date: Fri Apr 17 11:40:17 2009 +0200
s3:registry: Prevent creation of keys containing the '/' character.
Even though "net conf setparm abc/def comment xyz" does not
create a broken registry we do not want such keys to be created.
Since we get problems accessing these with "net registry" since
the registry code treats the '/' sign as a separator as a lower
level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
---
Summary of changes:
source/registry/reg_api.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/registry/reg_api.c b/source/registry/reg_api.c
index e9a7145..4678636 100644
--- a/source/registry/reg_api.c
+++ b/source/registry/reg_api.c
@@ -455,6 +455,16 @@ WERROR reg_createkey(TALLOC_CTX *ctx, struct registry_key
*parent,
char *path, *end;
WERROR err;
+ /*
+* We must refuse to handle subkey-paths containing
+* a '/' character because at a lower level, after
+* normalization, '/' is treated as a key separator
+* just like '\\'.
+*/
+ if (strchr(subkeypath, '/') != NULL) {
+ return WERR_INVALID_PARAM;
+ }
+
if (!(mem_ctx = talloc_new(ctx))) return WERR_NOMEM;
if (!(path = talloc_strdup(mem_ctx, subkeypath))) {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-stable updated - release-3-3-3-33-gdd02789
The branch, v3-3-stable has been updated via dd02789ce82b2ed7e60a2168e1b0bcb6656d0ce6 (commit) via ae7c1b59f0c537f0e3a689150fcab8040301fd5c (commit) via 016d6e8a077d35752448bc833ee67aa7bc886aba (commit) via 26c73280654efc1320bcfe1808ebf545d43b4487 (commit) via 40ec3c6ea77248a4d39a7f7322d9bebc41b832c8 (commit) via a2469fe6b04881a257e5f5c255e83c9cf50c19d4 (commit) via a7b1a75ba334fcde71da0a70a4ed7e007996ee17 (commit) via bb7c209b2728aa51e1660e40952510ff914bcb88 (commit) via 8bb93e555842c51a3722c46bcc8401f3944b1b3d (commit) via aec3cf3e0e4b4d6c30c88cd46d8114c8750c448b (commit) via 38ba3af879fdbca736233da45608fdaca0add9f5 (commit) via 77bc996c769a253d0fa07cd9808162372dfc73c9 (commit) via 8a74aeb1b0fc42687adede34bfc131d486b8873b (commit) via 892ffce717cf1e0ad9eed2d9ebcc4df88b58f3d8 (commit) via 54c13a6c226a6a06e64180d2fbdd29cba8fcf483 (commit) via 26d176b0019f656b9b603e670fbac2257504f432 (commit) via 9d5069129123c5e5f738cc0dbe49c6cadbfd4023 (commit) via 269799d33e06910397e407fefe7a6e84a39ac2e0 (commit) via 5e6efe9632842815dfcdcb61e3289b5ae70485c9 (commit) via e2a5386e34e2c8210e615e9d860eb6f22ea6043b (commit) via 243fd31f6d17b192cac2f12bbe6e5fa99d3b6c9a (commit) via 8b3c6220fea7d691ee0bd0c8c211624a0379ef6f (commit) via cb5a5728cc36a2232bcedb0cf64b7bdf14d7a06f (commit) via 5372102f37c5e6da2837426d64047957bc54a905 (commit) via 4190dbe13bf473ba7b8aea8503145d38e77abaea (commit) via f780afd9754181104e986eff48498925b45c0344 (commit) via 9159045951d33ae0f3e7b355a1ade5aabb0dbf72 (commit) via 9ff316ea2fb927d46878cdae4d9fa0d7a3e9fe77 (commit) via 5094f0b593741bf6a62122390d46539d5136f1a2 (commit) via 7da73d74880a3ba2bf529bc9ce8fc681887ac50c (commit) via 93aff1c36b94eb7f4912077bf42d04e37da0cf89 (commit) via ce241b6a6cf5f11e74fac3676b49dbf3564a614e (commit) via eecd4e74c5777ba6e15f67fea53c897b195150cc (commit) from ac2d88014dd7d2c09480972ab4e950cfec62b6cc (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-stable - Log - commit dd02789ce82b2ed7e60a2168e1b0bcb6656d0ce6 Author: Günther Deschner Date: Fri Apr 17 01:30:54 2009 +0200 s3-docs: fix typo in smb.conf.5. Guenther (cherry picked from commit 05ea8daacabe62b6c20770a8518192c44e7eb763) (cherry picked from commit 8dc31b185d67aa4cdcb367254a913039e3f286ee) commit ae7c1b59f0c537f0e3a689150fcab8040301fd5c Author: Günther Deschner Date: Thu Apr 16 13:03:35 2009 +0200 s3-docs: document warn_pwd_expire pam_winbind option in manpage. Andreas, please check. Guenther (cherry picked from commit 5517c0bcddfbd8c877fd1f909407824553a20e7f) (cherry picked from commit 1f5485ed8d8e50159859b2e994680dfa224d15f3) commit 016d6e8a077d35752448bc833ee67aa7bc886aba Author: Jeremy Allison Date: Thu Apr 16 16:21:00 2009 -0700 Add torture tester to ensure we don't regress the ulogoff bug. Jeremy. (cherry picked from commit e2dd445921b509a2c05646e5aece50243f2b7a5a) commit 26c73280654efc1320bcfe1808ebf545d43b4487 Author: Jeremy Allison Date: Thu Apr 16 16:20:12 2009 -0700 Fix bug found by Tim Prouty, logging off and then re-using a vuid can cause smbd to access a freed structure. Jeremy. (cherry picked from commit 043ade0f4dff788f81e014d3c85217377226899e) commit 40ec3c6ea77248a4d39a7f7322d9bebc41b832c8 Author: Jeremy Allison Date: Thu Apr 16 15:14:37 2009 -0700 When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid. Jeremy. (cherry picked from commit d7b0894c8d025ceda4b7208e134e591bc4953400) commit a2469fe6b04881a257e5f5c255e83c9cf50c19d4 Author: Jim McDonough Date: Thu Apr 16 17:04:00 2009 +0200 Don't look up local user for remote changes, even when root. (cherry picked from commit bece9b36c455de30eb601912554d43e743def6b2) commit a7b1a75ba334fcde71da0a70a4ed7e007996ee17 Author: Martin Schwenke Date: Thu Apr 16 10:25:29 2009 +1000 In net_conf_import, start a transaction when importing a single share. Commit d69c3db9d44ad5d9fd1f5d7a9499f3bd79ecfb47 caused the transaction start to be conditional but the commit is still unconditional, so an error occurs when importing a single share. An alternate fix would be to return the transaction start to be unconditional but then it would occur before other error checking. Signed-off-by: Martin Schwenke Signed-off-by: Michael Adam (cherry picked from commit 9a28b28314c6a76cf619fc5f1b676d1f4229e3e1) commit bb7c209b2728aa51e1660e40952510ff914bcb88 Author: Günther Deschner Date: Thu Apr 16 01:42:35 2009 +0200 s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3. LookupSids needs to bounce b
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-5221-g943b335
The branch, v3-3-test has been updated
via 943b33587c9905e0b6b6ee090fe9bf9bdfc77465 (commit)
from 0cc56c386476c6072f16ad0ae2bb55889b748dc7 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -
commit 943b33587c9905e0b6b6ee090fe9bf9bdfc77465
Author: Michael Adam
Date: Fri Apr 17 11:40:17 2009 +0200
s3:registry: Prevent creation of keys containing the '/' character.
This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
---
Summary of changes:
source/registry/reg_api.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/registry/reg_api.c b/source/registry/reg_api.c
index c49ee03..0f12c78 100644
--- a/source/registry/reg_api.c
+++ b/source/registry/reg_api.c
@@ -459,6 +459,16 @@ WERROR reg_createkey(TALLOC_CTX *ctx, struct registry_key
*parent,
char *path, *end;
WERROR err;
+ /*
+* We must refuse to handle subkey-paths containing
+* a '/' character because at a lower level, after
+* normalization, '/' is treated as a key separator
+* just like '\\'.
+*/
+ if (strchr(subkeypath, '/') != NULL) {
+ return WERR_INVALID_PARAM;
+ }
+
if (!(mem_ctx = talloc_new(ctx))) return WERR_NOMEM;
if (!(path = talloc_strdup(mem_ctx, subkeypath))) {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-782-g74385e9
The branch, v3-4-test has been updated
via 74385e90fa72b132088861d864cb275909ed7f6f (commit)
from 4c8d90a077901f7901b8202abed54746679aa3a9 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test
- Log -
commit 74385e90fa72b132088861d864cb275909ed7f6f
Author: Michael Adam
Date: Fri Apr 17 11:40:17 2009 +0200
s3:registry: Prevent creation of keys containing the '/' character.
This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
---
Summary of changes:
source3/registry/reg_api.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index 67767a2..c1a78c1 100644
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -459,6 +459,16 @@ WERROR reg_createkey(TALLOC_CTX *ctx, struct registry_key
*parent,
char *path, *end;
WERROR err;
+ /*
+* We must refuse to handle subkey-paths containing
+* a '/' character because at a lower level, after
+* normalization, '/' is treated as a key separator
+* just like '\\'.
+*/
+ if (strchr(subkeypath, '/') != NULL) {
+ return WERR_INVALID_PARAM;
+ }
+
if (!(mem_ctx = talloc_new(ctx))) return WERR_NOMEM;
if (!(path = talloc_strdup(mem_ctx, subkeypath))) {
--
Samba Shared Repository
[SCM] SAMBA-CTDB repository - branch v3-2-ctdb updated - build_3.2.10_ctdb.58-3-gb16d063
The branch, v3-2-ctdb has been updated
via b16d0635155ed8ef6cadba5d0faec15ddfd06736 (commit)
from 9b5be0d38099deb117e9fca996bf032f35904079 (commit)
http://gitweb.samba.org/?p=obnox/samba-ctdb.git;a=shortlog;h=v3-2-ctdb
- Log -
commit b16d0635155ed8ef6cadba5d0faec15ddfd06736
Author: Michael Adam
Date: Fri Apr 17 11:40:17 2009 +0200
s3:registry: Prevent creation of keys containing the '/' character.
This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
---
Summary of changes:
source/registry/reg_api.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/registry/reg_api.c b/source/registry/reg_api.c
index c49ee03..0f12c78 100644
--- a/source/registry/reg_api.c
+++ b/source/registry/reg_api.c
@@ -459,6 +459,16 @@ WERROR reg_createkey(TALLOC_CTX *ctx, struct registry_key
*parent,
char *path, *end;
WERROR err;
+ /*
+* We must refuse to handle subkey-paths containing
+* a '/' character because at a lower level, after
+* normalization, '/' is treated as a key separator
+* just like '\\'.
+*/
+ if (strchr(subkeypath, '/') != NULL) {
+ return WERR_INVALID_PARAM;
+ }
+
if (!(mem_ctx = talloc_new(ctx))) return WERR_NOMEM;
if (!(path = talloc_strdup(mem_ctx, subkeypath))) {
--
SAMBA-CTDB repository
[SCM] Samba Shared Repository - branch v3-2-stable updated - release-3-2-10-18-g47311ed
The branch, v3-2-stable has been updated via 47311ed9f3ed39c02ffbdf7b958135065ab7f0c2 (commit) via 5eb947acf6b34f32b97f16d8357cb0a815d1e0c7 (commit) via 53ad0364f153ca986c4ed92f102970d7b9f5695d (commit) via c47f27001fded2c3c8965b7a8539abe02d958292 (commit) via 18e2a7a2a3134d49208a0adc9530c87e0bca3eb1 (commit) via 5d755974d300cd3914e3152d51b1c4ee42817bdc (commit) via 94b4eb9525a8d0829066891fb64923021c5ffd6e (commit) via a54a868180b4545244ae0fc037c7d7b6daa3a2e8 (commit) via b50a19e20aaaf70cb2e222624f41b2c7450c7e76 (commit) via 96ed6b631fbe690ae6292b13a5a2e2478d932aca (commit) via 4f87bcbf8a7c453200cb9d0159e0c6e233d64282 (commit) via 143e418c36969d1cd2c9495698aecd4aed3c45f3 (commit) via 427e8f4780d276ee6c2c3506f5322bb327b65d6e (commit) via 70919570f1df031937f596df5e87468e77dac772 (commit) via cdb9382d1ee36639fc26556806d6c5bd4fc66cd4 (commit) via 7ce5e3ea4d692e0800931d24a791469a8e6b97d4 (commit) via dd7ec1c933cf325a8826cd524f691c61311367f7 (commit) via c9334fc37155f27a653f7b3d81e178ecf503e226 (commit) from 1b9151271f45a3d95e4aefbe11eb5f737f7c542f (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-stable - Log - commit 47311ed9f3ed39c02ffbdf7b958135065ab7f0c2 Author: Karolin Seeger Date: Fri Apr 17 11:57:41 2009 +0200 WHATSNEW: Rewording. Karolin (cherry picked from commit 642afabf26dbb7d0f73c15c5502a90020f65a914) commit 5eb947acf6b34f32b97f16d8357cb0a815d1e0c7 Author: Karolin Seeger Date: Fri Apr 17 11:52:02 2009 +0200 VERSION: Raise version number upt to 3.2.11. Karolin (cherry picked from commit aaf5c25489b916d4892ce757bb5c0f32f9910c59) commit 53ad0364f153ca986c4ed92f102970d7b9f5695d Author: Karolin Seeger Date: Fri Apr 17 10:42:31 2009 +0200 WHATSNEW: Update changes since 3.2.10. Karolin (cherry picked from commit c63dc9866e84461a7a8359958d6bcf753c51d125) commit c47f27001fded2c3c8965b7a8539abe02d958292 Author: Jeremy Allison Date: Thu Apr 16 15:14:37 2009 -0700 When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid. Jeremy. (cherry picked from commit 72f55ca71c2d9b4c24866b7e1418fa4c17948db6) commit 18e2a7a2a3134d49208a0adc9530c87e0bca3eb1 Author: Jim McDonough Date: Thu Apr 16 16:42:59 2009 +0200 Don't look up local user for remote changes, even when root. (cherry picked from commit 1c47bcb5b24ab360d5e632bbf3dcbc7d1d9f6fc4) commit 5d755974d300cd3914e3152d51b1c4ee42817bdc Author: Günther Deschner Date: Thu Apr 16 01:42:35 2009 +0200 s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3. LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED. Guenther (cherry picked from commit 597be402e40ff880b595ae49a8600b932365cbcb) (cherry picked from commit f049fb5643f93cc4806ada5db8e591bbe4cb9204) commit 94b4eb9525a8d0829066891fb64923021c5ffd6e Author: Jeremy Allison Date: Wed Apr 15 14:09:32 2009 -0700 Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+ What a difference a name makes... :-). Just because something is missnamed SA_RIGHT_SAM_OPEN_DOMAIN, when it should actually be SA_RIGHT_SAM_LOOKUP_DOMAIN, don't automatically use it for a security check in _samr_OpenDomain(). Jeremy. (cherry picked from commit 3591c95beaed3abfa10b1579e377b0103647a177) commit a54a868180b4545244ae0fc037c7d7b6daa3a2e8 Author: Michael Adam Date: Mon Sep 8 15:51:57 2008 +0200 packaging(RHEL): add cifs.upcall binary and manpage to client package Michael (cherry picked from commit f1b80bcb58b8aa5c586835dc201ce674b3417835) (cherry picked from commit b4c58d49902d62f25aa0c9289d1857aa2636c028) (cherry picked from commit 6d308951c5b0fec988685f64f040f0770b537efb) commit b50a19e20aaaf70cb2e222624f41b2c7450c7e76 Author: Guenther Deschner Date: Mon Apr 13 09:44:54 2009 -0700 s3-loadparm: Fix resume command typo for "printing = vlp". (cherry picked from commit 8203f5f3890afec3ec631f822b0f2e5ddd262b9a) commit 96ed6b631fbe690ae6292b13a5a2e2478d932aca Author: Volker Lendecke Date: Sat Apr 11 13:54:06 2009 -0700 Fix a memleak in an unlikely error path in change_notify_create() (cherry picked from commit 7284b7bb226990abce91d40782bf4e592e2f7b4d) commit 4f87bcbf8a7c453200cb9d0159e0c6e233d64282 Author: Jeremy Allison Date: Thu Apr 9 22:46:31 2009 -0700 Fix bug #6254 - PUT/GET produces an error in IPv6 to a smb-server(3.3) has parameter "msdfs root = yes" This was broken by the refactoring around create_file(). MSDFS pathname processing must be done FIRST. MSDFS pathnames containing IPv6 addresses can be confused with NTFS stream names (they contain ":" characters. Jeremy. (cherry picked from commit eb29aa4
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3558-g642afab
The branch, v3-2-test has been updated via 642afabf26dbb7d0f73c15c5502a90020f65a914 (commit) from aaf5c25489b916d4892ce757bb5c0f32f9910c59 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit 642afabf26dbb7d0f73c15c5502a90020f65a914 Author: Karolin Seeger Date: Fri Apr 17 11:57:41 2009 +0200 WHATSNEW: Rewording. Karolin --- Summary of changes: WHATSNEW.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index a3d9571..4137597 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -9,7 +9,7 @@ This is a maintenance release of the Samba 3.2 series. Major enhancements in 3.2.11 include: o Fix domain logins for WinXP clients pre SP3 (bug #6263). -o Fix Winbind samr_OpenDomain (bug #6089). +o Fix samr_OpenDomain access checks (bug #6089). o Fix smbd crash for close_on_completion. @@ -22,7 +22,7 @@ Changes since 3.2.10 o Jeremy Allison -* BUG 6089: Fix Winbind samr_OpenDomain. +* BUG 6089: Fix samr_OpenDomain access checks. * BUG 6254: Fix IPv6 PUT/GET errors to an SMB server (3.3) with "msdfs root" set to "yes". * Allow pdbedit to change a user rid/sid. -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3557-gaaf5c25
The branch, v3-2-test has been updated via aaf5c25489b916d4892ce757bb5c0f32f9910c59 (commit) via c63dc9866e84461a7a8359958d6bcf753c51d125 (commit) from dd13edf0249718b8deb5db237dd71c9d4c979019 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test - Log - commit aaf5c25489b916d4892ce757bb5c0f32f9910c59 Author: Karolin Seeger Date: Fri Apr 17 11:52:02 2009 +0200 VERSION: Raise version number upt to 3.2.11. Karolin commit c63dc9866e84461a7a8359958d6bcf753c51d125 Author: Karolin Seeger Date: Fri Apr 17 10:42:31 2009 +0200 WHATSNEW: Update changes since 3.2.10. Karolin --- Summary of changes: WHATSNEW.txt | 41 ++--- source/VERSION |2 +- 2 files changed, 31 insertions(+), 12 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index e7a0fa5..a3d9571 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,28 +1,47 @@ == - Release Notes for Samba 3.2.10 - April 1, 2009 + Release Notes for Samba 3.2.11 + April 17, 2009 == This is a maintenance release of the Samba 3.2 series. -In Samba 3.2.9, there is an issue while migrating passdb.tdb files from older -Samba versions (e.g. 3.2.8). That causes panics of smbd child processes until -the parent smbd is restarted once after converting the passdb.tdb file. This -issue is fixed in Samba 3.2.10. +Major enhancements in 3.2.11 include: + +o Fix domain logins for WinXP clients pre SP3 (bug #6263). +o Fix Winbind samr_OpenDomain (bug #6089). +o Fix smbd crash for close_on_completion. -Sorry for the inconveniences! ## Changes ### -Changes since 3.2.9 +Changes since 3.2.10 + + + +o Jeremy Allison +* BUG 6089: Fix Winbind samr_OpenDomain. +* BUG 6254: Fix IPv6 PUT/GET errors to an SMB server (3.3) with + "msdfs root" set to "yes". +* Allow pdbedit to change a user rid/sid. +* When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid. + + +o Günther Deschner +* BUG 6205: Correct sample smb.conf share configuration. +* BUG 6263: Fix domain logins for WinXP clients pre SP3. +* Fix resume command typo for "printing = vlp". + + +o Volker Lendecke +* Fix smbd crash for close_on_completion. +* Fix a memleak in an unlikely error path in change_notify_create(). -o Michael Adam -* BUG #6195: Don't let smbd child processes panic. +o Jim McDonough +* Don't look up local user for remote changes, even when root. ## diff --git a/source/VERSION b/source/VERSION index 5272e32..87a82f1 100644 --- a/source/VERSION +++ b/source/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=3 SAMBA_VERSION_MINOR=2 -SAMBA_VERSION_RELEASE=10 +SAMBA_VERSION_RELEASE=11 # Bug fix releases use a letter for the patch revision # -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1071-g8c023fe
The branch, master has been updated
via 8c023fea86d48ff2fd7990003ce2511b4263b762 (commit)
from 0ba833f3eedff5dec272eb71f3b09becd8707156 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 8c023fea86d48ff2fd7990003ce2511b4263b762
Author: Michael Adam
Date: Fri Apr 17 11:40:17 2009 +0200
s3:registry: Prevent creation of keys containing the '/' character.
This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
---
Summary of changes:
source3/registry/reg_api.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index 67767a2..c1a78c1 100644
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -459,6 +459,16 @@ WERROR reg_createkey(TALLOC_CTX *ctx, struct registry_key
*parent,
char *path, *end;
WERROR err;
+ /*
+* We must refuse to handle subkey-paths containing
+* a '/' character because at a lower level, after
+* normalization, '/' is treated as a key separator
+* just like '\\'.
+*/
+ if (strchr(subkeypath, '/') != NULL) {
+ return WERR_INVALID_PARAM;
+ }
+
if (!(mem_ctx = talloc_new(ctx))) return WERR_NOMEM;
if (!(path = talloc_strdup(mem_ctx, subkeypath))) {
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-781-g4c8d90a
The branch, v3-4-test has been updated
via 4c8d90a077901f7901b8202abed54746679aa3a9 (commit)
via 7f6094fe8238f7a146fe7c45ab31f0e2244704bd (commit)
via 93f4a4f89448f33dbcf67ebb92fd94e65579b3c4 (commit)
from afc2a0f9c860fbaee86c96e2f77b2f551727c2fd (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test
- Log -
commit 4c8d90a077901f7901b8202abed54746679aa3a9
Author: Günther Deschner
Date: Fri Apr 17 11:21:20 2009 +0200
s3-samr: set the builtin_domain bool flag in get_samr_dispinfo_by_sid().
Volker, please check.
Found by torture test RPC-SAMR-PASSWORDS-PWDLASTSET (which we pass with
this fix).
Guenther
(cherry picked from commit 0ba833f3eedff5dec272eb71f3b09becd8707156)
commit 7f6094fe8238f7a146fe7c45ab31f0e2244704bd
Author: Günther Deschner
Date: Fri Apr 17 11:14:14 2009 +0200
s3-selftest: enable RPC-SAMR-PASSWORDS-PWDLASTSET whilte testing Samba3.
Guenther
(cherry picked from commit 490f6c418d8b1280d0a3b85773a72b2047122c12)
commit 93f4a4f89448f33dbcf67ebb92fd94e65579b3c4
Author: Günther Deschner
Date: Fri Apr 17 11:04:44 2009 +0200
s4-smbtorture: disable CreateUser2 tests when running
RPC-SAMR-PASSWORDS-PWDLAST
against Samba3.
Samba 3 does not (yet) get all the ACB_flag settings right upon creation.
Guenther
(cherry picked from commit 32add69632ed4a2b877043c8df1185008516c299)
---
Summary of changes:
source3/rpc_server/srv_samr_nt.c |2 ++
source3/script/tests/test_posix_s3.sh |3 ++-
source4/torture/rpc/samr.c|4 +++-
3 files changed, 7 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_server/srv_samr_nt.c b/source3/rpc_server/srv_samr_nt.c
index b153bef..165fb17 100644
--- a/source3/rpc_server/srv_samr_nt.c
+++ b/source3/rpc_server/srv_samr_nt.c
@@ -343,6 +343,7 @@ static DISP_INFO *get_samr_dispinfo_by_sid(DOM_SID *psid)
}
}
sid_copy(&builtin_dispinfo->sid, &global_sid_Builtin);
+ builtin_dispinfo->builtin_domain = true;
return builtin_dispinfo;
}
@@ -359,6 +360,7 @@ static DISP_INFO *get_samr_dispinfo_by_sid(DOM_SID *psid)
}
}
sid_copy(&domain_dispinfo->sid, get_global_sam_sid());
+ domain_dispinfo->builtin_domain = false;
return domain_dispinfo;
}
diff --git a/source3/script/tests/test_posix_s3.sh
b/source3/script/tests/test_posix_s3.sh
index 89a7ea7..093afb6 100755
--- a/source3/script/tests/test_posix_s3.sh
+++ b/source3/script/tests/test_posix_s3.sh
@@ -40,7 +40,8 @@ raw="$raw RAW-SAMBA3ROOTDIRFID"
rpc="RPC-AUTHCONTEXT RPC-BINDSAMBA3 RPC-SAMBA3-SRVSVC RPC-SAMBA3-SHARESEC"
rpc="$rpc RPC-SAMBA3-SPOOLSS RPC-SAMBA3-WKSSVC"
rpc="$rpc RPC-NETLOGSAMBA3 RPC-SAMBA3SESSIONKEY RPC-SAMBA3-GETUSERNAME"
-rpc="$rpc RPC-SVCCTL RPC-SPOOLSS-WIN RPC-NTSVCS RPC-LSA-LOOKUPSIDS"
+rpc="$rpc RPC-SVCCTL RPC-SPOOLSS-WIN RPC-NTSVCS RPC-LSA-LOOKUPSIDS "
+rpc="$rpc RPC-SAMR-PASSWORDS-PWDLASTSET"
# NOTE: to enable the UNIX-WHOAMI test, we need to change the default share
# config to allow guest access. I'm not sure whether this would break other
diff --git a/source4/torture/rpc/samr.c b/source4/torture/rpc/samr.c
index 8af9867..9c867fd 100644
--- a/source4/torture/rpc/samr.c
+++ b/source4/torture/rpc/samr.c
@@ -5664,7 +5664,9 @@ static bool test_OpenDomain(struct dcerpc_pipe *p, struct
torture_context *tctx,
}
break;
case TORTURE_SAMR_PASSWORDS_PWDLASTSET:
- ret &= test_CreateUser2(p, tctx, &domain_handle, sid,
which_ops, machine_credentials);
+ if (!torture_setting_bool(tctx, "samba3", false)) {
+ ret &= test_CreateUser2(p, tctx, &domain_handle, sid,
which_ops, machine_credentials);
+ }
ret &= test_CreateUser(p, tctx, &domain_handle, &user_handle,
sid, which_ops, machine_credentials);
if (!ret) {
printf("Testing PASSWORDS PWDLASTSET on domain %s
failed!\n", dom_sid_string(tctx, sid));
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1070-g0ba833f
The branch, master has been updated via 0ba833f3eedff5dec272eb71f3b09becd8707156 (commit) from 490f6c418d8b1280d0a3b85773a72b2047122c12 (commit) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 0ba833f3eedff5dec272eb71f3b09becd8707156 Author: Günther Deschner Date: Fri Apr 17 11:21:20 2009 +0200 s3-samr: set the builtin_domain bool flag in get_samr_dispinfo_by_sid(). Volker, please check. Found by torture test RPC-SAMR-PASSWORDS-PWDLASTSET (which we pass with this fix). Guenther --- Summary of changes: source3/rpc_server/srv_samr_nt.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/rpc_server/srv_samr_nt.c b/source3/rpc_server/srv_samr_nt.c index b153bef..165fb17 100644 --- a/source3/rpc_server/srv_samr_nt.c +++ b/source3/rpc_server/srv_samr_nt.c @@ -343,6 +343,7 @@ static DISP_INFO *get_samr_dispinfo_by_sid(DOM_SID *psid) } } sid_copy(&builtin_dispinfo->sid, &global_sid_Builtin); + builtin_dispinfo->builtin_domain = true; return builtin_dispinfo; } @@ -359,6 +360,7 @@ static DISP_INFO *get_samr_dispinfo_by_sid(DOM_SID *psid) } } sid_copy(&domain_dispinfo->sid, get_global_sam_sid()); + domain_dispinfo->builtin_domain = false; return domain_dispinfo; } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1069-g490f6c4
The branch, master has been updated
via 490f6c418d8b1280d0a3b85773a72b2047122c12 (commit)
via 32add69632ed4a2b877043c8df1185008516c299 (commit)
from 1214bf606d1cdf3f33b91ffe7cb4c349ce737d68 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 490f6c418d8b1280d0a3b85773a72b2047122c12
Author: Günther Deschner
Date: Fri Apr 17 11:14:14 2009 +0200
s3-selftest: enable RPC-SAMR-PASSWORDS-PWDLASTSET whilte testing Samba3.
Guenther
commit 32add69632ed4a2b877043c8df1185008516c299
Author: Günther Deschner
Date: Fri Apr 17 11:04:44 2009 +0200
s4-smbtorture: disable CreateUser2 tests when running
RPC-SAMR-PASSWORDS-PWDLAST
against Samba3.
Samba 3 does not (yet) get all the ACB_flag settings right upon creation.
Guenther
---
Summary of changes:
source3/script/tests/test_posix_s3.sh |3 ++-
source4/torture/rpc/samr.c|4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/script/tests/test_posix_s3.sh
b/source3/script/tests/test_posix_s3.sh
index 89a7ea7..093afb6 100755
--- a/source3/script/tests/test_posix_s3.sh
+++ b/source3/script/tests/test_posix_s3.sh
@@ -40,7 +40,8 @@ raw="$raw RAW-SAMBA3ROOTDIRFID"
rpc="RPC-AUTHCONTEXT RPC-BINDSAMBA3 RPC-SAMBA3-SRVSVC RPC-SAMBA3-SHARESEC"
rpc="$rpc RPC-SAMBA3-SPOOLSS RPC-SAMBA3-WKSSVC"
rpc="$rpc RPC-NETLOGSAMBA3 RPC-SAMBA3SESSIONKEY RPC-SAMBA3-GETUSERNAME"
-rpc="$rpc RPC-SVCCTL RPC-SPOOLSS-WIN RPC-NTSVCS RPC-LSA-LOOKUPSIDS"
+rpc="$rpc RPC-SVCCTL RPC-SPOOLSS-WIN RPC-NTSVCS RPC-LSA-LOOKUPSIDS "
+rpc="$rpc RPC-SAMR-PASSWORDS-PWDLASTSET"
# NOTE: to enable the UNIX-WHOAMI test, we need to change the default share
# config to allow guest access. I'm not sure whether this would break other
diff --git a/source4/torture/rpc/samr.c b/source4/torture/rpc/samr.c
index 8af9867..9c867fd 100644
--- a/source4/torture/rpc/samr.c
+++ b/source4/torture/rpc/samr.c
@@ -5664,7 +5664,9 @@ static bool test_OpenDomain(struct dcerpc_pipe *p, struct
torture_context *tctx,
}
break;
case TORTURE_SAMR_PASSWORDS_PWDLASTSET:
- ret &= test_CreateUser2(p, tctx, &domain_handle, sid,
which_ops, machine_credentials);
+ if (!torture_setting_bool(tctx, "samba3", false)) {
+ ret &= test_CreateUser2(p, tctx, &domain_handle, sid,
which_ops, machine_credentials);
+ }
ret &= test_CreateUser(p, tctx, &domain_handle, &user_handle,
sid, which_ops, machine_credentials);
if (!ret) {
printf("Testing PASSWORDS PWDLASTSET on domain %s
failed!\n", dom_sid_string(tctx, sid));
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1067-g1214bf6
The branch, master has been updated
via 1214bf606d1cdf3f33b91ffe7cb4c349ce737d68 (commit)
via 75ccf934ac09e5af68cfd5afdd75a1b32ca24287 (commit)
from 05ea8daacabe62b6c20770a8518192c44e7eb763 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 1214bf606d1cdf3f33b91ffe7cb4c349ce737d68
Merge: 75ccf934ac09e5af68cfd5afdd75a1b32ca24287
05ea8daacabe62b6c20770a8518192c44e7eb763
Author: Jim McDonough
Date: Fri Apr 17 09:28:01 2009 +0200
Merge branch 'master' of /home/jmcd/samba/git.samba.org/samba-master into
mymaster
commit 75ccf934ac09e5af68cfd5afdd75a1b32ca24287
Author: Jim McDonough
Date: Thu Apr 16 17:14:29 2009 +0200
Don't look up local user for remote changes, even when root.
---
Summary of changes:
source3/utils/smbpasswd.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/utils/smbpasswd.c b/source3/utils/smbpasswd.c
index 4cd0d55..8cca93f 100644
--- a/source3/utils/smbpasswd.c
+++ b/source3/utils/smbpasswd.c
@@ -430,14 +430,18 @@ static int process_root(int local_flags)
}
if((local_flags & LOCAL_SET_PASSWORD) && (new_passwd == NULL)) {
- struct passwd *passwd = getpwnam_alloc(NULL, user_name);
+ struct passwd *passwd;
- if (!passwd) {
- fprintf(stderr, "Cannot locate Unix account for
"
- "'%s'!\n", user_name);
- exit(1);
+ if (remote_machine == NULL) {
+ passwd = getpwnam_alloc(NULL, user_name);
+
+ if (!passwd) {
+ fprintf(stderr, "Cannot locate Unix
account for "
+ "'%s'!\n", user_name);
+ exit(1);
+ }
+ TALLOC_FREE(passwd);
}
- TALLOC_FREE(passwd);
new_passwd = prompt_for_new_password(stdin_passwd_get);
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-778-gafc2a0f
The branch, v3-4-test has been updated
via afc2a0f9c860fbaee86c96e2f77b2f551727c2fd (commit)
via 583d7c97bb5f9b62fab17ce2466442ece648331f (commit)
from edf797fb614271c17bc005a661af8c8e8b913d81 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test
- Log -
commit afc2a0f9c860fbaee86c96e2f77b2f551727c2fd
Merge: 583d7c97bb5f9b62fab17ce2466442ece648331f
edf797fb614271c17bc005a661af8c8e8b913d81
Author: Jim McDonough
Date: Fri Apr 17 09:25:06 2009 +0200
Merge branch 'v3-4-test' of /home/jmcd/samba/git.samba.org/samba-master
into 34-test
commit 583d7c97bb5f9b62fab17ce2466442ece648331f
Author: Jim McDonough
Date: Thu Apr 16 17:14:20 2009 +0200
Don't look up local user for remote changes, even when root.
---
Summary of changes:
source3/utils/smbpasswd.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/utils/smbpasswd.c b/source3/utils/smbpasswd.c
index 4cd0d55..8cca93f 100644
--- a/source3/utils/smbpasswd.c
+++ b/source3/utils/smbpasswd.c
@@ -430,14 +430,18 @@ static int process_root(int local_flags)
}
if((local_flags & LOCAL_SET_PASSWORD) && (new_passwd == NULL)) {
- struct passwd *passwd = getpwnam_alloc(NULL, user_name);
+ struct passwd *passwd;
- if (!passwd) {
- fprintf(stderr, "Cannot locate Unix account for
"
- "'%s'!\n", user_name);
- exit(1);
+ if (remote_machine == NULL) {
+ passwd = getpwnam_alloc(NULL, user_name);
+
+ if (!passwd) {
+ fprintf(stderr, "Cannot locate Unix
account for "
+ "'%s'!\n", user_name);
+ exit(1);
+ }
+ TALLOC_FREE(passwd);
}
- TALLOC_FREE(passwd);
new_passwd = prompt_for_new_password(stdin_passwd_get);
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-3-test updated - release-3-2-0pre2-5220-g0cc56c3
The branch, v3-3-test has been updated
via 0cc56c386476c6072f16ad0ae2bb55889b748dc7 (commit)
via bece9b36c455de30eb601912554d43e743def6b2 (commit)
from 8dc31b185d67aa4cdcb367254a913039e3f286ee (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test
- Log -
commit 0cc56c386476c6072f16ad0ae2bb55889b748dc7
Merge: bece9b36c455de30eb601912554d43e743def6b2
8dc31b185d67aa4cdcb367254a913039e3f286ee
Author: Jim McDonough
Date: Fri Apr 17 09:24:49 2009 +0200
Merge branch 'v3-3-test' of /home/jmcd/samba/git.samba.org/samba-master
into 33-test
commit bece9b36c455de30eb601912554d43e743def6b2
Author: Jim McDonough
Date: Thu Apr 16 17:04:00 2009 +0200
Don't look up local user for remote changes, even when root.
---
Summary of changes:
source/utils/smbpasswd.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/utils/smbpasswd.c b/source/utils/smbpasswd.c
index 78c1ce8..6f12692 100644
--- a/source/utils/smbpasswd.c
+++ b/source/utils/smbpasswd.c
@@ -430,14 +430,18 @@ static int process_root(int local_flags)
}
if((local_flags & LOCAL_SET_PASSWORD) && (new_passwd == NULL)) {
- struct passwd *passwd = getpwnam_alloc(NULL, user_name);
+ struct passwd *passwd;
- if (!passwd) {
- fprintf(stderr, "Cannot locate Unix account for
"
- "'%s'!\n", user_name);
- exit(1);
+ if (remote_machine == NULL) {
+ passwd = getpwnam_alloc(NULL, user_name);
+
+ if (!passwd) {
+ fprintf(stderr, "Cannot locate Unix
account for "
+ "'%s'!\n", user_name);
+ exit(1);
+ }
+ TALLOC_FREE(passwd);
}
- TALLOC_FREE(passwd);
new_passwd = prompt_for_new_password(stdin_passwd_get);
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-2-test updated - release-3-2-0pre2-3555-gdd13edf
The branch, v3-2-test has been updated
via dd13edf0249718b8deb5db237dd71c9d4c979019 (commit)
via 1c47bcb5b24ab360d5e632bbf3dcbc7d1d9f6fc4 (commit)
from 72f55ca71c2d9b4c24866b7e1418fa4c17948db6 (commit)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test
- Log -
commit dd13edf0249718b8deb5db237dd71c9d4c979019
Merge: 1c47bcb5b24ab360d5e632bbf3dcbc7d1d9f6fc4
72f55ca71c2d9b4c24866b7e1418fa4c17948db6
Author: Jim McDonough
Date: Fri Apr 17 09:23:50 2009 +0200
Merge branch 'v3-2-test' of /home/jmcd/samba/git.samba.org/samba-master
into 32-test
commit 1c47bcb5b24ab360d5e632bbf3dcbc7d1d9f6fc4
Author: Jim McDonough
Date: Thu Apr 16 16:42:59 2009 +0200
Don't look up local user for remote changes, even when root.
---
Summary of changes:
source/utils/smbpasswd.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source/utils/smbpasswd.c b/source/utils/smbpasswd.c
index 041b02a..47377e1 100644
--- a/source/utils/smbpasswd.c
+++ b/source/utils/smbpasswd.c
@@ -430,14 +430,18 @@ static int process_root(int local_flags)
}
if((local_flags & LOCAL_SET_PASSWORD) && (new_passwd == NULL)) {
- struct passwd *passwd = getpwnam_alloc(NULL, user_name);
+ struct passwd *passwd;
- if (!passwd) {
- fprintf(stderr, "Cannot locate Unix account for
"
- "'%s'!\n", user_name);
- exit(1);
+ if (remote_machine == NULL) {
+ passwd = getpwnam_alloc(NULL, user_name);
+
+ if (!passwd) {
+ fprintf(stderr, "Cannot locate Unix
account for "
+ "'%s'!\n", user_name);
+ exit(1);
+ }
+ TALLOC_FREE(passwd);
}
- TALLOC_FREE(passwd);
new_passwd = prompt_for_new_password(stdin_passwd_get);
--
Samba Shared Repository
