[SCM] Samba Shared Repository - annotated tag release-3-3-11 created
The annotated tag, release-3-3-11 has been created at 96d53db2f67a9e8154d92a7022aa4d0876c3af2b (tag) tagging adc7b060e42b6183d45b5206c23e4e1828f548eb (commit) replaces release-3-3-10 tagged by Karolin Seeger on Fri Feb 26 09:58:32 2010 +0100 - Log - tag release-3-3-11 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.12 (GNU/Linux) iD8DBQBLh41abzORW2Vot+oRAs4uAKCbEsO4vFHJkNQp/A9Syr54kZFfUwCgk7ga CZN8kJMU1odXAenqfx3H0H0= =RfAt -END PGP SIGNATURE- Bo Yang (1): s3: Fix malformed require_membership_of_sid. Günther Deschner (1): s3-libsmbclient: Fix crash bug in SMBC_parse_path(). Jeremy Allison (11): Fix bug #7036 - net rpc getsid fails in hardened windows environments. Fix bug 7045 - Bad (non memory copying) interfaces in smbc_set calls. Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail to respond to a read or write. Fix bug #7072 - Accounts can't be unlocked from ldap. Fix bug 7104 - wide links and unix extensions are incompatible. Fixes issue with preexec scripts creating a share directory, and problems if a smb.conf reload turns wide links back on after a connection is establised. Fix bug #6557 - Do not work VFS full_audit Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when mangling method = hash Fix bug #7154 - mangling method = hash can crash storing a name not containing a '.' Fix off-by-one error in working out the limit of the NetServerEnum comment. Fix bug #7122 - Reading a large browselist fails (server returns invalid values in subsequent SMBtrans replies) Karolin Seeger (5): VERSION: Raise version up to 3.3.11. WHATSNEW: Update release notes. s3-docs: Fix typos. s3-docs: Add missing para end tag. WHATSNEW: Update changes since 3.3.10. Stefan Metzmacher (4): s3:libsmb: don't reuse the callers stype variable in cli_NetServerEnum() s3:libsmb: fix NetServerEnum3 rap calls. s3:smbd: Fix really ugly bool vs. int bug!!! s3:winbindd: never mark external domains as internal! Volker Lendecke (3): s3: Fix a crash in libsmbclient used against the OpenSolaris CIFS server s3: Fix an uninitialized variable reference s3:winbind: Fix bug 5626 William Jojo (1): s3: Fix bug 7052: DFS broken on AIX (maybe others) --- -- Samba Shared Repository
svn commit: samba-web r1404 - in trunk: . history
Author: kseeger Date: 2010-02-26 02:19:15 -0700 (Fri, 26 Feb 2010) New Revision: 1404 WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=revroot=samba-webrev=1404 Log: Announce Samba 3.3.11 Karolin Added: trunk/history/samba-3.3.11.html Modified: trunk/header_columns.html trunk/history/header_history.html trunk/index.html Changeset: Modified: trunk/header_columns.html === --- trunk/header_columns.html 2010-02-26 04:47:19 UTC (rev 1403) +++ trunk/header_columns.html 2010-02-26 09:19:15 UTC (rev 1404) @@ -127,9 +127,9 @@ h4Historical/h4 ul -lia href=/samba/ftp/stable/samba-3.3.10.tar.gzSamba 3.3.10 (gzipped)/a/li -lia href=/samba/history/samba-3.3.10.htmlRelease Notes 3.3.10/a/li -lia href=/samba/ftp/stable/samba-3.3.10.tar.ascSignature 3.3.10/a/li +lia href=/samba/ftp/stable/samba-3.3.11.tar.gzSamba 3.3.11 (gzipped)/a/li +lia href=/samba/history/samba-3.3.11.htmlRelease Notes 3.3.11/a/li +lia href=/samba/ftp/stable/samba-3.3.11.tar.ascSignature 3.3.11/a/li lia href=/samba/ftp/stable/samba-3.2.15.tar.gzSamba 3.2.15 (gzipped)/a/li lia href=/samba/history/samba-3.2.15.htmlRelease Notes 3.2.15/a/li Modified: trunk/history/header_history.html === --- trunk/history/header_history.html 2010-02-26 04:47:19 UTC (rev 1403) +++ trunk/history/header_history.html 2010-02-26 09:19:15 UTC (rev 1404) @@ -84,6 +84,7 @@ lia href=samba-3.4.2.htmlsamba-3.4.2/a/li lia href=samba-3.4.1.htmlsamba-3.4.1/a/li lia href=samba-3.4.0.htmlsamba-3.4.0/a/li +lia href=samba-3.3.11.htmlsamba-3.3.11/a/li lia href=samba-3.3.10.htmlsamba-3.3.10/a/li lia href=samba-3.3.9.htmlsamba-3.3.9/a/li lia href=samba-3.3.8.htmlsamba-3.3.8/a/li Added: trunk/history/samba-3.3.11.html === --- trunk/history/samba-3.3.11.html (rev 0) +++ trunk/history/samba-3.3.11.html 2010-02-26 09:19:15 UTC (rev 1404) @@ -0,0 +1,77 @@ +!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0 Transitional//EN +http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd; +html xmlns=http://www.w3.org/1999/xhtml; + +head +titleSamba - Release Notes Archive/title +/head + +body + + H2Samba 3.3.11 Available for Download/H2 + +p +pre + == + Release Notes for Samba 3.3.11 +February 26, 2010 + == + + +This is the latest bugfix release of the Samba 3.3 series. + +Major enhancements in Samba 3.3.11 include: + + o wide links and unix extensions are incompatible (bug #7104). + o Fix failing of smbd to respond to a read or a write caused by + Linux asynchronous IO (aio) (bug #7067). + + +## +Changes +### + +Changes since 3.3.10 + + + +o Jeremy Allison lt;j...@samba.orggt; +* BUG 6557: Fix vfs_full_audit. +* BUG 7036: Fix 'net rpc getsid' in hardened Windows environments. +* BUG 7045: Fix bad (non memory copying) interfaces in smbc_set calls. +* BUG 7067: Fix failing of smbd to respond to a read or a write caused by + Linux asynchronous IO (aio). +* BUG 7072: Fix unlocking of accounts from ldap. +* BUG 7104: wide links and unix extensions are incompatible. +* BUG 7122: Fix reading of large browselist. +* BUG 7154: mangling method = hash can crash storing a name containing a '.'. +* BUG 7155: Valgrind Conditional jump or move depends on uninitialised + value(s) error when mangling method = hash. + + +o Guuml;nther Deschner lt;g...@samba.orggt; +* BUG 7043: Fix crash bug in SMBC_parse_path. + + +o Volker Lendecke lt;v...@samba.orggt; +* BUG 5626: Fix build on AIX. +* BUG 5885: Fix bogus ip address in SWAT. +* BUG 7046: Fix a crash in libsmbclient used against the OpenSolaris CIFS + server. + + +o Stefan Metzmacher lt;me...@samba.orggt; +* BUG 7098: Fix results of 'smbclient -L' with a large browse list. +* BUG 7170: Fix handling of external domains in setups with one way trusts. + + +o William Jojo lt;w.j...@hvcc.edugt; +* BUG 7052: Fix DFS on AIX (maybe others). + + +o Bo Yang lt;boy...@samba.orggt; +* BUG 7106: Fix malformed require_membership_of_sid. +/pre + +/body +/html Property changes on: trunk/history/samba-3.3.11.html ___ Added: svn:executable + * Modified: trunk/index.html === --- trunk/index.html2010-02-26 04:47:19 UTC (rev 1403) +++ trunk/index.html2010-02-26 09:19:15 UTC (rev 1404) @@ -24,6 +24,18 @@ h2Latest News/h2 !--#include virtual=/samba/news/headlines.html --
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 81bb8f6... s4-smb: Migrate named_pipe_server to tsocket. via 1983256... tsocket: Improve the tsocket_address_bsd_sockaddr documentation. via 27e7578... s4:provision: use generate_random_password() via d2cd0a7... s4:pyglue: add generate_random_password() via 9ada48f... s4:torture/rpc: use generate_random_password() via 7473ca2... s4:libnet: use generate_random_password() via 792dd38... lib/util: add generate_random_password() from c2edea5... devel: get the ownership of the directories right in tmpfs.sh http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 81bb8f67fa50acb914a428b5468fe39643cecb78 Author: Andreas Schneider a...@redhat.com Date: Thu Feb 4 17:03:04 2010 +0100 s4-smb: Migrate named_pipe_server to tsocket. This is an improved version of commit 69d5cea2e59162f19460e7ce4b6382fc5fdd6ca0, which was reverted by commit 71c20f703b0c603d6aada63ed5634070a26df052. Signed-off-by: Stefan Metzmacher me...@samba.org commit 1983256c70cf07b8c8afddd024ee5fd2522ee83c Author: Andreas Schneider a...@redhat.com Date: Thu Feb 25 14:32:39 2010 +0100 tsocket: Improve the tsocket_address_bsd_sockaddr documentation. Signed-off-by: Stefan Metzmacher me...@samba.org commit 27e7578e2763f0e9de2e0c94521d552678244cf2 Author: Stefan Metzmacher me...@samba.org Date: Wed Feb 24 15:09:15 2010 +0100 s4:provision: use generate_random_password() metze commit d2cd0a783b059fc2a938f7e2a5f5d002e83be967 Author: Stefan Metzmacher me...@samba.org Date: Wed Feb 24 14:44:22 2010 +0100 s4:pyglue: add generate_random_password() metze commit 9ada48ffdb3b7ab4bc1bce0f6b2179f67292bcf8 Author: Stefan Metzmacher me...@samba.org Date: Wed Feb 24 15:12:17 2010 +0100 s4:torture/rpc: use generate_random_password() metze commit 7473ca2d33e04d9b9dbb7fa56b0cb44603988036 Author: Stefan Metzmacher me...@samba.org Date: Wed Feb 24 15:09:50 2010 +0100 s4:libnet: use generate_random_password() metze commit 792dd38d7c0be5319db1eef625c142a6490cd12b Author: Stefan Metzmacher me...@samba.org Date: Thu Feb 25 15:58:38 2010 +0100 lib/util: add generate_random_password() metze --- Summary of changes: lib/tsocket/tsocket.h |4 +- lib/util/genrand.c | 42 +++ lib/util/util.h |5 + source4/libnet/libnet_join.c|2 +- source4/libnet/libnet_vampire.c |2 +- source4/scripting/bin/upgradeprovision |2 +- source4/scripting/python/pyglue.c | 24 ++- source4/scripting/python/samba/provision.py | 10 +- source4/smbd/service_named_pipe.c | 519 --- source4/smbd/service_stream.c |2 +- source4/torture/rpc/netlogon.c |8 +- source4/torture/rpc/samba3rpc.c |8 +- source4/torture/rpc/samr.c |6 +- source4/torture/rpc/schannel.c |2 +- source4/torture/rpc/testjoin.c |2 +- 15 files changed, 405 insertions(+), 233 deletions(-) Changeset truncated at 500 lines: diff --git a/lib/tsocket/tsocket.h b/lib/tsocket/tsocket.h index 1cd40e4..d983325 100644 --- a/lib/tsocket/tsocket.h +++ b/lib/tsocket/tsocket.h @@ -869,7 +869,9 @@ ssize_t tsocket_address_bsd_sockaddr(const struct tsocket_address *addr, * @brief Wrap an existing file descriptors into the tstream abstraction. * * You can use this function to wrap an existing file descriptors into the - * tstream abstraction. + * tstream abstraction. After that you're not able to use this file descriptor + * for anything else. The file descriptor will be closed when the stream gets + * freed. If you still want to use the fd you have have to create a duplicate. * * @param[in] mem_ctx The talloc memory context to use. * diff --git a/lib/util/genrand.c b/lib/util/genrand.c index f054402..02b8d8b 100644 --- a/lib/util/genrand.c +++ b/lib/util/genrand.c @@ -362,6 +362,48 @@ again: } /** + * Generate a random text password. + */ + +_PUBLIC_ char *generate_random_password(TALLOC_CTX *mem_ctx, size_t min, size_t max) +{ + char *retstr; + const char *c_list = ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+_-#.,@$%!?:;=(){}[]~; + size_t len = max; + size_t diff; + + if (min max) { + errno = EINVAL; + return NULL; + } + + diff = max - min; + + if (diff 0 ) { + size_t tmp; + + generate_random_buffer((uint8_t *)tmp, sizeof(tmp)); + + tmp %= diff; + + len = min + tmp; + } + +again: + retstr =
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via d671b80... libcli/auth: print the error in the debug message from 81bb8f6... s4-smb: Migrate named_pipe_server to tsocket. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit d671b80cf5ebd4a4a2d832d90aeef27cacfb521a Author: Stefan Metzmacher me...@samba.org Date: Fri Feb 26 10:09:36 2010 +0100 libcli/auth: print the error in the debug message metze --- Summary of changes: libcli/auth/schannel_state_tdb.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/libcli/auth/schannel_state_tdb.c b/libcli/auth/schannel_state_tdb.c index fd61b0a..0ec928f 100644 --- a/libcli/auth/schannel_state_tdb.c +++ b/libcli/auth/schannel_state_tdb.c @@ -57,7 +57,8 @@ static struct tdb_wrap *open_schannel_session_store(TALLOC_CTX *mem_ctx, tdb_sc = tdb_wrap_open(mem_ctx, fname, 0, TDB_DEFAULT, O_RDWR|O_CREAT, 0600); if (!tdb_sc) { - DEBUG(0,(open_schannel_session_store: Failed to open %s\n, fname)); + DEBUG(0,(open_schannel_session_store: Failed to open %s - %s\n, +fname, strerror(errno))); TALLOC_FREE(fname); return NULL; } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via ee547e7... s3: remove unused schannel_auth_struct. via 274baba... testprogs: print the directory paths as well in spoolss test. from d671b80... libcli/auth: print the error in the debug message http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit ee547e715eff60fd26fa65655b00b80202088319 Author: Günther Deschner g...@samba.org Date: Fri Feb 26 02:51:21 2010 +0100 s3: remove unused schannel_auth_struct. Guenther commit 274baba4ab191e4b357ef5babc01a1c5501afebf Author: Günther Deschner g...@samba.org Date: Fri Feb 26 02:50:28 2010 +0100 testprogs: print the directory paths as well in spoolss test. Guenther --- Summary of changes: source3/include/ntdomain.h|6 -- testprogs/win32/spoolss/spoolss.c |8 2 files changed, 8 insertions(+), 6 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/include/ntdomain.h b/source3/include/ntdomain.h index 3204e2e..c98ee18 100644 --- a/source3/include/ntdomain.h +++ b/source3/include/ntdomain.h @@ -140,12 +140,6 @@ struct kerberos_auth_struct { DATA_BLOB session_key; }; -/* auth state for schannel. */ -struct schannel_auth_struct { - unsigned char sess_key[16]; - uint32 seq_num; -}; - /* auth state for all bind types. */ struct pipe_auth_data { diff --git a/testprogs/win32/spoolss/spoolss.c b/testprogs/win32/spoolss/spoolss.c index c9a7bc0..38eb7ed 100644 --- a/testprogs/win32/spoolss/spoolss.c +++ b/testprogs/win32/spoolss/spoolss.c @@ -1073,6 +1073,10 @@ static BOOL test_GetPrintProcessorDirectory(struct torture_context *tctx, } } + if (tctx-print) { + printf(\tPrint Processor Directory\t= %s\n\n, (LPSTR)buffer); + } + free(buffer); buffer = NULL; } @@ -1120,6 +1124,10 @@ static BOOL test_GetPrinterDriverDirectory(struct torture_context *tctx, } } + if (tctx-print) { + printf(\tPrinter Driver Directory\t= %s\n\n, (LPSTR)buffer); + } + free(buffer); buffer = NULL; } -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b792e55... s4: Winbind allow to behave more correctly when we have more than a few users via 2572391... s4:python Add bindings to set GENSEC flags on credentials in python from ee547e7... s3: remove unused schannel_auth_struct. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b792e5575c8dcd1ec4f5a572561a48ea5744000c Author: Matthieu Patou m...@matws.net Date: Thu Feb 25 20:41:57 2010 +0300 s4: Winbind allow to behave more correctly when we have more than a few users commit 25723914c5f5b18a25f758f1098ddded3c5aa074 Author: Andrew Bartlett abart...@samba.org Date: Thu Feb 25 20:22:52 2010 +1100 s4:python Add bindings to set GENSEC flags on credentials in python This should allow these to be manipulated by python scripts that need encrypted connections. Andrew Bartlett --- Summary of changes: source4/auth/credentials/pycredentials.c | 23 ++ source4/auth/gensec/pygensec.c |9 + source4/winbind/wb_cmd_setpwent.c| 49 +- 3 files changed, 73 insertions(+), 8 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/auth/credentials/pycredentials.c b/source4/auth/credentials/pycredentials.c index 8602be8..f5e8029 100644 --- a/source4/auth/credentials/pycredentials.c +++ b/source4/auth/credentials/pycredentials.c @@ -278,6 +278,27 @@ static PyObject *py_creds_get_named_ccache(py_talloc_Object *self, PyObject *arg return NULL; } +static PyObject *py_creds_set_gensec_features(py_talloc_Object *self, PyObject *args) +{ + unsigned int gensec_features; + + if (!PyArg_ParseTuple(args, I, gensec_features)) + return NULL; + + cli_credentials_set_gensec_features(PyCredentials_AsCliCredentials(self), gensec_features); + + Py_RETURN_NONE; +} + +static PyObject *py_creds_get_gensec_features(py_talloc_Object *self, PyObject *args) +{ + unsigned int gensec_features; + + gensec_features = cli_credentials_get_gensec_features(PyCredentials_AsCliCredentials(self)); + return PyInt_FromLong(gensec_features); +} + + static PyMethodDef py_creds_methods[] = { { get_username, (PyCFunction)py_creds_get_username, METH_NOARGS, S.get_username() - username\nObtain username. }, @@ -335,6 +356,8 @@ static PyMethodDef py_creds_methods[] = { { guess, (PyCFunction)py_creds_guess, METH_VARARGS, NULL }, { set_machine_account, (PyCFunction)py_creds_set_machine_account, METH_VARARGS, NULL }, { get_named_ccache, (PyCFunction)py_creds_get_named_ccache, METH_VARARGS, NULL }, + { set_gensec_features, (PyCFunction)py_creds_set_gensec_features, METH_VARARGS, NULL }, + { get_gensec_features, (PyCFunction)py_creds_get_gensec_features, METH_NOARGS, NULL }, { NULL } }; diff --git a/source4/auth/gensec/pygensec.c b/source4/auth/gensec/pygensec.c index 1c2bd20..21acff8 100644 --- a/source4/auth/gensec/pygensec.c +++ b/source4/auth/gensec/pygensec.c @@ -177,6 +177,15 @@ void initgensec(void) if (m == NULL) return; + PyModule_AddObject(m, FEATURE_SESSION_KEY, PyInt_FromLong(GENSEC_FEATURE_SESSION_KEY)); + PyModule_AddObject(m, FEATURE_SIGN, PyInt_FromLong(GENSEC_FEATURE_SIGN)); + PyModule_AddObject(m, FEATURE_SEAL, PyInt_FromLong(GENSEC_FEATURE_SEAL)); + PyModule_AddObject(m, FEATURE_DCE_STYLE, PyInt_FromLong(GENSEC_FEATURE_DCE_STYLE)); + PyModule_AddObject(m, FEATURE_ASYNC_REPLIES, PyInt_FromLong(GENSEC_FEATURE_ASYNC_REPLIES)); + PyModule_AddObject(m, FEATURE_DATAGRAM_MODE, PyInt_FromLong(GENSEC_FEATURE_DATAGRAM_MODE)); + PyModule_AddObject(m, FEATURE_SIGN_PKT_HEADER, PyInt_FromLong(GENSEC_FEATURE_SIGN_PKT_HEADER)); + PyModule_AddObject(m, FEATURE_NEW_SPNEGO, PyInt_FromLong(GENSEC_FEATURE_NEW_SPNEGO)); + Py_INCREF(Py_Security); PyModule_AddObject(m, Security, (PyObject *)Py_Security); } diff --git a/source4/winbind/wb_cmd_setpwent.c b/source4/winbind/wb_cmd_setpwent.c index 7fb1889..9384849 100644 --- a/source4/winbind/wb_cmd_setpwent.c +++ b/source4/winbind/wb_cmd_setpwent.c @@ -30,6 +30,7 @@ struct cmd_setpwent_state { struct libnet_context *libnet_ctx; struct wbsrv_pwent *result; + char *domain_name; }; static void cmd_setpwent_recv_domain(struct composite_context *ctx); @@ -80,6 +81,8 @@ static void cmd_setpwent_recv_domain(struct composite_context *ctx) user_list = talloc(state-result, struct libnet_UserList); if (composite_nomem(user_list, state-ctx)) return; + state-domain_name = talloc_strdup(state, + domain-libnet_ctx-samr.name);
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via e0e549a... s4:dcesrv_samr.c - Remove unused variable from b792e55... s4: Winbind allow to behave more correctly when we have more than a few users http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit e0e549a77004fc45bfc01db03df267bc003a81cb Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Fri Feb 26 11:53:49 2010 +0100 s4:dcesrv_samr.c - Remove unused variable --- Summary of changes: source4/rpc_server/samr/dcesrv_samr.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/rpc_server/samr/dcesrv_samr.c b/source4/rpc_server/samr/dcesrv_samr.c index 61a9f13..edfacfb 100644 --- a/source4/rpc_server/samr/dcesrv_samr.c +++ b/source4/rpc_server/samr/dcesrv_samr.c @@ -1939,7 +1939,7 @@ static NTSTATUS dcesrv_samr_LookupRids(struct dcesrv_call_state *dce_call, TALLO { struct dcesrv_handle *h; struct samr_domain_state *d_state; - int i, total; + int i; NTSTATUS status = NT_STATUS_OK; struct lsa_String *names; uint32_t *ids; @@ -1960,8 +1960,6 @@ static NTSTATUS dcesrv_samr_LookupRids(struct dcesrv_call_state *dce_call, TALLO if ((names == NULL) || (ids == NULL)) return NT_STATUS_NO_MEMORY; - total = 0; - for (i=0; ir-in.num_rids; i++) { struct ldb_message **res; int count; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 062a8cf... s4-winbind: Fixed the memory context of tstream_bsd_existing() via b800716... s4-ntp: Fixed the memory context of tstream_bsd_existing() via c3b90f0... s4-kdc: Fixed the memory context of tstream_bsd_existing() from e0e549a... s4:dcesrv_samr.c - Remove unused variable http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 062a8cf0068d9833b68d6569eae6fdb0fc622726 Author: Andreas Schneider a...@redhat.com Date: Fri Feb 26 10:21:10 2010 +0100 s4-winbind: Fixed the memory context of tstream_bsd_existing() Signed-off-by: Stefan Metzmacher me...@samba.org commit b80071602ffa127ab1857b0203ff868c15b8ce6b Author: Andreas Schneider a...@redhat.com Date: Fri Feb 26 10:19:55 2010 +0100 s4-ntp: Fixed the memory context of tstream_bsd_existing() Signed-off-by: Stefan Metzmacher me...@samba.org commit c3b90f00d4c76694060124a34eecb099584d3667 Author: Andreas Schneider a...@redhat.com Date: Fri Feb 26 10:35:01 2010 +0100 s4-kdc: Fixed the memory context of tstream_bsd_existing() Signed-off-by: Stefan Metzmacher me...@samba.org --- Summary of changes: source4/kdc/kdc.c |2 +- source4/ntp_signd/ntp_signd.c |2 +- source4/winbind/wb_server.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/kdc/kdc.c b/source4/kdc/kdc.c index 827159b..984999b 100644 --- a/source4/kdc/kdc.c +++ b/source4/kdc/kdc.c @@ -311,7 +311,7 @@ static void kdc_tcp_accept(struct stream_connection *conn) TALLOC_FREE(conn-event.fde); - rc = tstream_bsd_existing_socket(kdc_conn-tstream, + rc = tstream_bsd_existing_socket(kdc_conn, socket_get_fd(conn-socket), kdc_conn-tstream); if (rc 0) { diff --git a/source4/ntp_signd/ntp_signd.c b/source4/ntp_signd/ntp_signd.c index 025ff2b..a2d14ad 100644 --- a/source4/ntp_signd/ntp_signd.c +++ b/source4/ntp_signd/ntp_signd.c @@ -445,7 +445,7 @@ static void ntp_signd_accept(struct stream_connection *conn) TALLOC_FREE(conn-event.fde); - rc = tstream_bsd_existing_socket(ntp_signd_conn-tstream, + rc = tstream_bsd_existing_socket(ntp_signd_conn, socket_get_fd(conn-socket), ntp_signd_conn-tstream); if (rc 0) { diff --git a/source4/winbind/wb_server.c b/source4/winbind/wb_server.c index 306c8e2..11f0bf0 100644 --- a/source4/winbind/wb_server.c +++ b/source4/winbind/wb_server.c @@ -127,7 +127,7 @@ static void wbsrv_accept(struct stream_connection *conn) TALLOC_FREE(conn-event.fde); - rc = tstream_bsd_existing_socket(wbsrv_conn-tstream, + rc = tstream_bsd_existing_socket(wbsrv_conn, socket_get_fd(conn-socket), wbsrv_conn-tstream); if (rc 0) { -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 3ca8d28... spoolss: fix build and version in spoolss_PrinterInfo0 (aka PRINTER_INFO_STRESS). via b1f18fb... spoolss: add spoolss_Build to IDL. from 062a8cf... s4-winbind: Fixed the memory context of tstream_bsd_existing() http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 3ca8d28bb7c33fe7733f036c8a6254545b0410ce Author: Günther Deschner g...@samba.org Date: Fri Feb 26 14:45:07 2010 +0100 spoolss: fix build and version in spoolss_PrinterInfo0 (aka PRINTER_INFO_STRESS). Guenther commit b1f18fb808d56e5c29e78e838802553c5e95f824 Author: Günther Deschner g...@samba.org Date: Fri Feb 26 14:44:22 2010 +0100 spoolss: add spoolss_Build to IDL. Guenther --- Summary of changes: librpc/gen_ndr/ndr_spoolss.c| 31 --- librpc/gen_ndr/ndr_spoolss.h|1 + librpc/gen_ndr/spoolss.h| 15 ++- librpc/idl/spoolss.idl |7 ++- source3/rpc_server/srv_spoolss_nt.c |5 +++-- 5 files changed, 52 insertions(+), 7 deletions(-) Changeset truncated at 500 lines: diff --git a/librpc/gen_ndr/ndr_spoolss.c b/librpc/gen_ndr/ndr_spoolss.c index 2448f73..0610c18 100644 --- a/librpc/gen_ndr/ndr_spoolss.c +++ b/librpc/gen_ndr/ndr_spoolss.c @@ -6810,6 +6810,31 @@ _PUBLIC_ void ndr_print_spoolss_PrinterControl(struct ndr_print *ndr, const char ndr_print_enum(ndr, name, ENUM, val, r); } +static enum ndr_err_code ndr_push_spoolss_Build(struct ndr_push *ndr, int ndr_flags, enum spoolss_Build r) +{ + NDR_CHECK(ndr_push_enum_uint32(ndr, NDR_SCALARS, r)); + return NDR_ERR_SUCCESS; +} + +static enum ndr_err_code ndr_pull_spoolss_Build(struct ndr_pull *ndr, int ndr_flags, enum spoolss_Build *r) +{ + uint32_t v; + NDR_CHECK(ndr_pull_enum_uint32(ndr, NDR_SCALARS, v)); + *r = v; + return NDR_ERR_SUCCESS; +} + +_PUBLIC_ void ndr_print_spoolss_Build(struct ndr_print *ndr, const char *name, enum spoolss_Build r) +{ + const char *val = NULL; + + switch (r) { + case SPOOLSS_DEBUGGING_BUILD: val = SPOOLSS_DEBUGGING_BUILD; break; + case SPOOLSS_RELEASE_BUILD: val = SPOOLSS_RELEASE_BUILD; break; + } + ndr_print_enum(ndr, name, ENUM, val, r); +} + static enum ndr_err_code ndr_push_spoolss_SetPrinterInfo0(struct ndr_push *ndr, int ndr_flags, const struct spoolss_SetPrinterInfo0 *r) { if (ndr_flags NDR_SCALARS) { @@ -6823,7 +6848,7 @@ static enum ndr_err_code ndr_push_spoolss_SetPrinterInfo0(struct ndr_push *ndr, NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-global_counter)); NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-total_pages)); NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-version)); - NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-free_build)); + NDR_CHECK(ndr_push_spoolss_Build(ndr, NDR_SCALARS, r-free_build)); NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-spooling)); NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-max_spooling)); NDR_CHECK(ndr_push_uint32(ndr, NDR_SCALARS, r-session_counter)); @@ -6889,7 +6914,7 @@ static enum ndr_err_code ndr_pull_spoolss_SetPrinterInfo0(struct ndr_pull *ndr, NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-global_counter)); NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-total_pages)); NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-version)); - NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-free_build)); + NDR_CHECK(ndr_pull_spoolss_Build(ndr, NDR_SCALARS, r-free_build)); NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-spooling)); NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-max_spooling)); NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, r-session_counter)); @@ -6963,7 +6988,7 @@ _PUBLIC_ void ndr_print_spoolss_SetPrinterInfo0(struct ndr_print *ndr, const cha ndr_print_uint32(ndr, global_counter, r-global_counter); ndr_print_uint32(ndr, total_pages, r-total_pages); ndr_print_uint32(ndr, version, r-version); - ndr_print_uint32(ndr, free_build, r-free_build); + ndr_print_spoolss_Build(ndr, free_build, r-free_build); ndr_print_uint32(ndr, spooling, r-spooling); ndr_print_uint32(ndr, max_spooling, r-max_spooling); ndr_print_uint32(ndr, session_counter, r-session_counter); diff --git a/librpc/gen_ndr/ndr_spoolss.h b/librpc/gen_ndr/ndr_spoolss.h index 52873de..394db03 100644 --- a/librpc/gen_ndr/ndr_spoolss.h +++ b/librpc/gen_ndr/ndr_spoolss.h @@ -347,6 +347,7 @@ void ndr_print_spoolss_SetJobInfo(struct ndr_print *ndr, const char *name, const void
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 87c96f0... .gitignore - ignore display of mit_samba.so from 3ca8d28... spoolss: fix build and version in spoolss_PrinterInfo0 (aka PRINTER_INFO_STRESS). http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 87c96f0023fcf9c12a53171e70b53acf7303a89e Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Fri Feb 26 19:15:01 2010 +0100 .gitignore - ignore display of mit_samba.so --- Summary of changes: .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/.gitignore b/.gitignore index 4ed80ae..b40c794 100644 --- a/.gitignore +++ b/.gitignore @@ -320,6 +320,7 @@ source4/heimdal/lib/roken/roken.h source4/lib/ldb-samba/ldif_handlers_proto.h source4/libcli/drsblobs_proto.h source4/ntvfs/posix/vfs_acl_proto.h +source4/kdc/mit_samba.so *.swp tags *.x -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b49276e... s4:script/installmisc.sh - install dns_update_list to target setup folder from 87c96f0... .gitignore - ignore display of mit_samba.so http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b49276e291274652d46eed39249c07531e32b591 Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Fri Feb 26 20:41:38 2010 +0100 s4:script/installmisc.sh - install dns_update_list to target setup folder --- Summary of changes: source4/script/installmisc.sh |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/script/installmisc.sh b/source4/script/installmisc.sh index 5c7c648..73dbdd9 100755 --- a/source4/script/installmisc.sh +++ b/source4/script/installmisc.sh @@ -79,5 +79,6 @@ cp setup/named.conf.update $SETUPDIR || exit 1 cp setup/provision.smb.conf.dc $SETUPDIR || exit 1 cp setup/provision.smb.conf.member $SETUPDIR || exit 1 cp setup/provision.smb.conf.standalone $SETUPDIR || exit 1 +cp setup/dns_update_list $SETUPDIR || exit 1 exit 0 -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 2caa2a0... s4:provision.zone - fix port of _ldap._tcp.gc._msdcs from b49276e... s4:script/installmisc.sh - install dns_update_list to target setup folder http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 2caa2a045dd4f56cffb3a5af82a1f992198e4412 Author: Matthias Dieter Wallnöfer mwallnoe...@yahoo.de Date: Fri Feb 26 21:00:10 2010 +0100 s4:provision.zone - fix port of _ldap._tcp.gc._msdcs --- Summary of changes: source4/setup/provision.zone |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/setup/provision.zone b/source4/setup/provision.zone index 6d483b8..2c25fd0 100644 --- a/source4/setup/provision.zone +++ b/source4/setup/provision.zone @@ -20,7 +20,7 @@ ${NTDSGUID}._msdcsIN CNAME${HOSTNAME} ; global catalog servers _gc._tcp IN SRV 0 100 3268 ${HOSTNAME} _gc._tcp.${DEFAULTSITE}._sites IN SRV 0 100 3268 ${HOSTNAME} -_ldap._tcp.gc._msdcs IN SRV 0 100 389${HOSTNAME} +_ldap._tcp.gc._msdcs IN SRV 0 100 3268 ${HOSTNAME} _ldap._tcp.${DEFAULTSITE}._sites.gc._msdcs IN SRV 0 100 3268 ${HOSTNAME} ; ; ldap servers -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b28afd2... s4:ldb_dn: fix an uninitialized variable (found by make valgrindtest) via 47fafe8... s4:ldb_dn: remove dn-ext_linearized when ext_components is modified. via c7432e4... s4:ldb_dn: reset dn-ext_comp_num in ldb_dn_explode() via 4bad696... s4:dsdb/schema: fix validation of DNs from 2caa2a0... s4:provision.zone - fix port of _ldap._tcp.gc._msdcs http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b28afd2bcc825e9fef415f3a256e39e4af1ae84e Author: Stefan Metzmacher me...@samba.org Date: Fri Feb 26 10:53:06 2010 +0100 s4:ldb_dn: fix an uninitialized variable (found by make valgrindtest) metze commit 47fafe801b5a4a054dcde301b892cda9c0ababb0 Author: Stefan Metzmacher me...@samba.org Date: Fri Feb 26 15:48:02 2010 +0100 s4:ldb_dn: remove dn-ext_linearized when ext_components is modified. metze commit c7432e49506561316f42bf0a26dd21de563c8eda Author: Stefan Metzmacher me...@samba.org Date: Thu Feb 25 23:19:53 2010 +0100 s4:ldb_dn: reset dn-ext_comp_num in ldb_dn_explode() metze commit 4bad696f9ef3bdc3a1a9dc6b98a58d7071b994d7 Author: Stefan Metzmacher me...@samba.org Date: Fri Feb 26 16:48:09 2010 +0100 s4:dsdb/schema: fix validation of DNs ldb_dn_extended_filter() removes all but the listed components, I didn't noticed that when writting the code. Doing a ldb_dn_remove_extended_components(dn2) is wrong. This was hidden by some bugs in the ldb_dn code. metze --- Summary of changes: source4/dsdb/schema/schema_syntax.c |1 - source4/lib/ldb/common/ldb_dn.c | 13 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) Changeset truncated at 500 lines: diff --git a/source4/dsdb/schema/schema_syntax.c b/source4/dsdb/schema/schema_syntax.c index 877200b..bdd22f8 100644 --- a/source4/dsdb/schema/schema_syntax.c +++ b/source4/dsdb/schema/schema_syntax.c @@ -1742,7 +1742,6 @@ static WERROR dsdb_syntax_DN_validate_one_val(struct ldb_context *ldb, * one. */ ldb_dn_extended_filter(dn, extended_list); - ldb_dn_remove_extended_components(dn2); dn_str = ldb_dn_get_extended_linearized(tmp_ctx, dn, 0); if (dn_str == NULL) { diff --git a/source4/lib/ldb/common/ldb_dn.c b/source4/lib/ldb/common/ldb_dn.c index c395be2..04e769f 100644 --- a/source4/lib/ldb/common/ldb_dn.c +++ b/source4/lib/ldb/common/ldb_dn.c @@ -333,8 +333,8 @@ static bool ldb_dn_explode(struct ldb_dn *dn) /* make sure we free this if alloced previously before replacing */ talloc_free(dn-components); - talloc_free(dn-ext_components); - dn-ext_components = NULL; + LDB_FREE(dn-ext_components); + dn-ext_comp_num = 0; /* in the common case we have 3 or more components */ /* make sure all components are zeroed, other functions depend on it */ @@ -805,7 +805,7 @@ static int ldb_dn_extended_component_compare(const void *p1, const void *p2) char *ldb_dn_get_extended_linearized(void *mem_ctx, struct ldb_dn *dn, int mode) { const char *linearized = ldb_dn_get_linearized(dn); - char *p; + char *p = NULL; int i; if (!linearized) { @@ -894,6 +894,7 @@ void ldb_dn_extended_filter(struct ldb_dn *dn, const char * const *accept) i--; } } + LDB_FREE(dn-ext_linearized); } @@ -1424,9 +1425,7 @@ bool ldb_dn_add_base(struct ldb_dn *dn, struct ldb_dn *base) /* Wipe the ext_linearized DN, * the GUID and SID are almost certainly no longer valid */ - if (dn-ext_linearized) { - LDB_FREE(dn-ext_linearized); - } + LDB_FREE(dn-ext_linearized); LDB_FREE(dn-ext_components); dn-ext_comp_num = 0; @@ -1935,6 +1934,7 @@ int ldb_dn_set_extended_component(struct ldb_dn *dn, } return LDB_SUCCESS; } + LDB_FREE(dn-ext_linearized); } } @@ -1972,6 +1972,7 @@ void ldb_dn_remove_extended_components(struct ldb_dn *dn) { dn-ext_comp_num = 0; LDB_FREE(dn-ext_components); + LDB_FREE(dn-ext_linearized); } bool ldb_dn_is_valid(struct ldb_dn *dn) -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via cfc79f2... Fix one of the valgrind warnings from bug #6814 - Fixes for problems reported by valgrind from b28afd2... s4:ldb_dn: fix an uninitialized variable (found by make valgrindtest) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit cfc79f222d0fae7f976bb843da3565c58b2c375e Author: Roel van Meer ro...@alt001.com Date: Fri Feb 26 14:54:22 2010 -0800 Fix one of the valgrind warnings from bug #6814 - Fixes for problems reported by valgrind The timeval passed to event_add_to_select_args() must be initialized as event_add_to_select_args() uses a timeval_min() on this and next_event. --- Summary of changes: source3/winbindd/winbindd_dual.c |8 1 files changed, 8 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c index 74b2b99..26f9232 100644 --- a/source3/winbindd/winbindd_dual.c +++ b/source3/winbindd/winbindd_dual.c @@ -1463,6 +1463,14 @@ static bool fork_domain_child(struct winbindd_child *child) FD_SET(state.sock, r_fds); maxfd = state.sock; + /* +* Initialize this high as event_add_to_select_args() +* uses a timeval_min() on this and next_event. Fix +* from Roel van Meer ro...@alt001.com. +*/ + t.tv_sec = 99; + t.tv_usec = 0; + event_add_to_select_args(winbind_event_context(), now, r_fds, w_fds, t, maxfd); tp = get_timed_events_timeout(winbind_event_context(), t); -- Samba Shared Repository
Build status as of Sat Feb 27 07:00:05 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-02-26 00:00:23.0 -0700 +++ /home/build/master/cache/broken_results.txt 2010-02-27 00:00:12.0 -0700 @@ -1,9 +1,9 @@ -Build status as of Fri Feb 26 07:00:07 2010 +Build status as of Sat Feb 27 07:00:05 2010 Build counts: Tree Total Broken Panic build_farm 0 0 0 -ccache 35 19 0 +ccache 35 16 0 ldb 35 34 0 libreplace 35 12 0 lorikeet 0 0 0 @@ -13,9 +13,9 @@ samba-docs 0 0 0 samba-web0 0 0 samba_3_current 33 32 2 -samba_3_master 33 32 3 +samba_3_master 33 31 3 samba_3_next 29 29 4 -samba_4_0_test 35 33 1 +samba_4_0_test 35 32 0 talloc 35 11 0 tdb 33 22 0