Build status as of Wed Jun 30 06:00:01 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-06-29 00:00:02.0 -0600 +++ /home/build/master/cache/broken_results.txt 2010-06-30 00:00:21.0 -0600 @@ -1,4 +1,4 @@ -Build status as of Tue Jun 29 06:00:01 2010 +Build status as of Wed Jun 30 06:00:01 2010 Build counts: Tree Total Broken Panic
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 6abfe89... s4:schema/schema_set.c - free LDB message diffs
via 2821abe... s4:auth/session.c - free group_string when not needed
from 32b8b40... s4:dsdb Fix possible schema segfaults for
DRS-replication based schema
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 6abfe8904a1024512c0ea8bb4844e4409e8d994b
Author: Anatoliy Atanasov anatoliy.atana...@postpath.com
Date: Thu Jun 24 20:48:07 2010 +0300
s4:schema/schema_set.c - free LDB message diffs
Especially the frees after ldb_msg_diff are very important since the
diff
message is allocated on the long-living LDB context.
Signed-off-by: Matthias Dieter Wallnöfer m...@samba.org
commit 2821abee1f85c5d9a191a9880808b7022ac2e0b1
Author: Anatoliy Atanasov anatoliy.atana...@postpath.com
Date: Thu Jun 24 20:48:07 2010 +0300
s4:auth/session.c - free group_string when not needed
Signed-off-by: Matthias Dieter Wallnöfer m...@samba.org
---
Summary of changes:
source4/auth/session.c |2 +-
source4/dsdb/schema/schema_set.c |2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/auth/session.c b/source4/auth/session.c
index 29ba13e..1be9874 100644
--- a/source4/auth/session.c
+++ b/source4/auth/session.c
@@ -178,7 +178,7 @@ _PUBLIC_ NTSTATUS auth_generate_session_info(TALLOC_CTX
*mem_ctx,
group_dn = talloc_asprintf(tmp_ctx, SID=%s, group_string);
NT_STATUS_HAVE_NO_MEMORY_AND_FREE(group_dn, server_info);
-
+ talloc_free(group_string);
group_blob = data_blob_string_const(group_dn);
/* This function takes in memberOf values and expands
diff --git a/source4/dsdb/schema/schema_set.c b/source4/dsdb/schema/schema_set.c
index 0e04f5b..b5d8ae4 100644
--- a/source4/dsdb/schema/schema_set.c
+++ b/source4/dsdb/schema/schema_set.c
@@ -140,6 +140,7 @@ static int dsdb_schema_set_attributes(struct ldb_context
*ldb, struct dsdb_schem
if (mod_msg-num_elements 0) {
ret = dsdb_replace(ldb, mod_msg, 0);
}
+ talloc_free(mod_msg);
}
if (ret == LDB_ERR_OPERATIONS_ERROR || ret ==
LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS || ret == LDB_ERR_INVALID_DN_SYNTAX) {
@@ -168,6 +169,7 @@ static int dsdb_schema_set_attributes(struct ldb_context
*ldb, struct dsdb_schem
if (mod_msg-num_elements 0) {
ret = dsdb_replace(ldb, mod_msg, 0);
}
+ talloc_free(mod_msg);
}
if (ret == LDB_ERR_OPERATIONS_ERROR || ret ==
LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS || ret == LDB_ERR_INVALID_DN_SYNTAX) {
/* We might be on a read-only DB */
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via bf844ae... s4:auth/session.c - suppress a warning when freeing
group_string
from 6abfe89... s4:schema/schema_set.c - free LDB message diffs
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit bf844aed5b6ad6a9a5287ebd9b7da121fa9dd1a8
Author: Matthias Dieter Wallnöfer m...@samba.org
Date: Wed Jun 30 09:37:08 2010 +0200
s4:auth/session.c - suppress a warning when freeing group_string
---
Summary of changes:
source4/auth/session.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/auth/session.c b/source4/auth/session.c
index 1be9874..e14644d 100644
--- a/source4/auth/session.c
+++ b/source4/auth/session.c
@@ -170,15 +170,17 @@ _PUBLIC_ NTSTATUS auth_generate_session_info(TALLOC_CTX
*mem_ctx,
}
for (i = 0; i server_info-n_domain_groups; i++) {
- const char *group_string;
+ char *group_string;
const char *group_dn;
DATA_BLOB group_blob;
- group_string = dom_sid_string(tmp_ctx,
server_info-domain_groups[i]);
+
+ group_string = dom_sid_string(tmp_ctx,
+ server_info-domain_groups[i]);
NT_STATUS_HAVE_NO_MEMORY_AND_FREE(group_string, server_info);
group_dn = talloc_asprintf(tmp_ctx, SID=%s, group_string);
- NT_STATUS_HAVE_NO_MEMORY_AND_FREE(group_dn, server_info);
talloc_free(group_string);
+ NT_STATUS_HAVE_NO_MEMORY_AND_FREE(group_dn, server_info);
group_blob = data_blob_string_const(group_dn);
/* This function takes in memberOf values and expands
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 45fc728... libcli: Fixed a build warning for a missing prototype. from bf844ae... s4:auth/session.c - suppress a warning when freeing group_string http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 45fc7284982f3d6d3f5757f2e7336c878c4a6519 Author: Andreas Schneider a...@samba.org Date: Wed Jun 30 10:19:07 2010 +0200 libcli: Fixed a build warning for a missing prototype. --- Summary of changes: libcli/auth/schannel_state_tdb.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Changeset truncated at 500 lines: diff --git a/libcli/auth/schannel_state_tdb.c b/libcli/auth/schannel_state_tdb.c index 0dcc336..4b83a33 100644 --- a/libcli/auth/schannel_state_tdb.c +++ b/libcli/auth/schannel_state_tdb.c @@ -27,6 +27,7 @@ #include ../lib/util/util_tdb.h #include ../libcli/auth/libcli_auth.h #include ../libcli/auth/schannel_state.h +#include ../libcli/auth/schannel_proto.h #include ../librpc/gen_ndr/ndr_schannel.h #if _SAMBA_BUILD_ == 4 #include tdb_wrap.h -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 14f8953... s4:dsdb: move dsdb python tests from lib/ldb/ to dsdb/ via 19d93c6... s4:ldb/python: make it possible to run tests standalone from 45fc728... libcli: Fixed a build warning for a missing prototype. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 14f8953aa4f000173a051b8010252063db5295c1 Author: Stefan Metzmacher me...@samba.org Date: Wed Jun 30 11:09:10 2010 +0200 s4:dsdb: move dsdb python tests from lib/ldb/ to dsdb/ metze commit 19d93c6a1e810dbd634f35cf440412c1ff958448 Author: Stefan Metzmacher me...@samba.org Date: Wed Jun 30 10:57:37 2010 +0200 s4:ldb/python: make it possible to run tests standalone metze --- Summary of changes: source4/dsdb/tests/python/acl.py | 1042 source4/dsdb/tests/python/deletetest.py| 201 ++ source4/dsdb/tests/python/dsdb_schema_info.py | 213 ++ source4/dsdb/tests/python/ldap.py | 2688 source4/dsdb/tests/python/ldap_schema.py | 556 source4/dsdb/tests/python/passwords.py | 615 + source4/dsdb/tests/python/sec_descriptor.py| 1979 ++ source4/dsdb/tests/python/urgent_replication.py| 386 +++ source4/lib/ldb/tests/python/acl.py| 1039 source4/lib/ldb/tests/python/deletetest.py | 201 -- source4/lib/ldb/tests/python/dsdb_schema_info.py | 210 -- source4/lib/ldb/tests/python/ldap.py | 2685 --- source4/lib/ldb/tests/python/ldap_schema.py| 553 source4/lib/ldb/tests/python/passwords.py | 612 - source4/lib/ldb/tests/python/sec_descriptor.py | 1976 -- source4/lib/ldb/tests/python/urgent_replication.py | 385 --- source4/selftest/tests.sh | 16 +- 17 files changed, 7688 insertions(+), 7669 deletions(-) create mode 100755 source4/dsdb/tests/python/acl.py create mode 100755 source4/dsdb/tests/python/deletetest.py create mode 100755 source4/dsdb/tests/python/dsdb_schema_info.py create mode 100755 source4/dsdb/tests/python/ldap.py create mode 100755 source4/dsdb/tests/python/ldap_schema.py create mode 100755 source4/dsdb/tests/python/passwords.py create mode 100755 source4/dsdb/tests/python/sec_descriptor.py create mode 100755 source4/dsdb/tests/python/urgent_replication.py delete mode 100755 source4/lib/ldb/tests/python/acl.py delete mode 100755 source4/lib/ldb/tests/python/deletetest.py delete mode 100755 source4/lib/ldb/tests/python/dsdb_schema_info.py delete mode 100755 source4/lib/ldb/tests/python/ldap.py delete mode 100755 source4/lib/ldb/tests/python/ldap_schema.py delete mode 100755 source4/lib/ldb/tests/python/passwords.py delete mode 100755 source4/lib/ldb/tests/python/sec_descriptor.py delete mode 100755 source4/lib/ldb/tests/python/urgent_replication.py Changeset truncated at 500 lines: diff --git a/source4/dsdb/tests/python/acl.py b/source4/dsdb/tests/python/acl.py new file mode 100755 index 000..5bf3ff9 --- /dev/null +++ b/source4/dsdb/tests/python/acl.py @@ -0,0 +1,1042 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +# This is unit with tests for LDAP access checks + +import optparse +import sys +import base64 +import re + +sys.path.append(bin/python) +import samba +samba.ensure_external_module(subunit, subunit/python) +samba.ensure_external_module(testtools, testtools) + +import samba.getopt as options + +from ldb import ( +SCOPE_BASE, LdbError, ERR_NO_SUCH_OBJECT, ERR_INSUFFICIENT_ACCESS_RIGHTS) + +from samba.ndr import ndr_pack, ndr_unpack +from samba.dcerpc import security + +from samba.auth import system_session +from samba import gensec +from samba.samdb import SamDB +from samba.credentials import Credentials +import samba.tests +from subunit.run import SubunitTestRunner +import unittest + +parser = optparse.OptionParser(ldap [options] host) +sambaopts = options.SambaOptions(parser) +parser.add_option_group(sambaopts) +parser.add_option_group(options.VersionOptions(parser)) + +# use command line creds if available +credopts = options.CredentialsOptions(parser) +parser.add_option_group(credopts) +opts, args = parser.parse_args() + +if len(args) 1: +parser.print_usage() +sys.exit(1) + +host = args[0] + +lp = sambaopts.get_loadparm() +creds = credopts.get_credentials(lp) +creds.set_gensec_features(creds.get_gensec_features() | gensec.FEATURE_SEAL) + +# +# Tests start here +# + +class AclTests(samba.tests.TestCase): + +def delete_force(self, ldb, dn): +try: +ldb.delete(dn) +except LdbError, (num, _): +self.assertEquals(num, ERR_NO_SUCH_OBJECT) + +def find_basedn(self, ldb): +res = ldb.search(base=, expression=, scope=SCOPE_BASE, +
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 6961048... s4-smbtorture: in extended setvalue winreg test, reduce
max random buffer length to 16 bytes.
via 17ddefe... s3-docs: try to make default case explanation a little
clearer.
via 6625aad... s3-libsmb: move change_trust_account_password out of
smbd into libsmb.
via e1c185d... s4-smbtorture: enable QueryMultipleValues{2} torture
tests against samba3.
via 2a4bd64... s3-winreg: implement _winreg_QueryMultipleValues().
via de0d9e0... s3-winreg: implement _winreg_QueryMultipleValues2().
via 21869f5... s3-registry: add reg_querymultiplevalues() to reg_api.
via a329dd0... s4-smbtorture: add some more multiple_values_tests to
RPC-WINREG.
from 14f8953... s4:dsdb: move dsdb python tests from lib/ldb/ to dsdb/
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 69610484872bb8c9d52cd1b12c56a3bf99be78ae
Author: Günther Deschner g...@samba.org
Date: Wed Jun 30 17:13:42 2010 +0200
s4-smbtorture: in extended setvalue winreg test, reduce max random buffer
length to 16 bytes.
Guenther
commit 17ddefef8a3dd299fd318a9e3908396beba62cbb
Author: Günther Deschner g...@samba.org
Date: Wed Jun 30 13:25:28 2010 +0200
s3-docs: try to make default case explanation a little clearer.
Guenther
commit 6625aada8174d61f52d6ef22d49edefa15f4a9bb
Author: Günther Deschner g...@samba.org
Date: Wed Jun 30 12:10:55 2010 +0200
s3-libsmb: move change_trust_account_password out of smbd into libsmb.
Guenther
commit e1c185d07db69827435812227a392e711bc06db0
Author: Günther Deschner g...@samba.org
Date: Wed Jun 30 02:07:15 2010 +0200
s4-smbtorture: enable QueryMultipleValues{2} torture tests against samba3.
Guenther
commit 2a4bd64973252d87b34f90e14872285ed12135ed
Author: Günther Deschner g...@samba.org
Date: Wed Jun 30 16:31:46 2010 +0200
s3-winreg: implement _winreg_QueryMultipleValues().
Guenther
commit de0d9e0bff7d39c3f784112bd043095aeaa1042a
Author: Günther Deschner g...@samba.org
Date: Wed Jun 30 02:03:27 2010 +0200
s3-winreg: implement _winreg_QueryMultipleValues2().
Guenther
commit 21869f5ed00af5a05f1d109339cd8b725fcc7d61
Author: Günther Deschner g...@samba.org
Date: Wed Jun 30 02:02:43 2010 +0200
s3-registry: add reg_querymultiplevalues() to reg_api.
Guenther
commit a329dd02674010e673fbcc7acf369a19befb6738
Author: Günther Deschner g...@samba.org
Date: Wed Jun 30 17:13:14 2010 +0200
s4-smbtorture: add some more multiple_values_tests to RPC-WINREG.
Guenther
---
Summary of changes:
docs-xml/manpages-3/smb.conf.5.xml | 10 ++--
source3/Makefile.in|2 +-
source3/include/proto.h|5 +-
source3/include/registry.h |6 ++
source3/libsmb/trusts_util.c | 74 +++
source3/registry/reg_api.c | 50 +
source3/rpc_server/srv_winreg_nt.c | 138 +---
source3/smbd/change_trust_pw.c | 102 --
source4/torture/rpc/winreg.c | 20 --
9 files changed, 280 insertions(+), 127 deletions(-)
delete mode 100644 source3/smbd/change_trust_pw.c
Changeset truncated at 500 lines:
diff --git a/docs-xml/manpages-3/smb.conf.5.xml
b/docs-xml/manpages-3/smb.conf.5.xml
index 5df579e..7423fc4 100644
--- a/docs-xml/manpages-3/smb.conf.5.xml
+++ b/docs-xml/manpages-3/smb.conf.5.xml
@@ -628,11 +628,11 @@ chmod 1770 /usr/local/samba/lib/usershares
termdefault case = upper/lower/term
listitempara
controls what the default case is for new filenames (ie. files
that don't currently exist in the filesystem).
- Default emphasislower/emphasis. IMPORTANT NOTE: This
option will be used to modify the case of
- emphasisall/emphasis incoming client filenames, not just
new filenames if the options smbconfoption
- name=case sensitiveyes/smbconfoption, smbconfoption
name=preserve caseNo/smbconfoption,
- smbconfoption name=short preserve caseNo/smbconfoption
are set. This change is needed as part of the
- optimisations for directories containing large numbers of files.
+ Default emphasislower/emphasis. IMPORTANT NOTE: As part of
the optimizations for directories containing
+ large numbers of files, the following special case applies. If
the options
+ smbconfoption name=case sensitiveyes/smbconfoption,
smbconfoption name=preserve caseNo/smbconfoption, and
+ smbconfoption name=short preserve caseNo/smbconfoption
are set, then the case of emphasisall/emphasis
+ incoming client filenames, not just new filenames, will be
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 74721bf... s3-registry: fix malloc/talloc mismatch upon free in
reg_enumvalue().
from 6961048... s4-smbtorture: in extended setvalue winreg test, reduce
max random buffer length to 16 bytes.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 74721bf706371d3fdc5783995a60808763fc7e6d
Author: Günther Deschner g...@samba.org
Date: Thu Jul 1 01:22:11 2010 +0200
s3-registry: fix malloc/talloc mismatch upon free in reg_enumvalue().
Guenther
---
Summary of changes:
source3/registry/reg_api.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index 1954fb5..65118b9 100644
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -369,7 +369,7 @@ WERROR reg_enumvalue(TALLOC_CTX *mem_ctx, struct
registry_key *key,
if (pname
!(*pname = talloc_strdup(
mem_ctx, regval_name(blob {
- SAFE_FREE(val);
+ TALLOC_FREE(val);
return WERR_NOMEM;
}
--
Samba Shared Repository
