Build status as of Sun Jul 18 06:00:02 2010
URL: http://build.samba.org/ --- /home/build/master/cache/broken_results.txt.old 2010-07-17 00:00:04.0 -0600 +++ /home/build/master/cache/broken_results.txt 2010-07-18 00:00:05.0 -0600 @@ -1,9 +1,9 @@ -Build status as of Sat Jul 17 06:00:03 2010 +Build status as of Sun Jul 18 06:00:02 2010 Build counts: Tree Total Broken Panic build_farm 0 0 0 -ccache 30 7 0 +ccache 30 1 0 ldb 30 9 0 libreplace 30 11 0 lorikeet 0 0 0
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via b9835a1... s3: Don't use as-needed from bd54969... pam_winbind: Fix shadowing a global on FreeBSD http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit b9835a1f9d8b81e4121a01a190dffaefe67cbe5c Author: Volker Lendecke v...@samba.org Date: Sun Jul 18 11:56:17 2010 +0200 s3: Don't use as-needed This is just broken. RHEL5 can't deal with it, FreeBSD8 is broken with it, and who knows what other platforms are broken. I can rather live with a system that links in a bit too much than a system that does not work at all. --- Summary of changes: source3/configure.in | 33 - 1 files changed, 0 insertions(+), 33 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/configure.in b/source3/configure.in index 6157f37..43119fb 100644 --- a/source3/configure.in +++ b/source3/configure.in @@ -1799,39 +1799,6 @@ fi AC_MSG_RESULT($BLDSHARED) -saved_before_as_needed_ldflags=$LDFLAGS -for flags in -Wl,--as-needed -Wl,-z,ignore -z ignore ; do - saved_ldflags=$LDFLAGS - AC_MSG_CHECKING([if $flags works]) - LDFLAGS=$flags $saved_ldflags - AC_TRY_LINK([],[], - [AC_MSG_RESULT([yes]) - LD_AS_NEEDED_FLAG=$flags - ld_as_needed_flag_found=yes], - AC_MSG_RESULT([no])) - LDFLAGS=$LD_AS_NEEDED_FLAG $saved_ldflags - test x$ld_as_needed_flag_found = xyes break -done - -# check if we have to disable LD_AS_NEEDED_FLAG: -# On some systems for a veriety of reasons linking with -# -Wl,--as-needed -lreadline -lncurses fails -# we have to retest, if these combination is detected before. -# Bugzilla #7209 - -if test x$ac_cv_lib_readline_rl_callback_handler_install = xyes ; then - if test x$ld_as_needed_flag_found = xyes ; then - AC_MSG_CHECKING([if $LD_AS_NEEDED_FLAG works with readline]) - # try if check no fails - save_LIBS=$LIBS - LIBS=$LIBS $TERMLIBS - AC_TRY_LINK([], [rl_callback_handler_install();], [AC_MSG_RESULT([yes])],[ AC_MSG_RESULT([no]); LDFLAGS=$saved_before_as_needed_ldflags]) - LIBS=$save_LIBS -fi -fi - - - # for historical reasons almost all linkers don't complain about unresolved # symbols in shared libs. Except for the internal samba modules we want to get # errors when we produce a shared lib with unresolved symbols. On some -- Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 0d16a59... s3-waf: Fixed the build.
from b9835a1... s3: Don't use as-needed
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 0d16a591f4053785f419b27b7bc9694ecdd47fd0
Author: Andreas Schneider a...@samba.org
Date: Sun Jul 18 11:28:24 2010 +0200
s3-waf: Fixed the build.
---
Summary of changes:
source3/wscript_build |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/wscript_build b/source3/wscript_build
index 92c4bdf..f526501 100644
--- a/source3/wscript_build
+++ b/source3/wscript_build
@@ -415,8 +415,10 @@ RPC_SERVER_SRC = '''${RPC_PIPE_SRC} ${NPA_TSTREAM_SRC}'''
RPC_PARSE_SRC = '''${RPC_PARSE_SRC2}'''
-RPC_CLIENT_SRC = '''rpc_client/cli_pipe.c rpc_client/rpc_transport_np.c
-rpc_client/rpc_transport_sock.c rpc_client/rpc_transport_smbd.c'''
+RPC_CLIENT_SRC = '''rpc_client/cli_pipe.c librpc/rpc/rpc_common.c
+rpc_client/rpc_transport_np.c
+ rpc_client/rpc_transport_sock.c
+ rpc_client/rpc_transport_smbd.c'''
LOCKING_SRC = '''locking/locking.c locking/brlock.c locking/posix.c'''
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 898fd58... s3-rpc_client: Fixed a segfault in
rpccli_samr_chng_pswd_auth_crap().
from 0d16a59... s3-waf: Fixed the build.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 898fd584a4f96ba40c2692550518856671892add
Author: Andreas Schneider a...@samba.org
Date: Sun Jul 18 15:04:20 2010 +0200
s3-rpc_client: Fixed a segfault in rpccli_samr_chng_pswd_auth_crap().
This fixes the WINBIND-WBCLIENT test. The test set
old_lm_hash_enc_blob.length to 0 and we don't check the length here. So
the memcpy segfaulted.
---
Summary of changes:
source3/rpc_client/cli_samr.c | 27 +++
1 files changed, 23 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_client/cli_samr.c b/source3/rpc_client/cli_samr.c
index 8c92ebb..8c10112 100644
--- a/source3/rpc_client/cli_samr.c
+++ b/source3/rpc_client/cli_samr.c
@@ -165,10 +165,29 @@ NTSTATUS rpccli_samr_chng_pswd_auth_crap(struct
rpc_pipe_client *cli,
init_lsa_String(server, cli-srv_name_slash);
init_lsa_String(account, username);
- memcpy(new_nt_password.data, new_nt_password_blob.data, 516);
- memcpy(new_lm_password.data, new_lm_password_blob.data, 516);
- memcpy(old_nt_hash_enc.hash, old_nt_hash_enc_blob.data, 16);
- memcpy(old_lm_hash_enc.hash, old_lm_hash_enc_blob.data, 16);
+ if (new_nt_password_blob.length 0) {
+ memcpy(new_nt_password.data, new_nt_password_blob.data, 516);
+ } else {
+ ZERO_STRUCT(new_nt_password_blob);
+ }
+
+ if (new_lm_password_blob.length 0) {
+ memcpy(new_lm_password.data, new_lm_password_blob.data, 516);
+ } else {
+ ZERO_STRUCT(new_lm_password);
+ }
+
+ if (old_nt_hash_enc_blob.length 0) {
+ memcpy(old_nt_hash_enc.hash, old_nt_hash_enc_blob.data, 16);
+ } else {
+ ZERO_STRUCT(old_nt_hash_enc);
+ }
+
+ if (old_lm_hash_enc_blob.length 0) {
+ memcpy(old_lm_hash_enc.hash, old_lm_hash_enc_blob.data, 16);
+ } else {
+ ZERO_STRUCT(old_lm_hash_enc);
+ }
result = rpccli_samr_ChangePasswordUser2(cli, mem_ctx,
server,
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 27aece7... s3: Actually use the usecs in aio_fork_suspend
via 1946beb... s3: Fix an uninitialized variable
via 55512f4... s3: Work better without the aio sighandler
via b1717ac... s3: Fix some nonempty blank lines
via 7ac5828... s3: Remove a direct use of procid_self()
from 898fd58... s3-rpc_client: Fixed a segfault in
rpccli_samr_chng_pswd_auth_crap().
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 27aece72004a84a6e0b2e00987d8a362e307d1d8
Author: Volker Lendecke v...@samba.org
Date: Sun Jul 18 17:12:30 2010 +0200
s3: Actually use the usecs in aio_fork_suspend
Jeremy, please check!
commit 1946beb679c7de75b142b30d84b5e4bf12c7e6bd
Author: Volker Lendecke v...@samba.org
Date: Sun Jul 18 17:12:11 2010 +0200
s3: Fix an uninitialized variable
commit 55512f479172047ae7f69604c23fffecf66de8c4
Author: Volker Lendecke v...@samba.org
Date: Sun Jul 18 14:40:43 2010 +0200
s3: Work better without the aio sighandler
Refuse async I/O if we can't set up the signal handler
commit b1717ac92edbc08e1f4cd2a38dd9f60be8492469
Author: Volker Lendecke v...@samba.org
Date: Sun Jul 18 13:39:51 2010 +0200
s3: Fix some nonempty blank lines
commit 7ac58281aeebe4be282ca719ba1da2f821e521a5
Author: Volker Lendecke v...@samba.org
Date: Sat Jul 17 23:16:26 2010 +0200
s3: Remove a direct use of procid_self()
---
Summary of changes:
source3/modules/vfs_aio_fork.c |5 +++--
source3/smbd/aio.c | 29 ++---
source3/utils/net_dns.c | 10 --
source3/winbindd/winbindd_dual.c |8 +---
4 files changed, 34 insertions(+), 18 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/modules/vfs_aio_fork.c b/source3/modules/vfs_aio_fork.c
index b43aad2..02b1394 100644
--- a/source3/modules/vfs_aio_fork.c
+++ b/source3/modules/vfs_aio_fork.c
@@ -765,10 +765,11 @@ static int aio_fork_suspend(struct vfs_handle_struct
*handle,
}
if (timeout) {
- struct timeval tv;
+ struct timeval tv = convert_timespec_to_timeval(*timeout);
struct tevent_timer *te = tevent_add_timer(ev,
frame,
-
timeval_current_ofs(tv.tv_sec,0),
+ timeval_current_ofs(tv.tv_sec,
+ tv.tv_usec),
aio_fork_suspend_timed_out,
timed_out);
if (!te) {
diff --git a/source3/smbd/aio.c b/source3/smbd/aio.c
index a5a0e44..dbce120 100644
--- a/source3/smbd/aio.c
+++ b/source3/smbd/aio.c
@@ -67,11 +67,17 @@ static void smbd_aio_signal_handler(struct tevent_context
*ev_ctx,
}
-static void initialize_async_io_handler(void)
+static bool initialize_async_io_handler(void)
{
+ static bool tried_signal_setup = false;
+
if (aio_signal_event) {
- return;
+ return true;
+ }
+ if (tried_signal_setup) {
+ return false;
}
+ tried_signal_setup = true;
aio_signal_event = tevent_add_signal(smbd_event_context(),
smbd_event_context(),
@@ -79,7 +85,8 @@ static void initialize_async_io_handler(void)
smbd_aio_signal_handler,
NULL);
if (!aio_signal_event) {
- exit_server(Failed to setup RT_SIGNAL_AIO handler);
+ DEBUG(10, (Failed to setup RT_SIGNAL_AIO handler\n));
+ return false;
}
/* tevent supports 100 signal with SA_SIGINFO */
@@ -145,7 +152,9 @@ NTSTATUS schedule_aio_read_and_X(connection_struct *conn,
int ret;
/* Ensure aio is initialized. */
- initialize_async_io_handler();
+ if (!initialize_async_io_handler()) {
+ return NT_STATUS_RETRY;
+ }
if (fsp-base_fsp != NULL) {
/* No AIO on streams yet */
@@ -250,7 +259,9 @@ NTSTATUS schedule_aio_write_and_X(connection_struct *conn,
int ret;
/* Ensure aio is initialized. */
- initialize_async_io_handler();
+ if (!initialize_async_io_handler()) {
+ return NT_STATUS_RETRY;
+ }
if (fsp-base_fsp != NULL) {
/* No AIO on streams yet */
@@ -382,7 +393,9 @@ NTSTATUS schedule_smb2_aio_read(connection_struct *conn,
int ret;
/* Ensure aio is initialized. */
- initialize_async_io_handler();
+ if (!initialize_async_io_handler()) {
+ return
