[SCM] Samba Shared Repository - branch v3-6-stable updated
The branch, v3-6-stable has been updated via 0356de9 WHATSNEW: Prepare release notes for 3.6.11. via af874a7 ntlm_auth(1): fix format and make examples visible (bug #9569) via 9f09687 Fix bug #9471 - SEGV when using second vfs module. via a3f5202 Fix bug #9196 - defer_open is triggered multiple times on the same request. via 2b8c53d Fix bug 9548: Correctly detect O_DIRECT (cherry picked from commit c89f3ddd5db2de099e5b871d41553637d35e4097) via 5be19ac lib/replace: Add missing check for sys/wait.h via 68082b1 lib/replace: Add ucontext configure autoconf checks. via 5e1f60f lib/replace: Include sys/ucontext.h if available. via afb78ae tevent: Fix bug 9550 - sigprocmask does not work on FreeBSD to stop further signals in a signal handler via 5bbb6b6 configure: Fix bug 9546, aio_suspend detection on FreeBSD from acd5be0 WHATSNEW: Start release notes for Samba 3.6.11. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-stable - Log - commit 0356de9521fbd72ecf0f1707563b44227a182eed Author: Karolin Seeger ksee...@samba.org Date: Fri Jan 18 11:23:51 2013 +0100 WHATSNEW: Prepare release notes for 3.6.11. Karolin (cherry picked from commit 090d346017d5b3afb1baaa26d3c05ecb721fbd24) commit af874a7a96dd119673d473f332cd6efa20a8df85 Author: Björn Baumbach b...@sernet.de Date: Tue Dec 4 10:54:05 2012 +0100 ntlm_auth(1): fix format and make examples visible (bug #9569) example is no child of para. So these examples were not visible. Using a varlist instead may be not the best way but it does look nice. Signed-off-by: Björn Baumbach b...@sernet.de Reviewed-by: Michael Adam ob...@samba.org Reviewed-by: Volker Lendecke v...@samba.org (cherry picked from commit cabc89a1e72fc95300d4b6f8d480a7d666221b8b) (cherry picked from commit 2cd0314f1fe47ac30e0df6791ff27850b09e6d83) commit 9f096874faef1162f04f00641710aacb685b0c40 Author: Tsukasa Hamano ham...@osstech.co.jp Date: Thu Dec 6 13:01:33 2012 -0800 Fix bug #9471 - SEGV when using second vfs module. Don't use default_classname_table when we obviously shoud be using classname_table. Reviewed by: Jeremy Allison j...@samba.org Reviewed-by: Michael Adam ob...@samba.org Autobuild-User(master): Michael Adam ob...@samba.org Autobuild-Date(master): Fri Dec 7 17:51:50 CET 2012 on sn-devel-104 (cherry picked from commit 16d725b4f5ed77db865e2a3c27ae0eb4accca5a8) (cherry picked from commit 25eb1af07cc09e5e019a0702c60a763cc3266196) (cherry picked from commit 82db35cdb426355e4b7fd7ecf1ce9d9fca59ecd3) commit a3f5202cfeb48b64ffe9958b35c477c9d4f68788 Author: Jeremy Allison j...@samba.org Date: Fri Dec 14 08:56:52 2012 -0800 Fix bug #9196 - defer_open is triggered multiple times on the same request. get_deferred_open_message_state_smb2() is buggy in that it is checking the wrong things to determine if an open is in the deferred state. It checks if (smb2req-async == NULL) which is incorrect, as we're not always async in a deferred open - remove this. It should check instead state-open_was_deferred as this is explicity set to 'true' when an open is going deferred, so add this check. Signed-off-by: Jeremy Allison j...@samba.org (cherry picked from commit a8658bcb67927282288af5a579e3e66d3eaaac7b) commit 2b8c53d70129a7d364de00d220a547ec7bc900b2 Author: Volker Lendecke v...@samba.org Date: Sat Jan 12 16:08:07 2013 +0100 Fix bug 9548: Correctly detect O_DIRECT (cherry picked from commit c89f3ddd5db2de099e5b871d41553637d35e4097) commit 5be19aca9d07397bc49f3539aa8d358f561430b0 Author: Jeremy Allison j...@samba.org Date: Mon Jan 14 15:06:12 2013 -0800 lib/replace: Add missing check for sys/wait.h Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org (cherry picked from commit 8de4edd42cf16bd761a6acc2c8b5656d088969a7) commit 68082b1fc0b23921dd0ffc86d07f3f37f09224ea Author: Jeremy Allison j...@samba.org Date: Tue Jan 15 10:16:27 2013 -0800 lib/replace: Add ucontext configure autoconf checks. Signed-off-by: Jeremy Allison j...@samba.org (cherry picked from commit d78f760280473c35b33d4f17d31528dd6269405a) commit 5e1f60fbd3b7094d8790d3f089b3d38dd7490227 Author: Jeremy Allison j...@samba.org Date: Mon Jan 14 15:21:52 2013 -0800 lib/replace: Include sys/ucontext.h if available. Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Stefan Metzmacher me...@samba.org (cherry picked from commit 9a21bc35c565210767e71f4bc03a558fe61bdbc8) commit afb78ae9c048079c933eb6f6e7adcaf1ad40e7c2 Author: Jeremy Allison j...@samba.org Date: Mon Jan 14 15:22:11 2013 -0800 tevent: Fix bug 9550 - sigprocmask does not work on FreeBSD to stop further signals in
[SCM] Samba Shared Repository - annotated tag samba-3.6.11 created
The annotated tag, samba-3.6.11 has been created at 252c2b5f2f9256334881d4ce980f4c95929cb994 (tag) tagging 0356de9521fbd72ecf0f1707563b44227a182eed (commit) replaces samba-3.6.10 tagged by Karolin Seeger on Mon Jan 21 09:22:14 2013 +0100 - Log - tag samba-3.6.11 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.18 (GNU/Linux) iD8DBQBQ/PrEbzORW2Vot+oRAn4xAJ9mlAtoXi1pwGjcVMg/aFjiJbCu8wCePXeA Hryp4Hh+/A/GcKJnArHwmD4= =rERA -END PGP SIGNATURE- Björn Baumbach (1): ntlm_auth(1): fix format and make examples visible (bug #9569) Jeremy Allison (5): tevent: Fix bug 9550 - sigprocmask does not work on FreeBSD to stop further signals in a signal handler lib/replace: Include sys/ucontext.h if available. lib/replace: Add ucontext configure autoconf checks. lib/replace: Add missing check for sys/wait.h Fix bug #9196 - defer_open is triggered multiple times on the same request. Karolin Seeger (3): VERSION: Bump version up to 3.6.11. WHATSNEW: Start release notes for Samba 3.6.11. WHATSNEW: Prepare release notes for 3.6.11. Tsukasa Hamano (1): Fix bug #9471 - SEGV when using second vfs module. Volker Lendecke (2): configure: Fix bug 9546, aio_suspend detection on FreeBSD Fix bug 9548: Correctly detect O_DIRECT --- -- Samba Shared Repository
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 36005b2 Announce Samba 3.6.11. from ccd6164 Announce Call for Papers SambaXP 2013. http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 36005b294e292a7b9e5875e230d774634af80635 Author: Karolin Seeger ksee...@samba.org Date: Mon Jan 21 09:38:14 2013 +0100 Announce Samba 3.6.11. Karolin --- Summary of changes: generated_news/latest_10_bodies.html| 24 +++--- generated_news/latest_10_headlines.html |4 +- generated_news/latest_2_bodies.html | 29 -- history/header_history.html |1 + history/samba-3.6.11.html | 51 +++ 5 files changed, 79 insertions(+), 30 deletions(-) create mode 100755 history/samba-3.6.11.html Changeset truncated at 500 lines: diff --git a/generated_news/latest_10_bodies.html b/generated_news/latest_10_bodies.html index 6a858d8..a666f9c 100644 --- a/generated_news/latest_10_bodies.html +++ b/generated_news/latest_10_bodies.html @@ -1,3 +1,15 @@ + h5a name=3.6.1121 January 2013/a/h5 + p class=headlineSamba 3.6.11 Available for Download/p + pThis is the latest stable release of the Samba 3.6 series./p + +pThe uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +a href=http://samba.org/samba/ftp/stable/samba-3.6.11.tar.gz;downloaded +now/a. A a href=http://samba.org/samba/ftp/patches/patch-3.6.10-3.6.11.diffs.gz; +patch against Samba 3.6.10/a is also available. +See a href=http://samba.org/samba/history/samba-3.6.11.html; +the release notes for more info/a./p + h5a name=CfP15 January 2013/a/h5 p class=headlineCall for Papers SambaXP 2013/p @@ -95,15 +107,3 @@ now/a. A a href=http://samba.org/samba/ftp/patches/patch-3.5.18-3.5.19.diffs using GnuPG (ID 6568B7EA). The source code can be a href=https://download.samba.org/pub/samba/rc/samba-4.0.0rc4.tar.gz;downloaded now/a. See a href=https://download.samba.org/pub/samba/rc/WHATSNEW-4-0-0rc4.txt;the release notes for more info/a./p - - h5a name=3.6.929 October 2012/a/h5 - p class=headlineSamba 3.6.9 Available for Download/p - pThis is the latest stable release of the Samba 3.6 series./p - -pThe uncompressed tarballs and patch files have been signed -using GnuPG (ID 6568B7EA). The source code can be -a href=http://samba.org/samba/ftp/stable/samba-3.6.9.tar.gz;downloaded -now/a. A a href=http://samba.org/samba/ftp/patches/patch-3.6.8-3.6.9.diffs.gz; -patch against Samba 3.6.8/a is also available. -See a href=http://samba.org/samba/history/samba-3.6.9.html; -the release notes for more info/a./p diff --git a/generated_news/latest_10_headlines.html b/generated_news/latest_10_headlines.html index 9ae9e36..492893b 100644 --- a/generated_news/latest_10_headlines.html +++ b/generated_news/latest_10_headlines.html @@ -1,4 +1,6 @@ ul + li 21 January 2013 a href=#3.6.11Samba 3.6.11 Available for Download/a/li + li 15 January 2013 a href=#CfPCall for Papers SambaXP 2013/a/li li 15 January 2013 a href=#4.0.1Samba 4.0.1 Available for Download/a/li @@ -16,6 +18,4 @@ li 05 November 2012 a href=#3.5.19Samba 3.5.19 Available for Download/a/li li 30 October 2012 a href=#4.0.0rc4Samba 4.0.0rc4 Available for Download/a/li - - li 29 October 2012 a href=#3.6.9Samba 3.6.9 Available for Download/a/li /ul diff --git a/generated_news/latest_2_bodies.html b/generated_news/latest_2_bodies.html index e150ec7..1ae3eec 100644 --- a/generated_news/latest_2_bodies.html +++ b/generated_news/latest_2_bodies.html @@ -1,3 +1,16 @@ + h5a name=3.6.1121 January 2013/a/h5 + p class=headlineSamba 3.6.11 Available for Download/p + pThis is the latest stable release of the Samba 3.6 series./p + +pThe uncompressed tarballs and patch files have been signed +using GnuPG (ID 6568B7EA). The source code can be +a href=http://samba.org/samba/ftp/stable/samba-3.6.11.tar.gz;downloaded +now/a. A a href=http://samba.org/samba/ftp/patches/patch-3.6.10-3.6.11.diffs.gz; +patch against Samba 3.6.10/a is also available. +See a href=http://samba.org/samba/history/samba-3.6.11.html; +the release notes for more info/a./p + + h5a name=CfP15 January 2013/a/h5 p class=headlineCall for Papers SambaXP 2013/p @@ -7,19 +20,3 @@ Goettingen, Germany at the 12th international SAMBA conference, the pThe call for papers and early bird registration are open until February 28th 2013. Please find all necessary information at the a href=http://sambaXP.org;conference site/a. - - h5a name=4.0.115 January 2013/a/h5 - p class=headlineSamba 4.0.1 Available for Download/p - pThis is a bsecurity release/b./p - -pThis is a bsecurity release/b in order to address a
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via f70d0ac Tests: remove redondent testsuites in provision
via 95fc53a Tests: avoid adding python options that are functions in
the env
via e1ab7b6 Tests: rewrite ldap_schema to specify attributes
from 853360b Fix warnings with mismatched sizes in arguments to DEBUG
statements.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit f70d0ac7390fdd0f305f0ee1133fd9611caa
Author: Matthieu Patou m...@matws.net
Date: Thu Jan 3 14:34:31 2013 -0800
Tests: remove redondent testsuites in provision
Removed provision are already tested somewhere else.
Signed-off-by: Matthieu Patou m...@matws.net
Reviewed-by: Andrew Bartlett abart...@samba.org
Autobuild-User(master): Matthieu Patou m...@samba.org
Autobuild-Date(master): Mon Jan 21 09:59:43 CET 2013 on sn-devel-104
commit 95fc53a37b9c75cbc1d13432887de095ff779a1e
Author: Matthieu Patou m...@matws.net
Date: Thu Jan 3 14:34:13 2013 -0800
Tests: avoid adding python options that are functions in the env
This fix errors when running test --testenv --screen
Signed-off-by: Matthieu Patou m...@matws.net
Reviewed-by: Andrew Bartlett abart...@samba.org
commit e1ab7b68043c1f459541838c2b839bc7cb117c19
Author: Matthieu Patou m...@matws.net
Date: Tue Jan 1 13:40:44 2013 -0800
Tests: rewrite ldap_schema to specify attributes
Signed-off-by: Matthieu Patou m...@matws.net
Reviewed-by: Andrew Bartlett abart...@samba.org
---
Summary of changes:
selftest/wscript |7 -
source4/dsdb/tests/python/ldap_schema.py | 39 +---
source4/setup/tests/blackbox_provision.sh |7 +
3 files changed, 31 insertions(+), 22 deletions(-)
Changeset truncated at 500 lines:
diff --git a/selftest/wscript b/selftest/wscript
index 4733dc1..c7637a1 100644
--- a/selftest/wscript
+++ b/selftest/wscript
@@ -6,6 +6,7 @@
import Scripting, os, Options, Utils, Environment, optparse, sys
from samba_utils import *
from samba_autoconf import *
+import types
def set_options(opt):
@@ -114,7 +115,11 @@ def cmd_testonly(opt):
# put all command line options in the environment as TESTENV_*=*
for o in dir(Options.options):
if o[0:1] != '_':
-os.environ['TESTENV_%s' % o.upper()] =
str(getattr(Options.options, o, ''))
+val = getattr(Options.options, o, '')
+if not issubclass(type(val), types.FunctionType) \
+and not issubclass(type(val), types.MethodType):
+os.environ['TESTENV_%s' % o.upper()] =
str(getattr(Options.options, o, ''))
+
binary_mapping = ('nmblookup3:nmblookup,' +
'nmblookup4:nmblookup4,' +
diff --git a/source4/dsdb/tests/python/ldap_schema.py
b/source4/dsdb/tests/python/ldap_schema.py
index d77f553..fb0ef9c 100755
--- a/source4/dsdb/tests/python/ldap_schema.py
+++ b/source4/dsdb/tests/python/ldap_schema.py
@@ -67,8 +67,9 @@ class SchemaTests(samba.tests.TestCase):
def test_generated_schema_is_operational(self):
Testing we don't get the generated schema via LDAP by default
+# Must keep the * form
res = self.ldb.search(cn=aggregate,+self.schema_dn, scope=SCOPE_BASE,
-attrs=[*])
+ attrs=[*])
self.assertEquals(len(res), 1)
self.assertFalse(dITContentRules in res[0])
self.assertFalse(objectClasses in res[0])
@@ -106,7 +107,8 @@ schemaUpdateNow: 1
# Search for created attribute
res = []
-res = self.ldb.search(cn=%s,%s % (attr_name, self.schema_dn),
scope=SCOPE_BASE, attrs=[*])
+res = self.ldb.search(cn=%s,%s % (attr_name, self.schema_dn),
scope=SCOPE_BASE,
+ attrs=[lDAPDisplayName,schemaIDGUID])
self.assertEquals(len(res), 1)
self.assertEquals(res[0][lDAPDisplayName][0], attr_ldap_display_name)
self.assertTrue(schemaIDGUID in res[0])
@@ -160,7 +162,8 @@ systemOnly: FALSE
# Search for created objectclass
res = []
-res = self.ldb.search(cn=%s,%s % (class_name, self.schema_dn),
scope=SCOPE_BASE, attrs=[*])
+res = self.ldb.search(cn=%s,%s % (class_name, self.schema_dn),
scope=SCOPE_BASE,
+ attrs=[lDAPDisplayName,
defaultObjectCategory, schemaIDGUID, distinguishedName])
self.assertEquals(len(res), 1)
self.assertEquals(res[0][lDAPDisplayName][0],
class_ldap_display_name)
self.assertEquals(res[0][defaultObjectCategory][0],
res[0][distinguishedName][0])
@@ -193,7 +196,7 @@ name: + object_name +
# Search for created object
res = []
-res = self.ldb.search(cn=%s,cn=Users,%s % (object_name,
self.base_dn),
[SCM] Samba Shared Repository - branch v3-6-stable updated
The branch, v3-6-stable has been updated via 5f8ab89 WHATSNEW: Start release notes for Samba 3.6.12. via 0cd5f67 VERSION: Bump version number up to 3.6.12. from 0356de9 WHATSNEW: Prepare release notes for 3.6.11. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-stable - Log - commit 5f8ab89e41df7d2d5e37f3ee8c096c3a9c82f11a Author: Karolin Seeger ksee...@samba.org Date: Mon Jan 21 10:09:38 2013 +0100 WHATSNEW: Start release notes for Samba 3.6.12. Karolin (cherry picked from commit 6a11d2572ebe83a696c6366da7765fb123fa2987) commit 0cd5f67e526ebecacb8cd224cea9e43944a3bb14 Author: Karolin Seeger ksee...@samba.org Date: Mon Jan 21 10:06:31 2013 +0100 VERSION: Bump version number up to 3.6.12. Karolin (cherry picked from commit 29199e6771002e95ac9225be77226dc191c22325) --- Summary of changes: WHATSNEW.txt| 45 +++-- source3/VERSION |2 +- 2 files changed, 44 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 6599766..2f414bc 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,4 +1,44 @@ == + Release Notes for Samba 3.6.12 + March 18, 2013 + == + + +This is is the latest stable release of Samba 3.6. + +Major enhancements in Samba 3.6.12 include: + +o + +Changes since 3.6.11: + + +o Jeremy Allison j...@samba.org + + +## +Reporting bugs Development Discussion +### + +Please discuss this release on the samba-technical mailing list or by +joining the #samba-technical IRC channel on irc.freenode.net. + +If you do report problems then please try to send high quality +feedback. If you don't provide vital information to help us track down +the problem then you will probably be ignored. All bug reports should +be filed under the Samba 3.6 product in the project's Bugzilla +database (https://bugzilla.samba.org/). + + +== +== Our Code, Our Bugs, Our Responsibility. +== The Samba Team +== + +Release notes for older releases follow: + + + == Release Notes for Samba 3.6.11 January 21, 2013 == @@ -52,8 +92,9 @@ database (https://bugzilla.samba.org/). == The Samba Team == -Release notes for older releases follow: - + +-- + == Release Notes for Samba 3.6.10 diff --git a/source3/VERSION b/source3/VERSION index 075819c..c36d474 100644 --- a/source3/VERSION +++ b/source3/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=3 SAMBA_VERSION_MINOR=6 -SAMBA_VERSION_RELEASE=11 +SAMBA_VERSION_RELEASE=12 # Bug fix releases use a letter for the patch revision # -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 329ba78 docs-xml: add dbwrap_tool.1 manual page (fix bug #9568) from 6a11d25 WHATSNEW: Start release notes for Samba 3.6.12. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 329ba78272a03e2011743f4fd47b6094b271d573 Author: Björn Baumbach b...@sernet.de Date: Mon Oct 15 17:17:29 2012 +0200 docs-xml: add dbwrap_tool.1 manual page (fix bug #9568) Based on commit 8d6104f02d9ab879efe7867fec53cbe5cc408ded. Signed-off-by: Björn Baumbach b...@sernet.de Reviewed-by: Michael Adam ob...@samba.org Reviewed-by: Volker Lendecke v...@samba.org --- Summary of changes: docs-xml/manpages-3/dbwrap_tool.1.xml | 148 + 1 files changed, 148 insertions(+), 0 deletions(-) create mode 100644 docs-xml/manpages-3/dbwrap_tool.1.xml Changeset truncated at 500 lines: diff --git a/docs-xml/manpages-3/dbwrap_tool.1.xml b/docs-xml/manpages-3/dbwrap_tool.1.xml new file mode 100644 index 000..2a20701 --- /dev/null +++ b/docs-xml/manpages-3/dbwrap_tool.1.xml @@ -0,0 +1,148 @@ +?xml version=1.0 encoding=iso-8859-1? +!DOCTYPE refentry PUBLIC -//Samba-Team//DTD DocBook V4.2-Based Variant V1.0//EN http://www.samba.org/samba/DTD/samba-doc; +refentry id=dbwrap_tool.1 + +refmeta + refentrytitledbwrap_tool/refentrytitle + manvolnum1/manvolnum + refmiscinfo class=sourceSamba/refmiscinfo + refmiscinfo class=manualSystem Administration tools/refmiscinfo + refmiscinfo class=version3.6/refmiscinfo +/refmeta + + +refnamediv + refnamedbwrap_tool/refname + refpurposelow level TDB/CTDB manipulation tool using the dbwrap interface/refpurpose +/refnamediv + +refsynopsisdiv + cmdsynopsis + commanddbwrap_tool/command + arg choice=reqlt;databasegt;/arg + arg choice=reqlt;operationgt;/arg + arg choice=optlt;keygt; + arg choice=optlt;typegt; + arg choice=optlt;valuegt;/arg + /arg + /arg + /cmdsynopsis +/refsynopsisdiv + +refsect1 + titleDESCRIPTION/title + + paraThis tool is part of the citerefentryrefentrytitlesamba/refentrytitle + manvolnum7/manvolnum/citerefentry suite./para + + paraThe dbwrap_tool program is used to read and manipulate + TDB/CTDB databases using the dbwrap interface./para + + paraThe following database operations are available: + itemizedlist + listitemparafetch: fetch a record/para/listitem + listitemparastore: create or modify a record/para/listitem + listitemparadelete: remove a record/para/listitem + listitemparaerase: remove all records/para/listitem + listitemparalistkeys: list all available records/para/listitem + /itemizedlist + /para + paraThe following types are available: + itemizedlist + listitemparaint32: signed 32bit integer/para/listitem + listitemparauint32: unsigned 32bit integer/para/listitem + listitemparastring: hello world/para/listitem + /itemizedlist + /para +/refsect1 + +refsect1 + titleOPTIONS/title + + paraNone./para +/refsect1 + +refsect1 + titleCOMMANDS/title + refsect2 + titlefetch/title + cmdsynopsis + commanddbwrap_tool/command lt;databasegt; fetch lt;keygt; lt;typegt; + /cmdsynopsis + /refsect2 + refsect2 + titlestore/title + cmdsynopsis + commanddbwrap_tool/command lt;databasegt; store lt;keygt; lt;typegt; lt;valuegt; + /cmdsynopsis + /refsect2 + refsect2 + titledelete/title + cmdsynopsis + commanddbwrap_tool/command lt;databasegt; delete lt;keygt; + /cmdsynopsis + /refsect2 + refsect2 + titleerase/title + cmdsynopsis + commanddbwrap_tool/command lt;databasegt; erase + /cmdsynopsis + /refsect2 + refsect2 + titlelistkeys/title + cmdsynopsis + commanddbwrap_tool/command lt;databasegt; listkeys + /cmdsynopsis + /refsect2 +/refsect1 + +refsect1 + titleEXAMPLES/title + variablelist + varlistentrytermList all keys from winbindd_idmap.tdb/term + listitemparacommanddbwrap_tool/command winbindd_idmap.tdb listkeys/para/listitem + /varlistentry + varlistentrytermFetch record with key USER HWM as uint32/term + listitemparacommanddbwrap_tool/command
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via cd9c1a0 samr: Make use of posix_openpt
via 0018441 samr: Split up an assignment from an if condition
from 329ba78 docs-xml: add dbwrap_tool.1 manual page (fix bug #9568)
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit cd9c1a0a3abf0b44afd1054cca9c1da1cace1e52
Author: Volker Lendecke v...@samba.org
Date: Fri Jan 11 10:36:04 2013 +0100
samr: Make use of posix_openpt
The last 2 patches address bug #9541 - Add support for posix_openpt.
commit 00184412950adde1a3db0a16822d771d0868dfc3
Author: Volker Lendecke v...@samba.org
Date: Fri Jan 11 10:31:42 2013 +0100
samr: Split up an assignment from an if condition
---
Summary of changes:
source3/configure.in |2 +-
source3/rpc_server/samr/srv_samr_chgpasswd.c |7 ++-
source3/wscript |2 +-
3 files changed, 8 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/configure.in b/source3/configure.in
index 0f805ee..458ea39 100644
--- a/source3/configure.in
+++ b/source3/configure.in
@@ -1112,7 +1112,7 @@ AC_CHECK_FUNCS(sigprocmask sigblock sigaction sigset
innetgr setnetgrent getnetg
AC_CHECK_FUNCS(initgroups select rdchk getgrnam getgrent pathconf)
AC_CHECK_FUNCS(getgrset)
AC_CHECK_FUNCS(setpriv setgidx setuidx setgroups sysconf stat64 fstat64)
-AC_CHECK_FUNCS(lstat64 fopen64 atexit grantpt lseek64 ftruncate64
posix_fallocate posix_fallocate64)
+AC_CHECK_FUNCS(lstat64 fopen64 atexit grantpt posix_openpt lseek64 ftruncate64
posix_fallocate posix_fallocate64)
AC_CHECK_FUNCS(fallocate fallocate64)
AC_CHECK_FUNCS(fseeko fseek64 fseeko64 ftell64 ftello64 setluid getpwanam)
AC_CHECK_FUNCS(opendir64 readdir64 seekdir64 telldir64 rewinddir64 closedir64)
diff --git a/source3/rpc_server/samr/srv_samr_chgpasswd.c
b/source3/rpc_server/samr/srv_samr_chgpasswd.c
index 083b048..0b4b25b 100644
--- a/source3/rpc_server/samr/srv_samr_chgpasswd.c
+++ b/source3/rpc_server/samr/srv_samr_chgpasswd.c
@@ -73,8 +73,13 @@ static int findpty(char **slave)
*slave = NULL;
#if defined(HAVE_GRANTPT)
+#if defined(HAVE_POSIX_OPENPT)
+ master = posix_openpt(O_RDWR|O_NOCTTY);
+#else
/* Try to open /dev/ptmx. If that fails, fall through to old method. */
- if ((master = sys_open(/dev/ptmx, O_RDWR, 0)) = 0) {
+ master = sys_open(/dev/ptmx, O_RDWR, 0);
+#endif
+ if (master = 0) {
grantpt(master);
unlockpt(master);
line = (char *)ptsname(master);
diff --git a/source3/wscript b/source3/wscript
index b40848d..bcc6ce1 100644
--- a/source3/wscript
+++ b/source3/wscript
@@ -123,7 +123,7 @@ def configure(conf):
conf.CHECK_FUNCS('sigprocmask sigblock sigaction sigset innetgr')
conf.CHECK_FUNCS('initgroups select poll rdchk getgrnam getgrent pathconf')
conf.CHECK_FUNCS('setpriv setgidx setuidx setgroups sysconf stat64
fstat64')
-conf.CHECK_FUNCS('lstat64 fopen64 atexit grantpt lseek64 ftruncate64
fallocate fallocate64 posix_fallocate posix_fallocate64')
+conf.CHECK_FUNCS('lstat64 fopen64 atexit grantpt posix_openpt lseek64
ftruncate64 fallocate fallocate64 posix_fallocate posix_fallocate64')
conf.CHECK_FUNCS('fseeko fseek64 fseeko64 ftell64 ftello64 setluid')
conf.CHECK_FUNCS('getpwnam', headers='sys/types.h pwd.h')
conf.CHECK_FUNCS('opendir64 readdir64 seekdir64 telldir64 rewinddir64
closedir64')
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-0-test updated
The branch, v4-0-test has been updated via 0c29da8 samr: Fix bug 9541, make use of posix_openpt via 4063f9e samr: Split up an assignment from an if condition via da9d6c8 docs: document the command line options in dbwrap_tool(1) via fa0e1dc docs: add popt.common.samba.server and popt.common.samba.client entities via 3a70b74 docs: fix the stdarg.configfile entity to print a = sign after the long option via 94b7d3b docs: use the stdarg.option entity in the popt.common.samba entity via 5ca8907 docs: add an entity stdarg.option for the --option command line parameter via 6916daa build(waf): docs-xml: build new dbwrap_tool.8 manual page (fix bug #9568 [2/2]) via 1c6a561 docs-xml: add dbwrap_tool.1 manual page (fix bug #9568 [1/2]) via b247db7 nsswitch: Fix two bitfield constants being the same. via 2a9528e Sort winbind request flags. Ira saw we have a duplicate. from 78f4e66 vfs: Fix compilation of solaris ACL module http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test - Log - commit 0c29da8baded29ac4e0ac5dd4cfa63eee4dba61c Author: Volker Lendecke v...@samba.org Date: Fri Jan 11 10:36:04 2013 +0100 samr: Fix bug 9541, make use of posix_openpt Autobuild-User(v4-0-test): Karolin Seeger ksee...@samba.org Autobuild-Date(v4-0-test): Mon Jan 21 13:00:07 CET 2013 on sn-devel-104 commit 4063f9e46a370800aac5242cdc60a80997773749 Author: Volker Lendecke v...@samba.org Date: Fri Jan 11 10:31:42 2013 +0100 samr: Split up an assignment from an if condition commit da9d6c834b67687dcc047490c566db3bbb8980dd Author: Michael Adam ob...@samba.org Date: Mon Jan 14 17:15:08 2013 +0100 docs: document the command line options in dbwrap_tool(1) Related to bug #9568. Signed-off-by: Michael Adam ob...@samba.org Reviewed-by: Volker Lendecke v...@samba.org (cherry picked from commit d67911bafc0d098e67c8ad8d9b4bc49f184ff832) commit fa0e1dc89e025823d2c7a6e958ce4a442b260c9c Author: Michael Adam ob...@samba.org Date: Mon Jan 14 17:08:30 2013 +0100 docs: add popt.common.samba.server and popt.common.samba.client entities These are comprised by the popt.common.samba entity and the stdarg.server.debug or the stdarg.client.debut entity, respectively. The difference is only in the default value of the debug level setting. Related to bug #9568. Signed-off-by: Michael Adam ob...@samba.org Reviewed-by: Volker Lendecke v...@samba.org (cherry picked from commit 2d30e5deaf731839402b47751683d2c0e32d2bc7) commit 3a70b74f2063c4e0acdb647bfa39a28ccdda3486 Author: Michael Adam ob...@samba.org Date: Mon Jan 14 17:12:51 2013 +0100 docs: fix the stdarg.configfile entity to print a = sign after the long option This makes the appearance equal to the other options like --debuglevel or --log-basename. Related to bug #9568. Signed-off-by: Michael Adam ob...@samba.org Reviewed-by: Volker Lendecke v...@samba.org (cherry picked from commit 2ab3a96d262f60d26a8cd16dded3296889ab7f3f) commit 94b7d3b8c05e52d0be9c80822ca14fb71990702d Author: Michael Adam ob...@samba.org Date: Mon Jan 14 17:06:03 2013 +0100 docs: use the stdarg.option entity in the popt.common.samba entity Related to bug #9568. Signed-off-by: Michael Adam ob...@samba.org Reviewed-by: Volker Lendecke v...@samba.org (cherry picked from commit e3db3db784085bb2fedbf3063154b7cd77630e59) commit 5ca89077c43ee6e1f96edb027687e711322b45d3 Author: Michael Adam ob...@samba.org Date: Mon Jan 14 17:05:05 2013 +0100 docs: add an entity stdarg.option for the --option command line parameter Related to bug #9568. Signed-off-by: Michael Adam ob...@samba.org Reviewed-by: Volker Lendecke v...@samba.org (cherry picked from commit c9b95eb205abbdb77960eb0419937512358f7e64) commit 6916daa1a4a49e33daedc3d8c8e16a772fd90a86 Author: Björn Baumbach b...@sernet.de Date: Mon Oct 15 17:20:07 2012 +0200 build(waf): docs-xml: build new dbwrap_tool.8 manual page (fix bug #9568 [2/2]) Signed-off-by: Björn Baumbach b...@sernet.de Reviewed-by: Michael Adam ob...@samba.org Reviewed-by: Volker Lendecke v...@samba.org (cherry picked from commit b7a091ecf48963e2a0d1757d0faf131ad8d940fa) commit 1c6a561ec1429beb2e24a990d9ee5e96abab98a5 Author: Björn Baumbach b...@sernet.de Date: Mon Oct 15 17:17:29 2012 +0200 docs-xml: add dbwrap_tool.1 manual page (fix bug #9568 [1/2]) Signed-off-by: Björn Baumbach b...@sernet.de Reviewed-by: Michael Adam ob...@samba.org Reviewed-by: Volker Lendecke v...@samba.org (cherry picked from commit 8d6104f02d9ab879efe7867fec53cbe5cc408ded) commit b247db70f707c9ed325986e5e949d0be1d09b30c Author: Ira Cooper i...@samba.org Date: Wed Jan 16 11:33:31 2013 -0800 nsswitch:
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via c38fb0b BUG 9574: Fix a possible null pointer dereference in
spoolss.
from f70d0ac Tests: remove redondent testsuites in provision
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit c38fb0b106b62e42a5b75b1c78386bb8912c7d7e
Author: Andreas Schneider a...@samba.org
Date: Fri Jan 18 18:04:17 2013 +0100
BUG 9574: Fix a possible null pointer dereference in spoolss.
If the the client enumerates the printers and didn't specify a
servername we have a null pointer dereference, so the process serving
the connection crashes.
Reviewed-by: David Disseldorp dd...@samba.org
Autobuild-User(master): David Disseldorp dd...@samba.org
Autobuild-Date(master): Mon Jan 21 13:30:11 CET 2013 on sn-devel-104
---
Summary of changes:
source3/rpc_server/spoolss/srv_spoolss_nt.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c
b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index ef854b1..9df0b8a 100644
--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
@@ -4466,7 +4466,8 @@ static WERROR enum_all_printers_info_1_network(TALLOC_CTX
*mem_ctx,
listed. Windows responds to this call with a
WERR_CAN_NOT_COMPLETE so we should do the same. */
- if (servername[0] == '\\' servername[1] == '\\') {
+ if (servername != NULL
+ (servername[0] == '\\') (servername[1] == '\\')) {
s = servername + 2;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 58fadf2 BUG 9474: Downgrade v4 printer driver requests to v3.
from c38fb0b BUG 9574: Fix a possible null pointer dereference in
spoolss.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 58fadf2f48a2a409b4ee98fdc0166c7f801a7629
Author: Günther Deschner g...@samba.org
Date: Fri Jan 18 00:22:31 2013 +0100
BUG 9474: Downgrade v4 printer driver requests to v3.
Guenther
Signed-off-by: Günther Deschner g...@samba.org
Reviewed-by: Andreas Schneider a...@samba.org
Autobuild-User(master): Andreas Schneider a...@cryptomilk.org
Autobuild-Date(master): Mon Jan 21 16:11:02 CET 2013 on sn-devel-104
---
Summary of changes:
source3/rpc_server/spoolss/srv_spoolss_nt.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c
b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index 9df0b8a..9601ce6 100644
--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
@@ -5606,6 +5606,7 @@ WERROR _spoolss_GetPrinterDriver2(struct pipes_struct *p,
{
struct printer_handle *printer;
WERROR result;
+ uint32_t version = r-in.client_major_version;
int snum;
@@ -5630,13 +5631,19 @@ WERROR _spoolss_GetPrinterDriver2(struct pipes_struct
*p,
return WERR_BADFID;
}
+ if (r-in.client_major_version == SPOOLSS_DRIVER_VERSION_2012) {
+ DEBUG(3,(_spoolss_GetPrinterDriver2: v4 driver requested,
+ downgrading to v3\n));
+ version = SPOOLSS_DRIVER_VERSION_200X;
+ }
+
result = construct_printer_driver_info_level(p-mem_ctx,
get_session_info_system(),
p-msg_ctx,
r-in.level, r-out.info,
snum, printer-servername,
r-in.architecture,
-
r-in.client_major_version);
+version);
if (!W_ERROR_IS_OK(result)) {
TALLOC_FREE(r-out.info);
return result;
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via abc0030 dsdb: Fix warning about unused var
via c52408f dsdb: Explain ordering constraints on the ACL module as
well.
via 8f078cd dsdb: Ensure authenticated users is processed for group
memberships
via d36c030 libcli/security: remove useless if (root-num_of_children
0) statements
via 853ecd4 libcli/security: add init_mask to existing children in
insert_in_object_tree
via 5b4e3de libcli/security: handle node initialisation in one spot in
insert_in_object_tree()
via a359aef libcli/security: avoid usage of dom_sid_parse_talloc() in
sec_access_check_ds()
via a3fffde libcli/security: simplify get_ace_object_type()
via b0f731f libcli/security: fix formating in access_check.c
via 10a90ce libcli/security: fix whitespaces in access_check.c
via 0ebb937 dsdb-acl: the SEC_ADS_DELETE_CHILD checks need
objectclass-schemaIDGUID
via 8f8d97f dsdb-acl: make use of acl_check_access_on_objectclass() for
the object in acl_delete()
via 8aa8555 dsdb-acl: make use of
acl_check_access_on_{attribute,objectclass} in acl_rename()
via 8d31e42 dsdb-acl: make use of acl_check_access_on_attribute() in
acl_modify()
via 8e47e64 dsdb-acl: remove unused acl_check_access_on_class()
via 34f1a52 dsdb-acl: use acl_check_access_on_objectclass() instead of
acl_check_access_on_class()
via 6a4063f dsdb-acl: Use the structural objectClass in
acl_check_access_on_attribute()
via e8cc59e dsdb-acl: Pass the structural objectClass into
acl_check_access_on_attribute
via 93944ea dsdb-acl: Remove unused get_oc_guid_from_message()
via a1b421e dsdb-acl: ask for the objectClass attribute if it's not in
the scope of the clients search
via 6ab4150 dsdb-acl: use dsdb_get_structural_oc_from_msg() rather than
class_schemaid_guid_by_lDAPDisplayName
via 7304339 dsdb-acl: Use dsdb_get_structural_oc_from_msg() in
acl_rename()
via 6d7e53a dsdb-acl: Use dsdb_get_structural_oc_from_msg() in
acl_modify()
via 097fae2 dsdb-acl: add acl_check_access_on_objectclass() helper
via 74bfec0 dsdb-acl: Add helper function
dsdb_get_structural_oc_from_msg()
via 2685a4e dsdb-acl: attr is not optional to
acl_check_access_on_attribute()
via d695b8a dsdb-acl: dsdb_attribute_by_lDAPDisplayName() is needed for
all attributes
via ddfb8fe dsdb-acl: introduce a 'el' helper variable to acl_modify()
via 71b856a dsdb-acl: introduce a 'msg' helper variable to acl_modify()
via c2853f5 dsdb-schema: make sure we build [system]PossibleInferiors
completely
via 1f673bf dsdb-schema: make sure use clean caches in
schema_inferiors.c
via c4b9ee2 dsdb-schema: make schema_subclasses_order_recurse() static
from 58fadf2 BUG 9474: Downgrade v4 printer driver requests to v3.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit abc0030f780b775bf7656b572ee754ebd8079b5d
Author: Matthieu Patou m...@matws.net
Date: Sat Dec 29 16:43:44 2012 -0800
dsdb: Fix warning about unused var
Reviewed-by: Stefan Metzmacher me...@samba.org
Autobuild-User(master): Stefan Metzmacher me...@samba.org
Autobuild-Date(master): Mon Jan 21 17:51:16 CET 2013 on sn-devel-104
commit c52408f461fb3515cde17eebb458b566fd0a049c
Author: Andrew Bartlett abart...@samba.org
Date: Wed Jan 2 09:27:51 2013 +1100
dsdb: Explain ordering constraints on the ACL module as well.
Andrew Bartlett
Reviewed-by: Stefan Metzmacher me...@samba.org
Reviewed-by: Andrew Bartlett abart...@samba.org
commit 8f078cdf247476fad511bb6d7e00c8654fd26e85
Author: Andrew Bartlett abart...@samba.org
Date: Sat Dec 29 15:13:54 2012 +1100
dsdb: Ensure authenticated users is processed for group memberships
This change moves the addition of Authenticated Users from the very end
of the
token processing to the start. The reason is that we need to see if
Authenticated Users is a member of other builtin groups, just as we
would for any other SID. This picks up the Pre-Windows 2000 Compatible
Access
group, which is in turn often used in ACLs on LDAP objects.
Without this change, the eventual token does not contain S-1-5-32-554
and users other than Administrator are unable to read uidNumber
(in particular).
Andrew Bartlett
Reviewed-by: Stefan Metzmacher me...@samba.org
Reviewed-by: Andrew Bartlett abart...@samba.org
commit d36c03056fb85dfedbafd3a59497e35db63ade17
Author: Andrew Bartlett abart...@samba.org
Date: Thu Jan 3 21:30:12 2013 +1100
libcli/security: remove useless if (root-num_of_children 0) statements
The for loop does this implicitly when comparing for (i = 0; i
root-num_of_children; i++)
Andrew Bartlett
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2013-01-21-2330/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2013-01-21-2330/samba3.stderr http://git.samba.org/autobuild.flakey/2013-01-21-2330/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2013-01-21-2330/samba.stderr http://git.samba.org/autobuild.flakey/2013-01-21-2330/samba.stdout The top commit at the time of the failure was: commit abc0030f780b775bf7656b572ee754ebd8079b5d Author: Matthieu Patou m...@matws.net Date: Sat Dec 29 16:43:44 2012 -0800 dsdb: Fix warning about unused var Reviewed-by: Stefan Metzmacher me...@samba.org Autobuild-User(master): Stefan Metzmacher me...@samba.org Autobuild-Date(master): Mon Jan 21 17:51:16 CET 2013 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 0a4a4ba devel-script: add options for RODC and partial replica for
replicate flags
via fa591a6 devel-scripts: ask with WRIT_REP by default
via 0755b83 devel-getncchange: try to find the dest_dsa automatically
via 7822952 security: Add documentation
via c0638da libcli-security: Add documentation for
object_tree_modify_access
via 3b79774 dbcheck: look in hasMasterNCs as well for determining the
instance type of a NC
from abc0030 dsdb: Fix warning about unused var
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 0a4a4ba3f6b9748e3fccb546b284de565de2c8b5
Author: Matthieu Patou m...@matws.net
Date: Mon Oct 29 22:12:33 2012 -0700
devel-script: add options for RODC and partial replica for replicate flags
Reviewed-by: Andrew Bartlett abart...@samba.org
Autobuild-User(master): Andrew Bartlett abart...@samba.org
Autobuild-Date(master): Tue Jan 22 00:12:17 CET 2013 on sn-devel-104
commit fa591a6d3cf9182b6d49621c83a6c3fbfeab1ee7
Author: Matthieu Patou m...@matws.net
Date: Mon Oct 29 21:43:14 2012 -0700
devel-scripts: ask with WRIT_REP by default
Reviewed-by: Andrew Bartlett abart...@samba.org
commit 0755b835cc4e474f752de1b8cc56a9a6da14a3cd
Author: Matthieu Patou m...@matws.net
Date: Tue Oct 23 22:12:08 2012 -0700
devel-getncchange: try to find the dest_dsa automatically
Reviewed-by: Andrew Bartlett abart...@samba.org
commit 7822952a11707ff8aaa415adef62082c158c2398
Author: Matthieu Patou m...@matws.net
Date: Sat Oct 13 15:02:57 2012 -0700
security: Add documentation
Names seems to be a bit cryptic and misleading (at least for me).
So documenting them should remove at least partially this problem.
Reviewed-by: Andrew Bartlett abart...@samba.org
commit c0638dae6cbf8915e6a436d575562fc131ba772a
Author: Matthieu Patou m...@matws.net
Date: Sat Oct 13 15:28:08 2012 -0700
libcli-security: Add documentation for object_tree_modify_access
Reviewed-by: Andrew Bartlett abart...@samba.org
commit 3b7977419726a8630de828b634d669625ee358dd
Author: Matthieu Patou m...@matws.net
Date: Tue Oct 23 22:09:20 2012 -0700
dbcheck: look in hasMasterNCs as well for determining the instance type of
a NC
Forest of level 2000 don't hve the msDS-hasMasterNCs parameter
Reviewed-by: Andrew Bartlett abart...@samba.org
---
Summary of changes:
libcli/security/object_tree.c | 14 +++-
libcli/security/security.h |9 +
source4/scripting/devel/getncchanges| 45 --
source4/scripting/python/samba/dbchecker.py | 12 ++-
4 files changed, 72 insertions(+), 8 deletions(-)
Changeset truncated at 500 lines:
diff --git a/libcli/security/object_tree.c b/libcli/security/object_tree.c
index 3e5ee10..fd00068 100644
--- a/libcli/security/object_tree.c
+++ b/libcli/security/object_tree.c
@@ -104,8 +104,18 @@ struct object_tree *get_object_tree_by_GUID(struct
object_tree *root,
return result;
}
-/* Change the granted access per each ACE */
-
+/**
+ * @brief Modify the tree to mark specified access rights as granted
+ *
+ * This function will modify the root and the child of the tree pointed by
+ * root, so that for each tree element the bits set in access_mask are
+ * marked as granted.
+ *
+ * @param[in] rootAn object_tree structure that we want to modify
+ *
+ * @param[in] access_mask A bitfield of access right that we want to mark as
+ * granted in the whole tree.
+ */
void object_tree_modify_access(struct object_tree *root,
uint32_t access_mask)
{
diff --git a/libcli/security/security.h b/libcli/security/security.h
index 659d341..6e4b172 100644
--- a/libcli/security/security.h
+++ b/libcli/security/security.h
@@ -89,6 +89,15 @@
#define SHARE_ALL_ACCESS FILE_GENERIC_ALL
#define SHARE_READ_ONLY (FILE_GENERIC_READ|FILE_EXECUTE)
+/**
+ * Remaining access is a bit mask of remaining access rights (bits) that have
+ * to be granted in order to fulfill the requested access.
+ *
+ * The GUID is optional, if specified it restricts this object tree and its
+ * childs to object/attributes that inherits from this GUID.
+ * For DS access an object inherits from a GUID if one of its class has this
GUID
+ * in the schemaIDGUID attribute.
+ */
struct object_tree {
uint32_t remaining_access;
struct GUID guid;
diff --git a/source4/scripting/devel/getncchanges
b/source4/scripting/devel/getncchanges
index d401c82..37ec18b 100755
--- a/source4/scripting/devel/getncchanges
+++ b/source4/scripting/devel/getncchanges
@@ -13,6 +13,7 @@ import samba.getopt as options
from samba.dcerpc import drsuapi, misc
from
