autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2013-09-06-0827/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2013-09-06-0827/samba3.stderr http://git.samba.org/autobuild.flakey/2013-09-06-0827/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2013-09-06-0827/samba.stderr http://git.samba.org/autobuild.flakey/2013-09-06-0827/samba.stdout The top commit at the time of the failure was: commit 196da5925b6263b616149f8c4c8d67e1572dea4f Author: Volker Lendecke v...@samba.org Date: Wed Sep 4 17:26:30 2013 +0200 smbd: Remove FORCE_OPLOCK_BREAK_TO_NONE This flag existed to break an exclusive or batch oplock in just one instead of two steps down to no oplock when we did an allocation or file size change. Running raw.oplock against W2k12 differs in this respect from W2k3: W2k12 takes two steps (via level2) to break to none. This removes the special flag that we only had for compatibility with systems older than W2k12... Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org Autobuild-User(master): Jeremy Allison j...@samba.org Autobuild-Date(master): Fri Sep 6 00:47:07 CEST 2013 on sn-devel-104
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated via 41a7d66 smbd: Correctly return INFO_LENGTH_MISMATCH for smb1 via a63ca3e smbd: Fix error return for STREAM_INFO via c8e7244 smbd: Revert a93f9c3 via f5dfa2a smbd: Correctly return BUFFER_OVERFLOW in smb2_getinfo via 9818b31 smbd: Correctly return INFO_LENGTH_MISMATCH in smb2_getinfo via a3d0414 smbd: qfsinfo has fixed/variable buffers via d0f6c38 smbd: qfilepathinfo has fixed/variable buffers via 5efd0ca smbd: Use #defines in smb2_getinfo_send via 65d4f0b s3:smbd: allow info class SMB_QUERY_FS_ATTRIBUTE_INFO to return partial data via 84eabf7 s3:smbd: allow info class SMB_QUERY_FS_VOLUME_INFO to return partial data via a410c51 s3:smbd: allow status code in smbd_do_qfsinfo() to be set by information class handler via 331a0e8 s3:smbd: allow GetInfo responses with STATUS_BUFFER_OVERFLOW to return partial, but valid data via f351fbe s3:smbd: return NT_STATUS_INFO_LENGTH_MISMATCH for GetInfo in case output_buffer_length is too small from 0150086 smbd: Simplify dropbox special case in unix_convert http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test - Log - commit 41a7d66a399c3e1ad999dce5d14570d60c4d53d2 Author: Volker Lendecke v...@samba.org Date: Tue Aug 27 09:40:19 2013 + smbd: Correctly return INFO_LENGTH_MISMATCH for smb1 This is required if the client offered less buffer than the fixed portion of the info level data requires Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org (cherry picked from commit 1b1935b876a14154ef74e447bf53eb7cd0a5dde9) commit a63ca3ed840ca4ab19b4b4bd9238b663228ac2a6 Author: Volker Lendecke v...@samba.org Date: Tue Aug 27 09:39:17 2013 + smbd: Fix error return for STREAM_INFO The stream_info marshalling follows its own rules. This needs unifying eventually... Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org (cherry picked from commit 5634f240fd4273cb732740ccbea0fd41e3fc) commit c8e72447345bb5b737e8383cba069098f387de0a Author: Volker Lendecke v...@samba.org Date: Tue Aug 27 09:38:29 2013 + smbd: Revert a93f9c3 This was too broad and has been replaced by finer-grained error checks Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org (cherry picked from commit b37edda32930fec372d6467d442f67532c3fbd33) commit f5dfa2ac931d52b4517f4e5e07cf9730e6939967 Author: Volker Lendecke v...@samba.org Date: Tue Aug 27 09:37:34 2013 + smbd: Correctly return BUFFER_OVERFLOW in smb2_getinfo Also, don't overflow the client buffer Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org (cherry picked from commit 40f60024ca19e33cbbe9825b42692f386a8f1dd9) commit 9818b31167531f41cbf08fccf89d60ca128c3d4d Author: Volker Lendecke v...@samba.org Date: Tue Aug 27 09:36:03 2013 + smbd: Correctly return INFO_LENGTH_MISMATCH in smb2_getinfo We have to return this error if the client offered less than the fixed portion of the infolevel data requires Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org (cherry picked from commit 91939614760837b2ac2c6bb8b5daac108a4f4670) commit a3d041438f2f0fde9644ec27b89f19ded3146f50 Author: Volker Lendecke v...@samba.org Date: Tue Aug 27 09:06:27 2013 + smbd: qfsinfo has fixed/variable buffers The error message will have to change depending whether the buffer is too small for the fixed or variable buffers Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org (cherry picked from commit ac41df91a5a425633fc716ca02187e753879d795) commit d0f6c38f9638173b34e1a174b8811df83e045f5c Author: Volker Lendecke v...@samba.org Date: Tue Aug 27 09:06:27 2013 + smbd: qfilepathinfo has fixed/variable buffers The error message will have to change depending whether the buffer is too small for the fixed or variable buffers Bug: https://bugzilla.samba.org/show_bug.cgi?id=10106 Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org (cherry picked from commit 53123996033594f68a3fc9037474aada3aef0750) commit 5efd0ca590670a142631db1c2133450a1020ba60 Author: Volker Lendecke v...@samba.org Date: Mon Aug
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via 66b9ebd Optimization. Don't do the retry logic if sitename_fetch()
returned NULL, we already did a NULL query.
via f3d767a Move the retry logic when site_name is passed in a NULL or
to the wrapper function.
via c968f9c Move the manipulation of site_name into the caller function
dsgetdcname().
via ac4ce44 Refactor dsgetdcname to be called via a wrapper function.
via deac844 dsgetdcname_cache_fetch() doesn't use the site_name
parameter so don't pass it.
from 41a7d66 smbd: Correctly return INFO_LENGTH_MISMATCH for smb1
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit 66b9ebd961efe91b87156abf1bb5e1b8f2b87c38
Author: Jeremy Allison j...@samba.org
Date: Tue Sep 3 14:07:43 2013 -0700
Optimization. Don't do the retry logic if sitename_fetch() returned NULL,
we already did a NULL query.
Bug 5917 - Samba does not work on site with Read Only Domain Controller
Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: Andrew Bartlett abart...@samba.org
Autobuild-User(master): Andrew Bartlett abart...@samba.org
Autobuild-Date(master): Wed Sep 4 01:19:05 CEST 2013 on sn-devel-104
(cherry picked from commit bdab6f9431715fbfd28f8cc0dfb4dde2966f22f3)
commit f3d767ac0f6e3b07abf5672ae488ae57bc557677
Author: Jeremy Allison j...@samba.org
Date: Tue Sep 3 12:20:52 2013 -0700
Move the retry logic when site_name is passed in a NULL or to the
wrapper function.
Bug 5917 - Samba does not work on site with Read Only Domain Controller
Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: Andrew Bartlett abart...@samba.org
Reviewed-by: Richard Sharpe rsha...@samba.org
(cherry picked from commit 68e7b1c9446c7d1274b0fb85b59b90ac1a7f6041)
commit c968f9cb46b44a4d1b257a89381898d16086ae26
Author: Jeremy Allison j...@samba.org
Date: Tue Sep 3 12:08:46 2013 -0700
Move the manipulation of site_name into the caller function dsgetdcname().
Leave dsgetdcname_internal() only using const char *site_name.
Bug 5917 - Samba does not work on site with Read Only Domain Controller
Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: Andrew Bartlett abart...@samba.org
Reviewed-by: Richard Sharpe rsha...@samba.org
(cherry picked from commit 181c11066bd53b07015a199f56eb71182e89ff71)
commit ac4ce44d787f448e8dce7b2eca558cecdc75499e
Author: Jeremy Allison j...@samba.org
Date: Tue Sep 3 12:04:37 2013 -0700
Refactor dsgetdcname to be called via a wrapper function.
Bug 5917 - Samba does not work on site with Read Only Domain Controller
Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: Andrew Bartlett abart...@samba.org
Reviewed-by: Richard Sharpe rsha...@samba.org
(cherry picked from commit 66006be7ef703b2935334633d27641050cee5f58)
commit deac844f4ec4bca559285744e8c6ba924c8f492a
Author: Jeremy Allison j...@samba.org
Date: Tue Sep 3 12:13:45 2013 -0700
dsgetdcname_cache_fetch() doesn't use the site_name parameter so don't pass
it.
Bug 5917 - Samba does not work on site with Read Only Domain Controller
Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: Andrew Bartlett abart...@samba.org
Reviewed-by: Richard Sharpe rsha...@samba.org
(cherry picked from commit dd12bfbcbf359c1642cc2e968aec62ae904aad5d)
---
Summary of changes:
source3/libsmb/dsgetdcname.c | 85 --
1 files changed, 65 insertions(+), 20 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/libsmb/dsgetdcname.c b/source3/libsmb/dsgetdcname.c
index 442f8ed..841a179 100644
--- a/source3/libsmb/dsgetdcname.c
+++ b/source3/libsmb/dsgetdcname.c
@@ -321,7 +321,6 @@ static NTSTATUS dsgetdcname_cache_fetch(TALLOC_CTX *mem_ctx,
const char *domain_name,
const struct GUID *domain_guid,
uint32_t flags,
- const char *site_name,
struct netr_DsRGetDCNameInfo **info_p)
{
char *key;
@@ -394,7 +393,7 @@ static NTSTATUS dsgetdcname_cached(TALLOC_CTX *mem_ctx,
NTSTATUS status;
status = dsgetdcname_cache_fetch(mem_ctx, domain_name, domain_guid,
-flags, site_name, info);
+flags, info);
if (!NT_STATUS_IS_OK(status)
!NT_STATUS_EQUAL(status, NT_STATUS_NOT_FOUND)) {
DEBUG(10,(dsgetdcname_cached: cache fetch failed with: %s\n,
@@ -1083,12 +1082,10 @@ static bool is_closest_site(struct
netr_DsRGetDCNameInfo *info)
}
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2013-09-06-1054/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2013-09-06-1054/samba3.stderr http://git.samba.org/autobuild.flakey/2013-09-06-1054/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2013-09-06-1054/samba.stderr http://git.samba.org/autobuild.flakey/2013-09-06-1054/samba.stdout The top commit at the time of the failure was: commit 196da5925b6263b616149f8c4c8d67e1572dea4f Author: Volker Lendecke v...@samba.org Date: Wed Sep 4 17:26:30 2013 +0200 smbd: Remove FORCE_OPLOCK_BREAK_TO_NONE This flag existed to break an exclusive or batch oplock in just one instead of two steps down to no oplock when we did an allocation or file size change. Running raw.oplock against W2k12 differs in this respect from W2k3: W2k12 takes two steps (via level2) to break to none. This removes the special flag that we only had for compatibility with systems older than W2k12... Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org Autobuild-User(master): Jeremy Allison j...@samba.org Autobuild-Date(master): Fri Sep 6 00:47:07 CEST 2013 on sn-devel-104
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via 5978eab s3-sessionid: use sessionid_init_readonly() from cmdline
tools.
via d135201 s3-sessionid: change session_db_ctx() to always return the
session_id_ctx pointer.
via 039171a s3-sessionid: make sure to call sessionid_init() also from
the cmdline tools.
from 66b9ebd Optimization. Don't do the retry logic if sitename_fetch()
returned NULL, we already did a NULL query.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit 5978eab3cdbbc8971ed7f0fd9f0aadb02c98aba7
Author: Günther Deschner g...@samba.org
Date: Wed Sep 4 16:57:17 2013 +0200
s3-sessionid: use sessionid_init_readonly() from cmdline tools.
Guenther
Signed-off-by: Günther Deschner g...@samba.org
The last 3 patches address bug #10127 - smbstatus stopped working as
non-root
user.
commit d1352013bb694a30480282e398e29238470b0768
Author: Günther Deschner g...@samba.org
Date: Wed Sep 4 16:55:11 2013 +0200
s3-sessionid: change session_db_ctx() to always return the session_id_ctx
pointer.
Guenther
Signed-off-by: Günther Deschner g...@samba.org
commit 039171a9d1fc72de39ee8aa51830a37221988859
Author: Günther Deschner g...@samba.org
Date: Wed Sep 4 16:45:32 2013 +0200
s3-sessionid: make sure to call sessionid_init() also from the cmdline
tools.
Guenther
Signed-off-by: Günther Deschner g...@samba.org
---
Summary of changes:
source3/include/proto.h |1 +
source3/lib/sessionid_tdb.c | 25 ++---
source3/utils/net_serverid.c |5 +
source3/utils/net_status.c |6 ++
source3/utils/status.c |6 ++
5 files changed, 36 insertions(+), 7 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/include/proto.h b/source3/include/proto.h
index 189b286..7303e76 100644
--- a/source3/include/proto.h
+++ b/source3/include/proto.h
@@ -1846,6 +1846,7 @@ void server_messaging_context_free(void);
/* The following definitions come from lib/sessionid_tdb.c */
struct sessionid;
bool sessionid_init(void);
+bool sessionid_init_readonly(void);
struct db_record *sessionid_fetch_record(TALLOC_CTX *mem_ctx, const char *key);
int sessionid_traverse(int (*fn)(struct db_record *rec, const char *key,
struct sessionid *session,
diff --git a/source3/lib/sessionid_tdb.c b/source3/lib/sessionid_tdb.c
index de3ccab..769aac2 100644
--- a/source3/lib/sessionid_tdb.c
+++ b/source3/lib/sessionid_tdb.c
@@ -23,23 +23,34 @@
#include session.h
#include util_tdb.h
+static struct db_context *session_db_ctx_ptr = NULL;
+
static struct db_context *session_db_ctx(void)
{
- static struct db_context *session_db_ctx_ptr;
-
- if (session_db_ctx_ptr != NULL) {
- return session_db_ctx_ptr;
- }
+ return session_db_ctx_ptr;
+}
+static struct db_context *session_db_ctx_init(bool readonly)
+{
session_db_ctx_ptr = db_open(NULL, lock_path(sessionid.tdb), 0,
TDB_CLEAR_IF_FIRST|TDB_DEFAULT|TDB_INCOMPATIBLE_HASH,
-O_RDWR | O_CREAT, 0644);
+readonly ? O_RDONLY : O_RDWR | O_CREAT,
0644);
return session_db_ctx_ptr;
}
bool sessionid_init(void)
{
- if (session_db_ctx() == NULL) {
+ if (session_db_ctx_init(false) == NULL) {
+ DEBUG(1,(session_init: failed to open sessionid tdb\n));
+ return False;
+ }
+
+ return True;
+}
+
+bool sessionid_init_readonly(void)
+{
+ if (session_db_ctx_init(true) == NULL) {
DEBUG(1,(session_init: failed to open sessionid tdb\n));
return False;
}
diff --git a/source3/utils/net_serverid.c b/source3/utils/net_serverid.c
index 08a1a7f..01109b9 100644
--- a/source3/utils/net_serverid.c
+++ b/source3/utils/net_serverid.c
@@ -150,5 +150,10 @@ int net_serverid(struct net_context *c, int argc, const
char **argv)
{NULL, NULL, 0, NULL, NULL}
};
+ if (!sessionid_init()) {
+ d_printf(failed to open sessionid.tdb\n);
+ return -1;
+ };
+
return net_run_function(c, argc, argv, net serverid, func);
}
diff --git a/source3/utils/net_status.c b/source3/utils/net_status.c
index d602743..857b184 100644
--- a/source3/utils/net_status.c
+++ b/source3/utils/net_status.c
@@ -239,5 +239,11 @@ int net_status(struct net_context *c, int argc, const char
**argv)
},
{NULL, NULL, 0, NULL, NULL}
};
+
+ if (!sessionid_init_readonly()) {
+ d_printf(failed to open sessionid.tdb\n);
+ return -1;
+ }
+
return net_run_function(c, argc, argv, net status, func);
}
diff
[SCM] Samba Shared Repository - branch v4-0-test updated
The branch, v4-0-test has been updated via f9c157c Optimization. Don't do the retry logic if sitename_fetch() returned NULL, we already did a NULL query. via 70be15b Move the retry logic when site_name is passed in a NULL or to the wrapper function. via 9930f28 Move the manipulation of site_name into the caller function dsgetdcname(). via 6ddc9a5 Refactor dsgetdcname to be called via a wrapper function. via 8943d97 dsgetdcname_cache_fetch() doesn't use the site_name parameter so don't pass it. via e0beb5a smbd: Correctly return INFO_LENGTH_MISMATCH for smb1 via df9fd7f smbd: Fix error return for STREAM_INFO via d594876 smbd: Revert a93f9c3 via aadd02d smbd: Correctly return BUFFER_OVERFLOW in smb2_getinfo via cedcde9 smbd: Correctly return INFO_LENGTH_MISMATCH in smb2_getinfo via ef717ef smbd: qfsinfo has fixed/variable buffers via 4220369 smbd: qfilepathinfo has fixed/variable buffers via 12c77c7 smbd: Use #defines in smb2_getinfo_send via 6dc2f7f s3:smbd: allow info class SMB_QUERY_FS_ATTRIBUTE_INFO to return partial data via cc100f0 s3:smbd: allow info class SMB_QUERY_FS_VOLUME_INFO to return partial data via 235342b s3:smbd: allow status code in smbd_do_qfsinfo() to be set by information class handler via 2c608aa s3:smbd: allow GetInfo responses with STATUS_BUFFER_OVERFLOW to return partial, but valid data via 71c00f1 s3:smbd: return NT_STATUS_INFO_LENGTH_MISMATCH for GetInfo in case output_buffer_length is too small via 067ce71 torture: Ensure that GSSAPI and SPNEGO packets are accepted by dlz_bind9 via cf1ae22 selftest: Add a basic test of samba_upgradedns via 8424ea2 selftest: Start internal DNS server on domain provisioned for BIND9_DLZ via e94d37c selftest: Test creation of the dns-SERVER account during selftest via 8e618de scripting/samba_upgradedns: Tighten up exception and attribute list handling via d17713f scripting/join.py: Handle creating the dns-NAME account during a DC join via 6bed1b2 selftest: Fix specification of --machinepass to actually set a unique password from 8749a30 s3:lib/gencache: place gencache.tdb into /var/cache/samba http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test - Log - commit f9c157cf6892e02e765a64601c4a286d8dadece4 Author: Jeremy Allison j...@samba.org Date: Tue Sep 3 14:07:43 2013 -0700 Optimization. Don't do the retry logic if sitename_fetch() returned NULL, we already did a NULL query. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org Autobuild-User(master): Andrew Bartlett abart...@samba.org Autobuild-Date(master): Wed Sep 4 01:19:05 CEST 2013 on sn-devel-104 (cherry picked from commit bdab6f9431715fbfd28f8cc0dfb4dde2966f22f3) Autobuild-User(v4-0-test): Karolin Seeger ksee...@samba.org Autobuild-Date(v4-0-test): Fri Sep 6 12:51:06 CEST 2013 on sn-devel-104 commit 70be15bdb448b9c6c8ec047ce6f6df4a696ce61e Author: Jeremy Allison j...@samba.org Date: Tue Sep 3 12:20:52 2013 -0700 Move the retry logic when site_name is passed in a NULL or to the wrapper function. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org Reviewed-by: Richard Sharpe rsha...@samba.org (cherry picked from commit 68e7b1c9446c7d1274b0fb85b59b90ac1a7f6041) commit 9930f28a3cf94bdbeb11f551926c105f27c1c12e Author: Jeremy Allison j...@samba.org Date: Tue Sep 3 12:08:46 2013 -0700 Move the manipulation of site_name into the caller function dsgetdcname(). Leave dsgetdcname_internal() only using const char *site_name. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org Reviewed-by: Richard Sharpe rsha...@samba.org (cherry picked from commit 181c11066bd53b07015a199f56eb71182e89ff71) commit 6ddc9a57d025fe196b2f820cfa27429a3acf5643 Author: Jeremy Allison j...@samba.org Date: Tue Sep 3 12:04:37 2013 -0700 Refactor dsgetdcname to be called via a wrapper function. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org Reviewed-by: Richard Sharpe rsha...@samba.org (cherry picked from commit 66006be7ef703b2935334633d27641050cee5f58) commit 8943d971ee729e7f00e17125b9011d9456f220f3 Author: Jeremy Allison j...@samba.org Date: Tue Sep 3 12:13:45 2013 -0700
[SCM] Samba Shared Repository - branch v4-1-test updated
The branch, v4-1-test has been updated via 3beda4c WHATSNEW: Update changes since 4.1.0rc2. via cfa4e2a Optimization. Don't do the retry logic if sitename_fetch() returned NULL, we already did a NULL query. via 3912eeb9 Move the retry logic when site_name is passed in a NULL or to the wrapper function. via 2d7fe2b Move the manipulation of site_name into the caller function dsgetdcname(). via 0c046a4 Refactor dsgetdcname to be called via a wrapper function. via a616bbc dsgetdcname_cache_fetch() doesn't use the site_name parameter so don't pass it. via 317f960 smbd: Correctly return INFO_LENGTH_MISMATCH for smb1 via 26ac864 smbd: Fix error return for STREAM_INFO via db4e8a7 smbd: Revert a93f9c3 via 0e91fd6 smbd: Correctly return BUFFER_OVERFLOW in smb2_getinfo via 9444c6f smbd: Correctly return INFO_LENGTH_MISMATCH in smb2_getinfo via b4427b9 smbd: qfsinfo has fixed/variable buffers via 3691f46 smbd: qfilepathinfo has fixed/variable buffers via 6ee8231 smbd: Use #defines in smb2_getinfo_send via a9ef99c s3:smbd: allow info class SMB_QUERY_FS_ATTRIBUTE_INFO to return partial data via 25fbced s3:smbd: allow info class SMB_QUERY_FS_VOLUME_INFO to return partial data via 342afee s3:smbd: allow status code in smbd_do_qfsinfo() to be set by information class handler via 5e75d4b s3:smbd: allow GetInfo responses with STATUS_BUFFER_OVERFLOW to return partial, but valid data via 2b411e6 s3:smbd: return NT_STATUS_INFO_LENGTH_MISMATCH for GetInfo in case output_buffer_length is too small via a654601 torture: Ensure that GSSAPI and SPNEGO packets are accepted by dlz_bind9 via 1e653e4 selftest: Add a basic test of samba_upgradedns via 79b7888 selftest: Start internal DNS server on domain provisioned for BIND9_DLZ via 0d7c1f0 selftest: Test creation of the dns-SERVER account during selftest via e00be93 scripting/samba_upgradedns: Tighten up exception and attribute list handling via fee6fa5 scripting/join.py: Handle creating the dns-NAME account during a DC join via e6cbc39 WHATSNEW: Add paragraph about SMB2/3 support for client tools/library. from cf677c4 WHATSNEW: Add release notes for Samba 4.1.0rc3. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-1-test - Log - commit 3beda4cffdf36e10a85fdcb8f9cb31ba04fc9cf8 Author: Karolin Seeger ksee...@samba.org Date: Fri Sep 6 11:11:39 2013 +0200 WHATSNEW: Update changes since 4.1.0rc2. Signed-off-by: Karolin Seeger ksee...@samba.org Autobuild-User(v4-1-test): Karolin Seeger ksee...@samba.org Autobuild-Date(v4-1-test): Fri Sep 6 12:59:28 CEST 2013 on sn-devel-104 commit cfa4e2a8ae97b02a112c132f2154c22a9fc53314 Author: Jeremy Allison j...@samba.org Date: Tue Sep 3 14:07:43 2013 -0700 Optimization. Don't do the retry logic if sitename_fetch() returned NULL, we already did a NULL query. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org Autobuild-User(master): Andrew Bartlett abart...@samba.org Autobuild-Date(master): Wed Sep 4 01:19:05 CEST 2013 on sn-devel-104 (cherry picked from commit bdab6f9431715fbfd28f8cc0dfb4dde2966f22f3) commit 3912eeb93f633c0511147c34205b0813748d273a Author: Jeremy Allison j...@samba.org Date: Tue Sep 3 12:20:52 2013 -0700 Move the retry logic when site_name is passed in a NULL or to the wrapper function. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org Reviewed-by: Richard Sharpe rsha...@samba.org (cherry picked from commit 68e7b1c9446c7d1274b0fb85b59b90ac1a7f6041) commit 2d7fe2b9afed0e16a750f918eab30f017b4198fc Author: Jeremy Allison j...@samba.org Date: Tue Sep 3 12:08:46 2013 -0700 Move the manipulation of site_name into the caller function dsgetdcname(). Leave dsgetdcname_internal() only using const char *site_name. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett abart...@samba.org Reviewed-by: Richard Sharpe rsha...@samba.org (cherry picked from commit 181c11066bd53b07015a199f56eb71182e89ff71) commit 0c046a4e5814616d504d755a81901a6eeabea401 Author: Jeremy Allison j...@samba.org Date: Tue Sep 3 12:04:37 2013 -0700 Refactor dsgetdcname to be called via a wrapper function. Bug 5917 - Samba does not work on site with Read Only Domain Controller Signed-off-by: Jeremy Allison j...@samba.org Reviewed-by: Andrew Bartlett
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 5c9e10b smbd: Slightly simplify enum_file_close_fn via f9a7ea2 smbd: Slightly simplify do_break_to_none via 392889c smbd: Slightly simplify send_break_message via 4ecf8b4 smbd: Remove a silly ? true : false via 051b912 smbd: Apply some const to message_to_share_mode_entry via f4e4049 lib: Apply some const to pull_file_id_24 via 451cde7 smbd: Fix a const warning via 1bf10ad smbd: Remove two confusing TALLOC_FREE calls via cdc99b3 smbd: Remove unused should_notify_deferred_opens via e654268 smbd: Apply some const to find_share_mode_entry via aee0f2c smbd: Apply some const to share_modes_identical via a7d7429 smbd: Simplify find_share_mode_entry from 196da59 smbd: Remove FORCE_OPLOCK_BREAK_TO_NONE http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 5c9e10b4b9fb9abe7af6058c0513115ddb325500 Author: Volker Lendecke v...@samba.org Date: Mon Sep 2 09:09:16 2013 + smbd: Slightly simplify enum_file_close_fn Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org Autobuild-User(master): Michael Adam ob...@samba.org Autobuild-Date(master): Fri Sep 6 15:29:55 CEST 2013 on sn-devel-104 commit f9a7ea2df2aaae8b22cfb209e26ceee3c8252ce0 Author: Volker Lendecke v...@samba.org Date: Mon Sep 2 09:08:04 2013 + smbd: Slightly simplify do_break_to_none Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit 392889c8bcffd0f9eb25ad0586172f2b9476b0b4 Author: Volker Lendecke v...@samba.org Date: Mon Sep 2 09:06:13 2013 + smbd: Slightly simplify send_break_message Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit 4ecf8b4db69e5a7d09c3d269145d7b04914efff3 Author: Volker Lendecke v...@samba.org Date: Mon Sep 2 09:40:46 2013 + smbd: Remove a silly ? true : false Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit 051b9121bc8e113239f7207a68860b6472d117d4 Author: Volker Lendecke v...@samba.org Date: Tue Sep 3 11:55:27 2013 + smbd: Apply some const to message_to_share_mode_entry Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit f4e40494c07067838dd67f0614dc75fdb6291c41 Author: Volker Lendecke v...@samba.org Date: Tue Sep 3 11:51:48 2013 + lib: Apply some const to pull_file_id_24 Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit 451cde7f2ab82ea500a69a6072b28991bf4e13a2 Author: Volker Lendecke v...@samba.org Date: Thu Aug 29 14:53:01 2013 + smbd: Fix a const warning Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit 1bf10ad806512979521336391c627275ffeae040 Author: Volker Lendecke v...@samba.org Date: Tue Sep 3 09:23:39 2013 + smbd: Remove two confusing TALLOC_FREE calls We don't have lck allocated yet at these points. Remove the TALLOC_FREE calls that triggered me looking for the get_share_mode_lock calls. Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit cdc99b362f86cfab839076fba128699ae38d4039 Author: Volker Lendecke v...@samba.org Date: Tue Sep 3 14:44:45 2013 + smbd: Remove unused should_notify_deferred_opens Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit e6542683ca6d65b99972d763ebb4df52826fca1e Author: Volker Lendecke v...@samba.org Date: Tue Sep 3 14:40:58 2013 + smbd: Apply some const to find_share_mode_entry Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit aee0f2ccf7a10b5344b00711b0d294648f15bd10 Author: Volker Lendecke v...@samba.org Date: Tue Sep 3 14:40:35 2013 + smbd: Apply some const to share_modes_identical Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org commit a7d742937644373e0e2e75003d04c118e34385ff Author: Volker Lendecke v...@samba.org Date: Tue Sep 3 14:38:47 2013 + smbd: Simplify find_share_mode_entry There's no point checking the validity of the entry argument more than once Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org --- Summary of changes: source3/lib/file_id.c |2 +- source3/lib/file_id.h |2 +- source3/locking/locking.c | 15 +-- source3/rpc_server/srvsvc/srv_srvsvc_nt.c |3 +-- source3/smbd/open.c
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2013-09-06-1619/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2013-09-06-1619/samba3.stderr http://git.samba.org/autobuild.flakey/2013-09-06-1619/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2013-09-06-1619/samba.stderr http://git.samba.org/autobuild.flakey/2013-09-06-1619/samba.stdout The top commit at the time of the failure was: commit 5c9e10b4b9fb9abe7af6058c0513115ddb325500 Author: Volker Lendecke v...@samba.org Date: Mon Sep 2 09:09:16 2013 + smbd: Slightly simplify enum_file_close_fn Signed-off-by: Volker Lendecke v...@samba.org Reviewed-by: Michael Adam ob...@samba.org Autobuild-User(master): Michael Adam ob...@samba.org Autobuild-Date(master): Fri Sep 6 15:29:55 CEST 2013 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 81f8b9c s3: include/smb : changing smb server version from 5c9e10b smbd: Slightly simplify enum_file_close_fn http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 81f8b9c29f317d8a6bd0354cdef9bd319118b583 Author: Shekhar Amlekar samle...@in.ibm.com Date: Tue Jul 9 14:26:49 2013 +0530 s3: include/smb : changing smb server version changing smb server version from 4.9 to 6.1 to mimic win2k8r2. Reviewed-by: Volker Lendecke v...@samba.org Reviewed-by: Jeremy Allison j...@samba.org Autobuild-User(master): Jeremy Allison j...@samba.org Autobuild-Date(master): Fri Sep 6 19:41:51 CEST 2013 on sn-devel-104 --- Summary of changes: source3/include/smb.h |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/include/smb.h b/source3/include/smb.h index 8dd6555..b6b04a4 100644 --- a/source3/include/smb.h +++ b/source3/include/smb.h @@ -602,10 +602,15 @@ char *strdup(char *s); * Note: In the presence of NT4.X do not set above 4.9 *Setting this above 4.9 can have undesired side-effects. *This may change again in Samba-3.0 after further testing. JHT + * + * Version 6.1 - For older smb server versions, MMC doesn't let offline + * settings to be configured during share creation. Changing + * it to 6.1 to mimic Win2K8R2. + * */ -#define SAMBA_MAJOR_NBT_ANNOUNCE_VERSION 0x04 -#define SAMBA_MINOR_NBT_ANNOUNCE_VERSION 0x09 +#define SAMBA_MAJOR_NBT_ANNOUNCE_VERSION 0x06 +#define SAMBA_MINOR_NBT_ANNOUNCE_VERSION 0x01 /* Browser Election Values */ #define BROWSER_ELECTION_VERSION 0x010f -- Samba Shared Repository
