[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 2bb0954 torture3: Use tevent_req_nterror properly
from b7da5a5 printing: always store sytem job-ID in queue state
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 2bb0954567dc2b3680a8fd9609a4930b9c635101
Author: Volker Lendecke
Date: Fri Nov 15 13:17:21 2013 +
torture3: Use tevent_req_nterror properly
Might be minor, but the less example of wrong API use we have the better
it is.
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Tue Nov 19 04:05:08 CET 2013 on sn-devel-104
---
Summary of changes:
source3/torture/torture.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/torture/torture.c b/source3/torture/torture.c
index 8313cf1..573e3f8 100644
--- a/source3/torture/torture.c
+++ b/source3/torture/torture.c
@@ -6754,10 +6754,9 @@ static void torture_createdel_created(struct tevent_req
*subreq)
status = cli_ntcreate_recv(subreq, &fnum);
TALLOC_FREE(subreq);
- if (!NT_STATUS_IS_OK(status)) {
+ if (tevent_req_nterror(req, status)) {
DEBUG(10, ("cli_ntcreate_recv returned %s\n",
nt_errstr(status)));
- tevent_req_nterror(req, status);
return;
}
@@ -6775,9 +6774,8 @@ static void torture_createdel_closed(struct tevent_req
*subreq)
NTSTATUS status;
status = cli_close_recv(subreq);
- if (!NT_STATUS_IS_OK(status)) {
+ if (tevent_req_nterror(req, status)) {
DEBUG(10, ("cli_close_recv returned %s\n", nt_errstr(status)));
- tevent_req_nterror(req, status);
return;
}
tevent_req_done(req);
--
Samba Shared Repository
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2013-11-18-1816/flakey.log The samba3 build logs are available here: http://git.samba.org/autobuild.flakey/2013-11-18-1816/samba3.stderr http://git.samba.org/autobuild.flakey/2013-11-18-1816/samba3.stdout The source4 build logs are available here: http://git.samba.org/autobuild.flakey/2013-11-18-1816/samba.stderr http://git.samba.org/autobuild.flakey/2013-11-18-1816/samba.stdout The top commit at the time of the failure was: commit 7e01e4bc64a80ee43f1fe845e0e2eed523f235fa Author: Stefan Metzmacher Date: Sun Nov 17 10:47:47 2013 +0100 script: prepare librelease.sh for ntdb releases Signed-off-by: Stefan Metzmacher Autobuild-User(master): Stefan Metzmacher Autobuild-Date(master): Sun Nov 17 12:50:13 CET 2013 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via b7da5a5 printing: always store sytem job-ID in queue state
via 24d025f spoolss: return the spoolss job ID in notifications
from 7e01e4b script: prepare librelease.sh for ntdb releases
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit b7da5a5b00f6c78e41279415e33c091dcc0a773b
Author: David Disseldorp
Date: Fri Oct 18 13:09:23 2013 +0200
printing: always store sytem job-ID in queue state
Print jobs have multiple identifiers: the regular spoolss jobid, which
is allocated by spoolss on job submission, and the system jobid, which
is assigned by the printing back-end.
Currently these identifiers are incorrectly mixed in print job queue
tracking. Fix this by ensuring that only the system jobid is stored in
the print queue state structure.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10271
Signed-off-by: David Disseldorp
Reviewed-by: Jeremy Allison
Reviewed-by: Andreas Schneider
Reviewed-by: Günther Deschner
Autobuild-User(master): David Disseldorp
Autobuild-Date(master): Mon Nov 18 18:03:41 CET 2013 on sn-devel-104
commit 24d025f85d6eea272bff5e1040d4fd2ba0e6b8f3
Author: David Disseldorp
Date: Thu Sep 19 20:31:37 2013 -0700
spoolss: return the spoolss job ID in notifications
Print job notifications currently carry the system print job identifier
from the queue structure. Instead, the spoolss job identifier should be
resolved and returned.
Print clients can use notification job-ids in subsequent spoolss SetJob
requests. Returning an incorrect identifier can result in the failure of
such requests, e.g. spoolss_SetJob(SPOOLSS_JOB_CONTROL_DELETE).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10271
Signed-off-by: David Disseldorp
Reviewed-by: Jeremy Allison
Reviewed-by: Andreas Schneider
Reviewed-by: Günther Deschner
---
Summary of changes:
source3/include/printing.h |1 +
source3/printing/printing.c | 45 ++-
source3/rpc_server/spoolss/srv_spoolss_nt.c | 32 +++---
3 files changed, 50 insertions(+), 28 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/include/printing.h b/source3/include/printing.h
index 391fb7a..ec5a53b 100644
--- a/source3/include/printing.h
+++ b/source3/include/printing.h
@@ -193,6 +193,7 @@ uint16_t print_spool_rap_jobid(struct print_file_data
*print_file);
/* The following definitions come from printing/printing.c */
+uint32 sysjob_to_jobid_pdb(struct tdb_print_db *pdb, int sysjob);
uint32 sysjob_to_jobid(int unix_jobid);
bool print_notify_register_pid(int snum);
bool print_notify_deregister_pid(int snum);
diff --git a/source3/printing/printing.c b/source3/printing/printing.c
index 43f75e5..b126bd5 100644
--- a/source3/printing/printing.c
+++ b/source3/printing/printing.c
@@ -519,7 +519,7 @@ static int unixjob_traverse_fn(TDB_CONTEXT *the_tdb,
TDB_DATA key,
return 0;
}
-static uint32 sysjob_to_jobid_pdb(struct tdb_print_db *pdb, int sysjob)
+uint32 sysjob_to_jobid_pdb(struct tdb_print_db *pdb, int sysjob)
{
struct unixjob_traverse_state state;
@@ -3051,7 +3051,7 @@ static bool get_stored_queue_info(struct
messaging_context *msg_ctx,
size_t len = 0;
uint32 i;
int max_reported_jobs = lp_max_reported_jobs(snum);
- bool ret = False;
+ bool ret = false;
const char* sharename = lp_servicename(talloc_tos(), snum);
TALLOC_CTX *tmp_ctx = talloc_new(msg_ctx);
if (tmp_ctx == NULL) {
@@ -3095,7 +3095,7 @@ static bool get_stored_queue_info(struct
messaging_context *msg_ctx,
/* Retrieve the linearised queue data. */
- for( i = 0; i < qcount; i++) {
+ for(i = 0; i < qcount; i++) {
uint32 qjob, qsize, qpage_count, qstatus, qpriority, qtime;
len += tdb_unpack(data.dptr + len, data.dsize - len, "ddff",
&qjob,
@@ -3117,7 +3117,7 @@ static bool get_stored_queue_info(struct
messaging_context *msg_ctx,
total_count = qcount;
/* Add new jobids to the queue. */
- for( i = 0; i < extra_count; i++) {
+ for (i = 0; i < extra_count; i++) {
uint32 jobid;
struct printjob *pjob;
@@ -3130,7 +3130,7 @@ static bool get_stored_queue_info(struct
messaging_context *msg_ctx,
continue;
}
- queue[total_count].sysjob = jobid;
+ queue[total_count].sysjob = pjob->sysjob;
queue[total_count].size = pjob->size;
queue[total_count].page_count = pjob->page_count;
queue[total_count].status = pjob->sta
[SCM] Samba Shared Repository - branch v4-0-test updated
The branch, v4-0-test has been updated via 59da16e VERSION: Bump version number up to 4.0.13... via 430c74f VERSION: Disable git snapshots for the 4.0.12 release. via a60c24e WHATSNEW: Add release notes for Samba 4.0.12. from c35f22e util: Remove 32bit macros breaking strict aliasing. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test - Log - commit 59da16e6751fc67a4e24b71851d0e49cb708bd77 Author: Karolin Seeger Date: Mon Nov 18 10:30:36 2013 +0100 VERSION: Bump version number up to 4.0.13... and re-enable git snapshots. Signed-off-by: Karolin Seeger commit 430c74f5b58e7054ded963bd3dc8cc4b5f7b1cd2 Author: Karolin Seeger Date: Mon Nov 18 10:29:58 2013 +0100 VERSION: Disable git snapshots for the 4.0.12 release. Signed-off-by: Karolin Seeger commit a60c24e4ea73e99f6f14832201fbbf45a90f0c3b Author: Karolin Seeger Date: Mon Nov 18 10:28:36 2013 +0100 WHATSNEW: Add release notes for Samba 4.0.12. Signed-off-by: Karolin Seeger --- Summary of changes: VERSION |2 +- WHATSNEW.txt | 85 - 2 files changed, 84 insertions(+), 3 deletions(-) Changeset truncated at 500 lines: diff --git a/VERSION b/VERSION index 576d58f..0639a26 100644 --- a/VERSION +++ b/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=4 SAMBA_VERSION_MINOR=0 -SAMBA_VERSION_RELEASE=12 +SAMBA_VERSION_RELEASE=13 # If a official release has a serious bug # diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 20b6e7f..3ae3b2f 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,4 +1,85 @@ == + Release Notes for Samba 4.0.12 + November 19, 2013 + == + + +This is is the latest stable release of Samba 4.0. + +Major enhancements in Samba 4.0.12 include: + +o RW Deny for a specific user is not overriding RW Allow for a group (bug + #10196) + + +Changes since 4.0.11: +- + +o Jeremy Allison +* BUG 10187: Missing talloc_free can leak stackframe in error path. +* BUG 10196: RW Deny for a specific user is not overriding RW Allow for a + group. + + +o Andrew Bartlett +* BUG 10052: Use dsdb_search_one to catch 0 results as well as + NO_SUCH_OBJECT errors. + + +o Samuel Cabrero +* BUG 9091: s4-dns: dlz_bind9: Create dns-HOSTNAME account disabled. + + +o Günther Deschner +* BUG 10264: s3-winbind: Fix cache_traverse_validate_fn failure for NDR + cache entries. + + +o Björn Jacke +* BUG 10247: xattr: Fix listing EAs on *BSD for non-root users. + + +o Volker Lendecke +* BUG 10195: nsswitch: Fix short writes in winbind_write_sock. + + +o Stefan Metzmacher +* BUG 9905: ldap_server: Register name and pid at startup. +* BUG 10193: s4:dsdb/rootdse: report 'dnsHostName' instead of 'dNSHostName'. +* BUG 10232: libcli/smb: fix smb2cli_ioctl*() against Windows 2008. + + +o Andreas Schneider +* BUG 10132: pam_winbindd: Add support for the KEYRING ccache type. +* BUG 10194: winbind: Offline logon cache not updating for cross child + domain group membership. +* BUG 10269: util: Remove 32bit macros breaking strict aliasing. + + +## +Reporting bugs & Development Discussion +### + +Please discuss this release on the samba-technical mailing list or by +joining the #samba-technical IRC channel on irc.freenode.net. + +If you do report problems then please try to send high quality +feedback. If you don't provide vital information to help us track down +the problem then you will probably be ignored. All bug reports should +be filed under the Samba 4.0 product in the project's Bugzilla +database (https://bugzilla.samba.org/). + + +== +== Our Code, Our Bugs, Our Responsibility. +== The Samba Team +== + + +Release notes for older releases follow: + + + == Release Notes for Samba 4.0.11 November 11, 2013 == @@ -68,8 +149,8 @@ database (https://bugzilla.samba.org/). == -Release notes for older releases follow: - +-- +
