autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2014-07-14-0943/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2014-07-14-0943/samba.stderr http://git.samba.org/autobuild.flakey/2014-07-14-0943/samba.stdout The top commit at the time of the failure was: commit 02bcdd109fb24a369c05dceabfdc1b5edd291aeb Author: Michael Adam ob...@samba.org Date: Thu Jul 3 10:00:13 2014 +0200 s3:smbd: initialize stat_ex buffer in smbd_dirptr_get_entry() This prevents random garbage in the vfs_private member. Usually it should not be a problem to leave initialization of the vfs_private to the vfs module who wants to use it, but further down in the directory listing code, in vfswrap_readdir, there is in optimization introduced with 2a65e8befef004fd18d17853a1b72155752346c8, to call fstatat if possible to already fill stat info in the readdir call. The problem is that this calls fstatat directly, not going through VFS, but still making the stat buffer valid, leaving vfs_private with random garbage. Hence a vfs module using vfs_private, like vfs_gpfs does for offline info (and winAttrs in general) does not have a chance to tell whether the vfs_private is valid if the stat buffer is marked valid. This is a reason for the flapping offline flag problem of the vfs_gpfs module. Initializing the vfs_private to 0 here will for the vfs_gpfs module result in files being marked online always in a directory listing. So this is not a real fix but it does at least make the problem less random. A real general fix might be to implement SMB_VFS_FSTATAT() and use it here. Signed-off-by: Michael Adam ob...@samba.org Reviewed-by: Christof Schmitt c...@samba.org Autobuild-User(master): Christof Schmitt c...@samba.org Autobuild-Date(master): Sun Jul 13 11:26:58 CEST 2014 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 208b2d8 ctdb-ltdb: Use tdb_null instead of zeroing TDB_DATA variable
from 02bcdd1 s3:smbd: initialize stat_ex buffer in
smbd_dirptr_get_entry()
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 208b2d88c4efacee79fe4d856ee8256c680cad5c
Author: Amitay Isaacs ami...@gmail.com
Date: Mon Jul 14 16:30:18 2014 +1000
ctdb-ltdb: Use tdb_null instead of zeroing TDB_DATA variable
Signed-off-by: Amitay Isaacs ami...@gmail.com
Reviewed-by: Volker Lendecke v...@samba.org
Autobuild-User(master): Volker Lendecke v...@samba.org
Autobuild-Date(master): Mon Jul 14 16:01:31 CEST 2014 on sn-devel-104
---
Summary of changes:
ctdb/common/ctdb_ltdb.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/ctdb/common/ctdb_ltdb.c b/ctdb/common/ctdb_ltdb.c
index 500f721..103d89b 100644
--- a/ctdb/common/ctdb_ltdb.c
+++ b/ctdb/common/ctdb_ltdb.c
@@ -83,7 +83,6 @@ int ctdb_ltdb_fetch(struct ctdb_db_context *ctdb_db,
rec = tdb_fetch(ctdb_db-ltdb-tdb, key);
if (rec.dsize sizeof(*header)) {
- TDB_DATA d2;
/* return an initial header */
if (rec.dptr) free(rec.dptr);
if (ctdb-vnn_map == NULL) {
@@ -93,12 +92,11 @@ int ctdb_ltdb_fetch(struct ctdb_db_context *ctdb_db,
return -1;
}
ltdb_initial_header(ctdb_db, key, header);
- ZERO_STRUCT(d2);
if (data) {
- *data = d2;
+ *data = tdb_null;
}
if (ctdb_db-persistent || header-dmaster ==
ctdb_db-ctdb-pnn) {
- if (ctdb_ltdb_store(ctdb_db, key, header, d2) != 0) {
+ if (ctdb_ltdb_store(ctdb_db, key, header, tdb_null) !=
0) {
DEBUG(DEBUG_NOTICE,
(__location__ failed to store initial
header\n));
}
--
Samba Shared Repository
[SCM] UID Wrapper Repository - branch master updated
The branch, master has been updated
via 6e1a69f doc: Add a manpage for uid_wrapper.
from 80932d7 uwrap: Add logging if uwrap is enabled correctly.
http://gitweb.samba.org/?p=uid_wrapper.git;a=shortlog;h=master
- Log -
commit 6e1a69f52c1a5de968f0bc38af71ee99c1297021
Author: Andreas Schneider a...@samba.org
Date: Thu Jul 10 17:09:50 2014 +0200
doc: Add a manpage for uid_wrapper.
Signed-off-by: Andreas Schneider a...@samba.org
Reviewed-by: Michael Adam ob...@samba.org
---
Summary of changes:
CMakeLists.txt|2 +
README| 46 +--
doc/CMakeLists.txt|4 +
doc/README|3 +
doc/uid_wrapper.1 | 153 +
doc/uid_wrapper.1.txt | 56 ++
6 files changed, 232 insertions(+), 32 deletions(-)
create mode 100644 doc/CMakeLists.txt
create mode 100644 doc/README
create mode 100644 doc/uid_wrapper.1
create mode 100644 doc/uid_wrapper.1.txt
Changeset truncated at 500 lines:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 80fcaf1..af76cb8 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -81,3 +81,5 @@ install(
COMPONENT
devel
)
+
+add_subdirectory(doc)
diff --git a/README b/README
index 6f19b38..764fd36 100644
--- a/README
+++ b/README
@@ -1,42 +1,24 @@
-UID wrapper library
-
+UID_WRAPPER
+===
-Privilege separation - Some projects like a file server need privilege
-separation to be able to switch to the connnection user and do file operations.
-uid_wrapper convincingly lies to the application letting it believe it is
-operating as root and even switching betwen uids and gids as needed.
+This is a wrapper for the user, group and hosts NSS API.
-More precise this library intercepts seteuid and related calls, and simulates
-them in a manner similar to the nss_wrapper and socket_wrapper libraries.
+DESCRIPTION
+---
-This allows you to do user switching when testing e.g. file servers.
+More details can be found in the manpage:
-To use it set the following environment variables:
+ man -l ./doc/uid_wrapper.1
-LD_PRELOAD=libuid_wrapper.so
-UID_WRAPPER=1
+or the raw text version:
-If you unset the variable or set it to 0 you can disable uwrap even if it is
-loaded. If you need the application to think it is root at startup you can set:
+ less ./doc/uid_wrapper.1.txt
-UID_WRAPPER_ROOT=1
+For installation instructions please take a look at the README.install file.
-If you set the environment variable to UID_WRAPPER_MYUID=1 before you call
-geteuid() then it will return the real uid.
+MAILINGLIST
+---
-To find out if uid_wrapper is enabled, we suggest to implment the following
-function in a library your application loads:
+As the mailing list samba-technical is used and can be found here:
-int uid_wrapper_enabled(void)
-{
-return 0;
-}
-
-Then you can use:
-
-if (uid_wrapper_enabled()) {
-/* special uid_wrapper handling code */
-}
-
-uid_wrapper implements this funciton too and it will be loaded before your
-library gets loaded.
+https://lists.samba.org/mailman/listinfo/samba-technical
diff --git a/doc/CMakeLists.txt b/doc/CMakeLists.txt
new file mode 100644
index 000..7ce0e22
--- /dev/null
+++ b/doc/CMakeLists.txt
@@ -0,0 +1,4 @@
+install(FILES
+uid_wrapper.1
+DESTINATION
+${MAN_INSTALL_DIR}/man1)
diff --git a/doc/README b/doc/README
new file mode 100644
index 000..c97ae11
--- /dev/null
+++ b/doc/README
@@ -0,0 +1,3 @@
+The manpage is written with asciidoc. To generate the manpage use:
+
+a2x --doctype manpage --format manpage doc/uid_wrapper.1.txt
diff --git a/doc/uid_wrapper.1 b/doc/uid_wrapper.1
new file mode 100644
index 000..f6ff0df
--- /dev/null
+++ b/doc/uid_wrapper.1
@@ -0,0 +1,153 @@
+'\ t
+.\ Title: uid_wrapper
+.\Author: [FIXME: author] [see http://docbook.sf.net/el/author]
+.\ Generator: DocBook XSL Stylesheets v1.78.1 http://docbook.sf.net/
+.\ Date: 07/11/2014
+.\Manual: \ \
+.\Source: \ \
+.\ Language: English
+.\
+.TH UID_WRAPPER 1 07/11/2014 \ \ \ \
+.\ -
+.\ * Define some portability stuff
+.\ -
+.\ ~
+.\ http://bugs.debian.org/507673
+.\ http://lists.gnu.org/archive/html/groff/2009-02/msg00013.html
+.\ ~
+.ie \n(.g .ds Aq \(aq
+.el .ds Aq '
+.\ -
+.\ * set default formatting
+.\ -
+.\ disable hyphenation
+.nh
+.\ disable justification (adjust text to left margin only)
+.ad
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via ca1e4af As David Woodhouse points out, this breaks backwards
compatibility.
from 208b2d8 ctdb-ltdb: Use tdb_null instead of zeroing TDB_DATA variable
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit ca1e4af466af83c0f28804813dc19a77c340f981
Author: Jeremy Allison j...@samba.org
Date: Mon Jul 14 10:22:52 2014 -0700
As David Woodhouse points out, this breaks backwards compatibility.
https://bugzilla.samba.org/show_bug.cgi?id=10692
Revert libwbclient: reject unknown named blobs in wbcCredentialCache()
This reverts commit 740d12d1e77d356ff22c3725dce8d5019c86a7a5.
Autobuild-User(master): Jeremy Allison j...@samba.org
Autobuild-Date(master): Mon Jul 14 21:54:08 CEST 2014 on sn-devel-104
---
Summary of changes:
nsswitch/libwbclient/wbc_pam.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/nsswitch/libwbclient/wbc_pam.c b/nsswitch/libwbclient/wbc_pam.c
index a16de97..11b59f6 100644
--- a/nsswitch/libwbclient/wbc_pam.c
+++ b/nsswitch/libwbclient/wbc_pam.c
@@ -1224,8 +1224,6 @@ wbcErr wbcCredentialCache(struct wbcCredentialCacheParams
*params,
challenge_blob = params-blobs[i];
continue;
}
- status = WBC_ERR_INVALID_PARAM;
- goto fail;
}
if (params-domain_name != NULL) {
--
Samba Shared Repository
