[SCM] Samba Shared Repository - branch v4-0-test updated

2014-09-15 Thread Karolin Seeger 
The branch, v4-0-test has been updated
   via  7dbddb7 VERSION: Bump version number up to 4.0.23...
   via  f6fd102 VERSION: Disable git snapshots for the 4.0.22 release.
   via  5abb3ca WHATSNEW: Add release notes for Samba 4.0.22.
  from  a48e472 selftest: Fix selftest where pid is used uninitialized.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test


- Log -
commit 7dbddb7652a18c888b2cda88cd398ea4bb05ffe4
Author: Karolin Seeger ksee...@samba.org
Date:   Sat Sep 13 15:48:43 2014 +0200

VERSION: Bump version number up to 4.0.23...

and re-enable git snapshots.

Signed-off-by: Karolin Seeger ksee...@samba.org

commit f6fd10202cc6d67e0c1324c858cea23372a6cacd
Author: Karolin Seeger ksee...@samba.org
Date:   Sat Sep 13 15:48:07 2014 +0200

VERSION: Disable git snapshots for the 4.0.22 release.

Signed-off-by: Karolin Seeger ksee...@samba.org

commit 5abb3cab6965a6e63e186401a9db4337df4fc15d
Author: Karolin Seeger ksee...@samba.org
Date:   Sat Sep 13 15:47:13 2014 +0200

WHATSNEW: Add release notes for Samba 4.0.22.

Signed-off-by: Karolin Seeger ksee...@samba.org

---

Summary of changes:
 VERSION  |2 +-
 WHATSNEW.txt |  115 +-
 2 files changed, 114 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/VERSION b/VERSION
index 9299b98..58717fc 100644
--- a/VERSION
+++ b/VERSION
@@ -25,7 +25,7 @@
 
 SAMBA_VERSION_MAJOR=4
 SAMBA_VERSION_MINOR=0
-SAMBA_VERSION_RELEASE=22
+SAMBA_VERSION_RELEASE=23
 
 
 # If a official release has a serious bug  #
diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index 58e3986..9201406 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -1,4 +1,115 @@
==
+   Release Notes for Samba 4.0.22
+ September 15, 2014
+   ==
+
+
+This is the latest stable release of Samba 4.0.
+
+Major enhancements in Samba 4.0.22 include:
+
+o  New parameter winbind request timeout has been added (bug #3204). Please
+   see smb.conf man page for details.
+
+
+Changes since 4.1.21:
+-
+
+o   Michael Adam ob...@samba.org
+* BUG 10369: build: Fix configure to honour '--without-dmapi'.
+
+
+o   Jeremy Allison j...@samba.org
+* BUG 3204: s3: winbindd: On new client connect, prune idle or hung
+  connections older than winbind request timeout. Add new parameter
+  winbind request timeout.
+* BUG 10640: lib: tevent: make TEVENT_SIG_INCREMENT atomic.
+* BUG 10650: Make case sensitive = True option working with
+  max protocol = SMB2 or higher in large directories.
+* BUG 10728: 'net time': Fix usage and core dump.
+* BUG 10773: s3: smbd: POSIX ACLs. Remove incorrect check for
+  SECINFO_PROTECTED_DACL in incoming security_information flags in
+  posix_get_nt_acl_common().
+* BUG 10794: vfs_dirsort: Fix an off-by-one error that can
+  cause uninitialized memory read.
+
+
+o   Björn Baumbach b...@sernet.de
+* BUG 10543: s3: Enforce a positive allocation_file_size for non-empty
+  files.
+
+
+o   David Disseldorp dd...@samba.org
+* BUG 10652: Samba 4 consuming a lot of CPU when re-reading printcap info.
+* BUG 10787: dosmode: Fix FSCTL_SET_SPARSE request validation.
+
+
+o   Amitay Isaacs ami...@gmail.com
+* BUG 10742: s4-rpc: dnsserver: Allow . to be specified for @ record.
+
+
+o   Daniel Kobras d.kob...@science-computing.de
+* BUG 10731: sys_poll_intr: Fix timeout arithmetic.
+
+
+o   Ross Lagerwall rosslagerw...@gmail.com
+* BUG 10778: s3:libsmb: Set a max charge for SMB2 connections.
+
+
+o   Volker Lendecke v...@samba.org
+* BUG 10758: lib: Remove unused nstrcpy.
+* BUG 10782: smbd: Properly initialize mangle_hash.
+
+
+o   Stefan Metzmacher me...@samba.org
+* BUG 10773: libcli/security: Add better detection of
+  SECINFO_[UN]PROTECTED_[D|S]ACL in get_sec_info().
+
+
+o   Marc Muehlfeld mmuehlf...@samba.org
+* BUG 10761: docs: Fix typos in smb.conf (inherit acls).
+
+
+o   Shirish Pargaonkar spargaon...@suse.com
+* BUG 10755: samba: Retain case sensitivity of cifs client.
+
+
+o   Arvid Requate requ...@univention.de
+* BUG 9570: passdb: Fix NT_STATUS_NO_SUCH_GROUP.
+
+
+o   Har Gagan Sahai sharga...@novell.com
+* BUG 10759: Fix a memory leak in cli_set_mntpoint().
+
+
+o   Roel van Meer r...@1afa.com
+* BUG 10777: Don't discard result of checking grouptype.
+
+
+##
+Reporting bugs  Development Discussion
+###
+
+Please discuss this release on the

[SCM] Samba Shared Repository - annotated tag samba-4.0.22 created

2014-09-15 Thread Karolin Seeger 
The annotated tag, samba-4.0.22 has been created
at  cfacef180a188c3da5d75cd8ae4b817f12ac8dcc (tag)
   tagging  f6fd10202cc6d67e0c1324c858cea23372a6cacd (commit)
  replaces  samba-4.0.21
 tagged by  Karolin Seeger
on  Mon Sep 15 10:39:37 2014 +0200

- Log -
samba: tag release samba-4.0.22
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iEYEABECAAYFAlQWpckACgkQbzORW2Vot+rmhwCffShlrtL/3vzwKWkB8ZM9Czef
DesAn3+71aTvdY1wGB1UPfcUGYReYKD3
=9s8J
-END PGP SIGNATURE-

Amitay Isaacs (2):
  s4-rpc: dnsserver: Allow . to be specified for @ record
  tests: dnsserver: Add a update test with name set to '.'

Andreas Schneider (1):
  selftest: Fix selftest where pid is used uninitialized.

Arvid Requate (1):
  passdb: fix NT_STATUS_NO_SUCH_GROUP

Björn Baumbach (1):
  s3: enforce a positive allocation_file_size for non-empty files (bug 
#10543)

Daniel Kobras (1):
  sys_poll_intr: fix timeout arithmetic

David Disseldorp (10):
  printing: traverse_read the printer list for share updates
  printing: only reload printer shares on client enum
  printing: reload printer_list.tdb from in memory list
  printing: remove pcap_cache_add()
  printing: return last change time with pcap_cache_loaded()
  smbd: only reprocess printer_list.tdb if it changed
  server: remove duplicate snum_is_shared_printer()
  smbd: split printer reload processing
  printing: reload printer shares on OpenPrinter
  dosmode: fix FSCTL_SET_SPARSE request validation

Har Gagan Sahai (1):
  Fixed a memory leak in cli_set_mntpoint().

Jeremy Allison (9):
  lib: tevent: make TEVENT_SIG_INCREMENT atomic.
  s3: xml-docs. Ensure users of 'net time' know the remote server must be 
specified with -S.
  s3: net time - fix usage and core dump.
  s3: smbd: POSIX ACLs. Remove incorrect check for SECINFO_PROTECTED_DACL 
in incoming security_information flags in posix_get_nt_acl_common().
  s3: smbd - SMB[2|3]. Ensure a \ or / can't be found anywhere in a search 
path, not just at the start.
  s3: smbd : SMB2 - fix SMB2_SEARCH when searching non wildcard string with 
a case-canonicalized share.
  s3: winbindd: Add new parameter winbind request timeout set to 60 
seconds with man page.
  s3: winbindd: On new client connect, prune idle or hung connections older 
than winbind request timeout
  s3: smbd: vfs_dirsort module.

Karolin Seeger (5):
  VERSION: Bump version number up to 4.0.21...
  Merge tag 'samba-4.0.21' into v4-0-test
  VERSION: Bump version up to 4.0.22.
  WHATSNEW: Add release notes for Samba 4.0.22.
  VERSION: Disable git snapshots for the 4.0.22 release.

Marc Muehlfeld (1):
  docs: Fix typos in smb.conf (inherit acls)

Michael Adam (1):
  build: fix configure to honour --without-dmapi

Roel van Meer (1):
  Don't discard result of checking grouptype

Ross Lagerwall (1):
  s3:libsmb: Set a max charge for SMB2 connections

Shirish Pargaonkar (1):
  samba: Retain case sensitivity of cifs client

Stefan Metzmacher (3):
  security.idl: add SMB_SUPPORTED_SECINFO_FLAGS
  s3:smbd: mask security_information input values with 
SMB_SUPPORTED_SECINFO_FLAGS
  libcli/security: add better detection of SECINFO_[UN]PROTECTED_[D|S]ACL 
in get_sec_info()

Volker Lendecke (2):
  lib: Remove unused nstrcpy
  smbd: Properly initialize mangle_hash

---


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch v4-0-stable updated

2014-09-15 Thread Karolin Seeger 
The branch, v4-0-stable has been updated
   via  f6fd102 VERSION: Disable git snapshots for the 4.0.22 release.
   via  5abb3ca WHATSNEW: Add release notes for Samba 4.0.22.
   via  a48e472 selftest: Fix selftest where pid is used uninitialized.
   via  836d1ec s3: smbd: vfs_dirsort module.
   via  d14c83e s3: winbindd: On new client connect, prune idle or hung 
connections older than winbind request timeout
   via  36f55df s3: winbindd: Add new parameter winbind request timeout 
set to 60 seconds with man page.
   via  bd576b8 dosmode: fix FSCTL_SET_SPARSE request validation
   via  9a1a13a smbd: Properly initialize mangle_hash
   via  77e7db9 Don't discard result of checking grouptype
   via  691fe9a docs: Fix typos in smb.conf (inherit acls)
   via  851b93d samba: Retain case sensitivity of cifs client
   via  2eb6bbd printing: reload printer shares on OpenPrinter
   via  668127f smbd: split printer reload processing
   via  051cd1d server: remove duplicate snum_is_shared_printer()
   via  1a2a342 smbd: only reprocess printer_list.tdb if it changed
   via  918f7db printing: return last change time with pcap_cache_loaded()
   via  a4b2289 printing: remove pcap_cache_add()
   via  bad147d printing: reload printer_list.tdb from in memory list
   via  a97c2db printing: only reload printer shares on client enum
   via  c82338f printing: traverse_read the printer list for share updates
   via  d3fb60a s3: smbd : SMB2 - fix SMB2_SEARCH when searching non 
wildcard string with a case-canonicalized share.
   via  8a2f945 s3: smbd - SMB[2|3]. Ensure a \ or / can't be found 
anywhere in a search path, not just at the start.
   via  9977aa9 s3: enforce a positive allocation_file_size for non-empty 
files (bug #10543)
   via  7ff8102 passdb: fix NT_STATUS_NO_SUCH_GROUP
   via  8c97d9a s3:libsmb: Set a max charge for SMB2 connections
   via  cad42ef s3: smbd: POSIX ACLs. Remove incorrect check for 
SECINFO_PROTECTED_DACL in incoming security_information flags in 
posix_get_nt_acl_common().
   via  9fadcf3 libcli/security: add better detection of 
SECINFO_[UN]PROTECTED_[D|S]ACL in get_sec_info()
   via  c0ddfc1 s3:smbd: mask security_information input values with 
SMB_SUPPORTED_SECINFO_FLAGS
   via  04916e0 security.idl: add SMB_SUPPORTED_SECINFO_FLAGS
   via  6db4a91 Fixed a memory leak in cli_set_mntpoint().
   via  624a52f lib: Remove unused nstrcpy
   via  796afb4 build: fix configure to honour --without-dmapi
   via  473ccb5 tests: dnsserver: Add a update test with name set to '.'
   via  e61ee11 s4-rpc: dnsserver: Allow . to be specified for @ record
   via  8dbf363 s3: net time - fix usage and core dump.
   via  2cac0df s3: xml-docs. Ensure users of 'net time' know the remote 
server must be specified with -S.
   via  fb49656 sys_poll_intr: fix timeout arithmetic
   via  6030045 lib: tevent: make TEVENT_SIG_INCREMENT atomic.
   via  03e9c64 VERSION: Bump version up to 4.0.22.
   via  13ccfd2 Merge tag 'samba-4.0.21' into v4-0-test
   via  00fe8eb VERSION: Bump version number up to 4.0.21...
  from  2ec2bd6 VERSION: Disable git snapshots for the 4.0.21 release.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-stable


- Log -
---

Summary of changes:
 VERSION|2 +-
 WHATSNEW.txt   |  115 +++-
 docs-xml/manpages/net.8.xml|   15 ++-
 docs-xml/smbdotconf/security/inheritowner.xml  |6 +-
 .../smbdotconf/winbind/winbindrequesttimeout.xml   |   16 +++
 lib/param/param_functions.c|1 +
 lib/param/param_table.c|9 ++
 lib/replace/replace.h  |5 +
 lib/replace/wscript|   25 +
 lib/tevent/tevent_signal.c |6 +
 lib/util/select.c  |   14 ++-
 lib/util/string_wrappers.h |5 -
 libcli/security/secdesc.c  |   36 ---
 librpc/idl/security.idl|   18 +++
 python/samba/tests/dcerpc/dnsserver.py |   41 +++-
 selftest/target/Samba.pm   |7 +-
 source3/include/proto.h|1 +
 source3/libsmb/clidfs.c|6 +-
 source3/libsmb/libsmb_server.c |5 +
 source3/modules/vfs_default.c  |   12 ++
 source3/modules/vfs_dirsort.c  |2 +-
 source3/param/loadparm.c   |1 +
 source3/passdb/pdb_samba_dsdb.c|6 +-
 source3/printing/load.c

[SCM] Samba Website Repository - branch master updated

2014-09-15 Thread Karolin Seeger 
The branch, master has been updated
   via  2aabaff Announce Samba 4.0.22.
  from  7b20344 Announce Samba 4.1.12.

http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master


- Log -
commit 2aabaff1107ff509d7fd84c5a8232a43371e5c45
Author: Karolin Seeger ksee...@samba.org
Date:   Mon Sep 15 10:50:28 2014 +0200

Announce Samba 4.0.22.

Signed-off-by: Karolin Seeger ksee...@samba.org

---

Summary of changes:
 generated_news/latest_10_bodies.html |   26 
 generated_news/latest_10_headlines.html  |4 +-
 generated_news/latest_2_bodies.html  |   31 +++---
 history/header_history.html  |1 +
 history/{samba-4.1.12.html = samba-4.0.22.html} |   36 +-
 5 files changed, 36 insertions(+), 62 deletions(-)
 copy history/{samba-4.1.12.html = samba-4.0.22.html} (68%)


Changeset truncated at 500 lines:

diff --git a/generated_news/latest_10_bodies.html 
b/generated_news/latest_10_bodies.html
index a15af8a..9b251e0 100644
--- a/generated_news/latest_10_bodies.html
+++ b/generated_news/latest_10_bodies.html
@@ -1,3 +1,16 @@
+   h5a name=4.0.2215 September 2014/a/h5
+   p class=headlineSamba 4.0.22 Available for Download/p
+   pThis is the latest stable release of the Samba 4.0 series./p
+
+pThe uncompressed tarballs and patch files have been signed
+using GnuPG (ID 6568B7EA).  The source code can be
+a href=http://samba.org/samba/ftp/stable/samba-4.0.22.tar.gz;downloaded
+now/a. A a 
href=http://samba.org/samba/ftp/patches/patch-4.0.21-4.0.22.diffs.gz;
+patch against Samba 4.0.21/a is also available. See
+a href=http://samba.org/samba/history/samba-4.0.22.html; the release notes
+ for more info/a./p
+
+
h5a name=4.1.1208 September 2014/a/h5
p class=headlineSamba 4.1.12 Available for Download/p
pThis is the latest stable release of the Samba 4.1 series./p
@@ -124,16 +137,3 @@ now/a. A a 
href=http://samba.org/samba/ftp/patches/patch-4.1.6-4.1.7.diffs.g
 patch against Samba 4.1.6/a is also available. See
 a href=http://samba.org/samba/history/samba-4.1.7.html; the release notes
  for more info/a./p
-
-
-   h5a name=4.0.1715 April 2014/a/h5
-   p class=headlineSamba 4.0.17 Available for Download/p
-   pThis is the latest stable release of the Samba 4.0 series./p
-
-pThe uncompressed tarballs and patch files have been signed
-using GnuPG (ID 6568B7EA).  The source code can be
-a href=http://samba.org/samba/ftp/stable/samba-4.0.17.tar.gz;downloaded
-now/a. A a 
href=http://samba.org/samba/ftp/patches/patch-4.0.16-4.0.17.diffs.gz;
-patch against Samba 4.0.16/a is also available. See
-a href=http://samba.org/samba/history/samba-4.0.17.html; the release notes
- for more info/a./p
diff --git a/generated_news/latest_10_headlines.html 
b/generated_news/latest_10_headlines.html
index c7f0e6c..88db35c 100644
--- a/generated_news/latest_10_headlines.html
+++ b/generated_news/latest_10_headlines.html
@@ -1,4 +1,6 @@
 ul
+   li 15 September 2014 a href=#4.0.22Samba 4.0.22 Available for 
Download/a/li
+
li 08 September 2014 a href=#4.1.12Samba 4.1.12 Available for 
Download/a/li
 
li 01 August 2014 a href=#4.1.11Samba 4.1.11 and 4.0.21 Security
@@ -19,6 +21,4 @@
li 05 May 2014a href=#sambaxp2014SambaXP 2014: conference 
schedule is online!/a/li
 
li 17 April 2014 a href=#4.1.7Samba 4.1.7 Available for 
Download/a/li
-
-   li 15 April 2014 a href=#4.0.17Samba 4.0.17 Available for 
Download/a/li
 /ul
diff --git a/generated_news/latest_2_bodies.html 
b/generated_news/latest_2_bodies.html
index a1fa033..5609f1a 100644
--- a/generated_news/latest_2_bodies.html
+++ b/generated_news/latest_2_bodies.html
@@ -1,3 +1,15 @@
+   h5a name=4.0.2215 September 2014/a/h5
+   p class=headlineSamba 4.0.22 Available for Download/p
+   pThis is the latest stable release of the Samba 4.0 series./p
+
+pThe uncompressed tarballs and patch files have been signed
+using GnuPG (ID 6568B7EA).  The source code can be
+a href=http://samba.org/samba/ftp/stable/samba-4.0.22.tar.gz;downloaded
+now/a. A a 
href=http://samba.org/samba/ftp/patches/patch-4.0.21-4.0.22.diffs.gz;
+patch against Samba 4.0.21/a is also available. See
+a href=http://samba.org/samba/history/samba-4.0.22.html; the release notes
+ for more info/a./p
+
h5a name=4.1.1208 September 2014/a/h5
p class=headlineSamba 4.1.12 Available for Download/p
pThis is the latest stable release of the Samba 4.1 series./p
@@ -9,22 +21,3 @@ now/a. A a 
href=http://samba.org/samba/ftp/patches/patch-4.1.11-4.1.12.diffs
 patch against Samba 4.1.11/a is also available. See
 a href=http://samba.org/samba/history/samba-4.1.12.html; the release notes
  for more info/a./p
-
-
-   h5a name=4.1.1101 August 2014/a/h5
-   p class=headlineSamba

[SCM] Samba Website Repository - branch master updated

2014-09-15 Thread Karolin Seeger 
The branch, master has been updated
   via  620a906 Fix typo in the 4.0.22 release notes.
  from  2aabaff Announce Samba 4.0.22.

http://gitweb.samba.org/?p=samba-web.git;a=shortlog;h=master


- Log -
commit 620a9067431b40fcafebd1d43b8abd629deed4f3
Author: Karolin Seeger ksee...@samba.org
Date:   Mon Sep 15 11:49:26 2014 +0200

Fix typo in the 4.0.22 release notes.

Signed-off-by: Karolin Seeger ksee...@samba.org

---

Summary of changes:
 history/samba-4.0.22.html |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/history/samba-4.0.22.html b/history/samba-4.0.22.html
index 3dfcafb..53bf594 100755
--- a/history/samba-4.0.22.html
+++ b/history/samba-4.0.22.html
@@ -26,7 +26,7 @@ o  New parameter winbind request timeout has been added 
(bug #3204). Please
see smb.conf man page for details.
 
 
-Changes since 4.1.21:
+Changes since 4.0.21:
 -
 
 o   Michael Adam lt;ob...@samba.orggt;


-- 
Samba Website Repository

autobuild: intermittent test failure detected

2014-09-15 Thread autobuild 
The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2014-09-15-1243/flakey.log

The samba build logs are available here:

   http://git.samba.org/autobuild.flakey/2014-09-15-1243/samba.stderr
   http://git.samba.org/autobuild.flakey/2014-09-15-1243/samba.stdout
  
The top commit at the time of the failure was:

commit 7bc2e2d0d4a6706769a436798aa29d18a8f7c221
Author: Volker Lendecke v...@samba.org
Date:   Wed Sep 10 16:13:18 2014 +0200

messaging_dgm: Don't expose the messaging_dgm_context

Right now we can only support one messaging_dgm_context per process
anyway, the code has checks for this. I would like to keep it that
way, in the future we will have multiple messaging_context's or
imessaging_context's filtering based upon the dst server_id.

Why this change? messaging_dgm's lockfile contains the
serverid-unique_id. When designing messaging_dgm, I had in mind to
remove the serverid.tdb and replace it with the dgm lockfiles for server
lookup and enumeration. I have a WIP-patchset that gets rid of almost
all users of serverid.tdb. The problem is serverid_exists. Here we don't
have a messaging_context available, and it would be pretty intrusive
to make it so. This problem has plagued us since ctdb was developed,
see for example the comment

/*
 * This is a Samba3 hack/optimization. Routines like process_exists need to
 * talk to ctdbd, and they don't get handed a messaging context.
 */

in messaging_ctdb.c. This patchset removes this problem in a radical way:
Treat the messaging_dgm context as one globally available structure and
be done with it. The ctdb socket could go the same way in the future.

Signed-off-by: Volker Lendecke v...@samba.org
Reviewed-by: Stefan Metzmacher me...@samba.org

Autobuild-User(master): Stefan Metzmacher me...@samba.org
Autobuild-Date(master): Sun Sep 14 16:29:30 CEST 2014 on sn-devel-104

[SCM] Samba Shared Repository - branch master updated

2014-09-15 Thread Michael Adam 
The branch, master has been updated
   via  92da0b2 s3: winbindd: Old NT Domain code sets struct 
winbind_domain-alt_name to be NULL. Ensure this is safe with modern AD-DCs.
  from  7bc2e2d messaging_dgm: Don't expose the messaging_dgm_context

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 92da0b243c18546275c4736507188eba425a0732
Author: Jeremy Allison j...@samba.org
Date:   Wed Jul 16 12:41:55 2014 -0700

s3: winbindd: Old NT Domain code sets struct winbind_domain-alt_name to be 
NULL. Ensure this is safe with modern AD-DCs.

There are places in the code where we're not checking that alt_name is NULL
and then calling into the DC lookup code with a NULL name request. This can
happen in offline mode.

Fixes bug #10717 - Winbind crash on losing VPN connection

https://bugzilla.samba.org/show_bug.cgi?id=10717

Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: Michael Adam ob...@samba.org

Autobuild-User(master): Michael Adam ob...@samba.org
Autobuild-Date(master): Mon Sep 15 23:29:00 CEST 2014 on sn-devel-104

---

Summary of changes:
 source3/winbindd/winbindd_ads.c |3 ++-
 source3/winbindd/winbindd_cm.c  |8 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_ads.c b/source3/winbindd/winbindd_ads.c
index cfda82c..2e2239b 100644
--- a/source3/winbindd/winbindd_ads.c
+++ b/source3/winbindd/winbindd_ads.c
@@ -183,6 +183,7 @@ ADS_STATUS ads_idmap_cached_connection(ADS_STRUCT **adsp, 
const char *dom_name)
}
 
if (IS_DC) {
+   SMB_ASSERT(wb_dom-alt_name != NULL);
realm = SMB_STRDUP(wb_dom-alt_name);
} else {
struct winbindd_domain *our_domain = wb_dom;
@@ -239,7 +240,7 @@ static ADS_STRUCT *ads_cached_connection(struct 
winbindd_domain *domain)
}
 
if ( IS_DC ) {
-
+   SMB_ASSERT(domain-alt_name != NULL);
realm = SMB_STRDUP(domain-alt_name);
}
else {
diff --git a/source3/winbindd/winbindd_cm.c b/source3/winbindd/winbindd_cm.c
index 95c0aa8..01a4aa2 100644
--- a/source3/winbindd/winbindd_cm.c
+++ b/source3/winbindd/winbindd_cm.c
@@ -836,6 +836,10 @@ static NTSTATUS get_trust_creds(const struct 
winbindd_domain *domain,
return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;   

}
 
+   if (our_domain-alt_name == NULL) {
+   return NT_STATUS_INVALID_PARAMETER;
+   }
+
if (asprintf(machine_krb5_principal, %s$@%s,
 account_name, our_domain-alt_name) == -1)
{
@@ -1202,7 +1206,7 @@ static bool dcip_to_name(TALLOC_CTX *mem_ctx,
/* For active directory servers, try to get the ldap server name.
   None of these failures should be considered critical for now */
 
-   if (lp_security() == SEC_ADS) {
+   if ((lp_security() == SEC_ADS)  (domain-alt_name != NULL)) {
ADS_STRUCT *ads;
ADS_STATUS ads_status;
char addr[INET6_ADDRSTRLEN];
@@ -1328,7 +1332,7 @@ static bool get_dcs(TALLOC_CTX *mem_ctx, struct 
winbindd_domain *domain,
return True;
}
 
-   if (sec == SEC_ADS) {
+   if ((sec == SEC_ADS)  (domain-alt_name != NULL)) {
char *sitename = NULL;
 
/* We need to make sure we know the local site before


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

2014-09-15 Thread Jeremy Allison 
The branch, master has been updated
   via  c56a88d vfs_gpfs: Fix the build with profiling-data
  from  92da0b2 s3: winbindd: Old NT Domain code sets struct 
winbind_domain-alt_name to be NULL. Ensure this is safe with modern AD-DCs.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit c56a88da6ec7be1a0f042270a5750c4834a9e95a
Author: Volker Lendecke v...@samba.org
Date:   Fri Sep 12 13:03:52 2014 +0200

vfs_gpfs: Fix the build with profiling-data

This fails with -Werror=declaration-after-statement

Signed-off-by: Volker Lendecke v...@samba.org
Reviewed-by: Jeremy Allison j...@samba.org

Autobuild-User(master): Jeremy Allison j...@samba.org
Autobuild-Date(master): Tue Sep 16 01:55:57 CEST 2014 on sn-devel-104

---

Summary of changes:
 source3/modules/vfs_gpfs.c |8 
 1 files changed, 4 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
index e722a86..6ead65b 100644
--- a/source3/modules/vfs_gpfs.c
+++ b/source3/modules/vfs_gpfs.c
@@ -78,6 +78,8 @@ static int vfs_gpfs_kernel_flock(vfs_handle_struct *handle, 
files_struct *fsp,
struct gpfs_config_data *config;
int ret = 0;
 
+   START_PROFILE(syscall_kernel_flock);
+
SMB_VFS_HANDLE_GET_DATA(handle, config,
struct gpfs_config_data,
return -1);
@@ -86,8 +88,6 @@ static int vfs_gpfs_kernel_flock(vfs_handle_struct *handle, 
files_struct *fsp,
return 0;
}
 
-   START_PROFILE(syscall_kernel_flock);
-
kernel_flock(fsp-fh-fd, share_mode, access_mask);
 
if (!set_gpfs_sharemode(fsp, access_mask, fsp-share_access)) {
@@ -121,6 +121,8 @@ static int vfs_gpfs_setlease(vfs_handle_struct *handle, 
files_struct *fsp,
struct gpfs_config_data *config;
int ret=0;
 
+   START_PROFILE(syscall_linux_setlease);
+
SMB_VFS_HANDLE_GET_DATA(handle, config,
struct gpfs_config_data,
return -1);
@@ -128,8 +130,6 @@ static int vfs_gpfs_setlease(vfs_handle_struct *handle, 
files_struct *fsp,
if (linux_set_lease_sighandler(fsp-fh-fd) == -1)
return -1;
 
-   START_PROFILE(syscall_linux_setlease);
-
if (config-leases) {
/*
 * Ensure the lease owner is root to allow


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

2014-09-15 Thread David Disseldorp 
The branch, master has been updated
   via  df800ea Add test suite for iconv conversion fail of bad names over 
SMB1/SMB3.
   via  6d03aed s3: smbd: Fix a couple of tricky slow-path cases - don't 
return a mangled name for a name that cannot be converted.
   via  2fc8d0e s3: smbd: Change get_lanman2_dir_entry() to return the full 
NTSTATUS.
   via  c9877ea s3: smbd: Remove unneeded 'out_of_space' parameter from 
smbd_dirptr_lanman2_entry().
   via  5293dd2 s3: smbd: SMB2 - change smbd_dirptr_lanman2_entry() to 
return an NTSTATUS.
   via  d17fc79 s3: smbd: smbd_marshall_dir_entry() no longer needs 
explicit 'out_of_space' parameter.
   via  2bddcee s3: smbd: Change smbd_marshall_dir_entry() to return an 
NTSTATUS. Returns STATUS_MORE_ENTRIES on out of space.
   via  0519088 s3: smbd: Change the function signature of srvstr_push() 
from returning a length to returning an NTSTATUS with a length param.
   via  c7b89bb s3: smbd: Ensure types for all variables called 'len' used 
in srvstr_push() are correct.
   via  5c7e272 s3: smbd: srvstr_push() was changed to never return -1, so 
don't check for that as an error.
   via  6bce3d8 s3: utils: Don't directly manipulate errno inside 
strupper_m().
  from  c56a88d vfs_gpfs: Fix the build with profiling-data

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit df800ea6fb307abae785d3a5da60f4db70e9bc68
Author: Jeremy Allison j...@samba.org
Date:   Wed Aug 27 13:15:29 2014 -0700

Add test suite for iconv conversion fail of bad names over SMB1/SMB3.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: David Disseldorp dd...@samba.org

Autobuild-User(master): David Disseldorp dd...@samba.org
Autobuild-Date(master): Tue Sep 16 04:21:49 CEST 2014 on sn-devel-104

commit 6d03aed15e1be4c126c2de4708d0b1cd112ba901
Author: Jeremy Allison j...@samba.org
Date:   Tue Aug 26 16:39:56 2014 -0700

s3: smbd: Fix a couple of tricky slow-path cases - don't return a mangled 
name for a name that cannot be converted.

For a name that contains an illegal Windows character, the
directory listing code returns the mangled 8.3 name as the
primary name for the file.

If the original (non-mangled) filename cannot be converted
to UCS2 on the wire via iconv due to conversion error, we
should skip that name when returning a directory listing,
as we can't map back from a returned 8.3 name to a usable
non-mangled filename if the client sends it back to us.

As this is only done in a very slow path (name must be mangled)
or in the old DOS protocol listing code I don't feel too bad
about using a talloc/free pair here.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: David Disseldorp dd...@samba.org

commit 2fc8d0e0e85cd118f114f234a7eac3902d01c32e
Author: Jeremy Allison j...@samba.org
Date:   Tue Aug 26 15:05:24 2014 -0700

s3: smbd: Change get_lanman2_dir_entry() to return the full NTSTATUS.

Handle the errors correctly at the level above inside the SMB1 server.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: David Disseldorp dd...@samba.org

commit c9877eaf1b0ee83e4227483cb6891f94712bd32f
Author: Jeremy Allison j...@samba.org
Date:   Tue Aug 26 14:54:56 2014 -0700

s3: smbd: Remove unneeded 'out_of_space' parameter from 
smbd_dirptr_lanman2_entry().

This can now be handled by checking for the STATUS_MORE_ENTRIES error 
return.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: David Disseldorp dd...@samba.org

commit 5293dd2f635f049cd0632b071307df6a6c52d9b0
Author: Jeremy Allison j...@samba.org
Date:   Tue Aug 26 14:49:37 2014 -0700

s3: smbd: SMB2 - change smbd_dirptr_lanman2_entry() to return an NTSTATUS.

Handle the errors correctly at the top level inside the SMB2 server.

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: David Disseldorp dd...@samba.org

commit d17fc79ee6c80702fe5ce007bdbc68b3d21bc8a0
Author: Jeremy Allison j...@samba.org
Date:   Tue Aug 26 11:40:19 2014 -0700

s3: smbd: smbd_marshall_dir_entry() no longer needs explicit 'out_of_space' 
parameter.

Handle this in the caller when it returns STATUS_MORE_ENTRIES.

autobuild: intermittent test failure detected

2014-09-15 Thread autobuild 
The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2014-09-16-0445/flakey.log

The samba build logs are available here:

   http://git.samba.org/autobuild.flakey/2014-09-16-0445/samba.stderr
   http://git.samba.org/autobuild.flakey/2014-09-16-0445/samba.stdout
  
The top commit at the time of the failure was:

commit c56a88da6ec7be1a0f042270a5750c4834a9e95a
Author: Volker Lendecke v...@samba.org
Date:   Fri Sep 12 13:03:52 2014 +0200

vfs_gpfs: Fix the build with profiling-data

This fails with -Werror=declaration-after-statement

Signed-off-by: Volker Lendecke v...@samba.org
Reviewed-by: Jeremy Allison j...@samba.org

Autobuild-User(master): Jeremy Allison j...@samba.org
Autobuild-Date(master): Tue Sep 16 01:55:57 CEST 2014 on sn-devel-104