autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-27-0845/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-27-0845/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-27-0845/samba.stdout The top commit at the time of the failure was: commit 465c3d9a4e1a30e334922149f3ed1057f09fe169 Author: Uri Simchoni Date: Mon Jan 18 23:34:48 2016 +0200 smbd quotas: avoid stat of foreign file systems When determining the block device of our file system, avoid stat'ing paths which are definitely not the mount point of our file system. This is done to avoid stalling smbd due to unresponsive network file systems (e.g. NFS) which are not related to the SMB shares. See discussion in samba-technical for vfs_fileid: https://lists.samba.org/archive/samba-technical/2016-January/111553.html Signed-off-by: Uri Simchoni Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Jan 27 03:35:48 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-27-0845/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-27-0845/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-27-0845/samba.stdout The top commit at the time of the failure was: commit 465c3d9a4e1a30e334922149f3ed1057f09fe169 Author: Uri Simchoni Date: Mon Jan 18 23:34:48 2016 +0200 smbd quotas: avoid stat of foreign file systems When determining the block device of our file system, avoid stat'ing paths which are definitely not the mount point of our file system. This is done to avoid stalling smbd due to unresponsive network file systems (e.g. NFS) which are not related to the SMB shares. See discussion in samba-technical for vfs_fileid: https://lists.samba.org/archive/samba-technical/2016-January/111553.html Signed-off-by: Uri Simchoni Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Jan 27 03:35:48 CET 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-27-0443/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-27-0443/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-27-0443/samba.stdout The top commit at the time of the failure was: commit 465c3d9a4e1a30e334922149f3ed1057f09fe169 Author: Uri Simchoni Date: Mon Jan 18 23:34:48 2016 +0200 smbd quotas: avoid stat of foreign file systems When determining the block device of our file system, avoid stat'ing paths which are definitely not the mount point of our file system. This is done to avoid stalling smbd due to unresponsive network file systems (e.g. NFS) which are not related to the SMB shares. See discussion in samba-technical for vfs_fileid: https://lists.samba.org/archive/samba-technical/2016-January/111553.html Signed-off-by: Uri Simchoni Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Jan 27 03:35:48 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-27-0438/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-27-0438/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-27-0438/samba.stdout The top commit at the time of the failure was: commit 465c3d9a4e1a30e334922149f3ed1057f09fe169 Author: Uri Simchoni Date: Mon Jan 18 23:34:48 2016 +0200 smbd quotas: avoid stat of foreign file systems When determining the block device of our file system, avoid stat'ing paths which are definitely not the mount point of our file system. This is done to avoid stalling smbd due to unresponsive network file systems (e.g. NFS) which are not related to the SMB shares. See discussion in samba-technical for vfs_fileid: https://lists.samba.org/archive/samba-technical/2016-January/111553.html Signed-off-by: Uri Simchoni Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Jan 27 03:35:48 CET 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 465c3d9 smbd quotas: avoid stat of foreign file systems
via c6ed45f s3-lib: introduce sys_realpath()
from f0c43ce dbwrap_file: fix use of read_data()
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 465c3d9a4e1a30e334922149f3ed1057f09fe169
Author: Uri Simchoni
Date: Mon Jan 18 23:34:48 2016 +0200
smbd quotas: avoid stat of foreign file systems
When determining the block device of our file system, avoid
stat'ing paths which are definitely not the mount point of
our file system. This is done to avoid stalling smbd due to
unresponsive network file systems (e.g. NFS) which are not
related to the SMB shares.
See discussion in samba-technical for vfs_fileid:
https://lists.samba.org/archive/samba-technical/2016-January/111553.html
Signed-off-by: Uri Simchoni
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Wed Jan 27 03:35:48 CET 2016 on sn-devel-144
commit c6ed45fe710924f847f46d505ceabfec21e7cf38
Author: Uri Simchoni
Date: Mon Jan 18 23:34:06 2016 +0200
s3-lib: introduce sys_realpath()
Add sys_realpath() function that captures the OS variations
on realpath().
Signed-off-by: Uri Simchoni
Reviewed-by: Jeremy Allison
---
Summary of changes:
source3/include/proto.h | 1 +
source3/lib/sysquotas.c | 71 +--
source3/lib/system.c | 25 +++
source3/modules/vfs_default.c | 15 +
4 files changed, 88 insertions(+), 24 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/include/proto.h b/source3/include/proto.h
index e18aaf4..09e9915 100644
--- a/source3/include/proto.h
+++ b/source3/include/proto.h
@@ -264,6 +264,7 @@ int sys_setxattr (const char *path, const char *name, const
void *value, size_t
int sys_fsetxattr (int filedes, const char *name, const void *value, size_t
size, int flags);
uint32_t unix_dev_major(SMB_DEV_T dev);
uint32_t unix_dev_minor(SMB_DEV_T dev);
+char *sys_realpath(const char *path);
#if 0
int sys_get_number_of_cores(void);
#endif
diff --git a/source3/lib/sysquotas.c b/source3/lib/sysquotas.c
index 2ef1d1b..bacc4b2 100644
--- a/source3/lib/sysquotas.c
+++ b/source3/lib/sysquotas.c
@@ -40,35 +40,84 @@
#endif /* NO_QUOTACTL_USED */
-#ifdef HAVE_MNTENT
+#if defined(HAVE_MNTENT) && defined(HAVE_REALPATH)
static int sys_path_to_bdev(const char *path, char **mntpath, char **bdev,
char **fs)
{
int ret = -1;
SMB_STRUCT_STAT S;
FILE *fp;
- struct mntent *mnt;
+ struct mntent *mnt = NULL;
SMB_DEV_T devno;
+ char *stat_mntpath = NULL;
+ char *p;
/* find the block device file */
-
- if (!path||!mntpath||!bdev||!fs)
- smb_panic("sys_path_to_bdev: called with NULL pointer");
-
(*mntpath) = NULL;
(*bdev) = NULL;
(*fs) = NULL;
-
- if ( sys_stat(path, &S, false) == -1 )
- return (-1);
+
+ if (sys_stat(path, &S, false) != 0) {
+ return -1;
+ }
devno = S.st_ex_dev ;
+ stat_mntpath = sys_realpath(path);
+ if (stat_mntpath == NULL) {
+ DBG_WARNING("realpath(%s) failed - %s\n", path,
+ strerror(errno));
+ goto out;
+ }
+
+ if (sys_stat(stat_mntpath, &S, false) != 0) {
+ DBG_WARNING("cannot stat real path %s - %s\n", stat_mntpath,
+ strerror(errno));
+ goto out;
+ }
+
+ if (S.st_ex_dev != devno) {
+ DBG_WARNING("device on real path has changed\n");
+ goto out;
+ }
+
+ while (true) {
+ p = strrchr(stat_mntpath, '/');
+ if (p == NULL) {
+ DBG_ERR("realpath for %s does not begin with a '/'\n",
+ path);
+ goto out;
+ }
+
+ if (p == stat_mntpath) {
+ ++p;
+ }
+
+ *p = 0;
+ if (sys_stat(stat_mntpath, &S, false) != 0) {
+ DBG_WARNING("cannot stat real path component %s - %s\n",
+ stat_mntpath, strerror(errno));
+ goto out;
+ }
+ if (S.st_ex_dev != devno) {
+ *p = '/';
+ break;
+ }
+
+ if (p <= stat_mntpath + 1) {
+ break;
+ }
+ }
+
fp = setmntent(MOUNTED,"r");
if (fp == NULL) {
- return -1;
+ goto out;
}
while ((mnt = getmntent
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-27-0045/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-27-0045/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-27-0045/samba.stdout The top commit at the time of the failure was: commit 07bb954d929cf2aa61afe469c14ecba449cd5d43 Author: Karolin Seeger Date: Tue Jan 26 11:17:37 2016 +0100 VERSION: Bump version up to 4.5.0pre1 Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Jan 26 19:12:42 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-27-0043/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-27-0043/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-27-0043/samba.stdout The top commit at the time of the failure was: commit 07bb954d929cf2aa61afe469c14ecba449cd5d43 Author: Karolin Seeger Date: Tue Jan 26 11:17:37 2016 +0100 VERSION: Bump version up to 4.5.0pre1 Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Jan 26 19:12:42 CET 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via f0c43ce dbwrap_file: fix use of read_data()
via 32e545e s4-torture: let smb2.replay.replay4 test deal with scale
out shares.
via 757ade6 s4-torture: let smb2.replay.replay3 test deal with scale
out shares.
via 9c23f43 s4-torture: let smb2.replay.replay2 test deal with scale
out shares.
from 07bb954 VERSION: Bump version up to 4.5.0pre1
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit f0c43ceec5185ef4bc429e201339f3eb3e7c094b
Author: Uri Simchoni
Date: Thu Jan 21 13:18:20 2016 +0200
dbwrap_file: fix use of read_data()
Signed-off-by: Uri Simchoni
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Wed Jan 27 00:09:05 CET 2016 on sn-devel-144
commit 32e545ecea4f217c8b723fbea5d9131573a50488
Author: Günther Deschner
Date: Fri Jan 15 18:30:15 2016 +0100
s4-torture: let smb2.replay.replay4 test deal with scale out shares.
Guenther
Signed-off-by: Guenther Deschner
Reviewed-by: Jeremy Allison
commit 757ade67e6830ed66eeeb4954d1fd24d83effb13
Author: Günther Deschner
Date: Fri Jan 15 18:24:08 2016 +0100
s4-torture: let smb2.replay.replay3 test deal with scale out shares.
Guenther
Signed-off-by: Guenther Deschner
Reviewed-by: Jeremy Allison
commit 9c23f43f9edd8cfbfdd56e397748e2f74b1ef29b
Author: Günther Deschner
Date: Fri Jan 15 18:07:31 2016 +0100
s4-torture: let smb2.replay.replay2 test deal with scale out shares.
Guenther
Signed-off-by: Guenther Deschner
Reviewed-by: Jeremy Allison
---
Summary of changes:
lib/dbwrap/dbwrap_file.c | 11 +++---
source4/torture/smb2/replay.c | 80 ++-
2 files changed, 68 insertions(+), 23 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/dbwrap/dbwrap_file.c b/lib/dbwrap/dbwrap_file.c
index a3b1737..46e62c8 100644
--- a/lib/dbwrap/dbwrap_file.c
+++ b/lib/dbwrap/dbwrap_file.c
@@ -171,7 +171,7 @@ static struct db_record *db_file_fetch_locked(struct
db_context *db,
result->value.dptr = NULL;
if (statbuf.st_ex_size != 0) {
- NTSTATUS status;
+ ssize_t read_bytes;
result->value.dsize = statbuf.st_ex_size;
result->value.dptr = talloc_array(result, uint8_t,
@@ -182,11 +182,10 @@ static struct db_record *db_file_fetch_locked(struct
db_context *db,
return NULL;
}
- status = read_data(file->fd, (char *)result->value.dptr,
- result->value.dsize);
- if (!NT_STATUS_IS_OK(status)) {
- DEBUG(3, ("read_data failed: %s\n",
- nt_errstr(status)));
+ read_bytes = read_data(file->fd, (char *)result->value.dptr,
+ result->value.dsize);
+ if (read_bytes != result->value.dsize) {
+ DEBUG(3, ("read_data failed: %s\n", strerror(errno)));
TALLOC_FREE(result);
return NULL;
}
diff --git a/source4/torture/smb2/replay.c b/source4/torture/smb2/replay.c
index 57b14f1..4b3f569 100644
--- a/source4/torture/smb2/replay.c
+++ b/source4/torture/smb2/replay.c
@@ -302,12 +302,17 @@ static bool test_replay2(struct torture_context *tctx,
struct smb2_tree *tree)
bool ret = true;
const char *fname = BASEDIR "\\replay2.dat";
struct smb2_transport *transport = tree->session->transport;
+ uint32_t share_capabilities;
+ bool share_is_so;
if (smbXcli_conn_protocol(transport->conn) < PROTOCOL_SMB3_00) {
torture_skip(tctx, "SMB 3.X Dialect family required for "
"replay tests\n");
}
+ share_capabilities = smb2cli_tcon_capabilities(tree->smbXcli);
+ share_is_so = share_capabilities & SMB2_SHARE_CAP_SCALEOUT;
+
ZERO_STRUCT(break_info);
break_info.tctx = tctx;
tree->session->transport->oplock.handler = torture_oplock_ack_handler;
@@ -336,10 +341,16 @@ static bool test_replay2(struct torture_context *tctx,
struct smb2_tree *tree)
_h = io.out.file.handle;
h = &_h;
CHECK_CREATED(&io, CREATED, FILE_ATTRIBUTE_ARCHIVE);
- CHECK_VAL(io.out.oplock_level, smb2_util_oplock_level("b"));
CHECK_VAL(io.out.durable_open, false);
- CHECK_VAL(io.out.durable_open_v2, true);
- CHECK_VAL(io.out.timeout, io.in.timeout);
+ if (share_is_so) {
+ CHECK_VAL(io.out.oplock_level, smb2_util_oplock_level("s"));
+ CHECK_VAL(io.out.durable_open_v2, false);
+ CHECK_VAL(io.out.timeout,
[SCM] Samba Shared Repository - branch v4-2-test updated
The branch, v4-2-test has been updated
via be4f52b s4:torture: add SMB2 test for directory creation initial
allocation size
via e33472d s3:smbd: Ignore initial allocation size for directory
creation
from 279246d smbcacls: fix uninitialized variable
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-2-test
- Log -
commit be4f52b05057fbcdeea38d4a6b461648d4af3a41
Author: Ralph Boehme
Date: Wed Jan 20 17:46:38 2016 +0100
s4:torture: add SMB2 test for directory creation initial allocation size
Test that directory creation with an initial allocation size > 0
succeeds.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11684
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
Autobuild-User(master): Ralph Böhme
Autobuild-Date(master): Sun Jan 24 01:20:52 CET 2016 on sn-devel-144
(cherry picked from commit cd86f20e245cc1b0cb3be5d6cb1b45c45e2a45a8)
Autobuild-User(v4-2-test): Karolin Seeger
Autobuild-Date(v4-2-test): Tue Jan 26 23:51:46 CET 2016 on sn-devel-104
commit e33472d5f3bf7a3facd2541fd909c87bb43906eb
Author: Ralph Boehme
Date: Wed Nov 25 15:23:26 2015 +0100
s3:smbd: Ignore initial allocation size for directory creation
We reject directory creation with an initial allocation size > 0 with
NT_STATUS_ACCESS_DENIED. Windows servers ignore the initial allocation
size on directories.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11684
Pair-Programmed-With: Volker Lendecke
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
(cherry picked from commit 78ccbb07170c3e49a084d31434310f973e3d6158)
---
Summary of changes:
source3/smbd/open.c | 10 ++-
source4/torture/smb2/create.c | 64 +++
2 files changed, 67 insertions(+), 7 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 2e08818..5dbb0a5 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -4705,15 +4705,11 @@ static NTSTATUS create_file_unixpath(connection_struct
*conn,
/* Save the requested allocation size. */
if ((info == FILE_WAS_CREATED) || (info == FILE_WAS_OVERWRITTEN)) {
- if (allocation_size
- && (allocation_size > fsp->fsp_name->st.st_ex_size)) {
+ if ((allocation_size > fsp->fsp_name->st.st_ex_size)
+ && !(fsp->is_directory))
+ {
fsp->initial_allocation_size = smb_roundup(
fsp->conn, allocation_size);
- if (fsp->is_directory) {
- /* Can't set allocation size on a directory. */
- status = NT_STATUS_ACCESS_DENIED;
- goto fail;
- }
if (vfs_allocate_file_space(
fsp, fsp->initial_allocation_size) == -1) {
status = NT_STATUS_DISK_FULL;
diff --git a/source4/torture/smb2/create.c b/source4/torture/smb2/create.c
index 68dbbc1..1275aa8 100644
--- a/source4/torture/smb2/create.c
+++ b/source4/torture/smb2/create.c
@@ -1666,6 +1666,69 @@ done:
return ret;
}
+/*
+ test directory creation with an initial allocation size > 0
+*/
+static bool test_dir_alloc_size(struct torture_context *tctx,
+ struct smb2_tree *tree)
+{
+ bool ret = true;
+ const char *dname = DNAME "\\torture_alloc_size.dir";
+ NTSTATUS status;
+ struct smb2_create c;
+ struct smb2_handle h1 = {{0}}, h2;
+
+ torture_comment(tctx, "Checking initial allocation size on
directories\n");
+
+ smb2_deltree(tree, dname);
+
+ status = torture_smb2_testdir(tree, DNAME, &h1);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
"torture_smb2_testdir failed");
+
+ ZERO_STRUCT(c);
+ c.in.create_disposition = NTCREATEX_DISP_CREATE;
+ c.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
+ c.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
+ c.in.share_access = NTCREATEX_SHARE_ACCESS_NONE;
+ c.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+ c.in.fname = dname;
+ /*
+* An insanely large value so we can check the value is
+* ignored: Samba either returns 0 (current behaviour), or,
+* once vfswrap_get_alloc_size() is fixed to allow retrieving
+* the allocated size for directories, returns
+* smb_roundup(..., stat.st_size) which would be 1 MB by
+* default.
+*
+* Windows returns 0 for emtpy directories, once directories
+* have a few entries it starts replying with values > 0.
+*/
+ c.in.alloc_si
[SCM] Samba Shared Repository - branch v4-4-stable updated
The branch, v4-4-stable has been updated via 6c547b3 VERSION: Set version to 4.4.0rc1... via d201a20 WHATSNEW: Add smbstatus changes. via c1bbe58 WHATSNEW: Extend release notes for Samba 4.4.0rc1. via 192f151 waf: Only build smb_krb5_wrapper if we have CUPS via 91eeeb7 disk_quotas: style fix via 6689499 vfs_gpfs: make sure get_quota does not return bogus values via de3c2ed make disk_norm() static via a8eea0c vfs_gpfs: do not call disk_norm() on disk_free_fn via 9e60cbf vfs_ceph: do not call disk_norm() on disk_free_fn via 279c9ce vfs_fake_dfq: remove quota code from disk_free via 19f9b31 smbd: refactor disk_free handling via 72231ec vfs_snapper: add get_quota function via cc25335 vfs_shadow_copy2: add get_quota function via 22d757c vfs_cap: add get_quota function via c464b9e vfs: add path parameter to get_quota via f71761c selftest: add disk-free and quota tests based on fake_dfq VFS module via 540dcfa vfs_fake_dfq: add vfs module via 345f084 smbd: enable unit-testing of NT_TRANSACT_GET_USER_QUOTA via 17c9b8d quotas: correct comment about SMB_GROUP_QUOTA_TYPE via 798fcfd loadparm: introduce lp_parm_ulonglong() and lpcfg_parm_ulonglong() via 7a890a7 smbd:smb2_negprot: implement connection passing based on client_guid via cfbf450 smbd:smb2_server: let smbd_server_connection_terminate() only call exit_server() for the last connection via a446966 smbd:process: use smbXsrv_client_create. via 0010dc8 smbd:process: treat initialized table in smbXsrv_connection_init_tables via d77238f smbd: add smbXsrv_client.c via 8ab4629 smbd:globals.h: add guid_verified to smbXsrv_connection.smb2.client via 3590f3f idl:smbXsrv: add smbXsrv_connection_pass structures. via bae1b94 idl:smbXsrv: add smbXsrv_client_global structures via 5e91bf0 idl:messagaing: add MSG_SMBXSRV_CONNECTION_PASS from 6a24ccc s3:smbd: only process fsctl_network_iface_info if multi channel is enabled https://git.samba.org/?p=samba.git;a=shortlog;h=v4-4-stable - Log - --- Summary of changes: VERSION | 6 +- WHATSNEW.txt | 141 +- examples/VFS/skel_opaque.c | 5 +- examples/VFS/skel_transparent.c | 7 +- lib/param/loadparm.c | 33 ++ lib/param/param.h| 4 + librpc/idl/messaging.idl | 1 + selftest/selftesthelpers.py | 1 + selftest/target/Samba3.pm| 12 + source3/include/ntquotas.h | 2 +- source3/include/proto.h | 3 + source3/include/vfs.h| 6 +- source3/include/vfs_macros.h | 8 +- source3/librpc/idl/smbXsrv.idl | 69 +++ source3/modules/vfs_cap.c| 14 + source3/modules/vfs_ceph.c | 5 +- source3/modules/vfs_default.c| 14 +- source3/modules/vfs_default_quota.c | 13 +- source3/modules/vfs_fake_dfq.c | 174 +++ source3/modules/vfs_full_audit.c | 8 +- source3/modules/vfs_gpfs.c | 28 +- source3/modules/vfs_shadow_copy2.c | 34 ++ source3/modules/vfs_snapper.c| 34 ++ source3/modules/vfs_time_audit.c | 6 +- source3/modules/wscript_build| 7 + source3/param/loadparm.c | 16 + source3/script/tests/test_dfree_quota.sh | 174 +++ source3/selftest/tests.py| 1 + source3/smbd/dfree.c | 15 +- source3/smbd/globals.h | 17 + source3/smbd/ntquotas.c | 2 +- source3/smbd/nttrans.c | 2 +- source3/smbd/process.c | 15 +- source3/smbd/proto.h | 4 +- source3/smbd/quotas.c| 25 +- source3/smbd/smb2_negprot.c | 58 +++ source3/smbd/smb2_server.c | 17 +- source3/smbd/smbXsrv_client.c| 770 +++ source3/smbd/vfs.c | 4 +- source3/wscript | 1 + source3/wscript_build| 4 +- 41 files changed, 1676 insertions(+), 84 deletions(-) create mode 100644 source3/modules/vfs_fake_dfq.c create mode 100755 source3/script/tests/test_dfree_quota.sh create mode 100644 source3/smbd/smbXsrv_client.c Changeset truncated at 500 lines: diff --git a/VERSION b/VERSION index 7966f82..eba23fc 100644 --- a/VERSION +++ b/VERSION @@ -77,7 +77,7 @@ SAMBA_VERSION_BETA_RELEASE= # e.g. SAMBA_VERSION_PRE_RELEASE=1 # # -> "2.2.9pre1" # ##
[SCM] Samba Shared Repository - branch v4-4-test updated
The branch, v4-4-test has been updated via 1133650 VERSION: Bump version up to 4.4.0rc2... via 6c547b3 VERSION: Set version to 4.4.0rc1... via d201a20 WHATSNEW: Add smbstatus changes. via c1bbe58 WHATSNEW: Extend release notes for Samba 4.4.0rc1. via 192f151 waf: Only build smb_krb5_wrapper if we have CUPS via 91eeeb7 disk_quotas: style fix via 6689499 vfs_gpfs: make sure get_quota does not return bogus values via de3c2ed make disk_norm() static via a8eea0c vfs_gpfs: do not call disk_norm() on disk_free_fn via 9e60cbf vfs_ceph: do not call disk_norm() on disk_free_fn via 279c9ce vfs_fake_dfq: remove quota code from disk_free via 19f9b31 smbd: refactor disk_free handling via 72231ec vfs_snapper: add get_quota function via cc25335 vfs_shadow_copy2: add get_quota function via 22d757c vfs_cap: add get_quota function via c464b9e vfs: add path parameter to get_quota via f71761c selftest: add disk-free and quota tests based on fake_dfq VFS module via 540dcfa vfs_fake_dfq: add vfs module via 345f084 smbd: enable unit-testing of NT_TRANSACT_GET_USER_QUOTA via 17c9b8d quotas: correct comment about SMB_GROUP_QUOTA_TYPE via 798fcfd loadparm: introduce lp_parm_ulonglong() and lpcfg_parm_ulonglong() via 7a890a7 smbd:smb2_negprot: implement connection passing based on client_guid via cfbf450 smbd:smb2_server: let smbd_server_connection_terminate() only call exit_server() for the last connection via a446966 smbd:process: use smbXsrv_client_create. via 0010dc8 smbd:process: treat initialized table in smbXsrv_connection_init_tables via d77238f smbd: add smbXsrv_client.c via 8ab4629 smbd:globals.h: add guid_verified to smbXsrv_connection.smb2.client via 3590f3f idl:smbXsrv: add smbXsrv_connection_pass structures. via bae1b94 idl:smbXsrv: add smbXsrv_client_global structures via 5e91bf0 idl:messagaing: add MSG_SMBXSRV_CONNECTION_PASS from 6a24ccc s3:smbd: only process fsctl_network_iface_info if multi channel is enabled https://git.samba.org/?p=samba.git;a=shortlog;h=v4-4-test - Log - commit 11336502f3e588dc014beff7a88f9d1ad6c52a9f Author: Stefan Metzmacher Date: Tue Jan 26 21:16:15 2016 +0100 VERSION: Bump version up to 4.4.0rc2... ...and re-enable git snapshots. Signed-off-by: Stefan Metzmacher --- Summary of changes: VERSION | 4 +- WHATSNEW.txt | 141 +- examples/VFS/skel_opaque.c | 5 +- examples/VFS/skel_transparent.c | 7 +- lib/param/loadparm.c | 33 ++ lib/param/param.h| 4 + librpc/idl/messaging.idl | 1 + selftest/selftesthelpers.py | 1 + selftest/target/Samba3.pm| 12 + source3/include/ntquotas.h | 2 +- source3/include/proto.h | 3 + source3/include/vfs.h| 6 +- source3/include/vfs_macros.h | 8 +- source3/librpc/idl/smbXsrv.idl | 69 +++ source3/modules/vfs_cap.c| 14 + source3/modules/vfs_ceph.c | 5 +- source3/modules/vfs_default.c| 14 +- source3/modules/vfs_default_quota.c | 13 +- source3/modules/vfs_fake_dfq.c | 174 +++ source3/modules/vfs_full_audit.c | 8 +- source3/modules/vfs_gpfs.c | 28 +- source3/modules/vfs_shadow_copy2.c | 34 ++ source3/modules/vfs_snapper.c| 34 ++ source3/modules/vfs_time_audit.c | 6 +- source3/modules/wscript_build| 7 + source3/param/loadparm.c | 16 + source3/script/tests/test_dfree_quota.sh | 174 +++ source3/selftest/tests.py| 1 + source3/smbd/dfree.c | 15 +- source3/smbd/globals.h | 17 + source3/smbd/ntquotas.c | 2 +- source3/smbd/nttrans.c | 2 +- source3/smbd/process.c | 15 +- source3/smbd/proto.h | 4 +- source3/smbd/quotas.c| 25 +- source3/smbd/smb2_negprot.c | 58 +++ source3/smbd/smb2_server.c | 17 +- source3/smbd/smbXsrv_client.c| 770 +++ source3/smbd/vfs.c | 4 +- source3/wscript | 1 + source3/wscript_build| 4 +- 41 files changed, 1675 insertions(+), 83 deletions(-) create mode 100644 source3/modules/vfs_fake_dfq.c create mode 100755 source3/script/tests/test_dfree_quota.sh create mode 100644 source3/smbd/smbXsrv_client.c
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-26-2044/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-26-2044/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-26-2044/samba.stdout The top commit at the time of the failure was: commit 07bb954d929cf2aa61afe469c14ecba449cd5d43 Author: Karolin Seeger Date: Tue Jan 26 11:17:37 2016 +0100 VERSION: Bump version up to 4.5.0pre1 Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Jan 26 19:12:42 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-26-2043/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-26-2043/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-26-2043/samba.stdout The top commit at the time of the failure was: commit 07bb954d929cf2aa61afe469c14ecba449cd5d43 Author: Karolin Seeger Date: Tue Jan 26 11:17:37 2016 +0100 VERSION: Bump version up to 4.5.0pre1 Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Jan 26 19:12:42 CET 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 07bb954 VERSION: Bump version up to 4.5.0pre1 via 6c547b3 VERSION: Set version to 4.4.0rc1... via d201a20 WHATSNEW: Add smbstatus changes. via c1bbe58 WHATSNEW: Extend release notes for Samba 4.4.0rc1. via 192f151 waf: Only build smb_krb5_wrapper if we have CUPS via 91eeeb7 disk_quotas: style fix via 6689499 vfs_gpfs: make sure get_quota does not return bogus values via de3c2ed make disk_norm() static via a8eea0c vfs_gpfs: do not call disk_norm() on disk_free_fn via 9e60cbf vfs_ceph: do not call disk_norm() on disk_free_fn via 279c9ce vfs_fake_dfq: remove quota code from disk_free via 19f9b31 smbd: refactor disk_free handling via 72231ec vfs_snapper: add get_quota function via cc25335 vfs_shadow_copy2: add get_quota function via 22d757c vfs_cap: add get_quota function via c464b9e vfs: add path parameter to get_quota via f71761c selftest: add disk-free and quota tests based on fake_dfq VFS module via 540dcfa vfs_fake_dfq: add vfs module via 345f084 smbd: enable unit-testing of NT_TRANSACT_GET_USER_QUOTA via 17c9b8d quotas: correct comment about SMB_GROUP_QUOTA_TYPE via 798fcfd loadparm: introduce lp_parm_ulonglong() and lpcfg_parm_ulonglong() via 7a890a7 smbd:smb2_negprot: implement connection passing based on client_guid via cfbf450 smbd:smb2_server: let smbd_server_connection_terminate() only call exit_server() for the last connection via a446966 smbd:process: use smbXsrv_client_create. via 0010dc8 smbd:process: treat initialized table in smbXsrv_connection_init_tables via d77238f smbd: add smbXsrv_client.c via 8ab4629 smbd:globals.h: add guid_verified to smbXsrv_connection.smb2.client via 3590f3f idl:smbXsrv: add smbXsrv_connection_pass structures. via bae1b94 idl:smbXsrv: add smbXsrv_client_global structures via 5e91bf0 idl:messagaing: add MSG_SMBXSRV_CONNECTION_PASS from 6a24ccc s3:smbd: only process fsctl_network_iface_info if multi channel is enabled https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 07bb954d929cf2aa61afe469c14ecba449cd5d43 Author: Karolin Seeger Date: Tue Jan 26 11:17:37 2016 +0100 VERSION: Bump version up to 4.5.0pre1 Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Jan 26 19:12:42 CET 2016 on sn-devel-144 commit 6c547b337cdcfa2fc6bd631ef776e48c4077e644 Author: Karolin Seeger Date: Tue Jan 26 11:08:12 2016 +0100 VERSION: Set version to 4.4.0rc1... and disable git snapshots for 4.4.0rc1 release. Signed-off-by: Karolin Seeger commit d201a2080d73bfb73874c526134d38cebbcb572c Author: Karolin Seeger Date: Tue Jan 26 10:57:00 2016 +0100 WHATSNEW: Add smbstatus changes. Signed-off-by: Karolin Seeger commit c1bbe58cd6ea9078bc7c3608d45af640eab2292e Author: Karolin Seeger Date: Tue Jan 26 10:52:15 2016 +0100 WHATSNEW: Extend release notes for Samba 4.4.0rc1. Signed-off-by: Karolin Seeger Reviewed-by: Stefan Metzmacher commit 192f1516c378ae942d14921bfcc1e11173da36e6 Author: Andreas Schneider Date: Tue Jan 26 11:28:50 2016 +0100 waf: Only build smb_krb5_wrapper if we have CUPS Signed-off-by: Andreas Schneider Reviewed-by: Michael Adam Reviewed-by: Stefan Metzmacher commit 91eeeb76f0700041bcc7e862dfad5cc949f2c915 Author: Uri Simchoni Date: Thu Jan 21 21:09:12 2016 +0200 disk_quotas: style fix Signed-off-by: Uri Simchoni Reviewed-by: Volker Lendecke commit 6689499488b15ce996c91bc72048e92e765c5eee Author: Uri Simchoni Date: Sun Jan 10 20:28:57 2016 +0200 vfs_gpfs: make sure get_quota does not return bogus values add implementation of get_quota_fn to vfs_gpfs. The implemetation returns ENOSYS for the case of user and group quota, to make sure the default VFS does not accidentally succeed (and return wrong values which would alter the disk-free calculation) For other quota types the function calls the underlying VFS as before. Signed-off-by: Uri Simchoni Reviewed-by: Volker Lendecke commit de3c2ed0b1a6c786396435d8ea64359c9e17b1ba Author: Uri Simchoni Date: Sun Jan 10 19:54:06 2016 +0200 make disk_norm() static Now that disk_norm() is being run centrally from the SMB layer it can be made static. Signed-off-by: Uri Simchoni Reviewed-by: Volker Lendecke commit a8eea0c8b08a474f09cb39fa7aefe5687806d0d7 Author: Uri Simchoni Date: Sun Jan 10 15:39:44 2016 +0200 vfs_gpfs: do not call disk_norm() on disk_free_fn This is handled at the SMB layer now. Signed-off-by: Uri Simchoni Reviewed-by: Volker Lendecke commit 9e60cbfc7cff553c6e5ecfaa73a2e69d58c0e8
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 432ec87 Update sirius entry from bb316e6 Fix typo and make the snip shorter https://git.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 432ec87aa178dfa7488199527f02bd30d3641adc Author: Lars Müller Date: Tue Jan 26 16:42:53 2016 +0100 Update sirius entry on request by Louise Menezes --- Summary of changes: support/uk.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/support/uk.html b/support/uk.html index 930b43c..21b0238 100644 --- a/support/uk.html +++ b/support/uk.html @@ -104,8 +104,8 @@ Rivermead House, Hamm Moor Lane Weybridge, Surrey, KT15 2SF http://www.siriusopensource.com/samba-support";>http://www.siriusopensource.com/samba-support -0870 608 0063 -mailto:i...@siriusit.co.uk";>i...@siriusit.co.uk OR mailto:sa...@siriusit.co.uk";>sa...@siriusit.co.uk +0333 344 5054 +mailto:sa...@siriusopensource.com";>sa...@siriusopensource.com Kelly Flitter -- Samba Website Repository
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-26-1643/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-26-1643/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-26-1643/samba.stdout The top commit at the time of the failure was: commit 6a24cccd804eb8b89023fa0265d548fd722d909f Author: Michael Adam Date: Mon Jan 25 12:01:44 2016 +0100 s3:smbd: only process fsctl_network_iface_info if multi channel is enabled This effectively disables it for now. Ultimately, we may want to remove this restriction. Hence a separate patch. Signed-off-by: Michael Adam Reviewed-by: Stefan Metzmacher Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Jan 26 10:40:44 CET 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch v4-3-test updated
The branch, v4-3-test has been updated
via 756b452 s3-parm: clean up defaults when removing global parameters
via 54c0fce s4:torture: add SMB2 test for directory creation initial
allocation size
via 57654ee s3:smbd: Ignore initial allocation size for directory
creation
from 6d82bdd smbcacls: fix uninitialized variable
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-3-test
- Log -
commit 756b4525d7cb623eebf1d74447d946ca7781a79b
Author: Alexander Bokovoy
Date: Fri Jan 22 11:44:03 2016 +0200
s3-parm: clean up defaults when removing global parameters
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11693
When globals are re-initialized, they are cleared and globals' talloc
context is freed. However, parm_table still contains a reference to the
global value in the defaults. This confuses lpcfg_string_free() after
commit 795c543d858b2452f062a02846c2f908fe4cffe4 because it tries to
free already freed pointer which is passed by lp_save_defaults():
case P_STRING:
case P_USTRING:
lpcfg_string_set(Globals.ctx,
&parm_table[i].def.svalue,
*(char **)lp_parm_ptr(NULL,
&parm_table[i]));
here &parm_table[i].def.svalue is passed to lpcfg_string_free() but it
is a pointer to a value allocated with previous Globals.ctx which
already was freed.
This specifically affects registry backend of smb.conf in lp_load_ex()
where init_globals() called explicitly to re-init globals after
lp_save_defaults() if we have registry backend defined.
Reviewed-by: Uri Simchoni
Signed-off-by: Alexander Bokovoy
Autobuild-User(master): Uri Simchoni
Autobuild-Date(master): Mon Jan 25 23:58:42 CET 2016 on sn-devel-144
(cherry picked from commit 500bc01478881cab89f0e691427e34a405bb0003)
Autobuild-User(v4-3-test): Karolin Seeger
Autobuild-Date(v4-3-test): Tue Jan 26 12:58:53 CET 2016 on sn-devel-104
commit 54c0fce1be832427c9a7c3c0ba170a52e2356ec1
Author: Ralph Boehme
Date: Wed Jan 20 17:46:38 2016 +0100
s4:torture: add SMB2 test for directory creation initial allocation size
Test that directory creation with an initial allocation size > 0
succeeds.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11684
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
Autobuild-User(master): Ralph Böhme
Autobuild-Date(master): Sun Jan 24 01:20:52 CET 2016 on sn-devel-144
(cherry picked from commit cd86f20e245cc1b0cb3be5d6cb1b45c45e2a45a8)
commit 57654eefe041e3eeb3bdad9084aea194f2eb3777
Author: Ralph Boehme
Date: Wed Nov 25 15:23:26 2015 +0100
s3:smbd: Ignore initial allocation size for directory creation
We reject directory creation with an initial allocation size > 0 with
NT_STATUS_ACCESS_DENIED. Windows servers ignore the initial allocation
size on directories.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11684
Pair-Programmed-With: Volker Lendecke
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
(cherry picked from commit 78ccbb07170c3e49a084d31434310f973e3d6158)
---
Summary of changes:
source3/param/loadparm.c | 17
source3/smbd/open.c | 10 ++-
source4/torture/smb2/create.c | 64 +++
3 files changed, 84 insertions(+), 7 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index aee7ed7..7fd1c0d 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -403,8 +403,25 @@ static void free_parameters_by_snum(int snum)
*/
static void free_global_parameters(void)
{
+ uint32_t i;
+ struct parm_struct *parm;
+
free_param_opts(&Globals.param_opt);
free_parameters_by_snum(GLOBAL_SECTION_SNUM);
+
+ /* Reset references in the defaults because the context is going to be
freed */
+ for (i=0; parm_table[i].label; i++) {
+ parm = &parm_table[i];
+ if ((parm->type == P_STRING) ||
+ (parm->type == P_USTRING)) {
+ if ((parm->def.svalue != NULL) &&
+ (*(parm->def.svalue) != '\0')) {
+ if (talloc_parent(parm->def.svalue) ==
Globals.ctx) {
+ parm->def.svalue = NULL;
+ }
+ }
+ }
+ }
TALLOC_FREE(Globals.ctx);
}
diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 154c1a9..530c573 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -4706,15 +4706,11 @@ static NTSTATUS
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 6a24ccc s3:smbd: only process fsctl_network_iface_info if multi channel is enabled via e8a051f s3:smbd: implement fsctl_network_iface_info via 99d3dbe docs:smb.conf: document new extra syntax for interfaces. via 9fcf874 s4:lib:socket: skip extra data in interpret_interface() via 8284b34 s3:lib: extend interpret_interface() to optionally read speed, caps, and index from config via 3785be8 s3:lib: remove an unmotivated comment from interpret_interface() via e569ffd s3:lib: copy speed, cap, and index in add_interface() via 9f9d6ac smb.h: add linkspeed, capability, and if_index to interface struct via 549a9ab lib:socket: detect link speed with ethtool ioctl in get_interfaces (on linux) via 1862aa6 build: detect support for ethtool via 64be8e7 lib:socket: set defaults for linkspeed and capability in get_interfaces() via 235f37b lib:socket: get interface index from kernel via d392e0a lib:socket: add linkspeed, capability and if_index to iface_struct via bc9e1fc librpc:idl: define FSCTL_NET_IFACE_NONE_CAPABLE in ioctl.idl from a2894cf s3:lib: add braces around if-block in my_sam_name() https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 6a24cccd804eb8b89023fa0265d548fd722d909f Author: Michael Adam Date: Mon Jan 25 12:01:44 2016 +0100 s3:smbd: only process fsctl_network_iface_info if multi channel is enabled This effectively disables it for now. Ultimately, we may want to remove this restriction. Hence a separate patch. Signed-off-by: Michael Adam Reviewed-by: Stefan Metzmacher Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Jan 26 10:40:44 CET 2016 on sn-devel-144 commit e8a051f58a8f785ba8df66d263a1c632603f3650 Author: Stefan Metzmacher Date: Fri Jun 13 17:42:00 2014 +0200 s3:smbd: implement fsctl_network_iface_info The ioctl used for detecting interfaces for multi-channel. Pair-Programmed-With: Michael Adam Signed-off-by: Stefan Metzmacher Signed-off-by: Michael Adam commit 99d3dbee9952d2947e64a68380686b12c6a1e7f5 Author: Michael Adam Date: Mon Jan 25 16:35:12 2016 +0100 docs:smb.conf: document new extra syntax for interfaces. Signed-off-by: Michael Adam Reviewed-by: Stefan Metzmacher commit 9fcf87419f3f68429bb365ffb605be3eacc97e15 Author: Michael Adam Date: Mon Jan 25 16:22:57 2016 +0100 s4:lib:socket: skip extra data in interpret_interface() This is currently smbd-specific. No need to duplicate the extended parsing while these functions have not been merged yet. Signed-off-by: Michael Adam Reviewed-by: Stefan Metzmacher commit 8284b34f95639ad7c2e3a97b514529201c20e2ed Author: Michael Adam Date: Mon Jan 25 03:38:54 2016 +0100 s3:lib: extend interpret_interface() to optionally read speed, caps, and index from config New syntax for interfaces parameter: interfaces = address[;key=value[,key=value[,...]]] - keys can be 'speed', 'capability', and 'if_index'. - speed is in bits per second. - capability can be RSS and RDMA. - if_index should be used with care, because these indexes should not conicide with indexes the kernel sets... Signed-off-by: Michael Adam Reviewed-by: Stefan Metzmacher commit 3785be8d4e66f1bf01ec1b64a8e2325e4de08196 Author: Michael Adam Date: Sun Jan 24 13:26:35 2016 +0100 s3:lib: remove an unmotivated comment from interpret_interface() This seems to be a left-over from historic code. Signed-off-by: Michael Adam Reviewed-by: Stefan Metzmacher commit e569ffd83138952454ba9b9fb38ee7d852293697 Author: Michael Adam Date: Mon Jan 25 14:09:37 2016 +0100 s3:lib: copy speed, cap, and index in add_interface() Signed-off-by: Michael Adam Reviewed-by: Stefan Metzmacher commit 9f9d6ac8c1594f0c090a176d189c99fba3c31966 Author: Michael Adam Date: Mon Jan 25 03:38:16 2016 +0100 smb.h: add linkspeed, capability, and if_index to interface struct Pair-Programmed-With: Anoop C S Signed-off-by: Michael Adam Signed-off-by: Anoop C S Reviewed-by: Stefan Metzmacher commit 549a9abc7e037442dd8955b52caaaf11a1e4bc02 Author: Anoop C S Date: Fri Jan 22 20:51:55 2016 +0530 lib:socket: detect link speed with ethtool ioctl in get_interfaces (on linux) Pair-Programmed-With: Michael Adam Signed-off-by: Anoop C S Signed-off-by: Michael Adam Reviewed-by: Stefan Metzmacher commit 1862aa6c259ebe6de86b220208e315a22515b453 Author: Michael Adam Date: Mon Jan 25 03:30:39 2016 +0100 build: detect support for ethtool Pair-Programmed-With: Anoop C S Signed-off-by: Micha
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-26-1012/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-26-1012/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-01-26-1012/samba.stdout The top commit at the time of the failure was: commit a2894cf4e0c733b14e645ae492b8cd1c13878900 Author: Michael Adam Date: Thu Jan 21 12:46:40 2016 +0100 s3:lib: add braces around if-block in my_sam_name() Clean-up after moving the function. Signed-off-by: Michael Adam Reviewed-by: Andreas Schneider Autobuild-User(master): Michael Adam Autobuild-Date(master): Tue Jan 26 03:19:18 CET 2016 on sn-devel-144
