autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-11-0802/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-11-0802/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-11-0802/samba.stdout The top commit at the time of the failure was: commit 15f191a2329d08b92111f71e22f8a28c8a39c193 Author: Andrew Bartlett Date: Sat Jan 2 20:58:39 2016 +1300 ldb-samba: Add "secret" as a value to hide in LDIF files This is not secret or encrypted in LDAP, but is sensitive in secrets.ldb Signed-off-by: Andrew Bartlett Reviewed-by: Garming Sam Autobuild-User(master): Garming Sam Autobuild-Date(master): Wed May 11 07:17:38 CEST 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 15f191a ldb-samba: Add "secret" as a value to hide in LDIF files
via ac1ed18 classicupgrade: Avoid needing to quote CN values in an DN,
use dn.set_component()
via e0acee0 samr4: Remove talloc_asprintf leak onto mem_ctx
via 37ef959 samr4: Use in GetAliasMembership
from e3fdb0a ctdb-tests: rename tests from stubby.* to ctdb.*
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 15f191a2329d08b92111f71e22f8a28c8a39c193
Author: Andrew Bartlett
Date: Sat Jan 2 20:58:39 2016 +1300
ldb-samba: Add "secret" as a value to hide in LDIF files
This is not secret or encrypted in LDAP, but is sensitive in secrets.ldb
Signed-off-by: Andrew Bartlett
Reviewed-by: Garming Sam
Autobuild-User(master): Garming Sam
Autobuild-Date(master): Wed May 11 07:17:38 CEST 2016 on sn-devel-144
commit ac1ed18f8d396c431d381f511a21d6fd4f008c24
Author: Andrew Bartlett
Date: Thu Sep 24 07:41:22 2015 +1200
classicupgrade: Avoid needing to quote CN values in an DN, use
dn.set_component()
While invalid for samAccountName values, when also used for
samAccountName we should be dealing with this at the samldb layer, not
here.
This comes from unvalidated Samba3 data that can contain a , or =
without a problem in that codebase.
Signed-off-by: Andrew Bartlett
Reviewed-by: Garming Sam
commit e0acee02233d56392b99607bbd6afae6ff3da71f
Author: Garming Sam
Date: Wed May 11 13:02:03 2016 +1200
samr4: Remove talloc_asprintf leak onto mem_ctx
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11751
Signed-off-by: Garming Sam
Reviewed-by: Andrew Bartlett
commit 37ef959f37dc57302ff5824ff3223617863aad3e
Author: Mantas Mikulėnas
Date: Wed Feb 24 19:40:47 2016 +0200
samr4: Use in GetAliasMembership
As in commit 841845dea35089a187fd1626c9752d708989ac7b, this avoids
quoting problems in user DN's.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11751
Signed-off-by: Mantas Mikulėnas
Reviewed-by: Garming Sam
Reviewed-by: Andrew Bartlett
---
Summary of changes:
lib/ldb-samba/ldif_handlers.c | 2 +-
python/samba/upgrade.py | 6 --
source4/rpc_server/samr/dcesrv_samr.c | 19 ++-
3 files changed, 11 insertions(+), 16 deletions(-)
Changeset truncated at 500 lines:
diff --git a/lib/ldb-samba/ldif_handlers.c b/lib/ldb-samba/ldif_handlers.c
index d1b5bd7..87c171e 100644
--- a/lib/ldb-samba/ldif_handlers.c
+++ b/lib/ldb-samba/ldif_handlers.c
@@ -1693,7 +1693,7 @@ const struct ldb_schema_syntax
*ldb_samba_syntax_by_lDAPDisplayName(struct ldb_c
return s;
}
-static const char *secret_attributes[] = {DSDB_SECRET_ATTRIBUTES, NULL};
+static const char *secret_attributes[] = {DSDB_SECRET_ATTRIBUTES, "secret",
NULL};
/*
register the samba ldif handlers
diff --git a/python/samba/upgrade.py b/python/samba/upgrade.py
index 215ccd3..3856323 100644
--- a/python/samba/upgrade.py
+++ b/python/samba/upgrade.py
@@ -272,8 +272,10 @@ def add_group_from_mapping_entry(samdb, groupmap, logger):
return
m = ldb.Message()
-m.dn = ldb.Dn(samdb, "CN=%s,CN=Users,%s" % (groupmap.nt_name,
samdb.get_default_basedn()))
-m['cn'] = ldb.MessageElement(groupmap.nt_name, ldb.FLAG_MOD_ADD, 'cn')
+# We avoid using the format string to avoid needing to escape the CN
values
+m.dn = ldb.Dn(samdb, "CN=X,CN=Users")
+m.dn.set_component(0, "CN", groupmap.nt_name)
+m.dn.add_base(samdb.get_default_basedn())
m['objectClass'] = ldb.MessageElement('group', ldb.FLAG_MOD_ADD,
'objectClass')
m['objectSid'] = ldb.MessageElement(ndr_pack(groupmap.sid),
ldb.FLAG_MOD_ADD,
'objectSid')
diff --git a/source4/rpc_server/samr/dcesrv_samr.c
b/source4/rpc_server/samr/dcesrv_samr.c
index 423fcf0..25255d3 100644
--- a/source4/rpc_server/samr/dcesrv_samr.c
+++ b/source4/rpc_server/samr/dcesrv_samr.c
@@ -1525,11 +1525,12 @@ static NTSTATUS dcesrv_samr_GetAliasMembership(struct
dcesrv_call_state *dce_cal
{
struct dcesrv_handle *h;
struct samr_domain_state *d_state;
- const char *filter;
+ char *filter;
const char * const attrs[] = { "objectSid", NULL };
struct ldb_message **res;
uint32_t i;
int count = 0;
+ char membersidstr[DOM_SID_STR_BUFLEN];
DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
@@ -1545,19 +1546,11 @@ static NTSTATUS dcesrv_samr_GetAliasMembership(struct
dcesrv_call_state *dce_cal
}
for (i=0; iin.sids->num_sids; i++) {
- const char *memberdn;
-
- memberdn = samdb_search_string(d_state->sam_ctx, mem_ctx, NULL
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-11-0407/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-11-0407/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-11-0407/samba.stdout The top commit at the time of the failure was: commit e3fdb0a9b6a19a48c6ccd72b37485ae4a8217464 Author: Amitay Isaacs Date: Tue May 10 18:28:40 2016 +1000 ctdb-tests: rename tests from stubby.* to ctdb.* These tests do not use ctdb tool stub anymore. Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Wed May 11 02:19:20 CEST 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-11-0224/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-11-0224/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-11-0224/samba.stdout The top commit at the time of the failure was: commit 91f6439929fc88cc1cdfc9572db300ce9f4df263 Author: Douglas Bagnall Date: Wed May 4 11:24:12 2016 +1200 tests/dcerpc: add tests for string allocation and deletion Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue May 10 05:11:42 CEST 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via e3fdb0a ctdb-tests: rename tests from stubby.* to ctdb.* via 92c8bd7 ctdb-tests: Fix output for ctdb reloadnodes tests via 92d3704 ctdb-tests: Fix output for ctdb lvs test via 047886e ctdb-tests: Fix output for ctdb getcapabilities test via 90f04c7 ctdb-tests: Remove ctdb tool stub code via 1394856 ctdb-tests: Use fake_ctdbd for ctdb tool tests instead of ctdb stub via 0711904 ctdb-tests: Add fake ctdb daemon implementation for testing via 627e9a9 ctdb-tool: All errors should be logged via stderr via bbadce4 ctdb-tool: Add test-hooks to enable testing of the tool via c8ed16b ctdb-tests: Remove ctdb reloadips tests via e36a201 ctdb-tool: Remove xpnn command and related tests via e35ffb0 ctdb-protocol: Add function to compare ctdb_sock_addr via ad0286c ctdb-natgw: Allow override of CTDB for testing via 60d0725 ctdb-lvs: Allow override of CTDB for testing via 63f7466 ctdb-tests: Get rid of ctdb func tests from 91f6439 tests/dcerpc: add tests for string allocation and deletion https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit e3fdb0a9b6a19a48c6ccd72b37485ae4a8217464 Author: Amitay Isaacs Date: Tue May 10 18:28:40 2016 +1000 ctdb-tests: rename tests from stubby.* to ctdb.* These tests do not use ctdb tool stub anymore. Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Wed May 11 02:19:20 CEST 2016 on sn-devel-144 commit 92c8bd73e9b0aa53ac6f5eedd97ff4adcefe254a Author: Amitay Isaacs Date: Thu Apr 28 15:12:40 2016 +1000 ctdb-tests: Fix output for ctdb reloadnodes tests Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 92d37043756f667b6b8f09cf8a9d48081579c08c Author: Amitay Isaacs Date: Thu Apr 28 18:43:56 2016 +1000 ctdb-tests: Fix output for ctdb lvs test Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 047886e414e49287f44617136946815bb48f64f7 Author: Amitay Isaacs Date: Thu Apr 28 18:43:32 2016 +1000 ctdb-tests: Fix output for ctdb getcapabilities test Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 90f04c7fc384016a0fdf6f1c51c1b53c9361825d Author: Amitay Isaacs Date: Tue May 10 18:38:56 2016 +1000 ctdb-tests: Remove ctdb tool stub code Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 13948562c461a206e9a1613e802eeb0a87de329d Author: Amitay Isaacs Date: Wed Apr 27 01:42:33 2016 +1000 ctdb-tests: Use fake_ctdbd for ctdb tool tests instead of ctdb stub Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 07119045f0669cb4398d8cf138ac0c7980b98d42 Author: Amitay Isaacs Date: Fri Apr 22 17:30:52 2016 +1000 ctdb-tests: Add fake ctdb daemon implementation for testing Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 627e9a99f458bb01232794fcb23865a7d20b48ce Author: Amitay Isaacs Date: Fri May 6 14:06:43 2016 +1000 ctdb-tool: All errors should be logged via stderr Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit bbadce47b912c2b1530f7b7249592b813fe0e9ac Author: Amitay Isaacs Date: Thu Apr 28 13:03:35 2016 +1000 ctdb-tool: Add test-hooks to enable testing of the tool Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit c8ed16bdc9acfd3441d742a10eb98a768ffcb881 Author: Amitay Isaacs Date: Thu Apr 28 15:40:22 2016 +1000 ctdb-tests: Remove ctdb reloadips tests Since there are no public IPs setup, these tests do not really test the functionality. Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit e36a20145dab1b65825827b983fb73bd9b8cd235 Author: Amitay Isaacs Date: Thu Apr 28 13:32:31 2016 +1000 ctdb-tool: Remove xpnn command and related tests It's unreliable and should not be used. Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit e35ffb06bcc9a92cbed921a44e73ea022ce472bd Author: Amitay Isaacs Date: Wed Apr 27 18:30:12 2016 +1000 ctdb-protocol: Add function to compare ctdb_sock_addr Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit ad0286c744b2089540c883b77b8545ad3bc00b82 Author: Amitay Isaacs Date: Thu Apr 28 13:11:29 2016 +1000 ctdb-natgw: Allow override of CTDB for testing Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 60d0725f1f3305f3caa4f1ae4b749ac361d4a1f5 Author: Amitay Isaacs Date: Wed Apr 27 01:43:39 2016 +1000 ctdb-lvs: Allow override of CTDB for testing Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 63f7466490d22a8cf3946f8330b87d077
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-11-0004/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-11-0004/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-11-0004/samba.stdout The top commit at the time of the failure was: commit 91f6439929fc88cc1cdfc9572db300ce9f4df263 Author: Douglas Bagnall Date: Wed May 4 11:24:12 2016 +1200 tests/dcerpc: add tests for string allocation and deletion Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue May 10 05:11:42 CEST 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-10-2038/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-10-2038/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-10-2038/samba.stdout The top commit at the time of the failure was: commit 91f6439929fc88cc1cdfc9572db300ce9f4df263 Author: Douglas Bagnall Date: Wed May 4 11:24:12 2016 +1200 tests/dcerpc: add tests for string allocation and deletion Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue May 10 05:11:42 CEST 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-10-2002/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-10-2002/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-10-2002/samba.stdout The top commit at the time of the failure was: commit 91f6439929fc88cc1cdfc9572db300ce9f4df263 Author: Douglas Bagnall Date: Wed May 4 11:24:12 2016 +1200 tests/dcerpc: add tests for string allocation and deletion Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue May 10 05:11:42 CEST 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-10-1602/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-10-1602/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-10-1602/samba.stdout The top commit at the time of the failure was: commit 91f6439929fc88cc1cdfc9572db300ce9f4df263 Author: Douglas Bagnall Date: Wed May 4 11:24:12 2016 +1200 tests/dcerpc: add tests for string allocation and deletion Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue May 10 05:11:42 CEST 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-10-1304/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-10-1304/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-10-1304/samba.stdout The top commit at the time of the failure was: commit 91f6439929fc88cc1cdfc9572db300ce9f4df263 Author: Douglas Bagnall Date: Wed May 4 11:24:12 2016 +1200 tests/dcerpc: add tests for string allocation and deletion Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue May 10 05:11:42 CEST 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-10-1204/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-10-1204/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-10-1204/samba.stdout The top commit at the time of the failure was: commit 91f6439929fc88cc1cdfc9572db300ce9f4df263 Author: Douglas Bagnall Date: Wed May 4 11:24:12 2016 +1200 tests/dcerpc: add tests for string allocation and deletion Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue May 10 05:11:42 CEST 2016 on sn-devel-144
[SCM] pam wrapper repository - branch master updated
The branch, master has been updated
via 615fe23 pwrap: Disable audit on BSD
via f3ef1e8 modules: Add the path where we install the helper PAM
modules to the .pc file
via bc51c04 libpamtest: Only reply in conversation for echo_on and
echo_off
from 31d374c Bump version to 1.0.1
https://git.samba.org/?p=pam_wrapper.git;a=shortlog;h=master
- Log -
commit 615fe23acab323624fd732fd0272a768833e183e
Author: Andreas Schneider
Date: Mon May 9 09:51:00 2016 +0200
pwrap: Disable audit on BSD
This allows us to use pam_wrapper on BSD
Signed-off-by: Andreas Schneider
Reviewed-by: Ralph Boehme
commit f3ef1e8833fb809d3a4e8dd9051eb4ab31d76c78
Author: Jakub Hrozek
Date: Fri May 6 12:00:10 2016 +0200
modules: Add the path where we install the helper PAM modules to the .pc
file
A test needs to often know where are the helper pam modules
(pam_get_items.so and pam_set_items.so). This patch adds a new variable
to the pkg-config file that lets the user of pam_wrapper query the path
like this:
$ pkg-config --variable=modules pam_wrapper
/usr/lib64/pam_wrapper
And use that variable to define their own service files.
Signed-off-by: Jakub Hrozek
Reviewed-by: Andreas Schneider
Reviewed-by: Ralph Boehme
commit bc51c0430df83a1fdf8d468920d73a656c32b704
Author: Jakub Hrozek
Date: Thu May 5 15:53:46 2016 +0200
libpamtest: Only reply in conversation for echo_on and echo_off
Signed-off-by: Jakub Hrozek
Reviewed-by: Andreas Schneider
Reviewed-by: Ralph Boehme
---
Summary of changes:
pam_wrapper.pc.cmake | 2 ++
src/libpamtest.c | 5 -
src/pam_wrapper.c| 9 +
3 files changed, 15 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/pam_wrapper.pc.cmake b/pam_wrapper.pc.cmake
index 3c1c848..c1f407b 100644
--- a/pam_wrapper.pc.cmake
+++ b/pam_wrapper.pc.cmake
@@ -1,3 +1,5 @@
+modules=@LIB_INSTALL_DIR@/pam_wrapper
+
Name: @APPLICATION_NAME@
Description: The pam_wrapper library
Version: @APPLICATION_VERSION@
diff --git a/src/libpamtest.c b/src/libpamtest.c
index c6d5b89..7119184 100644
--- a/src/libpamtest.c
+++ b/src/libpamtest.c
@@ -294,9 +294,12 @@ static int pamtest_simple_conv(int num_msg,
}
}
- if (response) {
+ if (response && ri > 0) {
*response = reply;
+ } else {
+ free(reply);
}
+
return PAM_SUCCESS;
}
diff --git a/src/pam_wrapper.c b/src/pam_wrapper.c
index fddc7fa..bc73f41 100644
--- a/src/pam_wrapper.c
+++ b/src/pam_wrapper.c
@@ -1518,6 +1518,15 @@ int audit_open(void)
return -1;
}
+/* Disable BSD auditing */
+int cannot_audit(int x);
+int cannot_audit(int x)
+{
+ (void) x;
+
+ return 1;
+}
+
/
* DESTRUCTOR
***/
--
pam wrapper repository
