autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-19-0404/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-19-0404/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-19-0404/samba.stdout
  
The top commit at the time of the failure was:

commit 6b232b2720a3d71bc0b4b5603215b3f9d3de5ca6
Author: Michael Adam 
Date:   Sun May 15 23:24:08 2016 +0200

smbd:close: only remove kernel share modes if they had been taken at open

This avoids errors due to 'not implemented' for SMB_VFS_KERNEL_FLOCK
on some file systems like glusterfs (with the vfs module). The only
other code path where SMB_VFS_KERNEL_FLOCK is called, is already protected.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11919

Signed-off-by: Michael Adam 
Reviewed-by: Christian Ambach 

Autobuild-User(master): Christian Ambach 
Autobuild-Date(master): Thu May 19 02:34:36 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Christian Ambach]

The branch, master has been updated
   via  6b232b2 smbd:close: only remove kernel share modes if they had been 
taken at open
   via  3564873 s3:vfs: add 'kernel_share_modes_taken' to files_struct
  from  1171fe6 s3-net: Cleanup the code of printing migration

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 6b232b2720a3d71bc0b4b5603215b3f9d3de5ca6
Author: Michael Adam 
Date:   Sun May 15 23:24:08 2016 +0200

smbd:close: only remove kernel share modes if they had been taken at open

This avoids errors due to 'not implemented' for SMB_VFS_KERNEL_FLOCK
on some file systems like glusterfs (with the vfs module). The only
other code path where SMB_VFS_KERNEL_FLOCK is called, is already protected.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11919

Signed-off-by: Michael Adam 
Reviewed-by: Christian Ambach 

Autobuild-User(master): Christian Ambach 
Autobuild-Date(master): Thu May 19 02:34:36 CEST 2016 on sn-devel-144

commit 356487345724ce5dffdddf9c60735b2c965f30bc
Author: Michael Adam 
Date:   Mon May 16 01:39:09 2016 +0200

s3:vfs: add 'kernel_share_modes_taken' to files_struct

This will allow to track whether kernel share modes have been
taken at open and correclty remove them again on close.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11919

Signed-off-by: Michael Adam 
Reviewed-by: Christian Ambach 

---

Summary of changes:
 source3/include/vfs.h |  2 ++
 source3/smbd/close.c  | 17 ++---
 source3/smbd/open.c   |  2 ++
 3 files changed, 14 insertions(+), 7 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/include/vfs.h b/source3/include/vfs.h
index 9360802..a849443 100644
--- a/source3/include/vfs.h
+++ b/source3/include/vfs.h
@@ -259,6 +259,8 @@ typedef struct files_struct {
uint32_t access_mask;   /* NTCreateX access bits 
(FILE_READ_DATA etc.) */
uint32_t share_access;  /* NTCreateX share constants 
(FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE). */
 
+   bool kernel_share_modes_taken;
+
bool update_write_time_triggered;
struct tevent_timer *update_write_time_event;
bool update_write_time_on_close;
diff --git a/source3/smbd/close.c b/source3/smbd/close.c
index 0302c67..9d1f1a9 100644
--- a/source3/smbd/close.c
+++ b/source3/smbd/close.c
@@ -250,7 +250,6 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
const struct security_token *del_nt_token = NULL;
bool got_tokens = false;
bool normal_close;
-   int ret_flock;
 
/* Ensure any pending write time updates are done. */
if (fsp->update_write_time_event) {
@@ -474,12 +473,16 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
pop_sec_ctx();
}
 
-   /* remove filesystem sharemodes */
-   ret_flock = SMB_VFS_KERNEL_FLOCK(fsp, 0, 0);
-   if (ret_flock == -1) {
-   DEBUG(2, ("close_remove_share_mode: removing kernel flock for "
-   "%s failed: %s\n", fsp_str_dbg(fsp),
-   strerror(errno)));
+   if (fsp->kernel_share_modes_taken) {
+   int ret_flock;
+
+   /* remove filesystem sharemodes */
+   ret_flock = SMB_VFS_KERNEL_FLOCK(fsp, 0, 0);
+   if (ret_flock == -1) {
+   DEBUG(2, ("close_remove_share_mode: removing kernel "
+ "flock for %s failed: %s\n",
+ fsp_str_dbg(fsp), strerror(errno)));
+   }
}
 
if (!del_share_mode(lck, fsp)) {
diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index d111254..af1c1de 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -3102,6 +3102,8 @@ static NTSTATUS open_file_ntcreate(connection_struct 
*conn,
 
return NT_STATUS_SHARING_VIOLATION;
}
+
+   fsp->kernel_share_modes_taken = true;
}
 
/*


-- 
Samba Shared Repository

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-19-0004/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-19-0004/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-19-0004/samba.stdout
  
The top commit at the time of the failure was:

commit 1171fe6c7e6a43865ca9ec97e0c14d577d599a41
Author: Andreas Schneider 
Date:   Wed May 18 17:04:38 2016 +0200

s3-net: Cleanup the code of printing migration

Pair-Programmed-With: Guenther Deschner 
Signed-off-by: Andreas Schneider 
Signed-off-by: Guenther Deschner 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed May 18 23:00:35 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Andreas Schneider]

The branch, master has been updated
   via  1171fe6 s3-net: Cleanup the code of printing migration
   via  858e1ea s3-net: Convert the key_name to UTF8 during migration
  from  f15b23f packaging: Set default limit for core file size in service 
files

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 1171fe6c7e6a43865ca9ec97e0c14d577d599a41
Author: Andreas Schneider 
Date:   Wed May 18 17:04:38 2016 +0200

s3-net: Cleanup the code of printing migration

Pair-Programmed-With: Guenther Deschner 
Signed-off-by: Andreas Schneider 
Signed-off-by: Guenther Deschner 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed May 18 23:00:35 CEST 2016 on sn-devel-144

commit 858e1eaa64858790888b42d97ae4d6962a09756b
Author: Andreas Schneider 
Date:   Wed May 18 16:51:45 2016 +0200

s3-net: Convert the key_name to UTF8 during migration

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11922

Pair-Programmed-With: Guenther Deschner 
Signed-off-by: Andreas Schneider 
Signed-off-by: Guenther Deschner 

---

Summary of changes:
 source3/utils/net_printing.c | 133 ++-
 1 file changed, 120 insertions(+), 13 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/net_printing.c b/source3/utils/net_printing.c
index 6f805eb..8287e0e 100644
--- a/source3/utils/net_printing.c
+++ b/source3/utils/net_printing.c
@@ -33,9 +33,13 @@
 #include "printing/nt_printing_migrate.h"
 
 #define FORMS_PREFIX "FORMS/"
+#define FORMS_PREFIX_LEN 6
 #define DRIVERS_PREFIX "DRIVERS/"
+#define DRIVERS_PREFIX_LEN 8
 #define PRINTERS_PREFIX "PRINTERS/"
+#define PRINTERS_PREFIX_LEN 9
 #define SECDESC_PREFIX "SECDESC/"
+#define SECDESC_PREFIX_LEN 8
 
 #define ARG_ENCODING "encoding="
 
@@ -258,38 +262,91 @@ static int net_printing_dump(struct net_context *c, int 
argc,
 kbuf.dptr;
 newkey = tdb_nextkey(tdb, kbuf), free(kbuf.dptr), kbuf=newkey)
{
+   int cmp;
+
dbuf = tdb_fetch(tdb, kbuf);
if (!dbuf.dptr) {
continue;
}
 
-   if (strncmp((const char *)kbuf.dptr, FORMS_PREFIX, 
strlen(FORMS_PREFIX)) == 0) {
-   dump_form(ctx, (const char 
*)kbuf.dptr+strlen(FORMS_PREFIX), dbuf.dptr, dbuf.dsize);
+   cmp = strncmp((const char *)kbuf.dptr,
+ FORMS_PREFIX,
+ FORMS_PREFIX_LEN);
+   if (cmp == 0) {
+   char *key_name = NULL;
+   size_t converted_size = 0;
+   bool ok;
+
+   ok = pull_ascii_talloc(ctx,
+  _name,
+  (const char *) kbuf.dptr + 
strlen(FORMS_PREFIX),
+  _size);
+   if (!ok) {
+   continue;
+   }
+
+   dump_form(ctx, key_name, dbuf.dptr, dbuf.dsize);
+   TALLOC_FREE(key_name);
SAFE_FREE(dbuf.dptr);
continue;
}
 
-   if (strncmp((const char *)kbuf.dptr, DRIVERS_PREFIX, 
strlen(DRIVERS_PREFIX)) == 0) {
+   cmp = strncmp((const char *)kbuf.dptr,
+ DRIVERS_PREFIX,
+ DRIVERS_PREFIX_LEN);
+   if (cmp == 0) {
+   char *key_name = NULL;
+   size_t converted_size = 0;
+   bool ok;
+
+   ok = pull_ascii_talloc(ctx,
+  _name,
+  (const char *) kbuf.dptr + 
strlen(DRIVERS_PREFIX),
+  _size);
+   if (!ok) {
+   continue;
+   }
+
dump_driver(ctx,
-   (const char 
*)kbuf.dptr+strlen(DRIVERS_PREFIX),
+   key_name,
dbuf.dptr,
dbuf.dsize,
do_string_conversion);
+   TALLOC_FREE(key_name);
SAFE_FREE(dbuf.dptr);
continue;
}
 
-   if (strncmp((const char *)kbuf.dptr, PRINTERS_PREFIX, 
strlen(PRINTERS_PREFIX)) == 0) {
+   cmp = strncmp((const char *)kbuf.dptr,
+ 

autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-18-2036/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-18-2036/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-05-18-2036/samba.stdout
  
The top commit at the time of the failure was:

commit f15b23f8358d7b2f60b1df0f81bb93a2c8789af4
Author: Anoop C S 
Date:   Tue May 10 15:08:07 2016 +0530

packaging: Set default limit for core file size in service files

This change adds the missing LimitCORE variable setting in nmb and
winbind service files to have no limit for coredumps by default.

Signed-off-by: Anoop C S 
Reviewed-by: Jose A. Rivera 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed May 18 19:26:49 CEST 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-18-2004/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-18-2004/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-18-2004/samba.stdout
  
The top commit at the time of the failure was:

commit f15b23f8358d7b2f60b1df0f81bb93a2c8789af4
Author: Anoop C S 
Date:   Tue May 10 15:08:07 2016 +0530

packaging: Set default limit for core file size in service files

This change adds the missing LimitCORE variable setting in nmb and
winbind service files to have no limit for coredumps by default.

Signed-off-by: Anoop C S 
Reviewed-by: Jose A. Rivera 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed May 18 19:26:49 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Günther Deschner]

The branch, master has been updated
   via  f15b23f packaging: Set default limit for core file size in service 
files
   via  ba9ccc6 packaging: Set default limit for core file size in init 
scripts
   via  46524b4 packaging: Remove ulimit usage for setting core file size 
limit
  from  aa57604 s3:smbd: fix anonymous authentication if signing is 
mandatory

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit f15b23f8358d7b2f60b1df0f81bb93a2c8789af4
Author: Anoop C S 
Date:   Tue May 10 15:08:07 2016 +0530

packaging: Set default limit for core file size in service files

This change adds the missing LimitCORE variable setting in nmb and
winbind service files to have no limit for coredumps by default.

Signed-off-by: Anoop C S 
Reviewed-by: Jose A. Rivera 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed May 18 19:26:49 CEST 2016 on sn-devel-144

commit ba9ccc6be48e8541748afbf31d5e5dba7d1baf8e
Author: Anoop C S 
Date:   Tue May 10 21:07:01 2016 +0530

packaging: Set default limit for core file size in init scripts

SysV init scripts used for initiating smb and winbind services
determines the value for default limit of coredump from variable
named DAEMON_COREFILE_LIMIT within a bash env. Therefore this
patch explicitly sets this variable to 'unlimited' so as to have
no limit for core file size by default.

Signed-off-by: Anoop C S 
Reviewed-by: Jose A. Rivera 
Reviewed-by: Guenther Deschner 

commit 46524b4543acc9d104d85136c0a4a9e006fc099c
Author: Anoop C S 
Date:   Tue May 10 14:50:14 2016 +0530

packaging: Remove ulimit usage for setting core file size limit

Recent commit ebd139c4db7e51a2d7843a773991f15cadf504dd modified smb.init
to set core file size to 'unlimited' by default using the ulimit command.
But when smb and winbind services are initiated via sysv init scripts,
another variable named DAEMON_COREFILE_LIMIT takes higher priority in
deciding the core file size. Therefore setting default value using ulimit
command is useless.

Signed-off-by: Anoop C S 
Reviewed-by: Jose A. Rivera 
Reviewed-by: Guenther Deschner 

---

Summary of changes:
 packaging/RHEL-CTDB/setup/smb.init | 3 ++-
 packaging/RHEL-CTDB/setup/winbind.init | 2 ++
 packaging/RHEL/setup/smb.init  | 3 ++-
 packaging/RHEL/setup/winbind.init  | 2 ++
 packaging/systemd/nmb.service  | 1 +
 packaging/systemd/winbind.service  | 1 +
 6 files changed, 10 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/packaging/RHEL-CTDB/setup/smb.init 
b/packaging/RHEL-CTDB/setup/smb.init
index 00984d2..39bf0a8 100644
--- a/packaging/RHEL-CTDB/setup/smb.init
+++ b/packaging/RHEL-CTDB/setup/smb.init
@@ -18,6 +18,8 @@ else
   exit 0
 fi
 
+DAEMON_COREFILE_LIMIT='unlimited'
+
 # Avoid using root's TMPDIR
 unset TMPDIR
 
@@ -51,7 +53,6 @@ RETVAL=0
 start() {
KIND="SMB"
echo -n $"Starting $KIND services: "
-   ulimit -c unlimited
daemon smbd $SMBDOPTIONS
RETVAL=$?
echo
diff --git a/packaging/RHEL-CTDB/setup/winbind.init 
b/packaging/RHEL-CTDB/setup/winbind.init
index a99038f..2a9dd82 100644
--- a/packaging/RHEL-CTDB/setup/winbind.init
+++ b/packaging/RHEL-CTDB/setup/winbind.init
@@ -16,6 +16,8 @@ else
   exit 0
 fi
 
+DAEMON_COREFILE_LIMIT='unlimited'
+
 # Avoid using root's TMPDIR
 unset TMPDIR
 
diff --git a/packaging/RHEL/setup/smb.init b/packaging/RHEL/setup/smb.init
index dff9cd8..96fb74a 100644
--- a/packaging/RHEL/setup/smb.init
+++ b/packaging/RHEL/setup/smb.init
@@ -18,6 +18,8 @@ else
   exit 0
 fi
 
+DAEMON_COREFILE_LIMIT='unlimited'
+
 # Avoid using root's TMPDIR
 unset TMPDIR
 
@@ -50,7 +52,6 @@ RETVAL=0
 start() {
KIND="SMB"
echo -n $"Starting $KIND services: "
-   ulimit -c unlimited
daemon smbd $SMBDOPTIONS
RETVAL=$?
echo
diff --git a/packaging/RHEL/setup/winbind.init 
b/packaging/RHEL/setup/winbind.init
index a99038f..2a9dd82 100644
--- a/packaging/RHEL/setup/winbind.init
+++ b/packaging/RHEL/setup/winbind.init
@@ -16,6 +16,8 @@ else
   exit 0
 fi
 
+DAEMON_COREFILE_LIMIT='unlimited'
+
 # Avoid using root's TMPDIR
 unset TMPDIR
 
diff --git a/packaging/systemd/nmb.service b/packaging/systemd/nmb.service
index 3d71a7d..992c0cd 100644
--- a/packaging/systemd/nmb.service
+++ b/packaging/systemd/nmb.service
@@ -9,6 +9,7 @@ PIDFile=/run/nmbd.pid
 EnvironmentFile=-/etc/sysconfig/samba
 ExecStart=/usr/sbin/nmbd $NMBDOPTIONS
 

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-18-1604/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-18-1604/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-18-1604/samba.stdout
  
The top commit at the time of the failure was:

commit aa5760433b219de7b41d35ca7ad6d4d702b89adf
Author: Stefan Metzmacher 
Date:   Wed May 18 09:56:02 2016 +0200

s3:smbd: fix anonymous authentication if signing is mandatory

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11910

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Wed May 18 15:49:46 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Stefan Metzmacher]

The branch, master has been updated
   via  aa57604 s3:smbd: fix anonymous authentication if signing is 
mandatory
   via  825cce1 s3:ntlm_auth: make ntlm_auth_generate_session_info() more 
complete
  from  84aea20 ctdb: Fix CID 1327222 Copy into fixed size buffer

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit aa5760433b219de7b41d35ca7ad6d4d702b89adf
Author: Stefan Metzmacher 
Date:   Wed May 18 09:56:02 2016 +0200

s3:smbd: fix anonymous authentication if signing is mandatory

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11910

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Wed May 18 15:49:46 CEST 2016 on sn-devel-144

commit 825cce1f88b797c80116769e1755328dee2ba0e1
Author: Stefan Metzmacher 
Date:   Wed May 11 17:59:32 2016 +0200

s3:ntlm_auth: make ntlm_auth_generate_session_info() more complete

The generate_session_info() function maybe called more than once
per session.

Some may try to look/dereference session_info->security_token,
so we provide simplified token.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11914

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andreas Schneider 
Reviewed-by: Günther Deschner 

---

Summary of changes:
 source3/smbd/sesssetup.c  |  8 ++--
 source3/utils/ntlm_auth.c | 51 ++-
 2 files changed, 52 insertions(+), 7 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/sesssetup.c b/source3/smbd/sesssetup.c
index 62dc49e..c058eac 100644
--- a/source3/smbd/sesssetup.c
+++ b/source3/smbd/sesssetup.c
@@ -130,6 +130,7 @@ static void reply_sesssetup_and_X_spnego(struct smb_request 
*req)
struct smbXsrv_connection *xconn = req->xconn;
struct smbd_server_connection *sconn = req->sconn;
uint16_t action = 0;
+   bool is_authenticated = false;
NTTIME now = timeval_to_nttime(>request_time);
struct smbXsrv_session *session = NULL;
uint16_t smb_bufsize = SVAL(req->vwv+2, 0);
@@ -336,12 +337,13 @@ static void reply_sesssetup_and_X_spnego(struct 
smb_request *req)
sconn->num_users++;
 
if (security_session_user_level(session_info, NULL) >= 
SECURITY_USER) {
+   is_authenticated = true;
session->compat->homes_snum =

register_homes_share(session_info->unix_info->unix_name);
}
 
if (srv_is_signing_negotiated(xconn) &&
-   action == 0 &&
+   is_authenticated &&
session->global->signing_key.length > 0)
{
/*
@@ -601,6 +603,7 @@ void reply_sesssetup_and_X(struct smb_request *req)
struct auth_session_info *session_info = NULL;
uint16_t smb_flag2 = req->flags2;
uint16_t action = 0;
+   bool is_authenticated = false;
NTTIME now = timeval_to_nttime(>request_time);
struct smbXsrv_session *session = NULL;
NTSTATUS nt_status;
@@ -1038,12 +1041,13 @@ void reply_sesssetup_and_X(struct smb_request *req)
sconn->num_users++;
 
if (security_session_user_level(session_info, NULL) >= SECURITY_USER) {
+   is_authenticated = true;
session->compat->homes_snum =

register_homes_share(session_info->unix_info->unix_name);
}
 
if (srv_is_signing_negotiated(xconn) &&
-   action == 0 &&
+   is_authenticated &&
session->global->signing_key.length > 0)
{
/*
diff --git a/source3/utils/ntlm_auth.c b/source3/utils/ntlm_auth.c
index e19bc7e..ed6b2f4 100644
--- a/source3/utils/ntlm_auth.c
+++ b/source3/utils/ntlm_auth.c
@@ -27,6 +27,7 @@
 #include "includes.h"
 #include "lib/param/param.h"
 #include "popt_common.h"
+#include "libcli/security/security.h"
 #include "utils/ntlm_auth.h"
 #include "../libcli/auth/libcli_auth.h"
 #include "auth/ntlmssp/ntlmssp.h"
@@ -716,18 +717,58 @@ static NTSTATUS ntlm_auth_generate_session_info(struct 
auth4_context *auth_conte
uint32_t session_info_flags,
struct auth_session_info 
**session_info_out)
 {
-   char *unix_username = (char *)server_returned_info;
-   struct auth_session_info *session_info = talloc_zero(mem_ctx, struct 
auth_session_info);
-   if (!session_info) {
+   const char *unix_username = (const char *)server_returned_info;
+   bool ok;
+   

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-18-0803/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-18-0803/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-05-18-0803/samba.stdout
  
The top commit at the time of the failure was:

commit 84aea20f37f7a59c13eb0dcb63e26a389fcc47ee
Author: Volker Lendecke 
Date:   Tue May 17 11:39:38 2016 +0200

ctdb: Fix CID 1327222 Copy into fixed size buffer

Signed-off-by: Volker Lendecke 
Reviewed-by: Uri Simchoni 

Autobuild-User(master): Uri Simchoni 
Autobuild-Date(master): Tue May 17 21:21:30 CEST 2016 on sn-devel-144