[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 721b21b selftest: add test for DNS updates with TKEY/TSIG via 88700e7 s4/dns_server: enable sending of TSIG error records via ba683d4 s4/dns_server: prepare sending correct error responses for dns_verify_tsig() errors via 8f46bf2 s4/dns_server: don't compute TSIG MAC in TSIG error records via 8b4a2dc s4/dns_server: error codes for failing MAC verification in TSIG requests via 77c5bfd s4/dns_server: ensure we store the key name in error code paths via c1fca8f s4/dns_server: not finding the key here is a fatal error via 830316c s4/dns_server: split out function that does the MAC computation via 8ed125e s4/dns_server: include request MAC in TSIG response MAC calculation via bea4aec librpc/dns: remove original_id from dns_fake_tsig_rec via a51f998 librpc/dns: don't compress strings in TKEY and TSIG responses via df07996 librpc/ndr: add flag LIBNDR_FLAG_NO_COMPRESSION from 234a470 s3:libnet: accept empty realm for AD domains when only security=domain is set. https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 721b21bb801735fe9179502ff34e7a707176dbd8 Author: Ralph BoehmeDate: Wed May 4 14:26:16 2016 +0200 selftest: add test for DNS updates with TKEY/TSIG Bug: https://bugzilla.samba.org/show_bug.cgi?id=11520 Signed-off-by: Ralph Boehme Reviewed-by: Garming Sam Autobuild-User(master): Garming Sam Autobuild-Date(master): Thu Jun 16 04:07:41 CEST 2016 on sn-devel-144 commit 88700e7d890c017e2d360fe4385e196f4016db4a Author: Ralph Boehme Date: Mon May 30 16:44:00 2016 +0200 s4/dns_server: enable sending of TSIG error records This final patch enables sending TSIG error records by adding DNS_RCODE_NOTAUTH to the set of error conditions that are allowed to trigger sending a full generated response. See RFC 2845 "4.5.1. KEY check and error handling" and "4.5.3. MAC check and error handling". Bug: https://bugzilla.samba.org/show_bug.cgi?id=11520 Signed-off-by: Ralph Boehme Reviewed-by: Garming Sam commit ba683d459e1b1550d0a4de3a0f576c857ee595c8 Author: Ralph Boehme Date: Mon May 30 16:42:14 2016 +0200 s4/dns_server: prepare sending correct error responses for dns_verify_tsig() errors Call dns_verify_tsig() after updating state.flags and assign and use out_packet for dns_verify_tsig(). We will need the updated flags when sending TSIG error responses when TSIG request MAC verification fails and dns_verify_tsig() uses the passed in packet as response, so we have to make sure we copy in_packet to out_packet before calling out and pass out_packet. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11520 Signed-off-by: Ralph Boehme Reviewed-by: Garming Sam commit 8f46bf2102a91c5f2d5beee530ece0387fdfbb0c Author: Ralph Boehme Date: Mon May 30 17:25:56 2016 +0200 s4/dns_server: don't compute TSIG MAC in TSIG error records See RFC 2845 "4.3. TSIG on TSIG Error returns". Bug: https://bugzilla.samba.org/show_bug.cgi?id=11520 Signed-off-by: Ralph Boehme Reviewed-by: Garming Sam commit 8b4a2dcf38e9f38bb99bd1daa5e0d5da176a1e15 Author: Ralph Boehme Date: Mon May 30 16:40:45 2016 +0200 s4/dns_server: error codes for failing MAC verification in TSIG requests According to RFC 2845 "4.5.3. MAC check and error handling" we must return NOTAUTH and DNS_RCODE_BADSIG when MAC verification fails. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11520 Signed-off-by: Ralph Boehme Reviewed-by: Garming Sam commit 77c5bfdce417a36b523e9901668fbff0d42f1ed2 Author: Ralph Boehme Date: Mon May 30 16:37:32 2016 +0200 s4/dns_server: ensure we store the key name in error code paths We need the TKEY name when adding TSIG records to error responses. Bug: https://bugzilla.samba.org/show_bug.cgi?id=11520 Signed-off-by: Ralph Boehme Reviewed-by: Garming Sam commit c1fca8fa398461fb0a67dbb0e181c71b83a32b62 Author: Ralph Boehme Date: Mon May 30 16:56:21 2016 +0200 s4/dns_server: not finding the key here is a fatal error Bug: https://bugzilla.samba.org/show_bug.cgi?id=11520 Signed-off-by: Ralph Boehme Reviewed-by: Garming Sam commit 830316ce84c6f4994841a1c68e60d90225a2963d Author: Ralph Boehme
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-16-0404/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-16-0404/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-16-0404/samba.stdout The top commit at the time of the failure was: commit 234a470f198f8f09f46aaeaf58f966faccedef18 Author: Günther DeschnerDate: Tue May 31 18:47:34 2016 +0200 s3:libnet: accept empty realm for AD domains when only security=domain is set. Initial patch from Matt Rogers @ RedHat. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11977 Guenther Pair-Programmed-With: Andreas Schneider Signed-off-by: Guenther Deschner Signed-off-by: Andreas Schneider Autobuild-User(master): Günther Deschner Autobuild-Date(master): Wed Jun 15 20:28:31 CEST 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-06-16-0400/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-06-16-0400/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-06-16-0400/samba.stdout The top commit at the time of the failure was: commit 234a470f198f8f09f46aaeaf58f966faccedef18 Author: Günther DeschnerDate: Tue May 31 18:47:34 2016 +0200 s3:libnet: accept empty realm for AD domains when only security=domain is set. Initial patch from Matt Rogers @ RedHat. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11977 Guenther Pair-Programmed-With: Andreas Schneider Signed-off-by: Guenther Deschner Signed-off-by: Andreas Schneider Autobuild-User(master): Günther Deschner Autobuild-Date(master): Wed Jun 15 20:28:31 CEST 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-16-0004/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-16-0004/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-16-0004/samba.stdout The top commit at the time of the failure was: commit 234a470f198f8f09f46aaeaf58f966faccedef18 Author: Günther DeschnerDate: Tue May 31 18:47:34 2016 +0200 s3:libnet: accept empty realm for AD domains when only security=domain is set. Initial patch from Matt Rogers @ RedHat. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11977 Guenther Pair-Programmed-With: Andreas Schneider Signed-off-by: Guenther Deschner Signed-off-by: Andreas Schneider Autobuild-User(master): Günther Deschner Autobuild-Date(master): Wed Jun 15 20:28:31 CEST 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 234a470 s3:libnet: accept empty realm for AD domains when only security=domain is set. via 632faa8 s3-libnet: Print error string even on successfuly completion of libnetjoin. via 169e8ae s3-libnetapi: Correctly check for lp_realm. from 4c408f6 libnet_join: use sitename if it was set by pre-join detection https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 234a470f198f8f09f46aaeaf58f966faccedef18 Author: Günther DeschnerDate: Tue May 31 18:47:34 2016 +0200 s3:libnet: accept empty realm for AD domains when only security=domain is set. Initial patch from Matt Rogers @ RedHat. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11977 Guenther Pair-Programmed-With: Andreas Schneider Signed-off-by: Guenther Deschner Signed-off-by: Andreas Schneider Autobuild-User(master): Günther Deschner Autobuild-Date(master): Wed Jun 15 20:28:31 CEST 2016 on sn-devel-144 commit 632faa87610b3afca3f8d3e9f3f46ee6b87f362a Author: Günther Deschner Date: Wed Jun 15 16:04:29 2016 +0200 s3-libnet: Print error string even on successfuly completion of libnetjoin. Sometimes useful information should be printed to the users. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11977 Guenther Signed-off-by: Guenther Deschner commit 169e8aeda5e9d851ec818b5c2543ec59c8bc0c31 Author: Andreas Schneider Date: Wed Jun 15 16:05:58 2016 +0200 s3-libnetapi: Correctly check for lp_realm. Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner --- Summary of changes: source3/lib/netapi/joindomain.c | 11 +++ source3/libnet/libnet_join.c| 17 + source3/utils/net_ads.c | 5 + source3/utils/net_rpc.c | 10 ++ 4 files changed, 39 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/lib/netapi/joindomain.c b/source3/lib/netapi/joindomain.c index 632c8c6..dc224b6 100644 --- a/source3/lib/netapi/joindomain.c +++ b/source3/lib/netapi/joindomain.c @@ -175,6 +175,7 @@ WERROR NetUnjoinDomain_l(struct libnetapi_ctx *mem_ctx, const char *domain = NULL; WERROR werr; struct libnetapi_private_ctx *priv; + const char *realm = lp_realm(); priv = talloc_get_type_abort(mem_ctx->private_data, struct libnetapi_private_ctx); @@ -186,8 +187,8 @@ WERROR NetUnjoinDomain_l(struct libnetapi_ctx *mem_ctx, werr = libnet_init_UnjoinCtx(mem_ctx, ); W_ERROR_NOT_OK_RETURN(werr); - if (lp_realm()) { - domain = lp_realm(); + if (realm[0] != '\0') { + domain = realm; } else { domain = lp_workgroup(); } @@ -352,8 +353,10 @@ WERROR NetGetJoinInformation_r(struct libnetapi_ctx *ctx, WERROR NetGetJoinInformation_l(struct libnetapi_ctx *ctx, struct NetGetJoinInformation *r) { - if ((lp_security() == SEC_ADS) && lp_realm()) { - *r->out.name_buffer = talloc_strdup(ctx, lp_realm()); + const char *realm = lp_realm(); + + if ((lp_security() == SEC_ADS) && realm[0] != '\0') { + *r->out.name_buffer = talloc_strdup(ctx, realm); } else { *r->out.name_buffer = talloc_strdup(ctx, lp_workgroup()); } diff --git a/source3/libnet/libnet_join.c b/source3/libnet/libnet_join.c index c007183..abb9cff 100644 --- a/source3/libnet/libnet_join.c +++ b/source3/libnet/libnet_join.c @@ -2367,9 +2367,26 @@ static WERROR libnet_join_check_config(TALLOC_CTX *mem_ctx, W_ERROR_HAVE_NO_MEMORY(wrong_conf); } + /* +* We should generate the warning for the special case when +* domain is AD, "security = domain" and the realm parameter is +* not set. +*/ + if (lp_security() == SEC_DOMAIN && + r->out.domain_is_ad && + !valid_realm) { + libnet_join_set_error_string(mem_ctx, r, + "Warning: when joining AD domains with security=domain, " + "\"realm\" should be defined in the configuration (%s) " + "and configuration modification was not requested", + wrong_conf); + return WERR_OK; + } + libnet_join_set_error_string(mem_ctx, r, "Invalid configuration (%s) and configuration
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-2003/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-2003/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-2003/samba.stdout The top commit at the time of the failure was: commit 4c408f6de5c32a41fbb44971419118e5425d13e7 Author: Alexander BokovoyDate: Tue Jun 14 22:37:31 2016 +0300 libnet_join: use sitename if it was set by pre-join detection When domain member is joined to AD, we need to use the same DC to authenticate against after the join because the machine account might not be replicated yet to other domain controllers, including off-site. Bug https://bugzilla.samba.org/show_bug.cgi?id=11769 dealt with detection of the site pre-join. However, we rewrite private local krb5.conf afterwards without taking the discovered site name into account. Fix this by reusing the site discovered pre-join. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11975 Signed-off-by: Alexander Bokovoy Reviewed-by: Jeremy Allison Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Wed Jun 15 15:25:44 CEST 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-1604/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-1604/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-1604/samba.stdout The top commit at the time of the failure was: commit 4c408f6de5c32a41fbb44971419118e5425d13e7 Author: Alexander BokovoyDate: Tue Jun 14 22:37:31 2016 +0300 libnet_join: use sitename if it was set by pre-join detection When domain member is joined to AD, we need to use the same DC to authenticate against after the join because the machine account might not be replicated yet to other domain controllers, including off-site. Bug https://bugzilla.samba.org/show_bug.cgi?id=11769 dealt with detection of the site pre-join. However, we rewrite private local krb5.conf afterwards without taking the discovered site name into account. Fix this by reusing the site discovered pre-join. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11975 Signed-off-by: Alexander Bokovoy Reviewed-by: Jeremy Allison Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Wed Jun 15 15:25:44 CEST 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-06-15-1600/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-06-15-1600/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-06-15-1600/samba.stdout The top commit at the time of the failure was: commit 4c408f6de5c32a41fbb44971419118e5425d13e7 Author: Alexander BokovoyDate: Tue Jun 14 22:37:31 2016 +0300 libnet_join: use sitename if it was set by pre-join detection When domain member is joined to AD, we need to use the same DC to authenticate against after the join because the machine account might not be replicated yet to other domain controllers, including off-site. Bug https://bugzilla.samba.org/show_bug.cgi?id=11769 dealt with detection of the site pre-join. However, we rewrite private local krb5.conf afterwards without taking the discovered site name into account. Fix this by reusing the site discovered pre-join. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11975 Signed-off-by: Alexander Bokovoy Reviewed-by: Jeremy Allison Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Wed Jun 15 15:25:44 CEST 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 4c408f6 libnet_join: use sitename if it was set by pre-join detection from 46916b2 lib: Add a little closefrom() test https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 4c408f6de5c32a41fbb44971419118e5425d13e7 Author: Alexander BokovoyDate: Tue Jun 14 22:37:31 2016 +0300 libnet_join: use sitename if it was set by pre-join detection When domain member is joined to AD, we need to use the same DC to authenticate against after the join because the machine account might not be replicated yet to other domain controllers, including off-site. Bug https://bugzilla.samba.org/show_bug.cgi?id=11769 dealt with detection of the site pre-join. However, we rewrite private local krb5.conf afterwards without taking the discovered site name into account. Fix this by reusing the site discovered pre-join. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11975 Signed-off-by: Alexander Bokovoy Reviewed-by: Jeremy Allison Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Wed Jun 15 15:25:44 CEST 2016 on sn-devel-144 --- Summary of changes: source3/libnet/libnet_join.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changeset truncated at 500 lines: diff --git a/source3/libnet/libnet_join.c b/source3/libnet/libnet_join.c index a28864d..c007183 100644 --- a/source3/libnet/libnet_join.c +++ b/source3/libnet/libnet_join.c @@ -2500,7 +2500,7 @@ static WERROR libnet_DomainJoin(TALLOC_CTX *mem_ctx, create_local_private_krb5_conf_for_domain( r->out.dns_domain_name, r->out.netbios_domain_name, - NULL, smbXcli_conn_remote_sockaddr(cli->conn)); + sitename, smbXcli_conn_remote_sockaddr(cli->conn)); if (r->out.domain_is_ad && !(r->in.join_flags & WKSSVC_JOIN_FLAGS_JOIN_UNSECURE)) { -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-4-test updated
The branch, v4-4-test has been updated via 53ac611 s3: krb5: keytab - The done label can be jumped to with context == NULL. via 83fa480 lib: Fix uninitialized read in msghdr_copy from 8acad0e ctdb-recoverd: Avoid duplicate recoverd event in parallel recovery https://git.samba.org/?p=samba.git;a=shortlog;h=v4-4-test - Log - commit 53ac611919653dc72486d6efe96716c2e2f7f053 Author: Jeremy AllisonDate: Wed Jun 8 14:50:59 2016 -0700 s3: krb5: keytab - The done label can be jumped to with context == NULL. Ensure we don't crash in this case. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11959 Signed-off-by: Jeremy Allison Reviewed-by: Uri Simchoni Autobuild-User(master): Uri Simchoni Autobuild-Date(master): Thu Jun 9 13:18:56 CEST 2016 on sn-devel-144 (cherry picked from commit e46cb9b835eb8f2bd998def82baf6f07fda9fe5c) Autobuild-User(v4-4-test): Karolin Seeger Autobuild-Date(v4-4-test): Wed Jun 15 15:21:29 CEST 2016 on sn-devel-144 commit 83fa4802bb15a34f2fbb11942cf331d214fe62a1 Author: Jeremy Allison Date: Wed Jun 8 14:34:20 2016 +0200 lib: Fix uninitialized read in msghdr_copy Signed-off-by: Jeremy Allison Reviewed-by: Volker Lendecke BUG: https://bugzilla.samba.org/show_bug.cgi?id=11955 Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Wed Jun 8 18:34:27 CEST 2016 on sn-devel-144 (cherry picked from commit 0e2711b2a0adeda6873f9c8161b9b01a56ae7098) --- Summary of changes: source3/lib/msghdr.c | 9 - source3/libads/kerberos_keytab.c | 18 -- 2 files changed, 16 insertions(+), 11 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/lib/msghdr.c b/source3/lib/msghdr.c index 2aa2f2e..6917069 100644 --- a/source3/lib/msghdr.c +++ b/source3/lib/msghdr.c @@ -204,7 +204,14 @@ ssize_t msghdr_copy(struct msghdr_buf *msg, size_t msgsize, bufsize = (msgsize > offsetof(struct msghdr_buf, buf)) ? msgsize - offsetof(struct msghdr_buf, buf) : 0; - fd_len = msghdr_prep_fds(>msg, msg->buf, bufsize, fds, num_fds); + if (msg != NULL) { + msg->msg = (struct msghdr) {}; + + fd_len = msghdr_prep_fds(>msg, msg->buf, bufsize, +fds, num_fds); + } else { + fd_len = msghdr_prep_fds(NULL, NULL, bufsize, fds, num_fds); + } if (fd_len == -1) { return -1; diff --git a/source3/libads/kerberos_keytab.c b/source3/libads/kerberos_keytab.c index 309e614..b47dde6 100644 --- a/source3/libads/kerberos_keytab.c +++ b/source3/libads/kerberos_keytab.c @@ -744,26 +744,24 @@ done: TALLOC_FREE(oldEntries); TALLOC_FREE(frame); - { + if (context) { krb5_keytab_entry zero_kt_entry; + krb5_kt_cursor zero_csr; + ZERO_STRUCT(zero_kt_entry); + ZERO_STRUCT(zero_csr); + if (memcmp(_kt_entry, _entry, sizeof(krb5_keytab_entry))) { smb_krb5_kt_free_entry(context, _entry); } - } - { - krb5_kt_cursor zero_csr; - ZERO_STRUCT(zero_csr); if ((memcmp(, _csr, sizeof(krb5_kt_cursor)) != 0) && keytab) { krb5_kt_end_seq_get(context, keytab, ); } - } - if (keytab) { - krb5_kt_close(context, keytab); - } - if (context) { + if (keytab) { + krb5_kt_close(context, keytab); + } krb5_free_context(context); } return ret; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-3-test updated
The branch, v4-3-test has been updated via 2b18b8b s3: krb5: keytab - The done label can be jumped to with context == NULL. via fd1bccc lib: Fix uninitialized read in msghdr_copy from 55785c9 VERSION: Bump version up to 4.3.11... https://git.samba.org/?p=samba.git;a=shortlog;h=v4-3-test - Log - commit 2b18b8b246dac53ce1946f544043e210e389f60d Author: Jeremy AllisonDate: Wed Jun 8 14:50:59 2016 -0700 s3: krb5: keytab - The done label can be jumped to with context == NULL. Ensure we don't crash in this case. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11959 Signed-off-by: Jeremy Allison Reviewed-by: Uri Simchoni Autobuild-User(master): Uri Simchoni Autobuild-Date(master): Thu Jun 9 13:18:56 CEST 2016 on sn-devel-144 (cherry picked from commit e46cb9b835eb8f2bd998def82baf6f07fda9fe5c) Autobuild-User(v4-3-test): Karolin Seeger Autobuild-Date(v4-3-test): Wed Jun 15 15:05:50 CEST 2016 on sn-devel-104 commit fd1bccc9450081d6d121decb965668b848b08342 Author: Jeremy Allison Date: Wed Jun 8 14:34:20 2016 +0200 lib: Fix uninitialized read in msghdr_copy Signed-off-by: Jeremy Allison Reviewed-by: Volker Lendecke BUG: https://bugzilla.samba.org/show_bug.cgi?id=11955 Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Wed Jun 8 18:34:27 CEST 2016 on sn-devel-144 (cherry picked from commit 0e2711b2a0adeda6873f9c8161b9b01a56ae7098) --- Summary of changes: source3/lib/msghdr.c | 9 - source3/libads/kerberos_keytab.c | 18 -- 2 files changed, 16 insertions(+), 11 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/lib/msghdr.c b/source3/lib/msghdr.c index 2aa2f2e..6917069 100644 --- a/source3/lib/msghdr.c +++ b/source3/lib/msghdr.c @@ -204,7 +204,14 @@ ssize_t msghdr_copy(struct msghdr_buf *msg, size_t msgsize, bufsize = (msgsize > offsetof(struct msghdr_buf, buf)) ? msgsize - offsetof(struct msghdr_buf, buf) : 0; - fd_len = msghdr_prep_fds(>msg, msg->buf, bufsize, fds, num_fds); + if (msg != NULL) { + msg->msg = (struct msghdr) {}; + + fd_len = msghdr_prep_fds(>msg, msg->buf, bufsize, +fds, num_fds); + } else { + fd_len = msghdr_prep_fds(NULL, NULL, bufsize, fds, num_fds); + } if (fd_len == -1) { return -1; diff --git a/source3/libads/kerberos_keytab.c b/source3/libads/kerberos_keytab.c index 309e614..b47dde6 100644 --- a/source3/libads/kerberos_keytab.c +++ b/source3/libads/kerberos_keytab.c @@ -744,26 +744,24 @@ done: TALLOC_FREE(oldEntries); TALLOC_FREE(frame); - { + if (context) { krb5_keytab_entry zero_kt_entry; + krb5_kt_cursor zero_csr; + ZERO_STRUCT(zero_kt_entry); + ZERO_STRUCT(zero_csr); + if (memcmp(_kt_entry, _entry, sizeof(krb5_keytab_entry))) { smb_krb5_kt_free_entry(context, _entry); } - } - { - krb5_kt_cursor zero_csr; - ZERO_STRUCT(zero_csr); if ((memcmp(, _csr, sizeof(krb5_kt_cursor)) != 0) && keytab) { krb5_kt_end_seq_get(context, keytab, ); } - } - if (keytab) { - krb5_kt_close(context, keytab); - } - if (context) { + if (keytab) { + krb5_kt_close(context, keytab); + } krb5_free_context(context); } return ret; -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-2-test updated
The branch, v4-2-test has been updated via 3af9006 s3: krb5: keytab - The done label can be jumped to with context == NULL. from 4759f64 smbd: Fix an assert https://git.samba.org/?p=samba.git;a=shortlog;h=v4-2-test - Log - commit 3af9006f3d6cc1219885ca7ce33a8ec075af7070 Author: Jeremy AllisonDate: Wed Jun 8 14:50:59 2016 -0700 s3: krb5: keytab - The done label can be jumped to with context == NULL. Ensure we don't crash in this case. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11959 Signed-off-by: Jeremy Allison Reviewed-by: Uri Simchoni Autobuild-User(master): Uri Simchoni Autobuild-Date(master): Thu Jun 9 13:18:56 CEST 2016 on sn-devel-144 (cherry picked from commit e46cb9b835eb8f2bd998def82baf6f07fda9fe5c) Autobuild-User(v4-2-test): Karolin Seeger Autobuild-Date(v4-2-test): Wed Jun 15 14:26:39 CEST 2016 on sn-devel-104 --- Summary of changes: source3/libads/kerberos_keytab.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/libads/kerberos_keytab.c b/source3/libads/kerberos_keytab.c index ae3d80e39..2068d03 100644 --- a/source3/libads/kerberos_keytab.c +++ b/source3/libads/kerberos_keytab.c @@ -742,26 +742,24 @@ done: TALLOC_FREE(oldEntries); TALLOC_FREE(frame); - { + if (context) { krb5_keytab_entry zero_kt_entry; + krb5_kt_cursor zero_csr; + ZERO_STRUCT(zero_kt_entry); + ZERO_STRUCT(zero_csr); + if (memcmp(_kt_entry, _entry, sizeof(krb5_keytab_entry))) { smb_krb5_kt_free_entry(context, _entry); } - } - { - krb5_kt_cursor zero_csr; - ZERO_STRUCT(zero_csr); if ((memcmp(, _csr, sizeof(krb5_kt_cursor)) != 0) && keytab) { krb5_kt_end_seq_get(context, keytab, ); } - } - if (keytab) { - krb5_kt_close(context, keytab); - } - if (context) { + if (keytab) { + krb5_kt_close(context, keytab); + } krb5_free_context(context); } return ret; -- Samba Shared Repository
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-1205/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-1205/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-1205/samba.stdout The top commit at the time of the failure was: commit 46916b24e9c8b56a14152488e270a05064cf4586 Author: Volker LendeckeDate: Fri Jun 10 11:40:33 2016 +0200 lib: Add a little closefrom() test Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Jun 13 14:11:11 CEST 2016 on sn-devel-144
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-06-15-1200/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-144/2016-06-15-1200/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-144/2016-06-15-1200/samba.stdout The top commit at the time of the failure was: commit 46916b24e9c8b56a14152488e270a05064cf4586 Author: Volker LendeckeDate: Fri Jun 10 11:40:33 2016 +0200 lib: Add a little closefrom() test Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Jun 13 14:11:11 CEST 2016 on sn-devel-144
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via cb501c6 Properly encode french accents. from d6cc60a NEWS[4.3.10]: Samba 4.3.10 Available for Download https://git.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit cb501c6365b7f16c2e1902e86f4abcc0f8fd08c7 Author: Karolin SeegerDate: Wed Jun 15 09:26:29 2016 +0200 Properly encode french accents. Signed-off-by: Karolin Seeger --- Summary of changes: history/samba-4.3.10.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changeset truncated at 500 lines: diff --git a/history/samba-4.3.10.html b/history/samba-4.3.10.html index b60c6ef..41dad60 100644 --- a/history/samba-4.3.10.html +++ b/history/samba-4.3.10.html @@ -45,7 +45,7 @@ o Ralph Boehme s...@samba.org o Alexander Bokovoy a...@samba.org * BUG 11936: s3-smbd: Support systemd 230. -o Jérémie Courrèges-Anglas j...@wxcvbn.org +o Jrmie Courrges-Anglas j...@wxcvbn.org * BUG 11864: Provide fallback code for non-portable clearenv(3). o Gnther Deschner g...@samba.org -- Samba Website Repository
[SCM] Samba Shared Repository - annotated tag samba-4.3.10 created
The annotated tag, samba-4.3.10 has been created at d4ad2a2d2a18c200f9da40364f598b19abbe9eda (tag) tagging 65573bb07a6f86179e789023a20bb7cace0bb37c (commit) replaces samba-4.3.9 tagged by Karolin Seeger on Tue Jun 14 09:42:55 2016 +0200 - Log - samba: tag release samba-4.3.10 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iD8DBQBXX7V/bzORW2Vot+oRAl7VAJ9jZgKnE7Yb5IJUU0bEeKeNS0YLFACgvB6D UL/wxreWKPr3dXHA8dfzI2Y= =mJJM -END PGP SIGNATURE- Alexander Bokovoy (1): s3-smbd: Support systemd 230 Andreas Schneider (2): s3-net: Convert the key_name to UTF8 during migration s3-smbspool: Log to stderr Anoop C S (3): packaging: Remove ulimit usage for setting core file size limit packaging: Set default limit for core file size in init scripts packaging: Set default limit for core file size in service files Christian Ambach (6): s3:smbd/service disable case-sensitivity for SMB2/3 connections s3:smbd/service apply some code formatting s3:smbd/filename remove smelly code s3:libsmb/clifile use correct value for MaxParameterCount for setting EAs s3:rpcclient make --pw-nt-hash option work s3:selftest add a test for rpcclient --pw-nt-hash option Günther Deschner (1): s3:client:smbspool_krb5_wrapper: fix the non clearenv build. Hemanth Thummala (1): Fix memory leak in share mode locking. Ira Cooper (1): source3: Honor the core soft limit of the OS. Jeremy Allison (1): s3: auth: Move the declaration of struct dom_sid tmp_sid to function level scope. Jérémie Courrèges-Anglas (1): Provide fallback code for non-portable clearenv(3) Karolin Seeger (3): VERSION: Bump version up to 4.3.10... WHATSNEW: Add release notes for Samba 4.3.10. VERSION: Disable git snapshots for the 4.3.10 release. Lorinczy Zsigmond (1): lib: replace: snprintf - Fix length calculation for hex/octal 64-bit values. Luca Olivetti (1): pdb: Fix segfault in pdb_ldap for missing gecos Raghavendra Talur (1): init: set core file size to unlimited by default Ralph Boehme (2): vfs_fruit: add an option that allows disabling POSIX rename behaviour s3:libnet:libnet_join: add netbios aliases as SPNs Robin McCorkell (1): Correctly set cli->raw_status for libsmbclient in SMB2 code Rowland Penny (1): samba-too: Allow 'samba-tool fsmo' to cope with empty or missing fsmo roles Stefan Metzmacher (4): libcli/auth: let msrpc_parse() return talloc'ed empty strings s3:smbd: fix anonymous authentication if signing is mandatory s3:ntlm_auth: make ntlm_auth_generate_session_info() more complete s3:rpcclient: make use of SMB_SIGNING_IPC_DEFAULT Uri Simchoni (2): heimdal: encode/decode kvno as signed integer s3-quotas: fix sysquotas_4B quota fetching for BSD Volker Lendecke (1): smbd: Fix an assert --- -- Samba Shared Repository
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via d6cc60a NEWS[4.3.10]: Samba 4.3.10 Available for Download from 4525c38 Remove another reference to Binary_Packages https://git.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit d6cc60a0fa90e6b6a20f27a96894dc1a9eab8470 Author: Karolin SeegerDate: Tue Jun 14 09:43:48 2016 +0200 NEWS[4.3.10]: Samba 4.3.10 Available for Download Signed-off-by: Karolin Seeger --- Summary of changes: history/samba-4.3.10.html| 100 +++ posted_news/20160614-074707.4.3.10.body.html | 13 +++ posted_news/20160614-074707.4.3.10.headline.html | 3 + 3 files changed, 116 insertions(+) create mode 100644 history/samba-4.3.10.html create mode 100644 posted_news/20160614-074707.4.3.10.body.html create mode 100644 posted_news/20160614-074707.4.3.10.headline.html Changeset truncated at 500 lines: diff --git a/history/samba-4.3.10.html b/history/samba-4.3.10.html new file mode 100644 index 000..b60c6ef --- /dev/null +++ b/history/samba-4.3.10.html @@ -0,0 +1,100 @@ +http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;> +http://www.w3.org/1999/xhtml;> + +Samba 4.3.10 - Release Notes + + +Samba 4.3.10 Available for Download + +https://download.samba.org/pub/samba/stable/samba-4.3.10.tar.gz;>Samba 4.3.10 (gzipped) +https://download.samba.org/pub/samba/stable/samba-4.3.10.tar.asc;>Signature + + +https://download.samba.org/pub/samba/patches/samba-4.3.9-4.3.10.diffs.gz;>Patch (gzipped) against Samba 4.3.9 +https://download.samba.org/pub/samba/patches/samba-4.3.9-4.3.10.diffs.asc;>Signature + + + + == + Release Notes for Samba 4.3.10 +June 15, 2016 + == + + +This is the latest stable release of Samba 4.3. + + +Changes since 4.3.9: + + +o Jeremy Allison j...@samba.org + * BUG 10618: Do not ignore supplementary groups. + +o Christian Ambach a...@samba.org + * BUG 10796: s3:rpcclient: Make --pw-nt-hash option work. + * BUG 11354: s3:libsmb/clifile: Use correct value for MaxParameterCount for + setting EAs. + * BUG 11438: s3:smbd/service disable case-sensitivity for SMB2/3 connections. + +o Ralph Boehme s...@samba.org + * BUG 1703: s3:libnet:libnet_join: Add netbios aliases as SPNs. + * BUG 11721: vfs_fruit: Add an option that allows disabling POSIX rename + behaviour. + +o Alexander Bokovoy a...@samba.org + * BUG 11936: s3-smbd: Support systemd 230. + +o Jérémie Courrèges-Anglas j...@wxcvbn.org + * BUG 11864: Provide fallback code for non-portable clearenv(3). + +o Gnther Deschner g...@samba.org + * BUG 11864: s3:client:smbspool_krb5_wrapper: fix the non clearenv build. + +o Robin McCorkell ro...@mccorkell.me.uk + * BUG 11276: Correctly set cli-raw_status for libsmbclient in SMB2 code. + +o Stefan Metzmacher me...@samba.org + * BUG 11910: s3:smbd: Fix anonymous authentication if signing is mandatory. + * BUG 11912: libcli/auth: Let msrpc_parse() return talloced empty strings. + * BUG 11914: s3:ntlm_auth: Make ntlm_auth_generate_session_info() more + complete. + * BUG 11927: s3:rpcclient: Make use of SMB_SIGNING_IPC_DEFAULT. + +o Luca Olivetti l...@wetron.es + * BUG 11530: pdb: Fix segfault in pdb_ldap for missing gecos. + +o Rowland Penny rpe...@samba.org + * BUG 11613: samba-tool: Allow samba-tool fsmo to cope with empty or missing + fsmo roles. + +o Anoop C S anoo...@redhat.com + * BUG 11907: packaging: Set default limit for core file size in service + files. + +o Andreas Schneider a...@samba.org + * BUG 11922: s3-net: Convert the key_name to UTF8 during migration. + * BUG 11935: s3-smbspool: Log to stderr. + +o Uri Simchoni u...@samba.org + * BUG 11900: heimdal: Encode/decode kvno as signed integer. + * BUG 11931: s3-quotas: Fix sysquotas_4B quota fetching for BSD. + +o Raghavendra Talur rta...@redhat.com + * BUG 11907: init: Set core file size to unlimited by default. + +o Hemanth Thummala hemanth.thumm...@nutanix.com + * BUG 11934: Fix memory leak in share mode locking. + +o Volker Lendecke v...@samba.org + * BUG 11844: smbd: Fix an assert. + +o Lorinczy Zsigmond lzs...@freemail.c3.hu + * BUG 11947: lib: replace: snprintf - Fix length calculation for hex/octal + 64-bit values. + + + + + + diff --git a/posted_news/20160614-074707.4.3.10.body.html b/posted_news/20160614-074707.4.3.10.body.html new file mode 100644 index 000..bc5ae8f --- /dev/null +++ b/posted_news/20160614-074707.4.3.10.body.html @@ -0,0 +1,13 @@ + +15 June 2016 +Samba 4.3.10 Available for Download + +This is the latest stable release of the Samba 4.3 release series. + + +The uncompressed tarball has
[SCM] Samba Shared Repository - branch v4-3-stable updated
The branch, v4-3-stable has been updated via 65573bb VERSION: Disable git snapshots for the 4.3.10 release. via 8935d6e WHATSNEW: Add release notes for Samba 4.3.10. via a23461d lib: replace: snprintf - Fix length calculation for hex/octal 64-bit values. via 136ed0e samba-too: Allow 'samba-tool fsmo' to cope with empty or missing fsmo roles via 2e81a93 s3:client:smbspool_krb5_wrapper: fix the non clearenv build. via 14bd198 Provide fallback code for non-portable clearenv(3) via a304725 s3:selftest add a test for rpcclient --pw-nt-hash option via e469ad2 s3:rpcclient make --pw-nt-hash option work via 5f3cfc8 s3-smbd: Support systemd 230 via 4112991 s3-smbspool: Log to stderr via 58ba260 Fix memory leak in share mode locking. via 23663df s3-quotas: fix sysquotas_4B quota fetching for BSD via 2261c23 s3-net: Convert the key_name to UTF8 during migration via 40f1add packaging: Set default limit for core file size in service files via fc385f3 packaging: Set default limit for core file size in init scripts via 9b09d3d packaging: Remove ulimit usage for setting core file size limit via 73c385c s3: auth: Move the declaration of struct dom_sid tmp_sid to function level scope. via 0128c11 s3:rpcclient: make use of SMB_SIGNING_IPC_DEFAULT via 6d9dbe9 smbd: Fix an assert via ded212f s3:ntlm_auth: make ntlm_auth_generate_session_info() more complete via f5eeb21 s3:smbd: fix anonymous authentication if signing is mandatory via e44c9b6 libcli/auth: let msrpc_parse() return talloc'ed empty strings via 3a69922 s3:libsmb/clifile use correct value for MaxParameterCount for setting EAs via ea96367 pdb: Fix segfault in pdb_ldap for missing gecos via 133e196 s3:libnet:libnet_join: add netbios aliases as SPNs via 313ba1d init: set core file size to unlimited by default via 6d7ed01 source3: Honor the core soft limit of the OS. via 568ce3b heimdal: encode/decode kvno as signed integer via d926b8b vfs_fruit: add an option that allows disabling POSIX rename behaviour via 7916bd8 s3:smbd/filename remove smelly code via 859080c s3:smbd/service apply some code formatting via e21f43a s3:smbd/service disable case-sensitivity for SMB2/3 connections via 4598743 Correctly set cli->raw_status for libsmbclient in SMB2 code via a417e10 VERSION: Bump version up to 4.3.10... from 8e71328 VERSION: Disable git snapshots for the 4.3.9 release. https://git.samba.org/?p=samba.git;a=shortlog;h=v4-3-stable - Log - --- Summary of changes: VERSION| 2 +- WHATSNEW.txt | 104 - docs-xml/manpages/vfs_fruit.8.xml | 11 + lib/replace/snprintf.c | 6 +- lib/util/become_daemon.c | 10 +- libcli/auth/msrpc_parse.c | 24 ++- packaging/RHEL-CTDB/setup/smb.init | 2 + packaging/RHEL-CTDB/setup/winbind.init | 2 + packaging/RHEL/setup/smb.init | 2 + packaging/RHEL/setup/winbind.init | 2 + packaging/systemd/nmb.service | 1 + packaging/systemd/smb.service | 1 + packaging/systemd/winbind.service | 1 + python/samba/netcmd/fsmo.py| 233 - python/samba/tests/{auth.py => samba_tool/fsmo.py} | 22 +- source3/auth/token_util.c | 2 +- source3/client/smbspool.c | 2 +- source3/client/smbspool_krb5_wrapper.c | 10 + source3/lib/dumpcore.c | 15 -- source3/lib/sysquotas_4B.c | 6 + source3/libnet/libnet_join.c | 60 ++ source3/libsmb/cli_smb2_fnum.c | 16 +- source3/libsmb/clifile.c | 2 +- source3/locking/share_mode_lock.c | 5 + source3/modules/vfs_fruit.c| 6 +- source3/passdb/pdb_ldap.c | 6 +- source3/rpcclient/rpcclient.c | 16 +- source3/script/tests/test_rpcclient_pw_nt_hash.sh | 27 +++ source3/selftest/tests.py | 5 + source3/smbd/filename.c| 28 --- source3/smbd/oplock.c | 1 + source3/smbd/service.c | 50 +++-- source3/smbd/sesssetup.c | 8 +- source3/utils/net_printing.c | 90 +++- source3/utils/ntlm_auth.c
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-0803/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-0803/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-06-15-0803/samba.stdout The top commit at the time of the failure was: commit 46916b24e9c8b56a14152488e270a05064cf4586 Author: Volker LendeckeDate: Fri Jun 10 11:40:33 2016 +0200 lib: Add a little closefrom() test Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Jun 13 14:11:11 CEST 2016 on sn-devel-144