autobuild[sn-devel-144]: intermittent test failure detected

2016-07-13 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-14-0719/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-14-0719/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-14-0719/samba.stdout
  
The top commit at the time of the failure was:

commit 84992e31e15b67cd5823c45a7f9bb4df471a1170
Author: Michael Adam 
Date:   Wed Jul 13 13:22:54 2016 +0200

rpc_server: add mssing '#pragma GCC diagnostic push'

for completeness for later pop.

Signed-off-by: Michael Adam 
Reviewed-by: Ira Cooper 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Thu Jul 14 02:02:33 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

2016-07-13 Thread Jeremy Allison 
The branch, master has been updated
   via  7c9505e ldb:dlinklist: avoid -Wtautological-compare errors with gcc6
   via  2991f77 tevent: avoid -Wtautological-compare errors with gcc6
   via  5d85fd8 lib:dlinklist: avoid -Wtautological-compare errors with gcc6
   via  f6d4380 selftest: Add tunable for smb2.maxfid limit
  from  84992e3 rpc_server: add mssing '#pragma GCC diagnostic push'

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 7c9505e651287c5d4747b222af1fda970c562a00
Author: Ira Cooper 
Date:   Wed Jul 13 12:37:19 2016 +0200

ldb:dlinklist: avoid -Wtautological-compare errors with gcc6

We expect these macros to generate tautological compares
intentionally, so disabling the warning is just fine.

This lets --pick-developer work with gcc6 and newer.

Pair-Programmed-With: Michael Adam 

Signed-off-by: Michael Adam 
Signed-off-by: Ira Cooper 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Jul 14 05:44:21 CEST 2016 on sn-devel-144

commit 2991f7709973fdcc2c0b83bbe15dda3f1ceae9b3
Author: Michael Adam 
Date:   Wed Jul 13 12:36:21 2016 +0200

tevent: avoid -Wtautological-compare errors with gcc6

We expect these macros to generate tautological compares
intentionally, so disabling the warning is just fine.

This lets --picky-developer work with gcc6 and newer.

Pair-Programmed-With: Ira Cooper 

Signed-off-by: Ira Cooper 
Signed-off-by: Michael Adam 
Reviewed-by: Jeremy Allison 

commit 5d85fd85467eb1f8941641d5f71d75e7d5c7234c
Author: Ira Cooper 
Date:   Wed Jul 13 12:35:13 2016 +0200

lib:dlinklist: avoid -Wtautological-compare errors with gcc6

We expect these macros to generate tautological compares
intentionally, so disabling the warning is just fine.

This lets --picky-developer work with gcc6 and newer.

Pair-Programmed-With: Michael Adam 

Signed-off-by: Michael Adam 
Signed-off-by: Ira Cooper 
Reviewed-by: Jeremy Allison 

commit f6d4380a9d1e6e7323fb943d809893ce9b9dbbb2
Author: Christof Schmitt 
Date:   Wed Jul 13 13:09:48 2016 -0700

selftest: Add tunable for smb2.maxfid limit

Signed-off-by: Christof Schmitt 
Reviewed-by: Jeremy Allison 

---

Summary of changes:
 lib/ldb/include/dlinklist.h   |  8 
 lib/tevent/tevent_util.h  |  8 
 lib/util/dlinklist.h  |  8 
 source4/torture/smb2/maxfid.c | 10 --
 4 files changed, 32 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/ldb/include/dlinklist.h b/lib/ldb/include/dlinklist.h
index ef01aec..ca76794 100644
--- a/lib/ldb/include/dlinklist.h
+++ b/lib/ldb/include/dlinklist.h
@@ -83,6 +83,9 @@ do { \
 */
 #define DLIST_REMOVE(list, p) \
 do { \
+   _Pragma ("GCC diagnostic push") \
+   _Pragma ("GCC diagnostic ignored \"-Wpragmas\"") \
+   _Pragma ("GCC diagnostic ignored \"-Wtautological-compare\"") \
if ((p) == (list)) { \
if ((p)->next) (p)->next->prev = (p)->prev; \
(list) = (p)->next; \
@@ -94,6 +97,7 @@ do { \
if ((p)->next) (p)->next->prev = (p)->prev; \
} \
if ((p) != (list)) (p)->next = (p)->prev = NULL;\
+   _Pragma ("GCC diagnostic pop") \
 } while (0)
 
 /*
@@ -124,7 +128,11 @@ do { \
(p)->next = (el)->next; \
(el)->next = (p);   \
if ((p)->next) (p)->next->prev = (p);   \
+   _Pragma ("GCC diagnostic push") \
+   _Pragma ("GCC diagnostic ignored \"-Wpragmas\"") \
+   _Pragma ("GCC diagnostic ignored \"-Wtautological-compare\"") \
if ((list)->prev == (el)) (list)->prev = (p); \
+   _Pragma ("GCC diagnostic pop") \
}\
 } while (0)
 
diff --git a/lib/tevent/tevent_util.h b/lib/tevent/tevent_util.h
index e2cdbb8..eb7586f 100644
--- a/lib/tevent/tevent_util.h
+++ b/lib/tevent/tevent_util.h
@@ -79,6 +79,9 @@ do { \
 */
 #define DLIST_REMOVE(list, p) \
 do { \
+   _Pragma ("GCC diagnostic push") \
+   _Pragma ("GCC diagnostic ignored \"-Wpragmas\"") \
+   _Pragma ("GCC diagnostic ignored \"-Wtautological-compare\"") \
if ((p) == (list)) { \
if ((p)->next) (p)->next->prev = (p)->prev; \
(list) = (p)->next; \
@@ -90,6 +93,7 @@ do { \
if ((p)->next) (p)->next->prev = (p)->prev; \

autobuild[sn-devel-104]: intermittent test failure detected

2016-07-13 Thread autobuild 
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-14-0404/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-14-0404/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-14-0404/samba.stdout
  
The top commit at the time of the failure was:

commit 84992e31e15b67cd5823c45a7f9bb4df471a1170
Author: Michael Adam 
Date:   Wed Jul 13 13:22:54 2016 +0200

rpc_server: add mssing '#pragma GCC diagnostic push'

for completeness for later pop.

Signed-off-by: Michael Adam 
Reviewed-by: Ira Cooper 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Thu Jul 14 02:02:33 CEST 2016 on sn-devel-144

autobuild[sn-devel-144]: intermittent test failure detected

2016-07-13 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-14-0313/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-14-0313/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-14-0313/samba.stdout
  
The top commit at the time of the failure was:

commit f8181360a89ac9e53cc991e966958e496271fa15
Author: Stefan Metzmacher 
Date:   Mon Jul 11 15:25:31 2016 +0200

python/remove_dc: handle dnsNode objects without dnsRecord attribute

If we have dnsNode objects without dnsRecord attribute values we trigger
the following error triggered by 'samba-tool domain demote 
--remove-other-dead-server=server2'

  ERROR(): uncaught exception - 
__ndr_unpack__()
  argument 1 must be string or read-only buffer, not dnsp.DnssrvRpcRecord
File "/usr/lib64/python2.6/site-packages/samba/netcmd/__init__.py", 
line 175,
  in _run
  return self.run(*args, **kwargs)
File "/usr/lib64/python2.6/site-packages/samba/netcmd/domain.py", line 
720, in
  run
  remove_dc.remove_dc(samdb, logger, remove_other_dead_server)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 423, 
in
  remove_dc
  remove_dns_account=True)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 351, 
in
  offline_remove_ntds_dc
  remove_dns_account=remove_dns_account)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 266, 
in
  offline_remove_server
  remove_dns_references(samdb, logger, dnsHostName)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 186, 
in
  remove_dns_references
  for v in values if not to_remove(v) ]
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 160, 
in
  to_remove
  dnsRecord = ndr_unpack(dnsp.DnssrvRpcRecord, value)
File "/usr/lib64/python2.6/site-packages/samba/ndr.py", line 45, in 
ndr_unpack
  object.__ndr_unpack__(data, allow_remaining=allow_remaining)
  A transaction is still active in ldb context [0xe1f320] on
  tdb:///var/lib/samba/private/sam.ldb

"next" is used in perl not in python!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12018

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Jul 13 10:10:30 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

2016-07-13 Thread Michael Adam 
The branch, master has been updated
   via  84992e3 rpc_server: add mssing '#pragma GCC diagnostic push'
  from  f818136 python/remove_dc: handle dnsNode objects without dnsRecord 
attribute

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 84992e31e15b67cd5823c45a7f9bb4df471a1170
Author: Michael Adam 
Date:   Wed Jul 13 13:22:54 2016 +0200

rpc_server: add mssing '#pragma GCC diagnostic push'

for completeness for later pop.

Signed-off-by: Michael Adam 
Reviewed-by: Ira Cooper 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Thu Jul 14 02:02:33 CEST 2016 on sn-devel-144

---

Summary of changes:
 source3/rpc_server/mdssvc/mdssvc.h | 1 +
 1 file changed, 1 insertion(+)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/mdssvc/mdssvc.h 
b/source3/rpc_server/mdssvc/mdssvc.h
index 091cd97..4e08fe1 100644
--- a/source3/rpc_server/mdssvc/mdssvc.h
+++ b/source3/rpc_server/mdssvc/mdssvc.h
@@ -34,6 +34,7 @@
 #undef TRUE
 #undef FALSE
 /* allow building with --picky-developer */
+#pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wcast-qual"
 #include 
 #include 


-- 
Samba Shared Repository

autobuild[sn-devel-104]: intermittent test failure detected

2016-07-13 Thread autobuild 
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-14-0003/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-14-0003/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-14-0003/samba.stdout
  
The top commit at the time of the failure was:

commit f8181360a89ac9e53cc991e966958e496271fa15
Author: Stefan Metzmacher 
Date:   Mon Jul 11 15:25:31 2016 +0200

python/remove_dc: handle dnsNode objects without dnsRecord attribute

If we have dnsNode objects without dnsRecord attribute values we trigger
the following error triggered by 'samba-tool domain demote 
--remove-other-dead-server=server2'

  ERROR(): uncaught exception - 
__ndr_unpack__()
  argument 1 must be string or read-only buffer, not dnsp.DnssrvRpcRecord
File "/usr/lib64/python2.6/site-packages/samba/netcmd/__init__.py", 
line 175,
  in _run
  return self.run(*args, **kwargs)
File "/usr/lib64/python2.6/site-packages/samba/netcmd/domain.py", line 
720, in
  run
  remove_dc.remove_dc(samdb, logger, remove_other_dead_server)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 423, 
in
  remove_dc
  remove_dns_account=True)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 351, 
in
  offline_remove_ntds_dc
  remove_dns_account=remove_dns_account)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 266, 
in
  offline_remove_server
  remove_dns_references(samdb, logger, dnsHostName)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 186, 
in
  remove_dns_references
  for v in values if not to_remove(v) ]
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 160, 
in
  to_remove
  dnsRecord = ndr_unpack(dnsp.DnssrvRpcRecord, value)
File "/usr/lib64/python2.6/site-packages/samba/ndr.py", line 45, in 
ndr_unpack
  object.__ndr_unpack__(data, allow_remaining=allow_remaining)
  A transaction is still active in ldb context [0xe1f320] on
  tdb:///var/lib/samba/private/sam.ldb

"next" is used in perl not in python!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12018

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Jul 13 10:10:30 CEST 2016 on sn-devel-144

autobuild[sn-devel-144]: intermittent test failure detected

2016-07-13 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-13-2300/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-13-2300/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-07-13-2300/samba.stdout
  
The top commit at the time of the failure was:

commit f8181360a89ac9e53cc991e966958e496271fa15
Author: Stefan Metzmacher 
Date:   Mon Jul 11 15:25:31 2016 +0200

python/remove_dc: handle dnsNode objects without dnsRecord attribute

If we have dnsNode objects without dnsRecord attribute values we trigger
the following error triggered by 'samba-tool domain demote 
--remove-other-dead-server=server2'

  ERROR(): uncaught exception - 
__ndr_unpack__()
  argument 1 must be string or read-only buffer, not dnsp.DnssrvRpcRecord
File "/usr/lib64/python2.6/site-packages/samba/netcmd/__init__.py", 
line 175,
  in _run
  return self.run(*args, **kwargs)
File "/usr/lib64/python2.6/site-packages/samba/netcmd/domain.py", line 
720, in
  run
  remove_dc.remove_dc(samdb, logger, remove_other_dead_server)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 423, 
in
  remove_dc
  remove_dns_account=True)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 351, 
in
  offline_remove_ntds_dc
  remove_dns_account=remove_dns_account)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 266, 
in
  offline_remove_server
  remove_dns_references(samdb, logger, dnsHostName)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 186, 
in
  remove_dns_references
  for v in values if not to_remove(v) ]
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 160, 
in
  to_remove
  dnsRecord = ndr_unpack(dnsp.DnssrvRpcRecord, value)
File "/usr/lib64/python2.6/site-packages/samba/ndr.py", line 45, in 
ndr_unpack
  object.__ndr_unpack__(data, allow_remaining=allow_remaining)
  A transaction is still active in ldb context [0xe1f320] on
  tdb:///var/lib/samba/private/sam.ldb

"next" is used in perl not in python!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12018

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Jul 13 10:10:30 CEST 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

2016-07-13 Thread autobuild 
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-2003/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-2003/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-2003/samba.stdout
  
The top commit at the time of the failure was:

commit f8181360a89ac9e53cc991e966958e496271fa15
Author: Stefan Metzmacher 
Date:   Mon Jul 11 15:25:31 2016 +0200

python/remove_dc: handle dnsNode objects without dnsRecord attribute

If we have dnsNode objects without dnsRecord attribute values we trigger
the following error triggered by 'samba-tool domain demote 
--remove-other-dead-server=server2'

  ERROR(): uncaught exception - 
__ndr_unpack__()
  argument 1 must be string or read-only buffer, not dnsp.DnssrvRpcRecord
File "/usr/lib64/python2.6/site-packages/samba/netcmd/__init__.py", 
line 175,
  in _run
  return self.run(*args, **kwargs)
File "/usr/lib64/python2.6/site-packages/samba/netcmd/domain.py", line 
720, in
  run
  remove_dc.remove_dc(samdb, logger, remove_other_dead_server)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 423, 
in
  remove_dc
  remove_dns_account=True)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 351, 
in
  offline_remove_ntds_dc
  remove_dns_account=remove_dns_account)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 266, 
in
  offline_remove_server
  remove_dns_references(samdb, logger, dnsHostName)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 186, 
in
  remove_dns_references
  for v in values if not to_remove(v) ]
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 160, 
in
  to_remove
  dnsRecord = ndr_unpack(dnsp.DnssrvRpcRecord, value)
File "/usr/lib64/python2.6/site-packages/samba/ndr.py", line 45, in 
ndr_unpack
  object.__ndr_unpack__(data, allow_remaining=allow_remaining)
  A transaction is still active in ldb context [0xe1f320] on
  tdb:///var/lib/samba/private/sam.ldb

"next" is used in perl not in python!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12018

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Jul 13 10:10:30 CEST 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

2016-07-13 Thread autobuild 
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-1603/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-1603/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-1603/samba.stdout
  
The top commit at the time of the failure was:

commit f8181360a89ac9e53cc991e966958e496271fa15
Author: Stefan Metzmacher 
Date:   Mon Jul 11 15:25:31 2016 +0200

python/remove_dc: handle dnsNode objects without dnsRecord attribute

If we have dnsNode objects without dnsRecord attribute values we trigger
the following error triggered by 'samba-tool domain demote 
--remove-other-dead-server=server2'

  ERROR(): uncaught exception - 
__ndr_unpack__()
  argument 1 must be string or read-only buffer, not dnsp.DnssrvRpcRecord
File "/usr/lib64/python2.6/site-packages/samba/netcmd/__init__.py", 
line 175,
  in _run
  return self.run(*args, **kwargs)
File "/usr/lib64/python2.6/site-packages/samba/netcmd/domain.py", line 
720, in
  run
  remove_dc.remove_dc(samdb, logger, remove_other_dead_server)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 423, 
in
  remove_dc
  remove_dns_account=True)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 351, 
in
  offline_remove_ntds_dc
  remove_dns_account=remove_dns_account)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 266, 
in
  offline_remove_server
  remove_dns_references(samdb, logger, dnsHostName)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 186, 
in
  remove_dns_references
  for v in values if not to_remove(v) ]
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 160, 
in
  to_remove
  dnsRecord = ndr_unpack(dnsp.DnssrvRpcRecord, value)
File "/usr/lib64/python2.6/site-packages/samba/ndr.py", line 45, in 
ndr_unpack
  object.__ndr_unpack__(data, allow_remaining=allow_remaining)
  A transaction is still active in ldb context [0xe1f320] on
  tdb:///var/lib/samba/private/sam.ldb

"next" is used in perl not in python!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12018

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Jul 13 10:10:30 CEST 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

2016-07-13 Thread autobuild 
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-1204/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-1204/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-1204/samba.stdout
  
The top commit at the time of the failure was:

commit f8181360a89ac9e53cc991e966958e496271fa15
Author: Stefan Metzmacher 
Date:   Mon Jul 11 15:25:31 2016 +0200

python/remove_dc: handle dnsNode objects without dnsRecord attribute

If we have dnsNode objects without dnsRecord attribute values we trigger
the following error triggered by 'samba-tool domain demote 
--remove-other-dead-server=server2'

  ERROR(): uncaught exception - 
__ndr_unpack__()
  argument 1 must be string or read-only buffer, not dnsp.DnssrvRpcRecord
File "/usr/lib64/python2.6/site-packages/samba/netcmd/__init__.py", 
line 175,
  in _run
  return self.run(*args, **kwargs)
File "/usr/lib64/python2.6/site-packages/samba/netcmd/domain.py", line 
720, in
  run
  remove_dc.remove_dc(samdb, logger, remove_other_dead_server)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 423, 
in
  remove_dc
  remove_dns_account=True)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 351, 
in
  offline_remove_ntds_dc
  remove_dns_account=remove_dns_account)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 266, 
in
  offline_remove_server
  remove_dns_references(samdb, logger, dnsHostName)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 186, 
in
  remove_dns_references
  for v in values if not to_remove(v) ]
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 160, 
in
  to_remove
  dnsRecord = ndr_unpack(dnsp.DnssrvRpcRecord, value)
File "/usr/lib64/python2.6/site-packages/samba/ndr.py", line 45, in 
ndr_unpack
  object.__ndr_unpack__(data, allow_remaining=allow_remaining)
  A transaction is still active in ldb context [0xe1f320] on
  tdb:///var/lib/samba/private/sam.ldb

"next" is used in perl not in python!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12018

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Jul 13 10:10:30 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

2016-07-13 Thread Andrew Bartlett 
The branch, master has been updated
   via  f818136 python/remove_dc: handle dnsNode objects without dnsRecord 
attribute
  from  be39b73 dsdb: Fix CID 1363810: Null pointer dereferences

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit f8181360a89ac9e53cc991e966958e496271fa15
Author: Stefan Metzmacher 
Date:   Mon Jul 11 15:25:31 2016 +0200

python/remove_dc: handle dnsNode objects without dnsRecord attribute

If we have dnsNode objects without dnsRecord attribute values we trigger
the following error triggered by 'samba-tool domain demote 
--remove-other-dead-server=server2'

  ERROR(): uncaught exception - 
__ndr_unpack__()
  argument 1 must be string or read-only buffer, not dnsp.DnssrvRpcRecord
File "/usr/lib64/python2.6/site-packages/samba/netcmd/__init__.py", 
line 175,
  in _run
  return self.run(*args, **kwargs)
File "/usr/lib64/python2.6/site-packages/samba/netcmd/domain.py", line 
720, in
  run
  remove_dc.remove_dc(samdb, logger, remove_other_dead_server)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 423, 
in
  remove_dc
  remove_dns_account=True)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 351, 
in
  offline_remove_ntds_dc
  remove_dns_account=remove_dns_account)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 266, 
in
  offline_remove_server
  remove_dns_references(samdb, logger, dnsHostName)
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 186, 
in
  remove_dns_references
  for v in values if not to_remove(v) ]
File "/usr/lib64/python2.6/site-packages/samba/remove_dc.py", line 160, 
in
  to_remove
  dnsRecord = ndr_unpack(dnsp.DnssrvRpcRecord, value)
File "/usr/lib64/python2.6/site-packages/samba/ndr.py", line 45, in 
ndr_unpack
  object.__ndr_unpack__(data, allow_remaining=allow_remaining)
  A transaction is still active in ldb context [0xe1f320] on
  tdb:///var/lib/samba/private/sam.ldb

"next" is used in perl not in python!

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12018

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Jul 13 10:10:30 CEST 2016 on sn-devel-144

---

Summary of changes:
 python/samba/remove_dc.py | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/python/samba/remove_dc.py b/python/samba/remove_dc.py
index 055a516..db7bb82 100644
--- a/python/samba/remove_dc.py
+++ b/python/samba/remove_dc.py
@@ -176,19 +176,18 @@ def remove_dns_references(samdb, logger, dnsHostName):
attrs=["dnsRecord"])
 for record in records:
 try:
-values = record["dnsRecord"]
+orig_values = record["dnsRecord"]
 except KeyError:
-next
-orig_num_values = len(values)
+continue
 
 # Remove references to dnsHostName in A, , NS, CNAME and SRV
 values = [ ndr_unpack(dnsp.DnssrvRpcRecord, v)
-   for v in values if not to_remove(v) ]
+   for v in orig_values if not to_remove(v) ]
 
-if len(values) != orig_num_values:
+if len(values) != len(orig_values):
 logger.info("updating %s keeping %d values, removing %s 
values" \
 % (record.dn, len(values),
-   orig_num_values - len(values)))
+   len(orig_values) - len(values)))
 
 # This requires the values to be unpacked, so this
 # has been done in the list comprehension above


-- 
Samba Shared Repository

autobuild[sn-devel-104]: intermittent test failure detected

2016-07-13 Thread autobuild 
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-0803/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-0803/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-07-13-0803/samba.stdout
  
The top commit at the time of the failure was:

commit be39b73ccd0f44a53b1b03c47cc0b5687d20eda2
Author: Volker Lendecke 
Date:   Tue Jul 12 18:28:23 2016 +0200

dsdb: Fix CID 1363810: Null pointer dereferences

The if-condition explicitly tests for new_schema==NULL, so this seems to be 
a
valid error case. The DEBUG statement would segfault in this case.

Signed-off-by: Volker Lendecke 
Reviewed-by: Ira Cooper 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Jul 13 06:34:33 CEST 2016 on sn-devel-144