autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-07-0733/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-07-0733/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-07-0733/samba.stdout
  
The top commit at the time of the failure was:

commit d8b57e3828eac084ad302a90b33c35ff4e918e5a
Author: Günther Deschner 
Date:   Thu Sep 1 19:55:40 2016 +0200

s3-spoolss: fix _spoolss_GetPrinterDataEx by moving the keyname lengthcheck.

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed Sep  7 03:00:14 CEST 2016 on sn-devel-144

autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2016-09-07-0419/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-09-07-0419/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-09-07-0419/samba.stdout
  
The top commit at the time of the failure was:

commit d8b57e3828eac084ad302a90b33c35ff4e918e5a
Author: Günther Deschner 
Date:   Thu Sep 1 19:55:40 2016 +0200

s3-spoolss: fix _spoolss_GetPrinterDataEx by moving the keyname lengthcheck.

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed Sep  7 03:00:14 CEST 2016 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-07-0332/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-07-0332/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-07-0332/samba.stdout
  
The top commit at the time of the failure was:

commit fee1f4ce15c8d167c6e0e358bf802d28c6617b88
Author: Michael Adam 
Date:   Mon Sep 5 17:33:38 2016 +0200

tevent: fix confused documentation

Signed-off-by: Michael Adam 
Reviewed-by: Andreas Schneider 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Sep  6 23:16:34 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Günther Deschner]

The branch, master has been updated
   via  d8b57e3 s3-spoolss: fix _spoolss_GetPrinterDataEx by moving the 
keyname lengthcheck.
   via  518b2a3 s4-torture: test GetPrinterData with server handle and 0 
keylength.
   via  d569bda pidl: support HRESULT as return code in wireshark 
autogenerated dissectors.
  from  fee1f4c tevent: fix confused documentation

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit d8b57e3828eac084ad302a90b33c35ff4e918e5a
Author: Günther Deschner 
Date:   Thu Sep 1 19:55:40 2016 +0200

s3-spoolss: fix _spoolss_GetPrinterDataEx by moving the keyname lengthcheck.

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed Sep  7 03:00:14 CEST 2016 on sn-devel-144

commit 518b2a3f5f3a4814e96546505487b775b5dbca40
Author: Günther Deschner 
Date:   Thu Sep 1 19:54:46 2016 +0200

s4-torture: test GetPrinterData with server handle and 0 keylength.

This is what e.g. Windows 10 does a lot.

Guenther

Signed-off-by: Guenther Deschner 
Reviewed-by: Andreas Schneider 

commit d569bda1e5452e13aa3dcf63a501aa581930589f
Author: Günther Deschner 
Date:   Mon Sep 28 07:28:28 2015 +0200

pidl: support HRESULT as return code in wireshark autogenerated dissectors.

Guenther

Change-Id: I68b7c579c5a519e429d2f4c2b3f63247e02f24e3
Signed-off-by: Günther Deschner 
Reviewed-on: https://code.wireshark.org/review/16718
Reviewed-by: Michael Mann 
Reviewed-by: Stefan Metzmacher 

---

Summary of changes:
 pidl/lib/Parse/Pidl/Wireshark/NDR.pm|  9 -
 source3/rpc_server/spoolss/srv_spoolss_nt.c | 12 ++--
 source4/torture/rpc/spoolss.c   | 22 +++---
 3 files changed, 29 insertions(+), 14 deletions(-)


Changeset truncated at 500 lines:

diff --git a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm 
b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
index 8161646..21ef714 100644
--- a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
+++ b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
@@ -571,7 +571,7 @@ sub Function($$$)
$self->pidl_code("{");
$self->indent;
if ( not defined($fn->{RETURN_TYPE})) {
-   } elsif ($fn->{RETURN_TYPE} eq "NTSTATUS" or $fn->{RETURN_TYPE} eq 
"WERROR")
+   } elsif ($fn->{RETURN_TYPE} eq "NTSTATUS" or $fn->{RETURN_TYPE} eq 
"WERROR" or $fn->{RETURN_TYPE} eq "HRESULT")
{
$self->pidl_code("guint32 status;\n");
} elsif (my $type = getType($fn->{RETURN_TYPE})) {
@@ -607,6 +607,11 @@ sub Function($$$)
$self->pidl_code("\tcol_append_fstr(pinfo->cinfo, COL_INFO, \", 
Error: %s\", val_to_str(status, WERR_errors, \"Unknown DOS error 
0x%08x\"));\n");
 
$return_types{$ifname}->{"werror"} = ["WERROR", "Windows 
Error"];
+   } elsif ($fn->{RETURN_TYPE} eq "HRESULT") {
+   $self->pidl_code("offset = dissect_ndr_uint32(tvb, offset, 
pinfo, tree, di, drep, hf\_$ifname\_hresult, );\n");
+   $self->pidl_code("if (status != 0)");
+   $self->pidl_code("\tcol_append_fstr(pinfo->cinfo, COL_INFO, \", 
Error: %s\", val_to_str(status, HRES_errors, \"Unknown HRES error 
0x%08x\"));\n");
+   $return_types{$ifname}->{"hresult"} = ["HRESULT", "HRES Windows 
Error"];
} elsif (my $type = getType($fn->{RETURN_TYPE})) {
if ($type->{DATA}->{TYPE} eq "ENUM") {
my $return_type = 
"g".Parse::Pidl::Typelist::enum_type_fn($type->{DATA});
@@ -1099,6 +1104,8 @@ sub Initialize($$)
"offset = PIDL_dissect_uint32(tvb, offset, pinfo, tree, di, 
drep, \@HF\@, \@PARAM\@);","FT_UINT32", "BASE_DEC", 0, "VALS(WERR_errors)", 4);
$self->register_type("NTSTATUS",
"offset = PIDL_dissect_uint32(tvb, offset, pinfo, tree, di, 
drep, \@HF\@, \@PARAM\@);","FT_UINT32", "BASE_DEC", 0, "VALS(NT_errors)", 4);
+   $self->register_type("HRESULT",
+   "offset = PIDL_dissect_uint32(tvb, offset, pinfo, tree, di, 
drep, \@HF\@, \@PARAM\@);","FT_UINT32", "BASE_DEC", 0, "VALS(HRES_errors)", 4);
$self->register_type("ipv6address", "proto_tree_add_item(tree, \@HF\@, 
tvb, offset, 16, ENC_NA); offset += 16;", "FT_IPv6", "BASE_NONE", 0, "NULL", 
16);
$self->register_type("ipv4address", "proto_tree_add_item(tree, \@HF\@, 
tvb, offset, 4, ENC_BIG_ENDIAN); offset += 4;", "FT_IPv4", "BASE_NONE", 0, 
"NULL", 4);
 
diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c 
b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index 0dcae46..7413d9d 100644
--- 

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-2332/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-2332/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-2332/samba.stdout
  
The top commit at the time of the failure was:

commit 4f654acad01dbb1b17e933a855bb53ea6a7bb34d
Author: Björn Baumbach 
Date:   Fri Aug 26 17:16:51 2016 +0200

idmap_script: add missing "IDTOSID" argument to the script command line.

According to the documentation the commands should look like
"IDTOSID UID " instead of "UID ".

This fixes changes of commit b4239ca096738f553b0f9d7fa6aaa4219b72ef7f:
idmap_script: Parallelize script calls

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12194

Signed-off-by: Björn Baumbach 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Michael Adam 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Tue Sep  6 19:32:57 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Volker Lendecke]

The branch, master has been updated
   via  fee1f4c tevent: fix confused documentation
  from  4f654ac idmap_script: add missing "IDTOSID" argument to the script 
command line.

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit fee1f4ce15c8d167c6e0e358bf802d28c6617b88
Author: Michael Adam 
Date:   Mon Sep 5 17:33:38 2016 +0200

tevent: fix confused documentation

Signed-off-by: Michael Adam 
Reviewed-by: Andreas Schneider 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Sep  6 23:16:34 CEST 2016 on sn-devel-144

---

Summary of changes:
 lib/tevent/tevent.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/tevent/tevent.h b/lib/tevent/tevent.h
index 64e2d98..7de04d0 100644
--- a/lib/tevent/tevent.h
+++ b/lib/tevent/tevent.h
@@ -465,11 +465,11 @@ void tevent_set_abort_fn(void (*abort_fn)(const char 
*reason));
 /* bits for file descriptor event flags */
 
 /**
- * Monitor a file descriptor for write availability
+ * Monitor a file descriptor for data to be read
  */
 #define TEVENT_FD_READ 1
 /**
- * Monitor a file descriptor for data to be read
+ * Monitor a file descriptor for writeability
  */
 #define TEVENT_FD_WRITE 2
 


-- 
Samba Shared Repository

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-1933/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-1933/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-1933/samba.stdout
  
The top commit at the time of the failure was:

commit 451907739cc14717c12875b88fbbe63a53e9cbec
Author: Garming Sam 
Date:   Thu Jun 9 03:52:38 2016 +0200

tests/dns_forwarder: Fail out with an assertion instead OOB error

Signed-off-by: Garming Sam 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Garming Sam 
Autobuild-Date(master): Tue Sep  6 15:41:54 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Stefan Metzmacher]

The branch, master has been updated
   via  4f654ac idmap_script: add missing "IDTOSID" argument to the script 
command line.
  from  4519077 tests/dns_forwarder: Fail out with an assertion instead OOB 
error

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 4f654acad01dbb1b17e933a855bb53ea6a7bb34d
Author: Björn Baumbach 
Date:   Fri Aug 26 17:16:51 2016 +0200

idmap_script: add missing "IDTOSID" argument to the script command line.

According to the documentation the commands should look like
"IDTOSID UID " instead of "UID ".

This fixes changes of commit b4239ca096738f553b0f9d7fa6aaa4219b72ef7f:
idmap_script: Parallelize script calls

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12194

Signed-off-by: Björn Baumbach 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Michael Adam 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Tue Sep  6 19:32:57 CEST 2016 on sn-devel-144

---

Summary of changes:
 source3/winbindd/idmap_script.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/idmap_script.c b/source3/winbindd/idmap_script.c
index f986021..75eabdf 100644
--- a/source3/winbindd/idmap_script.c
+++ b/source3/winbindd/idmap_script.c
@@ -101,7 +101,7 @@ static struct tevent_req *idmap_script_xid2sid_send(
return tevent_req_post(req, ev);
}
 
-   state->syscmd = talloc_asprintf(state, "%s %cID %lu", script, key,
+   state->syscmd = talloc_asprintf(state, "%s IDTOSID %cID %lu", script, 
key,
(unsigned long)xid.id);
if (tevent_req_nomem(state->syscmd, req)) {
return tevent_req_post(req, ev);


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

[Garming Sam]

The branch, master has been updated
   via  4519077 tests/dns_forwarder: Fail out with an assertion instead OOB 
error
   via  ad3b3e9 tests/dns_forwarder: Check that the subprocess is still 
living
   via  668e4e4 tests/dns_forwarder: Wait for port for 15 seconds
  from  aef1d45 samba-tool: Remove --use-xattrs support without --use-ntvfs

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 451907739cc14717c12875b88fbbe63a53e9cbec
Author: Garming Sam 
Date:   Thu Jun 9 03:52:38 2016 +0200

tests/dns_forwarder: Fail out with an assertion instead OOB error

Signed-off-by: Garming Sam 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Garming Sam 
Autobuild-Date(master): Tue Sep  6 15:41:54 CEST 2016 on sn-devel-144

commit ad3b3e978ebf0692580166f9deba0368a922362d
Author: Garming Sam 
Date:   Thu Jul 7 16:58:27 2016 +1200

tests/dns_forwarder: Check that the subprocess is still living

Signed-off-by: Garming Sam 
Reviewed-by: Andrew Bartlett 

commit 668e4e4a436756d73d64790fd0a7e79fa4769ffe
Author: Garming Sam 
Date:   Tue Sep 6 10:48:57 2016 +1200

tests/dns_forwarder: Wait for port for 15 seconds

Signed-off-by: Garming Sam 
Reviewed-by: Andrew Bartlett 

---

Summary of changes:
 python/samba/tests/dns_forwarder.py | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/python/samba/tests/dns_forwarder.py 
b/python/samba/tests/dns_forwarder.py
index de36de9..51a8619 100644
--- a/python/samba/tests/dns_forwarder.py
+++ b/python/samba/tests/dns_forwarder.py
@@ -185,14 +185,18 @@ class TestDnsForwarding(DNSTest):
  host, str(port), id])
 self.subprocesses.append(p)
 s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM, 0)
-for i in xrange(30):
-time.sleep(0.01)
+for i in xrange(300):
+time.sleep(0.05)
 s.connect((host, port))
 try:
 s.send('timeout 0', 0)
 except socket.error, e:
 if e.errno in (errno.ECONNREFUSED, errno.EHOSTUNREACH):
 continue
+
+if p.returncode is not None:
+self.fail("Toy server has managed to die already!")
+
 return s
 
 def tearDown(self):
@@ -462,8 +466,9 @@ class TestDnsForwarding(DNSTest):
 try:
 data = ad.recv(0x + 2, 0)
 data = ndr.ndr_unpack(dns.name_packet, data)
-self.assertEqual('forwarder1', data.answers[0].rdata)
 self.assert_dns_rcode_equals(data, dns.DNS_RCODE_OK)
+self.assertEqual(len(data.answers), 1)
+self.assertEqual('forwarder1', data.answers[0].rdata)
 except socket.timeout:
 self.fail("DNS server is too slow (timeout %s)" % timeout)
 


-- 
Samba Shared Repository

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-1219/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-1219/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-1219/samba.stdout
  
The top commit at the time of the failure was:

commit aef1d45c9a3af5ac9a5f262604d1f364c397875c
Author: Andrew Bartlett 
Date:   Sun Sep 4 21:33:30 2016 +1200

samba-tool: Remove --use-xattrs support without --use-ntvfs

The only reasonable use --use-xattrs=no should be used is in selftest,
and there is no need for that or --use-xattrs=auto without
--use-ntvfs, all systems we support in production for the AD DC have
xattrs, as using smbd needs posix ACLs.

This also removes the option entirely if NTVFS support is omitted from
the build.

I would prefer to get rid of the option, but currently selftest relies
on the default of --use-xattrs=auto, and we first should get rid of
that auto-detection, which will then mean we need --use-xattrs=no
specified wherever we specify --use-ntvfs.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam 

Autobuild-User(master): Garming Sam 
Autobuild-Date(master): Tue Sep  6 04:21:42 CEST 2016 on sn-devel-144

[SCM] Samba Shared Repository - branch v4-5-test updated

[Stefan Metzmacher]

The branch, v4-5-test has been updated
   via  51a6036 ctdb-tests: Add a test to ensure that CTDB works with no 
eventscripts
   via  af2386b ctdb-tests: Conditionally use temporary config file for 
local daemons
   via  7e0846a ctdb-tests: Factor out function config_from_environment()
   via  8b2e01a ctdb-daemon: Don't steal control structure before 
synchronous reply
   via  d9f5a6a ctdb-daemon: Handle failure immediately, do housekeeping 
later
   via  41ca635 ctdb-daemon: Schedule running of callback if there are no 
event scripts
   via  0ccfa21 dbcheck: Abandon dbcheck if we get an error during a 
transaction
   via  b005b5b dsdb: Allow missing a mandatory attribute from a dbcheck fix
  from  181d050 script/release.sh: use 8 byte gpg key ids

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-5-test


- Log -
commit 51a6036b9539f02c29b76fb3a2ff96d02453d2cf
Author: Martin Schwenke 
Date:   Mon Aug 29 16:52:45 2016 +1000

ctdb-tests: Add a test to ensure that CTDB works with no eventscripts

This only tests something on local daemons, since the configuration
can't be easily manipulated on a real cluster.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12180

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Thu Sep  1 17:15:06 CEST 2016 on sn-devel-144

(cherry picked from commit 625f080f213d03fd4b08e1b6ff9f1415f77ee73b)

Autobuild-User(v4-5-test): Stefan Metzmacher 
Autobuild-Date(v4-5-test): Tue Sep  6 12:18:42 CEST 2016 on sn-devel-144

commit af2386bdc2f0b69acb65701f15352ea14c0f0051
Author: Martin Schwenke 
Date:   Mon Aug 29 16:49:07 2016 +1000

ctdb-tests: Conditionally use temporary config file for local daemons

If there's configuration in the environment then daemons_start()
should use a temporary configuration file with that appended.

This means that global overrides don't (harmlessly) build up in the
configuration file during each test and individual tests can override
configuration when calling daemons_start() directly.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12180

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 
(cherry picked from commit 7885b9652fcb3b30361a8b2e0b4688c261b55065)

commit 7e0846a3b9dddc1adec11f04912cc2d3249d394c
Author: Martin Schwenke 
Date:   Mon Aug 29 16:05:33 2016 +1000

ctdb-tests: Factor out function config_from_environment()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12180

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 
(cherry picked from commit a2bbf71ad67e5c3a6287cf62f54ff13389bf2143)

commit 8b2e01a20656620c63d84c8b02a9a13f41a0fe25
Author: Martin Schwenke 
Date:   Wed Aug 31 08:29:13 2016 +1000

ctdb-daemon: Don't steal control structure before synchronous reply

If *async_reply isn't set then the calling code will reply to the
control and free the control structure.  In some places the control
structure pointer is stolen onto state before a synchronous exit due
to an error condition.  The error handling then frees state and
returns an error.  The calling code will access-after-free when trying
to reply to the control.

To make this easier to understand, the convention is that any
(immediate) error results in a synchronous reply to the control via an
error return code AND *async_reply not being set.  In this case the
control structure pointer should never be stolen onto state.  State is
never used for a synchronous reply, it is only ever used by a
callback.

Also initialise state->c to NULL so that any premature call to a
callback (e.g. in an immediate error path) is more obvious.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12180

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 
(cherry picked from commit 9d975b860d52030a702723c70791c6a2829107c0)

commit d9f5a6ab0fba3c7ba77c93040c7e190877c3573d
Author: Martin Schwenke 
Date:   Fri Aug 26 16:38:56 2016 +1000

ctdb-daemon: Handle failure immediately, do housekeeping later

The callback should never be called before an immediate return.  The
callback might reply to a control and the caller of
ctdb_event_script_callback_v() may not have assigned/stolen the
pointer to control structure into the private data.  Therefore,
calling the callback can dereference an uninitialised pointer to the
control structure when attempting to reply.

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-1132/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-1132/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-09-06-1132/samba.stdout
  
The top commit at the time of the failure was:

commit aef1d45c9a3af5ac9a5f262604d1f364c397875c
Author: Andrew Bartlett 
Date:   Sun Sep 4 21:33:30 2016 +1200

samba-tool: Remove --use-xattrs support without --use-ntvfs

The only reasonable use --use-xattrs=no should be used is in selftest,
and there is no need for that or --use-xattrs=auto without
--use-ntvfs, all systems we support in production for the AD DC have
xattrs, as using smbd needs posix ACLs.

This also removes the option entirely if NTVFS support is omitted from
the build.

I would prefer to get rid of the option, but currently selftest relies
on the default of --use-xattrs=auto, and we first should get rid of
that auto-detection, which will then mean we need --use-xattrs=no
specified wherever we specify --use-ntvfs.

Signed-off-by: Andrew Bartlett 
Reviewed-by: Garming Sam 

Autobuild-User(master): Garming Sam 
Autobuild-Date(master): Tue Sep  6 04:21:42 CEST 2016 on sn-devel-144