autobuild[sn-devel-144]: intermittent test failure detected

2017-10-16 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-16-2110/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-16-2110/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-16-2110/samba.stdout
  
The top commit at the time of the failure was:

commit 2abc1272874a07c987e3e6eb8477925cc84904b9
Author: Anoop C S 
Date:   Mon Oct 16 14:49:41 2017 +0530

docs-xml: Fix a typo in manpage for vfs_fruit

Signed-off-by: Anoop C S 
Reviewed-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Mon Oct 16 15:55:35 CEST 2017 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

2017-10-16 Thread Günther Deschner 
The branch, master has been updated
   via  7917f97 vfs_fruit: Replace closedir() by SMB_VFS_CLOSEDIR
  from  2abc127 docs-xml: Fix a typo in manpage for vfs_fruit

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 7917f9721c9f8efdf9e7b7c50a9e5147250e36fe
Author: Anoop C S 
Date:   Fri Oct 13 20:38:31 2017 +0530

vfs_fruit: Replace closedir() by SMB_VFS_CLOSEDIR

Pointer to directory 'dh' inside fruit_rmdir() is obtained using
SMB_VFS_OPENDIR. But this handle is closed directly by invoking
closedir() rather than SMB_VFS_CLOSEDIR. This will result in a
smbd crash if this handle was not obtained from local file system.
Therefore use SMB_VFS_CLOSEDIR corresponding to SMB_VFS_OPENDIR
to correctly close the directory handle.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13086

Signed-off-by: Anoop C S 
Reviewed-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Mon Oct 16 19:56:55 CEST 2017 on sn-devel-144

---

Summary of changes:
 source3/modules/vfs_fruit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c
index 2771980..b0dd0f0 100644
--- a/source3/modules/vfs_fruit.c
+++ b/source3/modules/vfs_fruit.c
@@ -3785,7 +3785,7 @@ static int fruit_rmdir(struct vfs_handle_struct *handle,
 
 exit_rmdir:
if (dh) {
-   closedir(dh);
+   SMB_VFS_CLOSEDIR(handle->conn, dh);
}
return SMB_VFS_NEXT_RMDIR(handle, smb_fname);
 }


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

2017-10-16 Thread Ralph Böhme 
The branch, master has been updated
   via  2abc127 docs-xml: Fix a typo in manpage for vfs_fruit
  from  71bedfa ctdb-tests: Check an unchecked return value

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 2abc1272874a07c987e3e6eb8477925cc84904b9
Author: Anoop C S 
Date:   Mon Oct 16 14:49:41 2017 +0530

docs-xml: Fix a typo in manpage for vfs_fruit

Signed-off-by: Anoop C S 
Reviewed-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Mon Oct 16 15:55:35 CEST 2017 on sn-devel-144

---

Summary of changes:
 docs-xml/manpages/vfs_fruit.8.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/docs-xml/manpages/vfs_fruit.8.xml 
b/docs-xml/manpages/vfs_fruit.8.xml
index b0cb9f0..48c3acd 100644
--- a/docs-xml/manpages/vfs_fruit.8.xml
+++ b/docs-xml/manpages/vfs_fruit.8.xml
@@ -71,7 +71,7 @@
against Netatalk AFP sharing modes by setting
fruit:locking = netatalk.
 
-   This module is not stackable other then described in
+   This module is not stackable other than described in
this manpage.
 
 


-- 
Samba Shared Repository

[SCM] Samba Shared Repository - branch master updated

2017-10-16 Thread Martin Schwenke 
The branch, master has been updated
   via  71bedfa ctdb-tests: Check an unchecked return value
   via  e0cf8a4 ctdb-test: Fix CID 1419118 (Error handling issues)
   via  9b880de ctdb-client: Fix a typo
   via  a0c5d2e ctdb-tests: Strengthen some tests
   via  1eec318 ctdb-protocol: Fix typo in type of return variable
  from  7d47f75 man pages: properly ident lists

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 71bedfabbfa4d04ff654857094899f6a76e30922
Author: Martin Schwenke 
Date:   Wed Oct 11 19:16:25 2017 +1100

ctdb-tests: Check an unchecked return value

This can't fail but check it for completeness... just in case Coverity
decides to notice it.

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Mon Oct 16 09:27:17 CEST 2017 on sn-devel-144

commit e0cf8a4d0d3d820164d333d8968d4a3b599acd54
Author: Martin Schwenke 
Date:   Wed Oct 11 19:04:28 2017 +1100

ctdb-test: Fix CID 1419118 (Error handling issues)

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke 

commit 9b880defb6f364925ab2b0ebba3158a21ca062a6
Author: Martin Schwenke 
Date:   Tue Oct 10 14:51:40 2017 +1100

ctdb-client: Fix a typo

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke 

commit a0c5d2e2b542754ccb8d8c59396119005ce6c9fd
Author: Martin Schwenke 
Date:   Mon Oct 9 14:56:00 2017 +1100

ctdb-tests: Strengthen some tests

Check for the expected result instead of just any failure.

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke 

commit 1eec3184b6a65e1c1f7417f20c63a31ee4ca01a0
Author: Martin Schwenke 
Date:   Mon Oct 9 14:52:30 2017 +1100

ctdb-protocol: Fix typo in type of return variable

This causes failures to be folded down to 1, which is incorrect.

Signed-off-by: Martin Schwenke 
Reviewed-by: Volker Lendecke 

---

Summary of changes:
 ctdb/client/client_control_sync.c   |  2 +-
 ctdb/protocol/protocol_util.c   |  2 +-
 ctdb/tests/src/fake_ctdbd.c | 16 +---
 ctdb/tests/src/protocol_util_test.c |  6 +++---
 4 files changed, 18 insertions(+), 8 deletions(-)


Changeset truncated at 500 lines:

diff --git a/ctdb/client/client_control_sync.c 
b/ctdb/client/client_control_sync.c
index e4e14b7..e56a2b2 100644
--- a/ctdb/client/client_control_sync.c
+++ b/ctdb/client/client_control_sync.c
@@ -2014,7 +2014,7 @@ int ctdb_ctrl_tcp_add_delayed_update(TALLOC_CTX *mem_ctx,
ret = ctdb_reply_control_tcp_add_delayed_update(reply);
if (ret != 0) {
DEBUG(DEBUG_ERR,
- ("Control TCP_ADD_DELAYED_UDATE failed, ret=%d\n", ret));
+ ("Control TCP_ADD_DELAYED_UPDATE failed, ret=%d\n", ret));
return ret;
}
 
diff --git a/ctdb/protocol/protocol_util.c b/ctdb/protocol/protocol_util.c
index 68a470f..73652e7 100644
--- a/ctdb/protocol/protocol_util.c
+++ b/ctdb/protocol/protocol_util.c
@@ -265,7 +265,7 @@ int ctdb_sock_addr_from_string(const char *str,
unsigned port;
char *endp = NULL;
size_t len;
-   bool ret;
+   int ret;
 
if (! with_port) {
ret = ip_from_string(str, addr);
diff --git a/ctdb/tests/src/fake_ctdbd.c b/ctdb/tests/src/fake_ctdbd.c
index 06b5b22..af56e08 100644
--- a/ctdb/tests/src/fake_ctdbd.c
+++ b/ctdb/tests/src/fake_ctdbd.c
@@ -251,7 +251,11 @@ static bool nodemap_parse(struct node_map *node_map)
}
node = _map->node[node_map->num_nodes];
 
-   ctdb_sock_addr_from_string(ip, >addr, false);
+   ret = ctdb_sock_addr_from_string(ip, >addr, false);
+   if (ret != 0) {
+   fprintf(stderr, "bad line (%s) - invalid IP\n", line);
+   continue;
+   }
ctdb_sock_addr_set_port(>addr, CTDB_PORT);
node->pnn = pnn;
node->flags = flags;
@@ -1962,11 +1966,17 @@ static void control_reload_nodes_file(TALLOC_CTX 
*mem_ctx,
}
 
if (nodemap->node[i].flags & NODE_FLAGS_DELETED) {
+   int ret;
+
node = _map->node[i];
 
node->flags |= NODE_FLAGS_DELETED;
-   ctdb_sock_addr_from_string("0.0.0.0", >addr,
-  false);
+   ret =