autobuild[sn-devel-144]: intermittent test failure detected

2018-04-30 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-01-0629/flakey.log

The failure seems to be in the "ctdb" suite, whose build logs are available 
here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-01-0629/ctdb.stderr
   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-05-01-0629/ctdb.stdout
  
The top commit at the time of the failure was:

commit aefe444d17a2eee3c0ff38bd34cf9e3f012ecf51
Author: Jeremy Allison 
Date:   Fri Apr 27 14:25:54 2018 -0700

ceph: VFS: Add asynchronous fsync to ceph module, fake using synchronous 
call.

This will allow me to ultimately simplify the VFS by removing the 
synchronous
fsync VFS call.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13412

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Mon Apr 30 21:48:55 CEST 2018 on sn-devel-144

and the last 50 lines of the stdout log were:

 PASSED  tests/tool/ctdb.unban.003.sh
 PASSED  tests/tool/ctdb.uptime.001.sh
 PASSED  tests/tool/ctdb.writekey.001.sh
 PASSED  tests/simple/00_ctdb_init.sh
 PASSED  tests/simple/00_ctdb_onnode.sh
 PASSED  tests/simple/01_ctdb_version.sh
 PASSED  tests/simple/02_ctdb_listvars.sh
 PASSED  tests/simple/03_ctdb_getvar.sh
 PASSED  tests/simple/04_ctdb_setvar.sh
 PASSED  tests/simple/05_ctdb_listnodes.sh
 PASSED  tests/simple/06_ctdb_getpid.sh
 PASSED  tests/simple/07_ctdb_process_exists.sh
 PASSED  tests/simple/08_ctdb_isnotrecmaster.sh
 PASSED  tests/simple/09_ctdb_ping.sh
 PASSED  tests/simple/11_ctdb_ip.sh
 PASSED  tests/simple/12_ctdb_getdebug.sh
 PASSED  tests/simple/13_ctdb_setdebug.sh
 PASSED  tests/simple/14_ctdb_statistics.sh
 PASSED  tests/simple/15_ctdb_statisticsreset.sh
 PASSED  tests/simple/16_ctdb_config_add_ip.sh
 PASSED  tests/simple/17_ctdb_config_delete_ip.sh
 PASSED  tests/simple/18_ctdb_reloadips.sh
 PASSED  tests/simple/19_ip_takeover_noop.sh
 PASSED  tests/simple/20_delip_iface_gc.sh
 PASSED  tests/simple/21_ctdb_attach.sh
 PASSED  tests/simple/23_ctdb_moveip.sh
 PASSED  tests/simple/24_ctdb_getdbmap.sh
 PASSED  tests/simple/25_dumpmemory.sh
 PASSED  tests/simple/26_ctdb_config_check_error_on_unreachable_ctdb.sh
 PASSED  tests/simple/27_ctdb_detach.sh
 PASSED  tests/simple/28_zero_eventscripts.sh
 PASSED  tests/simple/31_ctdb_disable.sh
 PASSED  tests/simple/32_ctdb_enable.sh
 PASSED  tests/simple/35_ctdb_getreclock.sh
 PASSED  tests/simple/41_ctdb_stop.sh
 PASSED  tests/simple/42_ctdb_continue.sh
 PASSED  tests/simple/43_stop_recmaster_yield.sh
 PASSED  tests/simple/51_message_ring.sh
 PASSED  tests/simple/52_fetch_ring.sh
 PASSED  tests/simple/53_transaction_loop.sh
 PASSED  tests/simple/54_transaction_loop_recovery.sh
 PASSED  tests/simple/55_ctdb_ptrans.sh
 PASSED  tests/simple/56_replicated_transaction_recovery.sh
 PASSED  tests/simple/58_ctdb_restoredb.sh
*FAILED* tests/simple/60_recoverd_missing_ip.sh

522/523 tests passed

Removing TEST_VAR_DIR=/memdisk/autobuild/fl/b90844/ctdb/ctdb/tests/var
autotest exited with exit status 1

[SCM] Samba Shared Repository - branch master updated

2018-04-30 Thread Ralph Böhme 
The branch, master has been updated
   via  aefe444 ceph: VFS: Add asynchronous fsync to ceph module, fake 
using synchronous call.
  from  268ad19 python/samba: Py2/Py3 compat change '/' to '//' to ensure 
int result

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit aefe444d17a2eee3c0ff38bd34cf9e3f012ecf51
Author: Jeremy Allison 
Date:   Fri Apr 27 14:25:54 2018 -0700

ceph: VFS: Add asynchronous fsync to ceph module, fake using synchronous 
call.

This will allow me to ultimately simplify the VFS by removing the 
synchronous
fsync VFS call.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13412

Signed-off-by: Jeremy Allison 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Mon Apr 30 21:48:55 CEST 2018 on sn-devel-144

---

Summary of changes:
 source3/modules/vfs_ceph.c | 53 ++
 1 file changed, 53 insertions(+)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_ceph.c b/source3/modules/vfs_ceph.c
index d612131..656ce57 100644
--- a/source3/modules/vfs_ceph.c
+++ b/source3/modules/vfs_ceph.c
@@ -37,6 +37,7 @@
 #include "cephfs/libcephfs.h"
 #include "smbprofile.h"
 #include "modules/posixacl_xattr.h"
+#include "lib/util/tevent_unix.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_VFS
@@ -569,6 +570,56 @@ static int cephwrap_fsync(struct vfs_handle_struct 
*handle, files_struct *fsp)
WRAP_RETURN(result);
 }
 
+/*
+ * Fake up an async ceph fsync by calling the sychronous API.
+ */
+
+static struct tevent_req *cephwrap_fsync_send(struct vfs_handle_struct *handle,
+   TALLOC_CTX *mem_ctx,
+   struct tevent_context *ev,
+   files_struct *fsp)
+{
+   struct tevent_req *req = NULL;
+   struct vfs_aio_state *state = NULL;
+   int ret = -1;
+
+   DBG_DEBUG("[CEPH] cephwrap_fsync_send\n");
+
+   req = tevent_req_create(mem_ctx, , struct vfs_aio_state);
+   if (req == NULL) {
+   return NULL;
+   }
+
+   /* Make sync call. */
+   ret = ceph_fsync(handle->data, fsp->fh->fd, false);
+
+   if (ret != 0) {
+   /* ceph_fsync returns -errno on error. */
+   tevent_req_error(req, -ret);
+   return tevent_req_post(req, ev);
+   }
+
+   /* Mark it as done. */
+   tevent_req_done(req);
+   /* Return and schedule the completion of the call. */
+   return tevent_req_post(req, ev);
+}
+
+static int cephwrap_fsync_recv(struct tevent_req *req,
+   struct vfs_aio_state *vfs_aio_state)
+{
+   struct vfs_aio_state *state =
+   tevent_req_data(req, struct vfs_aio_state);
+
+   DBG_DEBUG("[CEPH] cephwrap_fsync_recv\n");
+
+   if (tevent_req_is_unix_error(req, _aio_state->error)) {
+   return -1;
+   }
+   *vfs_aio_state = *state;
+   return 0;
+}
+
 #ifdef HAVE_CEPH_STATX
 #define SAMBA_STATX_ATTR_MASK  (CEPH_STATX_BASIC_STATS|CEPH_STATX_BTIME)
 
@@ -1440,6 +1491,8 @@ static struct vfs_fn_pointers ceph_fns = {
.recvfile_fn = cephwrap_recvfile,
.rename_fn = cephwrap_rename,
.fsync_fn = cephwrap_fsync,
+   .fsync_send_fn = cephwrap_fsync_send,
+   .fsync_recv_fn = cephwrap_fsync_recv,
.stat_fn = cephwrap_stat,
.fstat_fn = cephwrap_fstat,
.lstat_fn = cephwrap_lstat,


-- 
Samba Shared Repository

autobuild[sn-devel-144]: intermittent test failure detected

2018-04-30 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-04-30-1939/flakey.log

The failure seems to be in the "samba" suite, whose build logs are available 
here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-04-30-1939/samba.stderr
   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-04-30-1939/samba.stdout
  
The top commit at the time of the failure was:

commit a23d80547545f1d367ef446d6d7173999ca4e97c
Author: Martin Schwenke 
Date:   Mon Apr 30 12:07:48 2018 +1000

ctdb-tests: Fix a typo

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Mon Apr 30 14:26:43 CEST 2018 on sn-devel-144

and the last 50 lines of the stdout log were:

badPasswordTime = '131695834115749660'
logonCount = '0'
lastLogon = '131695834097903280'
lastLogonTimestamp = '131695834097903280'
userAccountControl = '512'
msDS-User-Account-Control-Computed = '16'
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
badPwdCount = '3'
lockoutTime = '131695834115749660'
badPasswordTime = '131695834115749660'
logonCount = '0'
lastLogon = '131695834097903280'
lastLogonTimestamp = '131695834097903280'
userAccountControl = '512'
msDS-User-Account-Control-Computed = '16'
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
badPwdCount = '3'
lockoutTime = '131695834115749660'
badPasswordTime = '131695834115749660'
logonCount = '0'
lastLogon = '131695834097903280'
lastLogonTimestamp = '131695834097903280'
userAccountControl = '512'
msDS-User-Account-Control-Computed = '16'
UNEXPECTED(failure): 
samba4.ldap.password_lockout.python(ad_dc_ntvfs).__main__.PasswordTests.test_userPassword_lockout_with_clear_change_ntlm_ldap_lockoutTime(ad_dc_ntvfs)
REASON: Exception: Exception: Traceback (most recent call last):
  File 
"/memdisk/autobuild/fl/b1743336/samba/source4/dsdb/tests/python/password_lockout.py",
 line 574, in test_userPassword_lockout_with_clear_change_ntlm_ldap_lockoutTime
initial_lastlogon_relation='greater')
  File 
"/memdisk/autobuild/fl/b1743336/samba/source4/dsdb/tests/python/password_lockout.py",
 line 319, in _test_userPassword_lockout_with_clear_change
msDSUserAccountControlComputed=dsdb.UF_LOCKOUT)
  File 
"/memdisk/autobuild/fl/b1743336/samba/source4/dsdb/tests/python/password_lockout_base.py",
 line 180, in _check_account
self.assertEquals(uinfo5.bad_password_count, effective_bad_password_count)
AssertionError: 0 != 3

FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)

A summary with detailed information can be found in:
  ./bin/ab/summary
TOP 10 slowest tests
samba4.ldap.vlv.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 783
samba4.ldap.rodc_rwdc.python(rodc)(rodc:local) -> 437
samba4.rpc.samr.passwords.lockout on ncacn_np with (ad_dc_ntvfs) -> 224
samba4.rpc.samr.passwords.pwdlastset on ncacn_np with (ad_dc_ntvfs) -> 200
samba3.smbtorture_s3.vfs_aio_fork(simpleserver).RW2(simpleserver) -> 137
samba4.ldap.secdesc.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 127
samba4.raw.notify(ad_dc_ntvfs) -> 107
samba4.ldb.ldaps with options -U"$USERNAME%$PASSWORD"(ad_dc_ntvfs)(ad_dc_ntvfs) 
-> 101
samba4.ldap.dirsync.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 97
samba4.ldap.acl.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 83
ERROR: test failed with exit code 1

[SCM] Samba Shared Repository - branch master updated

2018-04-30 Thread Noel Power 
The branch, master has been updated
   via  268ad19 python/samba: Py2/Py3 compat change '/' to '//' to ensure 
int result
   via  141d908 python/samba: port some isinstance str checks (to cater for 
unicode)
   via  b54472f python: Bulk conversion callers of ldb.Dn second param
   via  13280d3 python/samba: bulk conversion of caller to dsdb_Dn 2nd 
param.
   via  cbd6786 python/samba: Add binary_type for p2/p3 testing.
   via  d331ddf Add aliases for StringIO.StringIO
   via  d2ee36e python/samba: Add some compatability PY2/PY3 functions
   via  ba5f00d s4/param: Additionally accept unicode as string param in Py2
   via  5c12935 s4/librpc: Additionally accept unicode as string param in 
Py2
   via  5055b54 s4/dsdb: Additionally accept unicode as string param in Py2
   via  3544f1b s4/auth: Additionally accept unicode as string param in Py2
   via  7020af4 libcli/nbt: Additionally accept unicode as string param in 
Py2
   via  702e85e lib/tevent: Additionally accept unicode as string param in 
Py2
   via  db8da07 lib/ldb: Additionally accept unicode as string param in Py2
   via  f477a75 samba-tool visualize: use correct DC in graph label
  from  a23d805 ctdb-tests: Fix a typo

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 268ad19eee469ef7d703d5b9610683aca874fa9f
Author: Noel Power 
Date:   Fri Apr 27 08:15:28 2018 +0100

python/samba: Py2/Py3 compat change '/' to '//' to ensure int result

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Mon Apr 30 18:25:25 CEST 2018 on sn-devel-144

commit 141d9081f4715b6c0ef439f34ca3b79fbddac1dd
Author: Noel Power 
Date:   Thu Apr 26 10:38:57 2018 +0100

python/samba: port some isinstance str checks (to cater for unicode)

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy 

commit b54472f868dc491579b471db6c6660bb03ab51c3
Author: Noel Power 
Date:   Wed Apr 25 20:01:49 2018 +0100

python: Bulk conversion callers of ldb.Dn second param

Convert second param passed to ldb.Dn to be unicode so py2 & py3 code
will work

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy 

commit 13280d3db9fdbbd87c6ed2faa69b24bc7660674d
Author: Noel Power 
Date:   Wed Apr 25 18:28:30 2018 +0100

python/samba: bulk conversion of caller to dsdb_Dn 2nd param.

Convert second param to dsdb_Dn to be unicode so py2 & py3 code
will work

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy 

commit cbd6786c0471782024750b85b6f4fbf42977c81b
Author: Noel Power 
Date:   Tue Apr 24 16:28:41 2018 +0100

python/samba: Add binary_type for p2/p3 testing.

For helping test for binary types, binary_type evaluates to 'str'
in py2, and 'bytes' in py3.

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy 

commit d331ddf47f7b0ee360a8c7a61e0b38d279ecbd48
Author: Noel Power 
Date:   Tue Apr 17 13:52:58 2018 +0100

Add aliases for StringIO.StringIO

cStringIO doesn't handle unicode, StringIO does. With py2/py3
compatable code we can easily find ourselves getting passed
unicode so we don't alias cStringIO

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy 

commit d2ee36e350108a226a3d3dc641a067c9eed4897d
Author: Noel Power 
Date:   Fri Apr 13 11:19:10 2018 +0100

python/samba: Add some compatability PY2/PY3 functions

I hope these changes are a short term interim solution for the
absence of the 'six' module/library. I also hope that soon this
module can be removed and be replaced by usage of six.

Signed-off-by: Noel Power 
Reviewed-by: Alexander Bokovoy 

commit ba5f00deb772b76719bfd06467a6b05edfeef061
Author: Noel Power 
Date:   Fri Apr 13 17:34:40 2018 +0100

s4/param: Additionally accept unicode as string param in Py2

With the changes to make samba python code Py2/Py3 compatible there
now are many instances where string content is decoded.
Decoded string variables in Py2 are returned as the unicode type. Many
Py2 c-module functions that take string arguments only check for the
string type. However now it's quite possibe the content formally passed
as a string argument is now passed as unicode after being decoded,
such arguments are rejected and code can fail subtly. This only affects
places

[SCM] Samba Shared Repository - branch master updated

2018-04-30 Thread Amitay Isaacs 
The branch, master has been updated
   via  a23d805 ctdb-tests: Fix a typo
   via  693ca7b ctdb-tests: Simplify a test
  from  110e72c ctdb-scripts: Drop CTDB_RC_LOCAL testing hook

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit a23d80547545f1d367ef446d6d7173999ca4e97c
Author: Martin Schwenke 
Date:   Mon Apr 30 12:07:48 2018 +1000

ctdb-tests: Fix a typo

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Mon Apr 30 14:26:43 CEST 2018 on sn-devel-144

commit 693ca7b99e6b2bcce5a3a9c375a2c7e83a053894
Author: Martin Schwenke 
Date:   Tue Feb 27 06:40:59 2018 +1100

ctdb-tests: Simplify a test

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

---

Summary of changes:
 ctdb/tests/simple/03_ctdb_getvar.sh|  2 +-
 ctdb/tests/simple/20_delip_iface_gc.sh | 14 ++
 2 files changed, 7 insertions(+), 9 deletions(-)


Changeset truncated at 500 lines:

diff --git a/ctdb/tests/simple/03_ctdb_getvar.sh 
b/ctdb/tests/simple/03_ctdb_getvar.sh
index a58aa3b..cae3dd1 100755
--- a/ctdb/tests/simple/03_ctdb_getvar.sh
+++ b/ctdb/tests/simple/03_ctdb_getvar.sh
@@ -36,7 +36,7 @@ cluster_is_healthy
 
 try_command_on_node -v 0 "$CTDB listvars"
 
-echo "Veryifying all variable values using \"ctdb getvar\"..."
+echo "Verifying all variable values using \"ctdb getvar\"..."
 
 echo "$out" |
 while read var x val ; do
diff --git a/ctdb/tests/simple/20_delip_iface_gc.sh 
b/ctdb/tests/simple/20_delip_iface_gc.sh
index 8ad001f..e73eed2 100755
--- a/ctdb/tests/simple/20_delip_iface_gc.sh
+++ b/ctdb/tests/simple/20_delip_iface_gc.sh
@@ -18,14 +18,12 @@ cluster_is_healthy
 # Reset configuration
 ctdb_restart_when_done
 
-echo "Getting public IPs information..."
-try_command_on_node -v any "$CTDB ip -v all -X | tail -n +2"
-ip_info="$out"
-
-# Select the first node and find out its interfaces
-test_node=$(awk -F'|' 'NR == 1 { print $3}' <<<"$ip_info")
-ifaces=$(awk -F'|' -v tn=$test_node '$3 == tn { print $6 }' <<<"$ip_info" | 
sed 's@, @ @g' | xargs -n 1 | sort -u)
-echo "Selected test node ${test_node} with interfaces: ${ifaces}"
+select_test_node_and_ips
+
+# Find interfaces on test node
+try_command_on_node $test_node "$CTDB ifaces -X"
+ifaces=$(awk -F'|' 'NR > 1 { print $2 }' <<<"$out")
+echo "Node ${test_node} has interfaces: ${ifaces}"
 
 # Delete all IPs on each interface...  deleting IPs from one interface
 # can cause other interfaces to disappear, so we need to be careful...


-- 
Samba Shared Repository