[SCM] Samba Shared Repository - branch master updated

2018-11-06 Thread Douglas Bagnall
The branch, master has been updated
   via  3ca1399 selftest: Add some more testenv descriptions
   via  5870c64 selftest: Add README documenting the customdc testenv
  from  8d787f7 tdb: Align integer types

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 3ca13997e5017fb00032c6044d8dc8eab2a13221
Author: Tim Beale 
Date:   Mon Nov 5 14:45:34 2018 +1300

selftest: Add some more testenv descriptions

This still doesn't cover all the testenvs comprehensively, but it
pretty much exhausts my knowledge of what the various testenvs do.

Signed-off-by: Tim Beale 
Reviewed-by: Douglas Bagnall 

Autobuild-User(master): Douglas Bagnall 
Autobuild-Date(master): Wed Nov  7 04:39:05 CET 2018 on sn-devel-144

commit 5870c642cea94de1e7231678d033dfbb0cb83b8e
Author: Tim Beale 
Date:   Mon Nov 5 13:41:08 2018 +1300

selftest: Add README documenting the customdc testenv

Also documented the other backup/restore testenvs as well.

Signed-off-by: Tim Beale 
Reviewed-by: Douglas Bagnall 

---

Summary of changes:
 selftest/target/README | 93 ++
 1 file changed, 93 insertions(+)
 create mode 100644 selftest/target/README


Changeset truncated at 500 lines:

diff --git a/selftest/target/README b/selftest/target/README
new file mode 100644
index 000..28a8d00
--- /dev/null
+++ b/selftest/target/README
@@ -0,0 +1,93 @@
+Selftest target environments (testenvs)
+===
+Samba's integration testing heavily relies on the automatic creation of a Samba
+network. This specialized test environment is generally referred to as a Samba
+'testenv'.
+
+A testenv involves starting the Samba server listening on a fake network, which
+is established using the socket_wrapper library from cwrap (https://cwrap.org).
+All testing is also done as a non-root user using the uid_wrapper library, also
+from cwrap.
+
+Samba's test framework uses many different types of testenv. Each testenv is
+customized to test a particular Samba feature or configuration. Using cwrap
+allows multiple different Samba servers to run at the same time, without
+interference.
+
+Some of the different testenvs are described in more detail below.
+
+'local' disambiguation
+--
+You may notice some variation in the target testenv that test suites are run
+against, for example "ad_dc" and "ad_dc:local". The main difference is the
+":local" changes the smb.conf that the testenv uses. By default, the testenvs
+use the st/client/client.conf config-file, so that they simulate a client
+talking to the Samba server. However, some tests may want to simulate running
+a command on the Samba server itself. In these cases, the ":local" is used,
+which means the testenv uses the Samba server's smb.conf instead (i.e.
+st/ad_dc/etc/smb.conf).
+
+Note that several of the testenvs also use local in their name, e.g.
+'localvampiredc'. In particular, there's the 'localdc', which is the NetBIOS
+name of the DC in the 'ad_dc_ntvfs' testenv.
+
+Vampire DC
+--
+Vampire DC gets its name for historic reasons. It's one of the few testenvs
+where 2 DCs are joined together, so it's used for a lot of DRS replication
+testing. Basically its main job is to 'suck' the database changes out of
+another DC (the 'ad_dc_ntfvs' DC).
+
+There's also a 'vampire_2000_dc' that joins the 'fl2000dc' DC, although that's
+not used very much.
+
+Backup/restore testenvs
+---
+Several testenvs are created to test the domain backup/restore commands. These
+testenvs verify that we can backup and restore a domain's database, start
+Samba against it, and the restored database is actually functional. There are
+several different flavours of backups (to cover different use-cases), so there
+are separate testenvs for each one.
+
+- backupfromdc: A fairly plain AD DC used as the base to generate the
+backup-files. These backup-files will then seed the domain database
+for the separate testenvs below.
+Backupfromdc's other unique feature is that it's the only testenv that gets
+provisioned with a non-default site, i.e. Default-First-Site-Name doesn't
+exist.
+- restoredc: tests the 'backup online' option. Online backups are similar to
+doing a DC join.
+- offlinebackupdc: tests the 'backup offline' option. Offline backups capture
+the raw DB files on disk (safely).
+- renamedc: tests the 'backup rename' option, where the domain and realm are
+renamed.
+- labdc: one of the use-cases for the backup tool is to create a realistic
+pre-production testbed, based off a production DC. This testenv simulates
+that process. It uses the 'backup rename --no-secrets' option.
+
+customdc testenv
+
+The customdc is a special testenv that's 

autobuild[sn-devel-144]: intermittent test failure detected

2018-11-06 Thread autobuild
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-11-07-0136/flakey.log

The failure seems to be in the "samba" suite, whose build logs are available 
here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-11-07-0136/samba.stderr
   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-11-07-0136/samba.stdout
  
The top commit at the time of the failure was:

commit 8d787f73bbcaff181583eadb9b15dcaf863c032c
Author: Volker Lendecke 
Date:   Sat Nov 3 10:11:26 2018 +0100

tdb: Align integer types

tdb->max_dead_records is "int", as is the corresponding parameter to
tdb_set_max_dead(). Not that a signed variable makes any sense, but
this is old code and tdb_set_max_dead() is a public API which we
should not change for this.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Nov  6 21:52:32 CET 2018 on sn-devel-144

and the last 50 lines of the stdout log were:

[751(4035)/850 at 52m54s] samba.tests.blackbox.traffic_replay(ad_dc_ntvfs)
[752(4041)/850 at 53m6s] samba.tests.blackbox.traffic_learner(ad_dc_ntvfs)
[753(4043)/850 at 53m7s] samba.tests.blackbox.traffic_summary(ad_dc_ntvfs)
[754(4043)/850 at 53m7s] samba.tests.blackbox.smbcontrol(ad_dc_ntvfs:local)
[755(4045)/850 at 53m9s] samba.tests.blackbox.smbcontrol(promoted_dc:local)
[756(4047)/850 at 53m10s] samba4.ldap.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[757(4086)/850 at 53m22s] 
samba4.tokengroups.krb5.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[758(4096)/850 at 53m31s] 
samba4.tokengroups.ntlm.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[759(4105)/850 at 53m39s] samba4.sam.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[760(4122)/850 at 53m43s] 
samba4.user_account_control.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[761(4133)/850 at 53m56s] samba4.schemaInfo.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[762(4135)/850 at 53m59s] samba.tests.dsdb_schema_attributes(ad_dc_ntvfs:local)
[763(4141)/850 at 54m13s] 
samba4.urgent_replication.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[764(4149)/850 at 54m16s] samba4.ldap.dirsync.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[765(4173)/850 at 55m48s] samba4.ldap.match_rules.python(ad_dc_ntvfs)
[766(4207)/850 at 56m5s] 
samba4.ldap.notification.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[767(4210)/850 at 56m10s] samba4.ldap.sites.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[768(4221)/850 at 56m16s] samba4.ldap.sort.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[769(4228)/850 at 56m21s] samba4.ldap.vlv.python(ad_dc_ntvfs)(ad_dc_ntvfs)
[770(4243)/850 at 1h16s] 
samba4.ldap.linked_attributes.python(ad_dc_ntvfs)(ad_dc_ntvfs:local)
[771(4263)/850 at 1h21s] samba4.ldap.rodc.python(rodc)(rodc)
[772(4269)/850 at 1h25s] samba4.ldap.rodc_rwdc.python(rodc)(rodc:local)
[773(4289)/850 at 1h7m59s] samba4.drs.replica_sync_rodc.python(rodc)(rodc:local)
[774(4291)/850 at 1h8m7s] samba4.ldap.passwordsettings.python(ad_dc_ntvfs)
[775(4303)/850 at 1h8m45s] samba4.ldap_schema.python(ad_dc_ntvfs)(ad_dc_ntvfs)
GSS client Update(krb5)(1) Update failed:  Miscellaneous failure (see text): 
Clock skew too great
UNEXPECTED(error): 
samba4.ldap_schema.python(ad_dc_ntvfs).__main__.SchemaTests.test_generated_mAPIID(ad_dc_ntvfs)
REASON: Exception: Exception: Traceback (most recent call last):
  File 
"/memdisk/autobuild/fl/b2160726/samba/source4/dsdb/tests/python/ldap_schema.py",
 line 1162, in test_generated_mAPIID
self.ldb.modify_ldif(ldif)
  File "bin/python/samba/__init__.py", line 241, in modify_ldif
self.modify(msg, controls)
LdbError: (3, 'ldb_wait from (null) with LDB_WAIT_ALL: Time limit exceeded (3)')

FAILED (0 failures, 1 errors and 0 unexpected successes in 0 testsuites)

A summary with detailed information can be found in:
  ./bin/ab/summary
TOP 10 slowest tests
samba4.ldap.rodc_rwdc.python(rodc)(rodc:local) -> 453
samba4.ldap.vlv.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 235
samba4.rpc.samr.passwords.lockout on ncacn_np with (ad_dc_ntvfs) -> 226
samba4.rpc.samr.passwords.pwdlastset on ncacn_np with (ad_dc_ntvfs) -> 200
samba3.smbtorture_s3.vfs_aio_fork(simpleserver).RW2(simpleserver) -> 143
samba4.ldb.ldaps with options -U"$USERNAME%$PASSWORD"(ad_dc_ntvfs)(ad_dc_ntvfs) 
-> 115
samba4.raw.notify(ad_dc_ntvfs) -> 106
samba4.ldap.dirsync.python(ad_dc_ntvfs)(ad_dc_ntvfs) -> 91
samba.tests.emulate.traffic_packet(ad_dc_ntvfs) -> 68
samba.tests.samba_tool.user(ad_dc_ntvfs:local) -> 65
ERROR: test failed with exit code 1



[SCM] Samba Shared Repository - branch master updated

2018-11-06 Thread Jeremy Allison
The branch, master has been updated
   via  8d787f7 tdb: Align integer types
   via  608df97 gencache: Prune expired entries
   via  c13eb55 gencache: Wipe corrupt databases
   via  1386200 gencache: Remove transaction-based tdb
   via  a1e13b4 gencache: Add crc check
   via  0d7f67f gencache: Convert to a binary timestamp
   via  72ec893 tdb: Allow !CLEAR_IF_FIRST & MUTEX_LOCKING
   via  e814fb6 tdb: Version 1.3.17 for tdb_traverse_chain
   via  3daf9c8 tdb: Add test for tdb_traverse_chain
   via  46a87f2 tdb: Add tdb_traverse_chain
  from  6e16e95 ctdb-daemon: Do not fork when CTDB_TEST_MODE is set

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 8d787f73bbcaff181583eadb9b15dcaf863c032c
Author: Volker Lendecke 
Date:   Sat Nov 3 10:11:26 2018 +0100

tdb: Align integer types

tdb->max_dead_records is "int", as is the corresponding parameter to
tdb_set_max_dead(). Not that a signed variable makes any sense, but
this is old code and tdb_set_max_dead() is a public API which we
should not change for this.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Nov  6 21:52:32 CET 2018 on sn-devel-144

commit 608df97d5dbc4e56456b83a28e3b2251a9aa4007
Author: Volker Lendecke 
Date:   Wed Oct 24 10:51:40 2018 +0200

gencache: Prune expired entries

This solves the problem that gencache never shrinks right
now. Whenever we write an entry, we now walk that entry's chain and
delete expired entries. This should be a good balance between
performance and cleanup actions: Reading is still unaffected, and
those who write pay a small penalty while keeping gencache size under
control.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit c13eb55253a00d9472c749ccf58dd13e0efd1518
Author: Volker Lendecke 
Date:   Fri Nov 2 16:58:53 2018 +0100

gencache: Wipe corrupt databases

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 1386200be5c583c680c3894a11688a0e0a3d2285
Author: Volker Lendecke 
Date:   Thu Oct 11 12:52:40 2018 +0200

gencache: Remove transaction-based tdb

At more than one large site I've seen significant problems due to
gencache_stabilize. gencache_stabilize was mainly introduced to
survive machine crashes with the cache still being in place. Given
that most installations crash rarely and this is still a cache, this
safety is overkill and causes real problems.

With the recent changes to tdb, we should be safe enough to run on
completely corrupted databases and properly detect errors. A further
commit will introduce code that wipes the gencache.tdb if such a
corruption is detected.

There is one kind of corruption that we don't properly handle:
Orphaned space in the database. I don't have a good idea yet how to
handle this in a graceful and efficient way during normal operations,
but maybe this idea pops up at some point.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit a1e13b4a5dd98bd13790c52e5745b8d04e1bda15
Author: Volker Lendecke 
Date:   Wed Oct 10 16:53:10 2018 +0200

gencache: Add crc check

This covers key, timestamp and data. This will detect silent
corruption of gencache data after a system crash

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 0d7f67f07cd96943dfe58e91254145e28e047ace
Author: Volker Lendecke 
Date:   Wed Oct 10 16:12:28 2018 +0200

gencache: Convert to a binary timestamp

Two reasons:

The ascii conversion shows up on profiles.

In a further commit we will get checksums for gencache entries to
protect at hidden corruption due to a crash on the non-transactioned
gencache.tdb. Next to the timestamp this is a second field that is
gencache metadata, and I don't want to deal with a second ascii number
when at least some of the gencache values are binary already.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 72ec893d0aaa518a2cf22aa68b16c3907a17dfc8
Author: Volker Lendecke 
Date:   Mon Oct 22 08:57:00 2018 +0200

tdb: Allow !CLEAR_IF_FIRST & MUTEX_LOCKING

This is a prerequisite to allow gencache to run on a non-transactioned
database with mutexes.

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit e814fb6bcba8687dafb7d0d1654df8225b2e6229
Author: Volker Lendecke 
Date:   Mon Oct 29 07:43:43 2018 +0100

tdb: Version 1.3.17 for tdb_traverse_chain

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

commit 3daf9c85b742ec9365faa123e38e23a0d80a69a0
Author: Volker Lendecke 
Date:   Sun Oct 7 22:03:09 2018 +0200

tdb: Add test for tdb_traverse_chain


autobuild[sn-devel-144]: intermittent test failure detected

2018-11-06 Thread autobuild
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-11-06-1808/flakey.log

The failure seems to be in the "ctdb" suite, whose build logs are available 
here:

   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-11-06-1808/ctdb.stderr
   
https://git.samba.org/autobuild.flakey.sn-devel-144/2018-11-06-1808/ctdb.stdout
  
The top commit at the time of the failure was:

commit 6e16e95f74c06bf381db666007a30ecb0e1ff7ce
Author: Martin Schwenke 
Date:   Thu Oct 18 18:02:13 2018 +1100

ctdb-daemon: Do not fork when CTDB_TEST_MODE is set

Explicitly background ctdbd instead.

This has the advantage of leaving stdin open.  ctdbd can then be
enhanced to exit when stdin closes, allowing better cleanup in a test
environment.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Tue Nov  6 10:30:14 CET 2018 on sn-devel-144

and the last 50 lines of the stdout log were:

 PASSED  tests/cunit/config_test_005.sh
 PASSED  tests/cunit/config_test_006.sh
 PASSED  tests/cunit/config_test_007.sh
 PASSED  tests/cunit/conf_test_001.sh
 PASSED  tests/cunit/db_hash_test_001.sh
 PASSED  tests/cunit/event_protocol_test_001.sh
 PASSED  tests/cunit/event_script_test_001.sh
 PASSED  tests/cunit/hash_count_test_001.sh
 PASSED  tests/cunit/line_test_001.sh
 PASSED  tests/cunit/path_tests_001.sh
 PASSED  tests/cunit/pidfile_test_001.sh
 PASSED  tests/cunit/pkt_read_001.sh
 PASSED  tests/cunit/pkt_write_001.sh
 PASSED  tests/cunit/porting_tests_001.sh
 PASSED  tests/cunit/protocol_test_001.sh
 PASSED  tests/cunit/protocol_test_002.sh
 PASSED  tests/cunit/protocol_test_012.sh
 PASSED  tests/cunit/protocol_test_101.sh
 PASSED  tests/cunit/protocol_test_111.sh
 PASSED  tests/cunit/protocol_test_201.sh
 PASSED  tests/cunit/rb_test_001.sh
 PASSED  tests/cunit/reqid_test_001.sh
 PASSED  tests/cunit/run_event_001.sh
 PASSED  tests/cunit/run_proc_001.sh
 PASSED  tests/cunit/sock_daemon_test_001.sh
 PASSED  tests/cunit/sock_io_test_001.sh
 PASSED  tests/cunit/srvid_test_001.sh
 PASSED  tests/cunit/system_socket_test_001.sh
 PASSED  tests/eventd/eventd_001.sh
 PASSED  tests/eventd/eventd_002.sh
 PASSED  tests/eventd/eventd_003.sh
 PASSED  tests/eventd/eventd_004.sh
 PASSED  tests/eventd/eventd_005.sh
 PASSED  tests/eventd/eventd_006.sh
 PASSED  tests/eventd/eventd_007.sh
 PASSED  tests/eventd/eventd_008.sh
 PASSED  tests/eventd/eventd_009.sh
 PASSED  tests/eventd/eventd_011.sh
 PASSED  tests/eventd/eventd_012.sh
 PASSED  tests/eventd/eventd_013.sh
 PASSED  tests/eventd/eventd_014.sh
 PASSED  tests/eventd/eventd_021.sh
 PASSED  tests/eventd/eventd_022.sh
 PASSED  tests/eventd/eventd_023.sh
*FAILED* tests/eventd/eventd_024.sh

51/52 tests passed

Removing TEST_VAR_DIR=/memdisk/autobuild/fl/b3717937/ctdb/ctdb/tests/var
autotest exited with exit status 1



[SCM] Socket Wrapper Repository - branch master updated

2018-11-06 Thread Andreas Schneider
The branch, master has been updated
   via  efbb27d gitlab-ci: Enable freebsd runner
   via  9c0931b tests: Disable failing tests as on FreeBSD
   via  38704a9 cmake: Create a list with required libraries
   via  db7070c tests: Protect IPv6 function in setup_echo_srv_tcp_ipv6
   via  f690f8c tests: Protect IPv6 case in echo_srv
   via  fb4df59 swrap: Protect IPv6 case in swrap_socket()
  from  916ce9c cmake: Don't use string PREPEND

https://git.samba.org/?p=socket_wrapper.git;a=shortlog;h=master


- Log -
commit efbb27d464afbf97e5f4b83d51f521028391a45b
Author: Andreas Schneider 
Date:   Tue Oct 30 13:01:27 2018 +0100

gitlab-ci: Enable freebsd runner

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

commit 9c0931bf0ba7d3a08fe6428fa891d36d6c2130c7
Author: Andreas Schneider 
Date:   Tue Oct 30 13:00:51 2018 +0100

tests: Disable failing tests as on FreeBSD

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

commit 38704a92f5ded6ac028f589632f4a305400a83ce
Author: Andreas Schneider 
Date:   Wed Oct 31 08:07:17 2018 +0100

cmake: Create a list with required libraries

This should fix the build on OmniOS.

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

commit db7070c65a8732996a11ce05287a2380278ec6a8
Author: Andreas Schneider 
Date:   Mon Nov 5 08:29:25 2018 +0100

tests: Protect IPv6 function in setup_echo_srv_tcp_ipv6

Fixes the build on OmniOS.

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

commit f690f8c0873d87359f9d3c11e46c8c4dc185af0e
Author: Andreas Schneider 
Date:   Wed Oct 31 08:04:03 2018 +0100

tests: Protect IPv6 case in echo_srv

This fixes the build on OmniOS.

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

commit fb4df592a055669b8046e2d0a263b8cc49633fb0
Author: Andreas Schneider 
Date:   Wed Oct 31 08:02:25 2018 +0100

swrap: Protect IPv6 case in swrap_socket()

Fixes the build on OmniOS

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

---

Summary of changes:
 .gitlab-ci.yml |  5 +
 ConfigureChecks.cmake  |  7 ---
 src/socket_wrapper.c   |  2 ++
 tests/CMakeLists.txt   | 12 
 tests/echo_srv.c   |  6 ++
 tests/test_echo_tcp_bind.c |  2 ++
 6 files changed, 27 insertions(+), 7 deletions(-)


Changeset truncated at 500 lines:

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 1f9dab3..00b4576 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -77,10 +77,7 @@ fedora/undefined-sanitizer:
 paths:
   - obj/
 
-# This runner is disabled because there is a threading race condition in
-# FreeBSD.
-# See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231848
-.freebsd/x86_64:
+freebsd/x86_64:
   image:
   script:
   - mkdir -p obj && cd obj && cmake
diff --git a/ConfigureChecks.cmake b/ConfigureChecks.cmake
index cb5bf53..17fdd3e 100644
--- a/ConfigureChecks.cmake
+++ b/ConfigureChecks.cmake
@@ -72,7 +72,7 @@ check_function_exists(pledge HAVE_PLEDGE)
 if (UNIX)
 find_library(DLFCN_LIBRARY dl)
 if (DLFCN_LIBRARY)
-string(APPEND _REQUIRED_LIBRARIES ${DLFCN_LIBRARY})
+list(APPEND _REQUIRED_LIBRARIES ${DLFCN_LIBRARY})
 else()
 check_function_exists(dlopen HAVE_DLOPEN)
 if (NOT HAVE_DLOPEN)
@@ -84,13 +84,13 @@ if (UNIX)
 # libsocket (Solaris)
 check_library_exists(socket getaddrinfo "" HAVE_LIBSOCKET)
 if (HAVE_LIBSOCKET)
-string(APPEND _REQUIRED_LIBRARIES socket)
+list(APPEND _REQUIRED_LIBRARIES socket)
 endif (HAVE_LIBSOCKET)
 
 # libnsl/inet_pton (Solaris)
 check_library_exists(nsl inet_pton "" HAVE_LIBNSL)
 if (HAVE_LIBNSL)
-string(APPEND _REQUIRED_LIBRARIES nsl)
+list(APPEND _REQUIRED_LIBRARIES nsl)
 endif (HAVE_LIBNSL)
 endif (NOT LINUX)
 
@@ -269,4 +269,5 @@ endif (NOT WIN32)
 
 check_type_size(pid_t SIZEOF_PID_T)
 
+string(REPLACE ";" " " _REQUIRED_LIBRARIES "${_REQUIRED_LIBRARIES}")
 set(SWRAP_REQUIRED_LIBRARIES ${_REQUIRED_LIBRARIES} CACHE INTERNAL 
"socket_wrapper required system libraries")
diff --git a/src/socket_wrapper.c b/src/socket_wrapper.c
index 5e3a47b..a107710 100644
--- a/src/socket_wrapper.c
+++ b/src/socket_wrapper.c
@@ -3098,6 +3098,7 @@ static int swrap_socket(int family, int type, int 
protocol)
memcpy(>myname.sa.in, , si->myname.sa_socklen);
break;
}
+#ifdef HAVE_IPV6
case AF_INET6: {
struct sockaddr_in6 sin6 = {
.sin6_family = AF_INET6,
@@ -3107,6 +3108,7 @@ static int swrap_socket(int family, int type, int 
protocol)
memcpy(>myname.sa.in6, , si->myname.sa_socklen);
break;
   

[SCM] Samba Shared Repository - branch v4-8-test updated

2018-11-06 Thread Karolin Seeger
The branch, v4-8-test has been updated
   via  b51ef80 torture: Fix the clang build
   via  0eebb6e vfs_fruit: let fruit_open_meta() with O_CREAT return a 
fake-fd
   via  cbbd530 vfs_fruit: don't check for delete-on-close on the 
FinderInfo stream
   via  80c9567 vfs_fruit: let fruit_pwrite_meta_stream also ftruncate 
empty FinderInfo
   via  248b5fc vfs_fruit: pass stream size to delete_invalid_meta_stream()
   via  1078e22 vfs_fruit: let fruit handle all aio on the FinderInfo 
metadata stream
   via  8c8d2d0 vfs_fruit: do ino calculation
   via  a9b6f3a vfs_fruit: prepare fruit_pread_meta() for reading on fake-fd
   via  257281c vfs_fruit: prepare fruit_pwrite_meta() for on-demand 
opening and writing
   via  a3cc00f vfs_fruit: prepare struct fio for fake-fd and on-demand 
opening
   via  bc6d5c9 vfs_fruit: add fio->created
   via  82783db vfs_fruit: remove resource fork special casing
   via  02987f7 vfs_fruit: add some debugging of dev/ino
   via  6501f48 s4:torture/vfs/fruit: add test "empty_stream"
   via  76fb134 s4:torture/vfs/fruit: add check_stream_list_handle()
   via  e38c76e s4:torture/util: add torture_smb2_open()
   via  2807227 vfs_fruit: filter empty streams
   via  b0657fa vfs_fruit: use check on global_fruit_config.nego_aapl for 
macOS specific behaviour
   via  fd53ad8 s4:torture/vfs/fruit: enable AAPL extensions in a bunch of 
tests
   via  aa7de98 vfs_fruit: don't unlink 0-byte size truncated streams
   via  0893dd1 s4:torture/vfs/fruit: write some data to a just created 
teststream
   via  0cad5ea s4:torture/vfs/fruit: expand test "setinfo eof stream"
   via  347c78f vfs_fruit: update handling of read-only creation of 
resource fork
   via  46c5c8a s4:torture/vfs/fruit: update test "creating rsrc with 
read-only access" for newer macOS versions
   via  a14fe5b s4:torture/vfs/fruit: expand existing vfs_test "null 
afpinfo"
   via  b58b000 s4:torture/vfs/fruit: expand existing test "setinfo 
delete-on-close AFP_AfpInfo" a little bit
   via  758ab1e s4:torture/vfs/fruit: update test "read open rsrc after 
rename" to work with macOS
   via  dcd54e8 s4:torture/vfs/fruit: ensure a directory handle is closed 
in all code paths
   via  f2c7d60 s4:torture/vfs/fruit: update test "stream names" to work 
with macOS
   via  2fcc620 s4:torture/vfs/fruit: update test "SMB2/CREATE context 
AAPL" to work against macOS
   via  8651d0e s4:torture/vfs/fruit: set share_access to 
NTCREATEX_SHARE_ACCESS_MASK in check_stream_list
   via  caa5f0b s4:torture/vfs/fruit: fix a few error checks in "delete 
AFP_AfpInfo by writing all 0"
   via  00953bb s4:torture/vfs/fruit: skip a few tests when running against 
a macOS SMB server
   via  a7b85d5 vfs_streams_xattr: fix open implementation
   via  5a01f6c s4/test: fix AAPL size check
   via  45d55dc ctdb-recovery: Ban a node that causes recovery failure
   via  ce25e57 s3:smbd: remove now unused check if fsp is NULL
   via  d365e6d s3:smbd: fix SMB2 aio cancelling
   via  86a115c s4:torture/smb2/read: add test for cancelling SMB aio
   via  27fb50f vfs_delay_inject: implement pread_send and pwrite_send
   via  8ae8c56 s4:libcli/smb2: reapply request endtime
   via  d79d719 libcli: fill endtime if smbXcli_req_create() timeout is 
non-zero
   via  23c1e01 libcli: add smbXcli_req_endtime
  from  994c6c6 dsdb: Add comments explaining the limitations of our 
current backlink behaviour

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-8-test


- Log -
commit b51ef80a7aa289d6b42c481640d823284b83e67d
Author: Volker Lendecke 
Date:   Thu Nov 1 12:09:14 2018 +0100

torture: Fix the clang build

It's used uninitialized if an early torture_assert fails

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Nov  1 17:34:31 CET 2018 on sn-devel-144

(cherry picked from commit 9b28d47b0d86570be5a7c5628e460e01207afb00)

Autobuild-User(v4-8-test): Karolin Seeger 
Autobuild-Date(v4-8-test): Tue Nov  6 13:44:37 CET 2018 on sn-devel-144

commit 0eebb6e0a47a53709b7a8ec67bd97dae7b1fd53e
Author: Ralph Boehme 
Date:   Wed Aug 22 15:25:26 2018 +0200

vfs_fruit: let fruit_open_meta() with O_CREAT return a fake-fd

This is the final step in implementing the needed macOS semantics on the
FinderInfo stream: as long as the client hasn't written a non-zero
FinderInfo blob to the stream, there mustn't be a visible filesystem
entry for other openers.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 

[SCM] Samba Shared Repository - branch v4-9-test updated

2018-11-06 Thread Karolin Seeger
The branch, v4-9-test has been updated
   via  2dd3c33 torture: Fix the clang build
   via  7354097 vfs_fruit: let fruit_open_meta() with O_CREAT return a 
fake-fd
   via  cf43b5d vfs_fruit: don't check for delete-on-close on the 
FinderInfo stream
   via  eacbfe9 vfs_fruit: let fruit_pwrite_meta_stream also ftruncate 
empty FinderInfo
   via  27a5a83 vfs_fruit: pass stream size to delete_invalid_meta_stream()
   via  029f64f vfs_fruit: let fruit handle all aio on the FinderInfo 
metadata stream
   via  d405dc3 vfs_fruit: do ino calculation
   via  c23f1da vfs_fruit: prepare fruit_pread_meta() for reading on fake-fd
   via  a5b677d vfs_fruit: prepare fruit_pwrite_meta() for on-demand 
opening and writing
   via  44834da vfs_fruit: prepare struct fio for fake-fd and on-demand 
opening
   via  a57e29e vfs_fruit: add fio->created
   via  c7ce8c8 vfs_fruit: remove resource fork special casing
   via  c8e1405 vfs_fruit: add some debugging of dev/ino
   via  42a5dbd s4:torture/vfs/fruit: add test "empty_stream"
   via  5076abb s4:torture/vfs/fruit: add check_stream_list_handle()
   via  0a16d4f s4:torture/util: add torture_smb2_open()
   via  e03f36a vfs_fruit: filter empty streams
   via  e8f1df0 vfs_fruit: use check on global_fruit_config.nego_aapl for 
macOS specific behaviour
   via  71d8b4a s4:torture/vfs/fruit: enable AAPL extensions in a bunch of 
tests
   via  a09f0a8 vfs_fruit: don't unlink 0-byte size truncated streams
   via  535abb3 s4:torture/vfs/fruit: write some data to a just created 
teststream
   via  e2fe019 s4:torture/vfs/fruit: expand test "setinfo eof stream"
   via  abfc211 vfs_fruit: update handling of read-only creation of 
resource fork
   via  816651b s4:torture/vfs/fruit: update test "creating rsrc with 
read-only access" for newer macOS versions
   via  cc9956e s4:torture/vfs/fruit: expand existing vfs_test "null 
afpinfo"
   via  530c24f s4:torture/vfs/fruit: expand existing test "setinfo 
delete-on-close AFP_AfpInfo" a little bit
   via  756da49 s4:torture/vfs/fruit: update test "read open rsrc after 
rename" to work with macOS
   via  8b5a4c3 s4:torture/vfs/fruit: ensure a directory handle is closed 
in all code paths
   via  1e3f8a6 s4:torture/vfs/fruit: update test "stream names" to work 
with macOS
   via  cca8842 s4:torture/vfs/fruit: update test "SMB2/CREATE context 
AAPL" to work against macOS
   via  7717809 s4:torture/vfs/fruit: set share_access to 
NTCREATEX_SHARE_ACCESS_MASK in check_stream_list
   via  718317b s4:torture/vfs/fruit: fix a few error checks in "delete 
AFP_AfpInfo by writing all 0"
   via  dd2a1d0 s4:torture/vfs/fruit: skip a few tests when running against 
a macOS SMB server
   via  e03bdef vfs_streams_xattr: fix open implementation
   via  53104cb ctdb-recovery: Ban a node that causes recovery failure
   via  d72319d s3:smbd: remove now unused check if fsp is NULL
   via  c1e441e s3:smbd: fix SMB2 aio cancelling
   via  a9bb620 s4:torture/smb2/read: add test for cancelling SMB aio
   via  6fa0ab1 vfs_delay_inject: implement pread_send and pwrite_send
   via  82a7e00 s4:libcli/smb2: reapply request endtime
   via  7e99105 libcli: fill endtime if smbXcli_req_create() timeout is 
non-zero
   via  786b6c7 libcli: add smbXcli_req_endtime
  from  a0a3ce5 dsdb group audit tests: log_membership_changes extra tests

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-9-test


- Log -
commit 2dd3c3341a6f0fa577571955ed9ed24a6b63d5ac
Author: Volker Lendecke 
Date:   Thu Nov 1 12:09:14 2018 +0100

torture: Fix the clang build

It's used uninitialized if an early torture_assert fails

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Volker Lendecke 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Thu Nov  1 17:34:31 CET 2018 on sn-devel-144

(cherry picked from commit 9b28d47b0d86570be5a7c5628e460e01207afb00)

Autobuild-User(v4-9-test): Karolin Seeger 
Autobuild-Date(v4-9-test): Tue Nov  6 12:16:07 CET 2018 on sn-devel-144

commit 73540974bc8fc03bb1860581449bd6509f36d3ad
Author: Ralph Boehme 
Date:   Wed Aug 22 15:25:26 2018 +0200

vfs_fruit: let fruit_open_meta() with O_CREAT return a fake-fd

This is the final step in implementing the needed macOS semantics on the
FinderInfo stream: as long as the client hasn't written a non-zero
FinderInfo blob to the stream, there mustn't be a visible filesystem
entry for other openers.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13646

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Thu Nov  1 01:14:23 CET 2018 on sn-devel-144


[SCM] Samba Shared Repository - branch master updated

2018-11-06 Thread Amitay Isaacs
The branch, master has been updated
   via  6e16e95 ctdb-daemon: Do not fork when CTDB_TEST_MODE is set
   via  01f6fbb ctdb-daemon: Switch interactive variable to a bool
   via  804bdf9 ctdb-tests: Add local_daemons.sh onnode and socket commands
   via  19de5f4 ctdb-tests: Use local_daemons.sh in local_daemons.bash
   via  46fd4f1 ctdb-tests: Add local_daemons.sh
   via  25efb92 ctdb-tests: Allow use of setup_ctdb_base() outside of test 
cases
   via  9679c9e ctdb-build: Don't set unused variable TEST_BIN_DIR
   via  aa0c7cc ctdb-tests: Move setting of ctdb_dir and top_dir
   via  1d86fd5 ctdb-tests: Use $CTDB_SCRIPTS_TOOLS_BIN_DIR
   via  7ac5e7a ctdb-tests: Use $CTDB_SCRIPTS_TESTS_BINDIR
   via  bde73c7 ctdb-tests: Add new variable CTDB_SCRIPTS_TESTS_BINDIR
   via  2cb82ef ctdb-tests: Change all cluster setup to use ctdb_test_init()
   via  9a2910c ctdb-tests: Drop passing of test arguments to 
ctdb_test_init()
   via  d762e52 ctdb-tests: Drop ctdb_restart_when_done()
   via  79db138 ctdb-tests: Drop dependency on variable 
ctdb_test_restart_scheduled
   via  bc8df71 ctdb-tests: Drop tests that only start and stop daemons
   via  412fb7b ctdb-tests: Move enabling of event scripts to setup_ctdb()
   via  aa2ee4b ctdb-tests: Improve signal handling trap
   via  9233723 ctdb-tests: Drop cleanup_handler()
   via  0e9ead8 ctdb-tests: Start daemons in ctdb_test_init(), stop them in 
ctdb_test_exit()
   via  e733e4c ctdb-tests: Ignore SIGPIPE during simple test cleanup
   via  6d9c89b ctdb-tests: Drop setting of unused variable scriptname
   via  5205680 ctdb-tests: Drop use of confusing testfailures variable
   via  9ebcebe ctdb-tests: Drop useless "ctdb version" test
   via  43c26e1 ctdb-tests: Rationalise tunable simple tests
   via  ba86eac ctdb-tests: Rationalise ctdb stop/continue/disable/enable 
simple tests
   via  5fdac51 ctdb-tests: Use wait_until_node_has_no_ips() in some tests
   via  eda1296 ctdb-tests: Add function wait_until_node_has_no_ips()
   via  698a9ef lib: ldb: Remove use of talloc_autofree_context().
   via  f420e8d lib: talloc: Mark talloc_autofree_context() as deprecated.
   via  44019b5 ctdb-event: Only run talloc report if CTDB_INTERACTIVE is 
set
   via  e952f03 ctdb-event: Never fork to become daemon in eventd
   via  4e6bd42 ctdb-daemon: Improve documentation for -i option
   via  9c41481 ctdb-daemon: Don't set log_to_stdout for become_daemon()
   via  c84254d ctdb-daemon: Avoid unnecessarily spamming the logs when in 
test mode
   via  1bbc4fa ctdb-tools: Detect unknown node number
   via  0846940 ctdb-tests: README updates
   via  4f4a835 ctdb-tests: Remove export of CTDB_SOCKET
   via  d246b1d ctdb-tests: Use path_socket() in dummy client
   via  3b1e597 ctdb-tests: Drop incorrect comment, unused function
   via  82e589e ctdb-tests: Drop setting of CTDB_SOCKET and CTDB_PIDFILE
   via  d75fa2c ctdb-daemon: Drop unused function ctdb_set_socketname()
   via  5f478b7 ctdb-daemon: Use path functions for socket and PID file
   via  cd02159 ctdb-tests: Use path_socket() in test client tools
   via  cc3aedd ctdb-tools: Use path_socket() in ctdb tool
   via  3856678 ctdb-tests: Use ctdb-path for fake_ctdbd directory setup
   via  d4a1f89 ctdb-tests: Use ctdb-path-like values for local daemons 
socket and PID file
   via  32c2ec8 ctdb-common: Allow path_socket() to use $CTDB_SOCKET
  from  2229f46 drs_utils: Avoid invalid dereference of v8 requests

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 6e16e95f74c06bf381db666007a30ecb0e1ff7ce
Author: Martin Schwenke 
Date:   Thu Oct 18 18:02:13 2018 +1100

ctdb-daemon: Do not fork when CTDB_TEST_MODE is set

Explicitly background ctdbd instead.

This has the advantage of leaving stdin open.  ctdbd can then be
enhanced to exit when stdin closes, allowing better cleanup in a test
environment.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

Autobuild-User(master): Amitay Isaacs 
Autobuild-Date(master): Tue Nov  6 10:30:14 CET 2018 on sn-devel-144

commit 01f6fbba4e5823f2cc028ba6f094b55812dff6ee
Author: Martin Schwenke 
Date:   Tue Nov 6 14:06:14 2018 +1100

ctdb-daemon: Switch interactive variable to a bool

popt uses an int in place of a bool, so declare an extra int and make
the conversion explicit.

Signed-off-by: Martin Schwenke 
Reviewed-by: Amitay Isaacs 

commit 804bdf9719cdc128df7ba4dfe7564e5339426b35
Author: Martin Schwenke 
Date:   Fri Oct 12 13:49:58 2018 +1100

ctdb-tests: Add local_daemons.sh onnode and socket commands

These aren't used by simple tests but they will be useful for
integrating ctdbd local daemons into other test suites and for