[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 1b263ed631c s3-vfs-streams_xattr: add close call via 5c928d7cd1d lib/audit_logging: actually create talloc via 35349fecbd0 docs-xml: document "log level" changes via 08d37b4a44b debug: enable per debug-class logfiles via 3dbda63284c debug: remove fd and debugf from state, use dbgc_config[DBGC_ALL] via 781f5a95edd debug: update logsize checking for per debug-class logfiles via d792f15ff14 debug: update need_to_check_log_size() for per debug-class logfiles via 249bdd93783 debug: add support for per debug-class logfiles via abfb3c6bbf5 debug: add resource cleanup for per debug-class logfiles via 43c693511d9 debug: add logfile and fd to struct debug_class via 7369674787d debug: factor out logfile size check via 4341f24069f debug: add a call to debug_parse_levels() to reopen_logs() via 2bc7e254a62 debug: add an empty line via 240b08c414c debug: factor out a function that opens and closes the new and old logfile via e6655f08873 debug: track current debug message class via 63f330761e7 debug: convert dbgc_config to an array of struct debug_class via d346cf94a44 debug: README.Coding fixes via 3b293c66902 debug: rename DEBUGLEVEL_CLASS variable to dbgc_config via 7a2562fd2b4 debug: move some definitions around from 357fe04bd47 s4: Add kerberos tracing https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 1b263ed631c86bf4117c9388fce3fa1f24cea4c9 Author: Günther Deschner Date: Tue Dec 18 17:20:29 2018 +0100 s3-vfs-streams_xattr: add close call https://bugzilla.samba.org/show_bug.cgi?id=13725 We cannot always rely on vfs_default to close the fake fds. This mostly is relevant when used with another non-local VFS filesystem module such as gluster. Guenther Signed-off-by: Günther Deschner Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Thu Dec 20 07:18:20 CET 2018 on sn-devel-144 commit 5c928d7cd1d0ac994fe95892eec235b939ad2ec9 Author: Philipp Gesang Date: Tue Dec 18 16:09:19 2018 +0100 lib/audit_logging: actually create talloc Heal damage of 79f494e51e.. That context is being passed around and freed but is never actually allocated on that stack. Signed-off-by: Philipp Gesang Reviewed-by: Gary Lockyer Reviewed-by: Jeremy Allison commit 35349fecbd075a5e5dd4c87be465d61c5104fb21 Author: Ralph Boehme Date: Wed Dec 12 21:04:42 2018 +0100 docs-xml: document "log level" changes "log level" now takes an optional per debug-class logfile: log level = 1 full_audit:1@/var/log/audit.log winbind:2 Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit 08d37b4a44bc7daed3c1c5774a3d7e796de582ef Author: Ralph Boehme Date: Wed Dec 12 22:46:49 2018 +0100 debug: enable per debug-class logfiles This finally enables per debug-class logfiles by hooking into reopen_logs_internal() calls to reopen_one_log() per configured debug-class. Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit 3dbda63284cdeb2f060931c85388842627c955a1 Author: Ralph Boehme Date: Wed Dec 12 22:49:15 2018 +0100 debug: remove fd and debugf from state, use dbgc_config[DBGC_ALL] Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit 781f5a95edde4cd27627515869bfe2fc626fbb3a Author: Ralph Boehme Date: Wed Dec 12 14:43:22 2018 +0100 debug: update logsize checking for per debug-class logfiles Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit d792f15ff1406cde7f38ddc5febb08a8b39b90e8 Author: Ralph Boehme Date: Wed Dec 12 14:54:41 2018 +0100 debug: update need_to_check_log_size() for per debug-class logfiles Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit 249bdd9378306c146dca0eec6711e2c6b8eae29a Author: Ralph Boehme Date: Wed Dec 12 13:11:26 2018 +0100 debug: add support for per debug-class logfiles This adds support for per debug-class logfiles to the function parsing the "log level" option. The enhanced syntax is: log level = CLASS:LEVEL[@PATH] [CLASS:LEVEL[@PATH] ... ] Eg log level = full_audit:1@/var/log/audit.logfile While the option is already parsed and stored in in the dbgc_config[] array, the feature is still effectively disabled, as reopen_logs_internal() still doesn't open the per debug-class logfiles. Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison commit abfb3c6bbf5d3d27ca61cd973ffb15c3d8e2be4f Author: Ralph Boehme Date: Wed Dec 12 13:09:03 2018 +0100 debug: add resource cleanup for per debug-class logfiles
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 357fe04bd47 s4: Add kerberos tracing via 0b0a22ddad0 winbindd: Add kerberos tracing via 5eefb0885c9 utils: Add kerberos tracing via bf675938924 passdb: Add kerberos tracing via 9f33864770e librpc: Add kerberos tracing via 8887a680310 libnet: Add kerberos tracing via 3df7789e4b3 libads: Add kerberos tracing via 2cc561fbbf1 client: Add kerberos tracing via 5056b962241 lib: Add kerberos tracing via a800baece74 Add MIT kerberos tracing capability from 49dc04f9f55 samba-tool: don't print backtrace on simple DNS errors https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 357fe04bd477858bb21cfb5e8a5e0efc556864d6 Author: Swen Schillig Date: Wed Dec 5 11:55:09 2018 +0100 s4: Add kerberos tracing Replace kerberos context initialization from raw krb5_init_context() to smb_krb5_init_context_basic() which is adding common tracing as well. Signed-off-by: Swen Schillig Reviewed-by: Andrew Bartlett Reviewed-by: Christof Schmitt Autobuild-User(master): Christof Schmitt Autobuild-Date(master): Thu Dec 20 01:31:17 CET 2018 on sn-devel-144 commit 0b0a22ddad0e5f1542aee6ed65efaedb08471cc5 Author: Swen Schillig Date: Wed Dec 5 11:46:46 2018 +0100 winbindd: Add kerberos tracing Replace kerberos context initialization from raw krb5_init_context() to smb_krb5_init_context_basic() which is adding common tracing as well. Signed-off-by: Swen Schillig Reviewed-by: Andrew Bartlett Reviewed-by: Christof Schmitt commit 5eefb0885c935854fd3ddc1fcbab2c456745ee0f Author: Swen Schillig Date: Wed Dec 5 11:44:24 2018 +0100 utils: Add kerberos tracing Replace kerberos context initialization from raw krb5_init_context() to smb_krb5_init_context_basic() which is adding common tracing as well. Signed-off-by: Swen Schillig Reviewed-by: Andrew Bartlett Reviewed-by: Christof Schmitt commit bf67593892402fc469ecb7930795dafe273e60e7 Author: Swen Schillig Date: Wed Dec 5 11:41:47 2018 +0100 passdb: Add kerberos tracing Replace kerberos context initialization from raw krb5_init_context() to smb_krb5_init_context_basic() which is adding common tracing as well. Signed-off-by: Swen Schillig Reviewed-by: Andrew Bartlett Reviewed-by: Christof Schmitt commit 9f33864770ee973ab35da07494c1100f628070be Author: Swen Schillig Date: Wed Dec 5 11:38:44 2018 +0100 librpc: Add kerberos tracing Replace kerberos context initialization from raw krb5_init_context() to smb_krb5_init_context_basic() which is adding common tracing as well. Signed-off-by: Swen Schillig Reviewed-by: Andrew Bartlett Reviewed-by: Christof Schmitt commit 8887a68031070e0d6b93f7283b7ab409977206de Author: Swen Schillig Date: Wed Dec 5 11:35:42 2018 +0100 libnet: Add kerberos tracing Replace kerberos context initialization from raw krb5_init_context() to smb_krb5_init_context_basic() which is adding common tracing as well. Signed-off-by: Swen Schillig Reviewed-by: Andrew Bartlett Reviewed-by: Christof Schmitt commit 3df7789e4b34f08b21d7d5d294831c795f0145d4 Author: Swen Schillig Date: Wed Dec 5 11:16:42 2018 +0100 libads: Add kerberos tracing Replace kerberos context initialization from raw krb5_init_context() to smb_krb5_init_context_basic() which is adding common tracing as well. Signed-off-by: Swen Schillig Reviewed-by: Andrew Bartlett Reviewed-by: Christof Schmitt commit 2cc561fbbf157ce9bddb702d46f5dba1bf46311b Author: Swen Schillig Date: Wed Dec 5 11:06:20 2018 +0100 client: Add kerberos tracing Replace kerberos context initialization from raw krb5_init_context() to smb_krb5_init_context_basic() which is adding common tracing as well. Signed-off-by: Swen Schillig Reviewed-by: Andrew Bartlett Reviewed-by: Christof Schmitt commit 5056b9622416311535578a481af800afe8c8c729 Author: Swen Schillig Date: Wed Dec 5 11:03:33 2018 +0100 lib: Add kerberos tracing Add krb5 tracing to samba krb5 wrapper. Signed-off-by: Swen Schillig Reviewed-by: Andrew Bartlett Reviewed-by: Christof Schmitt commit a800baece74fc9d3766af8432adf8efad05ed9d6 Author: Swen Schillig Date: Wed Dec 5 10:29:44 2018 +0100 Add MIT kerberos tracing capability HEIMDAL kerberos offers already tracing via a logging facility through smb_krb5_init_context(). MIT kerberos offers to register a callback via krb5_set_trace_callback with which tracing information can be routed to a common logging facility. This is now integrated into smb_krb5_init_context_basic() offering the same functionality for
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 49dc04f9f55 samba-tool: don't print backtrace on simple DNS errors
from fe7ab7d5132 tests/ntlm_auth: Port ntlm_auth_diagnostics tests to
python
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 49dc04f9f553c443c78c8073c07ea2a38cde61b2
Author: Björn Jacke
Date: Tue Dec 18 12:58:53 2018 +0100
samba-tool: don't print backtrace on simple DNS errors
samba-tool throws backtraces even for simple DNS error
messages, we should not frighten users for no good reason.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13721
Signed-off-by: Bjoern Jacke
Reviewed-by: Stefan Metzmacher
Autobuild-User(master): Björn Jacke
Autobuild-Date(master): Wed Dec 19 20:58:52 CET 2018 on sn-devel-144
---
Summary of changes:
python/samba/netcmd/dns.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
Changeset truncated at 500 lines:
diff --git a/python/samba/netcmd/dns.py b/python/samba/netcmd/dns.py
index b50e7b7dd0c..b7459a71acd 100644
--- a/python/samba/netcmd/dns.py
+++ b/python/samba/netcmd/dns.py
@@ -780,7 +780,7 @@ class cmd_zonedelete(Command):
None)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_ZONE_DOES_NOT_EXIST:
-self.outf.write('Zone does not exist and so could not be
deleted.')
+raise CommandError('Zone does not exist and so could not be
deleted.')
raise e
self.outf.write('Zone %s deleted successfully\n' % zone)
@@ -860,7 +860,7 @@ class cmd_query(Command):
None, record_type, select_flags, None, None)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_NAME_DOES_NOT_EXIST:
-self.outf.write('Record or zone does not exist.')
+raise CommandError('Record or zone does not exist.')
raise e
print_dnsrecords(self.outf, res)
@@ -940,7 +940,7 @@ class cmd_add_record(Command):
0, server, zone, name, add_rec_buf,
None)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_NAME_DOES_NOT_EXIST:
-self.outf.write('Zone does not exist; record could not be
added.\n')
+raise CommandError('Zone does not exist; record could not be
added.')
raise e
self.outf.write('Record added successfully\n')
@@ -1011,7 +1011,7 @@ class cmd_update_record(Command):
del_rec_buf)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_NAME_DOES_NOT_EXIST:
-self.outf.write('Zone does not exist; record could not be
updated.\n')
+raise CommandError('Zone does not exist; record could not be
updated.')
raise e
self.outf.write('Record updated successfully\n')
@@ -1066,7 +1066,7 @@ class cmd_delete_record(Command):
del_rec_buf)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_NAME_DOES_NOT_EXIST:
-self.outf.write('Zone does not exist; record could not be
deleted.\n')
+raise CommandError('Zone does not exist; record could not be
deleted.')
raise e
self.outf.write('Record deleted successfully\n')
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via fe7ab7d5132 tests/ntlm_auth: Port ntlm_auth_diagnostics tests to python via 4846d4a7136 selftest: Remove test_ntlm_auth.py helper via 129ab34baf0 tests/ntlm_auth: Port ntlm_auth_krb5 tests to python via 91c4f260360 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with incorrect fixed password against winbind via 3ae7095bbee tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with plaintext password against winbind but wrong sid via 8d4258f43de tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with plaintext password against winbind via 7c0c683b2ea tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with incorrect fixed password via 28ea2f7220d tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with fixed password via 3794c1c5274 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth plaintext authentication with failed require-membership-of via dfa149276f1 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth plaintext authentication with require-membership-of via caa505302f5 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP gss-spnego-client and gss-spnego server against winbind with failed require-membership-of via 377e87a2347 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth against winbindd with failed require-membership-of via 8d11a54e370 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP gss-spnego-client and gss-spnego server against winbind with require-membership-of via 1f704496ea6 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth against winbindd with require-membership-of via 06d101e3f08 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ccached credentials with NTLMSSP client and gss-spnego server via 4ce9371f5fa tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP gss-spnego-client and gss-spnego server against winbind via c9a5bf3c82c tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP gss-spnego-client and gss-spnego server via d3fd3d01f19 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth with NTLMSSP client and gss-spnego server via 4a11ab373b3 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth against winbindd via 247592f7162 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth and ntlm_auth with specified domain via e8144129111 selftest: Add a new base class for ntlm_auth tests via d0b5e216b07 selftest: Create included files during provision from b1ad5a880fd krb5_wrap: Fix bit shifting https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit fe7ab7d5132b2312f617b3c51db9d4c9f9271a51 Author: Samuel Cabrero Date: Thu Sep 6 13:56:53 2018 +0200 tests/ntlm_auth: Port ntlm_auth_diagnostics tests to python Port ntlm_auth_diagnostics bash script tests to python Signed-off-by: Samuel Cabrero Reviewed-by: Noel Power Reviewed-by: Andrew Bartlett Autobuild-User(master): Noel Power Autobuild-Date(master): Wed Dec 19 16:21:32 CET 2018 on sn-devel-144 commit 4846d4a713679957f31b8da179be192d8b6e7506 Author: Samuel Cabrero Date: Thu Nov 15 11:17:43 2018 +0100 selftest: Remove test_ntlm_auth.py helper Signed-off-by: Samuel Cabrero Reviewed-by: Noel Power Reviewed-by: Andrew Bartlett commit 129ab34baf0b1554dea3d93506b95439bffcb30f Author: Samuel Cabrero Date: Thu Sep 6 12:58:42 2018 +0200 tests/ntlm_auth: Port ntlm_auth_krb5 tests to python Port ntlm_auth_krb5 bash script tests to python Signed-off-by: Samuel Cabrero Reviewed-by: Noel Power Reviewed-by: Andrew Bartlett commit 91c4f2603607a917c1f1006b2f9f83232ac489c4 Author: Samuel Cabrero Date: Fri Aug 31 19:28:06 2018 +0200 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with incorrect fixed password against winbind Port ntlm_auth bash script tests to python and remove bash test script Signed-off-by: Samuel Cabrero Reviewed-by: Noel Power Reviewed-by: Andrew Bartlett commit 3ae7095bbee9ca19056c00a61084d49e5e278728 Author: Samuel Cabrero Date: Fri Aug 31 19:27:20 2018 +0200 tests/ntlm_auth: Port ntlm_auth tests to python: ntlm_auth ntlm-server-1 with plaintext password against winbind but wrong sid Port ntlm_auth bash script tests to python Signed-off-by: Samuel Cabrero Reviewed-by: Noel Power Reviewed-by: Andrew Bartlett commit 8d4258f43dea153cc60a6b9dbd36f0ca0b5abf0e Author: Samuel Cabrero Date: Fri Aug 31 19:15:05 2018 +0200 tests/ntlm_auth: Port ntlm_auth tests to
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via b1ad5a880fd krb5_wrap: Fix bit shifting
from 5118985841a lib/util: Count a trailing line that doesn't end in a
newline
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit b1ad5a880fd571c970a0fff33e20f4ea0c469f4c
Author: Andreas Schneider
Date: Wed Dec 12 10:10:08 2018 +0100
krb5_wrap: Fix bit shifting
lib/krb5_wrap/enctype_convert.c:93:27: runtime error: left shift of 1 by
31 places cannot be represented in type 'int'
Signed-off-by: Andreas Schneider
Reviewed-by: Gary Lockyer
Autobuild-User(master): Andreas Schneider
Autobuild-Date(master): Wed Dec 19 12:40:40 CET 2018 on sn-devel-144
---
Summary of changes:
lib/krb5_wrap/enctype_convert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/lib/krb5_wrap/enctype_convert.c b/lib/krb5_wrap/enctype_convert.c
index b78304f6bf0..a658911190a 100644
--- a/lib/krb5_wrap/enctype_convert.c
+++ b/lib/krb5_wrap/enctype_convert.c
@@ -90,7 +90,7 @@ krb5_error_code ms_suptypes_to_ietf_enctypes(TALLOC_CTX
*mem_ctx,
return ENOMEM;
}
for (i = 0; i < (8 * sizeof(enctype_bitmap)); i++) {
- uint32_t bit_value = (1 << i) & enctype_bitmap;
+ uint32_t bit_value = (1U << i) & enctype_bitmap;
if (bit_value & enctype_bitmap) {
(*enctypes)[j] = ms_suptype_to_ietf_enctype(bit_value);
if (!(*enctypes)[j]) {
--
Samba Shared Repository
