[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via c68d9c9ef36 vfs_snapper: drop unneeded fstat handler
from 2e7f4b1d370 s3:tests: Add test for smbstatus and smbstatus
--resolve_uids
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit c68d9c9ef367c1e85619ac2d027a0a425164ca8a
Author: David Disseldorp
Date: Mon Mar 25 18:06:15 2019 +0100
vfs_snapper: drop unneeded fstat handler
fstat is handle based, and unlike vfs_shadow_copy2, we don't need to
make any changes to the returned sbuf, so remove the existing handler
which does nothing.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13858
Signed-off-by: David Disseldorp
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Wed Mar 27 18:21:38 UTC 2019 on sn-devel-144
---
Summary of changes:
source3/modules/vfs_snapper.c | 19 ---
1 file changed, 19 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/modules/vfs_snapper.c b/source3/modules/vfs_snapper.c
index 0f52f9e71c5..fac4aa698de 100644
--- a/source3/modules/vfs_snapper.c
+++ b/source3/modules/vfs_snapper.c
@@ -2165,24 +2165,6 @@ static int snapper_gmt_lstat(vfs_handle_struct *handle,
return ret;
}
-static int snapper_gmt_fstat(vfs_handle_struct *handle, files_struct *fsp,
-SMB_STRUCT_STAT *sbuf)
-{
- time_t timestamp;
- int ret;
-
- ret = SMB_VFS_NEXT_FSTAT(handle, fsp, sbuf);
- if (ret == -1) {
- return ret;
- }
- if (!snapper_gmt_strip_snapshot(talloc_tos(), handle,
- fsp->fsp_name->base_name,
- , NULL)) {
- return 0;
- }
- return 0;
-}
-
static int snapper_gmt_open(vfs_handle_struct *handle,
struct smb_filename *smb_fname, files_struct *fsp,
int flags, mode_t mode)
@@ -3111,7 +3093,6 @@ static struct vfs_fn_pointers snapper_fns = {
.symlink_fn = snapper_gmt_symlink,
.stat_fn = snapper_gmt_stat,
.lstat_fn = snapper_gmt_lstat,
- .fstat_fn = snapper_gmt_fstat,
.open_fn = snapper_gmt_open,
.unlink_fn = snapper_gmt_unlink,
.chmod_fn = snapper_gmt_chmod,
--
Samba Shared Repository
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2019-03-27-1907/flakey.log The failure seems to be in the "samba-fileserver" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2019-03-27-1907/samba-fileserver.stderr https://git.samba.org/autobuild.flakey.sn-devel-144/2019-03-27-1907/samba-fileserver.stdout The top commit at the time of the failure was: commit 2e7f4b1d3701b9da32e03dcee1095711945f22b8 Author: Andreas Schneider Date: Wed Mar 13 12:00:27 2019 +0100 s3:tests: Add test for smbstatus and smbstatus --resolve_uids BUG: https://bugzilla.samba.org/show_bug.cgi?id=13793 Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Wed Mar 27 14:33:35 UTC 2019 on sn-devel-144 and the last 50 lines of the stdout log were: [94(382)/132 at 15m49s] samba3.blackbox.netshareenum (fileserver)(fileserver) [95(386)/132 at 15m51s] samba3.blackbox.acl_xattr.NT1(fileserver) [96(399)/132 at 16m6s] samba3.blackbox.acl_xattr.SMB3(fileserver) [97(412)/132 at 16m17s] samba3.blackbox.smb2.not_casesensitive (fileserver)(fileserver) [98(414)/132 at 16m18s] samba3.blackbox.inherit_owner.default.NT1(fileserver) [99(433)/132 at 16m27s] samba3.blackbox.inherit_owner.default.SMB3(fileserver) [100(452)/132 at 16m37s] samba3.blackbox.inherit_owner.full.NT1(fileserver) [101(471)/132 at 16m45s] samba3.blackbox.inherit_owner.full.SMB3(fileserver) [102(490)/132 at 16m53s] samba3.blackbox.inherit_owner.unix.NT1(fileserver) [103(509)/132 at 17m1s] samba3.blackbox.inherit_owner.unix.SMB3(fileserver) [104(528)/132 at 17m8s] samba3.blackbox.large_acl.NT1(fileserver) [105(529)/132 at 17m9s] samba3.blackbox.large_acl.SMB3(fileserver) [106(530)/132 at 17m10s] samba3.blackbox.give_owner(fileserver) [107(541)/132 at 17m15s] samba3.blackbox.homes(fileserver) [108(544)/132 at 17m17s] samba3.blackbox.force_group_change(fileserver) [109(545)/132 at 17m19s] samba3.blackbox.smbclient_tarmode.NT1(fileserver) [110(547)/132 at 17m21s] samba3.blackbox.smbclient_tarmode.SMB3(fileserver) [111(549)/132 at 17m23s] samba3.blackbox.smbclient_tar.NT1(fileserver) [112(571)/132 at 17m33s] samba3.blackbox.smbclient_tar.SMB3(fileserver) [113(593)/132 at 17m42s] samba3.blackbox.net_usershare(fileserver:local) [114(599)/132 at 17m43s] samba3.blackbox.smbstatus(fileserver:local) [115(601)/132 at 17m45s] samba3.base.delaywrite(fileserver) [116(618)/132 at 19m30s] samba3.base.deny1(fileserver) [117(619)/132 at 20m25s] samba3.base.deny2(fileserver) [118(620)/132 at 21m25s] samba3.raw.samba3hide(simpleserver) [119(621)/132 at 21m25s] samba3.raw.samba3checkfsp(simpleserver) [120(622)/132 at 21m25s] samba3.raw.samba3closeerr(simpleserver) [121(623)/132 at 21m26s] samba3.smb2.notify-inotify(fileserver) smbtorture 4.11.0pre1-DEVELOPERBUILD Using seed 1553709966 Testing change notify of a rename with inotify UNEXPECTED(failure): samba3.smb2.notify-inotify.inotify-rename(fileserver) REASON: Exception: Exception: ../../source4/torture/smb2/notify.c:2591: status was NT_STATUS_CANCELLED, expected NT_STATUS_OK: smb2_notify_recv failed FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba3.blackbox.shadow_copy2 SMB3 (fileserver)(fileserver) -> 180 samba3.blackbox.shadow_copy2 NT1 (fileserver)(fileserver) -> 174 samba3.smbtorture_s3.vfs_aio_fork(simpleserver).RW2(simpleserver) -> 156 samba3.base.delaywrite(fileserver) -> 106 samba3.base.deny2(fileserver) -> 59 samba3.base.deny1(fileserver) -> 55 samba3.smb2.compound_find vfs_aio_pthread_async_dosmode_force_sync2(simpleserver) -> 45 samba3.smb2.compound_find vfs_aio_pthread_async_dosmode_force_sync1(simpleserver) -> 43 samba3.smb2.compound_find vfs_aio_pthread_async_dosmode_default2(simpleserver) -> 39 samba3.smb2.compound_find vfs_aio_pthread_async_dosmode_default1(simpleserver) -> 35 ERROR: test failed with exit code 1
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 2e7f4b1d370 s3:tests: Add test for smbstatus and smbstatus
--resolve_uids
via 6106b8a053e selftest: Add smbstatus to testhelper
via ffad76ae260 s3:utils: Add 'smbstatus -L --resolve-uids' to show
usernames
via 991d32a1756 s4/torture: Update winsreplication to only use IPv4
addresses
via a4d433aede8 selftest: Restore IPs 12-16 for selftest client
from 3e1d8ab1255 libsmb: Change cli_posix_readlink to return talloc'ed
target
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 2e7f4b1d3701b9da32e03dcee1095711945f22b8
Author: Andreas Schneider
Date: Wed Mar 13 12:00:27 2019 +0100
s3:tests: Add test for smbstatus and smbstatus --resolve_uids
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13793
Signed-off-by: Andreas Schneider
Reviewed-by: Andrew Bartlett
Autobuild-User(master): Andrew Bartlett
Autobuild-Date(master): Wed Mar 27 14:33:35 UTC 2019 on sn-devel-144
commit 6106b8a053e06699c332fd1a6d7636f550422cc7
Author: Andreas Schneider
Date: Wed Mar 13 12:00:11 2019 +0100
selftest: Add smbstatus to testhelper
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13793
Signed-off-by: Andreas Schneider
Reviewed-by: Andrew Bartlett
commit ffad76ae260ac33926db87c61aede5b66d9b09e6
Author: Andreas Schneider
Date: Mon Feb 18 14:11:32 2019 +0100
s3:utils: Add 'smbstatus -L --resolve-uids' to show usernames
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13793
Signed-off-by: Andreas Schneider
Reviewed-by: Andrew Bartlett
commit 991d32a1756e92db728abf17e12457fc9ac8c9b1
Author: Tim Beale
Date: Tue Mar 26 18:06:16 2019 +1300
s4/torture: Update winsreplication to only use IPv4 addresses
This test was failing now that the client had an IPv6 address, however,
the test was marked as flapping so this failure wasn't obvious.
Use iface_list_n_is_v4() to filter out only the IPv4 addresses, as
that's all the test cares about.
Signed-off-by: Tim Beale
Reviewed-by: Andrew Bartlett
commit a4d433aede8e08c1fec91ddb9ee7754275a13437
Author: Tim Beale
Date: Mon Mar 18 17:55:39 2019 +1300
selftest: Restore IPs 12-16 for selftest client
The assumption that tests only used the .11 IP was wrong. The
winsreplication test tries to use multiple different IPs - CI doesn't
fail when we remove the additional IPs, but it starts to skip test
cases.
+ Update get_interfaces_config() and get_ipv4_addr() so we can add
multiple different IPs for the same host.
+ Update selftest.pl so the client gets 6 IP addresses.
+ Update comments to better reflect this dependency.
Signed-off-by: Tim Beale
Reviewed-by: Andrew Bartlett
---
Summary of changes:
selftest/selftest.pl | 5 +-
selftest/selftesthelpers.py| 1 +
selftest/target/Samba.pm | 33 +--
source3/script/tests/test_smbstatus.sh | 155 +
source3/selftest/tests.py | 6 +-
source3/utils/status.c | 27 +-
source4/torture/nbt/winsreplication.c | 12 ++-
7 files changed, 223 insertions(+), 16 deletions(-)
create mode 100755 source3/script/tests/test_smbstatus.sh
Changeset truncated at 500 lines:
diff --git a/selftest/selftest.pl b/selftest/selftest.pl
index 52109e99b6f..228bb29ecfe 100755
--- a/selftest/selftest.pl
+++ b/selftest/selftest.pl
@@ -514,7 +514,10 @@ foreach (@opt_include) {
push (@includes, read_test_regexes($_));
}
-my $interfaces = Samba::get_interfaces_config("client");
+# We give the selftest client 6 different IPv4 addresses to use. Most tests
+# only use the first (.11) IP. Note that winsreplication.c is one test that
+# uses the other IPs (search for iface_list_count()).
+my $interfaces = Samba::get_interfaces_config("client", 6);
my $clientdir = "$prefix_abs/client";
diff --git a/selftest/selftesthelpers.py b/selftest/selftesthelpers.py
index 7513c265d17..1afabf3cdca 100644
--- a/selftest/selftesthelpers.py
+++ b/selftest/selftesthelpers.py
@@ -201,3 +201,4 @@ smbget = binpath('smbget')
rpcclient = binpath('rpcclient')
smbcacls = binpath('smbcacls')
smbcontrol = binpath('smbcontrol')
+smbstatus = binpath('smbstatus')
diff --git a/selftest/target/Samba.pm b/selftest/target/Samba.pm
index f7332da893e..6f28a017b17 100644
--- a/selftest/target/Samba.pm
+++ b/selftest/target/Samba.pm
@@ -437,12 +437,11 @@ sub get_interface($)
localnt4dc9 => 9,
# 10 is spare
- # 11 is used by selftest.pl for the client interface
+ # 11-16 are used by selftest.pl for the client.conf. Most tests
only
+ # use the first .11 IP.
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 3e1d8ab1255 libsmb: Change cli_posix_readlink to return talloc'ed
target
via 3478e9d124f libsmb: Don't pass "cli" to cli_posix_readlink_recv
via c7fae52ff09 libsmb: Rename "readlink_state" to
"cli_posix_readlink_state"
via f9a6992e802 libsmb: Fix valgrind errors in
cli_smb2_get_reparse_point
from ac487bf4d04 lib: Make fd_load work for non-regular files
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 3e1d8ab1255f1797a1803494b6333dc7990e0795
Author: Volker Lendecke
Date: Tue Mar 26 09:48:16 2019 +0100
libsmb: Change cli_posix_readlink to return talloc'ed target
This is a deviation from the Posix readlink function that from my
point of view makes this function easier to use. In Posix, probably
the assumption is that readlink is cheap, so someone under memory
constraints could just start with a small buffer and incrementally
increase the buffer size. For us, it's a network round-trip, and we
have the luxury of [mt]alloc, which the syscall kernel interface does
not have.
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Wed Mar 27 12:31:37 UTC 2019 on sn-devel-144
commit 3478e9d124f95344d67f1794e92658fa253b48fd
Author: Volker Lendecke
Date: Mon Mar 25 12:32:07 2019 +0100
libsmb: Don't pass "cli" to cli_posix_readlink_recv
From my point of view the option to change "cli" between
cli_posix_readlink_send and _recv is not necessary.
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
commit c7fae52ff09fca90e14231523fd3ec8ea6bdec55
Author: Volker Lendecke
Date: Mon Mar 25 12:26:37 2019 +0100
libsmb: Rename "readlink_state" to "cli_posix_readlink_state"
This is more in line with most other users of tevent_req: The state is
called fully after the routines it acts as a state repository for.
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
commit f9a6992e8027c119e7cf0426b46adb301083a7a5
Author: Volker Lendecke
Date: Tue Mar 26 10:56:27 2019 +0100
libsmb: Fix valgrind errors in cli_smb2_get_reparse_point
Both tevent_req_nterror and tevent_req_is_nterror invalidate
"state". Pull the variables out of "state" before calling those two
functions.
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
---
Summary of changes:
source3/client/client.c| 6 ++-
source3/libsmb/cli_smb2_fnum.c | 6 ++-
source3/libsmb/clifile.c | 106 +
source3/libsmb/proto.h | 14 +++---
source3/torture/torture.c | 8 ++--
5 files changed, 74 insertions(+), 66 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/client/client.c b/source3/client/client.c
index 366368630cb..a69ab5daa76 100644
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -3487,7 +3487,7 @@ static int cmd_readlink(void)
char *name= NULL;
char *buf = NULL;
char *targetname = NULL;
- char linkname[PATH_MAX+1];
+ char *linkname = NULL;
struct cli_state *targetcli;
NTSTATUS status;
@@ -3519,7 +3519,7 @@ static int cmd_readlink(void)
return 1;
}
- status = cli_posix_readlink(targetcli, name, linkname, PATH_MAX+1);
+ status = cli_posix_readlink(targetcli, name, talloc_tos(), );
if (!NT_STATUS_IS_OK(status)) {
d_printf("%s readlink on file %s\n",
nt_errstr(status), name);
@@ -3528,6 +3528,8 @@ static int cmd_readlink(void)
d_printf("%s -> %s\n", name, linkname);
+ TALLOC_FREE(linkname);
+
return 0;
}
diff --git a/source3/libsmb/cli_smb2_fnum.c b/source3/libsmb/cli_smb2_fnum.c
index 44786ca5912..33bc31592a4 100644
--- a/source3/libsmb/cli_smb2_fnum.c
+++ b/source3/libsmb/cli_smb2_fnum.c
@@ -5182,6 +5182,7 @@ static void cli_smb2_get_reparse_point_fnum_done(struct
tevent_req *subreq)
subreq, struct tevent_req);
struct cli_smb2_get_reparse_point_fnum_state *state = tevent_req_data(
req, struct cli_smb2_get_reparse_point_fnum_state);
+ struct cli_state *cli = state->cli;
NTSTATUS status;
status = smb2cli_ioctl_recv(subreq, state,
@@ -5189,7 +5190,7 @@ static void cli_smb2_get_reparse_point_fnum_done(struct
tevent_req *subreq)
>output_buffer);
TALLOC_FREE(subreq);
if (tevent_req_nterror(req, status)) {
- state->cli->raw_status = status;
+ cli->raw_status = status;
return;
}
tevent_req_done(req);
@@ -5203,8 +5204,9 @@ NTSTATUS
autobuild[sn-devel-144]: intermittent test failure detected
The autobuild test system (on sn-devel-144) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2019-03-27-1246/flakey.log The failure seems to be in the "samba-ad-dc-ntvfs" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-144/2019-03-27-1246/samba-ad-dc-ntvfs.stderr https://git.samba.org/autobuild.flakey.sn-devel-144/2019-03-27-1246/samba-ad-dc-ntvfs.stdout The top commit at the time of the failure was: commit ac487bf4d04c9771ada1ca7eeb9dac4e5fe34185 Author: Volker Lendecke Date: Thu Feb 21 18:37:08 2019 +0100 lib: Make fd_load work for non-regular files Follow-up to https://lists.samba.org/archive/samba/2018-September/217992.html and following. This also fixes a small and very theoretical race: Between the fstat and the read call the file size might change. This would make us fail on potentially legitimate files. This is more complex and probably slower, but looking at the use cases I don't think the speed matters. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13859 Signed-off-by: Volker Lendecke Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue Mar 26 04:43:40 UTC 2019 on sn-devel-144 and the last 50 lines of the stdout log were: [215(856)/252 at 20m29s] samba4.smb.signing on with -k yes --signing=on(ad_dc_ntvfs) [216(857)/252 at 20m30s] samba4.smb.signing on with -k yes --signing=required(ad_dc_ntvfs) [217(858)/252 at 20m31s] samba4.smb.signing on with -k yes --option=gensec:fake_gssapi_krb5=yes --option=gensec:gssapi_krb5=no --signing=on(ad_dc_ntvfs) [218(859)/252 at 20m32s] samba4.smb.signing on with -k yes --option=gensec:fake_gssapi_krb5=yes --option=gensec:gssapi_krb5=no --signing=required(ad_dc_ntvfs) [219(860)/252 at 20m33s] samba4.smb.signing --signing=yes anon(ad_dc_ntvfs) [220(861)/252 at 20m33s] samba4.smb.signing --signing=required anon(ad_dc_ntvfs) [221(862)/252 at 20m34s] samba.tests.complex_expressions(ad_dc_ntvfs) [222(884)/252 at 20m43s] samba.tests.samba_tool.gpo(ad_dc_ntvfs:local) [223(896)/252 at 21m37s] samba.tests.dcerpc.registry(ad_dc_ntvfs:local) [224(899)/252 at 21m38s] samba.tests.dcerpc.dnsserver(ad_dc_ntvfs) [225(916)/252 at 21m58s] samba.tests.auth_log(ad_dc_ntvfs:local) [226(963)/252 at 22m42s] samba.tests.auth_log_pass_change(ad_dc_ntvfs) [227(971)/252 at 22m53s] samba.tests.auth_log_ncalrpc(ad_dc_ntvfs:local) [228(973)/252 at 22m54s] samba.tests.auth_log_samlogon(ad_dc_ntvfs:local) [229(974)/252 at 22m56s] samba.tests.auth_log_netlogon(ad_dc_ntvfs:local) [230(975)/252 at 22m57s] samba.tests.auth_log_netlogon_bad_creds(ad_dc_ntvfs:local) [231(979)/252 at 23m0s] samba.tests.password_hash_fl2008(ad_dc_ntvfs:local) [232(983)/252 at 23m3s] samba.tests.krb5_credentials(ad_dc_ntvfs) [233(986)/252 at 23m6s] samba.tests.py_credentials(ad_dc_ntvfs) [234(994)/252 at 23m13s] samba.tests.emulate.traffic(ad_dc_ntvfs) [235(996)/252 at 23m13s] samba.tests.emulate.traffic_packet(ad_dc_ntvfs) [236(1085)/252 at 25m20s] samba.tests.blackbox.traffic_replay(ad_dc_ntvfs) [237(1090)/252 at 25m56s] samba.tests.blackbox.traffic_learner(ad_dc_ntvfs) [238(1092)/252 at 25m58s] samba.tests.blackbox.traffic_summary(ad_dc_ntvfs) [239(1092)/252 at 25m59s] samba.tests.blackbox.smbcontrol(ad_dc_ntvfs:local) [240(1094)/252 at 26m2s] samba4.urgent_replication.python(ad_dc_ntvfs)(ad_dc_ntvfs:local) [241(1102)/252 at 26m9s] samba4.ldap.match_rules.python(ad_dc_ntvfs) [242(1136)/252 at 26m41s] samba4.ldap.notification.python(ad_dc_ntvfs)(ad_dc_ntvfs) UNEXPECTED(failure): samba4.ldap.notification.python(ad_dc_ntvfs).__main__.LDAPNotificationTest.test_simple_search(ad_dc_ntvfs) REASON: Exception: Exception: Traceback (most recent call last): File "/memdisk/autobuild/fl/b1806530/samba-ad-dc-ntvfs/source4/dsdb/tests/python/notification.py", line 151, in test_simple_search self.assertIsNotNone(msg3) AssertionError: unexpectedly None FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba.tests.emulate.traffic_packet(ad_dc_ntvfs) -> 126 samba4.raw.notify(ad_dc_ntvfs) -> 112 samba4.ntvfs.cifs.krb5.base.deny2(ad_dc_ntvfs) -> 59 samba4.base.deny2(ad_dc_ntvfs) -> 58 samba.tests.samba_tool.gpo(ad_dc_ntvfs:local) -> 55 samba4.ntvfs.cifs.krb5.base.deny1(ad_dc_ntvfs) -> 54 samba4.base.deny1(ad_dc_ntvfs) -> 53 samba.tests.auth_log(ad_dc_ntvfs:local) -> 44 samba4.smb2.oplock(ad_dc_ntvfs) -> 42 samba4.ntvfs.cifs.krb5.base.delete(ad_dc_ntvfs) -> 41 ERROR: test failed with exit code 1
autobuild[sn-devel-184]: intermittent test failure detected
The autobuild test system (on sn-devel-184) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-03-27-0944/flakey.log The failure seems to be in the "ctdb" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-03-27-0944/ctdb.stderr https://git.samba.org/autobuild.flakey.sn-devel-184/2019-03-27-0944/ctdb.stdout The top commit at the time of the failure was: commit ac487bf4d04c9771ada1ca7eeb9dac4e5fe34185 Author: Volker Lendecke Date: Thu Feb 21 18:37:08 2019 +0100 lib: Make fd_load work for non-regular files Follow-up to https://lists.samba.org/archive/samba/2018-September/217992.html and following. This also fixes a small and very theoretical race: Between the fstat and the read call the file size might change. This would make us fail on potentially legitimate files. This is more complex and probably slower, but looking at the use cases I don't think the speed matters. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13859 Signed-off-by: Volker Lendecke Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue Mar 26 04:43:40 UTC 2019 on sn-devel-144 and the last 50 lines of the stdout log were: PASSED tests/tool/ctdb.stop.002.sh PASSED tests/tool/ctdb.stop.003.sh PASSED tests/tool/ctdb.unban.001.sh PASSED tests/tool/ctdb.unban.002.sh PASSED tests/tool/ctdb.unban.003.sh PASSED tests/tool/ctdb.uptime.001.sh PASSED tests/tool/ctdb.writekey.001.sh PASSED tests/simple/00_ctdb_onnode.sh PASSED tests/simple/01_ctdb_reclock_command.sh PASSED tests/simple/02_ctdb_tunables.sh PASSED tests/simple/05_ctdb_listnodes.sh PASSED tests/simple/06_ctdb_getpid.sh PASSED tests/simple/07_ctdb_process_exists.sh PASSED tests/simple/08_ctdb_isnotrecmaster.sh PASSED tests/simple/09_ctdb_ping.sh PASSED tests/simple/11_ctdb_ip.sh PASSED tests/simple/12_ctdb_getdebug.sh PASSED tests/simple/13_ctdb_setdebug.sh PASSED tests/simple/14_ctdb_statistics.sh PASSED tests/simple/15_ctdb_statisticsreset.sh PASSED tests/simple/16_ctdb_config_add_ip.sh PASSED tests/simple/17_ctdb_config_delete_ip.sh PASSED tests/simple/18_ctdb_reloadips.sh PASSED tests/simple/19_ip_takeover_noop.sh PASSED tests/simple/20_delip_iface_gc.sh PASSED tests/simple/21_ctdb_attach.sh PASSED tests/simple/23_ctdb_moveip.sh PASSED tests/simple/24_ctdb_getdbmap.sh PASSED tests/simple/25_dumpmemory.sh PASSED tests/simple/26_ctdb_config_check_error_on_unreachable_ctdb.sh PASSED tests/simple/27_ctdb_detach.sh PASSED tests/simple/28_zero_eventscripts.sh PASSED tests/simple/32_ctdb_disable_enable.sh PASSED tests/simple/35_ctdb_getreclock.sh PASSED tests/simple/42_ctdb_stop_continue.sh PASSED tests/simple/43_stop_recmaster_yield.sh PASSED tests/simple/51_message_ring.sh PASSED tests/simple/52_fetch_ring.sh PASSED tests/simple/53_transaction_loop.sh PASSED tests/simple/54_transaction_loop_recovery.sh PASSED tests/simple/55_ctdb_ptrans.sh PASSED tests/simple/56_replicated_transaction_recovery.sh PASSED tests/simple/58_ctdb_restoredb.sh *FAILED* tests/simple/60_recoverd_missing_ip.sh 517/518 tests passed Removing TEST_VAR_DIR=tests/var autotest exited with exit status 1 Makefile:22: recipe for target 'autotest' failed
