[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 1958cd8a7fb ldap server: generate correct referral schemes
via 6ccf74cf878 ldap tests: test scheme for referrals
via 163897f1253 selftest: Use scalar variable for new daemon_ctx hashmap
via b976502d496 selftest: Add common fork_and_exec() function
via 746e13e selftest: Rework setting env variables for other forked
binaries
via ae3e33d4929 selftest: Rework setting env variables for nmbd
via c79f0c19755 selftest: Store fork-and-exec daemon info in a hashmap
via ad30fdc6ba2 selftest: Add helper function to build up s3 daemon cmd
via ba9323abde0 selftest: Move fork cmd args up a level
via 0fd3685cfd8 selftest: remove unused variable (@optargs)
via a60e59735c2 selftest: Refactor duplicated code to set ENV vars
via d2f54775d3f selftest: Run samba3.srvsvc tests covering more of the
srvsvc server
via 773e476203f selftest: Remove infinite client/server loop in
srvsvc_NetNameValidate test
via 8dd0421a428 selftest: Add more testing of wkssvc in source3
via 430968b32dc Run test for initshutdown
from e7424897a12 ctdb: Make TDB_SEQNUM work synchronously with ctdb
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 1958cd8a7fb81ec51b81944ecf4dd0fb5c4208fa
Author: Gary Lockyer
Date: Tue May 21 13:17:22 2019 +1200
ldap server: generate correct referral schemes
Ensure that the referrals returned in a search request use the same
scheme as the request, i.e. referrals recieved via ldap are prefixed
with "ldap://; and those over ldaps are prefixed with "ldaps://"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12478
Signed-off-by: Gary Lockyer
Reviewed-by: Andrew Bartlett
Autobuild-User(master): Andrew Bartlett
Autobuild-Date(master): Fri May 24 05:12:14 UTC 2019 on sn-devel-184
commit 6ccf74cf878c295903673e3a1d1ed924a5e87547
Author: Gary Lockyer
Date: Tue May 21 13:14:08 2019 +1200
ldap tests: test scheme for referrals
Ensure that the referrals returned in a search request use the same
scheme as the request, i.e. referrals recieved via ldap are prefixed
with "ldap://; and those over ldaps are prefixed with "ldaps://"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12478
Signed-off-by: Gary Lockyer
Reviewed-by: Andrew Bartlett
commit 163897f12538ae12dbc2bd556adcc1abc4f0f438
Author: Tim Beale
Date: Thu May 23 16:58:20 2019 +1200
selftest: Use scalar variable for new daemon_ctx hashmap
The selftest code typically stores hashmaps as scalar variables (i.e.
it only ever uses references to hashmaps). So much so that using a regular
hashmap (and passing it by reference via \%daemon_ctx) looks out of
place.
Using the hashmap directly made more sense when it was only being used
locally, but now the hashmap is being passed by reference into a function
anyway, so storing it as a scalar doesn't make much difference.
Signed-off-by: Tim Beale
Reviewed-by: Andrew Bartlett
commit b976502d496cca0e8e04a2e5f2c72383efb296a7
Author: Tim Beale
Date: Thu May 23 16:35:07 2019 +1200
selftest: Add common fork_and_exec() function
Now the code has been refactored, we can move it into a common function.
This reduces code duplication and means we have a common place where we
start samba daemons from.
Note that some daemons behave slightly different, but the $daemon_ctx
allows us to customize their behaviour a bit.
Signed-off-by: Tim Beale
Reviewed-by: Andrew Bartlett
commit 746e13e559afb7851a359d56580c58231ddd
Author: Tim Beale
Date: Thu May 23 15:47:46 2019 +1200
selftest: Rework setting env variables for other forked binaries
Final refactor to merge the fork-and-exec code into a common function.
We can now use $daemon_ctx{ENV_VARS} to customize differences between
the forked binaries:
- samba: add in extra env variables on top of the defaults.
- dns_hub: there are no ENV variables we need to export.
- winbindd/smbd: these use the defaults, so they pass through an
undefined $daemon_ctx{ENV_VARS} (purely to make the code common across
all 5 places).
Signed-off-by: Tim Beale
Reviewed-by: Andrew Bartlett
commit ae3e33d492904ae05d4ff24c3d8f50fecaca2971
Author: Tim Beale
Date: Thu May 23 15:47:46 2019 +1200
selftest: Rework setting env variables for nmbd
Instead of having a special $skip_resolv_conf parameter just for nmbd,
use the get_env_for_process() API and customize the hashmap returned.
Pass the customized hashmap in as an optional part of the daemon_ctx.
Signed-off-by: Tim Beale
Reviewed-by: Andrew Bartlett
commit c79f0c197558e86fe4f9e27b0c4682441bb55b0b
Author:
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via e7424897a12 ctdb: Make TDB_SEQNUM work synchronously with ctdb
via 78a4639b2d0 vfs_fruit: change trigger points of AppleDouble
conversion
via 4777d1163a7 vfs_fruit: add a forward declaration for ad_get()
via 8ed9b6b4579 selftest: run vfs.fruit test against a share that
deletes empty resource forks
via bb5a457f287 s4:torture/vfs/fruit: ensure
test_adouble_conversion_wo_xattr() uses a non-emtpy resourcefork
via c3d28d49be3 s4:torture/vfs/fruit: ensure test_adouble_conversion()
uses a non-emtpy resourcefork
via cb6525e8681 libsmbconf:registry: Return correct case for get_share
via 91350d562b6 net: Return share name in correct case from net rpc
conf showshare
via f58127d0248 selftest: Add test for case-preserving in 'net [rpc]
conf showshare'
from 1f9b8964ca8 ctdb: Remove unused ctdb_ltdb_fetch_with_header()
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit e7424897a1272490b78c08f78ce7b260eb014f20
Author: Volker Lendecke
Date: Mon May 20 16:01:03 2019 +0200
ctdb: Make TDB_SEQNUM work synchronously with ctdb
Old war story completely from memory, I could not find the commit that
introduced TDB_SEQNUM so far...:
Back in the days when ctdb was initially developed, TDB_SEQNUM's only
user was the notify.tdb that held one huge record for all notify
records. With that use case in mind it made perfect sense to keep the
SEQNUM stable locally, sacrificing precision. By now notify.tdb is
long gone, an the only user of TDB_SEQNUM right now is brlock.tdb,
which contains special case code for the imprecise ctdb implementation
of TDB_SEQNUM.
With this commit, that special code can go: The TDB_SEQNUM will also
increment when just the DMASTER header field changes, indicating to
smbd that someone else might have changed the record. This will of
course increase the SEQNUM frequency, but it should not increase the
load on ctdb: If you look at the brlock.c workaround, it just does not
do the caching that is possible with precise TDB_SEQNUMs working.
How did I get here? I want to move brl_num_read_oplocks() from
brlock.tdb into locking.tdb, and for that I need precise TDB_SEQNUMs
for locking.tdb.
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Fri May 24 00:42:17 UTC 2019 on sn-devel-184
commit 78a4639b2d06cc69788861618d2e91945e142d2b
Author: Ralph Boehme
Date: Tue May 21 16:00:53 2019 +0200
vfs_fruit: change trigger points of AppleDouble conversion
This moves the trigger points where AppleDouble file conversion is run by
ad_convert() from deep down the callchain in ad_read_rsrc_adouble() to high
level VFS entry points.
Currently ad_convert() will be triggered as part of open_file_ntcreate(...,
"file:AFP_AfpResource", ...): after SMB_VFS_OPEN() has been called with
O_CREAT,
what created the file, we call SMB_VFS_FSTAT() on the just created
filehandle. This ends up in ad_convert(), finds the resource fork empty and
thus
deletes the file.
This commit moves calling of the conversion funtion to the high level VFS
entry
points where the converted metadata is needed:
o for directory enumerations SMB_VFS_READDIR_ATTR() is called to fill in the
repurposed fields in the directory entry metadata
o obviously for SMB_VFS_CREATE_FILE() on an macOS stream
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
commit 4777d1163a7c18c89ce9be955903427a18134415
Author: Ralph Boehme
Date: Tue May 21 16:00:00 2019 +0200
vfs_fruit: add a forward declaration for ad_get()
Will be needed in the next commit.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
commit 8ed9b6b457923d2353d1d18838f4a278db48c6b9
Author: Ralph Boehme
Date: Tue May 21 14:05:04 2019 +0200
selftest: run vfs.fruit test against a share that deletes empty resource
forks
This reveals a bug in the AppleDouble conversion code: the conversion code
that
unlinks an empty resource fork AppleDouble sidecar file ("._file") gets
triggered as part of open_file_ntcreate(..., "file:AFP_AfpResource", ...):
after SMB_VFS_OPEN() has been called with O_CREAT, what created the file, we
call SMB_VFS_FSTAT() on the just created filehandle. This ends up in
ad_convert(), finds the resource fork empty and thus deletes the file.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13958
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
commit
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 1f9b8964ca8 ctdb: Remove unused ctdb_ltdb_fetch_with_header()
via 1a59b0fa638 smbd: Calculate delay_mask only once in delay_for_oplock
via 77e37850fde tdb: Fix typo in README
via 564e0f25664 smbd: Merge "print_lock_struct" into one DBG
from 1a9da378a15 sambaundoguididx: Add flags=ldb.FLG_DONT_CREATE_DB and
port to Python3
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 1f9b8964ca868f70adee0f63e1df67a08d611bf2
Author: Volker Lendecke
Date: Mon May 20 15:12:56 2019 +0200
ctdb: Remove unused ctdb_ltdb_fetch_with_header()
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Thu May 23 18:08:36 UTC 2019 on sn-devel-184
commit 1a59b0fa638ce33f7a7fda07f26509a3370b76b4
Author: Volker Lendecke
Date: Fri May 17 15:29:59 2019 +0200
smbd: Calculate delay_mask only once in delay_for_oplock
"const" ist just a hint to make sure it's actually not modified inside
the loop
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
commit 77e37850fde550abcf1ce7e4eb8341b5022845f8
Author: Volker Lendecke
Date: Mon May 20 14:55:31 2019 +0200
tdb: Fix typo in README
README is far from a complete, good and accurate document, but what's
in there should at least not have obvious errors.
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
commit 564e0f25664b60f27d57bf1eab05e613db027d71
Author: Volker Lendecke
Date: Mon May 20 13:52:12 2019 +0200
smbd: Merge "print_lock_struct" into one DBG
Also, avoid some casts
Signed-off-by: Volker Lendecke
Reviewed-by: Jeremy Allison
---
Summary of changes:
ctdb/common/common.h | 4
ctdb/common/ctdb_ltdb.c | 35 ---
lib/tdb/docs/README | 4 ++--
source3/locking/brlock.c | 24
source3/smbd/open.c | 9 ++---
5 files changed, 16 insertions(+), 60 deletions(-)
Changeset truncated at 500 lines:
diff --git a/ctdb/common/common.h b/ctdb/common/common.h
index 02bb746c9b3..6b2c98ef383 100644
--- a/ctdb/common/common.h
+++ b/ctdb/common/common.h
@@ -61,10 +61,6 @@ int ctdb_ltdb_fetch(struct ctdb_db_context *ctdb_db,
TDB_DATA key, struct ctdb_ltdb_header *header,
TALLOC_CTX *mem_ctx, TDB_DATA *data);
-int ctdb_ltdb_fetch_with_header(struct ctdb_db_context *ctdb_db,
- TDB_DATA key, struct ctdb_ltdb_header *header,
- TALLOC_CTX *mem_ctx, TDB_DATA *data);
-
int ctdb_ltdb_store(struct ctdb_db_context *ctdb_db, TDB_DATA key,
struct ctdb_ltdb_header *header, TDB_DATA data);
diff --git a/ctdb/common/ctdb_ltdb.c b/ctdb/common/ctdb_ltdb.c
index f4f216e1ee3..de4f44895e4 100644
--- a/ctdb/common/ctdb_ltdb.c
+++ b/ctdb/common/ctdb_ltdb.c
@@ -221,41 +221,6 @@ int ctdb_ltdb_fetch(struct ctdb_db_context *ctdb_db,
return 0;
}
-/*
- fetch a record from the ltdb, separating out the header information
- and returning the body of the record.
- if the record does not exist, *header will be NULL
- and data = {0, NULL}
-*/
-int ctdb_ltdb_fetch_with_header(struct ctdb_db_context *ctdb_db,
- TDB_DATA key, struct ctdb_ltdb_header *header,
- TALLOC_CTX *mem_ctx, TDB_DATA *data)
-{
- TDB_DATA rec;
-
- rec = tdb_fetch(ctdb_db->ltdb->tdb, key);
- if (rec.dsize < sizeof(*header)) {
- free(rec.dptr);
-
- data->dsize = 0;
- data->dptr = NULL;
- return -1;
- }
-
- *header = *(struct ctdb_ltdb_header *)rec.dptr;
- if (data) {
- data->dsize = rec.dsize - sizeof(struct ctdb_ltdb_header);
- data->dptr = talloc_memdup(mem_ctx,
- sizeof(struct
ctdb_ltdb_header)+rec.dptr,
- data->dsize);
- }
-
- free(rec.dptr);
-
- return 0;
-}
-
-
/*
write a record to a normal database
*/
diff --git a/lib/tdb/docs/README b/lib/tdb/docs/README
index be2224f1d84..86d46a38ac2 100644
--- a/lib/tdb/docs/README
+++ b/lib/tdb/docs/README
@@ -206,13 +206,13 @@ int tdb_writeunlock(TDB_CONTEXT *tdb);
unlock the database
--
-int tdb_lockchain(TDB_CONTEXT *tdb, TDB_DATA key);
+int tdb_chainlock(TDB_CONTEXT *tdb, TDB_DATA key);
lock one hash chain. This is meant to be used to reduce locking
contention - it cannot guarantee how many records will be locked
--
-int
autobuild[sn-devel-184]: intermittent test failure detected
The autobuild test system (on sn-devel-184) has detected an intermittent
failing test in
the current master tree.
The autobuild log of the failure is available here:
https://git.samba.org/autobuild.flakey.sn-devel-184/2019-05-23-1544/flakey.log
The failure seems to be in the "samba-ad-member" suite, whose build logs are
available here:
https://git.samba.org/autobuild.flakey.sn-devel-184/2019-05-23-1544/samba-ad-member.stderr
https://git.samba.org/autobuild.flakey.sn-devel-184/2019-05-23-1544/samba-ad-member.stdout
The top commit at the time of the failure was:
commit 1a9da378a1505daff498be6d6355debd73526a1a
Author: Andrew Bartlett
Date: Mon May 20 16:29:10 2019 +1200
sambaundoguididx: Add flags=ldb.FLG_DONT_CREATE_DB and port to Python3
In py3 we need to add an extra str() around the returned ldb value to
enable .split() to be used.
Signed-off-by: Andrew Bartlett
Reviewed By: Noel Power
Autobuild-User(master): Noel Power
Autobuild-Date(master): Thu May 23 14:25:52 UTC 2019 on sn-devel-184
and the last 50 lines of the stdout log were:
[71(592)/85 at 6m49s] samba.wbinfo_simple.domain-groups(ad_member:local)
[72(593)/85 at 6m49s]
samba.wbinfo_simple.name-to-sid=$DC_USERNAME(ad_member:local)
[73(594)/85 at 6m49s]
samba.wbinfo_simple.name-to-sid=$DOMAIN/$DC_USERNAME(ad_member:local)
[74(595)/85 at 6m50s]
samba.wbinfo_simple.user-info=$DOMAIN/$DC_USERNAME(ad_member:local)
[75(596)/85 at 6m50s]
samba.wbinfo_simple.user-groups=$DOMAIN/$DC_USERNAME(ad_member:local)
[76(597)/85 at 6m50s]
samba.wbinfo_simple.authenticate=$DOMAIN/$DC_USERNAME%$DC_PASSWORD(ad_member:local)
[77(598)/85 at 6m51s] samba.wbinfo_simple.allocate-uid(ad_member:local)
[78(599)/85 at 6m51s] samba.wbinfo_simple.allocate-gid(ad_member:local)
[79(600)/85 at 6m51s] samba.wbinfo_sids2xids.(ad_member:local)(ad_member:local)
[80(601)/85 at 7m4s] samba.tests.ntlm_auth(ad_member:local)
[81(614)/85 at 7m9s] samba.nss.test using
winbind(ad_member:local)(ad_member:local)
[82(615)/85 at 7m9s] samba.tests.auth_log_winbind(ad_member:local)
WARNING: The "server schannel" option is deprecated
INFO: Received PING message from server 1436047.8 []
{"timestamp": "2019-05-23T15:44:10.745026+", "type": "Authentication",
"Authentication": {"version": {"major": 1, "minor": 2}, "eventId": 4624,
"logonId": "8ff3ccf6c78399e2", "logonType": 3, "status": "NT_STATUS_OK",
"localAddress": "ipv4:127.0.0.30:1026", "remoteAddress":
"ipv4:127.0.0.29:48334", "serviceDescription": "SamLogon", "authDescription":
"network", "clientDomain": "ADDOMAIN", "clientAccount": "Administrator",
"workstation": "LOCALADMEMBER", "becameAccount": "Administrator",
"becameDomain": "ADDOMAIN", "becameSid":
"S-1-5-21-4122807374-821037944-1796787775-500", "mappedAccount":
"Administrator", "mappedDomain": "ADDOMAIN", "netlogonComputer":
"LOCALADMEMBER", "netlogonTrustAccount": "LOCALADMEMBER$",
"netlogonNegotiateFlags": "0x610F", "netlogonSecureChannelType": 2,
"netlogonTrustAccountSid": "S-1-5-21-4122807374-821037944-1796787775-1109",
"passwordType": "NTLMv1", "duration": 6719}}
INFO: Received PING message from server 1438325.2610234216 []
{"timestamp": "2019-05-23T15:44:10.731008+", "type": "Authentication",
"Authentication": {"version": {"major": 1, "minor": 2}, "eventId": 4625,
"logonId": "15d282a9858b002c", "logonType": 2, "status":
"NT_STATUS_NO_SUCH_USER", "localAddress": "unix:", "remoteAddress": "unix:",
"serviceDescription": "winbind", "authDescription": "PASSDB, wbinfo, 1438253",
"clientDomain": "", "clientAccount": "Administrator", "workstation":
"LOCALADMEMBER", "becameAccount": null, "becameDomain": null, "becameSid":
null, "mappedAccount": "Administrator", "mappedDomain": "", "netlogonComputer":
null, "netlogonTrustAccount": null, "netlogonNegotiateFlags": "0x",
"netlogonSecureChannelType": 0, "netlogonTrustAccountSid": null,
"passwordType": "NTLMv2", "duration": 183}}
INFO: Received PING message from server 1438325.4146861396 []
{"timestamp": "2019-05-23T15:44:10.736150+", "type": "Authentication",
"Authentication": {"version": {"major": 1, "minor": 2}, "eventId": 4625,
"logonId": "15d282a9858b002c", "logonType": 8, "status":
"NT_STATUS_INVALID_HANDLE", "localAddress": "unix:", "remoteAddress": "unix:",
"serviceDescription": "winbind", "authDescription": "PAM_AUTH, wbinfo,
1438253", "clientDomain": "", "clientAccount": "Administrator", "workstation":
null, "becameAccount": "", "becameDomain": "", "becameSid": null,
"mappedAccount": null, "mappedDomain": null, "netlogonComputer": null,
"netlogonTrustAccount": null, "netlogonNegotiateFlags": "0x",
"netlogonSecureChannelType": 0, "netlogonTrustAccountSid": null,
"passwordType": "Plaintext", "duration": 5442}}
INFO: Received PING message from server 1438271.1774583989 []
{"timestamp": "2019-05-23T15:44:10.746316+", "type": "Authentication",
"Authentication": {"version": {"major": 1,
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 1a9da378a15 sambaundoguididx: Add flags=ldb.FLG_DONT_CREATE_DB and
port to Python3
from 3b608510e4b third_party: Update nss_wrapper to version 1.1.6
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 1a9da378a1505daff498be6d6355debd73526a1a
Author: Andrew Bartlett
Date: Mon May 20 16:29:10 2019 +1200
sambaundoguididx: Add flags=ldb.FLG_DONT_CREATE_DB and port to Python3
In py3 we need to add an extra str() around the returned ldb value to
enable .split() to be used.
Signed-off-by: Andrew Bartlett
Reviewed By: Noel Power
Autobuild-User(master): Noel Power
Autobuild-Date(master): Thu May 23 14:25:52 UTC 2019 on sn-devel-184
---
Summary of changes:
source4/scripting/bin/sambaundoguididx | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/scripting/bin/sambaundoguididx
b/source4/scripting/bin/sambaundoguididx
index 00fe63897b4..f67353ff361 100755
--- a/source4/scripting/bin/sambaundoguididx
+++ b/source4/scripting/bin/sambaundoguididx
@@ -34,7 +34,9 @@ if opts.H is None:
else:
url = opts.H
-samdb = ldb.Ldb(url=url, options=["modules:"])
+samdb = ldb.Ldb(url=url,
+flags=ldb.FLG_DONT_CREATE_DB,
+options=["modules:"])
partitions = samdb.search(base="@PARTITION",
scope=ldb.SCOPE_BASE,
@@ -58,10 +60,11 @@ privatedir = os.path.dirname(url)
dbs = []
for part in partitions[0]['partition']:
-tdbname = part.split(":")[1]
-tdbpath = os.path.join(privatedir, tdbname)
-
-db = ldb.Ldb(url=tdbpath, options=["modules:"])
+dbname = str(part).split(":")[1]
+dbpath = os.path.join(privatedir, dbname)
+db = ldb.Ldb(url="ldb://" + dbpath,
+ options=["modules:"],
+ flags=ldb.FLG_DONT_CREATE_DB)
db.transaction_start()
db.modify(modmsg)
dbs.append(db)
@@ -73,7 +76,8 @@ samdb.transaction_commit()
print("Re-opening with the full DB stack")
samdb = SamDB(url=url,
- lp=lp_ctx)
+ flags=ldb.FLG_DONT_CREATE_DB,
+ lp=lp_ctx)
print("Re-triggering another re-index")
chk = dbcheck(samdb)
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 3b608510e4b third_party: Update nss_wrapper to version 1.1.6 via d9af3dc02e9 s3:smbspool: Use NTSTATUS return codes via 93acd880801 s3:smbspool: Add debug messages to kerberos_ccache_is_valid() via 3d719a1f85d s3:smbspool: Always try to authenticate using Kerberos via 281274572bc s3:smbspool: Print the filename we failed to open via 6bbdf69e406 s3:smbspool: Fallback to default ccache if KRB5CCNAME is not set via be596ce3d24 s3:smbspool: Use %u format specifier to print uid via 3632bfef25e s3:smbspool: Add debug for finding KRB5CCNAME via 42492d54766 s3:smbspool: Print the principal we use to authenticate with via 6086efb6808 s3:smbspool: Add the 'lp' group to the users groups from 30622ed876c smbd: Fix a panic https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 3b608510e4be190d2aacf69dceefc937a25e10e7 Author: Andreas Schneider Date: Tue May 21 08:00:05 2019 +0200 third_party: Update nss_wrapper to version 1.1.6 Signed-off-by: Andreas Schneider Reviewed-by: Gary Lockyer Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Thu May 23 11:10:28 UTC 2019 on sn-devel-184 commit d9af3dc02e98a3eb22441dfbdeddbaca0af078ea Author: Andreas Schneider Date: Tue May 14 11:35:46 2019 +0200 s3:smbspool: Use NTSTATUS return codes This allows us to simplify some code and return better errors. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner commit 93acd880801524c5e621df7b5bf5ad650f93cec3 Author: Andreas Schneider Date: Thu May 16 18:24:32 2019 +0200 s3:smbspool: Add debug messages to kerberos_ccache_is_valid() BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner commit 3d719a1f85db8e423dc3a4116a2228961d5ac48d Author: Andreas Schneider Date: Mon May 13 18:54:02 2019 +0200 s3:smbspool: Always try to authenticate using Kerberos If username and password is given, then fallback to NTLM. However try kinit first. Also we correctly handle NULL passwords in the meantime and this makes it easier to deal with issues. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner commit 281274572bcc3125fe6026a01ef7bf7ef584a0dd Author: Andreas Schneider Date: Mon May 13 16:48:31 2019 +0200 s3:smbspool: Print the filename we failed to open BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner commit 6bbdf69e406916107400e2cabdbc831e2a2bbee3 Author: Andreas Schneider Date: Thu May 16 17:40:43 2019 +0200 s3:smbspool: Fallback to default ccache if KRB5CCNAME is not set This could also support the new KCM credential cache storage. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner commit be596ce3d2455bd49a8ebd311d8c764c37852858 Author: Andreas Schneider Date: Thu May 16 17:10:57 2019 +0200 s3:smbspool: Use %u format specifier to print uid BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner commit 3632bfef25e471075886eb7aecddd4cc260db8ba Author: Andreas Schneider Date: Thu May 16 14:25:00 2019 +0200 s3:smbspool: Add debug for finding KRB5CCNAME BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner commit 42492d547661cb7a98c237b32d42ee93de35aba5 Author: Andreas Schneider Date: Thu May 16 13:41:02 2019 +0200 s3:smbspool: Print the principal we use to authenticate with BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner commit 6086efb6808089c431e7307fa239924bfda1185b Author: Andreas Schneider Date: Mon May 13 16:55:49 2019 +0200 s3:smbspool: Add the 'lp' group to the users groups This is required to access files in /var/spool/cups which have been temporarily created in there by CUPS. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13939 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner --- Summary of changes: buildtools/wafsamba/samba_third_party.py | 2 +- source3/client/smbspool.c| 323 +++ source3/client/smbspool_krb5_wrapper.c | 101 +++--- source3/wscript_build| 1 +
