[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 7680010e3bc tests blackbox ndrdump: Clean up pep8 warnings via 532ba5a0693 ntprinting.idl: remove decode functions via 92d37950765 winsrepl.idl: remove unused decode functions via 2254d0e4b90 sasl_helpers.idl: remove unused decode functions via 883f2fa3d4d ntp_signd.idl: remove unused decode functions via dc786894252 security.idl: remove unused decode functions via c89cfbd15d8 preg.idl: remove unused decode functions via 939d72df4b5 negoex.idl: remove unused decode functions via f5cf33fa39d nbt.idl: remove unused decode functions via 66218cf1fb7 krb5pac.idl: remove unused decode functions via 1d89808dfbb cab.idl: remove unused decode functions via 52cb4f11dd8 dnsp.idl: remove unused decode functions via 0195e8d4642 ntlmssp.idl: remove unused decode functions via 41afed1189b drsblobs.idl: remove decode functions via 3bf05fbfd71 ndrdump: print public structures via 5d67e87d1c4 pidl: Allow ndrdump to print public structures via 0e771f0ed6c tests blackbox ndrdump: Add test for struct printing from a66af4c96ac s3:auth: explicitly add BUILTIN\Guests to the guest token https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 7680010e3bc7405e7350d7375cf02d61abd30849 Author: Gary Lockyer Date: Wed Jun 5 10:34:17 2019 +1200 tests blackbox ndrdump: Clean up pep8 warnings Clean up the test code and remove the pep8 warnings Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Thu Jun 6 04:58:18 UTC 2019 on sn-devel-184 commit 532ba5a069342c3a4508aac19491b439cae0ce87 Author: Gary Lockyer Date: Tue Jun 4 13:07:06 2019 +1200 ntprinting.idl: remove decode functions Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett commit 92d37950765a72f8a60b3aec27b73d1e0d6d184c Author: Gary Lockyer Date: Tue Jun 4 11:46:05 2019 +1200 winsrepl.idl: remove unused decode functions Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett commit 2254d0e4b90ff3ede7a5893a60299b699613e086 Author: Gary Lockyer Date: Tue Jun 4 11:45:40 2019 +1200 sasl_helpers.idl: remove unused decode functions Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett commit 883f2fa3d4d736be704063cd88b0d5b6ce6c76bd Author: Gary Lockyer Date: Tue Jun 4 11:44:46 2019 +1200 ntp_signd.idl: remove unused decode functions Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett commit dc78689425227e919b76b5f78470614b75764f45 Author: Gary Lockyer Date: Tue Jun 4 11:44:17 2019 +1200 security.idl: remove unused decode functions Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett commit c89cfbd15d8d7343a157baf2726d69f75dac950c Author: Gary Lockyer Date: Tue Jun 4 11:43:48 2019 +1200 preg.idl: remove unused decode functions Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett commit 939d72df4b5d01cac3e4233e20e4b48c99ecc6b7 Author: Gary Lockyer Date: Tue Jun 4 11:43:24 2019 +1200 negoex.idl: remove unused decode functions Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett commit f5cf33fa39d70722c69fd5d38d32f481aedcb645 Author: Gary Lockyer Date: Tue Jun 4 11:43:07 2019 +1200 nbt.idl: remove unused decode functions Remove the decode_* functions as they are no longer needed, and this will reduce the amount of untested automatically generated code. Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett commit 66218cf1fb7d2ea2c69ac4421f16c8c4bd62545d Author: Gary Lockyer Date: Tue Jun 4 11:42:44 2019 +1200 krb5pac.idl: remove unused decode functions Remove the
autobuild[sn-devel-184]: intermittent test failure detected
The autobuild test system (on sn-devel-184) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-06-06-0358/flakey.log The failure seems to be in the "samba-nt4" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-06-06-0358/samba-nt4.stderr https://git.samba.org/autobuild.flakey.sn-devel-184/2019-06-06-0358/samba-nt4.stdout The top commit at the time of the failure was: commit a66af4c96accba4ee64eeb1958458b69f3ccec1d Author: Ralph Boehme Date: Mon May 13 20:16:47 2019 +0200 s3:auth: explicitly add BUILTIN\Guests to the guest token This changes ensures that smbd always adds BUILTIN\Guests to the guest token which is required for guest authentication. Currently the guest token depends on the on-disk configured group mappings. If there's an existing group mapping for BUILTIN\Guests, but LOCALSAM\Guest is not a member, the final guest token won't contain BUILTIN\Guests. For SMB2 the flag SMB2_SESSION_FLAG_IS_GUEST will not be set in the final SMB2 SESSION_SETUP response, because smbd sets it based on the token containing the BUILTIN\Guests SID S-1-5-32-546. At the same time, the packet is not signed which causes Windows clients and smbclient to reject the unsigned SMB2 SESSION_SETUP response. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944 Pair-programmed-with: Stefan Metzmacher Signed-off-by: Ralph Boehme Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Wed Jun 5 16:55:26 UTC 2019 on sn-devel-184 and the last 50 lines of the stdout log were: [157(859)/591 at 16m52s] samba3.base.rename(nt4_dc) [158(860)/591 at 16m53s] samba3.base.rw1(nt4_dc) [159(861)/591 at 16m54s] samba3.base.rw1(nt4_dc) [160(862)/591 at 16m55s] samba3.base.rw1(nt4_dc) [161(863)/591 at 16m56s] samba3.base.secleak(nt4_dc) [162(864)/591 at 16m56s] samba3.base.tcon(nt4_dc) [163(865)/591 at 16m57s] samba3.base.tcondev(nt4_dc) [164(866)/591 at 16m58s] samba3.base.trans2(nt4_dc) [165(867)/591 at 17m1s] samba3.base.unlink(nt4_dc) [166(868)/591 at 17m2s] samba3.base.vuid(nt4_dc) [167(869)/591 at 17m3s] samba3.base.xcopy(nt4_dc) [168(870)/591 at 17m3s] samba3.base.samba3error(nt4_dc) [169(871)/591 at 17m4s] samba3.raw.acls(nt4_dc) [170(883)/591 at 17m8s] samba3.raw.acls nfs4acl_xattr-simple-40(nt4_dc) [171(895)/591 at 17m13s] samba3.raw.acls nfs4acl_xattr-special-40(nt4_dc) [172(907)/591 at 17m19s] samba3.raw.acls nfs4acl_xattr-simple-41(nt4_dc) [173(919)/591 at 17m22s] samba3.raw.acls nfs4acl_xattr-xdr-40(nt4_dc) [174(931)/591 at 17m25s] samba3.raw.acls nfs4acl_xattr-xdr-41(nt4_dc) [175(943)/591 at 17m28s] samba3.raw.acls nfs4acl_xattr-nfs-40(nt4_dc) [176(955)/591 at 17m32s] samba3.raw.acls nfs4acl_xattr-nfs-41(nt4_dc) [177(967)/591 at 17m35s] samba3.raw.chkpath(nt4_dc) [178(968)/591 at 17m36s] samba3.raw.close(nt4_dc) [179(969)/591 at 17m37s] samba3.raw.composite(nt4_dc) [180(973)/591 at 17m40s] samba3.raw.eas(nt4_dc) [181(974)/591 at 17m41s] samba3.raw.lock(nt4_dc) [182(987)/591 at 18m16s] samba3.raw.mkdir(nt4_dc) [183(988)/591 at 18m17s] samba3.raw.mux(nt4_dc) [184(989)/591 at 18m20s] samba3.raw.notify(nt4_dc) TESTING CHANGE NOTIFY COMPLETION FILTERS Testing mkdir UNEXPECTED(failure): samba3.raw.notify.mask(nt4_dc) REASON: Exception: Exception: ../../source4/torture/raw/notify.c:835: notify.nttrans.out.changes[0].action was 2 (0x2), expected 1 (0x1): nchanges=1 action=2 expectedAction=1 filter=0x0004 FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba3.blackbox.net.rpc.conf(nt4_dc) -> 158 samba3.blackbox.net.local.conf(nt4_dc:local) -> 85 samba3.base.dir2(nt4_dc) -> 44 samba3.raw.lock(nt4_dc) -> 35 samba3.blackbox.smbclient_s3.NT1.crypt (nt4_dc)(nt4_dc) -> 32 samba3.blackbox.smbclient_s3.SMB3.crypt (nt4_dc)(nt4_dc) -> 31 samba3.smbtorture_s3.crypt_client.OPLOCK1(nt4_dc) -> 31 samba3.blackbox.smbclient_s3.SMB3.plain (nt4_member) member creds(nt4_member) -> 30 samba3.blackbox.smbclient_s3.NT1.plain (nt4_dc)(nt4_dc) -> 29 samba3.blackbox.smbclient_s3.NT1.plain (nt4_member) member creds(nt4_member) -> 29 ERROR: test failed with exit code 1 Makefile:16: recipe for target 'test' failed
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via a66af4c96ac s3:auth: explicitly add BUILTIN\Guests to the guest token via 0e88f98855e tests: add a test for guest authentication via ac2167eb234 selftest: allow guest login in the ad_member_idmap_rid env via f4e340a48b6 s3:smbd: call reinit_guest_session_info() in the conf updated handler via 8096cc7eb2b s3:auth: add reinit_guest_session_info() via 96843452548 tests auth log winbind: Fix flapping test via aabdcc91513 third_party: Update waf to version 2.0.17 from 952437b1bdb ctdb-utils: Fix CID 1125558 (Unchecked return value from library) https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit a66af4c96accba4ee64eeb1958458b69f3ccec1d Author: Ralph Boehme Date: Mon May 13 20:16:47 2019 +0200 s3:auth: explicitly add BUILTIN\Guests to the guest token This changes ensures that smbd always adds BUILTIN\Guests to the guest token which is required for guest authentication. Currently the guest token depends on the on-disk configured group mappings. If there's an existing group mapping for BUILTIN\Guests, but LOCALSAM\Guest is not a member, the final guest token won't contain BUILTIN\Guests. For SMB2 the flag SMB2_SESSION_FLAG_IS_GUEST will not be set in the final SMB2 SESSION_SETUP response, because smbd sets it based on the token containing the BUILTIN\Guests SID S-1-5-32-546. At the same time, the packet is not signed which causes Windows clients and smbclient to reject the unsigned SMB2 SESSION_SETUP response. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944 Pair-programmed-with: Stefan Metzmacher Signed-off-by: Ralph Boehme Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Wed Jun 5 16:55:26 UTC 2019 on sn-devel-184 commit 0e88f98855e24cfddb55bef65c5910b8e662c630 Author: Ralph Boehme Date: Thu May 16 12:47:34 2019 +0200 tests: add a test for guest authentication This verifies that smbd always adds BUILTIN\Guests to the guest token which is required for guest authentication. Currently the guest token depends on the on-disk configured group mappings. If there's an existing group mapping for BUILTIN\Guests, but LOCALSAM\Guest is not a member, the final guest token won't contain BUILTIN\Guests. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944 Signed-off-by: Ralph Boehme Reviewed-by: Andrew Bartlett commit ac2167eb2349dc1c453e14a65692f16c8ba6532e Author: Ralph Boehme Date: Thu May 16 12:43:40 2019 +0200 selftest: allow guest login in the ad_member_idmap_rid env BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944 Signed-off-by: Ralph Boehme Reviewed-by: Andrew Bartlett commit f4e340a48b6f059a1daa66deb9c26da9e8fcd5e7 Author: Ralph Boehme Date: Thu May 16 12:42:54 2019 +0200 s3:smbd: call reinit_guest_session_info() in the conf updated handler BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944 Signed-off-by: Ralph Boehme Reviewed-by: Andrew Bartlett commit 8096cc7eb2b36b074ff17a52dc3540be4ecff6bb Author: Ralph Boehme Date: Thu May 16 12:42:29 2019 +0200 s3:auth: add reinit_guest_session_info() BUG: https://bugzilla.samba.org/show_bug.cgi?id=13944 Signed-off-by: Ralph Boehme Reviewed-by: Andrew Bartlett commit 968434525480020999a30881ca20b9b13c99ad65 Author: Gary Lockyer Date: Wed Jun 5 14:52:03 2019 +1200 tests auth log winbind: Fix flapping test Fix flapping auth_log_winbind tests, were seeing failures like UNEXPECTED(failure): samba.tests.auth_log_winbind.samba.tests.auth_log_winbind.AuthLogTestsWinbind. test_wbinfo(ad_member:local) REASON: Exception: Exception: Traceback (most recent call last): File "bin/python/samba/tests/auth_log_winbind.py", line 328, in test_wbinfo self.assertEquals(logon_id, msg["Authentication"]["logonId"]) AssertionError: '812b7158bff1660e' != '2cfc1fed76ff8865' - 812b7158bff1660e + 2cfc1fed76ff8865 Test had a race condition with other SamLogon events on the domain server. The tests can now handle multiple SamLogon messages and filter out the SamLogon messages for other logons. Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett commit aabdcc91513e242c4f191e170c890416d213 Author: Andreas Schneider Date: Mon Jun 3 10:40:55 2019 +0200 third_party: Update waf to version 2.0.17 This fixes building Samba, libtalloc, libtevent, libtdb and libldb with Python 3.8. wget https://waf.io/waf-2.0.17.tar.bz2 tar -xf waf-2.0.17.tar.bz2 git rm third_party/waf/waflib/ -r mkdir third_party/waf -p
autobuild[sn-devel-184]: intermittent test failure detected
The autobuild test system (on sn-devel-184) has detected an intermittent
failing test in
the current master tree.
The autobuild log of the failure is available here:
https://git.samba.org/autobuild.flakey.sn-devel-184/2019-06-05-1537/flakey.log
The failure seems to be in the "samba-schemaupgrade" suite, whose build logs
are available here:
https://git.samba.org/autobuild.flakey.sn-devel-184/2019-06-05-1537/samba-schemaupgrade.stderr
https://git.samba.org/autobuild.flakey.sn-devel-184/2019-06-05-1537/samba-schemaupgrade.stdout
The top commit at the time of the failure was:
commit 952437b1bdbe000c217836c4ecd59406e92146d7
Author: Martin Schwenke
Date: Wed May 29 19:11:51 2019 +1000
ctdb-utils: Fix CID 1125558 (Unchecked return value from library)
Signed-off-by: Martin Schwenke
Reviewed-by: Amitay Isaacs
Autobuild-User(master): Amitay Isaacs
Autobuild-Date(master): Wed Jun 5 12:09:56 UTC 2019 on sn-devel-184
and the last 50 lines of the stdout log were:
Applying Sch67.ldf updates...
5 changes applied
Applying Sch68.ldf updates...
30 changes applied
Applying Sch69.ldf updates...
4 changes applied
Schema successfully updated
Replicate from liveupgrade1dc to liveupgrade2dc was successful.
[1(0)/11 at 0s] samba.tests.samba_tool.schema(schema_dc:local)
[2(4)/11 at 2m22s] samba4.schemaInfo.python(schema_dc:local)(schema_dc:local)
[3(7)/11 at 2m27s] samba.tests.dsdb_schema_attributes(schema_dc:local)
[4(13)/11 at 2m44s] samba4.ldap_schema.python(schema_dc)(schema_dc)
[5(39)/11 at 3m25s] samba4.ldap.possibleInferiors.python(schema_dc)(schema_dc)
[6(313)/11 at 3m28s] samba4.ldap.secdesc.python(schema_dc)(schema_dc)
[7(396)/11 at 6m16s] samba4.ldap.acl.python(schema_dc)(schema_dc)
[8(449)/11 at 7m20s] samba4.ldap.passwords.python(schema_dc)(schema_dc)
[9(467)/11 at 7m42s]
samba4.drs.samba_tool_drs.python(schema_pair_dc)(schema_pair_dc:local)
[10(481)/11 at 9m50s]
samba4.drs.getnc_schema.python(schema_pair_dc)(schema_pair_dc)
Failed repl, retrying in 10s
UNEXPECTED(failure):
samba4.drs.getnc_schema.python(schema_pair_dc).getnc_schema.SchemaReplicationTests.test_schema_linked_attributes(schema_pair_dc)
REASON: Exception: Exception: Traceback (most recent call last):
File
"/memdisk/autobuild/fl/b182961/samba-schemaupgrade/source4/torture/drs/python/getnc_schema.py",
line 290, in test_schema_linked_attributes
self.do_repl(self.schema_dn)
File
"/memdisk/autobuild/fl/b182961/samba-schemaupgrade/source4/torture/drs/python/getnc_schema.py",
line 66, in do_repl
self.assertCmdSuccess(result, out, err)
File "bin/python/samba/tests/samba_tool/base.py", line 109, in
assertCmdSuccess
exit, out, err, msg))
AssertionError: -1 is not None : exit[-1] stdout[] stderr[ERROR(): DsReplicaSync failed - drsException:
DsReplicaSync failed (1168, 'WERR_NOT_FOUND')
File "bin/python/samba/netcmd/drs.py", line 574, in run
drs_utils.sendDsReplicaSync(server_bind, server_bind_handle,
source_dsa_guid, NC, req_options)
File "bin/python/samba/drs_utils.py", line 92, in sendDsReplicaSync
raise drsException("DsReplicaSync failed %s" % estr)
]:
FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
A summary with detailed information can be found in:
./bin/ab/summary
TOP 10 slowest tests
samba4.ldap.secdesc.python(schema_dc)(schema_dc) -> 169
samba4.drs.samba_tool_drs.python(schema_pair_dc)(schema_pair_dc:local) -> 127
samba4.ldap.acl.python(schema_dc)(schema_dc) -> 63
samba4.ldap_schema.python(schema_dc)(schema_dc) -> 42
samba4.ldap.passwords.python(schema_dc)(schema_dc) -> 23
samba.tests.dsdb_schema_attributes(schema_dc:local) -> 16
samba.tests.samba_tool.schema(schema_dc:local) -> 12
samba4.schemaInfo.python(schema_dc:local)(schema_dc:local) -> 5
samba4.ldap.possibleInferiors.python(schema_dc)(schema_dc) -> 2
ERROR: test failed with exit code 1
Makefile:16: recipe for target 'test' failed
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 952437b1bdb ctdb-utils: Fix CID 1125558 (Unchecked return value from library) via b1d83fb3e88 ctdb-daemon: Attempt to silence CID 1357985 (Unchecked return value) via aa602a8cc59 ctdb-cluster: CID 1435726: NULL pointer dereference via 2db0e71d3be ctdb-ipalloc: Fix warning about unused value assigned to srcimbl via 7df15b246ab ctdb-ipalloc: Avoid -1 as a PNN, use CTDB_UNKNOWN_PNN instead via 8d6570f ctdb-ipalloc: Fix signed/unsigned comparisons by declaring as unsigned via 18b4a3a0d31 ctdb-tests: Avoid potentially uninitialised data via 0bd87d75c0d ctdb-utils: Avoid warning about unused value via 90622ab901a ctdb-recovery: Fix signed/unsigned comparisons by declaring as unsigned via 35368d871d9 ctdb-recovery: Avoid -1 as a PNN, use CTDB_UNKNOWN_PNN instead via 978c7dbd559 ctdb-recovery: Fix signed/unsigned comparison by casting via fa7bd35b6ad ctdb-recovery: Fix signed/unsigned comparisons by declaring as unsigned via 7fa6c1206a3 ctdb-tests: Fix signed/unsigned comparison by using constant via 2c76a957c0e ctdb-client: Fix potentially uninitialised data via 2be15d3c61f ctdb-client: Fix signed/unsigned comparisons by declaring as unsigned via 887dc174f23 ctdb-common: Avoid unused value warning via 94e41a8466f ctdb-common: Avoid warning for potentially uninitialised pointers via cf9199f425c ctdb-common: Use #ifdef to avoid TEST_RB_TREE not defined via 2b3150db944 ctdb-common: Fix signed/unsigned comparisons by casting via 5b9456b70b6 ctdb-common: Fix signed/unsigned comparisons by declaring as unsigned via 938df1dbc81 ctdb-tools: Fix potentially uninitialised data via 9869ac1fb76 ctdb-tools: Fix signed/unsigned conversion by declaring as size_t via 282221b0d64 ctdb-tools: Fix signed/unsigned comparison by declaring as int via 201066d2e63 ctdb-tools: Fix signed/unsigned comparison by declaring as unsigned via 4a8ca51997f ctdb-tools: Fix signed/unsigned comparisons by casting via 865f127e7d2 ctdb-tools: Fix signed/unsigned comparisons by declaring extra variable via 2558f96da1f ctdb-tools: Fix signed/unsigned comparisons by declaring as unsigned from 843fbb1207e ctdb-scripts: Fix tcp_tw_recycle existence check https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 952437b1bdbe000c217836c4ecd59406e92146d7 Author: Martin Schwenke Date: Wed May 29 19:11:51 2019 +1000 ctdb-utils: Fix CID 1125558 (Unchecked return value from library) Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Wed Jun 5 12:09:56 UTC 2019 on sn-devel-184 commit b1d83fb3e88acfdfe00f06e950185ed03fee624f Author: Martin Schwenke Date: Wed May 29 19:05:49 2019 +1000 ctdb-daemon: Attempt to silence CID 1357985 (Unchecked return value) Yes, the other callers check the return value of ctdb_lockdb_mark(). However, this is called in a void function and ctdb_lockdb_mark() has already printed any error message. All we can do is explicitly ignore the return value. Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs commit aa602a8cc590dd416764d21147545bb411e47e35 Author: Martin Schwenke Date: Wed May 29 17:38:03 2019 +1000 ctdb-cluster: CID 1435726: NULL pointer dereference Also found by csbuild. Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs commit 2db0e71d3bef334dbb0a73f7118bf92af1cf0890 Author: Martin Schwenke Date: Thu May 30 15:41:42 2019 +1000 ctdb-ipalloc: Fix warning about unused value assigned to srcimbl To make this much clearer, move the declaration into the scope where it is used. Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs commit 7df15b246abb9ea2f606f5739a02cfec51f6d9cb Author: Martin Schwenke Date: Thu May 30 15:40:42 2019 +1000 ctdb-ipalloc: Avoid -1 as a PNN, use CTDB_UNKNOWN_PNN instead This fixes warnings about signed versus unsigned comparisons. Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs commit 8d6570f5377139a18d3e8875e89565bb8ee0 Author: Martin Schwenke Date: Thu May 30 15:37:38 2019 +1000 ctdb-ipalloc: Fix signed/unsigned comparisons by declaring as unsigned Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs commit 18b4a3a0d316954d65617ee189dffa9c4269f42e Author: Martin Schwenke Date: Thu May 30 15:33:05 2019 +1000 ctdb-tests: Avoid potentially uninitialised data Signed-off-by: Martin Schwenke Reviewed-by: Amitay Isaacs commit 0bd87d75c0db076e17d2d186afbdccb3e769b125 Author: Martin Schwenke Date: Thu May 30 15:32:03 201
