autobuild[sn-devel-184]: intermittent test failure detected
The autobuild test system (on sn-devel-184) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-07-17-0423/flakey.log The failure seems to be in the "samba-ad-dc-6" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-07-17-0423/samba-ad-dc-6.stderr https://git.samba.org/autobuild.flakey.sn-devel-184/2019-07-17-0423/samba-ad-dc-6.stdout The top commit at the time of the failure was: commit c4613521723e3ab9b462d75485a514ca16595226 Author: Noel Power Date: Wed Jul 10 11:50:18 2019 + s3/lib/smbconf: clang: 'Value stored during its initialization is never read' Fixes: source3/lib/smbconf/smbconf_reg.c:123:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:178:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:444:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:583:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:712:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:995:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:1103:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ 7 warnings generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer Autobuild-User(master): Gary Lockyer Autobuild-Date(master): Wed Jul 17 00:07:48 UTC 2019 on sn-devel-184 and the last 50 lines of the stdout log were: msDS-User-Account-Control-Computed = '16' Failed to bind - LDAP error 49 LDAP_INVALID_CREDENTIALS - <8009030C: LdapErr: DSID-0C0904DC, comment: AcceptSecurityContext error, data 775, v1db1> <> Failed to connect to 'ldap://localdc' with backend 'ldap': LDAP error 49 LDAP_INVALID_CREDENTIALS - <8009030C: LdapErr: DSID-0C0904DC, comment: AcceptSecurityContext error, data 775, v1db1> <> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= badPwdCount = '3' lockoutTime = '132078109872029230' badPasswordTime = '132078109872029230' logonCount = '0' lastLogon = '132078109840575090' lastLogonTimestamp = '132078109771123540' userAccountControl = '512' msDS-User-Account-Control-Computed = '16' Failed to bind - LDAP error 49 LDAP_INVALID_CREDENTIALS - <8009030C: LdapErr: DSID-0C0904DC, comment: AcceptSecurityContext error, data 775, v1db1> <> Failed to connect to 'ldap://localdc' with backend 'ldap': LDAP error 49 LDAP_INVALID_CREDENTIALS - <8009030C: LdapErr: DSID-0C0904DC, comment: AcceptSecurityContext error, data 775, v1db1> <> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= badPwdCount = '3' lockoutTime = '132078109872029230' badPasswordTime = '132078109872029230' logonCount = '0' lastLogon = '132078109840575090' lastLogonTimestamp = '132078109771123540' userAccountControl = '512' msDS-User-Account-Control-Computed = '16' UNEXPECTED(failure): samba4.ldap.password_lockout.python(ad_dc_slowtests).__main__.PasswordTestsWithSleep.test_pso_login_lockout_ntlm(ad_dc_slowtests) REASON: Exception: Exception: Traceback (most recent call last): File "/memdisk/autobuild/fl/b1791832/samba-ad-dc-6/source4/dsdb/tests/python/password_lockout.py", line 1177, in test_pso_login_lockout_ntlm self._test_login_lockout(self.lockout1ntlm_creds) File "/memdisk/autobuild/fl/b1791832/samba-ad-dc-6/source4/dsdb/tests/python/password_lockout_base.py", line 562, in _test_login_lockout msDSUserAccountControlComputed=dsdb.UF_LOCKOUT) File "/memdisk/autobuild/fl/b1791832/samba-ad-dc-6/source4/dsdb/tests/python/password_lockout_base.py", line 180, in _check_account self.assertEquals(uinfo5.bad_password_count, effective_bad_password_count) AssertionError: 0 != 3 FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba4.ldap.vlv.python(ad_dc_slowtests)(ad_dc_slowtests) -> 702 samba4.ldap.confidential_attr.python(ad_dc_slowtests)(ad_dc_slowtests) -> 410
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via c4613521723 s3/lib/smbconf: clang: 'Value stored during its initialization is never read' via b388c217d4f s3/lib: clang: 'Value stored to 'rta' is never read' via 963f58fb622 s3/registry: clang: Fix 'initialization value is never read' via 80e57a10164 s3/registry: clang: Fix 'initialization value is never read' via e3e9330609b s3/lib: clang: Fix 'passed-by-value struct argument contains uninit-ed data' via 6ea9c795b13 libcli/smb: clang: Fix ' 2nd function call argument is an uninitialized value' via fb49e411aa3 libcli/smb: clang: Fix 'Dereference of null pointer' via 3594c3ae202 libcli/smb: clang: Fix 'Array access results in a null pointer deref' via 7a86c99ccb6 libcli/smb: clang: Fix 'array access results in a null pointer deref' via 7b8ec24ccfb s4/libcli/raw: Fix 'Value stored to 'p' is never read' via 4f61a9980db s3/param: clang: Fix 'Value stored to 'bRetval' is never read' via 06c3a493d99 s4/libcli/raw: clang: Fix 'initialization value is never read' via be319e24bb9 s4/libcli: clang: Fix 'initialization value is never read' via a901c5768ac libcli/cldap: clang: Fix 'Dereference of null pointer' via 9cfdb9f1906 libcls/netlogon: clang: Fix 'initialization value is never read' via 8aed7e9aae1 s4/libcli/ldab: clang: Fix 'Access results in a deref of a null pointer' via 80f5461ae6c s3/lib: clang: Fix 'Value stored to 'b' is never read' via 0ca6d34a69d s3/lib/dwrap: clang: Fix 'Array access results in a null pointer dereference' via 57e9b358ec8 s3/lib: clang: Fix 'Value stored during its initialization is never read' from 9cf3379a140 third_party: Update uid_wrapper to version 1.2.7 https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit c4613521723e3ab9b462d75485a514ca16595226 Author: Noel Power Date: Wed Jul 10 11:50:18 2019 + s3/lib/smbconf: clang: 'Value stored during its initialization is never read' Fixes: source3/lib/smbconf/smbconf_reg.c:123:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:178:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:444:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:583:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:712:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:995:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ source3/lib/smbconf/smbconf_reg.c:1103:9: warning: Value stored to 'werr' during its initialization is never read <--[clang] WERROR werr = WERR_OK; ^~~~ ~~~ 7 warnings generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer Autobuild-User(master): Gary Lockyer Autobuild-Date(master): Wed Jul 17 00:07:48 UTC 2019 on sn-devel-184 commit b388c217d4fa0d2451a5d949b4fdf5a778d814a1 Author: Noel Power Date: Wed Jul 10 11:45:01 2019 + s3/lib: clang: 'Value stored to 'rta' is never read' Fixes: source3/lib/addrchange.c:217:2: warning: Value stored to 'rta' is never read <--[clang] rta = IFA_RTA(ifa); ^ 1 warning generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer commit 963f58fb622f20d58f9dab2d5f474c7eec58a8e2 Author: Noel Power Date: Wed Jul 10 11:35:35 2019 + s3/registry: clang: Fix 'initialization value is never read' Fixes: source3/registry/reg_backend_db.c:853:9: warning: Value stored to 'result' during its initialization is never read <--[clang] WERROR result = WERR_OK; ^~ ~~~ source3/registry/reg_backend_db.c:1677:2: warning: Value stored to 'len' is never read <--[clang] len = 0; ^ ~ 2 warnings generated. Signed-off-by: Noel Power Reviewed-by: Gary Lockyer commit 80e57a10164cc8482f0611cbce4086521051ec9b Author: Noel Power Date: Wed Jul 10 11:26:06 2019 + s3/registry: clang: Fix 'initialization value is
autobuild[sn-devel-184]: intermittent test failure detected
The autobuild test system (on sn-devel-184) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-07-16-2147/flakey.log The failure seems to be in the "samba-nopython" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-07-16-2147/samba-nopython.stderr https://git.samba.org/autobuild.flakey.sn-devel-184/2019-07-16-2147/samba-nopython.stdout The top commit at the time of the failure was: commit 9cf3379a1409b95714a1d96bf75c0bc08104ed1f Author: Andreas Schneider Date: Mon Jul 15 10:32:49 2019 +0200 third_party: Update uid_wrapper to version 1.2.7 Signed-off-by: Andreas Schneider Reviewed-by: Ralph Boehme Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Tue Jul 16 17:20:31 UTC 2019 on sn-devel-184 and the last 50 lines of the stdout log were: Successfully added group domadmins to the mapping db as a domain group NT Group everyone doesn't exist in mapping DB Successfully added group everyone to the mapping db as a wellknown group SMBD LOG of: LOCALKTEST6 smbd version 4.12.0pre1-GIT-9cf3379a140 started. Copyright Andrew Tridgell and the Samba Team 1992-2019 daemon_ready: daemon 'smbd' finished starting up and ready to serve connections nt_printing_init: error checking published printers: WERR_ACCESS_DENIED NMBD LOG of: LOCALKTEST6 nmbd version 4.12.0pre1-GIT-9cf3379a140 started. Copyright Andrew Tridgell and the Samba Team 1992-2019 daemon_ready: daemon 'nmbd' finished starting up and ready to serve connections queue_query_name: interface 0 has NULL IP address ! Packet send failed to 127.0.0.1(10958) ERRNO=No route to host reply_netbios_packet: send_packet to IP 127.0.0.1 port 10958 failed testsuite: samba3.blackbox.smbclient_large_file krb5(ktest:local) progress: push time: 2019-07-16 21:45:24.152276 time: 2019-07-16 21:45:24.300063Z test: smbclient large posix write read time: 2019-07-16 21:45:27.671756Z success: smbclient large posix write read time: 2019-07-16 21:45:27.681760Z test: cmp of read and written files time: 2019-07-16 21:45:27.814752Z success: cmp of read and written files time: 2019-07-16 21:45:27.878806 progress: pop command: ./source3/script/tests/test_smbclient_large_file.sh $PREFIX/ktest/krb5_ccache-3 bin/smbclient $SERVER $PREFIX -k --configfile=$SMB_CONF_PATH || exit 1 expanded command: ./source3/script/tests/test_smbclient_large_file.sh ./st/ktest/krb5_ccache-3 bin/smbclient LOCALKTEST6 ./st -k --configfile=/memdisk/autobuild/fl/b1848911/samba-nopython/st/ktest/lib/server.conf || exit 1 testsuite-success: samba3.blackbox.smbclient_large_file krb5(ktest:local) PROVISIONING maptoguest...CREATE TEST ENVIRONMENT IN './st/maptoguest'...DONE STARTING nmbd for maptoguest...DONE (2753921) STARTING winbindd for maptoguest...DONE (2753923) STARTING smbd for maptoguest...DONE (2753924) checking for nmbd name_query failed to find name maptoguest name_query failed to find name maptoguest 127.0.0.8 maptoguest<00> querying __SAMBA__ on 127.0.0.8 127.0.0.8 __SAMBA__<00> 127.0.0.7 __SAMBA__<00> querying __SAMBA__ on 127.255.255.255 127.0.0.5 __SAMBA__<00> querying maptoguest on 127.0.0.8 127.0.0.8 maptoguest<00> wait for smbd SMBD failed to start up in a reasonable time (20sec) ERROR: test failed with exit code 3 Makefile:57: recipe for target 'test-nopython' failed
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 9cf3379a140 third_party: Update uid_wrapper to version 1.2.7
from da9472a934b prefork tests: re-enable restart tests for MIT Kerberos
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 9cf3379a1409b95714a1d96bf75c0bc08104ed1f
Author: Andreas Schneider
Date: Mon Jul 15 10:32:49 2019 +0200
third_party: Update uid_wrapper to version 1.2.7
Signed-off-by: Andreas Schneider
Reviewed-by: Ralph Boehme
Autobuild-User(master): Andreas Schneider
Autobuild-Date(master): Tue Jul 16 17:20:31 UTC 2019 on sn-devel-184
---
Summary of changes:
buildtools/wafsamba/samba_third_party.py | 2 +-
third_party/uid_wrapper/uid_wrapper.c| 115 ---
third_party/uid_wrapper/wscript | 2 +-
3 files changed, 77 insertions(+), 42 deletions(-)
Changeset truncated at 500 lines:
diff --git a/buildtools/wafsamba/samba_third_party.py
b/buildtools/wafsamba/samba_third_party.py
index f7410ecba52..4793b4355fe 100644
--- a/buildtools/wafsamba/samba_third_party.py
+++ b/buildtools/wafsamba/samba_third_party.py
@@ -57,7 +57,7 @@ Build.BuildContext.CHECK_RESOLV_WRAPPER = CHECK_RESOLV_WRAPPER
@conf
def CHECK_UID_WRAPPER(conf):
-return conf.CHECK_BUNDLED_SYSTEM_PKG('uid_wrapper', minversion='1.2.4')
+return conf.CHECK_BUNDLED_SYSTEM_PKG('uid_wrapper', minversion='1.2.7')
Build.BuildContext.CHECK_UID_WRAPPER = CHECK_UID_WRAPPER
@conf
diff --git a/third_party/uid_wrapper/uid_wrapper.c
b/third_party/uid_wrapper/uid_wrapper.c
index 8f41ed92cb9..6e4a6da2f0d 100644
--- a/third_party/uid_wrapper/uid_wrapper.c
+++ b/third_party/uid_wrapper/uid_wrapper.c
@@ -34,6 +34,7 @@
#include
#endif
#include
+#include
#include
@@ -87,6 +88,14 @@
#define PRINTF_ATTRIBUTE(a,b)
#endif /* HAVE_FUNCTION_ATTRIBUTE_FORMAT */
+#ifndef FALL_THROUGH
+# ifdef HAVE_FALLTHROUGH_ATTRIBUTE
+# define FALL_THROUGH __attribute__ ((fallthrough))
+# else /* HAVE_FALLTHROUGH_ATTRIBUTE */
+# define FALL_THROUGH
+# endif /* HAVE_FALLTHROUGH_ATTRIBUTE */
+#endif /* FALL_THROUGH */
+
#define UWRAP_DLIST_ADD(list,item) do { \
if (!(list)) { \
(item)->prev= NULL; \
@@ -386,14 +395,30 @@ static void *uwrap_load_lib_handle(enum uwrap_lib lib)
int i;
#ifdef RTLD_DEEPBIND
- flags |= RTLD_DEEPBIND;
+ const char *env_preload = getenv("LD_PRELOAD");
+ const char *env_deepbind = getenv("UID_WRAPPER_DISABLE_DEEPBIND");
+ bool enable_deepbind = true;
+
+ /* Don't do a deepbind if we run with libasan */
+ if (env_preload != NULL && strlen(env_preload) < 1024) {
+ const char *p = strstr(env_preload, "libasan.so");
+ if (p != NULL) {
+ enable_deepbind = false;
+ }
+ }
+
+ if (env_deepbind != NULL && strlen(env_deepbind) >= 1) {
+ enable_deepbind = false;
+ }
+
+ if (enable_deepbind) {
+ flags |= RTLD_DEEPBIND;
+ }
#endif
switch (lib) {
case UWRAP_LIBNSL:
- /* FALL TROUGH */
case UWRAP_LIBSOCKET:
- /* FALL TROUGH */
case UWRAP_LIBC:
handle = uwrap.libc.handle;
if (handle == NULL) {
@@ -749,7 +774,7 @@ static int uwrap_pthread_create(pthread_t *thread,
UWRAP_LOCK(uwrap_id);
- args->id->groups = malloc(sizeof(gid_t) * src_id->ngroups);
+ args->id->groups = calloc(src_id->ngroups, sizeof(gid_t));
if (args->id->groups == NULL) {
UWRAP_UNLOCK(uwrap_id);
SAFE_FREE(args->id);
@@ -972,6 +997,31 @@ static void uwrap_thread_child(void)
UWRAP_UNLOCK_ALL;
}
+static unsigned long uwrap_get_xid_from_env(const char *envname)
+{
+ unsigned long xid;
+ const char *env = NULL;
+ char *endp = NULL;
+
+ env = getenv(envname);
+ if (env == NULL) {
+ return ULONG_MAX;
+ }
+
+ if (env[0] == '\0') {
+ unsetenv(envname);
+ return ULONG_MAX;
+ }
+
+ xid = strtoul(env, , 10);
+ unsetenv(envname);
+ if (env == endp) {
+ return ULONG_MAX;
+ }
+
+ return xid;
+}
+
/*
* This initializes uid_wrapper with the IDs exported to the environment. Those
* are normally set after we forked and executed.
@@ -980,53 +1030,38 @@ static void uwrap_init_env(struct uwrap_thread *id)
{
const char *env;
int ngroups = 0;
+ unsigned long xid;
- env = getenv("UID_WRAPPER_INITIAL_RUID");
- if (env != NULL && env[0] != '\0') {
- UWRAP_LOG(UWRAP_LOG_DEBUG, "Initialize ruid with %s", env);
- id->ruid = strtoul(env, (char **)NULL, 10);
-
autobuild[sn-devel-184]: intermittent test failure detected
The autobuild test system (on sn-devel-184) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-07-16-1610/flakey.log The failure seems to be in the "samba-nt4" suite, whose build logs are available here: https://git.samba.org/autobuild.flakey.sn-devel-184/2019-07-16-1610/samba-nt4.stderr https://git.samba.org/autobuild.flakey.sn-devel-184/2019-07-16-1610/samba-nt4.stdout The top commit at the time of the failure was: commit da9472a934bf242c7dec1a7a355fb4eb043e5b15 Author: Gary Lockyer Date: Thu Jul 11 09:31:31 2019 +1200 prefork tests: re-enable restart tests for MIT Kerberos Previously the restart back off tests were disabled for MIT Kerberos, as they used the kdc, which is not run in that case. Tests now use the echo server. Signed-off-by: Gary Lockyer Reviewed-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Tue Jul 16 10:10:23 UTC 2019 on sn-devel-184 and the last 50 lines of the stdout log were: [172(874)/604 at 13m47s] samba3.base.tcon(nt4_dc) [173(875)/604 at 13m48s] samba3.base.tcondev(nt4_dc) [174(876)/604 at 13m49s] samba3.base.trans2(nt4_dc) [175(877)/604 at 13m53s] samba3.base.unlink(nt4_dc) [176(878)/604 at 13m54s] samba3.base.vuid(nt4_dc) [177(879)/604 at 13m54s] samba3.base.xcopy(nt4_dc) [178(880)/604 at 13m55s] samba3.base.samba3error(nt4_dc) [179(881)/604 at 13m56s] samba3.raw.acls(nt4_dc) [180(893)/604 at 14m2s] samba3.raw.acls nfs4acl_xattr-simple-40(nt4_dc) [181(905)/604 at 14m8s] samba3.raw.acls nfs4acl_xattr-special-40(nt4_dc) [182(917)/604 at 14m13s] samba3.raw.acls nfs4acl_xattr-simple-41(nt4_dc) [183(929)/604 at 14m18s] samba3.raw.acls nfs4acl_xattr-xdr-40(nt4_dc) [184(941)/604 at 14m23s] samba3.raw.acls nfs4acl_xattr-xdr-41(nt4_dc) [185(953)/604 at 14m28s] samba3.raw.acls nfs4acl_xattr-nfs-40(nt4_dc) [186(965)/604 at 14m33s] samba3.raw.acls nfs4acl_xattr-nfs-41(nt4_dc) [187(977)/604 at 14m38s] samba3.raw.chkpath(nt4_dc) [188(978)/604 at 14m39s] samba3.raw.close(nt4_dc) [189(979)/604 at 14m40s] samba3.raw.composite(nt4_dc) [190(983)/604 at 14m44s] samba3.raw.eas(nt4_dc) [191(984)/604 at 14m45s] samba3.raw.lock(nt4_dc) [192(997)/604 at 15m21s] samba3.raw.mkdir(nt4_dc) [193(998)/604 at 15m21s] samba3.raw.mux(nt4_dc) [194(999)/604 at 15m24s] samba3.raw.notify(nt4_dc) TESTING CHANGE NOTIFY ON DIRECTORIES Testing notify cancel Testing notify mkdir Testing notify rmdir Testing notify mkdir - rmdir - mkdir - rmdir Testing buffered notify on create of 10 files Testing notify on unlink for the first file UNEXPECTED(failure): samba3.raw.notify.dir(nt4_dc) REASON: Exception: Exception: ../../source4/torture/raw/notify.c:223: notify.nttrans.out.num_changes was 9 (0x9), expected 10 (0xA): wrong number of changes FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites) A summary with detailed information can be found in: ./bin/ab/summary TOP 10 slowest tests samba3.blackbox.net.rpc.conf(nt4_dc) -> 134 samba3.base.dir2(nt4_dc) -> 82 samba3.blackbox.net.local.conf(nt4_dc:local) -> 67 samba3.raw.lock(nt4_dc) -> 36 samba3.smbtorture_s3.crypt_client.OPLOCK1(nt4_dc) -> 31 samba3.blackbox.net.rpc.registry(nt4_dc) -> 21 samba3.blackbox.smbclient_s3.SMB3.crypt (nt4_dc)(nt4_dc) -> 21 samba3.smbtorture_s3.crypt_client.LOCK1(nt4_dc) -> 20 samba3.blackbox.smbclient_s3.NT1.crypt (nt4_dc)(nt4_dc) -> 20 samba3.blackbox.smbclient_s3.SMB3.sign (nt4_dc)(nt4_dc) -> 20 ERROR: test failed with exit code 1 Makefile:16: recipe for target 'test' failed
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via da9472a934b prefork tests: re-enable restart tests for MIT Kerberos
via 1c4b9ba36c7 prefork restart tests: Use echo server for back off
via 15196c7561f s4 echo_server: Enable prefork process model
from 5522aa1a4c3 vfs:glusterfs_fuse: ensure fileids are constant across
nodes
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit da9472a934bf242c7dec1a7a355fb4eb043e5b15
Author: Gary Lockyer
Date: Thu Jul 11 09:31:31 2019 +1200
prefork tests: re-enable restart tests for MIT Kerberos
Previously the restart back off tests were disabled for MIT Kerberos, as
they used the kdc, which is not run in that case. Tests now use the
echo server.
Signed-off-by: Gary Lockyer
Reviewed-by: Andreas Schneider
Autobuild-User(master): Andreas Schneider
Autobuild-Date(master): Tue Jul 16 10:10:23 UTC 2019 on sn-devel-184
commit 1c4b9ba36c724b6fcc26a51af5202483ab3f1c23
Author: Gary Lockyer
Date: Thu Jul 11 09:28:30 2019 +1200
prefork restart tests: Use echo server for back off
Use the echo server for the restart back off tests in the
samba.tests.prefork_restart tests instead of the kdc. The kdc is not
enabled
when the ADDC is built to run MIT Kerberos. Changing the test to use
the echo server means it can be run when MIT Kerberos is enabled.
Signed-off-by: Gary Lockyer
Reviewed-by: Andreas Schneider
commit 15196c7561ff3afdb3d61afd6951d22e4cf698c7
Author: Gary Lockyer
Date: Thu Jul 11 09:29:28 2019 +1200
s4 echo_server: Enable prefork process model
Enable the prefork process model, for the echo server. This is allows
it to be used in the prefork_restart tests.
Signed-off-by: Gary Lockyer
Reviewed-by: Andreas Schneider
---
Summary of changes:
python/samba/tests/prefork_restart.py | 14 +++---
selftest/skip_mit_kdc | 4
source4/echo_server/echo_server.c | 2 +-
3 files changed, 8 insertions(+), 12 deletions(-)
Changeset truncated at 500 lines:
diff --git a/python/samba/tests/prefork_restart.py
b/python/samba/tests/prefork_restart.py
index 5233ca1f805..9ab97d062b4 100644
--- a/python/samba/tests/prefork_restart.py
+++ b/python/samba/tests/prefork_restart.py
@@ -404,7 +404,7 @@ class PreforkProcessRestartTests(TestCase):
def test_master_restart_backoff(self):
# get kdc master process
-pid = self.get_process("prefork-master-kdc")
+pid = self.get_process("prefork-master-echo")
self.assertIsNotNone(pid)
#
@@ -417,13 +417,13 @@ class PreforkProcessRestartTests(TestCase):
# Get the worker processes
workers = self.get_worker_pids("kdc", NUM_WORKERS)
-process = self.get_process("prefork-master-kdc")
+process = self.get_process("prefork-master-echo")
os.kill(process, signal.SIGTERM)
# wait for the process to restart
start = time.time()
-self.wait_for_process("prefork-master-kdc", process, 0, 1, 30)
+self.wait_for_process("prefork-master-echo", process, 0, 1, 30)
# wait for the workers to restart as well
-self.wait_for_workers("kdc", workers)
+self.wait_for_workers("echo", workers)
end = time.time()
duration = end - start
@@ -434,7 +434,7 @@ class PreforkProcessRestartTests(TestCase):
self.assertGreaterEqual(duration, expected)
# check that the worker processes have restarted
-new_workers = self.get_worker_pids("kdc", NUM_WORKERS)
+new_workers = self.get_worker_pids("echo", NUM_WORKERS)
for x in range(NUM_WORKERS):
self.assertNotEquals(workers[x], new_workers[x])
@@ -449,12 +449,12 @@ class PreforkProcessRestartTests(TestCase):
# prefork maximum backoff = 10
backoff_increment = 5
for expected in [0, 5, 10, 10]:
-process = self.get_process("prefork-worker-kdc-2")
+process = self.get_process("prefork-worker-echo-2")
self.assertIsNotNone(process)
os.kill(process, signal.SIGTERM)
# wait for the process to restart
start = time.time()
-self.wait_for_process("prefork-worker-kdc-2", process, 0, 1, 30)
+self.wait_for_process("prefork-worker-echo-2", process, 0, 1, 30)
end = time.time()
duration = end - start
diff --git a/selftest/skip_mit_kdc b/selftest/skip_mit_kdc
index bef52f50f86..4a51c98ea0b 100644
--- a/selftest/skip_mit_kdc
+++ b/selftest/skip_mit_kdc
@@ -3,7 +3,3 @@
.*RODC
^samba4.ntvfs.cifs.ntlm.base.unlink
^samba4.ntvfs.cifs.krb5.base.unlink
-#
-# We skip the pre-fork restart tests as they use
[SCM] UID Wrapper Repository - annotated tag uid_wrapper-1.2.7 created
The annotated tag, uid_wrapper-1.2.7 has been created at 4219800a2d3f6954ab9154e56b74367ae83be701 (tag) tagging d966dd2709397f334666be681aed8d86e5e9fb28 (commit) replaces uid_wrapper-1.2.6 tagged by Andreas Schneider on Tue Jul 16 11:16:41 2019 +0200 - Log - uid_wrapper-1.2.7 * Fix unsetting initial XIDs -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEjf9T4Y8qvI2PPJIjfuD8TcwBTj0FAl0tlgIACgkQfuD8TcwB Tj0LVA//TovBtTN5iUOJyRLVDn4q456BUKJDGHv1QFjQbE2re3YTWf90QnxNGxi6 +wyjFb3r//Ab0/MTK1HksnkbhVD7ZwZEiQYovnZh8JOIoD+DwjGValYD0rqsc8Yr +mIiMsLjGhOXa5PnGXk7NhXjn2QVPbZRzvjfNvMWfX6yfz1p+C+XkLeIfMm03WyY 74XSJmoqjwfQGPXWqo/O7ET71uWB+Mg4TwXe5zXnd+JY5KBixNd+fRUEw+XXP2JL V+xkFuMj3FhlOoOuGx9KaEoqc/iENDYFG21YI3Sup1YkPSs4cJRg3w3mknCLQYue psjMwOrpPVzbiGd3GgIQsuCR+G0WdkkzCeicam42sFo3K8kjRGKnK7VHPVVLcIiz QmMdUiTDqShLFvCviNjeLGcZpHQSeD1ZExuK1jqVy2pMz4rd7Wz0+FWBks4rvgtM aDzzYlaZqORpuSCRCzWXLS5HCjHnXvjsB9KaBqgcQYeiWFNtyeEYQhfu7Q71O5HG DyZ7qLRylNCINsW2K+e+nduo45uF62KH/3tMLPqZXUslaMfXPNdEPElslqMVjFm7 V8BbJpynXa+yJCV/6SirysnyN7UIS2Baz+c+IWcFGMgZprAmkxqkeEoLoQxnKYJI PNcEq2/1bnqf0iuK7Ulr+r6Cz+eoJQFsqSr+zIvh2sTvB9s9+rY= =HVm5 -END PGP SIGNATURE- Andreas Schneider (2): uwrap: Fix unsetting the the envname of initial XIDs Bump version to 1.2.7 --- -- UID Wrapper Repository
[SCM] UID Wrapper Repository - branch master updated
The branch, master has been updated
via d966dd2 Bump version to 1.2.7
via 52277f6 uwrap: Fix unsetting the the envname of initial XIDs
from e00f045 Bump version to 1.2.6
https://git.samba.org/?p=uid_wrapper.git;a=shortlog;h=master
- Log -
commit d966dd2709397f334666be681aed8d86e5e9fb28
Author: Andreas Schneider
Date: Mon Jul 15 16:17:52 2019 +0200
Bump version to 1.2.7
Signed-off-by: Andreas Schneider
Reviewed-by: Ralph Boehme
commit 52277f6fbc2dc144086234eaae6294f43033566a
Author: Andreas Schneider
Date: Mon Jul 15 13:58:44 2019 +0200
uwrap: Fix unsetting the the envname of initial XIDs
This issue got introduced by:
1c793e19f1cb8cb33defb171c9ae719ec8a820da
Signed-off-by: Andreas Schneider
Reviewed-by: Ralph Boehme
---
Summary of changes:
CMakeLists.txt| 4 ++--
ChangeLog | 3 +++
src/uid_wrapper.c | 4 ++--
3 files changed, 7 insertions(+), 4 deletions(-)
Changeset truncated at 500 lines:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 40c1ded..2fe81b0 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -11,7 +11,7 @@ list(APPEND CMAKE_MODULE_PATH
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/Modules")
include(DefineCMakeDefaults)
include(DefineCompilerFlags)
-project(uid_wrapper VERSION 1.2.6 LANGUAGES C)
+project(uid_wrapper VERSION 1.2.7 LANGUAGES C)
# global needed variables
set(APPLICATION_NAME ${PROJECT_NAME})
@@ -23,7 +23,7 @@ set(APPLICATION_NAME ${PROJECT_NAME})
# Increment AGE. Set REVISION to 0
# If the source code was changed, but there were no interface changes:
# Increment REVISION.
-set(LIBRARY_VERSION "0.0.7")
+set(LIBRARY_VERSION "0.0.8")
set(LIBRARY_SOVERSION "0")
# add definitions
diff --git a/ChangeLog b/ChangeLog
index 8260f35..e3c6de2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,9 @@
ChangeLog
==
+version 1.2.7 (released 2019-07-15)
+ * Fix unsetting initial XIDs
+
version 1.2.6 (released 2019-07-15)
* Fix manpage installation
* Fix cmake-config installation
diff --git a/src/uid_wrapper.c b/src/uid_wrapper.c
index 84c3ca5..6e4a6da 100644
--- a/src/uid_wrapper.c
+++ b/src/uid_wrapper.c
@@ -1009,12 +1009,12 @@ static unsigned long uwrap_get_xid_from_env(const char
*envname)
}
if (env[0] == '\0') {
- unsetenv("UID_WRAPPER_INITIAL_RUID");
+ unsetenv(envname);
return ULONG_MAX;
}
xid = strtoul(env, , 10);
- unsetenv("UID_WRAPPER_INITIAL_RUID");
+ unsetenv(envname);
if (env == endp) {
return ULONG_MAX;
}
--
UID Wrapper Repository
