[SCM] Samba Shared Repository - branch master updated

2020-12-15 Thread Noel Power
The branch, master has been updated
   via  7a077f152aa s3:smbd:trans2.c - add twrp to tmp smb_fname in 
smbd_do_qfsinfo
   via  9bf9b998088 dbcheck: clarify check_object userparams
   via  83371443898 dbcheck: check_object/userparams: use variable for 
clarity
   via  22447a51598 dbcheck: reduce useless use of str(attrname)
   via  0dd736ff334 dbcheck: better disambiguate 'attrs'
   via  206a028e1e8 dbcheck: split out attr calculations from check_object()
   via  43530f087de dbcheck: add a helper function for attr tracking
   via  b21287c2f49 dbcheck: do not add duplicate attrs for checking
   via  6b4ff458055 dbcheck: check_object() caches of lower case attr names
   via  25a94fa4743 dbcheck: make rIDSetReferences attr check 
case-insensitve
  from  6601b3ac544 bootstrap: Update distro list in README.md

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 7a077f152aa3e1e09b4228ae24780fa613540a68
Author: Andrew Walker 
Date:   Tue Dec 8 10:36:10 2020 -0500

s3:smbd:trans2.c - add twrp to tmp smb_fname in smbd_do_qfsinfo

Preserve VSS-related timestamp in temporary smb_filename before
calling vfs_stat_fn() in smbd_do_qfsinfo. Otherwise, we can fail
here on smb2_getinfo requests if file does not exist outside of
shadow copy path.

Signed-off-by: Andrew Walker 
Reviewed-by: Ralph Boehme 
Reviewed-by: Noel Power 

Autobuild-User(master): Noel Power 
Autobuild-Date(master): Tue Dec 15 15:32:18 UTC 2020 on sn-devel-184

commit 9bf9b998088b181955994da2004bf459ef131037
Author: Douglas Bagnall 
Date:   Wed Dec 9 11:50:37 2020 +1300

dbcheck: clarify check_object userparams

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power 

commit 83371443898aacdc6033ccf20bc67d4033b96767
Author: Douglas Bagnall 
Date:   Wed Dec 9 11:38:48 2020 +1300

dbcheck: check_object/userparams: use variable for clarity

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power 

commit 22447a5159867729559ae47c6fc20159be8f4c25
Author: Douglas Bagnall 
Date:   Wed Dec 9 11:37:48 2020 +1300

dbcheck: reduce useless use of str(attrname)

it's already a string!

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power 

commit 0dd736ff3343ce19f2fef3132285d4595aa54afb
Author: Douglas Bagnall 
Date:   Wed Dec 9 11:34:50 2020 +1300

dbcheck: better disambiguate 'attrs'

We had too many things called 'attrs'; now we have just one, but we
don't want it to look like it is *the* one.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power 

commit 206a028e1e8c83fa1fc2a7b3bbe4a573eb315ff8
Author: Douglas Bagnall 
Date:   Fri Dec 4 13:17:24 2020 +1300

dbcheck: split out attr calculations from check_object()

check_object is too long!

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power 

commit 43530f087deab648708508445d4dea160de46889
Author: Douglas Bagnall 
Date:   Fri Dec 4 13:10:49 2020 +1300

dbcheck: add a helper function for attr tracking

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power 

commit b21287c2f4922abb76ead510680bd489c6cf3cf9
Author: Douglas Bagnall 
Date:   Fri Dec 4 13:06:25 2020 +1300

dbcheck: do not add duplicate attrs for checking

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power 

commit 6b4ff45805550216a47577a2ee2fa04be305fe61
Author: Douglas Bagnall 
Date:   Fri Dec 4 12:57:57 2020 +1300

dbcheck: check_object() caches of lower case attr names

The construct `'name' in map(str.lower, attrs)` is doubly inefficient,
because not only is it running the lower() function too often, it is
searching linearly in a temporary iterator for membership.

So we make a set, and use that.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power 

commit 25a94fa4743f4bda9924786775aba43bb8c58c0d
Author: Douglas Bagnall 
Date:   Fri Dec 4 13:56:56 2020 +1300

dbcheck: make rIDSetReferences attr check case-insensitve

Yes, it looks inefficient, but that's because it is just trying to fit
in. Very soon we will fix it it properly.

Signed-off-by: Douglas Bagnall 
Reviewed-by: Noel Power 

---

Summary of changes:
 python/samba/dbchecker.py | 127 +-
 source3/smbd/trans2.c |   7 ++-
 2 files changed, 86 insertions(+), 48 deletions(-)


Changeset truncated at 500 lines:

diff --git a/python/samba/dbchecker.py b/python/samba/dbchecker.py
index 28b56edaafb..364dc9427d7 100644
--- a/python/samba/dbchecker.py
+++ b/python/samba/dbchecker.py
@@ -250,7 +250,7 @@ class dbcheck(object):
 
 for object in res:
 self.dn_set.add(str(object.dn))
-error_count += self.check_object(object.dn, attrs=attrs)
+

[SCM] Samba Shared Repository - branch master updated

2020-12-15 Thread Martin Schwenke
The branch, master has been updated
   via  6601b3ac544 bootstrap: Update distro list in README.md
   via  1c59f49aaed bootstrap: Cope with case changes in CentOS 8 repo names
  from  49256925996 libsmb: Remove unused ads_dns_query_* routines

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 6601b3ac544244563a8cd3cdb5a4bc7da1b4a759
Author: Martin Schwenke 
Date:   Fri Dec 11 15:57:37 2020 +1100

bootstrap: Update distro list in README.md

Update examples to make them valid.

Signed-off-by: Martin Schwenke 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Tue Dec 15 12:03:58 UTC 2020 on sn-devel-184

commit 1c59f49aaede8ec1662d4e49aef84fcd902a8a76
Author: Martin Schwenke 
Date:   Wed Dec 9 00:03:47 2020 +1100

bootstrap: Cope with case changes in CentOS 8 repo names

RN: Be more flexible with repository names in CentOS 8 test environments

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14594
Signed-off-by: Martin Schwenke 
Reviewed-by: Andrew Bartlett 

---

Summary of changes:
 .gitlab-ci.yml |  2 +-
 bootstrap/README.md| 12 ++--
 bootstrap/config.py|  6 --
 bootstrap/generated-dists/centos8/bootstrap.sh |  6 --
 bootstrap/sha1sum.txt  |  2 +-
 5 files changed, 16 insertions(+), 12 deletions(-)


Changeset truncated at 500 lines:

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index accaced66a0..7a7582cb6db 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -32,7 +32,7 @@ variables:
   # Set this to the contents of bootstrap/sha1sum.txt
   # which is generated by bootstrap/template.py --render
   #
-  SAMBA_CI_CONTAINER_TAG: 42ecbfbf716fa85ce251a955de72a92af26fc7b2
+  SAMBA_CI_CONTAINER_TAG: c4c00eb35cae36d8d6e752ee01fd943432993721
   #
   # We use the ubuntu1804 image as default as
   # it matches what we have on sn-devel-184.
diff --git a/bootstrap/README.md b/bootstrap/README.md
index d4f30955197..47ef1c67836 100644
--- a/bootstrap/README.md
+++ b/bootstrap/README.md
@@ -12,8 +12,8 @@ A pure python3 module with CLI to bootstrap Samba envs for 
multiple distribution
 
 ## Supported Distributions
 
-deb: Debian 7|8|9|10, Ubuntu 1404|1604|1804
-rpm: CentOS 6|7, Fedora 28|29, openSUSE Leap 15.0|15.1
+deb: Debian 10, Ubuntu 1604|1804|2004
+rpm: CentOS 7|8, Fedora 32|33, openSUSE Leap 15.1|15.2
 
 Easy to add more.
 
@@ -86,14 +86,14 @@ With Vagrant:
 
  cd bootstrap/generated-dists/
  vagrant up   # start all
- vagrant up debian9  # start one
- vagrant ssh debian9
- vagrant destroy debian9  # destroy one
+ vagrant up debian10  # start one
+ vagrant ssh debian10
+ vagrant destroy debian10  # destroy one
  vagrant destroy  # destroy all
 
 Or a remote/cloud machine:
 
- scp bootstrap/generated-dists/fedora30/bootstrap.sh USER@IP:
+ scp bootstrap/generated-dists/fedora33/bootstrap.sh USER@IP:
  ssh USER@IP
  sudo bash ./bootstrap.sh
 
diff --git a/bootstrap/config.py b/bootstrap/config.py
index 982ebae1cd1..8383aeb392d 100644
--- a/bootstrap/config.py
+++ b/bootstrap/config.py
@@ -235,8 +235,10 @@ yum install -y dnf-plugins-core
 yum install -y epel-release
 
 yum -v repolist all
-yum config-manager --set-enabled PowerTools -y
-yum config-manager --set-enabled Devel -y
+yum config-manager --set-enabled PowerTools -y || \
+yum config-manager --set-enabled powertools -y
+yum config-manager --set-enabled Devel -y || \
+yum config-manager --set-enabled devel -y
 yum update -y
 
 yum install -y \
diff --git a/bootstrap/generated-dists/centos8/bootstrap.sh 
b/bootstrap/generated-dists/centos8/bootstrap.sh
index e5167a2b561..b9f2df67645 100755
--- a/bootstrap/generated-dists/centos8/bootstrap.sh
+++ b/bootstrap/generated-dists/centos8/bootstrap.sh
@@ -12,8 +12,10 @@ yum install -y dnf-plugins-core
 yum install -y epel-release
 
 yum -v repolist all
-yum config-manager --set-enabled PowerTools -y
-yum config-manager --set-enabled Devel -y
+yum config-manager --set-enabled PowerTools -y || \
+yum config-manager --set-enabled powertools -y
+yum config-manager --set-enabled Devel -y || \
+yum config-manager --set-enabled devel -y
 yum update -y
 
 yum install -y \
diff --git a/bootstrap/sha1sum.txt b/bootstrap/sha1sum.txt
index 46493c16eb0..3e87c2ed1b0 100644
--- a/bootstrap/sha1sum.txt
+++ b/bootstrap/sha1sum.txt
@@ -1 +1 @@
-42ecbfbf716fa85ce251a955de72a92af26fc7b2
+c4c00eb35cae36d8d6e752ee01fd943432993721


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - annotated tag samba-4.13.3 created

2020-12-15 Thread Karolin Seeger
The annotated tag, samba-4.13.3 has been created
at  19255f02b0f0c84e19fea2b10f2e0b149567510d (tag)
   tagging  916472aebc907c6bc78972e16c5d0557ad215b59 (commit)
  replaces  samba-4.13.2
 tagged by  Karolin Seeger
on  Tue Dec 15 08:54:38 2020 +0100

- Log -
samba: tag release samba-4.13.3
-BEGIN PGP SIGNATURE-

iF0EABECAB0WIQRS+8C4bZVLCEMyTNxvM5FbZWi36gUCX9hrvgAKCRBvM5FbZWi3
6nHgAJwKtjdGzNaI3nm9WSLBCyMqFjJlbACgjv3dahHSiUF091sXBAck6LWdntc=
=ZImr
-END PGP SIGNATURE-

Anoop C S (2):
  vfs_shadow_copy2: Preserve all open flags assuming ROFS
  manpages/vfs_glusterfs: Mention silent skipping of write-behind translator

David Disseldorp (1):
  Revert "vfs_ceph: drop fdopendir handler"

Günther Deschner (2):
  s3-vfs_glusterfs: always disable write-behind translator
  vfs_glusterfs: print exact cmdline for disabling write-behind translator

Isaac Boukris (1):
  s3-libads: Pass timeout to open_socket_out in ms

Jeremy Allison (6):
  libcli: smb2: Never print length if smb2_signing_key_valid() fails for 
crypto blob.
  s3: modules: gluster. Fix the error I made in preventing talloc leaks 
from a function.
  s3: smbd: Don't overwrite contents of fsp->aio_requests[0] with NULL via 
TALLOC_FREE().
  s3: spoolss: Make parameters in call to user_ok_token() match all other 
uses.
  s3/script/tests: Ensure all remote test files are removed
  s3: smbd: Quiet log messages from usershares for an unknown share.

Jones Syue (1):
  interface: fix if_index is not parsed correctly

Karolin Seeger (3):
  VERSION: Bump version up to 4.13.3...
  WHATSNEW: Add release notes for Samba 4.13.3.
  VERSION: Disable GIT_SNAPSHOT for the 4.13.3 release.

Noel Power (11):
  s3/script/tests: Fix 'Unrecognized option(s) passed to mkpath()' error
  selftest: Add a new tarmode shares
  s3/script/test: Use different testdir for 
samba3.blackbox.smbclient_tarmode
  s3/script/tests: Use tarmode share for samba3.blackbox.smbclient_tar*
  s3/script: Use smbclient deltree to clean up smbclient_tarmode subdir
  s3/script/tests: Fix samba3.blackbox.smbclient_tarmode cleanup
  selftest: make samba3.blackbox.smbclient_tar runnable (even manually)
  s3/script/tests: Remove make_path (for remote dir)
  s3/script/tests: Make smb_client 'die' behaviour configurable
  s3/script/tests: call smbclient deltree to remove remote files
  selftest: Remove samba3.blackbox.smbclient_tar from flapping tests

Ralph Boehme (13):
  loadparm: setup debug subsystem setting max_log_size from config
  debug: pass struct debug_class *config to reopen_one_log()
  debug: pass struct debug_class *config to do_one_check_log_size()
  debug: detect logrotation by checking inode number
  s4: add samba server tevent trace helper stuff
  s4: install tevent tracing hooks to trigger logfile rotation
  s4: replace low-level SIGUP handler with a tevent handler
  s4: call reopen_logs_internal() in the SIGHUP handler of the prefork 
process model
  s4/samba: call force_check_log_size() in prefork_reload_after_fork()
  s4/samba: call force_check_log_size() in standard_accept_connection()
  s4/samba: call force_check_log_size() in standard_new_task()
  vfs_zfsacl: reformatting
  vfs_zfsacl: add missing inherited flag on hidden "magic" everyone@ ACE

Volker Lendecke (5):
  smbclient: Remove the "abort_mget" variable
  smbclient: Slightly simplify do_mget()
  test3: Add a test showing that smbclient recursive mget is broken
  smbclient: Fix recursive mget
  clitar: Use do_list()'s recursion in clitar.c

---


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - branch v4-13-test updated

2020-12-15 Thread Karolin Seeger
The branch, v4-13-test has been updated
   via  6f4f529dded VERSION: Bump version up to 4.13.4...
   via  916472aebc9 VERSION: Disable GIT_SNAPSHOT for the 4.13.3 release.
   via  1648eed2470 WHATSNEW: Add release notes for Samba 4.13.3.
  from  670c33fe9cb vfs_zfsacl: add missing inherited flag on hidden 
"magic" everyone@ ACE

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-13-test


- Log -
commit 6f4f529ddedfefae28a4476b33e9e1b556469786
Author: Karolin Seeger 
Date:   Tue Dec 15 08:51:12 2020 +0100

VERSION: Bump version up to 4.13.4...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger 

commit 916472aebc907c6bc78972e16c5d0557ad215b59
Author: Karolin Seeger 
Date:   Tue Dec 15 08:50:21 2020 +0100

VERSION: Disable GIT_SNAPSHOT for the 4.13.3 release.

Signed-off-by: Karolin Seeger 

commit 1648eed247013464624076e8430fb590d0e32aa7
Author: Karolin Seeger 
Date:   Tue Dec 15 08:48:59 2020 +0100

WHATSNEW: Add release notes for Samba 4.13.3.

Signed-off-by: Karolin Seeger 

---

Summary of changes:
 VERSION  |  2 +-
 WHATSNEW.txt | 75 ++--
 2 files changed, 74 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/VERSION b/VERSION
index 3450883b693..567aa29970f 100644
--- a/VERSION
+++ b/VERSION
@@ -25,7 +25,7 @@
 
 SAMBA_VERSION_MAJOR=4
 SAMBA_VERSION_MINOR=13
-SAMBA_VERSION_RELEASE=3
+SAMBA_VERSION_RELEASE=4
 
 
 # If a official release has a serious bug  #
diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index a3ce5cc3dd5..947fd89e3c3 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -1,3 +1,74 @@
+   ==
+   Release Notes for Samba 4.13.3
+  December 15, 2020
+   ==
+
+
+This is the latest stable release of the Samba 4.13 release series.
+
+
+Changes since 4.13.2
+
+
+o  Jeremy Allison 
+   * BUG 14210: libcli: smb2: Never print length if smb2_signing_key_valid()
+ fails for crypto blob.
+   * BUG 14486: s3: modules: gluster. Fix the error I made in preventing talloc
+ leaks from a function. 
+   * BUG 14515: s3: smbd: Don't overwrite contents of fsp->aio_requests[0] with
+ NULL via TALLOC_FREE().
+   * BUG 14568: s3: spoolss: Make parameters in call to user_ok_token() match
+ all other uses.
+   * BUG 14590: s3: smbd: Quiet log messages from usershares for an unknown
+ share.
+
+o  Ralph Boehme 
+   * BUG 14248: samba process does not honor max log size.
+   * BUG 14587: vfs_zfsacl: Add missing inherited flag on hidden "magic"
+ everyone@ ACE.
+
+o  Isaac Boukris 
+   * BUG 13124: s3-libads: Pass timeout to open_socket_out in ms.
+
+o  Günther Deschner 
+   * BUG 14486: s3-vfs_glusterfs: Always disable write-behind translator.
+
+o  Volker Lendecke 
+   * BUG 14517: smbclient: Fix recursive mget.
+   * BUG 14581: clitar: Use do_list()'s recursion in clitar.c.
+
+o  Anoop C S 
+   * BUG 14486: manpages/vfs_glusterfs: Mention silent skipping of write-behind
+ translator.
+   * BUG 14573: vfs_shadow_copy2: Preserve all open flags assuming ROFS.
+
+o  Jones Syue 
+   * BUG 14514: interface: Fix if_index is not parsed correctly.
+
+
+###
+Reporting bugs & Development Discussion
+###
+
+Please discuss this release on the samba-technical mailing list or by
+joining the #samba-technical IRC channel on irc.freenode.net.
+
+If you do report problems then please try to send high quality
+feedback. If you don't provide vital information to help us track down
+the problem then you will probably be ignored.  All bug reports should
+be filed under the Samba 4.1 and newer product in the project's Bugzilla
+database (https://bugzilla.samba.org/).
+
+
+==
+== Our Code, Our Bugs, Our Responsibility.
+== The Samba Team
+==
+
+
+Release notes for older releases follow:
+
+
==
Release Notes for Samba 4.13.2
   November 03, 2020
@@ -104,8 +175,8 @@ database (https://bugzilla.samba.org/).
 ==
 
 
-Release notes for older releases follow:
-
+--
+
 
==
Release Notes for Samba 4.13.1