[SCM] Samba Shared Repository - branch master updated

2021-03-23 Thread Andrew Bartlett
The branch, master has been updated
   via  bf1c294adb7 auth:creds: Free the uname pointer in 
cli_credentials_parse_string()
   via  aa34799600b auth:creds: Don't include credentials_internal.h twice
   via  d7c111514ad netcmd: Fix opening SamDB database for offline backup
   via  bb3dcd403ce netcmd: Workaround issue backing up offline domain with 
lmdb >= 0.9.26
  from  c871c224611 s3:netapi: Add libnetapi_set_creds()

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit bf1c294adb7ef623d0da1dd9b43d3b3fab58fa26
Author: Andreas Schneider 
Date:   Mon Mar 22 18:11:33 2021 +0100

auth:creds: Free the uname pointer in cli_credentials_parse_string()

The data is duplicated and we don't need it anymore.

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Mar 24 03:13:05 UTC 2021 on sn-devel-184

commit aa34799600bc95758d01bc9d7b3dd58f251d71ad
Author: Andreas Schneider 
Date:   Thu Dec 3 17:10:22 2020 +0100

auth:creds: Don't include credentials_internal.h twice

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 

commit d7c111514ad53787af5a7084355126dfa34f
Author: Joseph Sutton 
Date:   Mon Mar 22 11:06:30 2021 +1300

netcmd: Fix opening SamDB database for offline backup

When opening the backed-up SamDB database, open the top-level database
without loading any modules so the backend database files aren't
unnecessarily opened. The domain SID is now fetched from the original
database rather than from the backup.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14676

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Samuel Cabrero 

commit bb3dcd403ced922574a89011dd3814c4fe87dd76
Author: Samuel Cabrero 
Date:   Thu Mar 18 17:54:33 2021 +0100

netcmd: Workaround issue backing up offline domain with lmdb >= 0.9.26

The LMDB change "ITS#9278 fix robust mutex cleanup for FreeBSD" released
in version 0.9.26 makes samba-tool domain backup offline to fail with
the following error:

Failed to connect to 
'mdb:///tmp/foo/private/sam.ldb.d/CN=CONFIGURATION,DC=FOO,DC=EXAMPLE,DC=COM.ldb'
 with backend 'mdb': Unable to load ltdb cache records for backend 'ldb_mdb 
backend'
module samba_dsdb initialization failed : Operations error
Unable to load modules for /tmp/foo/private/sam.ldb.bak-offline: Unable to 
load ltdb cache records for backend 'ldb_mdb backend'
ERROR(ldb): uncaught exception - Unable to load ltdb cache records for 
backend 'ldb_mdb backend'
  File 
"/usr/local/samba/lib64/python3.6/site-packages/samba/netcmd/__init__.py", line 
186, in _run
return self.run(*args, **kwargs)
  File 
"/usr/local/samba/lib64/python3.6/site-packages/samba/netcmd/domain_backup.py", 
line 1147, in run
session_info=system_session(), lp=lp)
  File "/usr/local/samba/lib64/python3.6/site-packages/samba/samdb.py", 
line 72, in __init__
options=options)
  File "/usr/local/samba/lib64/python3.6/site-packages/samba/__init__.py", 
line 114, in __init__
self.connect(url, flags, options)
  File "/usr/local/samba/lib64/python3.6/site-packages/samba/samdb.py", 
line 87, in connect
options=options)

The error occurs opening the backed ldb to write the backup date and the
next SID, a call to pthread_mutex_lock in mdb_txn_renew0 (frame 8) returns
EINVAL:

  #0  0x7ff63c2f1bea in wait4 () from /lib64/libc.so.6
  #1  0x7ff63c26f3a3 in do_system () from /lib64/libc.so.6
  #2  0x7ff63bc71e94 in smb_panic_default (why=0x7ffed481b7d0 "Signal 
6: Aborted") at ../../lib/util/fault.c:153
  #3  0x7ff63bc72168 in smb_panic (why=0x7ffed481b7d0 "Signal 6: 
Aborted") at ../../lib/util/fault.c:200
  #4  0x7ff63bc71c82 in fault_report (sig=6) at 
../../lib/util/fault.c:81
  #5  0x7ff63bc71c97 in sig_fault (sig=6) at ../../lib/util/fault.c:92
  #6  
  #7  0x7ff63c2178b5 in raise () from /lib64/libpthread.so.0
  #8  0x7ff637602e65 in mdb_txn_renew0 (txn=txn@entry=0x55d6f97fb800) 
at mdb.c:2710
  #9  0x7ff637603ae8 in mdb_txn_begin (env=0x55d6f85dfa80, parent=0x0, 
flags=131072, ret=0x55d6f89c0928)
  at mdb.c:2912
  #10 0x7ff6376236cc in lmdb_lock_read (module=0x55d6f8c5f4b0) at 
../../lib/ldb/ldb_mdb/ldb_mdb.c:585
  #11 0x7ff637641de6 in ldb_kv_cache_load (module=0x55d6f8c5f4b0) at 
../../lib/ldb/ldb_key_value/ldb_kv_cache.c:450
  #12 0x7ff637638792 in ldb_kv_init_store (ldb_kv=0x55d6f8af2a80, 
name=0x7ff637625675 "ldb_mdb backend",
  ldb=0x55d6f8cd22b0, options=0x0, _module=0x7ffed481c248) at 
../../lib/ldb/ldb_key_value/ldb_kv.c:2166
  #13 0x7ff6376247ba in lmdb_connect (ldb=0x55d6f8cd22b0,
  

[SCM] Samba Shared Repository - branch master updated

2021-03-23 Thread Günther Deschner
The branch, master has been updated
   via  c871c224611 s3:netapi: Add libnetapi_set_creds()
   via  6968a325d9d s3:netapi: Get rid of set_cmdline_auth_info_*()
   via  4e82150dc14 auth:creds: Use our own 
cli_credentials_set_cmdline_callbacks()
   via  9e5ac70a7e4 auth:creds: Add command line function for standard 
password callback
   via  ca57356b78f s4:lib:cmdline: Rename 
cli_credentials_set_cmdline_callbacks()
   via  3f3093933a2 s3:netapi: Remove use_ccache from 'struct libnetapi_ctx'
   via  67d49ac1480 s3:netapi: Remove use_kerberos from struct libnetapi_ctx
   via  dd7adbfa8f2 s3:netapi: Remove workgroup from 'struct libnetapi_ctx'
   via  51d5bebcc15 s3:netapi: Remove password from 'struct libnetapi_ctx'
   via  d94053f9d8b s3:netapi: Remove username from 'struct libnetapi_ctx'
   via  fd78554d11a s3:netapi: Use public functions for username/password
   via  0aeca4e5a13 s3:netapi: Get username/password from cli_credentials 
in joindomain.c
   via  3506800d3ef s3:netapi: Get username/password from cli_credentials 
in netapi.c
   via  9285e64a623 s3:netapi: Fill also cli_credentials with netapi setters
   via  7bb70f701e4 s3:netapi: Add a cli_credentials pointer to struct 
libnetapi_ctx
   via  517f94f5bff s3:netapi: Remove unused ctx->krb5_cc_env
   via  e79b067e239 s3:netapi: Make 'struct libnetapi_ctx' opaque
   via  bcc3945e538 s3:netapi: Use public getters in getjoinableous example
   via  44ef7f96e16 s3:netapi: Use public getters in remote_machine example
   via  c9222ab8388 s3:netapi: Implement public 
libnetapi_get_(username|password) functions
  from  17283de8fd9 netcmd: Fix typos in offline domain backup test

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit c871c224611296ee922a508129913aca93a38a16
Author: Andreas Schneider 
Date:   Thu Mar 18 13:34:15 2021 +0100

s3:netapi: Add libnetapi_set_creds()

This will be used by the 'net' command in future!

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed Mar 24 02:07:20 UTC 2021 on sn-devel-184

commit 6968a325d9d5c9d68634b10d9ee080004865bcd8
Author: Andreas Schneider 
Date:   Thu Mar 18 13:49:27 2021 +0100

s3:netapi: Get rid of set_cmdline_auth_info_*()

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit 4e82150dc14cb8852a7a20c1d57b0db4a4cf82e1
Author: Andreas Schneider 
Date:   Thu Dec 3 17:07:53 2020 +0100

auth:creds: Use our own cli_credentials_set_cmdline_callbacks()

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit 9e5ac70a7e49ecd0e61e9546ccdf0ad863f1177a
Author: Andreas Schneider 
Date:   Wed Aug 7 11:36:28 2019 +0200

auth:creds: Add command line function for standard password callback

Pair-Programmed-With: Stefan Metzmacher 
Signed-off-by: Stefan Metzmacher 
Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit ca57356b78f095c20685c4b510d20b1efedb5882
Author: Andreas Schneider 
Date:   Tue Mar 23 16:27:38 2021 +0100

s4:lib:cmdline: Rename cli_credentials_set_cmdline_callbacks()

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit 3f3093933a2341da5329647b843ef8f06fc9e30b
Author: Andreas Schneider 
Date:   Thu Mar 18 13:39:54 2021 +0100

s3:netapi: Remove use_ccache from 'struct libnetapi_ctx'

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit 67d49ac14805d6cb6fbc87904173aaeaf5f859c5
Author: Andreas Schneider 
Date:   Thu Mar 18 13:39:54 2021 +0100

s3:netapi: Remove use_kerberos from struct libnetapi_ctx

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit dd7adbfa8f277932eeed17eceaaa7713fc23829b
Author: Andreas Schneider 
Date:   Thu Mar 18 11:37:50 2021 +0100

s3:netapi: Remove workgroup from 'struct libnetapi_ctx'

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit 51d5bebcc156ee9b93937deefc534e44911245a7
Author: Andreas Schneider 
Date:   Thu Mar 18 11:37:03 2021 +0100

s3:netapi: Remove password from 'struct libnetapi_ctx'

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit d94053f9d8b1fdce61e90d3942e75b02e2d3209c
Author: Andreas Schneider 
Date:   Thu Mar 18 11:36:37 2021 +0100

s3:netapi: Remove username from 'struct libnetapi_ctx'

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit fd78554d11a60c75c0e6d2c8606a82bc20526c8a
Author: Andreas Schneider 
Date:   Thu Mar 18 11:14:39 2021 +0100

s3:netapi: Use public functions for username/password

Signed-off-by: Andreas Schneider 
Reviewed-by: Guenther Deschner 

commit 0aeca4e5a131c38328c7768e173b845f594c3470
Author: 

[SCM] Samba Shared Repository - branch master updated

2021-03-23 Thread Andrew Bartlett
The branch, master has been updated
   via  17283de8fd9 netcmd: Fix typos in offline domain backup test
   via  05b17c98598 netcmd: Avoid database corruption by opting not to 
create database files during an offline domain backup
   via  09995f780d1 netcmd: Determine which files are to be copied for an 
offline domain backup
   via  f52e6e5345b netcmd: Add test for an offline backup of nested 
directories
   via  542678908ac netcmd: Add test for an offline backup of a directory 
containing hardlinks
  from  447ad461588 man winbind: Remove untrue statement, you can run 
winbind without running nmbd.

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 17283de8fd967fbfe68f64b0cacb1e7aadf559fc
Author: Joseph Sutton 
Date:   Tue Mar 16 22:46:02 2021 +1300

netcmd: Fix typos in offline domain backup test

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 
Autobuild-Date(master): Wed Mar 24 00:46:31 UTC 2021 on sn-devel-184

commit 05b17c98598168b6d74a3f2dd0d9973e3bf407c1
Author: Joseph Sutton 
Date:   Tue Mar 16 22:20:21 2021 +1300

netcmd: Avoid database corruption by opting not to create database files 
during an offline domain backup

If backup dirs contain hardlinks, the backup process could previously
attempt to open an LMDB database already opened during the backup,
causing it to be recreated as a new TDB database. This commit ensures
that new database files are not created during this operation, and that
the main SamDB database is not modified.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14027

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 
Date:   Tue Mar 16 16:22:40 2021 +1300

netcmd: Determine which files are to be copied for an offline domain backup

The old behaviour attempted to check for and remove files with duplicate
names, but did not do so due to a bug, and would have left undetermined
which files were given priority when duplicate filenames were present.
Now when hardlinks are present, only one instance of each file is
chosen, with files in the private directory having priority. If one
backup dir is nested inside another, the files contained in the nested
directory are only added once. Additionally, the BIND DNS database is
omitted from the backup.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14027

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 
Date:   Thu Mar 18 10:52:52 2021 +1300

netcmd: Add test for an offline backup of nested directories

This test verifies that when performing an offline backup of a domain
where one of the directories to be backed up is nested inside another,
the contained files are only included once in the backup.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14027

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 
Date:   Tue Mar 16 16:13:05 2021 +1300

netcmd: Add test for an offline backup of a directory containing hardlinks

This test verifies that when performing an offline backup of a domain
where the directories to be backed up contain hardlinks, only one
instance of each file is backed up, and that files in the private
directory take precedence.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14027

Signed-off-by: Joseph Sutton 
Reviewed-by: Andrew Bartlett 
Reviewed-by: Douglas Bagnall 

[SCM] Samba Shared Repository - branch master updated

2021-03-23 Thread Ralph Böhme
The branch, master has been updated
   via  447ad461588 man winbind: Remove untrue statement, you can run 
winbind without running nmbd.
  from  321703fbea5 s3: vxfs: Remove unused vxfs_setxattr_path().

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 447ad46158858a687184aa2f8312343082334c66
Author: Rowland Penny 
Date:   Tue Mar 23 13:16:02 2021 +

man winbind: Remove untrue statement, you can run winbind without running 
nmbd.

Signed-off-by: Rowland Penny 
Reviewed-by: Ralph Boehme 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Tue Mar 23 15:15:02 UTC 2021 on sn-devel-184

---

Summary of changes:
 docs-xml/manpages/winbindd.8.xml | 4 
 1 file changed, 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/docs-xml/manpages/winbindd.8.xml b/docs-xml/manpages/winbindd.8.xml
index 99c00388c20..d5acc072a00 100644
--- a/docs-xml/manpages/winbindd.8.xml
+++ b/docs-xml/manpages/winbindd.8.xml
@@ -358,10 +358,6 @@ auth  required/lib/security/pam_unix.so \
The following notes are useful when configuring and
running winbindd: 
 
-   nmbd
-   8 must be running on the local 
machine
-   for winbindd to work. 
-
PAM is really easy to misconfigure.  Make sure you know what
you are doing when modifying PAM configuration files.  It is possible
to set up PAM such that you can no longer log into your system. 


-- 
Samba Shared Repository