[SCM] pam wrapper repository - branch master updated
The branch, master has been updated
via 39d9af8 cmake: Remove -Werror=declaration-after-statement
from 8e94874 cmake: Fix cmocka >= 1.1.6 find_package() in CONFIG mode
https://git.samba.org/?p=pam_wrapper.git;a=shortlog;h=master
- Log -
commit 39d9af80cdae1be805346bca4f40b71149d62ba8
Author: Andreas Schneider
Date: Mon Jul 10 11:32:23 2023 +0200
cmake: Remove -Werror=declaration-after-statement
This is not compatible with Python 3.12
Signed-off-by: Andreas Schneider
Reviewed-by: Stefan Metzmacher
---
Summary of changes:
CompilerChecks.cmake | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/CompilerChecks.cmake b/CompilerChecks.cmake
index 6c74b0b..559ecf9 100644
--- a/CompilerChecks.cmake
+++ b/CompilerChecks.cmake
@@ -32,7 +32,8 @@ if (UNIX)
add_c_compiler_flag("-Wpointer-arith" SUPPORTED_COMPILER_FLAGS)
add_c_compiler_flag("-Werror=pointer-arith" SUPPORTED_COMPILER_FLAGS)
add_c_compiler_flag("-Wdeclaration-after-statement"
SUPPORTED_COMPILER_FLAGS)
-add_c_compiler_flag("-Werror=declaration-after-statement"
SUPPORTED_COMPILER_FLAGS)
+# Not compatible with Python 3.12 headers
+#add_c_compiler_flag("-Werror=declaration-after-statement"
SUPPORTED_COMPILER_FLAGS)
add_c_compiler_flag("-Wreturn-type" SUPPORTED_COMPILER_FLAGS)
add_c_compiler_flag("-Werror=return-type" SUPPORTED_COMPILER_FLAGS)
add_c_compiler_flag("-Wuninitialized" SUPPORTED_COMPILER_FLAGS)
--
pam wrapper repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 7d2c68f2e25 s3:nmbd: Fix code spelling via 0ff51f86a67 s3:nmbd: Fix trailing white spaces in nmbd_incomingrequests.c via 4e1f1a8acee s3:nmbd: Fix trailing white spaces in nmbd_incomingdgrams.c via 6c2338f36c3 s3:nmbd: Fix trailing white spaces in nmbd.c via 856b5abc957 s3:modules: Fix code spelling via 1d2ec674a70 s3:modules: Remove fruit:ressource option with incorrect spelling via 005a78ee7fd s3:modules: Remove trailing white spaces of README.nfs4acls.txt via b64308f2a42 s3:modules: Remove trailing white spaces of vfs_hpuxacl.c via b746f777328 s3:locking: Fix code spelling via f64add99473 s3:librpc: Fix code spelling via 7f033268c86 wscript: Fix code spelling via f9107c55a88 examples: Remove outdated validchars via 573e5e06f8d example: Remove outdated config files from tridge from dfeabce44fb s3:rpc_server:netlogon: generate FAULT_INVALID_TAG for invalid netr_LogonGetCapabilities levels https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 7d2c68f2e257a64b58bfa3e9fe593d27718b3cd4 Author: Andreas Schneider Date: Thu Jul 13 09:09:48 2023 +0200 s3:nmbd: Fix code spelling Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Mon Jul 17 12:41:21 UTC 2023 on atb-devel-224 commit 0ff51f86a67c5d7a08519d7a115135a6d8e910df Author: Andreas Schneider Date: Thu Jul 13 09:10:07 2023 +0200 s3:nmbd: Fix trailing white spaces in nmbd_incomingrequests.c Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit 4e1f1a8acee717b3b6cd56f567dd518e93c43b51 Author: Andreas Schneider Date: Thu Jul 13 09:08:32 2023 +0200 s3:nmbd: Fix trailing white spaces in nmbd_incomingdgrams.c Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit 6c2338f36c3b045850d2cc1135f4e25f51458837 Author: Andreas Schneider Date: Thu Jul 13 09:08:01 2023 +0200 s3:nmbd: Fix trailing white spaces in nmbd.c Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit 856b5abc957453a58c17d2efcc1c5168200b8f59 Author: Andreas Schneider Date: Thu Jul 13 08:52:45 2023 +0200 s3:modules: Fix code spelling Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit 1d2ec674a7065c5745e13618f4600353649f5b9f Author: Andreas Schneider Date: Thu Jul 13 09:03:18 2023 +0200 s3:modules: Remove fruit:ressource option with incorrect spelling The plan was to remove it in 4.7. I think it is safe to remove it with 4.19. Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit 005a78ee7fde3520a9532cdff3b7a6979cfec1d8 Author: Andreas Schneider Date: Thu Jul 13 08:55:31 2023 +0200 s3:modules: Remove trailing white spaces of README.nfs4acls.txt Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit b64308f2a42bfb5d1c4da553c754c8b7c27d82a8 Author: Andreas Schneider Date: Thu Jul 13 08:53:26 2023 +0200 s3:modules: Remove trailing white spaces of vfs_hpuxacl.c Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit b746f7773288fe9a42d73b5b2c82e9e6aa0e2c52 Author: Andreas Schneider Date: Thu Jul 13 08:50:21 2023 +0200 s3:locking: Fix code spelling Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit f64add99473672cdca85f53a7b3be7455f1bd594 Author: Andreas Schneider Date: Thu Jul 13 08:47:11 2023 +0200 s3:librpc: Fix code spelling Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit 7f033268c86c857e20fbdfe65c64e9a00130fbda Author: Andreas Schneider Date: Thu Jul 13 08:46:20 2023 +0200 wscript: Fix code spelling Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit f9107c55a88460722fa548b2de10f41f3e8c7f06 Author: Andreas Schneider Date: Thu Jul 13 07:52:02 2023 +0200 examples: Remove outdated validchars I don't think we even look into this anymore and have other tests in place. Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett commit 573e5e06f8dac695659edc22a6934f4e10d966d7 Author: Andreas Schneider Date: Thu Jul 13 07:44:44 2023 +0200 example: Remove outdated config files from tridge I don't think he still runs Windows 95 ... Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett --- Summary of changes: examples/tridge/README | 8 - examples/tridge/smb.conf| 92 examples/tridge/smb.conf.WinNT | 14 -- examples/tridge/smb.conf.fjall | 20 ---
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via dfeabce44fb s3:rpc_server:netlogon: generate FAULT_INVALID_TAG for
invalid netr_LogonGetCapabilities levels
via d5f1097b622 s4:rpc_server:netlogon: generate FAULT_INVALID_TAG for
invalid netr_LogonGetCapabilities levels
via 404ce08e908 s4:torture/rpc: let rpc.schannel also check
netr_LogonGetCapabilities with different levels
via 5f87888ed53 netlogon.idl: add support for netr_LogonGetCapabilities
response level 2
from 5a5e24e s3:libsmb: Fix code spelling
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit dfeabce44fbb78083fbbb2aa634fc4172cf83db9
Author: Stefan Metzmacher
Date: Sat Jul 15 16:11:48 2023 +0200
s3:rpc_server:netlogon: generate FAULT_INVALID_TAG for invalid
netr_LogonGetCapabilities levels
This is important as Windows clients with KB5028166 seem to
call netr_LogonGetCapabilities with query_level=2 after
a call with query_level=1.
An unpatched Windows Server returns DCERPC_NCA_S_FAULT_INVALID_TAG
for query_level values other than 1.
While Samba tries to return NT_STATUS_NOT_SUPPORTED, but
later fails to marshall the response, which results
in DCERPC_FAULT_BAD_STUB_DATA instead.
Because we don't have any documentation for level 2 yet,
we just try to behave like an unpatched server and
generate DCERPC_NCA_S_FAULT_INVALID_TAG instead of
DCERPC_FAULT_BAD_STUB_DATA.
Which allows patched Windows clients to keep working
against a Samba DC.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15418
Signed-off-by: Stefan Metzmacher
Reviewed-by: Andrew Bartlett
Autobuild-User(master): Stefan Metzmacher
Autobuild-Date(master): Mon Jul 17 07:35:09 UTC 2023 on atb-devel-224
commit d5f1097b6220676d56ed5fc6707acf667b704518
Author: Stefan Metzmacher
Date: Sat Jul 15 16:11:48 2023 +0200
s4:rpc_server:netlogon: generate FAULT_INVALID_TAG for invalid
netr_LogonGetCapabilities levels
This is important as Windows clients with KB5028166 seem to
call netr_LogonGetCapabilities with query_level=2 after
a call with query_level=1.
An unpatched Windows Server returns DCERPC_NCA_S_FAULT_INVALID_TAG
for query_level values other than 1.
While Samba tries to return NT_STATUS_NOT_SUPPORTED, but
later fails to marshall the response, which results
in DCERPC_FAULT_BAD_STUB_DATA instead.
Because we don't have any documentation for level 2 yet,
we just try to behave like an unpatched server and
generate DCERPC_NCA_S_FAULT_INVALID_TAG instead of
DCERPC_FAULT_BAD_STUB_DATA.
Which allows patched Windows clients to keep working
against a Samba DC.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15418
Signed-off-by: Stefan Metzmacher
Reviewed-by: Andrew Bartlett
commit 404ce08e9088968311c714e756f5d58ce2cef715
Author: Stefan Metzmacher
Date: Sat Jul 15 17:25:05 2023 +0200
s4:torture/rpc: let rpc.schannel also check netr_LogonGetCapabilities with
different levels
The important change it that we expect DCERPC_NCA_S_FAULT_INVALID_TAG
for unsupported query_levels, we allow it to work with servers
with or without support for query_level=2.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15418
Signed-off-by: Stefan Metzmacher
Reviewed-by: Andrew Bartlett
commit 5f87888ed53320538cf773d64868390d8641a40e
Author: Stefan Metzmacher
Date: Sat Jul 15 17:20:32 2023 +0200
netlogon.idl: add support for netr_LogonGetCapabilities response level 2
We don't have any documentation about this yet, but tests against
a Windows Server 2022 patched with KB5028166 revealed that
the response for query_level=2 is exactly the same as
for querey_level=1.
Until we know the reason for query_level=2 we won't
use it as client nor support it in the server, but
we want ndrdump to work.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15418
Signed-off-by: Stefan Metzmacher
Reviewed-by: Andrew Bartlett
---
Summary of changes:
librpc/idl/netlogon.idl | 1 +
source3/rpc_server/netlogon/srv_netlog_nt.c | 29 --
source4/rpc_server/netlogon/dcerpc_netlogon.c | 28 --
source4/torture/rpc/netlogon.c| 77 ++-
4 files changed, 126 insertions(+), 9 deletions(-)
Changeset truncated at 500 lines:
diff --git a/librpc/idl/netlogon.idl b/librpc/idl/netlogon.idl
index 48a8c8f9310..85dd73ee7e4 100644
--- a/librpc/idl/netlogon.idl
+++ b/librpc/idl/netlogon.idl
@@ -1236,6 +1236,7 @@ interface netlogon
/* Function 0x15 */
typedef [switch_type(uint32)] union {
[case(1)] netr_NegotiateFlags server_capabilities;
+
