[SCM] Samba Shared Repository - branch master updated

2024-01-09 Thread Andreas Schneider
The branch, master has been updated
   via  e9c9615a2f6 s3:rpc_server: Mark _lsa_CreateTrustedDomainEx as 
NOT_IMPLMENTED
   via  179641bfbe1 s3:rpc_server: Mark _lsa_CreateTrustedDomain as 
NOT_IMPLMENTED
  from  1b6ef968d83 dcesrv_reply: just drop responses if the connection is 
already terminating

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit e9c9615a2f657b77890e5489e2d8f0f1c3116a16
Author: Andreas Schneider 
Date:   Mon Jan 8 16:15:03 2024 +0100

s3:rpc_server: Mark _lsa_CreateTrustedDomainEx as NOT_IMPLMENTED

There is no PDB backend supporting this.

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Jan  9 14:17:40 UTC 2024 on atb-devel-224

commit 179641bfbe184ef18896ec9d5dddf8e5c7770e2c
Author: Andreas Schneider 
Date:   Mon Jan 8 16:13:52 2024 +0100

s3:rpc_server: Mark _lsa_CreateTrustedDomain as NOT_IMPLMENTED

There is no PDB backend which is supporting this.

Signed-off-by: Andreas Schneider 
Reviewed-by: Stefan Metzmacher 

---

Summary of changes:
 source3/rpc_server/lsa/srv_lsa_nt.c | 36 
 1 file changed, 4 insertions(+), 32 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/lsa/srv_lsa_nt.c 
b/source3/rpc_server/lsa/srv_lsa_nt.c
index f125c65069d..e2078c63952 100644
--- a/source3/rpc_server/lsa/srv_lsa_nt.c
+++ b/source3/rpc_server/lsa/srv_lsa_nt.c
@@ -1981,18 +1981,8 @@ NTSTATUS _lsa_CreateTrustedDomainEx2(struct pipes_struct 
*p,
 NTSTATUS _lsa_CreateTrustedDomainEx(struct pipes_struct *p,
struct lsa_CreateTrustedDomainEx *r)
 {
-   struct lsa_CreateTrustedDomainEx2 q;
-   struct lsa_TrustDomainInfoAuthInfoInternal auth_info;
-
-   ZERO_STRUCT(auth_info);
-
-   q.in.policy_handle  = r->in.policy_handle;
-   q.in.info   = r->in.info;
-   q.in.auth_info_internal = _info;
-   q.in.access_mask= r->in.access_mask;
-   q.out.trustdom_handle   = r->out.trustdom_handle;
-
-   return _lsa_CreateTrustedDomainEx2(p, );
+   p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
+   return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 /***
@@ -2002,26 +1992,8 @@ NTSTATUS _lsa_CreateTrustedDomainEx(struct pipes_struct 
*p,
 NTSTATUS _lsa_CreateTrustedDomain(struct pipes_struct *p,
  struct lsa_CreateTrustedDomain *r)
 {
-   struct lsa_CreateTrustedDomainEx2 c;
-   struct lsa_TrustDomainInfoInfoEx info;
-   struct lsa_TrustDomainInfoAuthInfoInternal auth_info;
-
-   ZERO_STRUCT(auth_info);
-
-   info.domain_name= r->in.info->name;
-   info.netbios_name   = r->in.info->name;
-   info.sid= r->in.info->sid;
-   info.trust_direction= LSA_TRUST_DIRECTION_OUTBOUND;
-   info.trust_type = LSA_TRUST_TYPE_DOWNLEVEL;
-   info.trust_attributes   = 0;
-
-   c.in.policy_handle  = r->in.policy_handle;
-   c.in.info   = 
-   c.in.auth_info_internal = _info;
-   c.in.access_mask= r->in.access_mask;
-   c.out.trustdom_handle   = r->out.trustdom_handle;
-
-   return _lsa_CreateTrustedDomainEx2(p, );
+   p->fault_state = DCERPC_FAULT_OP_RNG_ERROR;
+   return NT_STATUS_NOT_IMPLEMENTED;
 }
 
 /***


-- 
Samba Shared Repository



[SCM] Samba Shared Repository - branch v4-19-test updated

2024-01-09 Thread Jule Anger
The branch, v4-19-test has been updated
   via  cfbaab5654c smbd: move access override for previous versions to the 
SMB layer
   via  0874d3ab3e1 smbd: check for previous versions in 
check_any_access_fsp()
   via  f5eb449cac8 smbd: use check_any_access_fsp() for all access checks
   via  44396d7bade smbd: replace CHECK_WRITE() macro with calls to 
check_any_access_fsp()
   via  bfa5f178099 smbd: set fsp->fsp_flags.can_write to false for access 
to previous-versions
   via  0352aae6ea1 smbd: return correct error when trying to create a 
hardlink to a VSS file
   via  8318428f3f8 smbd: fix check_any_access_fsp() for non-fsa fsps
   via  0f865a34f1a smbd: rename check_access_fsp() to 
check_any_access_fsp()
   via  9ee7991d97d smbd: set fsp_flags.is_fsa to true on printer file 
handles
   via  b8383780249 smbd: return the correct error in can_rename()
   via  a510fc46bcd smbtorture: expand smb2.twrp.write test
   via  bb9aea6a7e6 s4/libcli/raw: implemement 
RAW_SFILEINFO_LINK_INFORMATION
   via  b6c2c26e9ba selftest: remove error_inject from shadow_write share
  from  b9f60718ccd VERSION: Bump version up to Samba 4.19.5...

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-19-test


- Log -
commit cfbaab5654cc40ef08ab09492d20aac2f33cbf0e
Author: Ralph Boehme 
Date:   Fri Dec 15 11:59:36 2023 +0100

smbd: move access override for previous versions to the SMB layer

Doing the previous version access checks and semantics at the SMB
layer means we can simplify the shadow_copy2 and remove the kludge.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Mon Jan  8 16:58:26 UTC 2024 on atb-devel-224

(backported from commit f14a7065690b00e3c6af2c1f0b0aec51c1e0b372)
[s...@samba.org: vfs_shadow_copy2.c: no TALLOC_FREE() in context]
[s...@samba.org: open.c: assign result from calculate_open_access_flags()]

Autobuild-User(v4-19-test): Jule Anger 
Autobuild-Date(v4-19-test): Tue Jan  9 13:17:12 UTC 2024 on atb-devel-224

commit 0874d3ab3e1cb7e42900da9543963799b864e485
Author: Ralph Boehme 
Date:   Wed Dec 20 15:09:59 2023 +0100

smbd: check for previous versions in check_any_access_fsp()

Now that check_any_access_fsp() is broadly used consistently to
restrict access for all modifying operations, we can add a check for
previous versions to check_any_access_fsp() and it gets enforced
consistently.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher 
(cherry picked from commit fd4e41144a819b4403340e4a28664ac586722b41)

commit f5eb449cac82de61c4eadc1b134c92896f69aacf
Author: Ralph Boehme 
Date:   Wed Dec 20 18:01:57 2023 +0100

smbd: use check_any_access_fsp() for all access checks

Replaces the direct access to fsp->access_mask with a call to
check_any_access_fsp() which allows doing additional checks if needed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher 
(cherry picked from commit 02ed99343d19fd0845531ad99a46b1dd5b8a7a4f)

commit 44396d7bade98b41fb655e30d84195793684f593
Author: Ralph Boehme 
Date:   Wed Dec 20 18:32:25 2023 +0100

smbd: replace CHECK_WRITE() macro with calls to check_any_access_fsp()

The additional check if fd underlying fd is valid and not -1 should not be 
done
at this place. I actually would prefer an write to fail with EBADF if this
happens, as it's likely easier to debug why this happened. These days we 
should
always have a valid fd.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher 
(cherry picked from commit 995a31c8d4c1789c16bae6b8196f2565d4b1dfdb)

commit bfa5f1780990e4f763f0214fb660c64c53188e65
Author: Ralph Boehme 
Date:   Wed Dec 20 18:03:22 2023 +0100

smbd: set fsp->fsp_flags.can_write to false for access to previous-versions

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher 
(cherry picked from commit ee3035218df4cfd68b6aab6825c78f2b85234c6c)

commit 0352aae6ea1e8c38ca8ca091123ddde455c2e5ab
Author: Ralph Boehme 
Date:   Fri Dec 22 11:19:38 2023 +0100

smbd: return correct error when trying to create a hardlink to a VSS file

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13688

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher 
(cherry picked from commit a0ae45be770a13373c148a689b9761f14c4f942c)

commit 8318428f3f8dbdbc7ff11f2755ae6b702049c72d
Author: Ralph Boehme 
Date:   Thu Dec 21 10:58:09 2023 +0100

 

[SCM] Samba Shared Repository - branch master updated

2024-01-09 Thread Stefan Metzmacher
The branch, master has been updated
   via  1b6ef968d83 dcesrv_reply: just drop responses if the connection is 
already terminating
   via  e829f5d8ec3 dcesrv_core: add dcesrv_call_state->subreq in order to 
allow tevent_req_cancel() on termination
   via  87e37e73a9b witness.idl: add flag(NDR_PAHEX) to some hex based enums
   via  290b0b04ae4 witness.idl: make some types public in order to be used 
elsewhere
   via  5beef87816d witness.idl: Set cifs as auth service name for the 
witness interface
   via  78ec47a6674 tdb: fix python/tdbdump.py example
   via  3c73d201d45 examples/scripts: add smbXsrvdump
   via  8e850685a10 smbXsrv.idl: add python bindings
   via  b96ce32f826 smbstatus: let --json dump also session channels
   via  3f92a684abb smbstatus: let --json report the client_guid a session 
belongs to
   via  c1c326ebccb smbXsrv_session: store session_global->client_guid
   via  88b1c8723b3 s3:sessionid: export smbXsrv_session_global via 
sessionid->global
   via  d52f7279063 lib/util: let is_zero_addr() return true for AF_UNSPEC
   via  10b084f824f s3:smbd multichannel: improve smbXsrv_connection_dbg()
   via  475784d63e9 s3:smbd multichannel: let a cross-node session binding 
NT_STATUS_REQUEST_NOT_ACCEPTED
   via  8a3707e3ed9 s3:smbd multichannel: always allow multichannel to the 
ip of the queried connection
   via  f94d2ed13e6 libcli/security: remove PRIMARY_{USER,GROUP}_SID_INDEX 
defines from security.h
   via  6331d33ae49 libcli/smb: add new SMB2_SHAREFLAG_ defines in 
smb2_constants.h
  from  f14a7065690 smbd: move access override for previous versions to the 
SMB layer

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 1b6ef968d8370757cb472a1e3bfe030f8066c50d
Author: Stefan Metzmacher 
Date:   Fri Nov 24 14:42:35 2023 +0100

dcesrv_reply: just drop responses if the connection is already terminating

There's no reason to waste resources...

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Tue Jan  9 11:26:55 UTC 2024 on atb-devel-224

commit e829f5d8ec3a77acb52a22d45e61dcce03762a10
Author: Stefan Metzmacher 
Date:   Fri Nov 24 14:02:02 2023 +0100

dcesrv_core: add dcesrv_call_state->subreq in order to allow 
tevent_req_cancel() on termination

Requests might be cancelled if the connection got disconnected,
we got an ORPHANED or CO_CANCEL pdu.

But this is all opt-in for the backends to choose.

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner 
Reviewed-by: Andreas Schneider 

commit 87e37e73a9ba13ed92a33a385a387b225b2b9190
Author: Stefan Metzmacher 
Date:   Fri Dec 29 10:20:02 2023 +0100

witness.idl: add flag(NDR_PAHEX) to some hex based enums

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner 
Reviewed-by: Andreas Schneider 

commit 290b0b04ae41b835f864bba02b1320693ef199d3
Author: Stefan Metzmacher 
Date:   Fri Nov 24 16:38:06 2023 +0100

witness.idl: make some types public in order to be used elsewhere

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner 
Reviewed-by: Andreas Schneider 

commit 5beef87816d103a729508ce88368c30c87b1fa4e
Author: Samuel Cabrero 
Date:   Wed Oct 21 18:30:29 2020 +0200

witness.idl: Set cifs as auth service name for the witness interface

Windows clients use the 'cifs' service name to bind to the witness 
interface.

Signed-off-by: Samuel Cabrero 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner 
Reviewed-by: Andreas Schneider 

commit 78ec47a6674db65d738305cf00861aa711886a43
Author: Stefan Metzmacher 
Date:   Fri Nov 24 16:28:38 2023 +0100

tdb: fix python/tdbdump.py example

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner 
Reviewed-by: Andreas Schneider 

commit 3c73d201d454a88135757065a2b238e6d94a1ac9
Author: Ralph Boehme 
Date:   Sun Jan 28 15:35:44 2018 +0100

examples/scripts: add smbXsrvdump

A simple python tool to dump smbXsrv TDB databases.

Signed-off-by: Ralph Boehme 
Reviewed-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner 
Reviewed-by: Andreas Schneider 

commit 8e850685a1052a16bea402df3e8057218080c373
Author: Stefan Metzmacher 
Date:   Fri Nov 24 16:09:58 2023 +0100

smbXsrv.idl: add python bindings

This is useful for some scripting examples and debugging...

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Günther Deschner 
Reviewed-by: Andreas Schneider 

commit b96ce32f826ba03384e6a7535200d7e18354fc4b
Author: Stefan Metzmacher 
Date:   Fri Dec 15 16:46:50 2023 +0100

smbstatus: let --json dump also session channels

This makes if easier to see how tcp