[SCM] Samba Shared Repository - branch v4-19-test updated
The branch, v4-19-test has been updated
via a58338ec926 libgpo: Do not segfault if we don't have a valid
security descriptor
via 51a3797f57e libgpo: Fix trailing spaces in pygpo.c
from 8ea3973ad40 python:gp: Implement client site lookup in
site_dn_for_machine()
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-19-test
- Log -
commit a58338ec926d4979253b86fcc273be66e708adbd
Author: Andreas Schneider
Date: Tue Mar 5 13:17:19 2024 +0100
libgpo: Do not segfault if we don't have a valid security descriptor
Program received signal SIGSEGV, Segmentation fault.
ndr_push_security_descriptor (ndr=ndr@entry=0x55bf41b0,
ndr_flags=ndr_flags@entry=768, r=r@entry=0x0) at
librpc/gen_ndr/ndr_security.c:713
713
NDR_CHECK(ndr_push_security_descriptor_revision(ndr, NDR_SCALARS, r->revision));
Thread 1 (Thread 0x77ece740 (LWP 21460) "python3"):
#0 ndr_push_security_descriptor (ndr=ndr@entry=0x55bf41b0,
ndr_flags=ndr_flags@entry=768, r=r@entry=0x0) at
librpc/gen_ndr/ndr_security.c:713
_flags_save_STRUCT = 0
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
__FUNCTION__ = "ndr_push_security_descriptor"
#1 0x7617237f in ndr_push_struct_blob
(blob=blob@entry=0x7fffdb20, mem_ctx=0x55aa3bd0, p=0x0,
fn=0x76074ad0 , fn@entry=0x760706c8
) at ../../librpc/ndr/ndr.c:1438
_status =
ndr = 0x55bf41b0
#2 0x7607cccf in marshall_sec_desc (mem_ctx=,
secdesc=, data=data@entry=0x7fffdb80,
len=len@entry=0x7fffdb78) at ../../libcli/security/secdesc.c:241
blob = {data = 0x7fffdb40 "`\333\377\377\377\177", length =
140737352374299}
ndr_err =
__FUNCTION__ = "marshall_sec_desc"
#3 0x729edd94 in GPO_marshall_get_sec_desc_buf (self=, args=, kwds=) at ../../libgpo/pygpo.c:119
gpo_ptr =
status =
data = 0x0
len = 0
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15599
Signed-off-by: Andreas Schneider
Reviewed-by: David Mulder
(cherry picked from commit b13d4359f2f16e391763d1dc6a5718def973fabb)
Autobuild-User(v4-19-test): Jule Anger
Autobuild-Date(v4-19-test): Fri Mar 15 11:20:39 UTC 2024 on atb-devel-224
commit 51a3797f57ea988677016395784bd8d117062b11
Author: Andreas Schneider
Date: Mon Mar 4 16:42:38 2024 +0100
libgpo: Fix trailing spaces in pygpo.c
Signed-off-by: Andreas Schneider
Reviewed-by: David Mulder
(cherry picked from commit 6fb86a0fa62d93c1c84c2000f01c381a9e8217e1)
---
Summary of changes:
libgpo/pygpo.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c
index adbd5b4688d..0f7116313f2 100644
--- a/libgpo/pygpo.c
+++ b/libgpo/pygpo.c
@@ -116,6 +116,11 @@ static PyObject *GPO_marshall_get_sec_desc_buf(PyObject
*self, PyObject *args,
uint8_t *data = NULL;
size_t len = 0;
+ if (gpo_ptr->security_descriptor == NULL) {
+ PyErr_SetString(PyExc_RuntimeError, "Uninitialized");
+ return NULL;
+ }
+
status = marshall_sec_desc(gpo_ptr, gpo_ptr->security_descriptor,
, );
if (!NT_STATUS_IS_OK(status)) {
@@ -371,7 +376,7 @@ static int py_ads_init(ADS *self, PyObject *args, PyObject
*kwds)
workgroup,
ldap_server,
ADS_SASL_PLAIN);
-
+
return 0;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-20-test updated
The branch, v4-20-test has been updated
via 69b69bb2085 libgpo: Do not segfault if we don't have a valid
security descriptor
via 72bd247c97d libgpo: Fix trailing spaces in pygpo.c
from 4d1536f86b9 VERSION: Bump version up to Samba 4.20.0rc5...
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-20-test
- Log -
commit 69b69bb2085dfc842292db14eadbcba71b096d69
Author: Andreas Schneider
Date: Tue Mar 5 13:17:19 2024 +0100
libgpo: Do not segfault if we don't have a valid security descriptor
Program received signal SIGSEGV, Segmentation fault.
ndr_push_security_descriptor (ndr=ndr@entry=0x55bf41b0,
ndr_flags=ndr_flags@entry=768, r=r@entry=0x0) at
librpc/gen_ndr/ndr_security.c:713
713
NDR_CHECK(ndr_push_security_descriptor_revision(ndr, NDR_SCALARS, r->revision));
Thread 1 (Thread 0x77ece740 (LWP 21460) "python3"):
#0 ndr_push_security_descriptor (ndr=ndr@entry=0x55bf41b0,
ndr_flags=ndr_flags@entry=768, r=r@entry=0x0) at
librpc/gen_ndr/ndr_security.c:713
_flags_save_STRUCT = 0
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
_status =
__FUNCTION__ = "ndr_push_security_descriptor"
#1 0x7617237f in ndr_push_struct_blob
(blob=blob@entry=0x7fffdb20, mem_ctx=0x55aa3bd0, p=0x0,
fn=0x76074ad0 , fn@entry=0x760706c8
) at ../../librpc/ndr/ndr.c:1438
_status =
ndr = 0x55bf41b0
#2 0x7607cccf in marshall_sec_desc (mem_ctx=,
secdesc=, data=data@entry=0x7fffdb80,
len=len@entry=0x7fffdb78) at ../../libcli/security/secdesc.c:241
blob = {data = 0x7fffdb40 "`\333\377\377\377\177", length =
140737352374299}
ndr_err =
__FUNCTION__ = "marshall_sec_desc"
#3 0x729edd94 in GPO_marshall_get_sec_desc_buf (self=, args=, kwds=) at ../../libgpo/pygpo.c:119
gpo_ptr =
status =
data = 0x0
len = 0
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15599
Signed-off-by: Andreas Schneider
Reviewed-by: David Mulder
(cherry picked from commit b13d4359f2f16e391763d1dc6a5718def973fabb)
Autobuild-User(v4-20-test): Jule Anger
Autobuild-Date(v4-20-test): Fri Mar 15 10:29:54 UTC 2024 on atb-devel-224
commit 72bd247c97da62789ab72111df11466dfb2a79fa
Author: Andreas Schneider
Date: Mon Mar 4 16:42:38 2024 +0100
libgpo: Fix trailing spaces in pygpo.c
Signed-off-by: Andreas Schneider
Reviewed-by: David Mulder
(cherry picked from commit 6fb86a0fa62d93c1c84c2000f01c381a9e8217e1)
---
Summary of changes:
libgpo/pygpo.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c
index adbd5b4688d..0f7116313f2 100644
--- a/libgpo/pygpo.c
+++ b/libgpo/pygpo.c
@@ -116,6 +116,11 @@ static PyObject *GPO_marshall_get_sec_desc_buf(PyObject
*self, PyObject *args,
uint8_t *data = NULL;
size_t len = 0;
+ if (gpo_ptr->security_descriptor == NULL) {
+ PyErr_SetString(PyExc_RuntimeError, "Uninitialized");
+ return NULL;
+ }
+
status = marshall_sec_desc(gpo_ptr, gpo_ptr->security_descriptor,
, );
if (!NT_STATUS_IS_OK(status)) {
@@ -371,7 +376,7 @@ static int py_ads_init(ADS *self, PyObject *args, PyObject
*kwds)
workgroup,
ldap_server,
ADS_SASL_PLAIN);
-
+
return 0;
}
--
Samba Shared Repository
