Re: [SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-24-g016795c

2007-10-12 Thread Stefan (metze) Metzmacher
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

simo schrieb:
 On Fri, 2007-10-12 at 16:07 +0200, Stefan (metze) Metzmacher wrote:
 that's wrong as a function is also possible, and now
 we have no correct string contant in version.h
 and version.c breaks:

 time for trying 'git revert g016795c' :-)
 
 I had the impression you can't revert once pushed.

git revert creates a new commit, but can't do:

git reset --hard HEAD^
git push

as this would not be a fast-forward

metze
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHD4yzm70gjA5TCD8RApZhAJ96D4Z/a3+axGnV84wsNqmJr2Fc+gCgohVF
kDV+bRFuU80aJpGOTPeU+xs=
=A3+U
-END PGP SIGNATURE-


Re: [SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-24-g016795c

2007-10-12 Thread simo
On Fri, 2007-10-12 at 16:07 +0200, Stefan (metze) Metzmacher wrote:
 
 that's wrong as a function is also possible, and now
 we have no correct string contant in version.h
 and version.c breaks:
 
 time for trying 'git revert g016795c' :-)

I had the impression you can't revert once pushed.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer [EMAIL PROTECTED]
Senior Software Engineer at Red Hat Inc. [EMAIL PROTECTED]



Re: [SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-24-g016795c

2007-10-12 Thread Stefan (metze) Metzmacher
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

 diff --git a/source/VERSION b/source/VERSION
 index 858b627..d34a625 100644
 --- a/source/VERSION
 +++ b/source/VERSION
 @@ -95,5 +95,5 @@ SAMBA_VERSION_IS_GIT_SNAPSHOT=yes
  # e.g. SAMBA_VERSION_VENDOR_SUFFIX=vendor_version()#
  #  -  CVS 3.0.0rc2-VendorVersion#
  
 -SAMBA_VERSION_VENDOR_SUFFIX=test
 +SAMBA_VERSION_VENDOR_SUFFIX=test
  SAMBA_VENDOR_PATCH=

Hi Michael,

that's wrong as a function is also possible, and now
we have no correct string contant in version.h
and version.c breaks:

time for trying 'git revert g016795c' :-)

Compiling lib/version.c
lib/version.c: In function ‘samba_version_string’:
lib/version.c:38: error: ‘test’ undeclared (first use in this function)
lib/version.c:38: error: (Each undeclared identifier is reported only once
lib/version.c:38: error: for each function it appears in.)
lib/version.c:31: warning: unused variable ‘remaining’
lib/version.c:29: warning: unused variable ‘tmp_version’


-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFHD3+Qm70gjA5TCD8RApCuAJ9K4nYOm0BOR3gawi0hjObXm2eFkACeNMvA
dHbFvvqXNLtsF7wQMuXAby0=
=txJF
-END PGP SIGNATURE-


[SCM] Samba Shared Repository - branch v3-2-test updated - initial-v3-2-unstable-24-g016795c

2007-10-12 Thread Michael Adam
The branch, v3-2-test has been updated
   via  016795c550ee0b78fa46c508703fb5e1e40d8f36 (commit)
  from  e68671b59500d7e1b645c80ee264c49893f8df84 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-2-test

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit 016795c550ee0b78fa46c508703fb5e1e40d8f36
Author: Michael Adam [EMAIL PROTECTED]
Date:   Fri Oct 12 14:39:35 2007 +0200

Remove superfluous quotation marks around samba version
vendor suffix.

Michael

---

Summary of changes:
 source/VERSION |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source/VERSION b/source/VERSION
index 858b627..d34a625 100644
--- a/source/VERSION
+++ b/source/VERSION
@@ -95,5 +95,5 @@ SAMBA_VERSION_IS_GIT_SNAPSHOT=yes
 # e.g. SAMBA_VERSION_VENDOR_SUFFIX=vendor_version()#
 #  -  CVS 3.0.0rc2-VendorVersion#
 
-SAMBA_VERSION_VENDOR_SUFFIX=test
+SAMBA_VERSION_VENDOR_SUFFIX=test
 SAMBA_VENDOR_PATCH=


-- 
Samba Shared Repository