[PATCH] winbindd/libsmb get_dc_list patch (cvs head)
Hi,
Using CVS-HEAD I hit the following bug in winbind, in
libsmb/namequery.c#get_dc_list():
The code piece to remove duplicate entrys/zeroed IPs is buggy. basically
it sets the number of DCs found to -1 if no dupe/zeroed IP was detected.
It's fixed very easily :) I've attached a patch for libsmb/namequery.c,
to make things work again.
I'm not subscribed to this list, in case please include me in a reply.
best wishes thanks,
dominik
--
Dominik 'Aeneas' Schnitzer [EMAIL PROTECTED]
http://www.schnitzer.at/dominik/ OpenPGP:C0C2CBEE
Latest Update - 24. August 2002: Interrail 2002 pictures
Index: namequery.c
===
RCS file: /cvsroot/samba/source/libsmb/namequery.c,v
retrieving revision 1.115
diff -u -r1.115 namequery.c
--- namequery.c 26 Nov 2002 11:57:29 - 1.115
+++ namequery.c 30 Nov 2002 22:34:34 -
@@ -1340,6 +1340,7 @@
while ( ilocal_count )
{
if ( !is_zero_ip(return_iplist[i]) ) {
+ hole_index = i + 1;
i++;
continue;
}
Re: [PATCH] winbindd/libsmb get_dc_list patch (cvs head)
On Sun, Dec 01, 2002 at 12:45:12AM +0100, Dominik 'Aeneas' Schnitzer wrote: Hi, Using CVS-HEAD I hit the following bug in winbind, in libsmb/namequery.c#get_dc_list(): The code piece to remove duplicate entrys/zeroed IPs is buggy. basically it sets the number of DCs found to -1 if no dupe/zeroed IP was detected. It's fixed very easily :) I've attached a patch for libsmb/namequery.c, to make things work again. I'm not subscribed to this list, in case please include me in a reply. Good catch - thanks. I've fixed this in a differnt way, could you please look at the patch and confirm it's ok ? Thanks, Jeremy.
Re: [PATCH] winbindd/libsmb get_dc_list patch (cvs head)
On Sun, 2002-12-01 at 01:46, [EMAIL PROTECTED] wrote: Good catch - thanks. I've fixed this in a differnt way, could you please look at the patch and confirm it's ok ? Hi, I just cvs-update'd and tried it out -- everything works fine for me :) thanks, domi. -- Dominik 'Aeneas' Schnitzer [EMAIL PROTECTED] http://www.schnitzer.at/dominik/ OpenPGP:C0C2CBEE Latest Update - 24. August 2002: Interrail 2002 pictures
