Re: [Savannah-users] Anonymous commit (empty Author and Committer)

2015-10-31 Thread André Z . D . A .
> 30.10.2015 23:59, Lennart Sorensen пишет:
> 
>> On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' 
>> Serbinenko wrote:
>>
>>> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>>
 On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:

> On 30.10.2015 15:26, Andrei Borzenkov wrote:
>
>> See
>> http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac
>>
>> I was not even aware that this is possible. Is there anything on server
>> side that can prevent it?
>>
>> Would be good if commit were amended and force pushed to fix it.
>
> It is a bug in SGit. I'll investigate how it happened
>>>
>>> I don't have non-fast-forward rights. Does someone from savannah-users
>>> have them? Could he just delete this commit?
>>
>> If you do that, then anyone that already did a pull after it went in
>> will have a broken tree. Rather annoying.
> 
> If we decide to fix this commit it is better done now, while it is the
> last one. It is annoying but do you have suggestion how it can be done
> differently?

+1 to undo it now

Indeed. The faster it is fixed smaller the number of potential unintentional 
repeats for it, if any.




Re: [Savannah-users] Anonymous commit (empty Author and Committer)

2015-10-31 Thread Andrei Borzenkov

30.10.2015 23:19, Vladimir 'φ-coder/phcoder' Serbinenko пишет:

On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote:

On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote:

On 30.10.2015 15:26, Andrei Borzenkov wrote:

See
http://git.savannah.gnu.org/cgit/grub.git/commit/?id=206676601eb853fc319df14cd3398fbdfde665ac


I was not even aware that this is possible. Is there anything on server
side that can prevent it?

Would be good if commit were amended and force pushed to fix it.


It is a bug in SGit. I'll investigate how it happened


I don't have non-fast-forward rights. Does someone from savannah-users
have them? Could he just delete this commit?


Looking at mail archives, non-fast-forward is global repository property 
and disabled by default. We probably need to open Savannah ticket to get 
it temporary enabled.




Re: [Savannah-users] Anonymous commit (empty Author and Committer)

2015-10-31 Thread Andrei Borzenkov

31.10.2015 10:02, Andreas Schwab пишет:

Kaz Kylheku  writes:


Nope. They will have a git in which that commit looks like their own
local work. *Someone* will inadvertently do a "git push" to blast out
their changes based on that deleted commit, thereby causing it to
reappear.


Not if another one pushes something different in the mean time.



Which is why I said "amended".



Re: [Savannah-users] Anonymous commit (empty Author and Committer)

2015-10-31 Thread Andreas Schwab
Kaz Kylheku  writes:

> Nope. They will have a git in which that commit looks like their own
> local work. *Someone* will inadvertently do a "git push" to blast out
> their changes based on that deleted commit, thereby causing it to
> reappear.

Not if another one pushes something different in the mean time.

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."