Re: [Scons-dev] Using SHLIBVERSION fails on Solaris and probably all other unixes but Linux
Pull request created: https://bitbucket.org/scons/scons/pull-request/186/attempt-to-fix-versionned-shared-library Le 19 sept. 2014 à 22:54, alexandre.feb...@gmail.com a écrit : > I may, but I'm pretty sure my patch is OK for me but only for me, and I've no > real clue on what is the correct way to fix this in all situations. > > Le 19 sept. 2014 à 21:48, William Blevins a écrit : > >> Would you mind making a pull request via Bitbucket? >> >> On Sep 19, 2014 1:03 PM, "Alexandre Feblot" wrote: >> The change on SCons/Tool/__init__.py line 308 was a bad idea, it broke >> Solaris build. >> Attached is my final patch which seem to work properly. >> >> 2014-09-19 17:36 GMT+02:00 Alexandre Feblot : >> So, I fixed point 2 by adding the same kind of fixes ( or platform == >> 'sunos') on : >> >> * required for sure: >> SCons/Tool/__init__.py line 259 >> >> SCons/Tool/__init__.py line 308 >> >> >> * not required but seems related, I don't really know: >> SCons/Tool/install.py" line 152 >> >> SCons/Tool/install.py" line 163 >> >> >> 2014-09-19 15:30 GMT+02:00 Alexandre Feblot : >> Hi, >> >> as the title says, it fails with the following error:" IndexError: list >> index out of range" in SCons/Tool/link.py. >> >> The reason is that versionned shared lib seem to be handled properly for >> unixes if PLATFORM=='posix', whereas on Solaris, it is detected as"sunos" >> rather than "posix". >> >> >> I tried to fix at SCons/Tool/link.py line 108: if platform == 'posix' or >> platform == 'sunos':, but >> This is an ugly fix which does not take into account other unixes which >> probably fail the same way. In fact, 'posix' is not at the same meaning >> level as 'sunos'. Shouldn't PLATFORM be set to something like 'linux' on >> linux, and a posix flag to be set for all posix platforms? >> This just fixes part of the issue. It now does create the lib with its >> version number, but not the 2 symlinks (and I don't really kow where to >> search for that. Any hint will be welcome). >> >> Note: I'd be happy to fill a bug, but should this still be done on Tigris, >> with ongoing migrations to new bug trackers (and I'm totally lost with the >> current status of these migrations)? >> >> Attached: the smallest example to reproduce the issue. >> >> >> >> ___ >> Scons-dev mailing list >> Scons-dev@scons.org >> https://pairlist2.pair.net/mailman/listinfo/scons-dev >> >> ___ >> Scons-dev mailing list >> Scons-dev@scons.org >> https://pairlist2.pair.net/mailman/listinfo/scons-dev > ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] 2.3.3 Release issue ?
On Sun, Sep 21, 2014 at 3:10 PM, wrote: > Hello, > > I see no commit and no pull request about that. Am I overlooking > something, or has this been forgotten? > Thanks for the reminder, Alexandre. Yes, we need to take care of this. (I was out of the country for a week.) Does anyone have a patch ready? -- Gary ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] 2.3.3 Release issue ?
Hello, I see no commit and no pull request about that. Am I overlooking something, or has this been forgotten? Le 8 sept. 2014 à 19:47, anatoly techtonik a écrit : > Anyway we need to wait when Gary is available to wrap a new release > with this fix. Is there anybody else who can release? > > On Mon, Sep 8, 2014 at 8:27 PM, anatoly techtonik wrote: >> I wonder why buildbots are silent about this? >> >> On Mon, Sep 8, 2014 at 8:25 PM, anatoly techtonik >> wrote: >>> On Mon, Sep 8, 2014 at 7:41 PM, Alexandre Feblot >>> wrote: Hi, Would there be a release issue with 2.3.3 ? Downloaded from http://prdownloads.sourceforge.net/scons/scons-2.3.3.tar.gz Installed by python setup.py install --prefix /usr/local --optimize 2 --symlink-scons scons --version SCons by Steven Knight et al.: script: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine path: ['/usr/local/lib/scons-2.3.3/SCons'] Copyright (c) 2001 - 2014 The SCons Foundation EnsureSConsVersion() just prints: scons: warning: EnsureSConsVersion is ignored for development version >>> >>> Yes. This is a bug: >>> >>> def EnsureSConsVersion(self, major, minor, revision=0): >>> """Exit abnormally if the SCons version is not late enough.""" >>> if SCons.__version__ == '2.3.3': >>> SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning, >>> >>> This should be: >>> >>> def EnsureSConsVersion(self, major, minor, revision=0): >>> """Exit abnormally if the SCons version is not late enough.""" >>> if SCons.__version__ == '__VERSION__': >>> SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning, >>> >>> The __VERSION__ of course was replaced during our build process. The >>> quick fix is: >>> - if SCons.__version__ == '__VERSION__': >>> + if SCons.__version__ == '__' + 'VERSION__': >> >> >> >> -- >> anatoly t. > > > > -- > anatoly t. > ___ > Scons-dev mailing list > Scons-dev@scons.org > https://pairlist2.pair.net/mailman/listinfo/scons-dev ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
