Re: [Scons-dev] SCons and Python 3
Bill, On 15.12.2015 23:07, Bill Deegan wrote: Dirk, Looks like the pull request blew up windows testing.. http://buildbot.scons.org/builders/win7-64-vs20102.7/builds/257/steps/shell/logs/stdio Do you have access to a machine to take a look? just gave this another short look, and I think I know what's wrong: src/engine/SCons/Util.py, make ll. 587 look like this if can_read_reg: WinError = WindowsError HKEY_CLASSES_ROOT = hkey_mod.HKEY_CLASSES_ROOT such that Util.WinError gets also initialized if we can read the registry. That should help. ;) Regards, Dirk ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] SCons and Python 3
Bill, On 15.12.2015 23:07, Bill Deegan wrote: Dirk, Looks like the pull request blew up windows testing.. http://buildbot.scons.org/builders/win7-64-vs20102.7/builds/257/steps/shell/logs/stdio sorry for that. Do you have access to a machine to take a look? I'd have to fire up one of my old Windows XP boxes under kvm/VirtualBox and see if I can reproduce the error...not sure if this is a good idea though, because it would only have MinGW installed...but no VisualStudio of any kind. And I'm not sure that I have a decent Python 2.7.x in there, might be only 2.6, arrghh. I would also get to this tomorrow night earliest, it's pretty late here already. So if you can take a look, I don't mind you (or someone else) taking over... ;) Regards, Dirk ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] SCons and Python 3
Dirk, Looks like the pull request blew up windows testing.. http://buildbot.scons.org/builders/win7-64-vs20102.7/builds/257/steps/shell/logs/stdio Do you have access to a machine to take a look? -Bill On Tue, Dec 15, 2015 at 7:08 AM, William Blevins wrote: > +1 for just merging the patch > > On Tue, Dec 15, 2015 at 3:36 AM, Bill Deegan > wrote: > >> Dirk, >> >> I think we've given enough notice that pre 2.7 is going to be dropped. >> I'll take a pass through the updated pull request (#284) and merge it, >> unless someone has serious issues with doing so. >> >> -Bill >> >> >> On Mon, Dec 14, 2015 at 4:53 PM, Dirk Bächle wrote: >> >>> Hi there, >>> >>> On 11.12.2015 22:39, Bill Deegan wrote: >>> +1 on waiting for Dirks pull request to land. He has a couple items to add before it's complete. He said he'll be working on them over the weekend. Might be done by Tuesday.. >>> I've updated my pull request with an additional commit. So, short of a >>> final review, it should be ready to get merged... >>> >>> I'd like to raise one question though: What about the integration of the >>> "stubprocess.py" wrapper? Wasn't this planned for the next release 2.5? If >>> we want to keep it this way, it might be better to *not* merge my PR into >>> "trunk" right now, but only onto the python3 branch directly. >>> Like this, we could work on the "stubprocess" thingy, merge it to >>> "trunk" first, and only then put PR#284 on top. This would give us the >>> opportunity to release a 2.5 with the "stubprocess.py" speedup, but still >>> (some) backward compatibility to Python 2.6...so more users could benefit >>> from this? >>> >>> Just as an idea... >>> >>> Best regards, >>> >>> Dirk >>> >>> >>> >>> ___ >>> Scons-dev mailing list >>> Scons-dev@scons.org >>> https://pairlist2.pair.net/mailman/listinfo/scons-dev >>> >> >> >> ___ >> Scons-dev mailing list >> Scons-dev@scons.org >> https://pairlist2.pair.net/mailman/listinfo/scons-dev >> >> > > ___ > Scons-dev mailing list > Scons-dev@scons.org > https://pairlist2.pair.net/mailman/listinfo/scons-dev > > ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] SCons and Python 3
+1 for just merging the patch On Tue, Dec 15, 2015 at 3:36 AM, Bill Deegan wrote: > Dirk, > > I think we've given enough notice that pre 2.7 is going to be dropped. > I'll take a pass through the updated pull request (#284) and merge it, > unless someone has serious issues with doing so. > > -Bill > > > On Mon, Dec 14, 2015 at 4:53 PM, Dirk Bächle wrote: > >> Hi there, >> >> On 11.12.2015 22:39, Bill Deegan wrote: >> >>> +1 on waiting for Dirks pull request to land. >>> He has a couple items to add before it's complete. >>> He said he'll be working on them over the weekend. >>> Might be done by Tuesday.. >>> >>> >> I've updated my pull request with an additional commit. So, short of a >> final review, it should be ready to get merged... >> >> I'd like to raise one question though: What about the integration of the >> "stubprocess.py" wrapper? Wasn't this planned for the next release 2.5? If >> we want to keep it this way, it might be better to *not* merge my PR into >> "trunk" right now, but only onto the python3 branch directly. >> Like this, we could work on the "stubprocess" thingy, merge it to "trunk" >> first, and only then put PR#284 on top. This would give us the opportunity >> to release a 2.5 with the "stubprocess.py" speedup, but still (some) >> backward compatibility to Python 2.6...so more users could benefit from >> this? >> >> Just as an idea... >> >> Best regards, >> >> Dirk >> >> >> >> ___ >> Scons-dev mailing list >> Scons-dev@scons.org >> https://pairlist2.pair.net/mailman/listinfo/scons-dev >> > > > ___ > Scons-dev mailing list > Scons-dev@scons.org > https://pairlist2.pair.net/mailman/listinfo/scons-dev > > ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
