Re: [Scons-dev] Python 2 and Python 3 on same project

[Bill Deegan]

I'm not sure there's a good way to determine if the sconsign is from
another version of python rather than just corrupted in some fashion.

There's no harm in having different files per python version, (or just .py3
for python 3 and no change for py 2 at this time).

sconsign is not tied to being a pickle, though that's the current
implementation.
We're open to faster options (if there are some).

Right now in one build I'm working with for a client, a null build takes
approx 55 seconds of which 10 seconds are spent writing the pickle.
Obviously a null build is not a normal build, but say your change only
requires one file rebuilt, and then you still write the entire sconsign. An
appreciable amount of runtime percentage wise is spent rewritting bits of
the sconsign which haven't changed..



On Thu, Jul 13, 2017 at 4:58 PM, Daniel Holth  wrote:

> It would make sense to replace the file because it should be very unusual
> to run the same SConstruct with multiple Pythons (unless you are a SCons
> developer unfortunately) and because the extension should depend on the
> version of the pickle protocol used, not the major version of Python.
>
> On Thu, Jul 13, 2017, 16:09 Bill Deegan  wrote:
>
>> The previous code (which is currently commented out), had different file
>> extension for py3, so there'd be no collision.
>> Though a warning that a sconsign from opposite python version is present
>> might be wise.
>>
>>
>> On Thu, Jul 13, 2017 at 3:24 PM, Daniel Holth  wrote:
>>
>>> Would it make more sense to present a warning and then replace the
>>> .dblite file?
>>>
>>> On Thu, Jul 13, 2017 at 2:09 PM Bill Deegan 
>>> wrote:
>>>
 dblite.py line 43.

 If you uncomment that and then run the tests py2 and py3 some will
 break because they are  looking for the file name without the .py3
 extension.
 Perhaps add a method or constant to QMTest/TestSCons.py which the
 default file name and use that in the tests which fail?

 -Bill

 On Thu, Jul 13, 2017 at 10:01 AM, Russel Winder 
 wrote:

> On Thu, 2017-07-13 at 09:10 -0400, Bill Deegan wrote:
> > Yes.
> >
> > There was a separate .py3 and .py2 version of sconsign.
> > Probably time to turn that back on and resolve test failures due to
> > changed
> > sconsign name.
> >
> > Care to give it a try?
> > ;)
> >
>
> Yes, I can do that. What change do I need to make for it to work?
>
> --
> Russel.
> 
> =
> Dr Russel Winder t:+44 20 7585 2200   voip:sip:
> russel.win...@ekiga.net
> 41 Buckmaster Road   m:+44 7770 465 077   xmpp:rus...@winder.org.uk
> London SW11 1EN, UK  w: www.russel.org.uk skype:russel_winder
>
> ___
> Scons-dev mailing list
> Scons-dev@scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
 ___
 Scons-dev mailing list
 Scons-dev@scons.org
 https://pairlist2.pair.net/mailman/listinfo/scons-dev

>>>
>>> ___
>>> Scons-dev mailing list
>>> Scons-dev@scons.org
>>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>>>
>>>
>> ___
>> Scons-dev mailing list
>> Scons-dev@scons.org
>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>>
>
> ___
> Scons-dev mailing list
> Scons-dev@scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Re: [Scons-dev] Python 2 and Python 3 on same project

[Daniel Holth]

It would make sense to replace the file because it should be very unusual
to run the same SConstruct with multiple Pythons (unless you are a SCons
developer unfortunately) and because the extension should depend on the
version of the pickle protocol used, not the major version of Python.

On Thu, Jul 13, 2017, 16:09 Bill Deegan  wrote:

> The previous code (which is currently commented out), had different file
> extension for py3, so there'd be no collision.
> Though a warning that a sconsign from opposite python version is present
> might be wise.
>
>
> On Thu, Jul 13, 2017 at 3:24 PM, Daniel Holth  wrote:
>
>> Would it make more sense to present a warning and then replace the
>> .dblite file?
>>
>> On Thu, Jul 13, 2017 at 2:09 PM Bill Deegan 
>> wrote:
>>
>>> dblite.py line 43.
>>>
>>> If you uncomment that and then run the tests py2 and py3 some will break
>>> because they are  looking for the file name without the .py3 extension.
>>> Perhaps add a method or constant to QMTest/TestSCons.py which the
>>> default file name and use that in the tests which fail?
>>>
>>> -Bill
>>>
>>> On Thu, Jul 13, 2017 at 10:01 AM, Russel Winder 
>>> wrote:
>>>
 On Thu, 2017-07-13 at 09:10 -0400, Bill Deegan wrote:
 > Yes.
 >
 > There was a separate .py3 and .py2 version of sconsign.
 > Probably time to turn that back on and resolve test failures due to
 > changed
 > sconsign name.
 >
 > Care to give it a try?
 > ;)
 >

 Yes, I can do that. What change do I need to make for it to work?

 --
 Russel.

 =
 Dr Russel Winder t:+44 20 7585 2200   voip:sip:
 russel.win...@ekiga.net
 41 Buckmaster Road   m:+44 7770 465 077   xmpp:rus...@winder.org.uk
 London SW11 1EN, UK  w: www.russel.org.uk skype:russel_winder

 ___
 Scons-dev mailing list
 Scons-dev@scons.org
 https://pairlist2.pair.net/mailman/listinfo/scons-dev


>>> ___
>>> Scons-dev mailing list
>>> Scons-dev@scons.org
>>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>>>
>>
>> ___
>> Scons-dev mailing list
>> Scons-dev@scons.org
>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>>
>>
> ___
> Scons-dev mailing list
> Scons-dev@scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Re: [Scons-dev] Python 2 and Python 3 on same project

[Bill Deegan]

The previous code (which is currently commented out), had different file
extension for py3, so there'd be no collision.
Though a warning that a sconsign from opposite python version is present
might be wise.


On Thu, Jul 13, 2017 at 3:24 PM, Daniel Holth  wrote:

> Would it make more sense to present a warning and then replace the .dblite
> file?
>
> On Thu, Jul 13, 2017 at 2:09 PM Bill Deegan 
> wrote:
>
>> dblite.py line 43.
>>
>> If you uncomment that and then run the tests py2 and py3 some will break
>> because they are  looking for the file name without the .py3 extension.
>> Perhaps add a method or constant to QMTest/TestSCons.py which the default
>> file name and use that in the tests which fail?
>>
>> -Bill
>>
>> On Thu, Jul 13, 2017 at 10:01 AM, Russel Winder 
>> wrote:
>>
>>> On Thu, 2017-07-13 at 09:10 -0400, Bill Deegan wrote:
>>> > Yes.
>>> >
>>> > There was a separate .py3 and .py2 version of sconsign.
>>> > Probably time to turn that back on and resolve test failures due to
>>> > changed
>>> > sconsign name.
>>> >
>>> > Care to give it a try?
>>> > ;)
>>> >
>>>
>>> Yes, I can do that. What change do I need to make for it to work?
>>>
>>> --
>>> Russel.
>>> 
>>> =
>>> Dr Russel Winder t:+44 20 7585 2200   voip:sip:
>>> russel.win...@ekiga.net
>>> 41 Buckmaster Road   m:+44 7770 465 077   xmpp:rus...@winder.org.uk
>>> London SW11 1EN, UK  w: www.russel.org.uk skype:russel_winder
>>>
>>> ___
>>> Scons-dev mailing list
>>> Scons-dev@scons.org
>>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>>>
>>>
>> ___
>> Scons-dev mailing list
>> Scons-dev@scons.org
>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>>
>
> ___
> Scons-dev mailing list
> Scons-dev@scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Re: [Scons-dev] Python 2 and Python 3 on same project

[Daniel Holth]

Would it make more sense to present a warning and then replace the .dblite
file?

On Thu, Jul 13, 2017 at 2:09 PM Bill Deegan 
wrote:

> dblite.py line 43.
>
> If you uncomment that and then run the tests py2 and py3 some will break
> because they are  looking for the file name without the .py3 extension.
> Perhaps add a method or constant to QMTest/TestSCons.py which the default
> file name and use that in the tests which fail?
>
> -Bill
>
> On Thu, Jul 13, 2017 at 10:01 AM, Russel Winder 
> wrote:
>
>> On Thu, 2017-07-13 at 09:10 -0400, Bill Deegan wrote:
>> > Yes.
>> >
>> > There was a separate .py3 and .py2 version of sconsign.
>> > Probably time to turn that back on and resolve test failures due to
>> > changed
>> > sconsign name.
>> >
>> > Care to give it a try?
>> > ;)
>> >
>>
>> Yes, I can do that. What change do I need to make for it to work?
>>
>> --
>> Russel.
>>
>> =
>> Dr Russel Winder t:+44 20 7585 2200   voip:sip:
>> russel.win...@ekiga.net
>> 41 Buckmaster Road   m:+44 7770 465 077   xmpp:rus...@winder.org.uk
>> London SW11 1EN, UK  w: www.russel.org.uk skype:russel_winder
>>
>> ___
>> Scons-dev mailing list
>> Scons-dev@scons.org
>> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>>
>>
> ___
> Scons-dev mailing list
> Scons-dev@scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Re: [Scons-dev] Python 2 and Python 3 on same project

[Bill Deegan]

dblite.py line 43.

If you uncomment that and then run the tests py2 and py3 some will break
because they are  looking for the file name without the .py3 extension.
Perhaps add a method or constant to QMTest/TestSCons.py which the default
file name and use that in the tests which fail?

-Bill

On Thu, Jul 13, 2017 at 10:01 AM, Russel Winder 
wrote:

> On Thu, 2017-07-13 at 09:10 -0400, Bill Deegan wrote:
> > Yes.
> >
> > There was a separate .py3 and .py2 version of sconsign.
> > Probably time to turn that back on and resolve test failures due to
> > changed
> > sconsign name.
> >
> > Care to give it a try?
> > ;)
> >
>
> Yes, I can do that. What change do I need to make for it to work?
>
> --
> Russel.
> 
> =
> Dr Russel Winder t:+44 20 7585 2200   voip:sip:
> russel.win...@ekiga.net
> 41 Buckmaster Road   m:+44 7770 465 077   xmpp:rus...@winder.org.uk
> London SW11 1EN, UK  w: www.russel.org.uk skype:russel_winder
>
> ___
> Scons-dev mailing list
> Scons-dev@scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Re: [Scons-dev] Python 2 and Python 3 on same project

[Russel Winder]

On Thu, 2017-07-13 at 09:10 -0400, Bill Deegan wrote:
> Yes.
> 
> There was a separate .py3 and .py2 version of sconsign.
> Probably time to turn that back on and resolve test failures due to
> changed
> sconsign name.
> 
> Care to give it a try?
> ;)
> 

Yes, I can do that. What change do I need to make for it to work?

-- 
Russel.
=
Dr Russel Winder t:+44 20 7585 2200   voip:sip:
russel.win...@ekiga.net
41 Buckmaster Road   m:+44 7770 465 077   xmpp:rus...@winder.org.uk
London SW11 1EN, UK  w: www.russel.org.uk skype:russel_winder

signature.asc
Description: This is a digitally signed message part
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

Re: [Scons-dev] Python 2 and Python 3 on same project

[Bill Deegan]

Yes.

There was a separate .py3 and .py2 version of sconsign.
Probably time to turn that back on and resolve test failures due to changed
sconsign name.

Care to give it a try?
;)

-Bill

On Thu, Jul 13, 2017 at 4:37 AM, Russel Winder  wrote:

> I note that trying to use SCons on Python 2 with a project that has had
> SCons run on Python 3 delivers the message:
>
> ValueError : unsupported pickle protocol: 4
>
> I wonder f SCons should habdle this rather than the user realising they
> need
> to remove .sconsign.dblite and restart the build.
>
> --
> Russel.
> 
> =
> Dr Russel Winder t:+44 20 7585 2200   voip:sip:
> russel.win...@ekiga.net
> 41 Buckmaster Road   m:+44 7770 465 077   xmpp:rus...@winder.org.uk
> London SW11 1EN, UK  w: www.russel.org.uk skype:russel_winder
> ___
> Scons-dev mailing list
> Scons-dev@scons.org
> https://pairlist2.pair.net/mailman/listinfo/scons-dev
>
>
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev

[Scons-dev] Python 2 and Python 3 on same project

[Russel Winder]

I note that trying to use SCons on Python 2 with a project that has had
SCons run on Python 3 delivers the message:

ValueError : unsupported pickle protocol: 4

I wonder f SCons should habdle this rather than the user realising they need
to remove .sconsign.dblite and restart the build. 

-- 
Russel.
=
Dr Russel Winder t:+44 20 7585 2200   voip:sip:
russel.win...@ekiga.net
41 Buckmaster Road   m:+44 7770 465 077   xmpp:rus...@winder.org.uk
London SW11 1EN, UK  w: www.russel.org.uk skype:russel_winder

signature.asc
Description: This is a digitally signed message part
___
Scons-dev mailing list
Scons-dev@scons.org
https://pairlist2.pair.net/mailman/listinfo/scons-dev