Re: [Scons-dev] 2.3.3 Release issue ?
On Sat, Sep 27, 2014 at 10:36 AM, Dirk Bächle tshor...@gmx.de wrote: ... Is it too late to stop you with that? I'm currently working on the fix for #2971, and would like to get that into 2.3.4 as well if possible. Sorry, I didn't know that a v2.3.4 was planned/pending, else I would've spoken up earlier. :P No problem, I can squeeze it in. Let me know when you're ready. -- Gary ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] 2.3.3 Release issue ?
On 27.09.2014 16:41, Gary Oberbrunner wrote: On Sat, Sep 27, 2014 at 10:36 AM, Dirk Bächle tshor...@gmx.de wrote: ... Is it too late to stop you with that? I'm currently working on the fix for #2971, and would like to get that into 2.3.4 as well if possible. Sorry, I didn't know that a v2.3.4 was planned/pending, else I would've spoken up earlier. :P No problem, I can squeeze it in. Let me know when you're ready. Thanks for waiting, created PR #188. Latch on. :) Regards, Dirk ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] 2.3.3 Release issue ?
On Sun, Sep 21, 2014 at 3:10 PM, alexandre.feb...@gmail.com wrote: Hello, I see no commit and no pull request about that. Am I overlooking something, or has this been forgotten? Thanks for the reminder, Alexandre. Yes, we need to take care of this. (I was out of the country for a week.) Does anyone have a patch ready? -- Gary ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
[Scons-dev] 2.3.3 Release issue ?
Hi, Would there be a release issue with 2.3.3 ? Downloaded from http://prdownloads.sourceforge.net/scons/scons-2.3.3.tar.gz Installed by python setup.py install --prefix /usr/local --optimize 2 --symlink-scons scons --version SCons by Steven Knight et al.: script: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine path: ['/usr/local/lib/scons-2.3.3/SCons'] Copyright (c) 2001 - 2014 The SCons Foundation EnsureSConsVersion() just prints: *scons: warning: EnsureSConsVersion is ignored for development version* ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] 2.3.3 Release issue ?
I wonder why buildbots are silent about this? On Mon, Sep 8, 2014 at 8:25 PM, anatoly techtonik techto...@gmail.com wrote: On Mon, Sep 8, 2014 at 7:41 PM, Alexandre Feblot alexan...@feblot.fr wrote: Hi, Would there be a release issue with 2.3.3 ? Downloaded from http://prdownloads.sourceforge.net/scons/scons-2.3.3.tar.gz Installed by python setup.py install --prefix /usr/local --optimize 2 --symlink-scons scons --version SCons by Steven Knight et al.: script: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine path: ['/usr/local/lib/scons-2.3.3/SCons'] Copyright (c) 2001 - 2014 The SCons Foundation EnsureSConsVersion() just prints: scons: warning: EnsureSConsVersion is ignored for development version Yes. This is a bug: def EnsureSConsVersion(self, major, minor, revision=0): Exit abnormally if the SCons version is not late enough. if SCons.__version__ == '2.3.3': SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning, This should be: def EnsureSConsVersion(self, major, minor, revision=0): Exit abnormally if the SCons version is not late enough. if SCons.__version__ == '__VERSION__': SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning, The __VERSION__ of course was replaced during our build process. The quick fix is: - if SCons.__version__ == '__VERSION__': + if SCons.__version__ == '__' + 'VERSION__': -- anatoly t. ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] 2.3.3 Release issue ?
Anyway we need to wait when Gary is available to wrap a new release with this fix. Is there anybody else who can release? On Mon, Sep 8, 2014 at 8:27 PM, anatoly techtonik techto...@gmail.com wrote: I wonder why buildbots are silent about this? On Mon, Sep 8, 2014 at 8:25 PM, anatoly techtonik techto...@gmail.com wrote: On Mon, Sep 8, 2014 at 7:41 PM, Alexandre Feblot alexan...@feblot.fr wrote: Hi, Would there be a release issue with 2.3.3 ? Downloaded from http://prdownloads.sourceforge.net/scons/scons-2.3.3.tar.gz Installed by python setup.py install --prefix /usr/local --optimize 2 --symlink-scons scons --version SCons by Steven Knight et al.: script: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine path: ['/usr/local/lib/scons-2.3.3/SCons'] Copyright (c) 2001 - 2014 The SCons Foundation EnsureSConsVersion() just prints: scons: warning: EnsureSConsVersion is ignored for development version Yes. This is a bug: def EnsureSConsVersion(self, major, minor, revision=0): Exit abnormally if the SCons version is not late enough. if SCons.__version__ == '2.3.3': SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning, This should be: def EnsureSConsVersion(self, major, minor, revision=0): Exit abnormally if the SCons version is not late enough. if SCons.__version__ == '__VERSION__': SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning, The __VERSION__ of course was replaced during our build process. The quick fix is: - if SCons.__version__ == '__VERSION__': + if SCons.__version__ == '__' + 'VERSION__': -- anatoly t. -- anatoly t. ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] 2.3.3 Release issue ?
Thx for pinpointing the issue location, anyway. I fixed my own in the meantime. 2014-09-08 19:47 GMT+02:00 anatoly techtonik techto...@gmail.com: Anyway we need to wait when Gary is available to wrap a new release with this fix. Is there anybody else who can release? On Mon, Sep 8, 2014 at 8:27 PM, anatoly techtonik techto...@gmail.com wrote: I wonder why buildbots are silent about this? On Mon, Sep 8, 2014 at 8:25 PM, anatoly techtonik techto...@gmail.com wrote: On Mon, Sep 8, 2014 at 7:41 PM, Alexandre Feblot alexan...@feblot.fr wrote: Hi, Would there be a release issue with 2.3.3 ? Downloaded from http://prdownloads.sourceforge.net/scons/scons-2.3.3.tar.gz Installed by python setup.py install --prefix /usr/local --optimize 2 --symlink-scons scons --version SCons by Steven Knight et al.: script: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine: v2.3.3, 2014/08/24 12:12:31, by garyo on lubuntu engine path: ['/usr/local/lib/scons-2.3.3/SCons'] Copyright (c) 2001 - 2014 The SCons Foundation EnsureSConsVersion() just prints: scons: warning: EnsureSConsVersion is ignored for development version Yes. This is a bug: def EnsureSConsVersion(self, major, minor, revision=0): Exit abnormally if the SCons version is not late enough. if SCons.__version__ == '2.3.3': SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning, This should be: def EnsureSConsVersion(self, major, minor, revision=0): Exit abnormally if the SCons version is not late enough. if SCons.__version__ == '__VERSION__': SCons.Warnings.warn(SCons.Warnings.DevelopmentVersionWarning, The __VERSION__ of course was replaced during our build process. The quick fix is: - if SCons.__version__ == '__VERSION__': + if SCons.__version__ == '__' + 'VERSION__': -- anatoly t. -- anatoly t. ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
Re: [Scons-dev] 2.3.3 Release issue ?
Grr. Oh well. On Mon, Sep 8, 2014 at 1:47 PM, anatoly techtonik techto...@gmail.com wrote: Anyway we need to wait when Gary is available to wrap a new release with this fix. Is there anybody else who can release? I'm here, but am pretty busy at the moment. This weekend I will be away. Please start by making a pull request with the fix. On Mon, Sep 8, 2014 at 8:27 PM, anatoly techtonik techto...@gmail.com wrote: I wonder why buildbots are silent about this? Good question, if we need a new test as part of the test suite please add it to the patch. -- Gary ___ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
