Re: [SeaBIOS] [Qemu-devel] What's the impact of enlarging IDE_TIMEOUT ?

2013-06-01 Thread Kevin O'Connor
On Fri, May 31, 2013 at 03:18:56AM +, Gonglei (Arei) wrote:
IDE_TIMEOUT is defined 32s. But we encountered its timeout in
some cases, and then loading disk failed in VM.  In order to
reduce the probability of timeout, we want to enlarge the
IDE_TIMEOUT, such as 120s.  We verified this modification worked
for us. But we are wondering if this modification may cause other
potential issues.  Why set IDE_TIMEOUT to 32s? Thanks!

The ATA specification specifies the maximum response time for many
commands to be 30 seconds.  The extra 2 seconds were thrown in for
safety.

-Kevin

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] [Qemu-devel] What's the impact of enlarging IDE_TIMEOUT ?

2013-06-01 Thread Fred .
Sounds like something that should be commented in the source code.

IDE_TIMEOUT = 32; // 30 seconds per ATA specification +2 seconds thrown in
for safety


On Sat, Jun 1, 2013 at 3:21 PM, Kevin O'Connor ke...@koconnor.net wrote:

 On Fri, May 31, 2013 at 03:18:56AM +, Gonglei (Arei) wrote:
 IDE_TIMEOUT is defined 32s. But we encountered its timeout in
 some cases, and then loading disk failed in VM.  In order to
 reduce the probability of timeout, we want to enlarge the
 IDE_TIMEOUT, such as 120s.  We verified this modification worked
 for us. But we are wondering if this modification may cause other
 potential issues.  Why set IDE_TIMEOUT to 32s? Thanks!

 The ATA specification specifies the maximum response time for many
 commands to be 30 seconds.  The extra 2 seconds were thrown in for
 safety.

 -Kevin

 ___
 SeaBIOS mailing list
 SeaBIOS@seabios.org
 http://www.seabios.org/mailman/listinfo/seabios

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] [PATCH] Seabios: allow mapping of multiple PCI option ROMs to one

2013-06-01 Thread Dave Frodin


- Original Message -
 From: Kevin O'Connor ke...@koconnor.net
 To: Dave Frodin dave.fro...@se-eng.com
 Cc: seabios seabios@seabios.org
 Sent: Friday, May 31, 2013 9:18:21 PM
 Subject: Re: [SeaBIOS] [PATCH] Seabios: allow mapping of multiple PCI option 
 ROMs to one
 
 On Fri, May 31, 2013 at 08:32:16AM -0500, Dave Frodin wrote:
  I see now, that's pretty slick. The problem I see with that approach is
  that coreboot would need to add all of these files for a family14
  mainboard.
 [...]
  And all of these files for a family15 mainboard
 [...]
  
  Since at build time we only know what cpu family the rom is being
  built for and not (necessarily) what the exact graphics ID is.
  
  The method I proposed would have one family specific vendev-map.bin file.
 
 Yes, but it would be quite difficult to inspect vendev-map.bin.  I
 think an ascii interface is preferable.
 
 One could go a level up and make a symbolic link type in cbfs (this
 is effectively what my patch did).  The advantage would be that
 cbfstool could display it in a nicer format.
 
 -Kevin

I agree with that, and marc made the same suggestion. I'll put together a
new patch next week.

Dave

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] [Qemu-devel] What's the impact of enlarging IDE_TIMEOUT ?

2013-06-01 Thread Peter Stuge
Fred . wrote:
 Sounds like something that should be commented in the source code.

Sounds like something that even you could send a patch for.


//Peter

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios