[SeaBIOS] Re: [PATCH 0/2] Fix reset issue with QEMU -machine q35

2022-03-25 Thread Gerd Hoffmann
On Sun, Mar 20, 2022 at 10:45:00AM +0100, Volker Rümelin wrote:
> This reset issue was reported on the QEMU issue tracker at
> https://gitlab.com/qemu-project/qemu/-/issues/766
> 
> A reset with QEMU -machine q35 -accel tcg leads to a reset loop
> and with -machine q35 -accel kvm the reset only works because
> KVM ignores the read-only semantics of the C-F segments.
> 
> Details about the issue are in "reset: force standard PCI
> configuration access".
> 
> Volker Rümelin (2):
>   pci: refactor the pci_config_*() functions
>   reset: force standard PCI configuration access

Series looks good to me.

Reviewed-by: Gerd Hoffmann 

take care,
  Gerd

___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org


[SeaBIOS] [PATCH 1/1] sercon: do not screwup the xterm on the serial console

2022-03-25 Thread Daniel Maslowski via SeaBIOS
From: Trammell Hudson 

---
 src/sercon.c | 21 -
 1 file changed, 21 deletions(-)

diff --git a/src/sercon.c b/src/sercon.c
index 3019d9b4..a65c51e1 100644
--- a/src/sercon.c
+++ b/src/sercon.c
@@ -99,12 +99,6 @@ static void sercon_putchar(u8 chr)
 }
 }
 
-static void sercon_term_reset(void)
-{
-sercon_putchar('\x1b');
-sercon_putchar('c');
-}
-
 static void sercon_term_clear_screen(void)
 {
 sercon_putchar('\x1b');
@@ -113,15 +107,6 @@ static void sercon_term_clear_screen(void)
 sercon_putchar('J');
 }
 
-static void sercon_term_no_linewrap(void)
-{
-sercon_putchar('\x1b');
-sercon_putchar('[');
-sercon_putchar('?');
-sercon_putchar('7');
-sercon_putchar('l');
-}
-
 static void sercon_term_cursor_goto(u8 row, u8 col)
 {
 row++; col++;
@@ -308,7 +293,6 @@ static void sercon_lazy_putchar(u8 chr, u8 attr, u8 
teletype)
 /* Set video mode */
 static void sercon_1000(struct bregs *regs)
 {
-u8 clearscreen = !(regs->al & 0x80);
 u8 mode = regs->al & 0x7f;
 u8 rows, cols;
 
@@ -345,11 +329,6 @@ static void sercon_1000(struct bregs *regs)
 SET_LOW(sercon_col_last, 0);
 SET_LOW(sercon_row_last, 0);
 SET_LOW(sercon_attr_last, 0);
-
-sercon_term_reset();
-sercon_term_no_linewrap();
-if (clearscreen)
-sercon_term_clear_screen();
 }
 
 /* Set text-mode cursor shape */
-- 
2.32.0

___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org