Re: [SeaBIOS] [Qemu-devel] What's the impact of enlarging IDE_TIMEOUT ?

2013-06-01 Thread Kevin O'Connor
On Fri, May 31, 2013 at 03:18:56AM +, Gonglei (Arei) wrote:
IDE_TIMEOUT is defined 32s. But we encountered its timeout in
some cases, and then loading disk failed in VM.  In order to
reduce the probability of timeout, we want to enlarge the
IDE_TIMEOUT, such as 120s.  We verified this modification worked
for us. But we are wondering if this modification may cause other
potential issues.  Why set IDE_TIMEOUT to 32s? Thanks!

The ATA specification specifies the maximum response time for many
commands to be 30 seconds.  The extra 2 seconds were thrown in for
safety.

-Kevin

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] [Qemu-devel] What's the impact of enlarging IDE_TIMEOUT ?

2013-06-01 Thread Fred .
Sounds like something that should be commented in the source code.

IDE_TIMEOUT = 32; // 30 seconds per ATA specification +2 seconds thrown in
for safety


On Sat, Jun 1, 2013 at 3:21 PM, Kevin O'Connor ke...@koconnor.net wrote:

 On Fri, May 31, 2013 at 03:18:56AM +, Gonglei (Arei) wrote:
 IDE_TIMEOUT is defined 32s. But we encountered its timeout in
 some cases, and then loading disk failed in VM.  In order to
 reduce the probability of timeout, we want to enlarge the
 IDE_TIMEOUT, such as 120s.  We verified this modification worked
 for us. But we are wondering if this modification may cause other
 potential issues.  Why set IDE_TIMEOUT to 32s? Thanks!

 The ATA specification specifies the maximum response time for many
 commands to be 30 seconds.  The extra 2 seconds were thrown in for
 safety.

 -Kevin

 ___
 SeaBIOS mailing list
 SeaBIOS@seabios.org
 http://www.seabios.org/mailman/listinfo/seabios

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios


Re: [SeaBIOS] [Qemu-devel] What's the impact of enlarging IDE_TIMEOUT ?

2013-06-01 Thread Peter Stuge
Fred . wrote:
 Sounds like something that should be commented in the source code.

Sounds like something that even you could send a patch for.


//Peter

___
SeaBIOS mailing list
SeaBIOS@seabios.org
http://www.seabios.org/mailman/listinfo/seabios