[SeaBIOS] Re: [PATCH v2] optionrom: disallow int19 redirect for pnp roms.
On Mon, May 20, 2019 at 05:40:16PM -0500, Matt DeVillier wrote:
> On Mon, May 20, 2019 at 4:49 PM Kevin O'Connor wrote:
>
> > On Mon, May 20, 2019 at 04:43:08PM -0500, Matt DeVillier wrote:
> > > v2 of the patch works as intended, once 'current.offset !=
> > current.offset'
> > > is corrected to 'current.offset != seabios.offset'
> >
> > FWIW, that code could simply be:
> >
> > static int boot_irq_captured(void)
> > {
> > return GET_IVT(0x19).segoff != FUNC16(entry_19_official).segoff;
> > }
> >
>
> yes, that seems to work as well :)
Thanks for testing. Sent fixed v3.
cheers,
Gerd
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
[SeaBIOS] Re: [PATCH v2] optionrom: disallow int19 redirect for pnp roms.
On Mon, May 20, 2019 at 4:49 PM Kevin O'Connor wrote:
> On Mon, May 20, 2019 at 04:43:08PM -0500, Matt DeVillier wrote:
> > v2 of the patch works as intended, once 'current.offset !=
> current.offset'
> > is corrected to 'current.offset != seabios.offset'
>
> FWIW, that code could simply be:
>
> static int boot_irq_captured(void)
> {
> return GET_IVT(0x19).segoff != FUNC16(entry_19_official).segoff;
> }
>
yes, that seems to work as well :)
>
> -Kevin
>
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
[SeaBIOS] Re: [PATCH v2] optionrom: disallow int19 redirect for pnp roms.
On Mon, May 20, 2019 at 04:43:08PM -0500, Matt DeVillier wrote:
> v2 of the patch works as intended, once 'current.offset != current.offset'
> is corrected to 'current.offset != seabios.offset'
FWIW, that code could simply be:
static int boot_irq_captured(void)
{
return GET_IVT(0x19).segoff != FUNC16(entry_19_official).segoff;
}
-Kevin
___
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org
[SeaBIOS] Re: [PATCH v2] optionrom: disallow int19 redirect for pnp roms.
v2 of the patch works as intended, once 'current.offset != current.offset' is corrected to 'current.offset != seabios.offset' cheers, Matt On Tue, Dec 11, 2018 at 2:03 AM Gerd Hoffmann wrote: > On Mon, Dec 10, 2018 at 09:53:01PM -0500, Kevin O'Connor wrote: > > On Thu, Dec 06, 2018 at 04:07:40PM +0100, Gerd Hoffmann wrote: > > > Check whenever pnp roms attempt to redirect int19, and in case it does > > > log a message and undo the redirect. > > > > > > A pnp rom should not need this, we have BEVs and BCVs for that. > > > Nevertheless there are roms in the wild which are redirecting int19. > > > At least some BIOS implementations for physical hardware have a config > > > option in the setup to allow/disallow int19 redirections, so just not > > > allowing this seems to be the way to deal with this situation. > > > > Thanks. As discussed, I'm okay with this change. > > ok. I'll wait for test results before committing. > > cheers, > Gerd > > > ___ > SeaBIOS mailing list > SeaBIOS@seabios.org > https://mail.coreboot.org/mailman/listinfo/seabios > ___ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-le...@seabios.org
