[security-dev 01101]: hg: jdk7/tl/jdk: 3 new changesets

2009-08-20 Thread alan . bateman 
Changeset: dfece53c600f
Author:alanb
Date:  2009-08-20 08:39 +0100
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dfece53c600f

6595866: File does work with symbolic links (win,vista)
Reviewed-by: sherman

! src/windows/native/java/io/WinNTFileSystem_md.c
+ test/java/io/File/SymLinks.java

Changeset: 70c03e494a68
Author:alanb
Date:  2009-08-20 08:42 +0100
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/70c03e494a68

6870926: (file) Path.toRealPath performance can be improved (win)
Reviewed-by: sherman

! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java
! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java
! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java
! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c

Changeset: 5cd12b68d09b
Author:alanb
Date:  2009-08-20 08:48 +0100
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5cd12b68d09b

6866804: (file) Path calls checkPermission insteadof checkXXX (sol)
Reviewed-by: sherman

! src/solaris/classes/sun/nio/fs/UnixPath.java
! src/windows/classes/sun/nio/fs/WindowsFileAttributeViews.java
+ test/java/nio/file/Path/CheckPermissions.java
! test/java/nio/file/Path/Misc.java

[security-dev 01102]: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be. (also reviewed by ksaks, ryano)

2009-08-20 Thread lance . andersen 
Changeset: 4ec7d1890538
Author:lancea
Date:  2009-08-20 19:21 -0400
URL:   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ec7d1890538

6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make 
constants final that needed to be. (also reviewed by ksaks, ryano)
Reviewed-by: valeriep

+ src/share/classes/com/sun/rowset/RowSetFactoryImpl.java
! src/share/classes/javax/sql/rowset/CachedRowSet.java
+ src/share/classes/javax/sql/rowset/RowSetFactory.java
! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
! src/share/classes/javax/sql/rowset/spi/SyncProvider.java

[security-dev 01104]: So many Cloneables in krb5

2009-08-20 Thread Max (Weijun) Wang 

Hi Valerie

I take a look at krb5 codes and find many classes Cloneable.

These 6 can be easily changed to immutable:

  Realm.java
  AuthorizationData.java
  AuthorizationDataEntry.java
  HostAddress.java
  HostAddresses.java
  Ticket.java

This one has internal states, but I see no one clone it:
  crc32.java

This one has setMicroSeconds(), probably should be pulled out (and  
then made immutable):

  KerberosTime.java

This one has setSalt() and setRealm(), keep it unchanged:
  PrincipalName.java

These two have secrets inside to destroy(), keep it unchanged:
  EncryptedData.java
  EncryptionKey.java

I plan to change the first 7 ones to final immutable first.

Any suggestions?

Thanks
Max