hg: jdk8/tl/langtools: 7196462: JavacProcessingEnvironment should tolerate BasicJavacTask

2012-09-24 Thread jonathan . gibbons 
Changeset: 8987971bcb45
Author:jjg
Date:  2012-09-24 14:04 -0700
URL:   http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8987971bcb45

7196462: JavacProcessingEnvironment should tolerate BasicJavacTask
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java
! 
src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
+ test/tools/javac/processing/T7196462.java

Re: Code review request, 7200295 CertificateRequest message is wrapping when using large numbers of Certs

2012-09-24 Thread Brad Wetmore 

Are there situations where we might overflow the int?

For example, in CertificateRequest.messageLength()

for (int i = 0; i  authorities.length; i++) {
len += authorities[i].length();
}

What if len overflows?

Also, all of these field's callers are overflow-1?

Brad




On 9/23/2012 7:42 PM, Xuelei Fan wrote:

Hi,

Please review the update to check output filed length overflow in TLS
handshaking.

bug   : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7200295
webrev: http://cr.openjdk.java.net/~xuelei/7200295/webrev.00/

The cause of the bug is that for 8, 16, 24 bits length-variable fields,
before put the bytes into the fields, we do not check that the length of
the bytes is less than the capabilities of the field.

Thanks,
Xuelei

Code review request: 7200682: TEST_BUG: keytool/autotest.sh still has problems with libsoftokn.so

2012-09-24 Thread Weijun Wang 

Hi Stuart

Please take a look at

   http://cr.openjdk.java.net/~weijun/7200682/webrev.00/

So I am now using java -XshowSettings:properties | grep os.arch to 
find out the arch. Not sure if there is a more formal way to do that.


I've added core-libs-dev to CC hoping more people have their opinions.

Thanks
Max


On 09/25/2012 09:47 AM, Stuart Marks wrote:

 Original Message 
*Change Request ID*: 7200682

*Synopsis*: TEST_BUG: keytool/autotest.sh still has problems with
libsoftokn.so

   Product: java
   Category: java
   Subcategory: classes_security

=== *Description*

I got a test failure in JPRT from sun/security/tools/keytool/autotest.sh.

The proximate cause of the failure is that the wrong libsoftokn3.so is
found:

java.io.IOException: /usr/lib/x86_64-linux-gnu/nss/libsoftokn3.so: wrong
ELF class: ELFCLASS64/usr/lib/x86_64-linux-gnu/nss/libsoftokn3.so

But note, this is a test run of the linux_i586-product-c2-jdk_security3
test target. This is a 32-bit test execution, I believe, and so the
library that needs to be loaded is
/usr/lib/i386-linux-gnu/nss/libsoftokn3.so (as opposed to the x86_64
version).

This seems to vary from system to system. The failure occurred on
sc11137361.us.oracle.com, which is on of these new Ubuntu 12.04 dual
architecture systems. The test passes on sc11137355.us.oracle.com, a
Fedora 9 system.

The has some logic to detect the architecture (bitness) of the system
and select the right library, but it needs to determine the arch/bitness
of the *JVM running the tests* not the system itself. (I think.)

I'll attach the JPRT failure log for complete context.