Re: 8165103: Update to "denyAfter constraint check" exception message

2016-10-06 Thread Valerie Peng 


I know it's intentional, however I doubt how much difference this makes. 
Code duplication is kind of error prone.

Just my preference,
Valerie

On 10/5/2016 8:29 PM, Anthony Scarpino wrote:
This is intentional as an optimization. Setting the String is only 
needed in the failure case, so I separated them to optimize the 
success case.  That's why I have the comment there.


Tony

On 10/05/2016 04:58 PM, Valerie Peng wrote:


Instead of duplicating the if-check block, how about just add another
String variable "dateType" and assign value to it in the first if-check
block?
Rest looks fine.
Valerie

On 10/5/2016 1:20 PM, Anthony Scarpino wrote:

Hi,

I'd like a review of this change away from a generic error messages in
the denyAfter constraint.  The message better specify which date was
checked against the constraint now. Testing is handled elsewhere.

http://cr.openjdk.java.net/~ascarpino/8165103/webrev/

Tony

Re: RFR 8167181: Exported elements referring to inaccessible types in jdk.security.jgss

2016-10-06 Thread Mandy Chung 

> On Oct 6, 2016, at 9:55 AM, Wang Weijun  wrote:
> 
> Please review the code change for jdk9/dev/jdk repo at
> 
>   http://cr.openjdk.java.net/~weijun/8167181/webrev.00


This looks good to me.  

Thanks
Mandy

RFR 8167181: Exported elements referring to inaccessible types in jdk.security.jgss

2016-10-06 Thread Wang Weijun 

Please review the code change for jdk9/dev/jdk repo at

   http://cr.openjdk.java.net/~weijun/8167181/webrev.00

and for jdk9/dev which is simply

diff --git a/make/CompileJavaModules.gmk b/make/CompileJavaModules.gmk
--- a/make/CompileJavaModules.gmk
+++ b/make/CompileJavaModules.gmk
@@ -452,10 +452,6 @@




-jdk.security.jgss_ADD_JAVAC_FLAGS := -Xlint:-exports
-
-
-
 jdk.vm.ci_ADD_JAVAC_FLAGS := -Xlint:-exports




After the change the *Impl classes disappeared from javadoc [1]. I wish 
I had noticed them before.


Thanks
Max

[1] 
http://download.java.net/java/jdk9/docs/jre/api/security/jgss/spec/com/sun/security/jgss/package-summary.html