[9] RFR: JDK-8170245 [TEST_BUG] Cipher tests fail when running with unlimited policy

[Valerie Peng]

Anyone has cycles to review this fix?
Some cipher tests fail when running against unlimited crypto policy due 
to hardcoded checks and values.


Changes are straight-forward. However, given the dependency between the 
tests (as they are ported from SQE tests in the previous co-location 
effort), I mostly just made the minimum changes needed for the test to 
work when unlimited crypto policy is in use.


Webrev: http://cr.openjdk.java.net/~valeriep/8170245/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8170245

Thanks,
Valerie

Re: Code Review Request JDK-8170329 New SSLSocket testing template

[Sean Mullan]

On 11/27/16 7:43 AM, Xuelei Fan wrote:

On 11/27/2016 6:04 PM, Wang Weijun wrote:

This is not only a test update.


No, I happened to find an implementation issue with the new test, so fix
it altogether.  The issue is that the simple validator
(SimpleValidator.java) does not support SKID/AKID during cert path
build.  If two trusted certs has the same subject,  the simple validator
may not be able to find the right one.


We have had issues in the PKIX CertPathBuilder with matching on 
AKID/SKID when building certpaths, so we want to be careful not to 
introduce a similar issue. See this bug for more information:


https://bugs.openjdk.java.net/browse/JDK-8072463

I have not reviewed the fix enough to know if this issue applies here 
but please double-check it.


--Sean



Thanks,
Xuelei


On Nov 27, 2016, at 9:35 AM, Xuelei Fan  wrote:

Hi,

Please review this test update:

  http://cr.openjdk.java.net/~xuelei/8170329/webrev.00/

The new template (SSLSocketTemplate.java) could be used to avoid the
anti-free-port issues.  By using sub-classes of it, the new one can
simplify the general SSLSocket test code significantly.

Thanks,
Xuelei

Re: [8u-dev] RFR 8170278 : ticket renewal won't happen with debugging turned on

[Wang Weijun]

+1

--Max

> On Nov 29, 2016, at 5:16 PM, Seán Coffey  wrote:
> 
> Looks good.
> 
> regards,
> Sean.
> 
> 
> On 29/11/2016 09:08, Ivan Gerasimov wrote:
>> Hello!
>> 
>> It was reported that there's broken behavior exposed when the debug mode is 
>> turned on, which is due to KerberosTicket.toString() throwing an exception, 
>> if the ticket was already destroyed.
>> 
>> The proposed fix is in fact the backport of a tiny portion of JDK-8043071.
>> 
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8170278
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8170278/00/webrev/
>> 
>> Would you please help review?
>> 
>> With kind regards,
>> Ivan
> 

Re: [8u-dev] RFR 8170278 : ticket renewal won't happen with debugging turned on

[Seán Coffey]

Looks good.

regards,
Sean.


On 29/11/2016 09:08, Ivan Gerasimov wrote:

Hello!

It was reported that there's broken behavior exposed when the debug 
mode is turned on, which is due to KerberosTicket.toString() throwing 
an exception, if the ticket was already destroyed.


The proposed fix is in fact the backport of a tiny portion of 
JDK-8043071.


BUGURL: https://bugs.openjdk.java.net/browse/JDK-8170278
WEBREV: http://cr.openjdk.java.net/~igerasim/8170278/00/webrev/

Would you please help review?

With kind regards,
Ivan

[8u-dev] RFR 8170278 : ticket renewal won't happen with debugging turned on

[Ivan Gerasimov]

Hello!

It was reported that there's broken behavior exposed when the debug mode 
is turned on, which is due to KerberosTicket.toString() throwing an 
exception, if the ticket was already destroyed.


The proposed fix is in fact the backport of a tiny portion of JDK-8043071.

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8170278
WEBREV: http://cr.openjdk.java.net/~igerasim/8170278/00/webrev/

Would you please help review?

With kind regards,
Ivan