Re: RFR 8170900: Issue with FilePermission::implies for wildcard flag(-)

[Wang Weijun]

Ping again.

> On Dec 14, 2016, at 1:53 PM, Wang Weijun  wrote:
> 
> An clarification is added to FilePermission::implies:
> 
>  * @implNote
>
>  * a simple {@code npath} is recursively inside a wildcard {@code npath}
>  * if and only if {@code simple_npath.relativize(wildcard_npath)}
> - * is a series of one or more "..". An invalid {@code FilePermission} 
> does
> + * is a series of one or more "..". Note that this means "/-" does not
> + * imply "foo". An invalid {@code FilePermission} does
>  * not imply any object except for itself.
> 
> The newly added sentence is
> 
>  Note that this means "/-" does not imply "foo".
> 
> JCK has agreed to update their test.
> 
> Since this is just a clarification inside an @implNote and no spec is 
> updated, I suppose no CCC is needed. Please confirm.
> 
> Thanks
> Max
> 

Re: Code Review Request, JDK-8171337 Check for correct SSLEngineImpl/SSLSocketImpl.setSSLParameters handshaker update method

[Xuelei Fan]

On 12/19/2016 12:20 PM, Bradford Wetmore wrote:

For SSLSocket, there are other .started() methods with similar
conditions, should those be changed as well?

The one in SSLSocketImpl is used to get the handshake application 
protocol (getHandshakeApplicationProtocol, line 2661-2664), better to 
use started() for the accuracy value for "handshake".


Thanks,
Xuelei


Thanks,

Brad


On 12/16/2016 11:03 AM, Xuelei Fan wrote:

Hi Brad,

Please review this handshake update method miss-use fix:

   http://cr.openjdk.java.net/~xuelei/8171337/webrev.00/

The activation process of handshake may consider the parameters in a big
picture and make adjustment accordingly.  Basically, SSL parameters
should be configured before the handshake activated.

Thanks,
Xuelei

Re: Code Review Request, JDK-8171337 Check for correct SSLEngineImpl/SSLSocketImpl.setSSLParameters handshaker update method

[Bradford Wetmore]

For SSLSocket, there are other .started() methods with similar 
conditions, should those be changed as well?


Thanks,

Brad


On 12/16/2016 11:03 AM, Xuelei Fan wrote:

Hi Brad,

Please review this handshake update method miss-use fix:

   http://cr.openjdk.java.net/~xuelei/8171337/webrev.00/

The activation process of handshake may consider the parameters in a big
picture and make adjustment accordingly.  Basically, SSL parameters
should be configured before the handshake activated.

Thanks,
Xuelei